[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #91 from David Cook --- (In reply to Jonathan Druart from comment #90) > (In reply to David Cook from comment #89) > > What's outstanding on this one? > > Read the commit messages. I did and I couldn't make sense of them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #90 from Jonathan Druart --- (In reply to David Cook from comment #89) > What's outstanding on this one? Read the commit messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34089] Batch item deletion doesn't give details about why something is not deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34089 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34089] Batch item deletion doesn't give details about why something is not deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34089 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34089] New: Batch item deletion doesn't give details about why something is not deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34089 Bug ID: 34089 Summary: Batch item deletion doesn't give details about why something is not deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikap...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1) Check out an item 2) Take note of the barcode of the checked out item 3) Go to the "Batch item deletion" module which is now in Cataloging 4) Attempt to delete the item that you checked out 5) Go to the "View detail of the enqueued job" link 6) Notice that no items were deleted, but there are no details as to why -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #2 from David Cook --- This isn't quite ready for NSO, as it needs to be polished, but I need to switch tasks right now, and I didn't want to forget to raise the ticket. This works very well. It takes about .06 seconds to run koha-upgrade-schema instead of 1.1 seconds. If you multiply that by 60, that is 3.6 seconds instead of 66 seconds. Huge difference! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 --- Comment #1 from David Cook --- Created attachment 152543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152543&action=edit Bug 34088: Short circuit database upgrade check If the database version and the code version are the same, we should short circuit and exit immediately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34088] New: Schema upgrade should short circuit faster if no upgrade needs to be done
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 Bug ID: 34088 Summary: Schema upgrade should short circuit faster if no upgrade needs to be done Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org At the moment, if there is no database upgrade to run, updatedatabase.pl can take over 1.1 seconds to run. If you chain together 60 runs of updatedatabase.pl via koha-upgrade-schema and "apt-get install koha-common", that takes well over 1 minute at best to check that nothing needs to be done. (In practice, I think it goes over 1 minute.) We should be short circuiting earlier because we have the code version at hand and it's easy to check the database version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #89 from David Cook --- What's outstanding on this one? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #88 from David Cook --- (In reply to Jonathan Druart from comment #80) > Created attachment 150927 [details] [review] > Bug 17427: Embed Data::Session > > Test plan: > Install libdata-session-perl and make sure our lib has priority > over the installed version An alternative could be to contribute Data::Session::Serialize::yamlxs. Ron seems pretty responsive on Github, and it looks like Mason has contributed a couple patches in Feb 2023. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #24 from Agustín Moyano --- (In reply to Jonathan Druart from comment #19) > (In reply to Tomás Cohen Arazi from comment #18) > > Not changing the status as I aint no Vue expert. But I tested things work > > and no warnings/errors in the console. > > > > The only thing I don't like but is not this patch responsibility, is the > > fact we display 'Show Thing' in the breadcrumb... I think we should be more > > consistent (we are not 100% consistent on this, I know but...). > > > > Right now we display > > > > Home > E-resource management > Licenses > Show license > > > > it should be: > > > > Home > E-resource management > Licenses > A licence name > > > > like we have in other places e.g > > > > Home > Tools > Patron lists > A list name > > > > I mention this in case it fits this change. > > It is something I didn't manage to do with the current code (I thought there > was actually a FIXME in the code but there is none). Maybe later I can add a method to the navigation store to be able to update the last part of the breadcrumb I'll create a new bug for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34087] New: Required label displays twice for Hold end date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34087 Bug ID: 34087 Summary: Required label displays twice for Hold end date Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: d...@interleaf.ie QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The 'Required' label displays twice under 'Hold not needed after' when confirming a hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #23 from Agustín Moyano --- (In reply to Tomás Cohen Arazi from comment #22) > Created attachment 152541 [details] [review] > Bug 33169: (QA follow-up) Tidy Vue-related files > > Signed-off-by: Tomas Cohen Arazi Thanks Tom for the follow-ups, I'll mark this as PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34059] advance_notices.pl -c --digest-per-branch does not work as intended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34059 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34072] Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34072] Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 ByWater Sandboxes changed: What|Removed |Added Attachment #152495|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 152542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152542&action=edit Bug 34072: Remove float/clear from froms.scss To test: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions - Apply patch, regerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ), clear browser cache - Try again, you should now see the search controls - Since this patch changes forms.scss try some other forms in Koha at different screen sizes to make sure they still look correct Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32025] Adding in a column for "checked in by' in patron's circulation history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32025 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 152541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152541&action=edit Bug 33169: (QA follow-up) Tidy Vue-related files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 152540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152540&action=edit Bug 33169: Add support for FA styles Font awesome now provides a different approach to icon styles so you can specify things like: ``` ``` but also ``` ``` The original implementation had a hardcoded `fa` and having an extra parameter for the *style* seemed overkill, as we would need to handle even a list of styles like on this example: ``` ``` So I chose to just explicitly require the full FA icon class and pass it thru. With no manipulation on the Vue side. This patch does that, and adjusts the 'style' for some icons, as introduced by the FA v6 patchset. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Tomás Cohen Arazi changed: What|Removed |Added Attachment #152068|0 |1 is obsolete|| --- Comment #20 from Tomás Cohen Arazi --- Created attachment 152539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152539&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34086] On detail.tt if item.permanent_location is NULL no shelving location will show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086 --- Comment #1 from Lucas Gass --- Created attachment 152538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152538&action=edit Bug 34086: Show location on detail page when there is no permenant location To test: 1. Have some items without a permanent location. 2. Go to the staff detail page. 3. In the 'Home library' column notice the span .shelvingloc is empty. 4. Add a permanent location, now the shelvingloc is populated 5. Apply patch 6. The location should now show even when there is no permenant location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34086] On detail.tt if item.permanent_location is NULL no shelving location will show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34086] New: On detail.tt if item.permanent_location is NULL no shelving location will show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086 Bug ID: 34086 Summary: On detail.tt if item.permanent_location is NULL no shelving location will show Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1. Have some items without a permanent location. 2. Go to the staff detail page. 3. In the 'Home library' column notice the span .shelvingloc is empty. 4. Add a permanent location, now the shelvingloc is populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22548] Z39.50/SRU search replaces existing biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22548 Noémie Labine changed: What|Removed |Added CC||noemie.lab...@collecto.ca --- Comment #3 from Noémie Labine --- We encountered this situation with 22.05.07.000 Clicking on the z39.50 search button while on a results page causes the replacement of the last biblio record of the page by the imported biblio record, as described by Rudolf in 2019. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22548] Z39.50/SRU search replaces existing biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22548 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34071] Change the phrasing of 'automatic checkin' to fit consistent terminology
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34071 --- Comment #1 from Sam Lau --- Created attachment 152537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152537&action=edit Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology This patch simply changes 'Automatic checkin' to be 'Automatic check-in'. Test plan: 1) Go to administration -> item types and click the edit button on an item. 2) Notice there is a checkbox labeled 'Automatic checkin'. 3) Apply patch. 4) Refresh the page and notice the checkbox now says 'Automatic check-in'. 5) prove t/db_dependent/Koha/Checkouts.t 6) Sign-off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34071] Change the phrasing of 'automatic checkin' to fit consistent terminology
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34071 Sam Lau changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34085] Remove the use of event attributes from basket groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 --- Comment #1 from Owen Leonard --- Created attachment 152536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152536&action=edit Bug 34085: Remove the use of event attributes from basket groups template This patch removes the use of event attributes (onclick, onsubmit) from the basket groups template. These events are defined now along with the other in-page JS. This change allows us to move the scripts to the bottom of the page. Unrelated changes: There was no confirmation tied to the process of deleting a basket group. I've added one. And there were several "MSG_" variables defined which were unused and have been removed. To test you should have at least one vendor with at least one basket group. - Apply the patch and go to Acquisitions. - Locate a vendor with an associated basket group. - Edit a basketgroup - Confirm that editing works correctly (leaving "Close basket group" unchecked") - Confirm that editing works correctly with "Close basket group" checked. - In the list of closed basket groups, confirm that all the controls work correctly. - Create an empty basket group and confirm that clicking the associated "Delete" button in the list of basket groups triggers a confirmation, "Are you sure you want to delete this basket group?" Test that both confirming and cancelling work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34085] Remove the use of event attributes from basket groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Sam Lau changed: What|Removed |Added Attachment #152516|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152535&action=edit Bug 34032: Set new expirationdate if waiting status is reverted When one reverts holds waiting status holds expiration date is not set even if DefaultHoldExpirationdate syspref is enabled. This patch adds new param hold_reverted to be used when RevertWaitingStatus is used to determine if expiration date should be set again. To test: 1) Make sure you have DefaultHoldExpirationdate syspref enabled. 2) Find hold with status "Waiting". 3) Revert waiting status. => Note that hold has no expiration date set. 4) Apply this patch. 5) Repeat steps 2 and 3. => Expiration date should now be set based on reserve date. Also prove t/db_dependent/Hold.t. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17858] [OMNIBUS] Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What|Removed |Added Depends on||34085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 [Bug 34085] Remove the use of event attributes from basket groups template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34085] New: Remove the use of event attributes from basket groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 Bug ID: 34085 Summary: Remove the use of event attributes from basket groups template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 17858 There are some event attributes in the basket groups template. These should be removed in favor of defining events in JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] [OMNIBUS] Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Sam Lau changed: What|Removed |Added Attachment #152532|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152534&action=edit Bug 34083: Add searching for full term on patron auto-complete To reproduce, on k-t-d: 1) Create a new patron of category 'School' 2) Enter 'Middle school high school' on the mandatory 'Name' field and put something in 'Card number:' 3) Visit patron lists at /cgi-bin/koha/patron_lists/lists.pl and click 'New patron list' 4) Put something in 'Name:' and click 'Save' 5) On the 'Patron search' input, enter 'middle school high school' slowly and observe the auto-complete behaviour 6) Notice how after you start typing the second word, the auto complete results vanish. 7) Apply patch, repeat plan and verify it now works as expected. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20373] Add floating toolbar on new acqui/basketgroups.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20373 Owen Leonard changed: What|Removed |Added Status|NEW |BLOCKED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25295] Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #5 from Rebecca Coert --- I agree with Andrew - having a more stable option for this would be ideal. We use our branch "color coding" (different menu bar colors @ each location) as a visual reminder for staff who move between locations. It's a simple yet effective way to cut down on errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34084] New: Shipment Budget ID does not default to a blank option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34084 Bug ID: 34084 Summary: Shipment Budget ID does not default to a blank option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Currently, the dropdown selector, "shipment_budget_id" under invoices defaults to the first budget in the list. It should default to a blank string or something that says "Please make a selection" so that partners do not accidentally use the wrong budget. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34081] Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34081 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34081] Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34081 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 152533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152533&action=edit Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses To test: 1. Apply patch 2. Install language ./misc/translator/translate install xx-XX 3. Update po files ./misc/translator/translate update xx-XX 4. View the xx-XX-messages.po file --> Strings for tag statuses for one tag should be separated from strings for statuses for multiple tags, with context Tags (single) or Tags (multiple) 5. Change the strings so you know which is which For example, in French, the approved status for a single tag would be "Approuvé" and for multiple tags would be "Approuvés" (with the plural s at the end) 6. Apply translations ./misc/translator/translate install xx-XX 7. Add tags through the OPAC 7.1. In another tab, go to the OPAC 7.2. Log in 7.3. Search for a record 7.4. From the detailed record, click Add tags 7.5. Enter a tag and click Add 8. In the staff interface, go to Tools > Tags 9. Approve/Reject the tag --> The status in the table and on the button should be the singular status, the status in the summary on the right should be plural -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34081] Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34081 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34051] Koha::AuthorisedValues->get_description_by_koha_field not caching results for non-existent values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34051 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34051] Koha::AuthorisedValues->get_description_by_koha_field not caching results for non-existent values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34051 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34033] DB update problems from bug 30649
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34033 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34033] DB update problems from bug 30649
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34033 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33820] Add hints to warn the librarian that they will be logged out if they change their username
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33029] Add wrapper method for dt_from_string to KohaDates template toolkit plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33029 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- Love this, but can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 --- Comment #1 from Pedro Amorim --- Created attachment 152532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152532&action=edit Bug 34083: Add searching for full term on patron auto-complete To reproduce, on k-t-d: 1) Create a new patron of category 'School' 2) Enter 'Middle school high school' on the mandatory 'Name' field and put something in 'Card number:' 3) Visit patron lists at /cgi-bin/koha/patron_lists/lists.pl and click 'New patron list' 4) Put something in 'Name:' and click 'Save' 5) On the 'Patron search' input, enter 'middle school high school' slowly and observe the auto-complete behaviour 6) Notice how after you start typing the second word, the auto complete results vanish. 7) Apply patch, repeat plan and verify it now works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34033] DB update problems from bug 30649
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34033 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Pedro Amorim changed: What|Removed |Added Blocks||34083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] New: Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Bug ID: 34083 Summary: Patron auto-complete fails if organization patron full name is in a single field separated by a space Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: pedro.amo...@ptfs-europe.com Reporter: pedro.amo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, katrin.fisc...@bsz-bw.de, kyle.m.h...@gmail.com, martin.renvo...@ptfs-europe.com, n...@bywatersolutions.com, tomasco...@gmail.com Depends on: 32772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 [Bug 32772] Patron autocomplete should not use contains on all fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34033] DB update problems from bug 30649
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34033 Tomás Cohen Arazi changed: What|Removed |Added Attachment #152405|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 152531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152531&action=edit Bug 34033: (bug 30649 follow-up) Fix update typos Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34033] DB update problems from bug 30649
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34033 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34079] The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard changed: What|Removed |Added Blocks||34082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34082 [Bug 34082] Cut some redundancy in OPAC JavaScript string translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34082] New: Cut some redundancy in OPAC JavaScript string translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34082 Bug ID: 34082 Summary: Cut some redundancy in OPAC JavaScript string translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34035 A few templates in the OPAC still define a string in one place and then use the string in another. If the string is used only once I don't think it's necessary to separate the definition from the use. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #5 from Owen Leonard --- Created attachment 152530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152530&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard changed: What|Removed |Added Attachment #152525|0 |1 is obsolete|| Attachment #152526|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 152529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152529&action=edit Bug 34035: (preparatory cleanup) Convert indentation to spaces. This patch converts tabs to spaces in tags.js. No other changes are made. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25295] Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 --- Comment #4 from AspenCat Team --- We customize our discovery layer already, it would be great to make it easier to put visual branding in for staff, that avoids a lot of jquery and css. We just have too many branches to take that approach. - Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25295] Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32765] Transfer is not retried after cancelling hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Sam Lau changed: What|Removed |Added Attachment #150801|0 |1 is obsolete|| --- Comment #11 from Sam Lau --- Created attachment 152528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152528&action=edit Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32765] Transfer is not retried after cancelling hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34081] New: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34081 Bug ID: 34081 Summary: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr In the case of tags, the statuses are the same for one or more term. For example, in the table of terms, the column "Status" contains the status for the one term. Whereas, on the right, in the "Terms summary", the statuses are for many terms. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34079] The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 --- Comment #4 from Caroline Cyr La Rose --- (In reply to Fridolin Somers from comment #2) > Tricky indeed. > > In my opinion, we should use the all phrase to have context and no %s : > > > [% IF ( filter_approved_all ) %]Displaying all terms[% END %] > [% IF ( filter_approved_ok ) %]Displaying approved terms[% END > %] > [% IF ( filter_approved_pending ) %]Displaying pending terms[% > END %] > [% IF ( filter_approved_rej ) %]Displaying rejected terms[% END > %] > Even better! I redid the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076
--- Comment #1 from Jonathan Druart ---
I have pushed a branch at
https://gitlab.com/joubu/Koha/-/commits/cypress-studio
The git log is a bit dirty but at least shows how I reached the current state.
Note that this first try (POC) adds code to the Koha repo, but ideally we will
certainly want it into its own repo.
The idea is to use cypress-studio |1] to let users without development skills
generate steps to reach the DOM element to screenshot (either the whole screen
or a specific div). However we will then need developers to polish the
generated code.
So far the remote branch only generates 4 screenshots: prefsearch,
searchbar-admin, prevcheckout and allowstafftosetvisibilityforguarantor (they
are the names of the images in the manual).
On the remote branch you can see "auto" and "manual" commits for those
examples. The "auto" are auto-generated by cypress-studio. The "manual" is what
needs to be done to make the tests run several times (either restore the state
or init it before we run the tests).
Eg. for prevcheckout we need to set the syspref to its original value (hardno)
or it will already be "hardyes" and the test will fail to set it to "hardyes"
The "manual" step also contain the screenshot part.
Test plan:
0. Checkout the remote branch
% git remote add joubu https://gitlab.com/joubu/Koha/
% git fetch joubu
% git checkout -b cypress-studio joubu/cypress-studio
1. start ktd up
2. Run a docker container with the newest version of cypress (Koha is using 9
we want 12)
Go to your Koha src directory and run (on your host then):
% docker run -it \
-v $PWD:/e2e \
-v /tmp/.X11-unix:/tmp/.X11-unix \
-w /e2e \
-e DISPLAY \
--entrypoint cypress \
--network koha_kohanet \
cypress/included:12.14.0 open --project .
If you get "No protocol specified" then run (still on the host)
% xhost local:root
And try again the 'docker run' command.
It should open the cypress UI in a new window.
Click "Continue" and you should see: https://snipboard.io/5KawXe.jpg
Click "E2E Testing" (that should be with a green 'Configured').
Select the browser you want to try https://snipboard.io/Aynf64.jpg and click
"Start E2E Testing in..."
It will open a new window with the browser. It will list the different test
files (found in t/cypress/integration): https://snipboard.io/Lk19cR.jpg
3. Run the tests
Click on Manual/0-language-ui.ts https://snipboard.io/Bd3v4A.jpg
The test should be green
Click on "Specs" top left to open the side menu
Click on 1-sysprefs.ts https://snipboard.io/4iIs2j.jpg
Click on the next 2 tests.
Are they all green? They should.
4. Admire the screenshots
Go to t/cypress/screenshots/ you should see 4 screenshots
en_prefsearch.png
en_searchbar-admin.png
en_prevcheckout.png
en_allowstafftosetvisibilityforguarantor.png
5. Generate translated screenshots
in ktd:
% cd misc/translator/
% perl translate install fr-FR
% perl translate install fr-CA
% perl translate install es-ES
Go to Koha, enable the 3 languages (search for the "language" syspref)
Close the Cypress UI (or ctrl-c in the console where you launched it), and now
pass --env KOHA_LANG=fr-FR (to use the French template)
docker run -it \
-v $PWD:/e2e \
-v /tmp/.X11-unix:/tmp/.X11-unix \
-w /e2e \
-e DISPLAY \
--entrypoint cypress \
--network koha_kohanet \
cypress/included:12.14.0 open --env KOHA_LANG=fr-FR --project .
And retry 3.
Now you should notice 4 new screenshots, prefixed with "fr-FR_" instead of
"en_". They should be showing the French interface.
6. Create a new (easy) test!
Here we are!
Let's start with an easy one, librarylist:
https://koha-community.org/manual/23.05/en/html/_images/librarylist.png
So it would be another file, as it's a "library" thing create the following
file: `t/cypress/integration/Manual/4-library.ts`
With the following content:
```
describe("Libraries", function () {
beforeEach(() => {
cy.login();
cy.set_cookie_lang();
});
it("librarylist", function () {
assert(true);
});
});
```
Go to the cypress UI (you can use a translated interface or the default/English
one) and notice that it detected the new file, click on it. The beforeEach part
is only there to login and set the language cookie before each test is run.
The "it" block is doing nothing (apart from running a test that will always
pass), but it's where we want our steps to be.
https://snipboard.io/B4YCrK.jpg
Hover your mouse over the "Libraries" line and notice the magic wand icon "Add
new test". Tests rerun and you can interact with the UI!
Go to Administation > Libraries. Now the goal is to find the correct element we
want to screenshot. We want the "New library" button and the library list.
Right click and locate the 'main' element (between the button and the
"Libraries" title for instance).
Click "Add assertion > be visible". Try to make as little "noise" as possible!
Every interaction (mouse or keyboard) with the UI will be record
[Koha-bugs] [Bug 34079] The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Caroline Cyr La Rose changed: What|Removed |Added Attachment #152523|0 |1 is obsolete|| --- Comment #3 from Caroline Cyr La Rose --- Created attachment 152527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152527&action=edit Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 --- Comment #3 from Owen Leonard --- Created attachment 152526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152526&action=edit Bug 34035: Move translatable strings out of opac-bottom.inc: Tags This patch removes the definition of JS variables in opac-bottom.inc related to the tags feature. These strings can be wrapped in the __() function inside tags.js and they'll get picked up for translation. Some other tags-related JS variable definitions are removed from templates in favor of embedding them directly in the
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard changed: What|Removed |Added Attachment #152416|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 152525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152525&action=edit Bug 34035: (preparatory cleanup) Convert indentation to spaces. This patch converts tabs to spaces in tags.js. No other changes are made. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #1 from Kyle M Hall --- Created attachment 152524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152524&action=edit Bug 34080 - Updating suggestion status can result in 500 error Sometimes using "Mark selection as" to update a suggestions can result in a 500 error with the logged error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggestion_itemtype' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 394 It appears that the search params are built from *all* the form fields and then some form fields are removed from the hashref, but not all ( hence the error ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Kyle M Hall changed: What|Removed |Added Summary|Updating suggestion status |Updating suggestion status |can result in 500 eror |can result in 500 error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] New: Updating suggestion status can result in 500 eror
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Bug ID: 34080 Summary: Updating suggestion status can result in 500 eror Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Sometimes using "Mark selection as" to update a suggestions can result in a 500 error with the logged error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggestion_itemtype' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 394 It appears that the search params are built from *all* the form fields and then some form fields are removed from the hashref, but not all ( hence the error ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31452] Attach item process allows for deleting of bib with holds with no warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31452 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org --- Comment #2 from Jason Robb --- +1 We had a hold disappear yesterday and discovered it was due to this process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34079] The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- Tricky indeed. In my opinion, we should use the all phrase to have context and no %s : [% IF ( filter_approved_all ) %]Displaying all terms[% END %] [% IF ( filter_approved_ok ) %]Displaying approved terms[% END %] [% IF ( filter_approved_pending ) %]Displaying pending terms[% END %] [% IF ( filter_approved_rej ) %]Displaying rejected terms[% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34035] Move translatable strings out of opac-bottom.inc: Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34035 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34079] The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 152523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152523&action=edit Bug 34079 - The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34079] The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34059] advance_notices.pl -c --digest-per-branch does not work as intended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34059 Pedro Amorim changed: What|Removed |Added Attachment #152492|0 |1 is obsolete|| --- Comment #3 from Pedro Amorim --- Created attachment 152522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152522&action=edit Bug 34059: Add only issues from the branch that is creating the notice Test plan, on k-t-d 1) Go to 'my account' on top right user menu 2) On 'Patron messaging preferences', click 'Edit' 3) On the 'Item due' row, check the 'Email' and 'Digests only' checkboxes and save 4) On the top search bar, press 'Check out' and enter '42' (koha user cardnumber) 5) On the checkout input bar, enter 301372 and press checkout 7) Go to 'Set library' on top right user menu and pick a different library 8) Repeat step 4), then, on the checkout input, enter 304571 and press checkout 9) Verify that this user now has 2 items checked out, from 2 different libraries at /cgi-bin/koha/circ/circulation.pl?borrowernumber=51 9) Run the following 2 queries to force the due_date to be equal to 'today's' date for both issues: NOTE: change the -MM-DD below to whatever day it is you're running this test plan UPDATE issues SET date_due = '2023-06-19 23:59:00' where issue_id = 1; UPDATE issues SET date_due = '2023-06-19 23:59:00' where issue_id = 2; 10) Run the cronjob: ./koha/misc/cronjobs/advance_notices.pl -c --digest-per-branch 11) Verify that two DUEDGEST notices were created, one per each library, but both notices contain both issues: SELECT letter_code, time_queued, content FROM message_queue ORDER BY message_id DESC LIMIT 2; 12) Apply patch, then do 10) and 11) again 13) Verify that each notice only contains the issue for its respective library Signed-off-by: Sam Lau Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34079] New: The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Bug ID: 34079 Summary: The phrase "Displaying [all|approved|pending|rejected] terms" was separated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The phrase "Displaying [all|approved|pending|rejected] terms" was cut into individual words by bug 30733. However, in French, we need to be able to change the sentence structure (it would become something like "Displaying terms [all|approved|pending|rejected]"). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20711] Previous fields are not cleared when selecting an authority in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20711 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34078] New: Add --branchcode to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34078 Bug ID: 34078 Summary: Add --branchcode to writeoff_debts.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz I think it would be useful to have a branchcode flag to the writeoff_debts.pl script. My specific use case is that I wanted to use it in an Independent branch environment to writeoff fines for a specific branch. I'm sure there are other use cases (one branch was closed or something). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34077 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28995 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34077] New: writeoff_debts without --confirm doesn't show which accountline records it would have been written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Bug ID: 34077 Summary: writeoff_debts without --confirm doesn't show which accountline records it would have been written off Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz The documentation in writeoff_debts says that if we omit --confirm, "the script will only report on the accountline records it would have been written off". However, while testing bug 28995, I tried to see which accountline would be written off, and omitting the --confirm flag only shows the help. I ran ./misc/cronjobs/writeoff_debts.pl --added-after 2023-06-20 and it showed the help. When I ran ./misc/cronjobs/writeoff_debts.pl --added-after 2023-06-20 --confirm it wrote off the charge correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #10 from Caroline Cyr La Rose --- I wrote what I did as a test plan, I hope it helps 1. Add two fees in a patron account 1.1. Go into a patron record > Accounting tab 1.2. Go to the Create a manual invoice tab 1.3. Fill out the form 1.4. Click 'Save' 1.5. Redo steps 1.2 to 1.4 to add a second fee 2. Manually change the date in the database 2.1. In the database, find the accountlines_id for the two fees Here's what I did select * from accountlines where borrowernumber = 21 and amountoutstanding > 0; +-+--+++-+---+-+--+-+---++--+---+-+--++-+---++ | accountlines_id | issue_id | borrowernumber | itemnumber | date | amount| description | credit_type_code | debit_type_code | credit_number | status | payment_type | amountoutstanding | timestamp | note | manager_id | register_id | interface | branchcode | +-+--+++-+---+-+--+-+---++--+---+-+--++-+---++ | 652 | NULL | 21 | NULL | 2023-06-21 09:34:05 | 10.00 | Lost item | NULL | LOST| NULL | NULL | NULL | 10.00 | 2023-06-21 09:34:05 | | 51 |NULL | intranet | CPL| | 653 | NULL | 21 | NULL | 2023-06-21 09:35:44 | 2.00 | Lost item | NULL | LOST| NULL | NULL | NULL | 2.00 | 2023-06-21 09:35:44 | | 51 |NULL | intranet | CPL| +-+--+++-+---+-+--+-+---++--+---+-+--++-+---++ 2 rows in set (0.001 sec) select * from account_offsets where debit_id = '652'; +-+---+--++---+-+ | id | credit_id | debit_id | type | amount| created_on | +-+---+--++---+-+ | 799 | NULL | 652 | CREATE | 10.00 | 2023-06-21 09:34:05 | +-+---+--++---+-+ 1 row in set (0.001 sec) 2.2. Update the date for one of the fees using the accountlines_id Here's what I did update accountlines set date = '2023-06-01 09:34:05' where accountlines_id = 652; update account_offsets set created_on = '2023-06-01 09:34:05' where debit_id = '652'; I now have one fee on June 1st and one fee on June 21st, the account_offset is also modified (not sure if that last part is necessary). select * from accountlines where borrowernumber = 21 and amountoutstanding > 0; +-+--+++-+---+-+--+-+---++--+---+-+--++-+---++ | accountlines_id | issue_id | borrowernumber | itemnumber | date | amount| description | credit_type_code | debit_type_code | credit_number | status | payment_type | amountoutstanding | timestamp | note | manager_id | register_id | interface | branchcode | +-+--+++-+---+-+--+-+---++--+---+-+--++-+---++ | 652 | NULL | 21 | NULL | 2023-06-01 09:34:05 | 10.00 | Lost item | NULL | LOST| NULL | NULL | NULL | 10.00 | 2023-06-21 09:40:46 | | 51 |NULL | intranet | CPL| | 653 | NULL | 21 | NULL | 2023-06-21 09:35:44 | 2.00 | Lost item | NULL | LOST| NULL | NULL | NULL | 2.00 | 2023-06-21 09:35:44 | | 51 |
[Koha-bugs] [Bug 25295] Allow customization of staff client based on login location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25295 Andrew Fuerste-Henry changed: What|Removed |Added Version|19.11 |master --- Comment #3 from Andrew Fuerste-Henry --- Giving this another bump after the staff interface design overhaul. This is still something we're accomplishing with jquery and css; it'd be great to have something more stable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Caroline Cyr La Rose changed: What|Removed |Added Attachment #127625|0 |1 is obsolete|| --- Comment #9 from Caroline Cyr La Rose --- Created attachment 152521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152521&action=edit Bug 28995: Update aliases Add an alias for added-before, added-after (Using an alias makes it backwards compatible) and update the POD. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Caroline Cyr La Rose changed: What|Removed |Added Attachment #127624|0 |1 is obsolete|| --- Comment #8 from Caroline Cyr La Rose --- Created attachment 152520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152520&action=edit Bug 28995: Add `--added_after` filter to writeoff_debts script This adds, as requested, the `added_after` filter option to writeoff_debts. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
