[Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #8 from Adam Styles --- Hi Katrin, opps I will get onto this one. Apologies for delay in new patch. Stay tuned. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #17 from David Cook --- Looks like this introduced a problem for Shibboleth config too but I have a patch on bug 31393 for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 David Cook changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #8 from David Cook --- Hopefully this patch doesn't break a case where there really is a config item that only has an attribute of "content" that should be treated as if it didn't have an attribute. CCing Julian Maurice in case I've missed something. But I think "content" was just used as a placeholder so changing it to "_content" should be perfectly fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 David Cook changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 David Cook changed: What|Removed |Added Summary|Shibboleth broken since|Koha::Config->read_from_fil |migration from XML::Simple |e incorrectly parses ||elements with 1 attribute ||named" content" (Shibboleth ||config) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Shibboleth broken since migration from XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 --- Comment #7 from David Cook --- Voila! Not bad for 15 minutes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Shibboleth broken since migration from XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393
--- Comment #6 from David Cook ---
Created attachment 152609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152609=edit
Bug 31393: Use _content as a placeholder when parsing koha-conf.xml
This patch uses '_content' instead of 'content' as a placeholder
when parsing koha-conf.xml, so that elements with a "content"
attribute don't get parsed incorrectly (like with shibboleth config).
Test plan:
0. Apply patch
1. echo 'flush_all' | nc -q 1 memcached 11211
2. koha-plack --reload kohadev
3. Add Shibboleth config to koha-conf.xml
userid
4. vi Koha/Config.pm
5. Dump out the $config from the read_from_file() function
6. Note that the following is shown:
'branchcode' => {
'content' => 'foo'
}
7. Note that the following is NOT shown:
'branchcode' => 'foo'
8. git restore Koha/Config.pm
9. Rejoice!
For bonus points, you can actually do a full SAML test and make sure
the Shibboleth integration works as expected
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Shibboleth broken since migration from XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Shibboleth broken since migration from XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 --- Comment #5 from David Cook --- (In reply to David Cook from comment #4) > I took a look at the code from bug 28278 and I have no idea why it removes > elements with an attribute of "content"... Of course, as soon as I look at it again, the answer looks obvious. At a glance, it looks like we should change "content" to "_content" in _read_from_dom_node. But I haven't actually written that out or tried it yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 David Cook changed: What|Removed |Added Blocks||31393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 [Bug 31393] Shibboleth broken since migration from XML::Simple -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Shibboleth broken since migration from XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 David Cook changed: What|Removed |Added Depends on||28278 --- Comment #4 from David Cook --- (In reply to Matthias Meusburger from comment #3) > Hi, > > Actually, having only "content" or only "is" is valid. > > "is" will get the value from the matching Shibboleth attribute. > > "content" is a fixed string. Ah that's good to know. Thanks for the correction. That would explain too why I haven't noticed the problem yet as well. -- I still think we should look at moving away from koha-conf.xml anyway. But I suppose we have to fix this in the meantime... I took a look at the code from bug 28278 and I have no idea why it removes elements with an attribute of "content"... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #6 from David Cook --- I recently bumped into this problem as well, although I don't try to recover using StripNonXmlChars()... I don't know what I think about sending out a slightly different version than what's stored in the database... But overall we do need a fix harvests choking on 1 bad record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 --- Comment #20 from David Cook --- (In reply to Owen Leonard from comment #19) > The database I use for testing is an older one from our production system > and it has been updated again and again. I needed a tool today to figure out > whether my problems importing patrons were Koha's fault or my database's, > and this tool identified a number of problems which I was able to resolve. > Now I can test patron imports again. That's awesome, Owen! You made my day :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #79 from David Cook --- I have a library catalogue with French, English, and Arabic records. We're using Zebra with ICU indexing, but it would be interesting to try out Elasticsearch on that catalogue, especially with these patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #78 from David Cook --- An interesting case I bumped into recently was "Dewhurst's textbook of obstetrics" The library wants to be able to search for "Dewhursts textbook of obstetrics". I think that I can understand that. It's often difficult with names to remember if it ends in just an "s" or if it's "'s". So it would be nice if the system considered both options. If "Dewhurst's" is indexed as "Dewhursts", that means it would catch both "Dewhurst's" and "Dewhursts". But it wouldn't catch "Dewhurst". That would return no results. If you have query stemming turned on, "Dewhursts" or "Dewhurst's" also gets stemmed down to "Dewhurst" in English, so that would also break your search, unless you have truncation turned on too. -- I think Bywater are the biggest English language users of Elasticsearch with Koha, so I'll defer to them on this topic. Like I said... I'm not using ES with Koha yet, so I wouldn't consider my comments a blocker at all. Feel free to move forward. I'm sure someone other than me will find any potential issues that pop up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #77 from David Cook --- (In reply to Katrin Fischer from comment #76) > I am not sure I follow that argument. We already have been ignoring ' with > Zebra for many years and never got a bug filed about it. On the other hand, > we have a lot of people now that ask for it to ignore the '. We don't ignore the apostrophe/single quote in Zebra. We change it to a space. That's significantly different than replacing it with nothing from a tokenization perspective. > Would it be possible to make it configurable? If not, I'd say we should just > go with it. It's a big issue for French. And searching 'dont' is what I feel > is more common than 'don t'. I think I've talked about some options on a different bug about indexing both options, so there probably are some options (like indexing with and without punctuation) for making a Koha configuration for it. But it would probably be a bit error-prone as we'd need to change all of Koha to support it. I'm not using Elasticsearch yet, so I'm happy for people to try things out. Just trying to think of any pitfalls. And also hoping that we can try to keep Zebra and Elasticsearch similar in their configuration - or else we should think about deprecating Zebra and just focusing on Elasticsearch. Regarding "don't", I would hope that people would search for "don't" instead of "dont" or "don t". Note that "dont" is also a French word, so searches for "don't" would match for titles including the word "dont". But multilingual indexing is hard anyway... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33944] When listing checkouts, don't fetch item object if not using recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33944 Katrin Fischer changed: What|Removed |Added Attachment #152129|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 152607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152607=edit Bug 33944: Don't fetch item object unless using recalls To test: 1 - Check someitems out to a patron 2 - View thier checkouts 3 - Apply patch, restart_all 4 - Confirm checkouts load as before 5 - Enable recalls 6 - Recall an item checked out to this patron 7 - Confirm recall shows as expected Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33944] When listing checkouts, don't fetch item object if not using recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33944 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33944] When listing checkouts, don't fetch item object if not using recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33944 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- First strike, Nick - you forgot Assignee again :P -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34071] Change the phrasing of 'automatic checkin' to fit consistent terminology
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34071 Katrin Fischer changed: What|Removed |Added Attachment #152551|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152606=edit Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology This patch simply changes 'Automatic checkin' to be 'Automatic check-in'. Test plan: 1) Go to administration -> item types and click the edit button on an item. 2) Notice there is a checkbox labeled 'Automatic checkin'. 3) Apply patch. 4) Refresh the page and notice the checkbox now says 'Automatic check-in'. 5) prove t/db_dependent/Koha/Checkouts.t 6) Sign-off :) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34071] Change the phrasing of 'automatic checkin' to fit consistent terminology
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34071 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34071] Change the phrasing of 'automatic checkin' to fit consistent terminology
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34071 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34086] On detail.tt if item.permanent_location is NULL no shelving location will show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #3 from Lucas Gass --- Marked as major because this can severely effect library workflows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33973] Sorting broken on ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 Katrin Fischer changed: What|Removed |Added Attachment #152471|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 152605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152605=edit Bug 33973: Restore sorting on Vue tables Regression from the KohaTable Vue component added by bug 33066. _dt_default_ajax expects options.columns to contain the columns. Test plan: Add some agreements, go the the agreement list view and confirm that you can now sort the agreements using the header columns. Note that the CSS is not correct yet. My understanding is that the DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column. Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33973] Sorting broken on ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33973] Sorting broken on ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 --- Comment #11 from Katrin Fischer --- There is still something wrong when searching by Name. Add agreements in this sequence: t b z They get sequential IDs (1 2 3 or similar). They get sequential IDs, when you sort, they by Name, they won't sort by the description, but by their ID: zbt or tbz Filed separately as: Bug 34107 - Sorting agreements by Name actually sorts by ID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #2 from Lucas Gass --- Created attachment 152604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152604=edit Bug 34106: Retain searchtype parameter in member-search-box To test: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' 7. Apply patch 8. Try everything again. By default both places should default to contain. 9. If you change the 'Search type' the search in the main header should always retain that value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33973] Sorting broken on ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 Katrin Fischer changed: What|Removed |Added Blocks||34107 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 [Bug 34107] Sorting agreements by Name actually sorts by ID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34107] New: Sorting agreements by Name actually sorts by ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Bug ID: 34107 Summary: Sorting agreements by Name actually sorts by ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+k...@gmail.com Reporter: katrin.fisc...@bsz-bw.de CC: jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, matt.blenkin...@ptfs-europe.com, pedro.amo...@ptfs-europe.com Depends on: 33973 There is still something wrong when searching by Name. Add agreements in this sequence: t b z They get sequential IDs (1 2 3 or similar). Now when you sort on the Name column, they won't sort by the description, but by their ID: zbt or tbz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 [Bug 33973] Sorting broken on ERM tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #1 from Lucas Gass --- I think these should both default to 'contains'/ And if you do a search with 'contains' it should always retain that parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34106] New: Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Bug ID: 34106 Summary: Patron search in member-search-box.inc always defaults to 'Starts with' search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33973] Sorting broken on ERM tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- Sorry for the earlier patch mess, but now I can QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32245] Deleting news entries from Koha's staff start page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 Katrin Fischer changed: What|Removed |Added Attachment #152561|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 152603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152603=edit Bug 32245: Fix delete news item from staff home page Simple fix: op was named incorrectly in URL. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32245] Deleting news entries from Koha's staff start page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Katrin Fischer changed: What|Removed |Added Depends on||32245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 [Bug 32245] Deleting news entries from Koha's staff start page is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32245] Deleting news entries from Koha's staff start page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 Katrin Fischer changed: What|Removed |Added Blocks||31383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Katrin Fischer changed: What|Removed |Added Blocks|32245 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 [Bug 32245] Deleting news entries from Koha's staff start page is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32245] Deleting news entries from Koha's staff start page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 Katrin Fischer changed: What|Removed |Added Depends on|31383 | --- Comment #6 from Katrin Fischer --- Currently the patch doesn't apply without 32245: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32245: Fix delete news item from staff home page error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt). error: could not build fake ancestor Patch failed at 0001 Bug 32245: Fix delete news item from staff home page hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32245-Fix-delete-news-item-from-staff-home-pag-c87n5g8w.patch As we want the bugfix backported, I suggest to turn the dependencies around. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32245] Deleting news entries from Koha's staff start page is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33790] Fix and add various links to the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33990] Fix 'Recalls awaiting pickup' report if there are recalls waiting a problematic number of days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Katrin Fischer changed: What|Removed |Added Attachment #152311|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152602=edit Bug 33990: Correctly access subtitle for Recalls awaiting pickup report This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab sudo koha-mysql INSTANCE select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X; 11. Refresh the Circulation -> Recalls awaiting pickup page 12. Confirm the page blows up and there is an error 13. Apply the patch and refresh the page 14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab 15. Confirm the subtitle (probably in 245$b) shows as expected Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33990] Fix 'Recalls awaiting pickup' report if there are recalls waiting a problematic number of days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33990] Fix 'Recalls awaiting pickup' report if there are recalls waiting a problematic number of days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33990 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Fix the 'Recalls awaiting |Fix 'Recalls awaiting |pickup' report if there are |pickup' report if there are |recalls waiting a |recalls waiting a |problematic number of days |problematic number of days -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33999] Subscription details link on bibliographic detail page should have permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- The permission check is correct of course, but I am not sure about turning this into a button. For me a button means "action", but here it's "navigation". Owen, what do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34105] Terminology: Biblio label on subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34105 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34105] New: Terminology: Biblio label on subscription detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34105 Bug ID: 34105 Summary: Terminology: Biblio label on subscription detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Biblio should read "Bibliographic record" or maybe "Staff interface view" (next link is OPAC view). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34002] Check for stage_marc_import permission when adding to basket from a new file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34002 Katrin Fischer changed: What|Removed |Added Attachment #152340|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152601=edit Bug 34002: Check for stage_marc_import permssion -1 Log in to the staff client as a user who has Acquisition management (acquisition) permissions but not the stage_marc_import (tools) permission. -2 Go to Acquisitions and Add to a basket. -3 Select 'From a new file' -4 You will be logged out as the user does not have percussion to visit that page. -5 Apply patch -6 Try again, you will not see the link for 'From a new file' if you don't have the permssion. -7 Give the user the stage_marc_import, you will now see the link Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34002] Check for stage_marc_import permission when adding to basket from a new file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34002 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- This patch stops the 500 error from occurring. However, with it applied I am unable to switch the status of suggestions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/697 Resolution|--- |FIXED Documentation||Caroline Cyr La Rose contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34002] Check for stage_marc_import permission when adding to basket from a new file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34002 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Katrin Fischer changed: What|Removed |Added Attachment #144312|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Comment on attachment 144312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144312 BUG 31651: Replaced duplicate error message This actually had no sign-off yet, so mine is a SO. Also fixed commit message: BUG.. should be Bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #14 from Katrin Fischer --- Created attachment 152600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152600=edit Bug 31651: Replaced duplicate error message The duplicated error message on ln119 has now been replaced for clarity. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 --- Comment #13 from Katrin Fischer --- (In reply to Martin Renvoize from comment #12) > Hmm.. there's already an Auth_with_shibboleth.t test where I mocked an > aweful lot.. we may be able to add tests there actually.. While a test would be great, this looks mostly like a string change to me. I couldn't test, but all the same variables are used and the code comment is pretty clear too. I'll sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer changed: What|Removed |Added Attachment #152256|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 152599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152599=edit Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer changed: What|Removed |Added Attachment #152255|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 152598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152598=edit Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Katrin Fischer changed: What|Removed |Added Attachment #152356|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 152597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152597=edit Bug 34013: Recalls awaiting pickup doesn't show count on each tab This patch modifies recalls_waiting.pl so that it defines template variables for 'recalls waiting' and 'recalls waiting over x days' counts in the same way that waitingreserves.pl handles it. To test you must have UseRecalls enabled, and some recalls data that will allow you to see content under each tab. Go to Circulation -> Recalls awaiting pickup and confirm that both tabs show the correct count. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Katrin Fischer changed: What|Removed |Added Attachment #152362|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 152596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152596=edit Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup This patch updates the recalls awaiting pickup template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test you must have UseRecalls enabled. Apply the patch and go to Circulation -> Recalls awaiting pickup. Both the "Recalls waiting" and "Recalls waiting over X days" tabs should look correct and work correctly. Signed-off-by: Sam Lau Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34013] Recalls awaiting pickup doesn't show count on each tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34013 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- *** Bug 34104 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34104] Recalls awaiting pickup missing number of recalls in tab labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34104 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 34013 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34104] New: Recalls awaiting pickup missing number of recalls in tab labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34104
Bug ID: 34104
Summary: Recalls awaiting pickup missing number of recalls in
tab labels
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
In the holds awaiting pickup we can see how it should look like, but it doesn't
work for the recalls awaiting pickup: the number of recalls that will show on
each tab at the end of the tab label.
We can see that the variables are there in the template, but it doesn't work:
+[% WRAPPER tabs id= "results" %]
+[% WRAPPER tabs_nav %]
+[% WRAPPER tab_item tabname= "recallswaiting"
bt_active= 1 %] Recalls waiting: [% recalls.count | html %] [% END
%]
+[% WRAPPER tab_item tabname= "recallsover" %]
Recalls waiting over [% Koha.Preference('RecallsMaxPickUpDelay') | html
%] days: [% over.count | html %] [% END %]
+[% END # /WRAPPER tabs_nav %]
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Katrin Fischer changed: What|Removed |Added Attachment #152359|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 152595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152595=edit Bug 34010: Template corrections to recall pages This patch makes some corrections to recall pages: - Update breadcrumbs menu to use wrapper. - Add where it is missing. - Use biblio-title include to show links to bibliographic record titles. - Correct Bootstrap button dropdown markup for consistent style - Change some submit buttons to elements for consistent style To test you must have UseRecalls enabled. Having some sample recalls data will help. Check the following pages to confirm that everything looks correct: - Circulation -> - Recalls queue - Recalls to pull - Overdue recalls - Recalls awaiting pickup - Old recalls - Existing recalls: View a bibliographic record with a recall and click "Recalls" in the sidebar. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34010] Template corrections to recall pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34010 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What|Removed |Added Blocks|34012 | Depends on||34012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Katrin Fischer changed: What|Removed |Added Blocks||32571 Depends on|32571 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34012] Use template wrapper for tabs: Recalls awaiting pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34012 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33581] Error in web installer concerning sample holidays and patrons requiring sample libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer changed: What|Removed |Added Summary|Error in Webinstaller |Error in web installer |concerning sample holidays |concerning sample holidays |and patrons requiring |and patrons requiring |sample libraries|sample libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Katrin Fischer changed: What|Removed |Added Attachment #152560|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 152594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152594=edit Bug 34083: (follow-up) Prevent showing 'null' In patron lists, if the patron added is an organization without the firstname, it presents 'null'. This fixes that Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Katrin Fischer changed: What|Removed |Added Attachment #152559|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 152593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152593=edit Bug 34083: Add searching for full term on patron auto-complete To reproduce, on k-t-d: 1) Create a new patron of category 'School' 2) Enter 'Middle school high school' on the mandatory 'Name' field and put something in 'Card number:' 3) Visit patron lists at /cgi-bin/koha/patron_lists/lists.pl and click 'New patron list' 4) Put something in 'Name:' and click 'Save' 5) On the 'Patron search' input, enter 'middle school high school' slowly and observe the auto-complete behaviour 6) Notice how after you start typing the second word, the auto complete results vanish. 7) Apply patch, repeat plan and verify it now works as expected. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34083] Patron auto-complete fails if organization patron full name is in a single field separated by a space
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34083 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34052] Fix link to subscription from serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer changed: What|Removed |Added Attachment #152591|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 152592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152592=edit Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34052] Fix link to subscription from serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer changed: What|Removed |Added Summary|Incomplete relative URL to |Fix link to subscription |subscription-detail.pl |from serial collection page |breaks navigation | --- Comment #4 from Katrin Fischer --- Technically the bug description was correct, but I think we can make it a little more telling to users :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34052] Incomplete relative URL to subscription-detail.pl breaks navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer changed: What|Removed |Added Attachment #152493|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152591=edit Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34052] Incomplete relative URL to subscription-detail.pl breaks navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34052] Incomplete relative URL to subscription-detail.pl breaks navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34052 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34103] Capitalization: Currencies & Exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34103 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Assignee|oleon...@myacpl.org |caroline.cyr-la-rose@inlibr ||o.com QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- Full queue, easy fix, setting to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34103] Capitalization: Currencies & Exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34103 Katrin Fischer changed: What|Removed |Added Attachment #152587|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 152590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152590=edit Bug 34103: Capitalization: Currencies & Exchange rates This patch corrects the breadcrumbs in the Administration > Currencies and exchange rates page to follow current capitalization and typographical guidelines. To test: 0. Apply patch 1. Go to Administration > Currencies and exchange rates 2. Verify that the breadcrumb has no spelling errors, and that capitalization and typography guidelines are applied 3. Click 'Delete' next to one of the currencies 4. Verify that the breadcrumb has no spelling errors, and that capitalization and typography guidelines are applied Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34103] Capitalization: Currencies & Exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34103 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31618] Typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31618 Katrin Fischer changed: What|Removed |Added Attachment #152323|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 152589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152589=edit Bug 31618: Fix typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile To test: 1) Apply the patch 2) Visit C4::ImportBatch::RecordsFromMARCXMLFile 3) See that in the POD (mine was somewhere around line 1592) the line starting with '@PARAM1' now says '@PARAM1, String, absolute path to the MARCXML file.' 4) Sign off :) Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31618] Typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31618 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31618] Typo in POD for C4::ImportBatch::RecordsFromMARCXMLFile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31618 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer --- The git diff was a bit confusing here, as it looks like this POD was changed: =head2 RecordsFromISO2709File my ($errors, $records) = C4::ImportBatch::RecordsFromISO2709File($input_file, $record_type, $encoding); Reads ISO2709 binary porridge from the given file and creates MARC::Record-objects out of it. @PARAM1, String, absolute path to the ISO2709 file. @PARAM2, String, see stage_file.pl @PARAM3, String, should be utf8 Returns two array refs. =cut But it's actually this one: =head2 RecordsFromMARCXMLFile my ($errors, $records) = C4::ImportBatch::RecordsFromMARCXMLFile($input_file, $encoding); Creates MARC::Record-objects out of the given MARCXML-file. @PARAM1, String, absolute path to the MARCXML file. @PARAM2, String, should be utf8 Returns two array refs. =cut So we are good! Welcome Sam to the Koha devs! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33896] Catalog search from the masthead searchbar produces a warning in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33896 --- Comment #4 from Katrin Fischer --- Thank you, Matt :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33896] Catalog search from the masthead searchbar produces a warning in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33896 Katrin Fischer changed: What|Removed |Added Attachment #152030|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 152588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152588=edit Bug 33896: Check whether index is defined before string match This patch checks that $indexes[$i] is defined before testing whether the string matches to remove the logged warning when searching Test plan: 1) In the intranet, search the catalog from the top search bar 2) Check plack-intranet-error.log 3) There should be a warning "[WARN] Use of uninitialized value within @indexes in string eq" 4) Apply patch 5) restart_all and then re-try the search 6) The warning should no longer appear Signed-off-by: David Cook Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33896] Catalog search from the masthead searchbar produces a warning in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33896 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33896] Catalog search from the masthead searchbar produces a warning in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33896 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33968] Two colons missing on guarantor labels in memberentry.pl form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33968 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- Nothing much to see here, but some punctuation. As the queue is very full I dare to PQA this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
