[Koha-bugs] [Bug 34126] Tests in t/db_dependent/Koha/Patron.t fail due broken FK constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34126
--- Comment #1 from Emmi Takkinen ---
It's actually this line which fails:
$patron->account->pay({ amount => 10, debits => [ $debit ] });
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34126] New: Tests in t/db_dependent/Koha/Patron.t fail due broken FK constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34126 Bug ID: 34126 Summary: Tests in t/db_dependent/Koha/Patron.t fail due broken FK constraint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: emmi.takki...@koha-suomi.fi QA Contact: testo...@bugs.koha-community.org Koha/Patron.t tests fail when apparently when patron should be deleted after paying accountlines: t/db_dependent/Koha/Patron.t .. 10/24 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kv`.`accountlines`, CONSTRAINT `accountlines_ibfk_borrowers_2` FOREIGN KEY (`manager_id`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) at /home/emmi/Koha/Koha/Object.pm line 170 # Looks like you planned 14 tests but ran 12. # Failed test 'safe_to_delete() tests' # at t/db_dependent/Koha/Patron.t line 1124. Broken FK constraint# Looks like your test exited with 255 just after 14. t/db_dependent/Koha/Patron.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 11/24 subtests Test Summary Report --- t/db_dependent/Koha/Patron.t (Wstat: 65280 Tests: 14 Failed: 1) Failed test: 14 Non-zero exit status: 255 Parse errors: Bad plan. You planned 24 tests but ran 14. Files=1, Tests=14, 8 wallclock secs ( 0.05 usr 0.00 sys + 7.20 cusr 0.57 csys = 7.82 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #17 from Aleisha Amohia --- Have attached a patch for 22.05.x, not sure how the bug status should change sorry but it should get tested before it's backported! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504
--- Comment #16 from Aleisha Amohia ---
Created attachment 152704
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152704=edit
Bug 32504: [22.05] Fix misalignment of visibility of basket orders table
columns and missing export columns
To reproduce:
1. Go to /cgi-bin/koha/admin/columns_settings.pl
2. In the section Acquisition > Basket > Orders uncheck all checkboxes in the
table settings
3. Go to a separate browser window to /cgi-bin/koha/acqui/booksellers.pl and
open/create a new basket and add one book to it so the basket table will have
rows in the "Order" table which we will configure below:
4. Click on the ["Columns" settings] for the table.
5. In the dropdown menu, observe that all Columns are marked as visible and
correspond to the current table display.
6. Also check the export table feature: Click on "Export" and choose print, you
will see that Columns up to GST (goods_and_services_tax) are displayed, and
Fund and Estimated delivery date are missing.
7. Go back to table settings (like it was in steps.1-2)
8. Make the estimated_delivery_date column 'invisible by default' by checking
out the appropriate checkbox and saving the changes.
9. Refresh the basket window/page (like in step 3).
10. Observe that in the table the whole columns "Estimated delivery date" is
visible but "Fund" is gone.
11. Click on the ["Columns" settings] for the table.
12. In the dropdown menu observe that the wrong column is disabled ("Fund"
instead of "Estimated delivery date").
13. Apply the patch.
14. Go through steps 3-12 and make sure that everything mentioned in those
steps now works correctly: when you hide any columns in columns_settings.pl
they are correctly hidden for the "Order" table, as well when exporting the
table, the Fund, and Estimated delivery date columns are now exported.
Note: this patch also respects Koha.Preference('EDIFACT') setting and when it's
enabled it also correctly hides/shows and exports the 'supplier_report' column.
Sponsored-by: Horowhenua Libraries Trust
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34125] New: JS error on OPAC detail page when Coce is on and OPACURLOpenInNewWindow is set to 'do'.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34125 Bug ID: 34125 Summary: JS error on OPAC detail page when Coce is on and OPACURLOpenInNewWindow is set to 'do'. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Turn on Coce. 2. Set OPACURLOpenInNewWindow to 'Do'. 3. Go to an OPAC detail page that should return a Coce image. 4. Nothing loads, and if you look at the console you will see the error 'parent.find is not a function' coming from coce.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #29 from Aleisha Amohia --- Hi Janusz, This is the correct order: > > Haendel Gregory > Haendel-Adler, John > Haendel, Georg > The policy is 'nothing' before 'something' so spaces will be sorted before punctuation. Hope that helps! Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #28 from Janusz Kaczmarek --- Hi Heater! Thank you very much for checking it. I can confirm--with 'Ha wen' things look good now. I'm working with ktd--I had to restart plack to get the order changed. But still there are doubts. Could you, please, have a look at these three names: Haendel Gregory Haendel-Adler, John Haendel, Georg (mind the presence or absence of the comma and the dash) I get them in the above order whereas I would wish: Haendel-Adler, John Haendel, Georg Haendel Gregory So, I am confused... Am I doing something wrong? Could you, please, check it again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34124] Improve in-page navigation on table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 --- Comment #1 from Owen Leonard --- Created attachment 152703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152703=edit Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Adinistration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34124] Improve in-page navigation on table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34124] New: Improve in-page navigation on table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Bug ID: 34124 Summary: Improve in-page navigation on table settings page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org We have in-page navigation to jump to specific pages, but we could use in-page navigation to jump directly to tables within pages too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Emily Lamancusa --- Tried to test this, but the patch does not apply. Applying: Bug 16122: Add localuse column to items and deleteditems Applying: Bug 16122: API and Schema updates Applying: Bug 16122: Increment items.localuse in AddReturn Applying: Bug 16122: Add display to holdings/otherholdings and Table settings Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging admin/columns_settings.yml Applying: Bug 16122: Increment localuse when checking out to stats patron error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 16122: Increment localuse when checking out to stats patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34101] Limit items types that can be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Sam Lau changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sama...@gmail.com |ity.org | CC||sama...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29359] Mark image as default in record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29359 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > I think a default would only work for multiple local covers, for web > services it would maybe needs something like a priorities list. Agreed. I think both should happen. Local images should have the ability to be marked as default, and a priority list in the Enhanced content section of the system preferences should indicate priority between the groups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29214] Lost item checked in shows "Lost item fee refund" instead of "Lost item fee removed"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29214 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > Maybe 'Lost item fee cancelled' could also work here. Agreed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29044] Check for untriggered holds when checking out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29044 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > Hi Christopher, can you explain this one a bit more? Is the item here > filling a hold for the user it's checked out to? Well, it does not look like this is an issue anymore. If a patron places a hold on an item, and then proceeds to check the item out before the hold is triggered, Koha automatically removes the hold. However, the question is, should the staff member be notified that the checkout is fulfilling the unfilled hold and the hold is being removed? Should the patron be notified? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34123] New: Ability to filter the Holds Cancellation tab by branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34123 Bug ID: 34123 Summary: Ability to filter the Holds Cancellation tab by branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Add the ability to filter the Holds Cancellation tab by branch location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9602] Allow/disallow self check out based on item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9602 Kris changed: What|Removed |Added CC||kbec...@jcls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 --- Comment #1 from Owen Leonard --- Created attachment 152702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152702=edit Bug 34116: Add page-sectioning to item search in label creator This patch adds a "page-section" class to search results page seen when adding items to a label batch. The patch also makes some minor changes to markup around the search header to make it more consistent with other search pages. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch - Without entering anything in the textarea, click the "Add item(s)" button" - In the pop-up window, perform a search which will return multiple results. - Confirm that everything looks correct and all controls work as they should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #26 from Nick Clemens --- (In reply to Magnus Enger from comment #25) > I can't reproduce the problem in ktd. I put this: > > > http://localhost:8080/silk/famfamfam.png"/> >
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens changed: What|Removed |Added Depends on||33881 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #27 from Heather --- Hi, again, Janusz! I was not able to reproduce your sorting problem. I created a sandbox, applied the patch, then created authority records for all the headings in the test plan, plus a heading for: Ha wen. All headings sorted correctly: Ha wen Hagahara, Yoshiaki, 1939- Hailstone, H. Haim, Emmanuelle Hall, Joseph N., 1966- Halliwell, Stephen. Hamburger, David Hamel, Debra. Hamilton-James, Charlie. Hamilton-James, Charlie. Hamilton-Jones, Charlie Homes and haunts. Hamilton-Jones, Charlie Homes and haunts. Hamilton, Karen A. Hanʼguk Kiwŏn. Hand-ball Hand blows Hand book for Prospect Park Hand (Fictitious character) Hand in glove Handbok for sangere Handbook for adventure Hande im Pflug Handel, George Frideric, 1685-1759. Handel, George Frideric, 1685-1759. Alcina. Tornami a vagheggiar. Handel, George Frideric, 1685-1759. Amadigi. Ah! spietato! e non ti muove. Handel, George Frideric, 1685-1759. Apollo e Dafne. Felicissima quest'alma. Handel, George Frideric, 1685-1759. Ariodante. Mio crudel martoro. Handel, George Frideric, 1685-1759 Film and video adaptations. Handel, George Frideric, 1685-1759 Giulio Cesare. Handel, George Frideric, 1685-1759. Giulio Cesare. Da tempeste il legno infranto. Handel, George Frideric, 1685-1759. Giulio Cesare. Piangerò la sorte mia. Handel, George Frideric, 1685-1759. Rinaldo. Lascia ch'io pianga mia cruda sorte. Handel, George Frideric, 1685-1759. Rinaldo. Vo' far guerra. Handel, George Frideric, 1685-1759. Semele. Endless pleasure, endless love (Air) Handel, George Frideric, 1685-1759. Semele. Myself I shall adore. Handel, George Frideric, 1685-1759. Teseo. Dolce riposo, ed innocente pace. Handel, George Frideric, 1685-1759. Teseo. O stringerò nel sen. Hands in the past Handu Harmes, Ross. I even created two authority records for "Ha wen," one as a topical term and another as a personal name (in case the type of heading was a problem), and both authority records for "Ha wen" sorted correctly. Based on this, I think the bug should remain signed off--unless Janusz's problem can be re-created? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 Pedro Amorim changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 --- Comment #1 from Pedro Amorim --- Created attachment 152701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152701=edit Bug 34058: WIP Patron search is now considering all inputs using new buildSearchPatronQuery Still missing keyword input -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34122] New: Updating Shelvingloc changes location of all related records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122 Bug ID: 34122 Summary: Updating Shelvingloc changes location of all related records Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Partners have reported that updating the shelving location on one item updates all of the items in the record regardless of their branch location. For example, Branch A has Item A located in the Genealogy department, and Branch B has it in their Reference section. Changing the location in Branch A to Genealogy will also change the shelving location for Branch B to Genealogy even if Branch B doesn't have a Genealogy shelving location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34121] Improve performance of Koha::Plugins::call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34121 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33972 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33972] Possible deadlock in C4::ImportBatch::SetimportBatchStatus from BatchCommitRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33972 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34121 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34121] Improve performance of Koha::Plugins::call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34121 --- Comment #2 from Kyle M Hall --- Created attachment 152700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152700=edit Bug 34121: Do not test plugin ahead of time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34121] Improve performance of Koha::Plugins::call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34121 --- Comment #1 from Kyle M Hall --- Created attachment 152699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152699=edit Bug 34121: Filter enabled plugins for the given method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34121] Improve performance of Koha::Plugins::call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34121 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34121] New: Improve performance of Koha::Plugins::call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34121 Bug ID: 34121 Summary: Improve performance of Koha::Plugins::call Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Koha::Plugins::call() uses get_enabled_plugins to get all enabled plugins, including plugins that do not have the method to be called. In addition, get_enabled_plugins uses can_load to evaluate plugis, but call already uses eval to call methods making the use of can_load and $plugin_class->new() superfluous and wasteful. We should filter out all enabled plugins that do not match the plugin method being called and allow the eval in call() to handle plugin error handling. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Attachment #152684|0 |1 is obsolete|| --- Comment #5 from Pedro Amorim --- Created attachment 152698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152698=edit Bug 34092: Move search-patron.inc logic into buildPatronSearchQuery -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33972] Possible deadlock in C4::ImportBatch::SetimportBatchStatus from BatchCommitRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33972
--- Comment #29 from Nick Clemens ---
We found the issue, it is related to plugins that create their own objects
(Curbside is known offender)
The plugins use a trick:
# register the additional schema classes
Koha::Schema->register_class(CurbsidePickup =>
'Koha::Schema::Result::CurbsidePickup');
Koha::Schema->register_class(CurbsidePickupPolicy =>
'Koha::Schema::Result::CurbsidePickupPolicy');
Koha::Schema->register_class(CurbsidePickupIssue =>
'Koha::Schema::Result::CurbsidePickupIssue');
# ... and force a refresh of the database handle so that it includes
# the new classes
Koha::Database->schema({ new => 1 });
}
That forces a new DB connection - which means the transaction doesn't commit
(the savepoint is released, but it is on a different connection, so moot)
The call:
_after_biblio_action_hooks({ action => 'create', biblio_id => $biblionumber
});
calls:
get_enabled_plugins
which calls:
my $plugin = eval { $plugin_class->new() };
which triggers the new schema/connection
when get_enabled_plugins is cached we call $plugin->can($method) which also
instantiates the plugin/creates new connection
I think the patches on this report still make sense, they remove an unecessary
status change.
We are fixing the plugin, but we probably should update:
https://koha-community.gitlab.io/KohaAdvent/2020-12-07-dbic/
and I think get_enabled_plugins should be using the plugin_methods table to
avoid loading plugins that don't have the method we need?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|22.11 |master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29181] Allow patron card creator to use a report to get list of borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29181 --- Comment #3 from Owen Leonard --- I don't know if this patch satisfies the original intent of the bug, but I hope it will be useful either way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29181] Allow patron card creator to use a report to get list of borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29181 --- Comment #2 from Owen Leonard --- Created attachment 152697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152697=edit Bug 29181: Create patron card creator batch from report result This patch adds the option of taking the results of a report that returns borrowernumbers and create a new patron card creator batch with those results. The logic of the dropdown menu has been modified in order to ensure that duplicate patron modification options aren't shown in the menu when a report return both borrowernumber and cardnumber. To test, apply the patch and create a new report which will return patron borrowernumbers, e.g. SELECT borrowernumber, cardnumber, surname, firstname FROM borrowers order by RAND() LIMIT 20 - Run your report - Click the "Batch operations with..." button at the top of the result - Click "Patron card creator" - A new tab should open with a new patron card creator batch with the patrons from your report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29181] Allow patron card creator to use a report to get list of borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29181 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Sam Lau changed: What|Removed |Added Attachment #152624|0 |1 is obsolete|| --- Comment #9 from Sam Lau --- Created attachment 152696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152696=edit Bug 23775: Claiming a serial issue doesn't create the next one Whenever we need to generate manually a new serial we go to page 'serials-edit.pl'. With this patch it is possible to generate a new serial on page 'serials.pl'. Test Plan: -- Previously we need a serial which is in EXPECTED status & the Date received should not be later than today -- 1) On the intra. Make sure to have at least 1 subscription for a bibliographic record & 1 vendor linked 2) Then Home > Serials > Claims > Claims for 3) Tick the checkbox of the row where the status is EXPECTED then 4) Click 'Send notification' 5) Notice the status of the row : it is now CLAIMED 6) To verify: Home > Serials > Serial collection information for 7) Here the status is CLAIMED too but nothing happened around 8) Apply patch 9) Repeat from 2) to 6) 10) The status is still CLAIMED & the new serial with status EXPECTED is freshly generated Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23775] Claiming a serial issue doesn't create the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23775 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Blocks||34058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 [Bug 34058] ILL - Left filters not considering all terms in input -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 Pedro Amorim changed: What|Removed |Added Depends on||34092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 --- Comment #10 from Martin Renvoize --- https://gitlab.com/koha-community/qa-test-tools/-/issues/68 I'll try to find a moment to have a look at submitting something for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33989] Inventory tool performs unnecessary authorized value lookups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33989 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33989] Inventory tool performs unnecessary authorized value lookups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33989 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33976] Claims returned option is not disabled in moredetail.pl if the item has a different lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33976] Claims returned option is not disabled in moredetail.pl if the item has a different lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Signed Off --- Comment #9 from Martin Renvoize --- I think this all looks solid.. so adding my signoff line. As for catching cases introduced in the future.. perhaps a QA script addition to spot `validation->param` introductions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Martin Renvoize changed: What|Removed |Added Attachment #152214|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 152695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152695=edit Bug 33556: Easy ERM-related changes I left the (easy) ERM cases out because it throws this when running the QA script: Processing files before patches |>| 51 / 51 (100.00%) An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::REST::V1::ERM::EHoldings::Titles::Local': current merge results [ Koha::REST::V1::ERM::EHoldings::Titles::Local, ] merging failed on 'Mojolicious::Controller' at /kohadevbox/qa-test-tools/koha-qa.pl line 112. and didn't want this to pollute the rest of the changes. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556
Martin Renvoize changed:
What|Removed |Added
Attachment #152213|0 |1
is obsolete||
--- Comment #7 from Martin Renvoize ---
Created attachment 152694
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152694=edit
Bug 33556: Avoid relying on $c->validation
Talking to the OpenAPI plugin maintainer, he mentioned the use of
$c->validation->output should be avoided as the plugin is not designed to have
a stable behavior there, and he even thought of just removing the method.
That method returns an internal data structure the plugin uses to validate
things, and then updates the request itself.
Take the following example:
GET /patrons/123
x-koha-embed: checkouts,library
without the OpenAPI plugin, requesting the header like this:
$c->req->headers->header('x-koha-embed')
would return a scalar, the string 'checkouts,library'.
When using the plugin, and with `x-koha-embed` being defined as
collectionFormat: csv, that header is entirely replaced by an arrayref.
That's how the plugin works and how it is expected to be used. So we need to
replace the uses of $c->validation format, with normal Mojo usage to avoid
future headaches.
This patch changes:
* $c->validation->param => $c->param
* $c->validation->param('body') => $c->req->json
To test:
1. Run:
$ ktd --shell
k$ prove t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass!
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Martin Renvoize changed: What|Removed |Added Attachment #152212|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 152693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152693=edit Bug 33556: Path parameters are handled explicitly in the controllers In the case of $c->objects->search_rs, the variable is just not used. In the case of /acq/orders, it's a leftover from when we removed in the helper. Check there are tests with path params everywhere (including orders) and it has no effect. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||martin.renvoize@ptfs-europe ||.com --- Comment #20 from Martin Renvoize --- All working, tests all still passing.. I'm happy with this. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Martin Renvoize changed: What|Removed |Added Attachment #152431|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 152692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152692=edit Bug 33971: Remove x-koha-query header support This patch removes support for the `x-koha-query` header entirely from the codebase. For the purpose: - $c->objects->search is adjusted - Relevant tests are cleared/adapted - The OpenAPI spec gets the header removed To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t \ t/db_dependent/api/v1/*.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Martin Renvoize changed: What|Removed |Added Attachment #152430|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 152691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152691=edit Bug 33971: Remove x-koha-query handing in Orders.pm This patch removes manual handling of `x-koha-query` in the Orders:list() controller. There are no tests for the feature but you can verify no behavior is changed by doing: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33971] Remove support for x-koha-query header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971 Martin Renvoize changed: What|Removed |Added Attachment #152429|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 152690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152690=edit Bug 33971: Remove x-koha-query usage in biblios.t This patch removes handling of x-koha-query from the tests. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Change from x-koha-header to q= gives same results. 4. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33996] Authority objects missing mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33996 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33996] Authority objects missing mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33996 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33996] Authority objects missing mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33996 --- Comment #5 from Martin Renvoize --- Created attachment 152689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152689=edit Bug 33996: (QA follow-up) Fix mappings to match guidelines The date field guidelines are recorded on the wiki: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4.1_date.2Fdatetime.2Ftimestamp_fields Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33996] Authority objects missing mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33996 Martin Renvoize changed: What|Removed |Added Attachment #152341|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 152688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152688=edit Bug 33996: Add missing authority objects mapping This patch adds a minimal mapping (i.e. some things get excluded from the API objects for now). It makes some attributes consistent with the current API names, and the rest can be added later when they become needed and we discuss a proper name. But right now is a mess :-/ To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33999] Subscription details link on bibliographic detail page should have permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 --- Comment #4 from Owen Leonard --- Created attachment 152687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152687=edit Bug 33999: (follow-up) Use link-styled button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33999] Subscription details link on bibliographic detail page should have permission check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33999 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Sam Lau changed: What|Removed |Added Attachment #152478|0 |1 is obsolete|| --- Comment #14 from Sam Lau --- Created attachment 152686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152686=edit Bug 28196: Insert searchid in URL correctly, so it doesn't follow the hash Test plan: 1. Search the catalog in the staff client for anything which will return at least two results 2. Click on any result to go to the bib detail page 3. Click the edit button for any item attached to the bib 4. Verify that the loaded URL contains =scs_(a number), and that the URL ends with #edititem 5. Make any change to the item, save, verify that your change was made Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #16 from Julian Maurice --- Still unsure about comment 14, but either way this patch should fix the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393
Julian Maurice changed:
What|Removed |Added
Attachment #152609|0 |1
is obsolete||
--- Comment #15 from Julian Maurice ---
Created attachment 152685
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152685=edit
Bug 31393: Koha::Config: handle the special case for 'content' attribute
was wrongly parsed as
{ key => 'value' }
whereas it should be
{ key => { content => 'value' } }
The 'content' attribute is used in shibboleth config
Test plan:
1 Run `prove t/Koha/Config.t`
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24608] Allow modification of checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092
--- Comment #4 from Pedro Amorim ---
Test plan to test different patron searches and make sure everything is working
as intended, before and after applying the patch.
Examples of patron-autocomplete.js:
- Patrons lists (create new list, add patrons to it):
/cgi-bin/koha/patron_lists/lists.pl
- View logs ("Librarian:" input):
/cgi-bin/koha/tools/viewlog.pl
- Reserve request:
/cgi-bin/koha/reserve/request.pl
Examples of patron-search.inc:
- ERM, "Add new user" button:
/cgi-bin/koha/erm/agreements/add
- New patron card batch:
/cgi-bin/koha/patroncards/edit-batch.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #10 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #9) > Ping? Working on this right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #26 from Fridolin Somers --- Interresting. Maybe a silly question : why not caching entire Koha::Patron object in CanBookBeReserved/CanItemBeReserve ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 --- Comment #3 from Pedro Amorim --- Created attachment 152684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152684=edit Bug 34092: Move search-patron.inc logic into buildPatronSearchQuery -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 --- Comment #2 from Pedro Amorim --- Created attachment 152683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152683=edit Bug 34092: Preparation: New buildPatronSearchQuery function Move patron search query logic out of patron_autocomplete into new function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 --- Comment #1 from Pedro Amorim --- Created attachment 152682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152682=edit Bug 34092: Move patron_autocomplete to staff-global.js Remove patron-autocomplete.js file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33904] 2FA registration fails if library name has non-latin characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.01 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.01 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34093] jQuery not loading on OAI XSLT pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34093 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.01 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34042] Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin Somers --- Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34022] Adding items on receive is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.01 released in|| --- Comment #21 from Fridolin Somers --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33888] Overdues with fines report displays error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 --- Comment #11 from Fridolin Somers --- (In reply to Laura Escamilla from comment #9) > (In reply to Katrin Fischer from comment #8) > > Can this please be backported for next bugfix releas? No strings! > > > I second Katrin, can this please be backported to 22.11.xx? Indeed it is need for 22.11.x since it contains Bug 22375. Now that I have backported to 23.05 it will come down to 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33888] Overdues with fines report displays error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33888 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.01 released in|| --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33885] Get HTTP 500 when retrieving orders created by a non-existent (deleted) user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33885 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.01 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33976] Claims returned option is not disabled in moredetail.pl if the item has a different lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Working as expected and change makes logical sense. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33976] Claims returned option is not disabled in moredetail.pl if the item has a different lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Martin Renvoize changed: What|Removed |Added Attachment #152345|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 152681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152681=edit Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33989] Inventory tool performs unnecessary authorized value lookups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33989 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- No regressions found and the change makes logical sense. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33989] Inventory tool performs unnecessary authorized value lookups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33989 Martin Renvoize changed: What|Removed |Added Attachment #152343|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 152680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152680=edit Bug 33989: Only look up authorized value descriptions for items in results This patch changes the inventory tool so that it only populates the authorized value descriptions for items that show up in the results. That is, items that will be viewed by a human. This change saves a lot of time by not performing unnecessary database lookups. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to create a SQL report from SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL 2. Save a report with the following SQL: SELECT barcode FROM items where barcode <> ''; 3. Run the report 4. Download as CSV 5. Edit the CSV and remove the "barcode" heading 6. Go to edit item for barcode 30001 /cgi-bin/koha/cataloguing/additem.pl?op=edititem=1=1 7. Add "Damaged status" of "Damaged" 8. Click "Save changes" 9. koha-mysql kohadev 10. update items set notforloan = 9 where barcode = 30001; 11. Go to inventory tool http://localhost:8081/cgi-bin/koha/tools/inventory.pl 12. Upload barcode file via "Choose file" 13. Uncheck "Compare barcodes list to results" 14. Open F12 tools 15. Click "Submit" 16. Click "OK" on confirm box 17. Note that the inventory job takes around 30 seconds to run instead of 60 seconds 17b. The exact figures may vary. If you compare with before patch inventory runs, you'll be saving roughly 18 seconds. 18. Note that "Damaged" appears in the "Damaged" column, which demonstrates that the authorized value lookup was completed for the item in the result list Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #8 from Marcel de Rooy --- Created attachment 152679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152679=edit Bug 23059: (QA follow-up) Put status strings in a span No test plan. Read the patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Attachment #152659|0 |1
is obsolete||
--- Comment #12 from Jan Kissig ---
Created attachment 152678
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152678=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
To Test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another one
from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) execute API calls eg like
PUT /biblios/{biblio_id}/merge/{biblio_id_to_merge}
eg:
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/9;
6) the record with the id is deleted now, the record with
has all items, etc attached, return code is 200, with the message
{"message":"Successfuly merged 9 into 262"}
7) optionally a full MARCXML record may be sent as body of the API call
curl -s -u koha:koha -X PUT
"http://127.0.0.1:8081/api/v1/biblios/262/merge/2; -d @marcfile.xml
8) now also the content of the record with is replaced with the
content of the MARCXML file
9) Sign off.
10) Thx
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: d...@plix.at
Signed-off-by: Jan Kissig
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Clear and working fix, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34005] Toggling the search term highlighting is not always working in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34005 Martin Renvoize changed: What|Removed |Added Attachment #152338|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 152677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152677=edit Bug 34005: Move button toggling code outside JS for loop When OpacHighlightedWords is set to "Highlight", if you search in the OPAC and the number of keywords is odd (1, 3, 5, etc.), then the "Unhighlight" / "Highlight" button will stop working after a couple of clicks. The relevant commit is 9cb89b46397 from v20.11.00, where the code responsible for toggling the "Unhighlight" / "Highlight" button was moved inside the JS for loop that cycles through each term in the array of search terms. This explains why the toggling only works when an even number of search terms is being used. This patch fixes that, by placing the button toggling code in its original position (outside the JavaScript for loop of the highlightOn() function). Test plan: 0) If required, set OpacHighlightedWords to "Highlight". 1) Search for "history" in the OPAC, and view the details page of one of the results. Click on the "Unhighlight" button a few times -- after a couple of clicks the button text will stop toggling and you won't be able to remove the keyword highlight any more. 2) Apply this patch. 3) Repeat step 1): this time you should be able to toggle the search keyword highlighting no matter how many times you click on the "Unhighlight" / "Highlight" button. 4) Repeat step 1), but this time search for "century history": you should be able to toggle search keyword highlighting in the details page on and off repeatedly without any problems. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- Nice cleanup, thanks. Tests all working as expected, simplified and modernised. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 --- Comment #13 from Martin Renvoize --- Created attachment 152676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152676=edit Bug 33778: (QA follow-up) Update for master The error message was updated in master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Martin Renvoize changed: What|Removed |Added Attachment #151497|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 152675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152675=edit Bug 33778: Move to db_dependent Test plan: Run t/db_dependent/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Martin Renvoize changed: What|Removed |Added Attachment #151496|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 152674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152674=edit Bug 33778: Fix indentation of last subtest Only whitespace. Test plan: git diff -w HEAD~1.. t/Auth_with_shibboleth.t No differences. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Martin Renvoize changed: What|Removed |Added Attachment #151495|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 152673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152673=edit Bug 33778: Further polishing Use mock_preference. Move final tests for BaseURLs into one subtest. Change reset_config to allow passing parameters replacing some variables. Copyright line. Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33778] Move t/Auth_with_shibboleth.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33778 Martin Renvoize changed: What|Removed |Added Attachment #151494|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 152672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152672=edit Bug 33778: Remove T::D::C from Auth_with_shibboleth.t This test should be in t/db. It needs patrons, categories, branches. T::D::C now hides e.g. the branchcode constraint. When removing T::D::C, we therefore need to add a branchcode in the shibboleth test config. Test plan: Run t/Auth_with_shibboleth.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
