[Koha-bugs] [Bug 28025] Allow option for when to send autorenew denied/onhold notices

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28025

Katrin Fischer  changed:

   What|Removed |Added

Summary|allow option for when to|Allow option for when to
   |send autorenew  |send autorenew
   |denied/onhold notices   |denied/onhold notices
Version|20.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28024] Remove X-Abuse-Report header adding in opac-sendbasket.pl

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28024

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Katrin Fischer  ---
It looks like we are on longer setting this header, so closing this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28010] add plugin to modify record in "opac-detail.pl"

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28010

--- Comment #3 from Katrin Fischer  ---
(In reply to Mark Hofstetter from comment #2)
> I actually thought about name it recursive/iterate, the implementation
> (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115180) does
> more than mine
> 
> (it changes the input, but with the name containing "recursive" that's ok)
> 
> so I think we are settled on this

Can this be closed with bug 26351 in Koha?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28008] Patron clubs bulk enrollment

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28008

Katrin Fischer  changed:

   What|Removed |Added

Version|20.05   |master
Summary|Patron Clubs Bulk   |Patron clubs bulk
   |Enrollment  |enrollment

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

--- Comment #9 from Phil Ringnalda  ---
Filed bug 34182 for removing the bogus code, though that won't help here since
the damage has already been done to existing installations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34182] New: AddBiblio shouldn't set biblio.serial based on biblio.seriestitle

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34182

Bug ID: 34182
   Summary: AddBiblio shouldn't set biblio.serial based on
biblio.seriestitle
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: p...@chetcolibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: katrin.fisc...@bsz-bw.de, m.de.r...@rijksmuseum.nl

Back in the 3.0 days, in
https://git.koha-community.org/Koha-community/Koha/commit/af466ca41ab02150f4f6c60bf6262b079b2e6e85
someone looked at the dead code in
https://git.koha-community.org/Koha-community/Koha/blame/commit/c6013f3fd09ac5bd02f31e86bcc932c265c58502/C4/Biblio.pm#L3288

my $series   = 0;

if ( $biblio->{'seriestitle'} ) { $series = 1 }

which did nothing because there wasn't any biblio.series for $series to be
setting (maybe there had been at one time, maybe it was always dead code,
dunno), and decided to "fix" it by changing it to

   # set the series flag
my $serial = 0;
if ( $biblio->{'seriestitle'} ) { $serial = 1 };

which turned it into actively wrong code, overriding someone actively setting
serial with whether or not it had a series title. A few years later, someone at
least let setting something mapped to biblio.serial cause biblio.serial to be
set, while leaving the bogus setting of it based on seriestitle still there if
serial wasn't already set.

The added comment "# set the series flag" makes it clear that it wasn't done
out of any belief that seriestitle implies serial, only thinking that serial
was how you spell "has a series."

As bug 34128 will tell you, it isn't. And since CheckPrevCheckout uses
biblio.serial to only warn people if they have previously checked out a
particular copy of People Weekly rather than warning them that they checked out
last week's issue so they don't want this week's issue, had it noticed that as
a result of seriestitle -> serial it doesn't warn people who've checked out
copy 1 of the 62nd Stone Barrington novel that they probably don't want to
check out copy 2, CheckPrevCheckout would also tell you that it isn't.

For comic relief, AddBiblio only sets biblio.serial the first time that you
save a biblio which has a seriestitle. If you edit the biblio again, ModBiblio
unsets it, so it's both wrong and incapable of making its wrongness stick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

--- Comment #8 from Phil Ringnalda  ---
Oy. It hasn't been that way for over 17 years, it's been that way for 16 years,
since
https://git.koha-community.org/Koha-community/Koha/commit/af466ca41ab02150f4f6c60bf6262b079b2e6e85
looked at the pointless code that was

my $series   = 0;

if ( $biblio->{'seriestitle'} ) { $series = 1 }

and said "well, $series is unused, there's no biblio.series for it to set, but
serial is just two letters differnt than series so they must have meant

# set the series flag
my $serial = 0;
if ( $biblio->{'seriestitle'} ) { $serial = 1 }
"

so this whole stupid thing is because someone looked at dead code and instead
of deleting it, made it do something very wrong instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

--- Comment #7 from Phil Ringnalda  ---
By default, UNIMARC maps biblio.serial to both 099$s and 942$s, neither one
editable by default, and maps biblio.seriestitle to nothing at all. So in
UNIMARC you only get biblio.serial if you either make one of the $s subfields
editable, or you map biblio.seriestitle to something thinking that doing so
will do you some good.

I can agree that being a volume in a series has no relationship whatsoever to
being a serial, if that helps. According to the first session in
https://www.loc.gov/catworkshop/courses/naco-full%20series-RDA/course%20table.html
in 2013 when they last updated their numbers, 89.4% of the series headings in
the LC/NACO name authority database were monograph series ("Annual report of
the tin production in Moldavia"), and monograph series are serials by
definition, unlike multipart monograph series ("Continents of the world") that
have a fixed ending. So I can't agree that "a volume in a series is not a
serial," only that "a volume in a series either is or is not a serial."

I would sign off a patch that removes setting biblio.serial based on
biblio.seriestitle in a heartbeat. More than a heartbeat: it's only set in
AddBiblio, not ModBiblio, so you have to have a seriestitle when you first save
a record to have serial set.

Even better, ModBiblio actually gets rid of it. The first time you save a
biblio without a seriestitle, serial is set to 0, but if you save it again it
is reset to null; the first time you save a biblio with a seriestitle, serial
is set to 1, but if you save it again it is set to null, making the whole
seriestitle -> serial thing useless.

Workaround for Matt's clients who are annoyed by unsorted items from a 490
existing: edit the biblio and save it without making any changes. Poof, no
longer a serial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] New: Batch Patron Modification Tool missing checkboxes to clear field values

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

Bug ID: 34181
   Summary: Batch Patron Modification Tool missing checkboxes to
clear field values
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: catr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 152920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152920&action=edit
22.05 Batch Patron Modification Tool with Checkboxes

When using the batch patron modification tool in 22.05, you could select one of
the boxes to the right of the field to clear the value. The instructions for
this feature are in 22.11, but the checkboxes and functionality is missing. See
attached screenshots for examples.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34107] Sorting agreements by Name actually sorts by ID

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

--- Comment #2 from Michal Denar  ---
Any test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33863] On receive "change currency" is always checked

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #688 from Michal Denar  ---
Any news?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34142] Add column sub_location to items table

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142

--- Comment #1 from Katrin Fischer  ---
Can you explain how sub_location, location and permanent_location would relate
to each other?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

--- Comment #6 from Katrin Fischer  ---
I believe that mapping seriestitle probably made sense in UNIMARC as the serial
flag seems to stem from there. It would be interesting to see what is mapped in
UNIMARC and if that makes more sense.

Can we agree that a volume in a series is not a serial?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript triggers error when showing authority MARC preview

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript triggers error when showing authority MARC preview

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #152918|0   |1
is obsolete||

--- Comment #2 from Phil Ringnalda  ---
Created attachment 152919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152919&action=edit
Bug 34180: Template variable in JavaScript prevents authority MARC preview from
displaying

Since template variables cannot be processed by JS, we must use a
template to declare a JS variable which the JS file can used. This patch
corrects this problem in the JS file which handles display of the
authority MARC preview from the authority search results page.

To test, apply the patch and go to Authorities.

- Perform a search which will return multiple authority results.
- Click "Actions -> MARC preview." The preview should display correctly.
- Click "Actions -> MARC preview" on another search result. This preview
  should also look correct.
- There should be no JavaScript errors in the browser console.

Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript triggers error when showing authority MARC preview

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Phil Ringnalda  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34179] Make authority MARC preview look like bibliographic MARC preview

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34179

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

--- Comment #1 from Owen Leonard  ---
The "plain" MARC preview which you can trigger from, for example, the
bibliographic detail page, depends on XML data which is being formatted by an
XSLT file, plainMARC.xsl. That file *might* be generic enough to pass an
authority record to, but the supporting script, catalogue/showmarc.pl, needs to
have authority record handling added.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript triggers error when showing authority MARC preview

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Owen Leonard  changed:

   What|Removed |Added

Summary|Template variable in|Template variable in
   |JavaScript prevents |JavaScript triggers error
   |authority MARC preview from |when showing authority MARC
   |displaying  |preview

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript prevents authority MARC preview from displaying

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

--- Comment #1 from Owen Leonard  ---
Created attachment 152918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152918&action=edit
Bug 34180: Template variable in JavaScript prevents authority MARC preview from
displaying

Since template variables cannot be processed by JS, we must use a
template to declare a JS variable which the JS file can used. This patch
corrects this problem in the JS file which handles display of the
authority MARC preview from the authority search results page.

To test, apply the patch and go to Authorities.

- Perform a search which will return multiple authority results.
- Click "Actions -> MARC preview." The preview should display correctly.
- Click "Actions -> MARC preview" on another search result. This preview
  should also look correct.
- There should be no JavaScript errors in the browser console.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript prevents authority MARC preview from displaying

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] New: Template variable in JavaScript prevents authority MARC preview from displaying

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Bug ID: 34180
   Summary: Template variable in JavaScript prevents authority
MARC preview from displaying
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

authorities-detail-modal.js has template variables in it:



We need to define variables in a Template Toolkit-processed file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34068] Dropdown selector when changing pickup library should not depend on RESTdefaultPageSize

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34068] Dropdown selector when changing pickup library should not depend on RESTdefaultPageSize

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34068

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
Summary|Dropdown selector when  |Dropdown selector when
   |changing pickup library is  |changing pickup library
   |buggy   |should not depend on
   ||RESTdefaultPageSize
 Resolution|WORKSFORME  |---

--- Comment #3 from Katrin Fischer  ---
It does solve it, but I think the dependency is not good - we should keep this
open and look into changing the behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

--- Comment #19 from Owen Leonard  ---
I was curious about this so I thought I'd rebase it and make a few minor
corrections just to get it back in play.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34179] New: Make authority MARC preview look like bibliographic MARC preview

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34179

Bug ID: 34179
   Summary: Make authority MARC preview look like bibliographic
MARC preview
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: heather_hernan...@nps.gov
QA Contact: testo...@bugs.koha-community.org

Starting with 22.11, the MARC preview of auts is very different from the MARC
preview of bibs.  When displaying aut search results, the user can select for a
particular aut record:
Actions
MARC preview

And what appears seems to be a compilation of the tabbed display with all the
MARC labels, e.g., "455 ## - SEE FROM TRACING--GENRE/FORM TERM" included.  So
it's not really a MARC preview--it's a repeat of the tabbed display assembled
into one window.

Since the MARC tag labels are already there for authorities in the tabbed
display (like the MARC tag labels are present in the OPAC "MARC view"), they
are already present for anyone wanting a MARC display with textual field
labels.  An unlabeled display for auts doesn't really exist, and it would be
great if the "MARC preview" for auts was the unlabeled MARC display available
for staff, just like the MARC preview for bibs is a unlabeled MARC display.

I really want a way to see an unlabeled MARC aut record in one screen—to be
able to look at it, read it, etc., quickly.  There is currently no way to do
that, and I think having the MARC preview repeat all the tag/field labels that
are already present in the regular display is redundant.  I would love​ for the
aut MARC preview to be exactly the same as the bib MARC preview, so there is a
way for catalogers to quickly see an unlabeled MARC record that they can
examine, scan, read, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

--- Comment #18 from Owen Leonard  ---
Created attachment 152917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152917&action=edit
Bug 29825: (follow-up) Some style fixes and modal correction

This patch makes a few coding style changes to the new JavaScript and
updates the Bootstrap modal markup to be in line with current standards.

The previous patches lacked a trigger for the preview modal, so I added
that. Since the content of the modal uses spaces for formatting I added
monospace formatting to the modal body.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

--- Comment #17 from Owen Leonard  ---
Created attachment 152916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152916&action=edit
Bug 29825: Preview of authority record on edit mode as MARC formatted view

A new file for modal view of result added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

Owen Leonard  changed:

   What|Removed |Added

 Attachment #140185|0   |1
is obsolete||
 Attachment #140186|0   |1
is obsolete||

--- Comment #16 from Owen Leonard  ---
Created attachment 152915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152915&action=edit
Bug 29825: Preview of authority record on edit mode as MARC formatted view

This bug adds a new functionality on Edit mode of a new or existing authority.
Add a new button 'MARC Preview' in order librarian have the ability to preview
the record on MARC plain structure mode and have all fields and subfields
that entered before save/update the record.

To test:
1. Open or add an authority
2. The preview button isn't on toolbar
3. Apply the patch
4. Do step 1
5. The preview button exists
6. Do some changes or not to the authority record
7. Click to Preview MARC button and a modal window will appear with all fields
   indicators and subfields that filled in the form of cataloguing.

Mentored by: Andreas Roussos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

--- Comment #8 from Katrin Fischer  ---
Thank you for the feedback Heather!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33746] [omnibus] speed improvement

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746

Nick Clemens  changed:

   What|Removed |Added

 Depends on||34178


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178
[Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to
IsAvailableForItemLevelRequest
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

Nick Clemens  changed:

   What|Removed |Added

 Blocks||33746


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746
[Bug 33746] [omnibus] speed improvement
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com,
   ||k...@bywatersolutions.com,
   ||sama...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

--- Comment #2 from Nick Clemens  ---
Created attachment 152914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152914&action=edit
Bug 34178: Adjust tests

We need to clear the cache when changing rules/statuses

To test:
1 - prove -v t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

--- Comment #1 from Nick Clemens  ---
Created attachment 152913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152913&action=edit
Bug 34178: Cache ItemsAnyAvailableAndNotRestricted in memory and don't
precalculate

There are several places in the code where we precalculate
ItemsAnyAvailableAndNotRestricted to avoid
looping on this routine when calling IsAvailableForItemLevelRequest on a list
of items form a biblio

The value of ItemsAnyAvailableAndNotRestricted is only used when there is a
circulation rule for
'onshelfholds' with a value of '2' (If all unavailable)

Rather than calculate a value that may never be used, let's cache this value
per request when we do
calculate it - and reuse the cached value

To test:
 1 - Apply patch
 2 - Set circulation rule 'On shelf holds allowed' as 'If all unavailable'
make sure the rule applies to all of the items/patrons you test with
 3 - Find a record with two items that are available
 4 - Try to place a hold for a patron - not allowed
 5 - Check out one item to another patron
 6 - Attempt hold - still not allowed
 7 - Check out second item to another patron
 8 - Attempt hold - allowed!
 9 - Apply patch
10 - Cancel and replace hold - it is allowed!
11 - Check in one item, and cancel hold
12 - Place hold - not allowed!
13 - Check in second item
14 - Place hold - not allowed!
15 - prove -v t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34178] New: Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

Bug ID: 34178
   Summary: Add caching of ItemsAnyAvailableAndNotRestricted to
IsAvailableForItemLevelRequest
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

There are several places in the code where we precalculate
ItemsAnyAvailableAndNotRestricted to avoid looping on this routinee when
calling IsAvailableForItemLevelRequest on a list of items form a biblio

The value of ItemsAnyAvailableAndNotRestricted is only used when there is a
circulation rule for 'onshelfholds' with a value of '2' (If all unavailable)

Rather than calculate a value that may never be used, let's cache this value
per request when we do calculate it - and reuse the cached value

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34177] New: Call number browser is not opening in new window

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34177

Bug ID: 34177
   Summary: Call number browser is not opening in new window
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The call number browser is not opening in a new pop-up window as expected. This
causes an issue in workflow whenever a library uses it because submitting a
search will cause the Koha navbar and header_search to disappear. 

/cgi-bin/koha/cataloguing/plugin_launcher.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16665] Add a staffadmin bar to the opac interface in order to edit the previewing record (MARC)

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16665

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #2 from Heather  ---
I would love this!  I would love something like this because my coworkers come
to me with a problem, and I have to use the OPAC to see what they're seeing--it
would save me time if I could:
Go to OPAC
Log in
A Staff Admin bar/button/thingy appears
Search and see what everyone else sees, search the way they're searching
Notice problem(s)!
--Select Staff Admin bar/button/thingy
--Fix record(s)
Accept gratitude from coworkers!!
Bow humbly.

For other workflows, I could go to Staff Client and work magic, as usual.  But
some sort of Staff admin bar/button/thingy that would allow me to get into
editing bibs & items from the OPAC would be awesome!
--h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34176] New: Don't autoload checkouts table when confirming circulation of items with additional materials

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34176

Bug ID: 34176
   Summary: Don't autoload checkouts table when confirming
circulation of items with additional materials
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When an additional materials dialog is displayed, it can delay a librarian to
the point where the loading delay from bug 33945 doesn't help. It makes sense
in this case to simply not auto-load the checkouts table, but leave the button
for manual loading of the table available.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029

--- Comment #22 from Katrin Fischer  ---
I think it was me after all, thx for catching it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33997] Borrowers.updated_on should not be updated by track_login

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997

--- Comment #8 from Katrin Fischer  ---
I have to admit I had the same feeling as Marcel when I saw this bug. Moving to
a separate table seems a bit of overkill. 

What is the use case that triggered this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30131] Centralize "MARC preview" buttons and links

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30131

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #4 from Heather  ---
Would this make the MARC previews in bibs and auts the same?  With 22.11, the
authority MARC preview is just a repeat of the labeled display in one
screen--it's not a clean, unlabeled MARC preview like the bib MARC preview.  Or
is making the aut MARC preview look like the unlabele, bib MARC preview a
separate bug (which I could create)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34175] New: Unable to delete certain tags in basic editor

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34175

Bug ID: 34175
   Summary: Unable to delete certain tags in basic editor
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When editing a biblio in the basic editor, it is not possible to delete certain
tags. It is possible to delete subject tags such as 600, 650, etc. But it is
not possible to delete a blank 007 despite the icon for delete tag being
present. If leaving a blank tag has no impact, then the delete tag icon should
be removed. Otherwise, the delete tag ability should be enabled. It is
confusing for it to be present if the tag should not be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

--- Comment #7 from Heather  ---
Hi, Katrin!  My issue is clearly bug 34157--my settings were on "Bibliographic
data precedes barcode" for my barcode range, and when I changed that to print
the barcode only, everything worked.  (It was like that because I was
experimenting with trying to get the library name printing on the barcode, then
I found out about bug 31507, and hadn't changed the setting back.)

I'm not sure if this is the same problem that stdominic.novices was having!
--h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33872] Duplicated patron's registration date is set to expiration date of template patron

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33872

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34117

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33872

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847

--- Comment #9 from Katrin Fischer  ---
So does this mean we need to find a way to do the fix only using SQL?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33800] Error 500 in issues_stats.pl

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33800

--- Comment #6 from Katrin Fischer  ---
You might see bug 34063 which left the paidfor in one of the tables in some
cases. If you delete it, things should work ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716

--- Comment #49 from Katrin Fischer  ---
Thank you, Nick :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028

--- Comment #68 from Martin Renvoize  ---
OK, well that may be the case.. but you'll need to also undo the first patch
here as that make it expect bon decimal dot

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33893] Use template wrapper for tabs: OPAC checkout history

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33893

Owen Leonard  changed:

   What|Removed |Added

 Attachment #151995|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 152912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152912&action=edit
Bug 33893: Use template wrapper for tabs: OPAC checkout history

This patch updates the OPAC checkout history page so that it uses
the new WRAPPER syntax to generate tabs markup.

This patch also updates tab WRAPPER directives in html_helpers.inc to
allow us to pass a custom id for tab links in situations like this one
where we have multiple tabs requiring unique IDs but they all point to
the same panel.

To test, apply the patch and make sure the OnSiteCheckouts system
preference is set to "disabled."

- Log into the OPAC as a patron with checkouts.
- View the checkout history page. The checkout history information
  should be displayed without any tabs.
- Enable the OnSiteCheckouts system preference and if necessary check
  out some on-site checkouts to your patron.
- On the OPAC history page there should now be three tabs: All,
  Checkouts, and On-site checokuts.
  - Switching between the tabs should filter the table accordingly.
- Test that the changes to the tab wrapper have not broken tabs on other
  pages, e.g. bibliographic details or user summary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33893] Use template wrapper for tabs: OPAC checkout history

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33893

Owen Leonard  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028

--- Comment #67 from Katrin Fischer  ---
I feel like we moved into contrary directions:

I tried to restore the former behaviour. Koha expects us to enter monetary
amounts with decimal dot everywhere, so I was trying to get back to this here.
I'd like to see input formats fixed, but I feel that a bugfix that needs to go
back into stables is the wrong place. I used the same pattern that we agreed on
and use in patron accounting and removed the Price TT filters to make sure we
get back to decimal dot everywhere, giving up the display in favor of having
the input fixed.

I believe Martin tried to allow entering with decimal comma with his patches,
which appears more risky to me. Also: how to communicate that this page expects
different input than anywhere else?

I might be mistaken - I need to take a closer look for sure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32542] Coce images not appearing in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542

Katrin Fischer  changed:

   What|Removed |Added

Summary|Coce images not appearing   |Coce images not appearing
   |in staff client |in staff interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31498] Allow for custom primary contact method values

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498

--- Comment #17 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #15)
> I see why y'all feel this should be completely arbitrary values: because it
> is only used for display purposes.
> 
> The catch is this options:
> 
> * phone
> * phonepro
> * mobile
> * email
> * emailpro
> * fax
> 
> refer to real `borrowers.*` columns, so my fear is at some point someone
> will want to tie the *selected prefered contact method* value on that
> column, to a real behavior/function in Koha.
> 
> So, thinking in advance, I feel like the current options should be presented
> a system-defined, which can also be disabled, and then we allow users to
> define their own.
> 
> 'Do not contact' should be a default system option (value NULL).
> 
> One drawback for this particular implementation is the contact methods are
> translatable (templates) right now. Moving them to the AV table will make
> them not-translatable or have every non-english install need to manually
> tweak the introduced AVs.

+1 

I've had the same feeling looking at this and I think it's a good idea. If
people want to hide some entries, which makes sense as we allow to hide any
patron field, we could inherit that from BorrowerUnwantedFields maybe or have a
separate visibility setting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

--- Comment #6 from Katrin Fischer  ---
I just tested the table printing in 22.11.05 both for patron records and
barcode labels and they both printed ok. I am wondering what the issue could
be. 

It makes me think it could be either a configuration or a server setup issue.

Heather and Manos, when you open the downloaded PDF in a text editor, is there
any error printed inside?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31009] Claims list on serials is too slow with many existing late issues

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31009

Katrin Fischer  changed:

   What|Removed |Added

Summary|Claims list take too much   |Claims list on serials is
   |times (timeout when you |too slow with many existing
   |have so many claims) on |late issues
   |serials |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732

--- Comment #1 from Owen Leonard  ---
Created attachment 152911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152911&action=edit
Bug 29732: Check alert in cataloguing authorities should be a static message

This patch modifies the authority record editor so that form
validation errors are collected in a static "dialog" at the top of the
page instead of showing in a transient JavaScript alert.

The text of the message is roughly the same as it was in the alert, and
links have been added so that the user can click to jump directly to the
field referenced.

If the user scrolls down away from the static error message, a button
appears in the floating toolbar to jump back to the message.

- Go to Authorities and create a new authority record using a framework
  which has multiple mandatory fields defined
  (e.g. an unmodified default framework)
- Without entering anything in mandatory fields, click the "Save"
  button.
- You should see a message box appear at the top of the page.
  - It should list each missing mandatory subfield and tag, each with a
"Go to field" link next to it.
  - Clicking the "Go to field" link should switch you to the correct tab
and scroll the mandatory field into view.
- When you have scrolled down far enough for the error messages to be
  offscreen, an "Errors" button should appear in the floating toolbar.
  Clicking it should scroll the box back into view.
- If you fix some but not all of the missing mandatory fields the
  message should update with only the current issues.
- Confirm that the record saves when all issues are resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34170] Ability to add record/order line specific credits

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34170

--- Comment #2 from Caroline Cyr La Rose  ---
Created attachment 152910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152910&action=edit
Credit in acq tab

Katrin, here's the screenshot of the credit in the acq tab in the catalogue
module.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep Local Use count

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #37 from Katrin Fischer  ---
Hi Lucas, I am having the same issue as Emily on current master:

Applying: Bug 16122: Add display to holdings/otherholdings and Table settings
Using index info to reconstruct a base tree...
M   admin/columns_settings.yml
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging admin/columns_settings.yml
Applying: Bug 16122: Increment localuse when checking out to stats patron
error: sha1 information is lacking or useless (C4/Circulation.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 16122: Increment localuse when checking out to stats
patron
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-16122-Increment-localuse-when-checking-out-to--o5eeizs8.patch


We might be missing something that is in your repository.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387

Katrin Fischer  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #6 from Katrin Fischer  ---
*** Bug 13556 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13556] Undo Item deletion

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13556

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 17387 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

--- Comment #3 from Katrin Fischer  ---
Thank you, Phil!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Michaela Sieber  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #138205|0   |1
is obsolete||

--- Comment #7 from ByWater Sandboxes  ---
Created attachment 152909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152909&action=edit
Bug 31253 - Item search in staff interface should call barcodedecode if the
search index is a barcode

We should run any inputted barcode through barcodedecode before passing it to
any subroutines.
This was missed during the initial development of bug 26351.

Test Plan:
1) Set itemBarcodeInputFilter to "Remove spaces from"
2) Create an item with the barcode "MYTEST"
3) Browse to the staff side advanced search
4) Run a barcode search for "MY TEST"
5) Note no results are round
6) Apply this patch
7) Restart all the things!
8) Repeat your search
9) Note the item was found!

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12968] "Lock budget" doesn't seem to work as described

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12968

--- Comment #3 from Caroline Cyr La Rose  ---
I changed the definition in the manual

https://gitlab.com/koha-community/koha-manual/-/merge_requests/699/diffs?commit_id=47e8601c5c970c4c6d2e9a29126d9506a3752018

Maybe it will clear up the confusion...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #152906|0   |1
is obsolete||

--- Comment #2 from Phil Ringnalda  ---
Created attachment 152908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152908&action=edit
Bug 29471: Add display of MARC 520 to staff interface detail page

At the moment 520 only displays in the OPAC. With this patch it
also displays in the staff interface detail page.

To test:
* Find a record with 520 or add some 520 entries to a record
  Note: different ind. 1 values will result in different labels
* View the record in the staff interface and the OPAC
* Verify only the OPAC shows the 520 entries
* Apply patch
* Verify now the staff interface displays them as well

Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

Phil Ringnalda  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34163] CSRF error if try OAuth2/OIDC after logout

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34163

Katrin Fischer  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Michael Hafen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Michael Hafen  changed:

   What|Removed |Added

 Attachment #151647|0   |1
is obsolete||

--- Comment #34 from Michael Hafen  ---
Created attachment 152907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152907&action=edit
Bug 18855: Don't create duplicate overdue fines if an issue  is returned

[rebase 2023-06-25]
[
  QA followup:
  I removed the first due date check, but left the issue object check.  Seemed
like the right thing to do.
  I added a $counted decrement since the iteration is getting skipped before
the fine is updated
]

This includes Jonathan's followup

If cronjobs/fines.pl is running during circulation hours, then an issue may
be considered for having it's overdue fine updated after the issue has been
returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'.  In
this case UpdateFine will create a duplicate fine because it can't find the
specific accountline for the (formerly) overdue issue.

This changes cronjobs/fines.pl to double check the issue before updating
the fine.  If the issue has changed between starting the script and updating
the fine, then the script will skip it.

There is a small amount of time between the check and calling UpdateFine
where the issue can be changed and this problem can reoccure.  The chance
of that happening is so small that it's probably fine to leave as is.

It is also possible that the fine won't be updated because the issue was
returned.  In this case the fine payed by the patron will be lower, but that
is better then the patron finding later that there is more to a fine they
thought they had paid all of.

Test plan (by Caroline):
0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
1.1.1. Go to Administration > Global system preferences
1.1.2. Search for BatchCheckouts
1.1.3. Set BatchCheckouts to Allow
1.1.4. Select all categories in BatchCheckoutsValidCategories
1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
1.2.1. Go to Reports
1.2.2. Click "Create from SQL"
1.2.3. Give the report a name
1.2.4. For the SQL query, enter

   SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

1.2.5. Click "Save report"
1.2.6. Click "Run report"
1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
1.3.1. Go to Patrons
1.3.2. Click on "Search"
1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
1.4.1. Click on the "Batch check out" tab on the left
1.4.2. In "Use a file", click "Choose file"
1.4.3. Choose the file downloaded from the report
1.4.4. In "Hard due date", choose a date in the past
1.4.5. Click "Check out"
1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

./misc/cronjobs/fines.pl

   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

4.1. Click on the patron's name in the check in screen
4.2. Go to the Accounting tab on the left
4.3. In the search box just above the table, paste in the returned item's
barcode

--> Without the patch, there are two fines, one Fine (Accruing) and one
Fine (Returned) for the same item at the same time
--> With the patch, there is only one fine, Fine (Returned)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-communit

[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #40 from Owen Leonard  ---
I could see us using a Bootstrap Collapse to show the options, with the "next
available" section displayed by default.

I could also see us keeping this version with the addition of making sure that
all form fields are disabled when the section isn't "active." We could even set
the opacity of the inactive fieldsets to .5 or something like that in order to
indicate that the controls are not available.

I find that the pickup location dropdowns are not populating, and the form
doesn't prevent me from placing the hold without selecting one. That must be
resolved.

I agree that a more detailed test plan would be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34174] Saving RIS results to Error 505

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174

Eugene Espinoza  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34174] New: Saving RIS results to Error 505

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174

Bug ID: 34174
   Summary: Saving RIS results to Error 505
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: eugen...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

When exporting records to RIS in the OPAC as well as in the administration
panel, it results to Error 505.
In plack-opac-error-log, we are getting this error: 
[2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at
/usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 166.
[2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at
/usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 179.
[2023/06/30 22:30:04] [WARN] seek() on closed filehandle _GEN_51 at
/usr/share/perl5/CGI/Emulate/PSGI.pm line 34.

Also in plack-intranet-error-log, when trying out to export to RIS a particular
record:
[2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at
/usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 84.
[2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at
/usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 87.
[2023/06/30 22:29:21] [WARN] seek() on closed filehandle _GEN_38 at
/usr/share/perl5/CGI/Emulate/PSGI.pm line 34.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34173] New: Imported items do not require home/holding branches, causing uneditable item records

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34173

Bug ID: 34173
   Summary: Imported items do not require home/holding branches,
causing uneditable item records
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In some configurations, importing items through the stage/import workflow
causes items to be created that have no home or holding branch. The mandatory
settings are not enforced through the frameworks, so these items can come in
without a home and holding branch, leading to no staff having the ability to
edit these records. Fixes must be made in the database to update these items. 

For some libraries adding a marc modification template to add the branch could
be a workaround. For systems with many branches and tightly controlled rules
about who can edit items, this bug can lead to uneditable items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26862] MARC 530 is missing a descriptive label in the OPAC

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
Summary|MARC 530 is missing a   |MARC 530 is missing a
   |descriptive lavel in the|descriptive label in the
   |OPAC|OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

--- Comment #1 from Katrin Fischer  ---
Created attachment 152906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152906&action=edit
Bug 29471: Add display of MARC 520 to staff interface detail page

At the moment 520 only displays in the OPAC. With this patch it
also displays in the staff interface detail page.

To test:
* Find a record with 520 or add some 520 entries to a record
  Note: different ind. 1 values will result in different labels
* View the record in the staff interface and the OPAC
* Verify only the OPAC shows the 520 entries
* Apply patch
* Verify now the staff interface displays them as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29471] MARC21: 520 - Summary etc. doesn't display in staff interface

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

--- Comment #145 from Katrin Fischer  ---
Just a note: JavaScript code from the test plan needs to have its quotes fixed
in order to work:

(function() { 
console.log('Hello from test1'); 
document.cookie = "test1=testing; domain=localhost; path=/; SameSite=None;
Secure"; 
})();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Katrin Fischer  changed:

   What|Removed |Added

 CC||m...@software.coop

--- Comment #144 from Katrin Fischer  ---
*** Bug 8155 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8155] Comply with UK Electronic Commerce (EC Directive) Regulations 2002

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8155

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 27378 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34172] Ability to search item records by biblionumber

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34172

--- Comment #1 from Katrin Fischer  ---
Hi Laura, you should be able to add it to item search through the additional
item search fields configuration in administration if that helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34172] New: Ability to search item records by biblionumber

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34172

Bug ID: 34172
   Summary: Ability to search item records by biblionumber
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Add the ability to search for item records by biblionumber to the navbar, in
the advanced search filters, and in the item search. 

Currently, the only way to search for items by biblionumber is by using the
"sn:" shortcut, and adding this feature would improve library workflows.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34170] Ability to add record/order line specific credits

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34170

--- Comment #1 from Caroline Cyr La Rose  ---
Here is the procedure I give my clients for handling returned items in
acquisitions.
https://inlibro.com/knowledge-base/ajouter-un-credit-pour-un-document-retourne/

Basically, make an order, but with a negative price. As far as I can tell, it
correctly "returns" the money in the chosen fund once the item is "received",
and the minus sign is displayed. It also keeps the credit information in the
acquisitions tab in the catalog module, so you know you returned that title. I
just tested it in master and it's working.

It's logical, but I find it's a lot of steps to return an item. When I used to
do acquisitions, returning items would be something that I did often, for a
variety of reasons (however, I used good old spreadsheets to manage my
acquisitions as our system didn't have the acquisitions module activated).

If we're to add this feature, I would think differently about how to go about
it. For example, skip the whole create basket/close basket/receive item
process, and simply add the ability to add a credit from the vendor page (New >
Credit). Then either choose to add an arbitrary amount, or choose an
ordered/received item to credit.

Or, add a button to add a credit next to the order (with the soon-to-be-added
*wink wink* cancel button from bug 33664 :D ).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31253] Item search in staff interface should call barcodedecode if the search index is a barcode

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Kyle M Hall  ---
(In reply to Emmanuel Bétemps from comment #5)
> No results match your search for 'bc,wrdl: "MY TEST"'.

That is not a valid test. This patch is about item searching ( itemsearch.pl )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #143 from Katrin Fischer  ---
Overall this is mostly small stuff, apart from 9) maybe!

We'll also need some good documetnation, but the test plan in comment 121 is a
good start.

1) Perltidy

Should we perltidy the new files at least? 

2) System preferences - sysprefs.sql

sysprefs.sql is supposed to be alphabetic (being a librarian, this is not
acceptable! ;) )

 ('ConfirmFutureHolds','0',...
+('CookieConsentedJS', '', NULL, 'Add ...
 ('ConsiderOnSiteCheckoutsAsNormalCheckouts',...
 ('ContentWarningField', '',...
+('CookieConsent', '0', NULL...

3) System preferences - YAML

a)
+ - pref: CookieConsent
+   choices:
+   yes: Require
+   no: "Don't require"
+ - cookie consent to be displayed

Should be 1 and 0. (blocker)

Should we rephrase a bit?

... cookie consent to be displayed in the OPAC and staff interface.

Question: Could it be interesting to make this OPAC only in the future?

b) Add Javascript code that will run if cookie consent is provided (e.g.
tracking code).

Should we rephrase this a little?

Run the following JavaScript if cookie consent was provided (e.g. tracking
code):


3) Add to cookie documentation please 

https://wiki.koha-community.org/wiki/Use_of_Cookies 

For OPAC and staff interface.


4) Translatability (blocker)

  'Delete' +


5) Test plan and comments

Giving that this is an old development there are quite some inconsistencies in
what is the final product and what is mentioned in the commit messages. Like we
started out with 4 prefs and now 2 are HTML customizations. Some squashing and
clean-up could be really helpful I think.

But: great updated test plan in comment 121 !

6) Display issues

a) In the OPAC, the cookie banner overlaps and blocks access to the language
selection at the bottom. If you have them at the top too, that's ok, but some
libraries prefer one over the other ( OpacLangSelectorMode  = only footer ).

b) In the staff interface we have the language chooser in front, cutting off a
bit of the "Accept all cookies" button.

c) In the OPAC readability (font color and size) is good, but in the staff
interface it's much less readable. 


7) Patron account  

a) It doesn't appear to be possible to revoke the general cookie consent?

b) The contrast on the yellow "Accept selected non-essential" cookies seems bad
(greyish font color on yellow background)

c) Should the button read "View and update..."?

d) I cannot close/cancel the modal without making a change. Clicking outside,
pressing ESC, nothing works. We shoudl have a "Cancel" link. This is also true
when using the "your cookies" link for a non-authenticated user.


8) Visibility OPAC/staff 

a) I checked one of the cookies for only OPAC and one only for staff interface.
I still see all 3 cookies in the pop-up in both OPAC and staff after clearing
local storage.

b) This might be related: test2 is my "staff only" cookie. It's unchecked in
the view, but it still gets added every time I refresh any OPAC page.
Same for my "opac only" cookie: it's always added in staff interface on page
reload.

c) Where can staff view and alter their cookie consents?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578

Stephanie Etallaz  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||stephanie.etallaz@univ-cote
   ||dazur.fr

--- Comment #23 from Stephanie Etallaz  ---
CONFLICT (rename/rename): Rename
"koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js"->"koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.highlight-3.js"
in branch "HEAD" rename
"koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js"->"koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-5.js"
in "Bug 29578: Upgrade the jQuery highlighter plugin"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31453] Add ability to filter messages to process using process_message_queue.pl via a command line parameter

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31009] Claims list take too much times (timeout when you have so many claims) on serials

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31009

Dept Num  changed:

   What|Removed |Added

 CC||cecile.lambour@univ-brest.f
   ||r

--- Comment #5 from Dept Num  ---
I create 1O late issues in the Receive page => I click on claims page and I
loads the claims of the vendor. I see the 10 claims. It's not slow.
Are 10 claims enought ? Is it the right process ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33573] Add public endpoint for cancelling holds

2023-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573

--- Comment #9 from Kyle M Hall  ---
Created attachment 152905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152905&action=edit
Bug 33573: Add public endpoint for cancelling holds

This patch introduces a public endpoint for cancelling holds.
Cancellation requests are generated when the hold is waiting and
configuration allows requesting cancellation, as the OPAC does right
now.

Tests cover all the use cases.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/patrons_holds.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Sam Lau 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >