[Koha-bugs] [Bug 31720] Output of export_borrowers with all fields cannot be imported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31720 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #35 from David Cook --- (In reply to Julian Maurice from comment #31) > It really is a minor slowdown. 1.5ms for 1000 migration files (which > represents two-thirds of the whole Koha history). > But I agree it's an unnecessary slowdown, and the check can moved to the > start of the application, as suggested in comment 17. Because it's always > faster to do nothing :) If we move it to the start of the application, I think we'd have to process upgrades automatically behind the scenes and not via the UI. That would leave the UI just for the initial install I think? Honestly, for most people using Koha packages, that should be the workflow they experience anyway, so I think that should work out well. Would you do this in plack.psgi or somewhere else? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #34 from David Cook --- Looking at backported db_revs and I think it is like Julian says. The following two files are equivalent: ./installer/data/mysql/db_revs/221102001.pl ./installer/data/mysql/db_revs/22124.pl When you upgrade from 22.11.03 to 23.05.03, you will run ./installer/data/mysql/db_revs/22124.pl even though ./installer/data/mysql/db_revs/221102001.pl has already run. The database migration system actually should be better because you're less likely to run the same migration script twice. The migration for "./installer/data/mysql/db_revs/221102001.pl" would be pushed to master then backported to 22.11.03. You run it as part of 22.11.03, which means you don't run it again when you're upgrading to 23.05.03. Nice. -- The only issue would be if there's a migration in 23.05.03 which conflicts with the database coming from 22.11.03, but that would already be a problem with updatedatabase.pl and db_revs anyways. -- So overall I think it should be OK in that respect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #33 from David Cook --- When in doubt, I like to look at existing implementations and resources. Ruby on Rails is known for its migrations: https://guides.rubyonrails.org/v3.2/migrations.html#what-s-in-a-name "For example Alice adds migrations 2008090612 and 20080906123000 and Bob adds 20080906124500 and runs it. Alice finishes her changes and checks in her migrations and Bob pulls down the latest changes. When Bob runs rake db:migrate, Rails knows that it has not run Alice’s two migrations so it executes the up method for each migration. Of course this is no substitution for communication within the team. For example, if Alice’s migration removed a table that Bob’s migration assumed to exist, then trouble would certainly strike." This is similar to what I was saying at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880#c26 I don't know enough about the RM/RMaint process, but it sounds like they'll need to be very careful with backporting any migrations so that they don't allow conflicting migrations / migrations will need to be written carefully. But I don't think that's a reason not to proceed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34249] New: New privacy option for lists: staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34249 Bug ID: 34249 Summary: New privacy option for lists: staff only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl There are many cases where a list needs to be viewable to a number of staff, but not viewable in the OPAC. Currently the only way other staff members can view a list is to make it public, but this is not workable as it also shows it in the OPAC. It would be really helpful to have a third option: Public, Private, Staff. Anyone who has access to login to the staff interface should be able to view lists set as Staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27880] Store each database migrations state in database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #32 from David Cook --- Generally speaking, I think that I'm in favour of this work, but I suppose we're all risk averse. If for some reason it does end up causing problems and we have to revert, would RM/RMaints just end up converting migrations into db_revs? If they're happy to do that, then it sounds like there might not actually be too much risk? Although one might argue that we might not notice the problem until the migrations are too well entrenched... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33932] Why multiple statuses on item record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33932 --- Comment #10 from David Cook --- (In reply to Christopher Brannon from comment #9) > I guess, if it helps to have it all separated out, then that isn't really > the issue. It probably has more to do with how staff interact with it. > IMO, as status is a status. I shouldn't have to look in 4 different places > to address an item status. Maybe the way it is displayed in the item > editing could be changed to checkboxes with a date next to each, and a > single update button? That would seem a little less clunky. I think that I hear what you're saying. It would be nice just to have one field that can be either "withdrawn", "lost", "damaged", "restricted", or "not for loan". One of the tricky things is there can be multiple user-defined statuses for each of those categories. Uniting those together into one would be quite problematic in a number of ways. Another thing about those statuses is that they're not all treated equally. While most of those categories cause an item to no longer be "available", the item is still "available" when it's restricted. There's also "Not for loan" at the item type level, which is something you won't see in the item editor, and isn't obvious when doing SQL reports. If all the possible statuses were in one 1 database column, you'd also need to take into account all possible codes when writing your SQL reports. That would either mean a lot of maintenance, or eliminating user-entered codes for statuses, which many would see as a feature regression. That said, perhaps "Status" could just be "withdrawn", "lost", "damaged", "restricted", or "not for loan" and then there could be a second column with the more precise code. But that would probably take a fair bit of UI refactoring. There are also recalls, holds, on order, and in transit statuses, although perhaps those should be marked under "Availability". > However, it still makes reporting more complicated - You simply need a > status, and you are having to get information from multiple fields. In theory, we or your Koha support folk could add a database "view" that unites the different columns into 1 status field to simplify your reporting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #8 from David Cook --- (In reply to Kyle M Hall from comment #7) > (In reply to David Cook from comment #6) > > An alternative could be to add a timeout (e.g. 10 seconds) to > > $conn->receive_frame, and to call $pm->reap_finished_children() if it > > returns undef (before calling next()). > > That would only work for Koha's using Rabbit and 10 seconds is quite a long > delay between calls to reap all. You could easily add it to the database polling block too. I suggested 10 seconds since that's the sleep used for the database polling block, but we could use shorter intervals for reaping. That said, why would 10 seconds be a long delay between calls to reap? If you have frequent jobs, then start() will be reaping previous ones. If you have infrequent jobs, then you probably won't have a lot of zombie children around, so 10 seconds seems all right to me to wait for reaping them. I suppose the problem compounds if you have many instances on a server, but I don't think they'd fill up the process table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 --- Comment #10 from David Cook --- (In reply to Sam Lau from comment #9) > (In reply to David Cook from comment #7) > > I'm keen to QA this one, so I'm just waiting for someone else to sign it > > off. > > > All yours! :) Thanks, Sam. I probably won't get to this until next week, so happy for someone else to swoop in, but failing that I'll take a look then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33938] Installer wants to upgrade even when the DB is up-to-date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33938 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- This feels wrong to me. We shouldn't have the comparison check in the templates. It should be in the controller script. Also, it doesn't take into account atomic updates. I'd raised bug 34088 to handle this scenario for updatedatabase.pl but hadn't gotten around to install.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21388] Add ability to hide Non-public Notes from Circulation Page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388 Juliet Heltibridle changed: What|Removed |Added CC||jheltibri...@rcplib.org --- Comment #4 from Juliet Heltibridle --- Our library would still like to be able to hide notes from the issues table. Many of our nonpublic notes are not used at checkout, and having them appear in red on the issues table gives the impression that the notes are something that needs to be acted upon when they are not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 --- Comment #6 from Katrin Fischer --- Note: this is just one spot, we need to fix the others as well, like: Bug 34234 - Item groups dropdown in detail.tt modal does not respect display order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 --- Comment #5 from Katrin Fischer --- Created attachment 153305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153305=edit Bug 34232: (QA follow-up) Remove superfluous "Use:" from each list entry We do have a heading "Use existing item groups" above the entries. The added "Use:" in front of each entry is not requires and makes entries longer and harder to scan. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Katrin Fischer changed: What|Removed |Added Attachment #153204|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 153304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153304=edit Bug 34232: Make dropdown on additem page rescept display order To test: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. 5. Apply patch and restart_all 6. The display order should now be respected Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Katrin Fischer changed: What|Removed |Added Summary|Item groups dropdown on |Item groups dropdown on add |edit/add item form does not |item form does not respect |respect display order |display order --- Comment #3 from Katrin Fischer --- I am only seeing the option to add the item to an item group when adding a new item, is that intended? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on edit/add item form does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Katrin Fischer changed: What|Removed |Added Summary|Item groups dropdown on |Item groups dropdown on |additem.tt does not respect |edit/add item form does not |display order |respect display order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34232] Item groups dropdown on additem.tt does not respect display order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34232 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34220] Running log viewer for only Catalog module loads wrong side navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34220 Katrin Fischer changed: What|Removed |Added Attachment #153262|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 153303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153303=edit Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. Works as advertised. Signed-off-by: Alexander Blanchard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34220] Running log viewer for only Catalog module loads wrong side navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34220 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31736] Context for translation: "All"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736 --- Comment #3 from Caroline Cyr La Rose --- Created attachment 153302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153302=edit Bug 31736: Context for translation: 'All' (All patron categories) This patch adds context for translators for the term 'All' when it refers to 'All patron categories'. 1. Apply patch 2. View the following pages --> The pages work (no errors) --> No spelling errors in 'All' patron categories - Administration > Circulation and fines rules > Patron category column (All in existing rule) - Administration > Circulation and fines rules > Patron category column (All in drop-down to create a new rule) - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Patron category column (All in existing rule) - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Patron category column (All in drop-down to create a new rule) - Administration > Circulation and fines rules > Default article request fees > Patron category column (All in existing rule) - Administration > Circulation and fines rules > Default article request fees > Patron category column (All in drop-down to create a new rule) - Installer > Onboarding > New circulation rule (Patron category) 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po) --> There should be an entry for 'All' with a line msgctxt that gives the 'All patron categories' context 5. Update the file with a random word or phrase for the 'All' translation For example, I translated 'All' by "Toutes les catégories d'utilisateurs" \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:215 \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:406 \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:892 \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:921 \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1027 \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1048 \#: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:75 msgctxt "All patron categories" msgid "All" msgstr "Toutes les catégories d'utilisateurs" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) ./misc/translator/translate install xx-XX 6.2. In the Koha staff interface, go to Administration > System preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. Switch the language of the interface 8. Redo step 2 --> The pages still work (no errors) --> The 'All' patron categories string should be replaced by whatever you put in step 5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31736] Context for translation: "All"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 153301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153301=edit Bug 31736: Context for translation: 'All' (All libraries) This patch adds context for translators for the term 'All' when it refers to 'All libraries'. 1. Apply patch 2. View the following pages --> The pages work (no errors) --> No spelling errors in 'All' libraries - Acquisitions > Invoices (Library filter on the left) - Circulation > Holds queue (Library filter) - Reports > Cash register (Transaction library filter) - Reports > Items lost (Library filter) - Serials > Check expiration (Library filter) - Serials > Search settings icon in the search bar > Advanced search (Library filter) - Acquisitions > Add to basket > From a subscription (Library filter on the left) - Installer > Onboarding > New circulation rule (Library) 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po) --> There should be an entry for 'All' with a line msgctxt that gives the 'All libraries/branches' context 5. Update the file with a random word or phrase for the 'All' translation For example, I translated 'All' by 'Toutes les bibliothèques' \#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:383 \#: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:254 \#: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:64 \#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:115 \#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:146 \#: koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt:48 \#: koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc:41 \#: koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc:34 msgctxt "All libraries/branches" msgid "All" msgstr "Toutes les bibliothèques" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) ./misc/translator/translate install xx-XX 6.2. In the Koha staff interface, go to Administration > System preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. Switch the language of the interface 8. Redo step 2 --> The pages still work (no errors) --> The 'All' libraries string should be replaced by whatever you put in step 5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34244] Improve contrast in staff interface main page layered icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34244 --- Comment #4 from Katrin Fischer --- Much nicer, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34244] Improve contrast in staff interface main page layered icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34244 Katrin Fischer changed: What|Removed |Added Attachment #153281|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 153300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153300=edit Bug 34244: Improve contrast in staff interface main page layered icons This patch adjusts CSS for the staff interface home page so that there is better contrast with Font Awesome icons which are layered. The main advanced search and item search links have two icons layered one on top of the other, and the "lower" one needs to have better contrast after the staff interface redesign. To test, apply the patch and rebuild the staff interface CSS. Log into the staff interface and confirm that the advanced search and item search link icons are clear and distinguishable from each other. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34244] Improve contrast in staff interface main page layered icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34244 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34244] Improve contrast in staff interface main page layered icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34244 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33946] biblio-title.inc should not add a link if biblio does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 --- Comment #10 from Katrin Fischer --- Created attachment 153299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153299=edit Bug 33946: (QA follow-up) Add spans and classes for styling and translatability Adds back the spans around No title and more spans for 'No bibliographic record' with individual classes for each to allow for styling later. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33946] biblio-title.inc should not add a link if biblio does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 Katrin Fischer changed: What|Removed |Added Attachment #152179|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 153298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153298=edit Bug 33946: Resync opac/intranet includes This patch resyncs the whitespace chomping in the opac include to match that in the intranet include so aid in diffing between the two. No changes should be visible in the UI but there may be cleaner markup as a result. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33946] biblio-title.inc should not add a link if biblio does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 Katrin Fischer changed: What|Removed |Added Attachment #152178|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 153297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153297=edit Bug 33946: Do not display link to non-existing bibliographic record If you use biblio-title.inc on a biblio that does not longer exist, "No title" is shown with a link to catalogue/detail?.pl?biblionumber= We should at least remove the link. We could even do better and display "No bibliographic record" if the biblio does not longer exist. Test plan: Edit mainpage.pl, add $template->param( your_bib => Koha::Biblios->find(42) ); Edit intranet-main.tt, add [% INCLUDE 'biblio-title.inc' biblio=your_bib link = 1 %] Not hit the main page and see what's hapenning. If you have a bibliographic record with biblionumber=42, its info will be displayed. Remove this record and try again => it's replaced with "No bibliographic record" without a link Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33946] biblio-title.inc should not add a link if biblio does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34248] New: Curbside pickup times should follow TimeFormat preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34248 Bug ID: 34248 Summary: Curbside pickup times should follow TimeFormat preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jr...@sekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When scheduling a pickup at a specific time, the time is in 24-hour format. It would make sense for the time slot selection formatting to follow the TimeFormat preference. This can be observed by: -Enabling the CurbsidePickup syspref -Configuring a branch with time slots at or beyond 13:00 (1:00 PM) -Switching the TimeFormat syspref to 12 hour format -Scheduling a pickup at that branch (time slots remain in 24-hour format) This is especially confusing for patrons who are accustomed to the 12-hour format choosing to schedule pickups themselves in the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33946] biblio-title.inc should not add a link if biblio does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 --- Comment #7 from Katrin Fischer --- This is a nice little improvement. Is there any plan to pull the records title from deletedbiblio maybe? Thinking of acq as one of the spots this would really be useful! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30151] branchcode should always be in PatronSelfRegistrationBorrowerMandatoryField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30151 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #2 from Emily Lamancusa --- It looks like this came about because of the odd behavior that can occur if branchcode is not mandatory for OPAC self-registration, right? Koha won't force a customer to choose a branchcode if it's not mandatory, but it can't be left blank either because it's required by the database, so it will simply default to the branchcode that comes first alphabetically. I wonder if a better solution would be to add a means of specifying a default branchcode for self-registration. That would allow branchcode to be added to PatronSelfRegistrationBorrowerUnwantedField if desired, too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33946] biblio-title.inc should not add a link if biblio does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns when placing holds in staff are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Katrin Fischer changed: What|Removed |Added Attachment #153267|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 153296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153296=edit Bug 34233: Move select2 include out of patron-search.inc 1. Apply patch 2. Place a hold and make sure the patron pickup locations are populating correctly again/ 3. Work through the test plan on Bug 28726 to make sure it still works. 4. Enable ArticleRequests, make sure you can still do a patron search there. 5. Do a patron search from members.tt, make sure that still works. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns when placing holds in staff are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Emily Lamancusa changed: What|Removed |Added CC||neng...@gmail.com --- Comment #26 from Emily Lamancusa --- *** Bug 16865 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16865] Patron self registration: hiding branchcode gives error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Emily Lamancusa changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #11 from Emily Lamancusa --- *** This bug has been marked as a duplicate of bug 17364 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns when placing holds in staff are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Katrin Fischer changed: What|Removed |Added Summary|Pickup location pulldowns |Pickup location pulldowns |in placing co are blank |when placing holds in staff ||are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in placing co are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Katrin Fischer changed: What|Removed |Added Summary|Pickup location pulldowns |Pickup location pulldowns |in request.pl are blank |in placing co are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34233] Pickup location pulldowns in request.pl are blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34233 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Katrin Fischer changed: What|Removed |Added Attachment #152686|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 153295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153295=edit Bug 28196: Insert searchid in URL correctly, so it doesn't follow the hash Test plan: 1. Search the catalog in the staff client for anything which will return at least two results 2. Click on any result to go to the bib detail page 3. Click the edit button for any item attached to the bib 4. Verify that the loaded URL contains =scs_(a number), and that the URL ends with #edititem 5. Make any change to the item, save, verify that your change was made Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33790] Fix and add various links to the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 cghattas changed: What|Removed |Added CC||cghat...@rclstn.org --- Comment #6 from cghattas --- Yes, we would like to see this as an automated resolution in Koha upon check-in by staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 --- Comment #6 from Katrin Fischer --- (In reply to Daphne Hoolahan from comment #5) > > We have tried entering 6; 6.; 6%; "6"; 6.0-6.999 but regardless of what we > enter the system appears to return everything that contains 6 with 526$c Did you try Nick's suggestion from comment 2? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13093] Allow/Don't allow holds on items with set statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13093 --- Comment #3 from Katrin Fischer --- I think settings would work, yes. Also this would allow for migrations without changing behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11420] Patron preference to restrict staff from changing location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 --- Comment #7 from Katrin Fischer --- (In reply to Christopher Brannon from comment #6) > (In reply to Katrin Fischer from comment #5) > > We do now have this permission: > > Allow staff to change logged in library (loggedinlibrary) > > What version? Not seeing it in 22.11. Correct, it's a 23.05 feature: Bug 30624 - Add a permission to control the ability to change the logged in library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 --- Comment #6 from Kyle M Hall --- Fixed! (In reply to Andrew Fuerste-Henry from comment #4) > Tested this on a sandbox with the following in MarcItemFieldsToOrder: > itype: 975$y > coded_location_qualifier: 975$a > barcode: 975$b > enumchrom: 975$c ^ I don't know if this was wrong in your syspref, but enumchron is spelled wrong here. I caught that during testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34218] XSLT parse on record directly breaks OPAC display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34218 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34218] XSLT parse on record directly breaks OPAC display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34218 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34137] Requested cancellation date column missing from holds awaiting pickup table config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34116] Add page-sectioning to item search in label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34116 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34086] On detail.tt if item.permanent_location is NULL no shelving location will show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34086] On detail.tt if item.permanent_location is NULL no shelving location will show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34072] Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34072] Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33047] Local cover image fetchers return 500 internal error when image not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33047 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33047] Local cover image fetchers return 500 internal error when image not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33047 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall changed: What|Removed |Added Attachment #147966|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 153294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153294=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Tomás Cohen Arazi changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Tomás Cohen Arazi changed: What|Removed |Added Severity|enhancement |new feature CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Daphne Hoolahan changed: What|Removed |Added CC||d...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33817] Composition of an item bundle can be changed if checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 153293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153293=edit Bug 33817: (QA follow-up) Fix tidyness This patch fixes some reported tidyness issues with the patches. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #33 from Nick Clemens --- *** Bug 34067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34067] Patron attributes search handles 'starts with'/contains incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34067 Nick Clemens changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Nick Clemens --- (In reply to Pedro Amorim from comment #4) > I believe the plan is to push bug 34092 to 22.11.x, but we're waiting for it > for first land on 23.05.x. I'm going to close this as a duplicate then, thanks for the fix :-) *** This bug has been marked as a duplicate of bug 34092 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Sam Lau changed: What|Removed |Added Attachment #153250|0 |1 is obsolete|| --- Comment #23 from Sam Lau --- Created attachment 153292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153292=edit Bug 30700: (follow-up) Redirect to patron page after changing password This patch ensures the logged in user is redirected to the patron detail page after successfully changing another patron's password (rather than the homepage). Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Sam Lau changed: What|Removed |Added Attachment #153249|0 |1 is obsolete|| --- Comment #22 from Sam Lau --- Created attachment 153291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153291=edit Bug 30700: (follow-up) Add system preference StaffLoginResetPassword This syspref wraps around the functionality added for patrons with the 'catalogue' permission to reset their own password via the staff client. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Sam Lau changed: What|Removed |Added Attachment #153248|0 |1 is obsolete|| --- Comment #21 from Sam Lau --- Created attachment 153290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153290=edit Bug 30700: Allow staff users to change their password via staff client Patrons who can log into the staff client (have the 'catalogue' permission) should be able to change their own password. To test: 0) Apply the patch, install database updates, restart services. Go to System preferences and enable the StaffLoginResetPassword system preference. 1) Create a user with only 'catalogue' permissions (Patron A) 2) Log in to the staff client as Patron A 3) Click the menu with your username in the top-right of the window. Click the 'your account' menu link. 4) Confirm you are forced to a login screen, so you cannot view your account, which is where the 'change password' link is normally found. 5) Try to access the page to change your password directly http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X (swap Patron A's borrowernumber in). Confirm you are forced to a login screen. 6) Apply this patch and restart services. Go back to the mainpage logged in as Patron A. 7) Click the menu with your username in the top-right of the window. Notice there is now a 'Change password' menu link. Go to 'change password'. 8) Confirm you are now shown a page to change your password. Change your password, and confirm you are redirect to the mainpage. 9) Try to access the page to change someone else's page directly http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X (swap some other borrowernumber in). Confirm you are redirected to a 404. 10) Log out and log back in as your original borrower. Confirm you are able to change your password as normal. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33610] Accelerated Reading Level Search not accurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 --- Comment #5 from Daphne Hoolahan --- (In reply to Katrin Fischer from comment #1) > Hi Daphne, are you using Zebra or Elasticsearch? > > How do you search for the reading level? Are you using "expert search" or > some other way? > > Both search engines might treat . as a space, making 5.6 into too separate > words. > > For Zebra using exact field search with ,ext might work, but I haven't > figured out yet how to do an exact field search with Elasticsearch. You > could try enclosing in "", but I feel it's probably not enough here. Hi Katrin, We're using Zebra Advanced Search and selecting Accelerated Reading Level search.pl?advsearch=1=arl%2Cphr=6.=kw==kw=_by=relevance We have tried entering 6; 6.; 6%; "6"; 6.0-6.999 but regardless of what we enter the system appears to return everything that contains 6 with 526$c -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34223] ILL status filter does not load immediately after selecting a backend filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34223 --- Comment #3 from Pedro Amorim --- The patch is just a proof of concept detailing the solution I had at the time of developing this but was ultimately prevented by the ONLY_FULL_GROUP_BY. The patch is NOT the fix, as I don't think we want to change Database.pm for this. It's just demonstrating how it should work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34223] ILL status filter does not load immediately after selecting a backend filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34223 --- Comment #2 from Pedro Amorim --- Created attachment 153289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153289=edit Bug 34223: PROOF OF CONCEPT The following command will (hopefully) reset your ILL data and create 10k fake ILL requests (run this in DEV KTD only). 1) On an empty k-t-d, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-data.sh) 2) Pet a cat 3) Visit /cgi-bin/koha/ill/ill-requests.pl and select a backend on the left side filters 4) Notice how the status filter takes a while (3-5 secs) to load 5) Apply patch and koha-plack --restart kohadev 6) Repeat 3, notice how the status filter now loads fast -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34247] Improve translation of notice character count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34247 --- Comment #1 from Owen Leonard --- Created attachment 153288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153288=edit Bug 34247: Improve translation of notice character count This patch restructures the template markup around the part of the notice edit screen where the system tracks how many characters have been entered in an SMS message. The change is intended to make translation easier. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po there should not be a line with the string "160 characters" - In fr-FR-messages.po the string should have been picked up like this: msgid "{content_length} / 160 characters" msgstr "" - Add a translation to fr-FR-messages.pl and install the updated translation: perl misc/translator/translate install fr-FR - Switch to the update language in the staff interface and go to Tools -> Notices. Edit any notice and expand the "SMS" block. (you may be asked to enable SMSSendDriver). - Confirm that the "X/160 characters" text updates correctly as you enter content into the textarea. Confirm that the same is true when you switch to your updated translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34247] Improve translation of notice character count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34247 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32530] When duplicating child card, guarantor is not saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Michael Spagnuolo changed: What|Removed |Added CC||mspagnu...@nrhtx.com --- Comment #2 from Michael Spagnuolo --- Our library staff have noticed this bug, and it is causing extra steps during family card creation. We would like to see it fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34247] New: Improve translation of notice character count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34247 Bug ID: 34247 Summary: Improve translation of notice character count Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr When entering content in an SMS message notice there is a character count to count down how many characters you have left. This looks ugly in the .po file: #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:589 #, c-format msgid "%s %s %s 0 %s/160 characters" msgstr "%s %s %s 0 %s/160 caractères" After my proposed change: #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:591 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:593 #, perl-brace-format msgid "{content_length} / 160 characters" msgstr "{content_length} / 160 caractères" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31736] Context for translation: "All"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com --- Comment #1 from Caroline Cyr La Rose --- I tried to separate what each "All" refers to All libraries/branches #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:382 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:253 #: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:63 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:114 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:145 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt:47 #: koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc:40 #: koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc:33 All patron categories #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:214 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:405 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:891 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:920 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1026 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1047 #: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:74 All item types #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:226 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:414 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:898 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:928 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:261 #: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:86 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:149 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt:25 All collections / collection codes #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:268 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt:198 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt:37 All shelving locations #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:275 All lost statuses #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:158 All not for loan statuses #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:172 All checkout types (regular vs on-site checkout) #: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt:139 All vendors #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:315 All options for Statistic 1 in acquisitions #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt:243 All options for Statistic 2 in acquisitions #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt:258 Report dictionary areas #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt:88 All report groups #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:228 All report subgroups #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:240 All display locations for additional contents #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt:148 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt:372 All MARC fields #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt:226 All log modules #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:212 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:214 All log actions #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:233 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:235 All log interfaces #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:263 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:265 Show all results in a table #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:349 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:126 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:128 #: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt:153 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:1491 #: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:253 All ?? (From additional fields) #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:392 All ?? (all options from authorized value list) #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:872 #: koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc:16 ?? #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt:45 #:
[Koha-bugs] [Bug 33932] Why multiple statuses on item record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33932 --- Comment #9 from Christopher Brannon --- (In reply to David Cook from comment #8) > (In reply to Christopher Brannon from comment #0) > > Is there a reason we need to have multiple status fields? I'm wondering why > > we don't consolidate the statuses to a single field that you can set > > multiple statuses on. Is it because each status has a timestamp? > > I've re-read your description, and I'm wondering are you talking about a > screen that has a "Status" label and then a number of checkboxes for things > like "Withdrawn", "Damaged", "Lost", etc? I guess, if it helps to have it all separated out, then that isn't really the issue. It probably has more to do with how staff interact with it. IMO, as status is a status. I shouldn't have to look in 4 different places to address an item status. Maybe the way it is displayed in the item editing could be changed to checkboxes with a date next to each, and a single update button? That would seem a little less clunky. However, it still makes reporting more complicated - You simply need a status, and you are having to get information from multiple fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142 Sam Lau changed: What|Removed |Added Attachment #153251|0 |1 is obsolete|| --- Comment #8 from Sam Lau --- Created attachment 153287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153287=edit Bug 32142: Implement issued_or_reserved HoldFeeMode option This enhancement adds an issued_or_reserved option to the HoldFeeMode system preference, so that a hold fee may be charged if either all items are check out, or the record has at least one hold already. To test: 1) Apply patch, update database, restart services 2) Go to Administration -> Patron categories 3) Edit Category A and add a hold fee of $1.00 4) Go to Administration -> System preferences and search for HoldFeeMode 5) Set HoldFeeMode to not_always - "only if all items are checked out and the record has at least one hold already" 6) In another tab, open the staff interface. Search for a record with one item attached to it (Biblio A) 7) Place a hold on this record for Patron B (any category). not_always, reserved but not issued 8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of Category A which the hold fee applies to) 9) Check Patron A's accounting page. They should NOT have a hold fee issued_or_reserved, reserved but not issued 10) In your System preferences tab, change HoldFeeMode to issued_or_reserved - "either if all items are checked out, or the record has at least one hold already" 11) Delete Patron A's hold on Biblio A 12) Place a hold on Biblio A for Patron A 13) Check Patron A's accounting page. They SHOULD have a hold fee not_always, issued but not reserved 14) In your System preferences tab, change HoldFeeMode to not_always - "only if all items are checked out and the record has at least one hold already" 15) Delete all holds on Biblio A 16) Check out Biblio A's item (Item A) to Patron B 17) Place a hold on Biblio A for Patron A 18) Check Patron A's accounting page. They should NOT have a hold fee issued_or_reserved, issued but not reserved 19) In your System preferences tab, change HoldFeeMode to issued_or_reserved - "either if all items are checked out, or the record has at least one hold already" 20) Delete Patron A's hold on Biblio A 21) Place a hold on Biblio A for Patron A 22) Check Patron A's accounting page. They SHOULD have a hold fee not_always, issued and reserved 23) In your System preferences tab, change HoldFeeMode to not_always - "only if all items are checked out and the record has at least one hold already" 24) Delete all holds on Biblio A 25) Place a hold on Biblio A for Patron C (any category). 26) Place a hold on Biblio A for Patron A 27) Check Patron A's accounting page. They SHOULD have a hold fee issued_or_reserved, issued and reserved 28) In your System preferences tab, change HoldFeeMode to issued_or_reserved - "either if all items are checked out, or the record has at least one hold already" 29) Delete Patron A's hold on Biblio A. There should still be a hold for Patron C. 30) Place a hold on Biblio A for Patron A 31) Check Patron A's accounting page. They SHOULD have a hold fee 32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t Sponsored-by: Horowhenua Libraries Trust Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142 Sam Lau changed: What|Removed |Added Attachment #143452|0 |1 is obsolete|| --- Comment #7 from Sam Lau --- Created attachment 153286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153286=edit Bug 32142: Add issued_or_reserved option to HoldFeeMode syspref Database updates Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13165] Don't trigger holds when patrons have already reached limit of checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165 --- Comment #6 from Christopher Brannon --- I think that it should be up to the system admin to implement, not how complicated we might think it is for the patron. If a library can communicate this well, it would be worth it. It could simply be communicated at the time the hold is being placed like a warning: "Please note that holds are not filled if you have reached the limit of your library's checkouts." Maybe we could even have something that would display checkout limits, if any. It should be up to the library whether this would be implemented or not, leaving it to the library as to whether a patron's holds can be filled if their checkout limits have been reached. As is, a patron gets notified that they have a hold, and they go to pick it up, only to find out that they can't check it out until they return something. They probably are not prepared with this dilemma, and have to return home to get something to return so they can claim their hold. With a new option, they are not even eligible or notified until they are under the limit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34227] Add persistent selections and batch operations to item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Sam Lau changed: What|Removed |Added Attachment #153208|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 153285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153285=edit Bug 34227: Add persistent selections and batch operations to item search This patch modifies the item search results page so that user selections are stored in local storage. This allows the user to make selections on one page of search results, move to another, and continue to make selections. The patch also adds the option to send selected items to batch item modification or batch item deletion. Changes to the patron search results template have been made to make some CSS classes more generic so they can be used by both pages. To test, apply the patch and rebuild the staff interface CSS. - Log in to the staff interface as a user with permission to perform batch item modification and batch item deletion. - Go to item search and perform a search which will return at least two pages of results. - On the search results page you should see a new search header toolbar with some controls: "Select visible rows," "Clear selection," "Export all results to" and "Batch operations" (disabled). - Without making any selections, confirm that the "Export all results to" menu items work correctly to export all results to a CSV or a barcode file. - Confirm that the "Select visible rows" control works as expected, selecting all checkboxes on the current page (and on no other pages) - After selecting all checkboxes the search header controls should be updated: - The "Export all..." button should now show the number of selections: "Export selected results (X) to..." - The batch operations button should be enabled. - There should be a new element labeled "Items selected: X" with a "Clear" link. - If you uncheck any checkboxes the controls should be updated, showing the new count of selected records. - Move to the next page of results and confirm that making selections on this page works to increment all counters - Confirm that the "Export selected.." options work and that your CSV and barcode files now contain only the items you selected. - Test the batch operations menu: - Test that the controls correctly reflect the logged-in user's permissions: - With permission to batch modify items - With permission to batch delete items - With both; with neither - Both menu options should take you to the correct page and the list of submitted items should match your selections. - Test that clicking the "Clear" button next to "Items selected" hides the items selected box and reverts the "Export all" and "Batch operations" buttons to their original state. - Page through the search results to confirm that no checkboxes are checked. - Test that your search selections are really persistent: - Navigate away from the page, return to item search, and perform another search. - The "Item selected" box should still show your previous selections. - Any items you previously selected which are also in this result set should have a checked checkbox. - Click the "Edit search" button from the item search results page and new search with different parameters. - The "Items selected" should still show your previous selections. - Log out of Koha and back in. When you perform an item search now, there should be no "Item selected" - Go to Patrons and test patron searching. As you make selections the "Patrons selected" box should be updated correctly and look correct, matching the one on the item search page. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34227] Add persistent selections and batch operations to item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34227 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13125] Total holds does not tally holds / items.reserves is not populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 --- Comment #7 from Christopher Brannon --- I don't agree with doing away with it. Perhaps the simple answer is to have the following options: A) uptick the count in this field if a hold is triggered on the specific item. First available or item specific is moot. If the hold is triggered, it is assigned to a specific item at that point. B) decide if a cancelled hold leaves the count as is, or downticks the count. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34228] Add translation context to "Managed by"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34228 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34228] Add translation context to "Managed by"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34228 Lucas Gass changed: What|Removed |Added Attachment #153282|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 153284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153284=edit Bug 34228: Add translation context to "Managed by" This patch adds context for translators to the Managed by string when it applies to acquisitions baskets (as opposed to purchase suggestions). To test: 0. If you don't already have acquisitions set up, create a budget and a vendor 1. Apply patch 2. Create a basket 2.1. Go to Acquisitions 2.2. Search for a vendor 2.3. Click New > Basket 2.4. Fill out the form 2.5. Click Save 3. View the basket details page --> The page works (no errors) --> 'Managed by:' is displayed on the right, no spelling errors 4. Click Add to basket > From a new (empty) record --> The page works (no errors) --> 'Managed by:' is displayed under Basket details, no spelling errors 5. Click Cancel 6. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 7. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po) --> There should be an entry for 'Managed by:' with a line msgctxt that gives the 'Acquisitions basket managed by user' context 8. Update the file with a random phrase for the 'Managed by:' translation for example, I translated 'Managed by:' by 'AAA:', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt:308 \#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:281 msgctxt "Acquisitions basket managed by user" msgid "Managed by:" msgstr "AAA:" 9. Install a new language 9.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) ./misc/translator/translate install xx-XX 9.2. In the Koha staff interface, go to Administration > System preferences 9.3. Search for language 9.4. Check the box next to the new language 9.5. Save 10. Switch the language of the interface 11. Redo steps 3 and 4 --> The pages still work (no errors) --> The 'Managed by:' string should be replaced by whatever you put in step 8 Optional test 12. In the staff interface in English, view one or more of these pages, the 'Managed by' string should be unchanged - Acquisitions > Suggestions (Managed by column heading) - Acquisitions > Suggestions (Organize by: Managed by sorting option) - Acquisitions > Suggestions (Filter by: Suggestion information: Managed by filter option) - Acquisitions > Suggestions > Click on a suggestion (Managed by table row under Suggestion management) - Patrons > Patron account > Purchase suggestions (Managed by column heading) 13. View these same pages in the other language, the Managed by string should NOT be changed to whatever you put in step 8 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13093] Allow/Don't allow holds on items with set statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13093 --- Comment #2 from Christopher Brannon --- Then perhaps we do away with the negative value/hold relationship in NOTFORLOAN, and a new setting created to list what statuses allow holds? NOTFORLOAN: 1,2,5 DAMAGED: 2,5 LOST: 3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11420] Patron preference to restrict staff from changing location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 --- Comment #6 from Christopher Brannon --- (In reply to Katrin Fischer from comment #5) > We do now have this permission: > Allow staff to change logged in library (loggedinlibrary) What version? Not seeing it in 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Sam Lau changed: What|Removed |Added Attachment #153247|0 |1 is obsolete|| --- Comment #5 from Sam Lau --- Created attachment 153283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153283=edit Bug 31147: Recalls should not adjust due time for related checkouts The current recalls behaviour adjusts the due date of the most appropriate checkout based on the 'recall due date interval' circulation rule. It also adjusts the due time, which is buggy behaviour. The due date should be adjusted based on the circulation rule, but the due time should remain the same. To test: 1. Enable the UseRecalls system preference and configure recalls-related circulation and fines rules 2. Check out Item A to Patron A 3. Log into the database and check the due date for that checked out item, e.g. SELECT date_due FROM issues WHERE itemnumber = ; --> It should be -MM-DD 23:59:00 4. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, at the exact time you placed the recall. This is buggy behaviour. 5. Apply the patch and restart services 6. Check in Item A, do NOT fulfill the recall 7. Cancel the recall 8. Check out Item A to Patron A 9. Log into the database and check the due date for that checked out item, e.g. SELECT date_due FROM issues WHERE itemnumber = ; --> It should be -MM-DD 23:59:00 10. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, with time of 23:59:00. 11. Check in Item A, do NOT fulfill the recall 12. Cancel the recall 13. Check out Item A to Patron A. Specify a due date and change the due time so it isn't 23:59. 14. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, with time you set in Step 13. 15. Confirm tests pass t/db_dependent/Koha/Recalls.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34228] Add translation context to "Managed by"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34228 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 153282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153282=edit Bug 34228: Add translation context to "Managed by" This patch adds context for translators to the Managed by string when it applies to acquisitions baskets (as opposed to purchase suggestions). To test: 0. If you don't already have acquisitions set up, create a budget and a vendor 1. Apply patch 2. Create a basket 2.1. Go to Acquisitions 2.2. Search for a vendor 2.3. Click New > Basket 2.4. Fill out the form 2.5. Click Save 3. View the basket details page --> The page works (no errors) --> 'Managed by:' is displayed on the right, no spelling errors 4. Click Add to basket > From a new (empty) record --> The page works (no errors) --> 'Managed by:' is displayed under Basket details, no spelling errors 5. Click Cancel 6. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 7. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po) --> There should be an entry for 'Managed by:' with a line msgctxt that gives the 'Acquisitions basket managed by user' context 8. Update the file with a random phrase for the 'Managed by:' translation for example, I translated 'Managed by:' by 'AAA:', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt:308 \#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:281 msgctxt "Acquisitions basket managed by user" msgid "Managed by:" msgstr "AAA:" 9. Install a new language 9.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) ./misc/translator/translate install xx-XX 9.2. In the Koha staff interface, go to Administration > System preferences 9.3. Search for language 9.4. Check the box next to the new language 9.5. Save 10. Switch the language of the interface 11. Redo steps 3 and 4 --> The pages still work (no errors) --> The 'Managed by:' string should be replaced by whatever you put in step 8 Optional test 12. In the staff interface in English, view one or more of these pages, the 'Managed by' string should be unchanged - Acquisitions > Suggestions (Managed by column heading) - Acquisitions > Suggestions (Organize by: Managed by sorting option) - Acquisitions > Suggestions (Filter by: Suggestion information: Managed by filter option) - Acquisitions > Suggestions > Click on a suggestion (Managed by table row under Suggestion management) - Patrons > Patron account > Purchase suggestions (Managed by column heading) 13. View these same pages in the other language, the Managed by string should NOT be changed to whatever you put in step 8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34228] Add translation context to "Managed by"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34228 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/