[Koha-bugs] [Bug 33043] Use process_tt in SIP modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 --- Comment #8 from Marcel de Rooy --- OK C4/SIP/ILS/Item.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid OK C4/SIP/ILS/Patron.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33043] Use process_tt in SIP modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33043] Use process_tt in SIP modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 Marcel de Rooy changed: What|Removed |Added Attachment #150522|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 153430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153430&action=edit Bug 33043: Use process_tt in SIP modules Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33043] Use process_tt in SIP modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- Base patch set in FQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Marcel de Rooy --- QA tools fail on exec flag and other things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #7 from Marcel de Rooy --- Moving this to In Discussion temporarily. Will mail QA about it. I am not very sure if we should do this via js and localStorage at the client side in terms of security. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Attachment #153425|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34243] Too much cities are created (at least in comments)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34243 --- Comment #3 from Marcel de Rooy --- OK t/db_dependent/api/v1/smtp_servers.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK t/db_dependent/api/v1/suggestions.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Marcel de Rooy changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 --- Comment #8 from Marcel de Rooy --- Tomas: Any reason why this did not get further ? Please note that the perl tidy stuff started just now. This passed the former qa tools.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Marcel de Rooy changed: What|Removed |Added Text to go in the||This patch set drops the release notes||column ||virtualshelfcontents.flag ||which is unused for a long ||time. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #15 from Marcel de Rooy --- Note for QA: I spent a lot of time on this one. It passed qa tools at the time. And now out of nowhere, qa tools has been changed quite a bit. And I am seeing warns about REST API validation and perl tidy. This was written before the cutoff date ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- We are failing patches in qa tools with a reference to a patch that does not even apply??? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34276] New: upgrading 23.05 to 23.05.002
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276
Bug ID: 34276
Summary: upgrading 23.05 to 23.05.002
Change sponsored?: ---
Product: Project Infrastructure
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Bugzilla
Assignee: jonathan.druart+k...@gmail.com
Reporter: aliakbar.petiwal...@gmail.com
Upgrade to 23.05.00.002 [16:25:11]: Bug 21983 - Deleted biblio handling on ILL
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name
'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34181] Batch Patron Modification Tool missing checkboxes to clear field values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Jennifer Marlatt changed: What|Removed |Added CC||jennifer.marlatt@coronaca.g ||ov --- Comment #2 from Jennifer Marlatt --- We use this feature at least once a week. I have a workaround in place, but takes significantly more time to complete what was once a quick and simple task. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34262] Merging duplicate patrons in succession is adding previously merged duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 --- Comment #2 from Esther Melander --- Thank you, that was not on my radar. I wonder if some improvements can be made with this though. With all of the testing I did, I did not see that button. Perhaps better contrast. Bolding, changing the font color to red, etc. Right now the coloring of that button is reading as nothing unless pointed out. This is especially true for aging eyes and accessibility. If the user doesn't see that button, then it causes no end of difficulty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23178] If all items are marked 'not for loan' staff results displays 'None available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23178 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34262] Merging duplicate patrons in succession is adding previously merged duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #1 from Emily Lamancusa --- Hi Esther, this is a new feature that was added in bug 29971 to make it possible to merge patrons that don't show up on the same page of the search. To the right of the "merge selected patrons" button, there should be another button that says "Patrons selected: N x Clear" (where N is the number of patrons that are currently selected/remembered). Clicking that button after performing a patron merge should clear the previous selection and ensure that only patrons selected after that are merged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 --- Comment #6 from Michal Denar --- Created attachment 153429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153429&action=edit Bug 30623: Copy permissions from one user to another This patch adds controls to the patron "Set permissions" page allowing the user to copy a set of permissions from one patron to another. The patch also makes a minor correction to global staff interface CSS to correct the appearance of non-primary split buttons. To test, apply the patch and rebuild the staff interface CSS. You may want to clear your browser cache. - Locate a patron in the staff client and choose More -> Set permissions. You might want to start with a staff patron who has multiple permissions enabled. - You should see two new buttons in the toolbar immediately above the list of permissions: "Copy settings," a split button with a secondary option to choose "Forget copied settings"; and "Paste settings" which should be disabled by default. - Clicking the "Copy settings" button should trigger the copy icon to cycle/fade from the copy icon to the check-mark icon and back to the copy icon. I thought this interaction needed some visual feedback since it doesn't otherwise trigger visible action. - Clicking the "Copy settings" button should also enable the "Paste settings" button. - Locate another patron, preferable one with permissions visibly different from your first choice. - On their "Set permissions" page, click the "Paste settings" button. The list of permissions should expand all settings and all the checkboxes should now match your original choice. - At this stage you could find another patron and paste the same permissions again. - Click "Copy settings -> Forget copied settings." The "Paste settings" button should become disabled. - Using the browser console to check the contents of Local Storage should confirm that the "copiedPermissions" entry has been removed. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33052] Add a message for from_local_hold_group override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Emily Lamancusa changed: What|Removed |Added Attachment #153417|0 |1 is obsolete|| --- Comment #8 from Emily Lamancusa --- Created attachment 153428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153428&action=edit Bug 34258: update SIP-related unit test Test plan: 1) Run the updated SIP-related unit test *without* having applied the other patch from this bug report -- it should fail: $ prove t/db_dependent/SIP/ILS.t 2) Apply the patch that fixes C4/SIP/ILS/Transaction/Renew.pm 3) Re-run the unit test -- it should pass. Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Emily Lamancusa changed: What|Removed |Added Attachment #153416|0 |1 is obsolete|| --- Comment #7 from Emily Lamancusa --- Created attachment 153427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153427&action=edit Bug 34258: pass an unblessed hash to AddIssue() In Koha 23.05, we lost the ability to renew an item via SIP2. The relevant commit is ddc2906b77 from Bug 31735, where the file C4/SIP/ILS/Transaction/Renew.pm was modified to no longer pass an unblessed $patron hash to C4::Circulation::AddIssue() This patch fixes that. Test plan: 1) Using the SIP emulator, check out an item to a patron, then try to renew it. Example commands for a KTD instance: $ misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkout --patron koha --item 30001 $ misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m renew --patron koha --item 30001 Notice that the second command will fail! 2) Apply this patch. 3) Repeat the 2nd command -- this time the renewal should work. 4) Run the SIP-related unit tests, they should all pass: $ prove t/db_dependent/SIP/ t/db_dependent/SIP/ILS.t .. ok t/db_dependent/SIP/Message.t .. ok t/db_dependent/SIP/Patron.t ... ok t/db_dependent/SIP/SIPServer.t ok t/db_dependent/SIP/Transaction.t .. ok Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34211] Add +strings for GET /api/v1/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34211 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34211] Add +strings for GET /api/v1/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34211 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33956] opac-user.pl should use Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33956] opac-user.pl should use Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33954] Add Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33954] Add Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33953] Add Koha::Biblio->ratings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33953] Add Koha::Biblio->ratings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33952] Add Koha::Biblio->normalized_isbn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33952] Add Koha::Biblio->normalized_isbn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 --- Comment #1 from Lucas Gass --- Created attachment 153426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153426&action=edit Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 --- Comment #5 from Owen Leonard --- This is not as full-featured as Christopher Brannon's "Add clear and preset permission buttons, and a copy button to user permissions page" customization on the wiki, https://wiki.koha-community.org/wiki/JQuery_Library#Add_clear_and_preset_permission_buttons.2C_and_a_copy_button_to_user_permissions_page_.28v20.x.29, but I think it's a good first step for something that is generalized and simple. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 --- Comment #4 from Owen Leonard --- Created attachment 153425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153425&action=edit Bug 30623: Copy permissions from one user to another This patch adds controls to the patron "Set permissions" page allowing the user to copy a set of permissions from one patron to another. The patch also makes a minor correction to global staff interface CSS to correct the appearance of non-primary split buttons. To test, apply the patch and rebuild the staff interface CSS. You may want to clear your browser cache. - Locate a patron in the staff client and choose More -> Set permissions. You might want to start with a staff patron who has multiple permissions enabled. - You should see two new buttons in the toolbar immediately above the list of permissions: "Copy settings," a split button with a secondary option to choose "Forget copied settings"; and "Paste settings" which should be disabled by default. - Clicking the "Copy settings" button should trigger the copy icon to cycle/fade from the copy icon to the check-mark icon and back to the copy icon. I thought this interaction needed some visual feedback since it doesn't otherwise trigger visible action. - Clicking the "Copy settings" button should also enable the "Paste settings" button. - Locate another patron, preferable one with permissions visibly different from your first choice. - On their "Set permissions" page, click the "Paste settings" button. The list of permissions should expand all settings and all the checkboxes should now match your original choice. - At this stage you could find another patron and paste the same permissions again. - Click "Copy settings -> Forget copied settings." The "Paste settings" button should become disabled. - Using the browser console to check the contents of Local Storage should confirm that the "copiedPermissions" entry has been removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] New: Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Bug ID: 34275 Summary: Add a button to easily toggle between advanced/basic cataloging editors Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Some librarians/catalogers would find it handy if there was a way to more easily toggle between the advanced and basic cataloging editors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147 Tomás Cohen Arazi changed: What|Removed |Added Attachment #153339|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 153424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153424&action=edit Bug 31147: Recalls should not adjust due time for related checkouts The current recalls behaviour adjusts the due date of the most appropriate checkout based on the 'recall due date interval' circulation rule. It also adjusts the due time, which is buggy behaviour. The due date should be adjusted based on the circulation rule, but the due time should remain the same. To test: 1. Enable the UseRecalls system preference and configure recalls-related circulation and fines rules 2. Check out Item A to Patron A 3. Log into the database and check the due date for that checked out item, e.g. SELECT date_due FROM issues WHERE itemnumber = ; --> It should be -MM-DD 23:59:00 4. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, at the exact time you placed the recall. This is buggy behaviour. 5. Apply the patch and restart services 6. Check in Item A, do NOT fulfill the recall 7. Cancel the recall 8. Check out Item A to Patron A 9. Log into the database and check the due date for that checked out item, e.g. SELECT date_due FROM issues WHERE itemnumber = ; --> It should be -MM-DD 23:59:00 10. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, with time of 23:59:00. 11. Check in Item A, do NOT fulfill the recall 12. Cancel the recall 13. Check out Item A to Patron A. Specify a due date and change the due time so it isn't 23:59. 14. Log into the OPAC as Patron B and place a recall on Item A. This will force a change to the recall's due date. Check the due date in the database SELECT date_due FROM issues WHERE itemnumber = ; --> It should be today + the number of days in your recall due date interval circulation rule, with time you set in Step 13. 15. Confirm tests pass t/db_dependent/Koha/Recalls.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34274] In batch patron modification adding a new attribute clears all existing values and applies authorised values to all attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34274 --- Comment #1 from Nick Clemens --- Not caused by 21083, but should be fixed on top of that one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Nick Clemens changed: What|Removed |Added Blocks||34274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34274 [Bug 34274] In batch patron modification adding a new attribute clears all existing values and applies authorised values to all attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34274] In batch patron modification adding a new attribute clears all existing values and applies authorised values to all attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34274 Nick Clemens changed: What|Removed |Added Depends on||21083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34274] New: In batch patron modification adding a new attribute clears all existing values and applies authorised values to all attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34274 Bug ID: 34274 Summary: In batch patron modification adding a new attribute clears all existing values and applies authorised values to all attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To test: 1 - Define 2 new patron attributes types, both marked repeatable: Repeatable Duplicatable - linked to authorised value 'YES_NO' 2 - Perform a batch patron modification 3 - Select attribute type 'Repeatable' and enter 'Repetition' 4 - Click - +New to add a second attribute 5 - Set the type to 'Duplicatable' 6 - WRONG - values are cleared and Repeatable is now a YES_NO dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #18 from Nick Clemens --- Created attachment 153423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153423&action=edit Bug 21083: (QA follow-up) Add a hint that attributes will replace all existing attributes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #17 from Nick Clemens --- Created attachment 153422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153422&action=edit Bug 21083: Remove all attributes not only the first one Signed-off-by: Philip Orr Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Nick Clemens changed: What|Removed |Added Attachment #152707|0 |1 is obsolete|| Attachment #152708|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 153421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153421&action=edit Bug 21083: Handle repeatable patron attributes in batch patron modification tool This patch adds the ability to set patron attributes marked as repeatable in the batch patron modification tool. Prior to this patch they were ignored. Test plan: You should try with several combinaisons and set patron attributes using the batch patron modification tool. Make sure there is no data lose and that the result is what you expect Please detail in a comment what you tested. Signed-off-by: Philip Orr Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 --- Comment #11 from Caroline Cyr La Rose --- The error "No protocol specified" from step 2 is this ``` Cypress failed to start. This may be due to a missing library or dependency. https://on.cypress.io/required-dependencies Please refer to the error below for more details. -- Authorization required, but no authorization protocol specified [17:0713/160502.554239:ERROR:ozone_platform_x11.cc(240)] Missing X server or $DISPLAY [17:0713/160502.554617:ERROR:env.cc(255)] The platform failed to initialize. Exiting. -- Platform: linux-x64 (Debian - 11.6) Cypress Version: 12.14.0 ``` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #16 from Nick Clemens --- Created attachment 153420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153420&action=edit Bug 33804: (follow-up) Convert to JSDoc formatted documentation Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 --- Comment #15 from Nick Clemens --- Created attachment 153419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153419&action=edit Bug 33804: Use as_due_date to display due dates Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Nick Clemens changed: What|Removed |Added Attachment #151666|0 |1 is obsolete|| Attachment #151667|0 |1 is obsolete|| Attachment #151668|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 153418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153418&action=edit Bug 33804: Add as_due_date option to $date Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 --- Comment #6 from Andreas Roussos --- Created attachment 153417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153417&action=edit Bug 34258: update SIP-related unit test Test plan: 1) Run the updated SIP-related unit test *without* having applied the other patch from this bug report -- it should fail: $ prove t/db_dependent/SIP/ILS.t 2) Apply the patch that fixes C4/SIP/ILS/Transaction/Renew.pm 3) Re-run the unit test -- it should pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Andreas Roussos changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 --- Comment #5 from Andreas Roussos --- Created attachment 153416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153416&action=edit Bug 34258: pass an unblessed hash to AddIssue() In Koha 23.05, we lost the ability to renew an item via SIP2. The relevant commit is ddc2906b77 from Bug 31735, where the file C4/SIP/ILS/Transaction/Renew.pm was modified to no longer pass an unblessed $patron hash to C4::Circulation::AddIssue() This patch fixes that. Test plan: 1) Using the SIP emulator, check out an item to a patron, then try to renew it. Example commands for a KTD instance: $ misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkout --patron koha --item 30001 $ misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m renew --patron koha --item 30001 Notice that the second command will fail! 2) Apply this patch. 3) Repeat the 2nd command -- this time the renewal should work. 4) Run the SIP-related unit tests, they should all pass: $ prove t/db_dependent/SIP/ t/db_dependent/SIP/ILS.t .. ok t/db_dependent/SIP/Message.t .. ok t/db_dependent/SIP/Patron.t ... ok t/db_dependent/SIP/SIPServer.t ok t/db_dependent/SIP/Transaction.t .. ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Andreas Roussos changed: What|Removed |Added Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34258] Cannot renew item via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Andreas Roussos changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED|REOPENED --- Comment #4 from Andreas Roussos --- (In reply to Jonathan Druart from comment #3) > Bug 32496 should not be backported IMO, so this is valid for stable versions. Thanks Jonathan, that makes sense. I'll re-open this report and upload my patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33956] opac-user.pl should use Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956
Nick Clemens changed:
What|Removed |Added
Attachment #153074|0 |1
is obsolete||
--- Comment #3 from Nick Clemens ---
Created attachment 153415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153415&action=edit
Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl
This code is currently duplicated in controllers opac-readingrecord.pl
and opac-user.pl.
After bug 33949 it will be removed from opac-readingrecord.pl, and bug
33956 aims to remove it from opac-user.pl.
Final situation will be: we have the code in a module, covered by tests
\o/
Test plan:
Check an item out
Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance)
Go to the "Your summary" at the OPAC and notice the "Links" column
Everything should work identically before and after this patch
Signed-off-by: Owen Leonard
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33956] opac-user.pl should use Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33954] Add Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 --- Comment #7 from Nick Clemens --- Created attachment 153414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153414&action=edit Bug 33954: Koha::Biblio->opac_summary_html Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33954] Add Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 Nick Clemens changed: What|Removed |Added Attachment #153072|0 |1 is obsolete|| Attachment #153073|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 153413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153413&action=edit Bug 33954: Add tests Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33954] Add Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33953] Add Koha::Biblio->ratings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 --- Comment #10 from Nick Clemens --- Created attachment 153412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153412&action=edit Bug 33953: Koha::Biblio->ratings Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33953] Add Koha::Biblio->ratings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 Nick Clemens changed: What|Removed |Added Attachment #152720|0 |1 is obsolete|| Attachment #152721|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 153411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153411&action=edit Bug 33953: Adjust tests Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33953] Add Koha::Biblio->ratings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 Nick Clemens changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33952] Add Koha::Biblio->normalized_isbn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 --- Comment #9 from Nick Clemens --- Created attachment 153410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153410&action=edit Bug 33952: Koha::Biblio->normalized_isbn This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33952] Add Koha::Biblio->normalized_isbn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 Nick Clemens changed: What|Removed |Added Attachment #152718|0 |1 is obsolete|| Attachment #153005|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 153409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153409&action=edit Bug 33952: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33952] Add Koha::Biblio->normalized_isbn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize changed: What|Removed |Added Attachment #153407|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 153408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153408&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #1 from Martin Renvoize --- Created attachment 153407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153407&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34145] Patron search broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #5) > Nick, does this patch seem correct to you? I don't recreate, what is the setup? Also, without view_borrower_infos_from_any_libraries you can log into another branch, but still can't see their patrons, so I don't think we should be adding the logged in branch. Can you explain why we should? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #49 from Heather --- I just came across this--I want it SO much!! Unfortunately I don't have the expertise to do a sign off (I don't know how to do all the steps), but I hope someone who does know how to do it signs off on it --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34211] Add +strings for GET /api/v1/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34211 --- Comment #10 from Nick Clemens --- Created attachment 153406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153406&action=edit Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items Allow to embed stringified version of attributes for the "Get items for a biblio" endpoint Test plan: curl -u koha:koha --request GET 'http://localhost:8081/api/v1/biblios/47/items' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34211] Add +strings for GET /api/v1/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34211 Nick Clemens changed: What|Removed |Added Attachment #153092|0 |1 is obsolete|| Attachment #153099|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 153405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153405&action=edit Bug 34211: Add tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34211] Add +strings for GET /api/v1/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34211 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33863] On receive "change currency" is always checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863
--- Comment #24 from Nick Clemens ---
Created attachment 153404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153404&action=edit
Bug 33863: Update values in data that will be saved
We are not saving the values of the input but a representation of the
form, contains in $("#order_edit").data('row');
To acchieve that it's preferable to reuse _update_unitprice and call it
when #change_currency is modified.
Some code cleaning slipped into the patch, for readability purpose.
Signed-off-by: Michaela Sieber
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33863] On receive "change currency" is always checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 --- Comment #23 from Nick Clemens --- Created attachment 153403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153403&action=edit Bug 33863: Reset value if checkbox is unchecked Signed-off-by: Michaela Sieber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33863] On receive "change currency" is always checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Nick Clemens changed: What|Removed |Added Attachment #153341|0 |1 is obsolete|| Attachment #153342|0 |1 is obsolete|| Attachment #153343|0 |1 is obsolete|| --- Comment #22 from Nick Clemens --- Created attachment 153402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153402&action=edit Bug 33863: (bug 25655 follow-up) Check "Change currency" only if checked before We should not check "Change currency" if it has not modified in the original order. Test plan: Create an order with 3+ items Receive 1 item, don't check "change currency" Receive an other item => "Change currency" is not checked Check "Change currency", modify the currency and the price Receive a third item => Change currency is checked, invoice currency and price are set correctly to the previous values Signed-off-by: Michaela Sieber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33863] On receive "change currency" is always checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34273] Notes on phone and email fields when editing patrons 'Shows on transit slips' is unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34273 Nick Clemens changed: What|Removed |Added CC||l...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34273] New: Notes on phone and email fields when editing patrons 'Shows on transit slips' is unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34273 Bug ID: 34273 Summary: Notes on phone and email fields when editing patrons 'Shows on transit slips' is unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Not sure if this refers to the transfer modals, or the notices? If notices, they are configurable now, so this is a but unecessary We should either make it clear, or remove this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34272] New: Add Library of Congress help links for Authority fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34272 Bug ID: 34272 Summary: Add Library of Congress help links for Authority fields Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The bibliographic records have question mark links to Library of Congress help pages in both the basic editor and the advanced editor. It would be nice to add these for the authority editor as well. https://www.loc.gov/marc/authority/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34271] Remove a few Logger statements from REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34271 Marcel de Rooy changed: What|Removed |Added CC||dc...@prosentient.com.au, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34271] Remove a few Logger statements from REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34271 --- Comment #1 from Marcel de Rooy --- Created attachment 153399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153399&action=edit Bug 34271: Remove a few Logger statements from REST API See also bug 22678. We should call app->log->warn, ->debug, etc. instead of Logger. Test plan: The simplest way I tested V1, is add a app->log->warn in the try blocks, restart all and check that your log4perl is set correctly too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34271] Remove a few Logger statements from REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34271 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34270] Upgrade and prune jQueryUI assets in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34270 Owen Leonard changed: What|Removed |Added Blocks||29222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222 [Bug 29222] OMNIBUS: Replace the use of jQueryUI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
