[Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs'

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs'

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||33169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169
[Bug 33169] Improve vue breadcrumbs and left-hand menu
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||33606


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606
[Bug 33606] Access to ERM requires parameters => 'manage_sysprefs'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462

Sam Lau  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |sama...@gmail.com
   |ity.org |
 CC||sama...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300

--- Comment #1 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 153579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153579=edit
Bug 34300: Add holds column to order table

Adds the ability to easily place a hold on an ordered item from a basket

To test:
1) Apply patch
2) Go to acquisitions
3) Go to an existing basket, or create a new one
4) Add an order to the basket
4) Notice there is a "Place hold" column in the Orders table
5) Click the link for an item which allows you to place a hold easily on
the biblio
6) On the columns settings, toggle the "Place hold" column to hide it, and
make sure it gets hidden

Sponsored-by: Pymble Ladies’ College

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

--- Comment #8 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #7)
> It's a fair point. In this case we could keep the legacy behavior with no
> harm. We thought being released a couple months ago made it not such a big
> deal.

I would very much appreciate that. 

> About V1 and breaking changes, I don't think there have been many, but truth
> is we are just reaching a point in which we can call the API stable.

That's true. I suppose we haven't quite reached the full stable "v1" yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #6)
> (In reply to Tomás Cohen Arazi from comment #5)
> > After talking with Martin, I decided to submit this patches the way they are
> > written.
> > 
> > I decided to rename 'userid' => 'identifier' to make it generic enough. I'm
> > open to discuss if you *also* want to be able to specify *userid* and
> > *cardnumber* explicitly, but I think this is the way to go and thus my
> > proposal.
> > 
> > Best regards
> 
> I'd be happy for "identifier" to be added in addition to "userid", but I
> think renaming it is a problematic idea, since "userid" is already in use by
> third-party systems using the production API. 
> 
> Koha has a bit of a habit of making backwards incompatible changes to its
> "v1" API...

It's a fair point. In this case we could keep the legacy behavior with no harm.
We thought being released a couple months ago made it not such a big deal.

About V1 and breaking changes, I don't think there have been many, but truth is
we are just reaching a point in which we can call the API stable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12012] Updating Zebra config files for debian packages

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12012

--- Comment #6 from David Cook  ---
(In reply to Marcel de Rooy from comment #5)
> Yes, I think that it is still valid. We should do some (unpopular)
> housekeeping in this area. Removing myself as assignee for now.

After looking through bug 9612, I see what you're saying now.

I agree about doing some (unpopular) housekeeping.

Although in terms of effort I'm probably more interested in divorcing the Zebra
config  from the Koha config in koha-conf.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |wainuiwitikapark@catalyst.n
   |ity.org |et.nz
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34300] New: Add link to place a hold on ordered items in baskets

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300

Bug ID: 34300
   Summary: Add link to place a hold on ordered items in baskets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Libraries would like the ability to easily place a hold on an ordered item from
the basket.

We envision this button being available next to orders, by the other action
buttons i.e. next to Modify/transfer and Cancel. It would be in its own column
"Place hold" and should be configurable to show or hide using the Table
settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #6 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #5)
> After talking with Martin, I decided to submit this patches the way they are
> written.
> 
> I decided to rename 'userid' => 'identifier' to make it generic enough. I'm
> open to discuss if you *also* want to be able to specify *userid* and
> *cardnumber* explicitly, but I think this is the way to go and thus my
> proposal.
> 
> Best regards

I'd be happy for "identifier" to be added in addition to "userid", but I think
renaming it is a problematic idea, since "userid" is already in use by
third-party systems using the production API. 

Koha has a bit of a habit of making backwards incompatible changes to its "v1"
API...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847

--- Comment #11 from David Cook  ---
(In reply to Kyle M Hall from comment #10)
> (In reply to Tomás Cohen Arazi from comment #6)
> > We shouldn't be using our business classes on the DBRev, as they can change
> > in the future and thus break this DBRev.
> 
> I'm reading this as using DBIC directly is ok. Is that correct?

I agree that we shouldn't be using business classes in the DBRev. 

I think that DBIC directly should be OK so long as only core functionality is
used. (A number of DBIC classes like Suggestion.pm, Itemtype.pm,
ErmAgreement.pm, et cetera have additional code added after "DO NOT MODIFY THIS
OR ANYTHING ABOVE", which is added logic and not drawn directly from the
database.)

In the past, Ruby on Rails used to warn about using models in DB migrations but
those warnings appear to have disappeared from recent documentation:
https://guides.rubyonrails.org/v3.2/migrations.html#using-models-in-your-migrations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33872] Duplicated patron's registration date is set to expiration date of template patron

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33872

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #6 from Emily Lamancusa  ---
Thanks for submitting a patch, Laura!

From what I can tell, this issue occurs when memberentry.pl calls
get_expiry_date( $data{dateenrolled} ) on line 724, because $data{dateenrolled}
is a DateTime object, and get_expiry_date uses the DateTime add method, which
edits the original object rather than returning a copy, according to the docs
(https://metacpan.org/pod/DateTime#Math-Methods). This causes
$data{dateenrolled} to be incorrect, which is why it populates an incorrect
value into the template.

The patch on bug 34117 fixes the underlying data inconsistency by setting
$data{dateenrolled} to a string instead of an object (thus causing
get_expiry_date to create its own object), so that might be the better solution
in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12316] Can't put text and other information on barcode labels

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #8 from Heather  ---
Thank you for reopening this!  It's still needed!  We print barcodes using an
old Zebra printer (so a custom format) and we would love to print our library
name on the barcode label!  We're trying to get the library name (in quotes) to
precede the barcode, and it never works--we just get the barcode and the
barcode number on the label.  I have to use a rubber stamp to then put our name
on every. single. label.:)  Because of the way the ancient Zebra printer
prints, there's space above the barcode, but not below the barcode.  I think
one should be able to put some free text (usually the library name) either
above or below the barcode/barcode number combination.

We're on 22.11.06.

Cheerio!
--h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34157] Exporting labels as a barcode range can cause 500 error

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34157

--- Comment #4 from Heather  ---
And thank you for mentioning that other bug, Katrin--I'll go comment on that
one!

Cheerio!
h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34157] Exporting labels as a barcode range can cause 500 error

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34157

--- Comment #3 from Katrin Fischer  ---
Hi Heather, thx for commenting, that makes a lot of sense actually. I think
this is bug 12316 (that I closed prematurely not thinking of this use case).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12316] Can't put text and other information on barcode labels

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #7 from Katrin Fischer  ---
I believe we still need the option to put text for pre-printing barcode ranges
where the barcode doesn't exist in Koha yet. See bug 34157.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

Michaela Sieber  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Michaela Sieber  ---
Could please someone check

8) Adding orders from a staged/new file


I tested it in 
http://staff-pricevalid.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/basket.pl?basketno=4

but the prices are not stored, the price is always 0.00

I'm not sure if I did everything correctly.

Perhaps this is a separate bug and has nothing to do with the validation.

1) - 7) Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #153569|0   |1
is obsolete||

--- Comment #6 from PTFS Europe Sandboxes  ---
Created attachment 153578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153578=edit
Bug 34169: Add decimal class to all relevant input fields in the acquisitions
module

This is a first step towards more consistency and possibly supporting
multiple input formats as well in the future. It marks all input fields
for monetary values, such as prices, replacement prices etc. with a class
that is linked to a check for number format with the jQuery Validator plugin.

To test:

For any input field to test, try adding various false entries, like "abc" or
"1,00".
It should only accept inputs with decimal dot, like: "1.00"

0) Apply patch, restart_all
1) Suggestion
  * Add a new suggestion in the staff interface
  * Test: price input field at the bottom of the form.
  * Accept the suggestion
2) Order form
  * Create a new basket
  * Create an order line from an existing record
  * Test: list price, replacement price, and actual price.
  * Check the checkbox for uncertain price before you save
3) Uncertain prices
  * Go to the uncertain prices page for this vendor
  * Test: price field
Note: this form does its own validation, but the change should not change
behaviour for now
  * Resolve the uncertain price
  * Close order
4) Receive shipment
  * Test: Shipping cost
5) Receive the order
  * Test: replacement price, actual price
  * Check checkbox for price in foreign currency
  * Test: price in foreign currency
  * Receive order line
6) Invoice summary
  * Finish receiving
  * Test: shipping cost
  * Test: invoice adjustments: amount in the form for the first entry, amount
in the table after adding it
7) Merging invoices
  * Receive another shipment and create and invoice
  * Go to invoices and search all
  * Check the 2 entries for merging
  * Test: shipping cost
8) Adding orders from a staged/new file
  * Export some records using the cart or list
  * Create a new basket
  * Order from new file
  * Import your file, ignore item records
  * Test: price and replacement price
  + Bonus: also test with items, test plan and file from bug 22802 are really
helpful here

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #153568|0   |1
is obsolete||

--- Comment #5 from PTFS Europe Sandboxes  ---
Created attachment 153577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153577=edit
Bug 34169: Use jQuery validator plugin to validate amounts

This is a first step towards more consistency and possibly supporting
multiple input formats as well in the future. It allows us to mark all
input fields for monetary values, such as prices, replacement prices,
fees etc. with a class that is linked to a check for the 'number' format
in the jQuery Validator plugin.

This is the base patch that does nothing by itself, please see
test plan in second patch.

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708

--- Comment #53 from Heather  ---
Thank you again for your help & your email!  I have some questions:

Around step 7, I'm not sure I'm seeing everything I should when looking at a
"Train"--I attached a screenshot.  I'm not sure I saw all this: "Notice that
the attributes linked with a database column are automatically pre filled.
Notice that attributes linked with an authorised value are displayed with a
dropdown list but that a different value can be set..."  So maybe this is why
the columns are empty?  I followed the test plan exactly, and when I added
items to the train, boxes were empty, and therefore the boxes in this column
were empty.  I was able to change the processing and get the different
"non-column" display.  Is this looking the way it should?

I had a problem at step 9--it wouldn't allow me to add items to a train
directly.  I got an error saying I had to add items through the waiting list.

Otherwise, everything worked!  Let me know if the screenshot is looking the way
it should.  And let me know if I'm misunderstanding step 9.  If these are OK, I
can sign off!  It looks like a great enhancement!!!

Cheerio!
h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708

--- Comment #52 from Heather  ---
Created attachment 153576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153576=edit
Screenshot of Train display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34262] Add styling to emphasize the "clear selected patrons" button

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262

Emily Lamancusa  changed:

   What|Removed |Added

Summary|Merging duplicate patrons   |Add styling to emphasize
   |in succession is adding |the "clear selected
   |previously merged duplicate |patrons" button

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

--- Comment #5 from Tomás Cohen Arazi  ---
After talking with Martin, I decided to submit this patches the way they are
written.

I decided to rename 'userid' => 'identifier' to make it generic enough. I'm
open to discuss if you *also* want to be able to specify *userid* and
*cardnumber* explicitly, but I think this is the way to go and thus my
proposal.

Best regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34157] Exporting labels as a barcode range can cause 500 error

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34157

--- Comment #2 from Heather  ---
We stumbled on this bug.  Yes--we use printing a barcode range to pre-produce
labels, to put on an item and then wand in to an item record (e.g., receiving a
serial issue, cataloging a book, etc.)  But we want our library name on the
barcode, so were experimenting with trying to get our library name on the label
and discovered this "500 error."

Our experimenting is related to bug 31507, "When printing barcode range labels
library name does not print."

--h2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 153575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153575=edit
Bug 32739: Allow other patron identifier on pwd validation

This patch takes a step forward on the password validation endpoint, by
renaming the `userid` attribute to `identifier` and making it be allowed
to be the patron's cardnumber.

The implementation relies on `C4::Auth::checkpw` to query for the
patron.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/password_validation.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 153574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153574=edit
Bug 32739: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12802] Send notices using several email addresses

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

--- Comment #109 from mathieu saby  ---
Hi
I am trying to test on a sandbox. Is it possible to purge pending messages
without completely recreating the sandbox ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Martin Renvoize  ---
Thanks Tomas.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #153567|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 153573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153573=edit
Bug 34288: Unit tests

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #153566|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 153572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153572=edit
Bug 34288: (follow-up) Tidy block

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #153565|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 153571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153571=edit
Bug 34288: Allow access to the cataloguing module with `tools` permission

Bug 31162 moved the cataloguing tools to a new cataloguing module home
page. This prevents people without cataloguing permissions, but with
some tools permissions to access things like the labels creator tool.

I tracked all permissions on the cataloging-home.tt template, including
the Stock Rotation ones which I initially missed because I was focusing
on tools.

This patch makes the cataloging-home.pl page require either
'cataloguing' or any relevant 'tools' permission to allow access. the
page.

The staff interface main page and the top bar dropdown are updated using
the same logic to display the cataloguing module link.

For that purpose, I wrapped the permissions on a sub in `C4::Auth`.

To test:
1. Have a patron with only 'catalogue' and some of this permissions:

* inventory
* items_batchdel
* items_batchmod
* items_batchmod
* label_creator
* manage_staged_marc
* marc_modification_templates
* records_batchdel
* records_batchmod
* stage_marc_import
* upload_cover_images
* stockrotation => manage_rotas

2. Log in
=> FAIL: No link to the cataloguing module, neither in the dropdown
3. Apply this patch
4. Repeat 2
=> SUCCESS: You have the link!
5. Play with the different combinations and notice things are sound and
   correct
6. Sign off :-D

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

--- Comment #10 from Martin Renvoize  ---
Ah.. my mistake.. I think `editcatalogue => '*'` covers it as a subpermission
'any' case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

--- Comment #9 from Martin Renvoize  ---
Looking at the fastadd cataloging side of this is making me wonder if the page
permissions are still wrong for that case.. we show the link from the home page
with `( fast_cataloging && CAN_user_editcatalogue_fast_cataloging )` but then
inside the page itself we're looking for 'editcatalogue'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

--- Comment #14 from mathieu saby  ---
Hi
you marked https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34049 as a
duplicate, but I am not sure of that.
By "logs", do you mean logs visible in /tools/viewlog.pl ?

What I meant in 34049 was not to "log" modifications that way, because logs are
often disabled in production Koha for performance issues, and not easy to
consult for the average librarian. I was thinking of a real "feature"
permitting any fund owner/user to see the modifications of their fund. It means
at least (very quick draft) 
- creating a new column inital_amount in aqbudgets
- creating a new SQL table like aqbudgets_changes
- each new line aqbudgets_changes would add or substract money (with an
optional comment) to aqbudgets.budget_amount, without altering
aqbudgets.inital_amount 
and of course some substantial modifications to the templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34299] New: Add Acquisitions functionality to Library Groups

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34299

Bug ID: 34299
   Summary: Add Acquisitions functionality to Library Groups
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Library Groups currently provide flexibility for multi-branch sites and
consortia to limit access to patron data, limit item editing by group, limit
OPAC searches, limit staff searches, and/or define holds behavior. 

It would be beneficial for these large sites to be able to limit budget/funds,
vendors, and baskets by groups to help keep financial, vendor, and
ordering/receiving management to each group.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

--- Comment #13 from Christopher Brannon  ---
At least on our test server, the claims counts are displayed differently than
the other counters.  They are incorporating labels that the others do not.

They are at least consistent now.  I agree with Owen that I don't think it is
necessary to know how many clubs are available, just how many they are signed
up for.  I could still go either way on having both numbers on the inactive
claims.  Maybe just have the number of claims, and if something needs
attention, change the color?

I think if we are going to move towards using labels, all the counters should
be in labels, and we should do away with the parenthesis.  It seems overkill. 
One or the other.  Labels look better and provide more functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34289] UI issue on returns.pl when checking the forgive fines checkbox

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289

--- Comment #1 from Owen Leonard  ---
Created attachment 153570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153570=edit
Bug 34289: Add missing class to one condition of the checkin template

The markup of the checkin template varies depending on the conditions of
the operation, and in one case the barcode field was missing the
"barcode" class. This patch adds it.

To test, apply the patch and make sure the finesMode system preference
is enabled.

- Go to returns.pl (/cgi-bin/koha/circ/returns.pl)
- Expand the the options so you see 'Forgive overdue charges'.
- Check that box and check in an item
- After checkin, the barcode field should keep the same style it had
  before the transaction.
- Note: The yellow background of the input when the "Forgive" checkbox
  is checked is to be expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34289] UI issue on returns.pl when checking the forgive fines checkbox

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34289] UI issue on returns.pl when checking the forgive fines checkbox

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

Katrin Fischer  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com, oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

--- Comment #4 from Katrin Fischer  ---
Created attachment 153569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153569=edit
Bug 34169: Add decimal class to all relevant input fields in the acquisitions
module

This is a first step towards more consistency and possibly supporting
multiple input formats as well in the future. It marks all input fields
for monetary values, such as prices, replacement prices etc. with a class
that is linked to a check for number format with the jQuery Validator plugin.

To test:

For any input field to test, try adding various false entries, like "abc" or
"1,00".
It should only accept inputs with decimal dot, like: "1.00"

0) Apply patch, restart_all
1) Suggestion
  * Add a new suggestion in the staff interface
  * Test: price input field at the bottom of the form.
  * Accept the suggestion
2) Order form
  * Create a new basket
  * Create an order line from an existing record
  * Test: list price, replacement price, and actual price.
  * Check the checkbox for uncertain price before you save
3) Uncertain prices
  * Go to the uncertain prices page for this vendor
  * Test: price field
Note: this form does its own validation, but the change should not change
behaviour for now
  * Resolve the uncertain price
  * Close order
4) Receive shipment
  * Test: Shipping cost
5) Receive the order
  * Test: replacement price, actual price
  * Check checkbox for price in foreign currency
  * Test: price in foreign currency
  * Receive order line
6) Invoice summary
  * Finish receiving
  * Test: shipping cost
  * Test: invoice adjustments: amount in the form for the first entry, amount
in the table after adding it
7) Merging invoices
  * Receive another shipment and create and invoice
  * Go to invoices and search all
  * Check the 2 entries for merging
  * Test: shipping cost
8) Adding orders from a staged/new file
  * Export some records using the cart or list
  * Create a new basket
  * Order from new file
  * Import your file, ignore item records
  * Test: price and replacement price
  + Bonus: also test with items, test plan and file from bug 22802 are really
helpful here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

--- Comment #3 from Katrin Fischer  ---
Created attachment 153568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153568=edit
Bug 34169: Use jQuery validator plugin to validate amounts

This is a first step towards more consistency and possibly supporting
multiple input formats as well in the future. It allows us to mark all
input fields for monetary values, such as prices, replacement prices,
fees etc. with a class that is linked to a check for the 'number' format
in the jQuery Validator plugin.

This is the base patch that does nothing by itself, please see
test plan in second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

--- Comment #8 from Kyle M Hall  ---
Created attachment 153567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153567=edit
Bug 34288: Unit tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

--- Comment #7 from Kyle M Hall  ---
Created attachment 153566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153566=edit
Bug 34288: (follow-up) Tidy block

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #153560|0   |1
is obsolete||
 Attachment #153561|0   |1
is obsolete||
 Attachment #153562|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 153565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153565=edit
Bug 34288: Allow access to the cataloguing module with `tools` permission

Bug 31162 moved the cataloguing tools to a new cataloguing module home
page. This prevents people without cataloguing permissions, but with
some tools permissions to access things like the labels creator tool.

I tracked all permissions on the cataloging-home.tt template, including
the Stock Rotation ones which I initially missed because I was focusing
on tools.

This patch makes the cataloging-home.pl page require either
'cataloguing' or any relevant 'tools' permission to allow access. the
page.

The staff interface main page and the top bar dropdown are updated using
the same logic to display the cataloguing module link.

For that purpose, I wrapped the permissions on a sub in `C4::Auth`.

To test:
1. Have a patron with only 'catalogue' and some of this permissions:

* inventory
* items_batchdel
* items_batchmod
* items_batchmod
* label_creator
* manage_staged_marc
* marc_modification_templates
* records_batchdel
* records_batchmod
* stage_marc_import
* upload_cover_images
* stockrotation => manage_rotas

2. Log in
=> FAIL: No link to the cataloguing module, neither in the dropdown
3. Apply this patch
4. Repeat 2
=> SUCCESS: You have the link!
5. Play with the different combinations and notice things are sound and
   correct
6. Sign off :-D

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34282] ILL batches - availability checking has issues

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282

--- Comment #2 from Pedro Amorim  ---
Created attachment 153564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153564=edit
Bug 34282: Follow-up to fix multiple requests causing high server load, squash
later

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33030] Add standardized subroutine for processing Template Toolkit syntax outside of notices

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34188] Require library selection when logging in

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188

Sam Lau  changed:

   What|Removed |Added

 Attachment #153348|0   |1
is obsolete||

--- Comment #5 from Sam Lau  ---
Created attachment 153563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153563=edit
Bug 34188: Require Library Branch Selection when Logging in

This patch adds the ability to force staff to select a library when logging
into the staff interface. This is done via a new system preference:
'ForcedLibrarySelection'

To test:
1) Apply patch, restart_all, and updatedatabase
2) Log out of the staff interface. Notice the login form looks the same and the
"Library:" dropdown has 'My Library" selected as default. Log back into the
staff interface.
3) In Administration, search for the system preference
"ForcedLibrarySelection". Set it to 'Force' and press save.
4) Log out of the staff interface. Notice that this time, the "Library:"
dropdown is required and has a blank selection as the default.
5) Fill in the username and password but do not select a library. Click 'Log
in'
6) Notice you cannot log in and are asked to 'Please select an item in the
list'
7) Select a library from the drop down and click 'Log in'
8) Notice the login was successful and you were logged in to the library you
selected.
9) Try loggin in with some other libraries to verify it works as expected
10) Sign-off :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34188] Require library selection when logging in

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188

Sam Lau  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34174] Saving RIS results to Error 505

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174

--- Comment #8 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34174] Saving RIS results to Error 505

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667

--- Comment #11 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33667] 'Copy to all libraries' doesn't work on editing holidays

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33667

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497

--- Comment #24 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496

--- Comment #11 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #40 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34298] New: Duplicate existing orders is missing page section on order list

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34298

Bug ID: 34298
   Summary: Duplicate existing orders is missing page section on
order list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When creating an order from an existing order (copy), on the third page, that
lists the selected orders, the page section is missing on the table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript triggers error when showing authority MARC preview

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

--- Comment #6 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34180] Template variable in JavaScript triggers error when showing authority MARC preview

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34180

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34101] Limit items types that can be checked out via SIP2

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101

--- Comment #11 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34101] Limit items types that can be checked out via SIP2

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974

--- Comment #22 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33879] check_cookie_auth overwrites interface set by get_template_and_user

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879

--- Comment #23 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33879] check_cookie_auth overwrites interface set by get_template_and_user

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404

--- Comment #27 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34101] Limit items types that can be checked out via SIP2

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101

--- Comment #10 from Martin Renvoize  ---
As this requires serverside configuration changes to have any effect, I think
we're safe to backport this one to 23.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34297] New: When merging invoices, amounts are not correctly formatted

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34297

Bug ID: 34297
   Summary: When merging invoices, amounts are not correctly
formatted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When merging 2 invoices from the invoices table, the amounts in the table and
the amount in the form are not formatted correctly appearing as 1..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974

--- Comment #21 from Martin Renvoize  ---
API only addition.. choosing to backport to 23.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|martin.renvoize@ptfs-europe |tomasco...@gmail.com
   |.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 153562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153562=edit
Bug 34288: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 153561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153561=edit
Bug 34288: (follow-up) Tidy block

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #153527|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 153560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153560=edit
Bug 34288: Allow access to the cataloguing module with `tools` permission

Bug 31162 moved the cataloguing tools to a new cataloguing module home
page. This prevents people without cataloguing permissions, but with
some tools permissions to access things like the labels creator tool.

I tracked all permissions on the cataloging-home.tt template, including
the Stock Rotation ones which I initially missed because I was focusing
on tools.

This patch makes the cataloging-home.pl page require either
'cataloguing' or any relevant 'tools' permission to allow access. the
page.

The staff interface main page and the top bar dropdown are updated using
the same logic to display the cataloguing module link.

For that purpose, I wrapped the permissions on a sub in `C4::Auth`.

To test:
1. Have a patron with only 'catalogue' and some of this permissions:

* inventory
* items_batchdel
* items_batchmod
* items_batchmod
* label_creator
* manage_staged_marc
* marc_modification_templates
* records_batchdel
* records_batchmod
* stage_marc_import
* upload_cover_images
* stockrotation => manage_rotas

2. Log in
=> FAIL: No link to the cataloguing module, neither in the dropdown
3. Apply this patch
4. Repeat 2
=> SUCCESS: You have the link!
5. Play with the different combinations and notice things are sound and
   correct
6. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34288] Cannot use cataloguing tools without cataloguing permissions

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34288

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

--- Comment #8 from Katrin Fischer  ---
Thanks, Lisette :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com
 Status|Needs Signoff   |Signed Off

--- Comment #7 from Lisette Scheer  ---
Worked as expected!
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Lisette Scheer  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

--- Comment #13 from Lisette Scheer  ---
*** Bug 34049 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34049] Keep track of fund amount modification

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34049

Lisette Scheer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||lisette.scheer@bywatersolut
   ||ions.com
 Status|NEW |RESOLVED

--- Comment #1 from Lisette Scheer  ---


*** This bug has been marked as a duplicate of bug 13325 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron details page

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #5 from Martin Renvoize  ---
Enhancement.. no backport for 23.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

Andreas Roussos  changed:

   What|Removed |Added

 Attachment #153526|0   |1
is obsolete||

--- Comment #7 from Andreas Roussos  ---
Created attachment 153559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153559=edit
Bug 34292: (bug 33804 follow-up) Format "checked out on" date

Signed-off-by: Andreas Roussos 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

--- Comment #6 from Andreas Roussos  ---
Thank you for your feedback, Jonathan. I have now obsoleted my patch and only
kept the typo-fixing patch. I've also tested your patch and it works fine, so
I'm going to sign it off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094

--- Comment #18 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092

--- Comment #34 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs documenting   |Pushed to stable

--- Comment #48 from Martin Renvoize  ---
Needed for simple backport of 34094 and the tree above it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||34094


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094
[Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||28726


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
[Bug 28726] Add sort1 and sort2 to patron card creator patron search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34146] How to limit number of copies (on additem and serials-edit)?

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146

--- Comment #20 from Martin Renvoize  ---
Thanks for all the hard work!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34146] How to limit number of copies (on additem and serials-edit)?

2023-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34146

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >