[Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #4 from Fridolin Somers --- (In reply to Jonathan Druart from comment #3) > Isn't there a flaw in the controller as well? See bug 24860 comment 231. Indeed. In my opinion we should use only 'bibitemloo.forced_hold_level' in TT if possible. bibitemloo.force_hold is not very explicit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Michaela Sieber changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Biblibre Sandboxes changed: What|Removed |Added Attachment #153799|0 |1 is obsolete|| --- Comment #7 from Biblibre Sandboxes --- Created attachment 153818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153818=edit Bug 30451: Update FK constraint on aqorders.subscriptionid This updates the FK constrant from ON DELETE CASCADE to ON DELETE SET NULL. This means that if a subscription linked to an order is deleted, we no longer will also delete the order, but we will just set subscrptinid in the order to NULL. This will avoid data loss that can cause the budgets/funds not to add up anymore with the real espenses of the library. To test: Preparation: * Create 2 subscriptions on different records * Create a new basket * Use the "order from subscription" functionality to create order lines for both of your subscriptions * Close basket Without patch: * Delete the first subscription * Verify the order line for this subscription is gone from your basket Apply patch: * Run database update and restart_all * Delete the second subscription * Verify the order line now remained in the basket Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33909] Improve translation of title tags: Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #4 from Caroline Cyr La Rose --- *Also need to check translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33909] Improve translation of title tags: Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #3 from Caroline Cyr La Rose --- I'm just putting what I checked here. I wrote OK if I was able to confirm it was the same as before. I put a lot of comments too about consistency. Since this bug requires that we look at each page individually one after the other, it's easier to spot inconsistencies. I realize this is outside of the scope of this bug, but if the comment is not deemed too nit-picky, I can open a new bug report to fix it. OK Libraries OK New library - It was there before, but I wonder why the branchcode is there... If it's a new library, it won't have a branchcode yet? Unless I misunderstand what that line does OK Modify library - I wonder if we should have the name or branchcode of the library? OK Delete library confirmation OK Library groups OK Item types OK Add item type - All the other admin pages are titled 'New something' rather than 'Add something' OK Modify item type OK Delete item type confirmation - Phrased as a question rather than the more ubiquitous "Confirm deletion of ..." - Data deleted - I'm unable to get to this page, when I delete an item type, it brings me back to the main item types page... is it only when you delete the last one? OK Authorized values OK Authorized values in category - Same as main authorized values page, was like this before too. Should the title show what category we're in? OK New category OK New authorized value in category OK Modify authorized value - There is no delete confirmation page when deleting a category or authorized value, only a browser prompt. OK Patron categories OK New category OK Modify category OK Cannot delete category - Same as before, but the format is not the same, there is a colon OK Confirm deletion of category OK Circulation and fines rules OK Patron attribute types OK Add patron attribute type - Add vs New (see above) OK Modify patron attribute type - Should we add the code to this? OK Confirm deletion of patron attribute type OK Library transfer limits - It was like this before, but is it normal that the title, header and breadcrumb do not match the admin page and menu link? OK Library transfer limits advanced editor - Same as above, the title header and breadcrumb do not match the admin page and menu links OK Transport cost matrix - Header is inconsistent with other pages (Defining... rather than just the noun) OK Item circulation alerts OK Cities and towns OK New city OK Modify city - Should we add the code/city name? OK Confirm deletion of city - Should we add the code/city name? OK Curbside pickup OK Patron restriction types OK New restriction type OK Modify restriction type OK Confirm deletion of restriction type OK Debit types OK New debit type OK Modify debit type - Should we add the code? OK Credit types OK New credit type OK Modify credit type - Should we add the code? OK Cash registers OK New cash register - The header of the page is Add new cash register, rather than simply New cash register OK Modify cash register - Confirm deletion of cash register - I was not able to access this page. I am only able to archive cash registers, I don't see how to delete them. - Manage plugins - It's the same as before, but I don't see this page being changed in this patch. OK Manage jobs OK Details of job OK MARC bibliographic framework OK Add framework - Add vs New (see above) OK Modify framework OK Delete framework - Phrased as a question rather than the more ubiquitous "Confirm deletion of ..." OK Add tag - Add vs New (although I think it works in this case because you're adding *to* the framework?) - I'm not sure why there is a placeholder for "searchfield" here... if it's new, it shouldn't exist yet... Unless I misunderstand the use of this line. OK Modify tag OK Confirm deletion of tag OK Data deleted (after deleting tag) OK View subfields (MARC subfield structure) OK Edit subfields (Edit MARC subfield constraints) - Edit vs Modify (see bug 28184) OK Confirm deletion of subfield OK Koha to MARC mapping OK MARC Bibliographic framework test - The title and breadcrumb of this page are not consistent with other admin pages... OK Authority types OK New authority type - The heading is really big on this page, and also inside the white area rather than above OK Modify authority type - The heading is really big on
[Koha-bugs] [Bug 34346] New: Adding duplicate tag to a framework leads to error page, should give user readable error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34346 Bug ID: 34346 Summary: Adding duplicate tag to a framework leads to error page, should give user readable error message Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I tried adding a tag to the default framework and got a 500 error. It was because the tag already existed. Elsewhere in Koha, we get a user readable message saying something like "An error occurred when inserting this patron category. The patron category might already exist." To replicate: 1. In the staff interface, go to Administration > MARC bibliographic framework 2. Click the Actions button next to the default framework and choose MARC structure 3. Click New tag 4. Fill out the form to add an already existing tag number Tag: 699 Label for lib: Local subject Label for OPAC: Local subject 5. Click Save changes --> 500 error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34337] Web installer doesn't install patrons when select all is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34337 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34337] Web installer doesn't install patrons when select all is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34337 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] Syntax error in point of sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] Syntax error in point of sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34213] False POD for matchpoint option in import_patrons.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34213 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34213] False POD for matchpoint option in import_patrons.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34213 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34345] New: 'Circulation and fine rules' vs 'Circulation and fines rules'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345
Bug ID: 34345
Summary: 'Circulation and fine rules' vs 'Circulation and fines
rules'
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
In some places, 'fines' is plural and in other places, it is singular. There
might be a reason a native English speaker could explain.
Plural "Circulation and fines rules"
- Administration page
- Administration menu bar on the left
Singular "Circulation and fine rules"
- Circulation and fine rules page title tag
- Circulation and fine rules page breadcrumbs
- Circulation and fine rules page header ("Defining circulation and fine
rules")
- Everywhere else on that page...
Singular seems to be used more, should we change the administration page and
administration menu?
Feel free to close if this is normal and I'm making a mountain out of a
molehill :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] Add cancellation request information embed option to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34344] New: Make item types breadcrumbs uniform
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344 Bug ID: 34344 Summary: Make item types breadcrumbs uniform Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I noticed while testing bug 33909 that the breadcrumbs for the item types administration page are not like the other administration pages. For example, the breadcrumbs in the libraries page are Home > Administration > Libraries The breadcrumbs in the patron categories page are Home > Administration > Patron categories Whereas the breadcrumbs in the item types page are Home > Administration > Item types administration I think we should remove the second "administration". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||This development adds a new release notes||attribute for identifying ||the patron for password ||validation: `identifier`. ||It expects to be passed a ||`userid` or a `cardnumber` ||in it. It the `identifier` ||doesn't match a `userid`, ||then Koha will try matching ||a `cardnumber`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #16) > (In reply to Katrin Fischer from comment #15) > > There is documentation in the patch claiming that userid with cardnumber > > should not work, but it does in my testing: I regretted about making such change. I'll deal with the thing that bothered me about it on a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #3 from Emily Lamancusa --- Trivial patch, looks good and QA tool is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 153817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153817=edit Bug 32739: Allow other patron identifier on pwd validation This patch takes a step forward on the password validation endpoint, by adding the `identifier` parameter and making it be allowed to be the patron's `cardnumber` or the `userid`. The current `userid` only validation option is kept as-is. The implementation relies on `C4::Auth::checkpw` to query for the patron. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/password_validation.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Tomás Cohen Arazi changed: What|Removed |Added Attachment #153776|0 |1 is obsolete|| Attachment #153777|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 153816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153816=edit Bug 32739: Unit tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Attachment #152657|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #17 from Tomás Cohen Arazi --- Nick, can you retest? I decided to restore the original behavior for userid. We will make it better [1] once we move password checking into Koha::*. But the original functionality should remain as-is, and it was a mistake to simplify it like I did. Sorry for that [1] We are fetching the Koha::Patron from the DB, and then checkpw will re-fetch it. This is how the original code works in master BTW. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Assignee|lu...@bywatersolutions.com |jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lucas Gass changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34343] New: Z39.50 search background not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Bug ID: 34343 Summary: Z39.50 search background not updated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org There is a blue gradient in the background of the Z39.50 search window pop-up. I think it is a relic from the old staff interface design... To get there: 1. In the staff interface, go to Cataloging 2. Click New from Z39.50/SRU --> At the bottom of the pop-up window, the background is a blue gradient -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171 Michaela Sieber changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Michaela Sieber --- Thanks Katrin! Tested with Systempreference itemBarcodeInputFilter and bywatersolutions koha-plugin-barcode-transformer Signed Off :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171 ByWater Sandboxes changed: What|Removed |Added Attachment #153800|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 153815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153815=edit Bug 34171: Use barcodedecode when attaching items to another record Bug 26351 added barcodecode that transforms scanned barcodes either by using itemBarcodeInputFilter or via a plugin to various pages in Koha, including checkout and checkin. But the feature for attaching items to a new record was missed. To test: * Add an item with barcode "ab" to any record * Set itemBarcodeInputFilter to "Remove spaces from" * Search for another record in the catalog * Edit > attach item > "a b" * The item is not found. * Apply patch, restart_all * Try again with "a b" * Verify that the item is found and attached to the record Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34267] Add <> to list of cataloguing framework placeholders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34267 Emily Lamancusa changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/703 Documentation||Emily Lamancusa contact|| CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28183] Retain patron-deleted suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28183 --- Comment #1 from Katie Bliss --- We'd love to be able to retain this information. It would be hugely useful for our collections development staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28183] Retain patron-deleted suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28183 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33754] Expand MaxTotalSuggestion to have an option for a calendar month rather than a set number of days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33754 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33965] Hide patron accounts that are for admin use only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33965 Sally Lodico changed: What|Removed |Added CC||slod...@knoxlib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31604] Add the ability to batch add a manual fee to a list of patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31604 Sally Lodico changed: What|Removed |Added CC||slod...@knoxlib.org --- Comment #2 from Sally Lodico --- The opposite would be handy to have too. I'd like a way to batch cancel or write off fines and fees, especially by date or from a report. If they haven't been paid in over 7 or 10 years, they're not likely to be. I suspect this would need to be a new batch edit tool that targets account lines instead of patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145
--- Comment #62 from Katrin Fischer ---
This was ultimately not a bad rebase. The trouble came from bug 31095 removing
GetDebarments.
The only conflicts where in C4/Circulation.pm MarkIssueReturned in the last
paragraph:
# Possibly remove any OVERDUES related debarment
my $overdue_restrictions = $patron->restrictions->search( { type =>
'OVERDUES' } );
if ( C4::Context->preference('AutoRemoveOverduesRestrictions') ne 'no'
&& $patron->is_debarred ) {
my $remove_restrictions =
C4::Context->preference('AutoRemoveOverduesRestrictions') eq
'when_no_overdue_causing_debarment'
? !$patron->has_restricting_overdues( { issue_branchcode =>
$issue_branchcode } )
: !$patron->has_overdues;
if ( $remove_restrictions && $overdue_restrictions->count ) {
DelUniqueDebarment( { borrowernumber => $borrowernumber, type
=> 'OVERDUES' } );
}
}
Once I got it rebased, I rewrote the tests to use $patron->restrictions instead
of GetDebarments. Tests pass now again!
I fixed some "John Doe" commit authorships from Kyle - realizing that our
mailmap already resolves "John Doe" to Kyle automatically, which is a little
confusing when tig, git log and the QA test show different things. Should be
all nice now :)
And last but not least: I applied some perltidy to the files. I didn't get a
perfect result sticking to the changed paragraphs, but it's very close.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #61 from Katrin Fischer --- Created attachment 153814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153814=edit Bug 29145: Perltidy files and added code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 --- Comment #60 from Katrin Fischer --- Created attachment 153813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153813=edit Bug 29145: Replace GetDebarments in unit tests GetDebarments was removed and replaced by $patron->restrictions. The tests needed some adjustments to reflect that change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #145751|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 153812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153812=edit Bug 29145: (QA follow-up) Remove debugging line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #145750|0 |1 is obsolete|| --- Comment #58 from Katrin Fischer --- Created attachment 153811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153811=edit Bug 29145: (QA follow-up) Use objects instead of straight SQL queries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #145749|0 |1 is obsolete|| --- Comment #57 from Katrin Fischer --- Created attachment 153810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153810=edit Bug 29145: (QA follow-up) Rename has_debarring_overdues to has_restricting_overdues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #145720|0 |1 is obsolete|| --- Comment #56 from Katrin Fischer --- Created attachment 153809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153809=edit Bug 29145: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #144782|0 |1 is obsolete|| --- Comment #55 from Katrin Fischer --- Created attachment 153808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153808=edit Bug 29145: (QA follow-up) Add missing POD and don't return undef -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #144781|0 |1 is obsolete|| --- Comment #54 from Katrin Fischer --- Created attachment 153807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153807=edit Bug 29145: (QA follow-up) Fix missing bug number in database update and typos Fixes some typos in test and update message that were highlighted by the QA tools. Add missing bug number to the atomic update file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #144780|0 |1 is obsolete|| --- Comment #53 from Katrin Fischer --- Created attachment 153806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153806=edit Bug 29145: Fix conditions for patron debarring overdues Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #144779|0 |1 is obsolete|| --- Comment #52 from Katrin Fischer --- Created attachment 153805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153805=edit Bug 29145: Add tests and modify sysprefs Add tests, remove ODueDebarmentRemovalAllowUnrestricted syspref and instead modify AutoRemoveOverduesRestrictions to have a third option Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Attachment #144778|0 |1 is obsolete|| --- Comment #51 from Katrin Fischer --- Created attachment 153804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153804=edit Bug 29145: use overdues restrict delays when removing overdues restriction upon return How to test: 1) Run tests in t/db_dependent/Circulation/MarkIssueReturned.t Sponsored by: Gothenburg University Library Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30281] Schedule batch patron deletion and anonymization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30281 Sally Lodico changed: What|Removed |Added CC||slod...@knoxlib.org --- Comment #1 from Sally Lodico --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34342] Barcode auto incremental exceed 13 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34342 Ruth Elliott changed: What|Removed |Added CC||kohasupp...@nlj.gov.jm, ||ruth.elli...@nlj.gov.jm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34342] New: Barcode auto incremental exceed 13 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34342 Bug ID: 34342 Summary: Barcode auto incremental exceed 13 digits Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: ruth.elli...@nlj.gov.jm QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We set the autoBarcode to incremental EAN_13 barcodes and it started to create barcodes that exceed 13 digits and now producing hexadecimal barcodes. We would love to have an idea as to why this is happening. When we create a new item instead of incrementing to the next number it adds another digit example of our barcode is now 100019499147 if I add another item to this record the barcode would be 1000194991471 notice an additional number is added at the end. Please assist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34251] MARC editor with JS error when using fast add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251 Nick Clemens changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #7 from Nick Clemens --- *** Bug 34329 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34329] Broken Save button when adding record via Fast Add framework from checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34329 Nick Clemens changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||n...@bywatersolutions.com --- Comment #3 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 34251 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | --- Comment #18 from Nick Clemens --- There are places where you end up with NaN when you enter invalid format, but you cannot submit and this seems a large improvement, passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #17 from Nick Clemens --- Created attachment 153803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153803=edit Bug 34169: (follow-up) Fix ordering from staged files by removing superfluous form Removes the unneded new form element as we have one big form for the whole page. This should fix the situation where only the prices and information of the first selected record carreid over into the order. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 --- Comment #16 from Nick Clemens --- Created attachment 153802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153802=edit Bug 34169: Add decimal class to all relevant input fields in the acquisitions module This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It marks all input fields for monetary values, such as prices, replacement prices etc. with a class that is linked to a check for number format with the jQuery Validator plugin. To test: For any input field to test, try adding various false entries, like "abc" or "1,00". It should only accept inputs with decimal dot, like: "1.00" 0) Apply patch, restart_all 1) Suggestion * Add a new suggestion in the staff interface * Test: price input field at the bottom of the form. * Accept the suggestion 2) Order form * Create a new basket * Create an order line from an existing record * Test: list price, replacement price, and actual price. * Check the checkbox for uncertain price before you save 3) Uncertain prices * Go to the uncertain prices page for this vendor * Test: price field Note: this form does its own validation, but the change should not change behaviour for now * Resolve the uncertain price * Close order 4) Receive shipment * Test: Shipping cost 5) Receive the order * Test: replacement price, actual price * Check checkbox for price in foreign currency * Test: price in foreign currency * Receive order line 6) Invoice summary * Finish receiving * Test: shipping cost * Test: invoice adjustments: amount in the form for the first entry, amount in the table after adding it 7) Merging invoices * Receive another shipment and create and invoice * Go to invoices and search all * Check the 2 entries for merging * Test: shipping cost 8) Adding orders from a staged/new file * Export some records using the cart or list * Create a new basket * Order from new file * Import your file, ignore item records * Test: price and replacement price + Bonus: also test with items, test plan and file from bug 22802 are really helpful here Signed-off-by: Michaela Sieber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens changed: What|Removed |Added Attachment #153581|0 |1 is obsolete|| Attachment #153582|0 |1 is obsolete|| Attachment #153583|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 153801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153801=edit Bug 34169: Use jQuery validator plugin to validate amounts This is a first step towards more consistency and possibly supporting multiple input formats as well in the future. It allows us to mark all input fields for monetary values, such as prices, replacement prices, fees etc. with a class that is linked to a check for the 'number' format in the jQuery Validator plugin. This is the base patch that does nothing by itself, please see test plan in second patch. Signed-off-by: Michaela Sieber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171 --- Comment #1 from Katrin Fischer --- Created attachment 153800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153800=edit Bug 34171: Use barcodedecode when attaching items to another record Bug 26351 added barcodecode that transforms scanned barcodes either by using itemBarcodeInputFilter or via a plugin to various pages in Koha, including checkout and checkin. But the feature for attaching items to a new record was missed. To test: * Add an item with barcode "ab" to any record * Set itemBarcodeInputFilter to "Remove spaces from" * Search for another record in the catalog * Edit > attach item > "a b" * The item is not found. * Apply patch, restart_all * Try again with "a b" * Verify that the item is found and attached to the record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 --- Comment #6 from Katrin Fischer --- Created attachment 153799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153799=edit Bug 30451: Update FK constraint on aqorders.subscriptionid This updates the FK constrant from ON DELETE CASCADE to ON DELETE SET NULL. This means that if a subscription linked to an order is deleted, we no longer will also delete the order, but we will just set subscrptinid in the order to NULL. This will avoid data loss that can cause the budgets/funds not to add up anymore with the real espenses of the library. To test: Preparation: * Create 2 subscriptions on different records * Create a new basket * Use the "order from subscription" functionality to create order lines for both of your subscriptions * Close basket Without patch: * Delete the first subscription * Verify the order line for this subscription is gone from your basket Apply patch: * Run database update and restart_all * Delete the second subscription * Verify the order line now remained in the basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34329] Broken Save button when adding record via Fast Add framework from checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34329 Carolyn Hughesman changed: What|Removed |Added CC||chughes...@cclsny.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 --- Comment #16 from Hammat wele --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Hammat wele changed: What|Removed |Added Attachment #151649|0 |1 is obsolete|| --- Comment #15 from Hammat wele --- Created attachment 153798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153798=edit Bug 30846: (follow-up) Unit tests Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforlan values as unavailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Hammat wele changed: What|Removed |Added Attachment #151648|0 |1 is obsolete|| --- Comment #14 from Hammat wele --- Created attachment 153797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153797=edit Bug 30846: 'If any unavailable' doesn't consider negative notforlan values as unavailable When we set up a circulation rule where 'On shelf holds allowed' is 'If any unavailable' and we have a record with one 'Ordered' item, we cannot place this item on hold. This patch allows placing hold on item with negative not for loan values, when using rule with 'On shelf holds allowed' set to 'If any unavailable' To test: 1. Set up a circulation rule where on shelf holds are not allowed and force the choosing of an item (to facilitate the test) 1.1. Go to Administration > Circulation and fines rules 1.2. In the matrix, add a circulation like this - Patron category: All - Item type: Books - Current checkouts allowed: 10 - Current on-site checkouts allowed: 10 - Loan period: 21 - Holds allowed (total): 10 - Holds allowed (daily): 10 - Holds per record (count): 10 - On shelf holds allowed: If any unavailable - OPAC item level holds: Force 1.3. Click Save 2. Create a record with one 'Ordered' item (or any negative value not for loan status) 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (by default in MARC21: 000, 003, 005, 008, 040, 245, and 942 (942 should be set to Books)) 2.4. Click Save 2.5. Fill out the following item fields - Not for loan: Ordered - Koha item type: Books 2.6. Click Add item 2.7. Click Normal to go to the detailed record 3. Try to place a hold on the 'Ordered' item 3.1. From the detailed record, click OPAC view: Open in new window. --> Note that the 'Place hold' option is not present 4. Add a second 'Available' item 4.1. Back in the staff interface tab with the detailed record, click New > New item 4.2. Make sure the item type is set to Books 4.3. Add a barcode in p 4.4. Click Add item 5. Try again to place a hold on the 'Ordered' item 5.1. Go back to the OPAC tab and refresh the page --> Note that the 'Place hold' option is still not present 6. Check out the available item to a patron 6.1. In the staff interface tab, copy the barcode from the available item 6.2. Go to Patrons 6.3. Click on Search 6.4. Click Check out next to one of the patrons 6.5. Paste the barcode in the box and click Check out 7. Try again to place a hold on the 'Ordered' item 7.1. Go back to the OPAC tab and refresh the page --> Note that the 'Place hold' option is now present 7.2. Click Place hold --> Note that only the checked out item is available to place on hold, if you click Show unholdable items, it will show the Ordered item, but you can't place a hold on it. 8. Apply the patch 9. Go to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is still present 9.1. Click Place hold --> Note that you can now place a hold on the 'Checked out' or the 'Ordered' item. 10. Check in the item to make it available again 10.1. In the staff interface tab, click on 'Show checkouts' button 10.2. Select the Checked out item and click on 'Renew or check in selected items' button. 11. Try again to place a hold on the 'Ordered' item 11.1. Go back to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is still present 11.2. Click Place hold --> Note that only the 'Ordered' item is available to place on hold, if you click Show unholdable items, it will show the Available item and you can't place a hold on it. 12. Delete the available item to keep only the Ordered item 12.1 in the staff interface tab, click on 'Search catalog' and search for the record 12.2 click on 'Edit' then 'Edit items' 12.3 Delete the available item 13. Try to place a hold on the remain 'Ordered' item 13.1 Go back to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is present 13.2. Click Place hold --> Note that you can place a hold on the Ordered item. Signed-off-by: Amaury GAU Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list
[Koha-bugs] [Bug 34339] $c->validation should be avoided (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34339 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Severity|enhancement |normal --- Comment #5 from Jonathan Druart --- Test plan: All EBSCO related actions must be tested in the eRM module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34339] $c->validation should be avoided (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34339 --- Comment #4 from Jonathan Druart --- Created attachment 153796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153796=edit Bug 34339: Avoid relying on $c->validation - ERM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34339] $c->validation should be avoided (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34339 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 --- Comment #23 from Caroline Cyr La Rose --- (In reply to Jonathan Druart from comment #22) > Yes, add+commit is better. > > I meant: I don't know how keep an up-to-date version of the test plan. > Adding a new comment here does not feel very optimal. Can you create a new comment with the updated test plan and obsolete the old one? Like for test plans in patches? I usually start from the bottom and find the last test plan, as that one is likely the most up to date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21246] Extend the 'Last patron' navigation feature to 'Last 10 patrons'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246
Katrin Fischer changed:
What|Removed |Added
Summary|Extend the 'Last patron'|Extend the 'Last patron'
|navigation feature to 'Last |navigation feature to 'Last
|X patrons' |10 patrons'
Status|Signed Off |Failed QA
--- Comment #3 from Katrin Fischer ---
Testing here:
1) Debugging statement
+console.log("HIDDEN BORROWER: " + $("#hiddenborrowernumber").val() );
Looks like a left over debugging statement?
2) Data privacy / functionality concerns
I remember when this patch was added there was some dicussion about showing
more or less patrons. What I would really like is if we could change the
showLastPatron preference from on/off into a pref for configuring the number of
patrons to show in the list instead of hardcoding 10. Or have a new pref if
that works better?
Overall this works very nicely and I'd love to see this!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 --- Comment #22 from Jonathan Druart --- Yes, add+commit is better. I meant: I don't know how keep an up-to-date version of the test plan. Adding a new comment here does not feel very optimal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #6 from Caroline Cyr La Rose --- Thank you Owen! I'm stumped as to why it didn't work for me yesterday. My working hypothesis right now is that I was too tired and probably mangled the commands to translate. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21246] Extend the 'Last patron' navigation feature to 'Last X patrons'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer changed: What|Removed |Added Attachment #153794|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 153795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153795=edit Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file: > perl translate install fr-FR Test the MARC detail page in your translated language to confirm that the string is correct. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer changed: What|Removed |Added Summary|Item(s) in MARCdetail |'Item(s)' in MARC detail |untranslatable |view untranslatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #28 from Jonathan Druart ---
(In reply to Owen Leonard from comment #26)
> Created attachment 153791 [details]
> Cover image browser with images attached to three items
>
> The cover image navigation seems to be getting duplicated.
Hum, interesting :D
Fixed (amended the patch)!
-$(".cover-slider").each(function(){
+cover_sliders.each(function(){
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] Item(s) in MARCdetail untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] Item(s) in MARCdetail untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Caroline Cyr La Rose changed: What|Removed |Added Attachment #153775|0 |1 is obsolete|| --- Comment #4 from Caroline Cyr La Rose --- Created attachment 153794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153794=edit Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file: > perl translate install fr-FR Test the MARC detail page in your translated language to confirm that the string is correct. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] Item(s) in MARCdetail untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34160] Link item barcode to the item more details page from the holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34160 Katrin Fischer changed: What|Removed |Added Summary|Hyperlink item barcode to |Link item barcode to the |the item more details |item more details page from |editor from the holds queue |the holds queue viewer |viewer | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34160] Hyperlink item barcode to the item more details editor from the holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34160 --- Comment #4 from Katrin Fischer --- Created attachment 153793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153793=edit Bug 34160: Fix filters in URL from html to uri Following the advice of the mighty QA test tools :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34160] Hyperlink item barcode to the item more details editor from the holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34160 Katrin Fischer changed: What|Removed |Added Attachment #153081|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 153792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153792=edit Bug 34160: Hyperlink item barcode to the item more details editor from the holds queue viewer Sometimes librarians fail to find an item on the shelf for a hold and need to mark the item as lost. In these cases it would be helpful to link the barcode to the item's "more details" form in the same way we do for the standard details item barcode hyperlink. Test Plan: 1) View the holds queue, note the item barcode is not a hyperlink 2) Apply this patch 3) Reload the page, note the item barcode is a hyperlink to the more details page for that item! Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34160] Hyperlink item barcode to the item more details editor from the holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34160 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34072] Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Owen Leonard changed: What|Removed |Added Blocks||34341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 [Bug 34341] Revert Bug 34072: Holds queue search interface hidden on small screens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34341] New: Revert Bug 34072: Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Bug ID: 34341 Summary: Revert Bug 34072: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: andre...@dubcolib.org, gmcha...@gmail.com, kyle.m.h...@gmail.com, lu...@bywatersolutions.com, testo...@bugs.koha-community.org Depends on: 34072 I am not able to reproduce Bug 34072 in Koha before the patch. In my test, the holds queue sidebar filter doesn't disappear, it just gets moved down to below the holds queue table when the browser window is below a certain width. This is to be expected with anything in the sidebar. I think the should be reverted. It has unwanted side-effects (changing margins around fieldsets and submit buttons) and doesn't seem to fix any bug as far as I can tell. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 [Bug 34072] Holds queue search interface hidden on small screens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556
--- Comment #28 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #27)
> > (2) The ERM missing changes I'm referring to, are not those on that patch,
> > but the fact this modules make use of `my $args = $c->validation->output` to
> > be passed to the specific classes implementing the business logic for each
> > case, and I didn't 100% understand how things worked (they feel a bit hacky)
> > so wasn't sure about the right way to do it.
>
> It certainly feels hacky, but I will someone to explain how to fix them
> properly.
> We are not manipulating usual Koha::Objects here, we are pulling data for an
> external service and serve it to the Koha ERM Vue app. So we cannot use the
> regular REST::Plugin::, we are trying to behave the same as the other
> objects so that the app does not need to do different for those endpoints.
I mean this:
my $args = $c->validation->output;
my $ebsco = Koha::ERM::Providers::EBSCO->new;
...
my $total = $result->{totalResults};
$total = 1 if $total > 1;
$c->add_pagination_headers(
{
base_total => $base_total,
page => $page,
per_page => $per_page,
query_params => $args,
total=> $total,
}
);
and similar. I wasn't sure how relevant the $args are here. I also feels like
it is not entirely correct, as $c->validation->output actually contains path
parameters, not just query params. So I felt like I didn't have enough
information to fix it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27249] Using the calendar to 'close' a branch can create an infinite loop during renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 --- Comment #9 from Jonathan Druart --- (In reply to Julian Maurice from comment #8) > Maybe there are other sysprefs/circ rules that make Koha the calendar checks > different when checking out or renewing an item... I am using the default values. > Without the patch, do you get the infinite loop when checking out the item ? Yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
