[Koha-bugs] [Bug 34307] Update plugin wrapper to use template wrapper for breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 --- Comment #7 from Victor Grousset/tuxayo --- It works! So second signoff. I've reached for help about reviewing the code. follow-up to improve i18n But there is something weird, there is a part I couldn't change to improve the extracted strings. I did this: ``` [% IF ( plugin_title ) %][% plugin_title | html %] [% END %] Plugins [% IF ( method == 'tool' ) %] Tools [% ELSE %] Administration [% END %] Koha ``` and got this as a diff of the translation files ``` misc/translator/Koha-staff-prog.pot +msgid "%s%s %s Plugins %s Tools %s Administration %s Koha " misc/translator/po/fr-FR-staff-prog.po +"%s%s %s Plugins %s Tools %s " +"Administration %s Koha " +msgstr "Plugins Outils Koha " ``` But I see in the diff that I have individual occurrences of Plugins, Tools, Administration, Koha linked with wrapper-staff-tool-plugin.inc:7 So it's liked it worked, and didn't work at the same time. I checked and the bad occurences aren't in the commented out section of the .po. And they contain the so it's not the remains of the previous version. Any hint? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34307] Update plugin wrapper to use template wrapper for breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 154674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154674=edit Bug 34307: (QA follow-up) add to have cleaner strings for i18n Cleaner strings are extracted this way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34307] Update plugin wrapper to use template wrapper for breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #154324|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 154673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154673=edit Bug 34307: Update plugin template to match master conventions This change uses WRAPPER to build the breadcrumbs and updates the plugin template to follow some other master conventions like differentiating between Administration and Tools for plugins. Test plan: 0. Apply patch 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34307] Update plugin wrapper to use template wrapper for breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | CC||vic...@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- > 4. Note how the plugin page looks like a perfect Koha Tools page Is there anything to do or check about the left menu? Or is that normal that plugins can't insert themselves there? Or maybe they can and it has nothing to do with wrapper-staff-tool-plugin.inc ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34580] ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'DefaultPatronSearchMethod' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 741
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34580 Manos PETRIDIS changed: What|Removed |Added Priority|P5 - low|P3 Severity|enhancement |blocker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 Claudio Costales changed: What|Removed |Added CC||cost...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28688] Automatically renew patron membership
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Amit Gupta changed: What|Removed |Added CC||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz ✔ ❤ ★
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #270 from Victor Grousset/tuxayo --- Oh lol the above don't look like a test, I'm emailing them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33961] In-built Offline circulation tool no longer working and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33961 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|FIXED |--- CC||vic...@tuxayo.net Status|RESOLVED|Needs documenting --- Comment #10 from Victor Grousset/tuxayo --- Still there in the manual at least there: https://koha-community.org/manual/23.05/en/html/circulationpreferences.html#allowofflinecirculation https://koha-community.org/manual/23.05/en/html/circulation.html#offline-circulation-in-koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
