[Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 --- Comment #14 from David Cook --- This one is a nice performance boost. I'm tempted to implement it locally, but I'd love to upstream it first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34064] Compare kohastructure.sql against current database using database audit script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34064 --- Comment #35 from David Cook --- So I think we've figured out the dependency thing. Should this still be BLOCKED or should it go back to "Passed QA"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 --- Comment #5 from David Cook --- Note this change affects both app-based and emailed passwords. It would be way too much work to just do it for emailed passwords. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 --- Comment #4 from David Cook --- Created attachment 155253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155253=edit Bug 30843: Add mfa_range configuration option for TOTP This change adds a mfa_range configuration option for TOTP to koha-conf.xml Test plan: 0. Apply the patch 1. koha-plack --restart kohadev 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=TwoFactorAuthentication 3. Change the syspref to "Enable" 4. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 5. Click "More" and "Manage two-factor authentication" 6. Register using an app 7. In an Incognito window, go to http://localhost:8081/cgi-bin/koha/mainpage.pl 8. Sign in with the "koha" user 9. Note down a code from your Authenticator app 10. Wait until after 60 seconds and try it 11. Note it says "Invalid two-factor code" 12. Try a new code from the app 13. Note that it works 14. Add 10 to /etc/koha/sites/kohadev/koha-conf.xml 15. Clear memcached and koha-plack --restart kohadev 16. Sign in with the "koha" user 17. Note down a code from your Authenticator app 18. Wait 4 minutes and then try it 19. Note that it works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30843] TOTP expiration delay should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30843 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 David Cook changed: What|Removed |Added Attachment #153742|0 |1 is obsolete|| --- Comment #5 from David Cook --- Created attachment 155252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155252=edit Bug 34310: Input prompt in datatables column search boxes untranslatable This patch corrects the internationalization function wrapped around the "% search" string in datatables.js. It should be the double-underscore function instead of the single-underscore. To test, apply the patch and test that the placeholder string is translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/datatables.js for translation, e.g.: \#: koha-tmpl/intranet-tmpl/prog/js/datatables.js:894 \#, javascript-format msgid "%s search" msgstr "%s recherche" - Install the updated translation: > perl translate install fr-FR In the staff interface, test a page that has column header filters, e.g. patron search. Confirm that the table of search results shows the translated string in the column header placeholders. Signed-off-by: Caroline Cyr La Rose Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 --- Comment #4 from David Cook --- There is a little issue with the aria-label for "Expires on" but that's unrelated to this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34085] Remove the use of event attributes from basket groups template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34085 David Cook changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 David Cook changed: What|Removed |Added Severity|enhancement |minor CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34302] Checkin and renewal error messages disappear immediately in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34302 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34302] Checkin and renewal error messages disappear immediately in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34302 David Cook changed: What|Removed |Added Attachment #153970|0 |1 is obsolete|| --- Comment #4 from David Cook --- Created attachment 155251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155251=edit Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened If checkin or renew failed, we should not refresh the table or it will hide the error message. Test plan: Apply the DO NOT PUSH patch Do a renew => No error in the table Apply this patch Do a renew => You see the error Revert the DO NOT PUSH patch Do a renew => The table is refreshed Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34412] Inconsistencies in System preferences page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 David Cook changed: What|Removed |Added Attachment #155233|0 |1 is obsolete|| --- Comment #3 from David Cook --- Created attachment 155250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155250=edit Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and header This patch makes changes to the markup of various areas of the local use system preferences template in order to make it more consistent with other pages in Koha. To test, apply the patch and go to Administration -> System preferences -> Local use. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - On the main page confirm that the heading is "Local use system preferences" - New preference: - The form on this page has been updated to make the markup structure more consistent with other pages, with the heading outside the white box of the form. - The two portions of the form have been combined into one so that the layout of the form is more consistent with similar forms. - Edit preference - Delete: - The deletion confirmation page has been reformatted to use an "alert" style dialog with styled confirmation buttons. - The "Data deleted" view has been reformatted to use a "message" style dialog. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34412] Inconsistencies in System preferences page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34412] Inconsistencies in System preferences page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412
--- Comment #2 from David Cook ---
Comment on attachment 155233
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155233
Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and
header
Review of attachment 155233:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=34412=155233)
-
I have a few comments but none of them are blockers imo
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
@@ +13,4 @@
> [% END %]
> [% END %]
> [% IF ( add_validate ) %]
> +[% t("Preference added") | html %]
I couldn't find a way to see this text but I'm not too worried about it.
@@ +91,5 @@
>
> [% IF ( add_form ) %]
> +
> +[% IF ( modify ) %]
> +Modify a local use system preference
I think this could probably be "Modify preference '[% searchfield | html %]'",
but not a deal breaker.
@@ +283,5 @@
> [% END %]
>
> [% IF ( delete_confirm ) %]
> +
> +Confirm deletion of [% searchfield | html %]?
It would be a good idea to wrap [% searchfield | html %] in single quotes, but
since this is the same before and after the change I don't think it's in scope.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34380] Inconsistencies in Item types page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34380 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I think this patch creates an inconsistency on http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form where the title and breadcrumbs are saying "New item type" but the header is still saying "Add item type". -- I also noticed when I tried to delete the item type "Books" that it just says: "Cannot delete this item type. This record is in use. Deletion is not possible." That differs from the deletion message you see when you try to delete "Computer Files", which asks "Are you sure you want to delete item type 'CF'?" which is one of the updated deletion messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34403] Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34403 David Cook changed: What|Removed |Added Attachment #155228|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 155249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155249=edit Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header This patch updates the currencies administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. To test, apply the patch and go to Administration -> Currencies and exchange rates. Test each variation of the page to confirm that the title, breadcrumbs, and headings are consistent. - Currencies main page - New currency - Edit currency - Delete currency confirmation Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34403] Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34403 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 Evan Giles changed: What|Removed |Added Attachment #155160|0 |1 is obsolete|| --- Comment #6 from Evan Giles --- Created attachment 155248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155248=edit Fix to exit code for koha-foreach -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34400] Inconsistencies in OAI sets page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34400] Inconsistencies in OAI sets page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 --- Comment #2 from David Cook --- Comment on attachment 155035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155035 Bug 34400: Inconsistencies in OAI sets page titles, breadcrumbs, and header Review of attachment 155035: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=34400=155035) - Overall, I think it's looking pretty good, but I did note a new inconsistency introduced by this patch. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt @@ +29,4 @@ > > [% IF ( op_new || op_mod ) %] > [% WRAPPER breadcrumb_item %] > +OAI sets This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. @@ +44,5 @@ > [% END %] > > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] > +OAI sets This change makes the breadcrumb inconsistent with oai_set_mappings.tt though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz Assignee|koha-b...@lists.koha-commun |e...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- (In reply to Kyle M Hall from comment #1) > Test Plan: > 1) Set up MarcItemFields to order > 2) Map the new keys discount, sor1 and sort2 to fields in the order >record > 3) Import an order record into a basket > 4) Note those fields were imported! I don't understand any of these steps . Could we get a more detailed test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34053] Text in holdings table gets wrapped on mobile, breaking words and decreasing readability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34053 David Cook changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- (In reply to Owen Leonard from comment #2) > Now that we have the DataTables responsive plugin on this table I wonder if > we can't remove the entire custom style from #holdingst? Sounds like that's worth a try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34685] updatedatabase.pl does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34685 David Cook changed: What|Removed |Added Attachment #155060|0 |1 is obsolete|| --- Comment #4 from David Cook --- Created attachment 155247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155247=edit Bug 34685: Make updatedatabase.pl propagate the error updatedatabase.pl already return 0 even if an error occurred during the upgrade. Test plan: Adjust a db rev to make it fail and modify the value of the syspref 'version' in DB to make the db rev run. Run updatedabase.pl and `echo $?` Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34685] updatedatabase.pl does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34685 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34685] updatedatabase.pl does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34685 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- My test plan: 0. vi Koha.pm Change $VERSION from "23.06.00.016" to "23.06.00.017" 1. vi installer/data/mysql/db_revs/230600017.pl Added a "die" into the first part of the "up" sub 2a. koha-mysql kohadev 2b. update systempreferences set value = '23.0600016' where variable = 'Version'; 3. echo 'flush_all' | nc -q 1 memcached 11211 4. perl ./installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34684] 220600007.pl is failing if run twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- How do you "play installer/data/mysql/db_revs/22067.pl"? I can't run it on its own using Perl. Do we need to set Version to a particular number or something else? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 --- Comment #6 from David Cook --- Btw also passed QA tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- No problemo on this end -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 David Cook changed: What|Removed |Added Attachment #152421|0 |1 is obsolete|| --- Comment #4 from David Cook --- Created attachment 155246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155246=edit Bug 34038: Fix incorrect use of __() in .tt and .inc files This patch corrects instances of the double-underscore function being used in .tt and .inc files where the single-underscore function should be used instead. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the strings are now in the .po file for translation. You should find these lines: - koha-tmpl/intranet-tmpl/prog/en/includes/js-biblio-format.inc: "No title." - koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: "Check in and add to bundle" "Ignore holds and add to bundle" - koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt: "Please enter only a barcode, or only a biblionumber." - koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt: "Please enter only barcodes, or only biblionumbers." - koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt: "Please specify a content for 'Default'" - Check fr-FR-opac-bootstrap.po for these lines: - koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc: "Please enter a valid date (should match %s)." - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt: "No item was selected" - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: "No item was selected" Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34589] Update on bug 20256 is not idempotent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34589 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Status|Needs Signoff |Failed QA --- Comment #2 from David Cook --- Can we get a test plan for this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #33 from David Cook --- Test plan missing some steps like enabling "SelfCheckInModule" and how to "have something on the SCO page that won't load". I used "SelfCheckInMainUserBlock" with for the self-checkin. I can't get the AutoSelfCheck user to log into the self checkin it seems? Is it supposed to be? But I think the patch is working? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 --- Comment #2 from Aleisha Amohia --- Created attachment 155245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155245=edit Bug 34722: Prevent other items from displaying to fill item-level recalls This patch prevents other items attached to a record from being displayed as 'recalled' by item-level recalls. To test: 1. Ensure UseRecalls system preference is enabled and circulation rules relevant to recalls are configured. Set 'on shelf recalls allowed' circulation rule 'if any unavailable' for ease of testing. 2. Search for a record that has multiple items, or create one with multiple items. Check out two of the items (Item A and Item B) to a patron, Patron A. 3. Log into the OPAC as another patron, Patron B. Search for the record and place a recall. Choose to recall a specific item and select Item A. 4. Go back to the staff interface and view the catalogue detail page for the record. Notice that every item has a 'recalled by...' message, even though Item A was specifically recalled. 5. Log into the OPAC as another patron, Patron C. Search for the record and place a recall. Choose to recall a specific item, notice every item has a 'recalled by...' message. Select Item B and Confirm. 6. In your terminal, the 'Other items are not returned for item-level recalls' test should fail when running prove t/db_dependent/Koha/Item.t 7. Apply the patch and restart services 8. Confirm tests at t/db_dependent/Koha/Item.t now pass 9. Refresh the staff interface, confirm only Items A and B have the recalled message and the recall patron information for each item is accurate 10. Log into the OPAC as another patron, Patron D. Search for the record and place a recall. Choose to recall a specific item. Confirm only Items A and B have the recalled message. Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #32 from David Cook --- I'm getting an error when I try running the selenium test. root@kohadevbox:koha(bug_23102)$ prove t/db_dependent/selenium/regressions.t t/db_dependent/selenium/regressions.t .. # Failed test at t/db_dependent/selenium/regressions.t line 87. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. # 'Log in to your account › Koha online catalog' # doesn't match '(?^u:Self check-in)' # Looks like you failed 1 test of 1. t/db_dependent/selenium/regressions.t .. 1/9 # Failed test 'SCI can load error pages' # at t/db_dependent/selenium/regressions.t line 92. t/db_dependent/selenium/regressions.t .. 7/9 Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. t/db_dependent/selenium/regressions.t .. 9/9 # Looks like you failed 1 test of 9. t/db_dependent/selenium/regressions.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report --- t/db_dependent/selenium/regressions.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=9, 51 wallclock secs ( 0.03 usr 0.01 sys + 3.94 cusr 0.58 csys = 4.56 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 --- Comment #5 from Evan Giles --- Thanks David That's all very helpful feedback. I think understand everything you're saying, so I'll update the patch to include all that. We'll find out if I truly understand soon :) Thanks again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33856] Inventory tool CSV export contains untranslatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 David Cook changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Patch doesn't apply currently. (In reply to Katrin Fischer from comment #2) > Hm, might need a little work with my dependent patch (I see yours still has > problem instead of Problem) I think this is the first problem. It also doesn't take into account bug 22135 and "shelved out of order" I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34043] Improve translation of CSV header templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34705] Koha should use a CSV library to generate CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34705 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 --- Comment #4 from David Cook --- (Little reminder to change the Assignee to yourself after posting a patch as well.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 David Cook changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #3 from David Cook --- The test for this one is a bit too simplistic, and it misses some steps. For instance, after "Apply patch", you need to either copy debian/scripts/koha-foreach to /usr/sbin/koha-foreach, or run the command from "debian/scripts/koha-foreach". As for the simplicity, I've created an alternative test: 1. koha-create --create-db test 2. vi test.sh #!/bin/sh if [ $USER = 'kohadev-koha' ]; then echo "FAILED"; exit 1; else echo "SUCCESS"; exit 0; fi root@kohadevbox:koha(bug_34653)$ debian/scripts/koha-foreach sh test.sh FAILED kohadev: 1 status returned by "sh test.sh" SUCCESS root@kohadevbox:koha(bug_34653)$ echo $? 1 -- With this patch, the exit code will be whatever the last non-zero exit code was in the koha-foreach loop. I'm not sure that's really what we want. I think it might be better if we exit with "1" if any command has a non-zero exit code. To do that, we could keep the current patch for the most part, or we could increment an error counter, or something else. Because we're running in a loop and apparently koha-foreach doesn't ditch out on non-zero exit code, I don't think we should just return the last $rv encountered. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 --- Comment #1 from Aleisha Amohia --- I've confirmed a similar thing shows on the OPAC, if an item-level recall is made, and someone else tries to place a recall on the same record, the message 'recalled by patron' shows for every item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34713] Standardize plugin hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34713 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||34722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 [Bug 34722] All items display as recalled when an item-level recall is made -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 Aleisha Amohia changed: What|Removed |Added Depends on||19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34722] All items display as recalled when an item-level recall is made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34722] New: All items display as recalled when an item-level recall is made
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34722 Bug ID: 34722 Summary: All items display as recalled when an item-level recall is made Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When a recall is requested on a specific item, all holdings on the record show a 'recalled by (borrower)' message on the staff interface catalogue detail page. That message should only show for the specific item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32333] IdRef system preference revamping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 David Cook changed: What|Removed |Added Blocks||34710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34710 [Bug 34710] Remove GreyBox from OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34710] Remove GreyBox from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34710 David Cook changed: What|Removed |Added Depends on||32333 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333 [Bug 32333] IdRef system preference revamping -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Ok so this seem to implement the UNIMARC part of the initial request of the ticket. C4::Heading::MARC21->new() does nothing compared to C4::Heading::UNIMARC->new() I guess the equivalent code might be somewhere else, weird. Though what Andreas found doesn't seem to be the same as what Martin analyzed at the beginning. So maybe it two different optimizations that can be stacked. So anyway, this could keep moving as UNIMARC only and in the end another ticket can be made for if the same could be done for MARC21. And/or keeping the initial proposal of Martin. (not sure if I understood well what we have here and the initial idea) --- The relevant tests seem to be *at least*: prove t/db_dependent/Biblio.t t/db_dependent/Heading.t They fail when when I sabotage C4::Heading::UNIMARC->new() But I can't tell in the detail if they test enough regarding the changes of this patch. No idea about eventual side effects of skipping stuff when $bib_heading_fields if defined. It's likely 100% redundant but I don't have the insight to be sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31584] Default indicators not taken into account when creating records using UseACQFrameworkForBiblioRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31584 --- Comment #4 from Tammy Buehler --- We are having the same issue: I have created a MARC Framework for Acquisitions that has a 264 Tag with a second indicator of 4, subfield c, where we want to input the copyright date. I've included a screenshot of our MARC Framework. However, when our ACQ person fills out the form in Acquisitions and saves the record, the information shows it's recorded in 264 subfield c, but the indicator 4 is not present, even though I have it on the MARC framework. This makes a huge difference in the MARC record, because if the second indicator 4 IS present, the record display shows, "Copyright date: 2017" (Screenshot attached) When the second indicator 4 IS NOT present, it justs shows, "2017" without the copyright date text. (Screenshot attached) I would like to get this fixed so that I don't have to keep going into the MARC record to add the second indicator on this tag, when it should already be displaying according to the framework being used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31584] Default indicators not taken into account when creating records using UseACQFrameworkForBiblioRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31584 --- Comment #3 from Tammy Buehler --- Created attachment 155244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155244=edit Indicator in ACQ MARC Framework -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31584] Default indicators not taken into account when creating records using UseACQFrameworkForBiblioRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31584 --- Comment #2 from Tammy Buehler --- Created attachment 155243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155243=edit Copyright statement with 2nd indicator -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31584] Default indicators not taken into account when creating records using UseACQFrameworkForBiblioRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31584 Tammy Buehler changed: What|Removed |Added CC||bueh...@suu.edu --- Comment #1 from Tammy Buehler --- Created attachment 155242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155242=edit Copyright statement without 2nd indicator Copyright statement without 2nd indicator -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34721] Change facet description for Limit to available items to accurately reflect what it does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34721 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Severity|enhancement |normal Version|22.11 |master Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34721] Change facet description for Limit to available items to accurately reflect what it does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34721 --- Comment #1 from Lucas Gass --- Created attachment 155241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155241=edit Bug 34721: Change facet availability text in staff interface and OPAC To test: 1. Apply patch 2. Do a catalog search in the staff interface. Make sure the 'Availability' button reads 'Limit to records with available items'. 3. Do a catalog search in the OPAC. Make sure the 'Availability' button reads 'Limit to records with available items'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34721] Change facet description for Limit to available items to accurately reflect what it does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34721 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34034] Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- I've signed off, even though I don't have any OverDrive credentials. I was able to trigger the error message by entering some random details for OverDrive credentials. Please change back to needs signoff if this insufficient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34034] Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind changed: What|Removed |Added Attachment #152411|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 155240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155240=edit Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding
[Koha-bugs] [Bug 34034] Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34034 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34721] New: Change facet description for Limit to available items to accurately reflect what it does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34721 Bug ID: 34721 Summary: Change facet description for Limit to available items to accurately reflect what it does Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the Staff Interface the facet for "Limit to currently available items" is incorrectly named. There are a number of bugs in regards to "fixing it", but in the meantime it would be immensely helpful to rename that facet to "Limit to records with available items" for clarity. This would be under Availability on both search.pl and the Advanced search page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33911] Improve translation of title tags: Catalog, basket, and lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33911 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): - MARC preview: wasn't sure how to test this one - normal view for a record > MARC preview > Show - results in a pop-up window with the title "MARC preview", if you right-click on the 'Show' link and open in a new tab, the title is "MARC View" with a plain text rendition of the MARC record. - Labelled MARC details: set IntranetBiblioDefaultView system preference to 'labelled MARC form', from the search results page this view is displayed. - Rota: enable the StockRotation system preference for the rota tab to display on the record view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33911] Improve translation of title tags: Catalog, basket, and lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33911 David Nind changed: What|Removed |Added Attachment #152128|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 155239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155239=edit Bug 33911: Improve translation of title tags: Catalog, basket, and lists This patch updates catalog, basket, and lists templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Advanced search - Search results - Bibliographic details - MARC preview - Image viewer (with local cover images) - MARC details - Labeled MARC details - ISBD details - Items - Checkout history - Rota - Add titles to the cart and view the cart - Send cart - Item search - Lists - View list - New list - Edit list - Send list Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33911] Improve translation of title tags: Catalog, basket, and lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33911 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 Aleisha Amohia changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |alei...@catalyst.net.nz |y.org | CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 Aleisha Amohia changed: What|Removed |Added Attachment #155213|0 |1 is obsolete|| --- Comment #28 from Aleisha Amohia --- Created attachment 155238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155238=edit Bug 34639: Restore order_by To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe success Signed-off-by: Jonathan Druart Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639
Aleisha Amohia changed:
What|Removed |Added
Attachment #155212|0 |1
is obsolete||
--- Comment #27 from Aleisha Amohia ---
Created attachment 155237
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155237=edit
Bug 34639: Use coderef for releationship
This patch switches from a simple relationship to a custom join as
illustrated in the DBIx::Class docs
Reference:
https://metacpan.org/pod/DBIx::Class::Relationship::Base#Custom-join-conditions
This does not include an order_by, so I am not sure if it is sufficient
To test:
1 - On command line:
export DBIC_TRACE=1;
2 - Save simple script:
use Modern::Perl;
use Koha::Items;
my $items = Koha::Items->search( {'me.itemnumber'=>27}, {prefetch =>
'current_branchtransfers'} );
my $item = $items->next;
warn $item->_result->current_branchtransfers->count();
warn $item->get_transfer();
3 - run it
4 - Note that the query doesn't include conditions on the transfers
5 - Apply patch
6 - Repeat
7 - Note that query is correct
Test in staf client:
1. Add an item to library A
2. Go to Circulation -> Transfer
3. Transfer the item from library A to another library B
4. Set your currently logged in library to library B
5. Check-in the item
6. Observe message "Item received from A"
7. View the bibliographic record of the item (catalogue/detail.pl)
8. Observe item in "In transit from A to B since xx/xx/ Available"
9. Apply patch
10. Restart all
11. Reload details - item no longer in transit
Signed-off-by: Lari Taskula
Signed-off-by: Jonathan Druart
Signed-off-by: Aleisha Amohia
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 Aleisha Amohia changed: What|Removed |Added Attachment #155211|0 |1 is obsolete|| --- Comment #26 from Aleisha Amohia --- Created attachment 155236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155236=edit Bug 34639: Add tests To reproduce: 1. Add an item to library A 2. Go to Circulation -> Transfer 3. Transfer the item from library A to another library B 4. Set your currently logged in library to library B 5. Check-in the item 6. Observe message "Item received from A" 7. View the bibliographic record of the item (catalogue/detail.pl) 8. Observe item in "In transit from A to B since xx/xx/ Available" To test: 1. prove t/db_dependent/Koha/Item.t Signed-off-by: Jonathan Druart Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639 Aleisha Amohia changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description to explain consequences of setting in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #3 from Caroline Cyr La Rose --- I have just had a problem of a client disabling this (not sure why) and then their searches weren't returning the results they expected. I liked the description here https://bywatersolutions.com/education/elastic-search-configuration "More specifically, on Elastic 6 and later, if ElasticsearchCrossFields is turned off, Koha will look for all of your search terms in all of your search indices, but only return titles where all of your terms were in the same index. So a search for "bram stoker dracula" would not find the novel (as "bram stoker" is in the author and "dracula" is in the title), but might find you the 1992 film titled Bram Stoker's Dracula." For now, I added more info in the manual. Nick, I hope it's OK with you that I reused your example. https://gitlab.com/koha-community/koha-manual/-/merge_requests/733 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #154853|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 155235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155235=edit Bug 34621: implement Patron import option to 'Renew existing patrons' 'from the current membership expiry date' Test Plan: 1) Test importing a patron with the "from the current membership expiry date" option, note it does not work 2) Apply this patch 3) Restart all the things! 4) Re-test, note the expiration was renewed from the patron's current expiration date! Signed-off-by: David Nind Rebased-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34516] Upgrade database fails for 22.11.07.003, points to web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34516 --- Comment #14 from dcowen...@gmail.com --- I was upgrading from Koha 22.11.07.003. mysql version 8.0.34-0ubuntu0.22.04.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23998] Messages REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34720] UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34720 Kyle M Hall changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30403] Update notforloan status also on check out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Kyle M Hall changed: What|Removed |Added Blocks||34720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34720 [Bug 34720] UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34720] UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34720 Kyle M Hall changed: What|Removed |Added Depends on||30403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 [Bug 30403] Update notforloan status also on check out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34720] New: UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34720 Bug ID: 34720 Summary: UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 30403 creates the syspref UpdateNotForLoanStatusOnCheckin, but it should have created UpdateNotForLoanStatusOnCheckout. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34319] Upgrade Cypress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 155234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155234=edit Bug 34319: (QA follow-up) Add cypress.config.ts to Makefile.PL mapping Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34719] Middle name doesn't show on autocomplete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34719 Erin A. changed: What|Removed |Added CC||erin.arn...@marionfl.org --- Comment #1 from Erin A. --- Our circulation staff noted that middle names and initials did not appear in the search autocomplete when searching for patrons. It would be useful to see middle names when scanning for duplicate accounts or patrons with common first and last names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34412] Inconsistencies in System preferences page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 --- Comment #1 from Owen Leonard --- Created attachment 155233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155233=edit Bug 34412: Inconsistencies in System preferences page titles, breadcrumbs, and header This patch makes changes to the markup of various areas of the local use system preferences template in order to make it more consistent with other pages in Koha. To test, apply the patch and go to Administration -> System preferences -> Local use. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - On the main page confirm that the heading is "Local use system preferences" - New preference: - The form on this page has been updated to make the markup structure more consistent with other pages, with the heading outside the white box of the form. - The two portions of the form have been combined into one so that the layout of the form is more consistent with similar forms. - Edit preference - Delete: - The deletion confirmation page has been reformatted to use an "alert" style dialog with styled confirmation buttons. - The "Data deleted" view has been reformatted to use a "message" style dialog. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34412] Inconsistencies in System preferences page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #19 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34552] No Results when filtering "All payments to the library" or "payment" in Statistics wizards : Cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Nick Clemens changed: What|Removed |Added Version|23.05 |master Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34690] Cypress - Fix random failure in Dialog_spec.ts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34690 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34690] Cypress - Fix random failure in Dialog_spec.ts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34690 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34641] Novelist content does not display on OPAC detail page if NovelistSelectView is set to below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34641] Novelist content does not display on OPAC detail page if NovelistSelectView is set to below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33833] Remove Test::DBIx::Class from t/SocialData.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33833] Remove Test::DBIx::Class from t/SocialData.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
