[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #16 from David Cook --- So where are we at with this one? "Needs Signoff"? "In discussion"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #8 from David Cook --- Created attachment 156198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156198&action=edit Bug 34549: perltidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #7 from David Cook --- (In reply to Owen Leonard from comment #6) > This seems to work, but the QA script complains about tidiness. David can > you take a look? It's taken me a little while but I'm tidying up... 😅 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34909] Show collection code when receiving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34909 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34909] New: Show collection code when receiving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34909 Bug ID: 34909 Summary: Show collection code when receiving items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org When an item is created when placing an order, you can specify fields such as collection code. When attempting to receive this order, i.e. you click Receive on the order line and the Edit Order box pops up, the collection does not show in the items table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34908] Sort item types alphabetically by description rather than code when adding a new empty record as an order to a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34908 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34908] New: Sort item types alphabetically by description rather than code when adding a new empty record as an order to a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34908 Bug ID: 34908 Summary: Sort item types alphabetically by description rather than code when adding a new empty record as an order to a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Item types are sorted by the code rather than the description in the Item type dropdown that is used when adding a new empty record as an order to a basket. To reproduce: 1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test". 2. Go to Acquisitions. Add to a basket from a new empty record 3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 --- Comment #2 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #1) > It seems all the listed dependencies are done, thanks for all the patches! :D Thanks, Victor, but there are still unlisted dependencies left to go. I just haven't gotten around to raising all the reports yet. But there's not too many left to go I think. I'm on holidays a lot the next couple weeks, but I'll be getting back to this after that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34883] Regression in Patron Import dateexpiry function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34883 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Created attachment 156197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156197&action=edit Sample patron import file - Bug 34883 Testing notes (using KTD): 1. I've added the CSV file I used for testing (rename and save into /kohadevbox/koha using whatever file name you want). 2. Command: misc/import_patrons.pl --file /kohadevbox/koha/whatever-you-called-me.csv --matchpoint cardnumber --confirm --overwrite -v -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34883] Regression in Patron Import dateexpiry function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34883 David Nind changed: What|Removed |Added Attachment #156149|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 156196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156196&action=edit Bug 34883: Stop patron expiry date being set to NULL during import A regression has been identified whereby an empty field in the dateexpiry field in a patron import file will cause the patron's expiry date to be set to NULL. This patch addresses this by checking for an empty field and using the existing expiry date if one is found. Test plan: 1) Setup a csv with column headers: surname firstname branchcode categorycodecardnumber dateenrolled dateexpiry 2) Add values: Acosta EdnaCPL PT 23529001000463 02/01/2013 3) Leave the dateexpiry column blank 4) Check Edna and make a note of her patron expiry date 5) Run the import_patrons.pl script with the following flags: a) --file b) --matchpoint cardnumber c) --confirm d) --overwrite 6) Check Edna, note her expiry date is now set to NULL 7) Manually edit Edna's expiry date to be reset to what it was before you ran the script 8) Apply the patch and restart_all 9) Repeat step 5 10) Check Edna, this time her expiry date should be the same as the value you set it to in step 7 11) Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34883] Regression in Patron Import dateexpiry function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34883 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 David Nind changed: What|Removed |Added Attachment #156156|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 156195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156195&action=edit Bug 34645: (follow-up) save sort1 and sort2 in order Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 David Nind changed: What|Removed |Added Attachment #155852|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 156194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156194&action=edit Bug 34645: always use discount, sort1, and sort2 from MarcFieldsToOrder These values are stored at the order level, not per item. This patch simply sets the order values from the values retrieved from MarcFieldsToOrder even inf MarcItemFields to order is being used for other fields To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Note that discount and sort1 and sort2 are not populated per the Marc Apply patch, restart all Stage and add to basket again Confirm discount and sort1 and sort2 are populated correctly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34645] Add missing fields to MarcItemFieldsToOrder system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34645 --- Comment #22 from David Nind --- Thanks Nick! I was able to successfully run through the test plan with and without deleting the existing record. These are the settings I used when staging the file: - Record matching rule: KohaBiblio (999$c) - Action if matching record found: Ignore incoming record (its items may still be processed) - Check for embedded item record data? Yes + How to process items: Always add items I can now see the statistics columns in the basket (used Columns to toggle on the display of the Statistics 1 and Statistics 2 columns). David Latest testing notes (using KTD): 1. Works successfully without needing to delete the existing record 303 (Pawn structure chess). Also works successfully if the existing record is deleted. 2. With existing record and items, use these settings when staging the file: - Record matching rule: KohaBiblio (999$c) - Action if matching record found: Ignore incoming record (its items may still be processed) - Check for embedded item record data? Yes + How to process items: Always add items 3. Steps: 3.1 Remember to set up the MarcFieldsToOrder and MarcItemFieldsToOrder system preferences as per the test plan! 3.2 Stage the file provided - use these settings (as the record and four items already exist): - Record matching rule: KohaBiblio (999$c) - Action if matching record found: Ignore incoming record (its items may still be processed) - Check for embedded item record data? Yes + How to process items: Always add items 3.3 Create a new basket for the vendor, for 'Create items when' select "placing an order" . 3.4 Add to the new basket using the 'From a staged file' option. 3.5 Tick item 'Pawn structure chess' - under the 'match heading' it shows quantity of 8 and correct discount + Sort1 and Sort2 in Statistics 1 and 2 - on the right-hand side, it lists 8 item records with the correct budgets, prices, etc., from the staged file. 3.6 Change to the 'Item information' tab, select a Koha item type (work around for bug 34827). 3.7 Change back to the 'Select to import' tab. 3.8 Click 'Save' at the bottom of the page. 3.9 Result ==> Items are added to the basket: - discount correctly shown on the order lines - use the Columns setting to display the Statistics 1 and Statistics 2 columns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #6) > You are right about the follow-up. I did intend to "move" the space outside > of translations, but forgot to remove it from the string. Good, I just needed a confirmation about this then, Works, makes sense, QA script happy, code looks good, passing QA :) --- (In reply to Katrin Fischer from comment #9) > I think the browser collapses 2 into 1 It indeed looks like that :) > I don't think this needs to be Failed QA? At first I was really not sure to have really found a mistake with the space thing. Hence the "maybe follow-up" and didn't know which status to use. Then I saw it seemed to come from Bug 15348 and got almost sure it was a mistake so Failed QA seemed to fit enough. But still needed a confirmation. Maybe "in discussion" fit better? --- (In reply to Caroline Cyr La Rose from comment #10) > I think Victor maybe wanted some feedback on the follow-up since it's called > "MAYBE FOLLOW UP ..." Yeah, either case it would have been able to move on after settling the space question. > Which is why I tried to test it with and without the follow up patch. I > don't see any difference in the .po file either. Thanks for retesting. > If it's only a clean code thing, it's fine since it doesn't change the > behaviour. > If it's meant to change the string, it's (maybe?) not working. In either case, the translatable string was without a leading space. Nice that it can avoid duplication of strings :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #156144|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #11 from Victor Grousset/tuxayo --- Created attachment 156193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156193&action=edit Bug 34833: (follow-up): remove redundant spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #15 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33926] Add ability to specify fields allowed in a response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33926 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34618] Add sort 1 and 2 fields to basket in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #11 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #16 from Fridolin Somers --- Depends on Bug 29822 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34748] Wrong column name basket_number in table settings for basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34748 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.11.00|23.11.00,23.05.04 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 Maybe depends on Bug 31932 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||hinemoea.via...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault changed: What|Removed |Added Attachment #150222|0 |1 is obsolete|| --- Comment #50 from Hinemoea Viault --- Created attachment 156192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156192&action=edit Bug 30556: Changing the logged-in user's branch by pick-up location Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault changed: What|Removed |Added Attachment #150221|0 |1 is obsolete|| --- Comment #49 from Hinemoea Viault --- Created attachment 156191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156191&action=edit Bug 30556: (follow-up) Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault changed: What|Removed |Added Attachment #150220|0 |1 is obsolete|| --- Comment #48 from Hinemoea Viault --- Created attachment 156190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156190&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault changed: What|Removed |Added Attachment #150219|0 |1 is obsolete|| --- Comment #47 from Hinemoea Viault --- Created attachment 156189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156189&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault changed: What|Removed |Added Attachment #150218|0 |1 is obsolete|| --- Comment #46 from Hinemoea Viault --- Created attachment 156188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156188&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #84 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34016] Enable fulfillment of recalled items through SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34016 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin Somers --- Depends on Bug 32496 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 --- Comment #16 from Tomás Cohen Arazi --- Hi, this are my 2 cents. Another angle for the problem. Keep in mind that: - I haven't written tests - I haven't dug into options for the weird 'outstanding' attribute that gets introduced by ->filter_by_amount_owed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277
--- Comment #15 from Tomás Cohen Arazi ---
Created attachment 156187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156187&action=edit
[ALTERNATE] Bug 34277: (follow-up) Use Koha::Patron->balance_details in GET
/patrons/{patron_id}/account
This patch makes the existing route reuse the introduced method. To
verify no behavior change:
1. Run:
$ ktd --shell
k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass!
2. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 156186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156186&action=edit [ALTERNATE] Bug 34277: Add option to embed balance details on GET /patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 156185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156185&action=edit [ALTERNATE] Bug 34277: Add a way to filter patrons by their outstanding balance This patch adds to new `query parameters` to the `GET /patrons` route: * owes_less_than * owes_more_than This parameters will be used to build a query, based on Koha::Patrons->filter_by_amount_owed, to return only patrons matching the criteria. FIXME: Tests missing yet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #16 from Nick Clemens --- I still got a warning about tidiness, however, the lines I added are tidied and nothing around them is not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 --- Comment #15 from Nick Clemens --- Created attachment 156184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156184&action=edit Bug 28805: (QA follow-up) Pass onsite variable to confirmation screen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 --- Comment #14 from Nick Clemens --- Created attachment 156183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156183&action=edit Bug 28805: (QA follow-up) Restore removed asset Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Nick Clemens changed: What|Removed |Added Attachment #154346|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 156182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156182&action=edit Bug 28805: Add on-site checkout checkbox in batch checkout Add the 'on-site checkout' checkbox to the 'Batch checkout'. To verify the functionality, follow these steps: 1) Before the modification is added, enable the 'OnSiteCheckouts' and 'BatchCheckout' system preferences. 2) In the 'BatchCheckoutsValidCategories' preference, select all categories. 3) Find a user in the system. For example, Henry Acevedo. 4) In the 'Check out' section, you can see that the 'Checkout settings' option displays the 'On-site Checkout' checkbox when clicked. 5) Check the 'On-site checkout' option. This will display the current date with a runtime deadline of 23:59. 6) Enter a barcode (for example 311418). 7) Click the 'Check out' button. This will show that the loan was made on-site. 8) Check the 'Batch checkout' section. This section does not hace the 'On-site checkout' checkbox. When loading the patch with the addition of the 'on-site checkout' checkbox in 'Batch checkout' starting from step 3), you can already find the checkbox in the 'Batch checkout' section. To use it, you can try the barcodes 306179 and 308494 together. Then continue from step 5). When viewing the loans, you will see that both items (306179 and 308494) will appear with the label 'On-site checkout'. If this patch is deactivated, the functionality will remain the same as it was before this change. Sponsored-by: Banco Central de la República Argentina Signed-off-by: Sam Lau Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #66 from Andrii Nugged --- (In reply to Andrii Nugged from comment #65) > Yet it was when I tried to religion from an older session, can't reproduce > 1:1 now, but giving a warning now for team + researching myself further. Own update: it's because $userid also comes empty to that code lines (in cases when old session? thinking aloud) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #82 from Nick Clemens --- Must fix: Applying this patch adds a default left justified, 14pt, 8.5 inches style to all notices which overrides anything set in SlipCSS - this will break user slip customizations - the new formatting must not override SlipCSS - especially if it is adding new defaults. This patchset must not affect existing slips. Ideally there would be nothing saved in the DB by default Should fix: Formatting applies to most things, however, some from print.css take precedence - for a hold slip the doesn't respect the font size I entered - if I enter a font size, I expect the entire notice to respect it - or we need more granular settings here Would fix: As we are storing the form values and using it to generate CSS - we could calculate that on save, and only need a single 'style' field for the slip - this would allow for adding an advanced editor in the future to allow staff to directly enter styles here. Not a blocker per se, but would add less fields and allow future extension. Otherwise each style we want to provide will require a new field Question: For a non-html notice - the formatting is odd. Set OVERDUES_SLIP / Print / HTML Message unchecked Set OVERDUES_SLIP / Format /Text justification: Right, Notice width: 4 Generate the overdue as per test plan Notice is narrow, cuttoff at edge, and not justified Should the style and wrapping div should only be added for html notices? i.e. should the trags be outside of the div and style, or those dropped entirely when notice is not html? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Nick Clemens changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34907] Load datatables on CMS pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34907 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34817] New framework plugin callnumber_colors.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 --- Comment #3 from Katrin Fischer --- Just a note: red / green is not good for accessibility - color blindness is very common. Could we add another visual element that helps to see the status? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34892] Convert RestrictedPageContent system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34892 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32957 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32957] Add option to CMS pages to make page private
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32957 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34892 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31630] Batch item deletion no longer shows which items were not removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 SamSowanick changed: What|Removed |Added CC||sam.sowanick@corvallisorego ||n.gov --- Comment #1 from SamSowanick --- Hello koha community, We recently moved to koha and are experiencing the same problem. It was suggested we voice our want for this resolution. Now we would need to recheck the cart that was just deleted to verify what was and wasn't deleted. Thank you all, Sam Sowanick Digital Services Coordinator. Corvallis-Benton County Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32957] Add option to CMS pages to make page private
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32957 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #1 from Lisette Scheer --- +1 this would be very helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34779] Pages: Remove "Appear in position?"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34779 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #1 from Lisette Scheer --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34863] Allow definition of custom url for pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34863 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com --- Comment #1 from Lisette Scheer --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34907] New: Load datatables on CMS pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34907 Bug ID: 34907 Summary: Load datatables on CMS pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It would be nice we loaded/could optionally load datatables on custom pages for table consistency. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Andrii Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
--- Comment #65 from Andrii Nugged ---
(In reply to David Nind from comment #63)
> Created attachment 155540 [details] [review]
> Bug 15504: (follow-up) Migrate to one clear method
my $patron = Koha::Patrons->find({ userid => $userid });
$patron->update_lastseen('login');
I've got one case when it returned empty $patron, so that led to:
[ERROR] Can't call method "update_lastseen" on an undefined value
at /usr/share/koha/lib/C4/Auth.pm line xxx.
Yet it was when I tried to religion from an older session, can't reproduce 1:1
now, but giving a warning now for team + researching myself further.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34906] barcodes issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34906 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34906] New: barcodes issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34906 Bug ID: 34906 Summary: barcodes issue Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nasralyashas...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi, I have a problem with my Koha system I have some books in my system and I have assigned a barcode to each book in opac I have the barcode for each book but the issue is when I want to check out one of the books it gives me this barcode does not available in the database and when I go to the database there is no barcodes. So how can I fix this? any help! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Owen Leonard changed: What|Removed |Added Attachment #156180|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 156181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156181&action=edit Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34884] Allow styling and customization of checkout screen by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34884 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34817] New framework plugin callnumber_colors.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #2 from Kelly McElligott --- Upon testing this, I wonder, if the red/green action should be stopping the user from continuing on through the process. Regardless if I had a new call number - green or a copy of a call number- red, it saved the item and moved on. This process was actaully super quick, like it flashed red/ green very quickly, and this could be missed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34671] Collapsing fields in patron form allows saving without mandatory fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34671 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #5 from Kelly McElligott --- Upon testing this, I did see the error message under the collapsed address field, so that works successfully. However, I did not see the same error on the Guarantor Collapsed field. I can not save the form without the relationship of the guarantor, but that does not show if the field is collapsed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Pedro Amorim changed: What|Removed |Added Blocks||34905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 [Bug 34905] ILL - "Place request with partners" icon is gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Pedro Amorim changed: What|Removed |Added Depends on||32910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 --- Comment #1 from Pedro Amorim --- Created attachment 156180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156180&action=edit Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34905] ILL - "Place request with partners" icon is gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34905] New: ILL - "Place request with partners" icon is gone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34905 Bug ID: 34905 Summary: ILL - "Place request with partners" icon is gone Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amo...@ptfs-europe.com CC: pedro.amo...@ptfs-europe.com 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 Pedro Amorim changed: What|Removed |Added Attachment #156089|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 156179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156179&action=edit Bug 34842: Fix Illrequest/Config.t if DB upgraded twice Not sure this is correct, but I think it is! Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842 --- Comment #5 from Pedro Amorim --- (In reply to Jonathan Druart from comment #0) > I think we should adjust the atomic update from bug 32911 and set the > syspref to "IL" if the config was "ILLLIBS". What do you think Pedro? I think we should make sure that k-t-d now has IL instead of ILLLIBS. The problem is that the updatedatabase will set the preference to ILLLIBS as that is what is coming from the config file, but IL is the category in the database, not ILLLIBS, so it gets botched. Existing installations using this feature will certainly have a existing in their conf file so will not experience this. (In reply to Pedro Amorim from comment #4) > > I'm not sure about the change to Config.pm, see bug 21548. This is fine, I tested and it works as expected. Ran update systempreferences set value = "" where variable ="ILLPartnerCode"; And tried to place a request with partners, it still defaults to 'IL' correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34842] t/db_dependent/Illrequest/Config.t is failing if the DB has been upgraded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34842
--- Comment #4 from Pedro Amorim ---
(In reply to Jonathan Druart from comment #1)
> Hum, I don't understand. Is the config still exists or not?
> Is the syspref only a fallback??
>
> * is($config->partner_code, "IL", "partner_code: Undefined partner_code is
> undefined.");
>
> Then it's not undefined!
>
> * Koha/Illrequest/Config.pm
> 258 partner_code => 'IL',
> then...
> 322 $configuration->{partner_code} =
> C4::Context->preference('ILLPartnerCode') || 'IL';
>
> Please clarify!
Hey!
k-t-d has ILLLIBS in
/etc/koha/sites/kohadev/koha-conf.xml.
To preserve functionality, the upgrade takes whatever already exists in
koha-conf.xml and sets that to the new system preference ILLPartnerCode.
We don't need to worry about multiple upgrade because of INSERT IGNORE, i.e.
it'll only read from the koha-conf.xml and put it in the database the first
time.
For clean-up, we could consider removing from koha-conf.xml
after the upgrade has ran successfully, but it even if it's there - it's not
being used anymore.
I'm not sure about the change to Config.pm, see bug 21548.
The fixes in the tests look good, I missed mocking the preference.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #10 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #9) > I don't think this needs to be Failed QA? I think Victor maybe wanted some feedback on the follow-up since it's called "MAYBE FOLLOW UP ..." Which is why I tried to test it with and without the follow up patch. I don't see any difference in the .po file either. If it's only a clean code thing, it's fine since it doesn't change the behaviour. If it's meant to change the string, it's (maybe?) not working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #3 from Pedro Amorim --- Created attachment 156178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156178&action=edit Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #9 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #8) > to be precise, I meant that I only saw one space before the parenthesis (I > checked by highlighting the text), with and without the follow-up patch... > > Maybe I'm misunderstanding what is being discussed... I think the browser collapses 2 into 1, but it's cleaner not to add them twice and the space at the beginning of a string might be problematic for translations too. I don't think this needs to be Failed QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #8 from Caroline Cyr La Rose --- to be precise, I meant that I only saw one space before the parenthesis (I checked by highlighting the text), with and without the follow-up patch... Maybe I'm misunderstanding what is being discussed... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #156175|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 156177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156177&action=edit Bug 34737: (follow-up) Code more defensively This patch adds some defense for errant preference lines, allowing for empty lines, comment lines and even skipping easily identified malformed lines. Signed-off-by: Toni Ford -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #156174|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 156176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156176&action=edit Bug 34737: (follow-up) Unit test for skipping bad lines We update the test rules set to include some malformed, empty and comment lines. No actual tests are added, but the skipping is checked by all other tests in this way. Signed-off-by: Toni Ford -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34833] "order number" untranslatable when editing estimated delivery date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34833 --- Comment #7 from Caroline Cyr La Rose --- I tried before and after the follow-up and did not see a difference in the interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #156147|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 156175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156175&action=edit Bug 34737: (follow-up) Code more defensively This patch adds some defense for errant preference lines, allowing for empty lines, comment lines and even skipping easily identified malformed lines. Signed-off-by: Toni Ford -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #156148|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 156174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156174&action=edit Bug 34737: (follow-up) Unit test for skipping bad lines We update the test rules set to include some malformed, empty and comment lines. No actual tests are added, but the skipping is checked by all other tests in this way. Signed-off-by: Toni Ford -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #155666|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 156173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156173&action=edit Bug 34737: Tidy t/db_dependent/SIP/Transaction.t Signed-off-by: Toni Ford Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #155665|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 156172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156172&action=edit Bug 34737: (follow-up) Squelch a warning We weren't checking whether an item property was defined or not and as such the new test highlighted a new warning. Signed-off-by: Toni Ford Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #155664|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 156171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156171&action=edit Bug 34737: Unit tests This patch adds unit test to prove the multi-field match functionality added in this patchset. Signed-off-by: Toni Ford Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Martin Renvoize changed: What|Removed |Added Attachment #155663|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 156170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156170&action=edit Bug 34737: Add ability to match on combinations of item fields This patch updates the sort bin selection logic to allow for multiple item field comparisons in a single config rule line. Test plan 1) Run the unit tests before and after applying this patch and confirm they pass in both cases (prove -v t/db_debendant/SIP/Transaction.t 2) Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N2020042212430020200422124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) 4) Check there is no CL field in the last response 5) Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:eq:BK:ccode:eq:TEEN:3 6) Repeat the first step 7) Check the response contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| Signed-off-by: Toni Ford Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Kyle M Hall changed: What|Removed |Added Attachment #156168|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 156169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156169&action=edit Bug 22873: Add comment to explain what disallow_overpayment is for Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 --- Comment #6 from Kyle M Hall --- Created attachment 156168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156168&action=edit Bug 22873: Add comment to explain what disallow_overpayment is for -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23565] Add columns configuration and export options to item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23565 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #6 from Caroline Cyr La Rose --- (In reply to Owen Leonard from comment #0) > Question: Should this make the "Export results to CSV" option obsolete? The > "Export results to CSV" button automatically exports all results. The > DataTables export button exports only visible results. Maybe keep it but rename to "Export all results to CSV"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > (In reply to Kyle M Hall from comment #3) > > It is used in a SIP option. Take a look at etc/SIPconfig.xml in master. > > So should this be closed? Let's add a comment so future devs will know what it is there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34653] Make koha-foreach return the correct status code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34653 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23565] Add columns configuration and export options to item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23565 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34892] Convert RestrictedPageContent system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34892 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #4 from Owen Leonard --- We would have to build some kind of flag into the additional_contents system to allow it, but I don't see why not. In fact such a setting could be used to show or hide any kind of content, html_customization, news, or page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34153] Add ability to allow items with additional materials notes to be checked out via SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #12 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #11) > Lol perltidy puts tons of spaces to align $response with 'equals'. > >check_field( > >$respcode, $response, FID_SCREEN_MSG, 'Item must be checked > > out at a circulation desk', > >'Check screen msg', 'equals' > >); I agree it's an interesting choice, but we have a community .perltidyrc as of bug 30002 and it's just doing what it's told to. If we don't like those results we should probably have a followup to bug 30002. > Last point to settle is whether allow_additional_materials_checkout should > be on by default. I don't have an educated enough opinion on this. I did not add the option to the debian SIPconfig.xml template, so it is off by default ( as it should be to retain current behavior ). The file etc/SIPconfig.xml is just an example file to demonstrate all the possible options in the SIP config, so it's fine to have it "enabled" there! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
