[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||the card expiration message ||on a patron's page so that ||it now includes the date ||that their card will ||expire. --- Comment #7 from David Nind --- Hi Émily-Rose. I amended your patch (I perhaps should have done this as a follow-up): 1. Removed the extra space in the commit message bug title, so that it now reads as "Bug 34462: Display..." instead of "Bug 34462 : Display...". 2. I added a full stop after the date, so the message displays as "... Patron's card expires on 10/18/2023. Renew or Edit details". I also added a follow-up patch to shorten the message to make it more succinct, as there is a bit of duplication. So the expiration message now reads as "Expiration: Patron's card expires on 10/18/2023. Renew or Edit details". Feel free to obsolete this patch if you disagree 8-). David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 David Nind changed: What|Removed |Added CC||da...@davidnind.com Attachment #156337|0 |1 is obsolete|| --- Comment #6 from David Nind --- Comment on attachment 156337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156337 Bug 34462 : Display the patron's expiration date Not sure what I did when signing off, obsoleting patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #5 from David Nind --- Created attachment 156360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156360=edit Bug 34462: (follow-up) Shorten card experiation message Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #4 from David Nind --- Created attachment 156359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156359=edit Bug 34462: Display the patron's expiration date The problem is in the patron_messages.inc file on line 25. The variable "expiry" is used, but it should be "patron.dateexpiry" because the patron's card isn't expired yet. TEST PLAN 1) Go to “Patrons > + New patron” 2) Create a patron with an expiry date that is less than 30 days in the future 3) Go to the "details" tab of this account 4) Notice that the date is missing after "expires on": "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5) Apply the patch 6) Reload the page; the expiry date should now be displayed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Blocks||34953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34953 [Bug 34953] Create page layout templates for CMS pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34953] Create page layout templates for CMS pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34953 Aleisha Amohia changed: What|Removed |Added Depends on||15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34953] New: Create page layout templates for CMS pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34953 Bug ID: 34953 Summary: Create page layout templates for CMS pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org It would be helpful to select a page layout that would insert some HTML into the CMS pages editor, and librarians could make their cusotmisations within that template. For example, a 3 column page, a 2 column page, a webform, etc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Blocks||34952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34952 [Bug 34952] Ability to limit visibility of CMS pages by logged in patron category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34952] Ability to limit visibility of CMS pages by logged in patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34952 Aleisha Amohia changed: What|Removed |Added Depends on||15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34952] New: Ability to limit visibility of CMS pages by logged in patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34952 Bug ID: 34952 Summary: Ability to limit visibility of CMS pages by logged in patron category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org It would be awesome if we could choose which patron categories could view/access CMS pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Blocks||34951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34951 [Bug 34951] Ability to make draft CMS pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34951] Ability to make draft CMS pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34951 Aleisha Amohia changed: What|Removed |Added Depends on||15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34951] New: Ability to make draft CMS pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34951 Bug ID: 34951 Summary: Ability to make draft CMS pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org It would be great to have a more explicit 'draft' state for CMS pages. We can use publication date/expiration date to 'schedule' pages but it would be great to have pages that are able to be viewed in their context (not just previewed) but aren't public or published yet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Blocks||32957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32957 [Bug 32957] Add option to CMS pages to make page private -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32957] Add option to CMS pages to make page private
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32957 Aleisha Amohia changed: What|Removed |Added Depends on||15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34944] Remove the use of event attributes from OPAC full serial issue page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||vic...@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- It works! :) testing notes: > To test you must have a serial record with issues from multiple years. create a subscription (no very frequent to not need tons of issues per year) => receive => multi receive => tons => here you go, you should have a few years -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34944] Remove the use of event attributes from OPAC full serial issue page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34944 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #156323|0 |1 is obsolete|| --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 156358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156358=edit Bug 34944: Remove the use of event attributes from OPAC full serial issue page This patch removes the use of event attributes (onclick) from the OPAC's full serial issues template. These events are defined now along with the other in-page JS. To test you must have a serial record with issues from multiple years. - Locate the serial record and view the detail page. - Click "More details" at the bottom of the "Subscriptions" tab. - Click the "Full history" tab. - Test the "Show year" controls to confirm that clicking each year correctly filters the table of issues to show only issues from that year. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34947] Koha Manual search does not bring user to the relevant place in the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34947 --- Comment #1 from David Nind --- See also the discussion on the GitLab issue https://gitlab.com/koha-community/koha-manual/-/issues/34 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #17 from David Nind --- The patch no longer applies 8-(.. 155719 - Bug 33703: Add cleave.js for direct input dateformatting 155861 - Bug 33703: (follow-up) declare variables 155862 - Bug 33703: Add cleave.js (OPAC) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33703: Add cleave.js for direct input dateformatting Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 33703: Add cleave.js for direct input dateformatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||UTF-8 characters for write ||off notes under a patron's ||accounting section. ||Previously, if you added a ||note when writing off ||multiple charges ([Patron] ||> Accounting > Make a ||payment > Payment note ||column > + Add note), a ||note with special ||characters (for example, ||éçö) did not display ||correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 --- Comment #10 from David Nind --- (In reply to Émily-Rose Francoeur from comment #8) > I forgot last time to mark one of the attachments as obsolete. Now, it > should work. I've also updated the test plan to make it clearer. Thanks Émily-Rose! Now signed off. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 --- Comment #9 from David Nind --- Created attachment 156357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156357=edit Bug 34870: Perform UTF8 encoding before redirection Display special characters correctly when writing off an invoice. The issue arises because pay.pl does not perform UTF-8 encoding on the “notes” parameter before redirecting the page. By using uri_escape_utf8, characters with a code above 255 are also UTF-8 encoded. Then, paycollect.pl can collect the information without any trouble. This patch work with “;” and “:” characters. TEST PLAN 1) Go to any patron profile > Accounting 2) Click “Create manual invoice” 3) Fill the fields and click the “Save” button 4) Repeat steps 2 and 3 5) Click “Make a payment” 6) Add a note with special characters for each one (e.g., éçö) 7) Select the created invoices and click the “Write off selected” button 8) In the note field, you should see “�” symbols where the special characters are supposed to be 9) Click the “Cancel” button 10) Now add a note with “:;” for one of the invoices 11) Select the invoices and click the “Write off selected” button 12) You should see a page with an error 500 13) Go back to the “Make a payment” page 14) Apply the patch 15) Add a note with special characters for each one (e.g., éçö) 16) Add “:;” to one of the note fields 17) Select the invoices and click the “Write off selected” button 18) Now the special characters are displayed correctly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34950] New: ILS DI Availability is not accurate for items on holds shelf or in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34950
Bug ID: 34950
Summary: ILS DI Availability is not accurate for items on holds
shelf or in transit
Change sponsored?: ---
Product: Koha
Version: 22.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Web services
Assignee: koha-bugs@lists.koha-community.org
Reporter: blaw...@clamsnet.org
QA Contact: testo...@bugs.koha-community.org
The ILS DI web service is a handy way for a third party system, such as a
mobile app, to check for the availability of items for a given bib record in
your system.
If you make a call like
https://{OPAC_DOMAIN}/cgi-bin/koha/ilsdi.pl?service=GetAvailability={BIB_ID}_type=bib
the response shows the availabilitystatus of items that are on the holds shelf
or in transit as 'available'.
While these items may be technically available to be checked out, it's not
ideal to send the message to patrons that these items are available because
they may show up at the library to get the book and be disappointed :(
It would be more accurate and informative if ILS DI could show
availabilitystatus 'not available' with availabilitymsg indicating 'on hold
shelf' or 'in transit' for these items.
Alternatively it would be nice to have a REST API endpoint for item
availability to easily get this info to third party developers.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34949] New: aqua
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34949 Bug ID: 34949 Summary: aqua Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: misopanjing...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 156356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156356=edit Aqua slot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #366 from Émily-Rose Francoeur --- Created attachment 156355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156355=edit Bug 17015 : Correction when creating a new library This patch is a rebase of all the other ones. I have also resolved an issue that occurred when creating a new library. When creating a library, days are copied from the first library in the "branches" table and added to the new library in the "discrete_calendar" table. The problem arises because the table stores libraries in alphabetical order based on their branch code. So, if the new library has a branch code that comes first in alphabetical order, no days can be added, which would prevent the calendar from functioning for that library. I resolved this issue by copying the days from the first library that appears in the "discrete_calendar" table. This way, we ensure that days will be found and copied. TEST PLAN 1) Apply the patch 2) Run installer/data/mysql/updatedatabase.pl 3) Run misc/cronjobs/add_days_discrete_calendar.pl 4) Check that the max date is today + 1 day 5) Run t/db_dependent/DiscreteCalendar.t 6) If all the test pass, then the rebase work 7) Now, go to “Koha administration > Libraries > New library” 8) In “Library code” enter “A” 9) Enter the name that you want 10) Click the “Submit” button 11) Go to “Tools > Calendar” 12) Select the calendar for the library you just created 13) If there are no errors displayed on the page, the issue is resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151450|0 |1 is obsolete|| --- Comment #365 from Émily-Rose Francoeur --- Created attachment 156354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156354=edit Bug 17015: Corrections for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151449|0 |1 is obsolete|| --- Comment #364 from Émily-Rose Francoeur --- Created attachment 156353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156353=edit Bug 17015: Miscellaneous corrections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151448|0 |1 is obsolete|| --- Comment #363 from Émily-Rose Francoeur --- Created attachment 156352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156352=edit Bug 17015: Always uncheck "Copy all librairies" when opening edit page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151447|0 |1 is obsolete|| --- Comment #362 from Émily-Rose Francoeur --- Created attachment 156351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156351=edit Bug 17015: UI tweaks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151446|0 |1 is obsolete|| --- Comment #361 from Émily-Rose Francoeur --- Created attachment 156350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156350=edit Bug 17015: Add minDate restrictions for pairs of date selectors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151445|0 |1 is obsolete|| --- Comment #360 from Émily-Rose Francoeur --- Created attachment 156349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156349=edit Bug 17015: Add an option to view past holiday details in table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151444|0 |1 is obsolete|| --- Comment #359 from Émily-Rose Francoeur --- Created attachment 156348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156348=edit Bug 17015: Allow holiday edits to be applied to all branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151443|0 |1 is obsolete|| --- Comment #358 from Émily-Rose Francoeur --- Created attachment 156347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156347=edit Bug 17015: Add description field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151442|0 |1 is obsolete|| --- Comment #357 from Émily-Rose Francoeur --- Created attachment 156346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156346=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151441|0 |1 is obsolete|| --- Comment #356 from Émily-Rose Francoeur --- Created attachment 156345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156345=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151440|0 |1 is obsolete|| --- Comment #355 from Émily-Rose Francoeur --- Created attachment 156344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156344=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151439|0 |1 is obsolete|| --- Comment #354 from Émily-Rose Francoeur --- Created attachment 156343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156343=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Émily-Rose Francoeur changed:
What|Removed |Added
Attachment #151438|0 |1
is obsolete||
--- Comment #353 from Émily-Rose Francoeur
---
Created attachment 156342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156342=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts
Signed-off-by: Michal Denar
Bug 17015: When using book drop mode, set check in time as closing hours
Signed-off-by: Michal Denar
Bug 17015: Automatically update calendar when creating or deleting a branch
Signed-off-by: Michal Denar
Bug 17015: Rebase and tests for discrete calendar
This patch is a rebase of all the previous patches in order to show the
discrete calendar.
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)
Signed-off-by: Michal Denar
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
Bug 17015: Fixing QA tools failures
This patch fixes tests that fails with the QA tool.
To test, run the QA tool
All tests should say OK except 2 that fails.
Bug 17015: Check out with the useDaysMode preference
When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.
To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #144258|0 |1 is obsolete|| --- Comment #352 from Émily-Rose Francoeur --- Created attachment 156341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156341=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #144257|0 |1 is obsolete|| --- Comment #351 from Émily-Rose Francoeur --- Created attachment 156340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156340=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34891] View restrictions button (patrons page) doesn't link to tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Emily Lamancusa changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Signed Off |Passed QA --- Comment #4 from Emily Lamancusa --- Trivial patch, nice fix, QA script is happy. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34891] View restrictions button (patrons page) doesn't link to tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Emily Lamancusa changed: What|Removed |Added Attachment #156119|0 |1 is obsolete|| --- Comment #3 from Emily Lamancusa --- Created attachment 156339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156339=edit Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34820] Clarify inventory tool message for items with non-matching notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820 --- Comment #11 from Kyle M Hall --- (In reply to Katrin Fischer from comment #9) > It's not the wording, it's the formatting. I'd forgo the for quotes. Katrin, can you have another look as this now that I've replaced them em tags? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added CC||emily-rose.francoeur@inLibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34188] Require library selection when logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- (In reply to Martin Renvoize from comment #8) > Agreed on the serverside requirement.. we should really check the pref there > too rather than do the standard auto-selection. (In reply to Jonathan Druart from comment #7) > 2. You are not enforcing the condition server-side, shouldn't we? I think we did talk about this initially - your library won't be removed from the list, so is still a valid selection. If you are going to far as to trick the script to sign you in to your library, I think you have been forced to make a selection :-) We could add a check, but it would need to be in Auth.pm, and is a bigger change that need more tests. I don't see this one so much as a security feature, but a convenience feature to ensure libraries don't accidentally sign in to the wrong branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #6 from Laura Escamilla --- Hi Katrin, The code that Heather has requested is available here! https://github.com/bywatersolutions/bywater-koha-xslt/commits/keys Please let me know if I can help out further. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34948] Document items.datelastseen and borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34948 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||vic...@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- It work! :D > The patch also adjusts the global "Dopop" function so that the popup window is a litte bigger. The comments form did not fit well. Nice addition :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34936] Remove the use of event attributes from OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34936 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #156301|0 |1 is obsolete|| --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 156338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156338=edit Bug 34936: Remove the use of event attributes from OPAC detail page This patch removes the use of event attributes (onclick) from the OPAC's bibliographic detail page template. These events are defined now along with the other in-page JS. The patch also adjusts the global "Dopop" function so that the popup window is a litte bigger. The comments form did not fit well. In checking for use of the "Dopop" function I found that it was being redefined in opac-topissues.tt for no reason so I removed it. To test you must have the OPACComments system preference enabled. - Log in to the OPAC, locate a bibliographic record, and view the detail page. - Under the "Comments" tab, click the "Post your comments on this title" link. It should trigger a popup window. - Submit your comment. When the detail page reloads, return to the "Comments" tab and click the "Edit" link on your comment. The same popup window should be triggered. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34948] Document items.datelastseen and borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34948 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15504 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34948 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20755] Allow separate email configuration for acq emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20755 Michaela Sieber changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |clemens.tub...@kit.edu |ity.org | --- Comment #3 from Michaela Sieber --- We will provide a path soon, hopefully ;-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34948] New: Document items.datelastseen and borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34948 Bug ID: 34948 Summary: Document items.datelastseen and borrowers.lastseen Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org Add a section (two sections) in the manual under FAQ to indicate what affects items.datelastseen and borrowers.lastseen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34947] Koha Manual search does not bring user to the relevant place in the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34947 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 Émily-Rose Francoeur changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33503] Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 --- Comment #9 from Victor Grousset/tuxayo --- > Install this plugin, and observe the routes are not loaded into the REST API > [...] > Make a GET request to /api/v1/ and you can see the schema definition. Indeed, /api/v1/ content didn't chance with and without the patch + plugin (after restart_all) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33806] Overridden checkin date not retained when CircConfirmItemParts enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Mike Barrette changed: What|Removed |Added CC||mbarre...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall --- That sounds like an excellent idea! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emily-rose.francoeur@inLibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #3 from Émily-Rose Francoeur --- Created attachment 156337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156337=edit Bug 34462 : Display the patron's expiration date The problem is in the patron_messages.inc file on line 25. The variable "expiry" is used, but it should be "patron.dateexpiry" because the patron's card isn't expired yet. TEST PLAN 1) Go to “Patrons > + New patron” 2) Create a patron with an expiry date that is less than 30 days in the future 3) Go to the "details" tab of this account 4) Notice that the date is missing after "expires on": "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5) Apply the patch 6) Reload the page; the expiry date should now be displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #77 from Nick Clemens --- Created attachment 156336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156336=edit Bug 9525: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #76 from Nick Clemens --- Created attachment 156335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156335=edit Bug 9525: (QA follow-up) Clarify how float groups are selected in circulation rules Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #75 from Nick Clemens --- Created attachment 156334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156334=edit Bug 9525: (QA follow-up) Fix QA complaints Add boolean to schema Remove stray console.log Fix subroutine name in POD Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #74 from Nick Clemens --- Created attachment 156333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156333=edit Bug 9525: DO NOT PUSH! Schema update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #73 from Nick Clemens --- Created attachment 156332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156332=edit Bug 9525: Fix tests To test prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #72 from Nick Clemens --- Created attachment 156331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156331=edit Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nick Clemens changed: What|Removed |Added Attachment #150241|0 |1 is obsolete|| Attachment #150242|0 |1 is obsolete|| Attachment #150243|0 |1 is obsolete|| Attachment #150244|0 |1 is obsolete|| Attachment #150245|0 |1 is obsolete|| Attachment #150246|0 |1 is obsolete|| --- Comment #71 from Nick Clemens --- Created attachment 156330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156330=edit Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #3 from Aude Charillon --- I'm all for informing users! Even if all the cookies are required and there is no choice for the user, we have to tell them what's happening. Can we slightly shift the cookie consent feature so that it's not just about the consent but mostly about the cookies? Or do we need a default Opac page about required cookies, with a link from the Opac footer? (Just throwing ideas wildly here.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34946] Remove the use of event attributes from self checkout and check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 --- Comment #1 from Owen Leonard --- Created attachment 156329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156329=edit Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34946] Remove the use of event attributes from self checkout and check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34947] New: Koha Manual search does not bring user to the relevant place in the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34947 Bug ID: 34947 Summary: Koha Manual search does not bring user to the relevant place in the page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charil...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org When clicking on a result in the Koha Manual search, the user lands at the top of the page rather than where the keyword appears. This is very unhelpful. Users are having to either do a "search within page" after clicking on the result; or run their search from a separate search engine in order to get to the relevant section in the Manual page. To replicate the issue: 1) Go to the Koha Manual, e.g. https://koha-community.org/manual/latest/en/html/index.html 2) In the search box, enter "on shelf holds". 3) Click on either of the first three results (Administration, Cataloging, Circulation). 4) Observe that you always land at the top of the page rather than where the search keywords first appear. Is there anything that can be done to improve this, please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 Jonathan Druart changed: What|Removed |Added Attachment #156287|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 156328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156328=edit Bug 34932: Patron.t - Pass borrowernumber of manager to userenv Test plan: Make sure that you do not have borrowr 51. Run t/db_dependent/Koha/Patron.t. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34932] A missing manager (51) failed my patron test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34932 --- Comment #4 from Jonathan Druart --- Hum ok, certainly enough for now. Maybe we should remove the fallback and force a patron. It will help to catch missing userenv mocks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34886] Regression in when hold button appears
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 --- Comment #24 from Nick Clemens --- I tried my hand, I didn't see the 34836 dependency until after, but addressed both scripts here as well. This code is gnarly and weird - I think Pedro's change to IsAvailableForItemLevel request makes sense, but should possibly be its own bug. We turn out to have strange assumptions here, so I tried to simplify as best as possible, I am not certain my test plan is all correct. I am fine if Pedro wants to simply obsolete my patches as well :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34886] Regression in when hold button appears
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 --- Comment #23 from Nick Clemens --- Created attachment 156327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156327=edit Bug 34886: [alternate] adjust other opac detail scripts Same chanegs as before, but for MARC and ISBD details pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34886] Regression in when hold button appears
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 --- Comment #22 from Nick Clemens --- Created attachment 156326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156326=edit Bug 34886: [alternate] Adjust holdability checks on opac details page This patch tries to simplify some of the logic here to match that on the search results. When we don't have a patron, we fallback to determining if an item can be held buy determining whether there are any items that don't have holds disallowed at the all libraries level. We also remove items with non-holdable statuses like withdrawn etc (and check some system preferences) If we don't have a patron, then we are done, however, if we do, then we need to check each item against the policies related to that patron. This patch also removes two checks at the end: CountItemsIssued($biblionumber) $biblio->has_items_waiting_or_intransit These seem to be from bug 4319 - however, those rules are checked by IsAvailableForItemLevelRequest and are only relevant when we have a patron. These checks essentially assumed 'onshelfholds' policy of 'If any unavailable' For consistency sake I think we should follow the same logic as the results page. To test: 1 - Find a record with two items, of different types, set a 'Default checkout, hold and return policy' of 'No holds allowed' 2 - Search opac, not logged in, and verify neither the results page or details page shows the place hold button 3 - Delete that rule, make both items withdrawn 4 - Search opac, not logged in, and verify neither the results page or details page shows the place hold button 5 - Mark one item as not withdrawn 6 - Search opac, not logged in, and verify both the results page or details page shows the place hold button 7 - Log in to opac 8 - Search opac, logged in, and verify both the results page or details page shows the place hold button 9 - Place an 'On shelf holds policy' rule for that patron category of 'If any unavailable' 10 - Search opac, logged in, and verify the results and details page shows the place hold button 11 - Set the other item to not withdrawn 12 - Search opac, logged in, and verify the results page shows the place hold button, but details does not 13 - Try various other scenarios - details page should be more correct, results page is always an approximation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34886] Regression in when hold button appears
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur changed: What|Removed |Added CC||emily-rose.francoeur@inLibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32391] [DOCS] Reorganise the manual contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391 Catrina Berka changed: What|Removed |Added CC||catr...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 Émily-Rose Francoeur changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 --- Comment #8 from Émily-Rose Francoeur --- I forgot last time to mark one of the attachments as obsolete. Now, it should work. I've also updated the test plan to make it clearer. TEST PLAN 1) Go to any patron’s profile > Accounting 2) Click on “Create manual invoice” 3) Complete the required fields and click the “Save” button 4) Repeat steps 2 and 3 5) Click on “Make a payment” 6) Click on “+ Add note” and add a note with special characters (e.g., éçö) for each invoice you create 7) Add “:;” to the note field for one of the invoices 8) Select the created invoices and click the “Write off selected” button 9) In the note field, you should see “�” symbols where the special characters are supposed to be, and there should be nothing for “:;” characters. 10) Click the “Cancel” button 11) Apply the patch 12) Repeat steps 6 to 8 13) Verify that the special characters are now displayed correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34870] Unrecognized special characters when writing off an invoice with a note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34870 Émily-Rose Francoeur changed: What|Removed |Added Attachment #156006|0 |1 is obsolete|| Attachment #156006|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34709] Eliminate event handler attributes in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Owen Leonard changed: What|Removed |Added Depends on||34946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 [Bug 34946] Remove the use of event attributes from self checkout and check-in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34946] New: Remove the use of event attributes from self checkout and check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34946 Bug ID: 34946 Summary: Remove the use of event attributes from self checkout and check-in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 34709 There are some event attributes in self checkout and self check-in templates. These should be removed in favor of defining events in JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 [Bug 34709] Eliminate event handler attributes in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34938] Add collection column to holds ratio report (circ/reserveratios.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938 --- Comment #6 from Lucas Gass --- (In reply to Kristi from comment #4) > In testing, when I go to Circulation > Holds ratios, I get the errors in the > attached screenshot. > If this is user error on my part, please let me know how I can adjust. Kristi, this is the thing I mention here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2 KTD and the sandboxes are set by default with SQL strict mode enabled. Since the code in reserveratios.pl contains several GROUP BY's it fails with strict mode on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34941] Patron search to find patrons with hyphens when they haven't been added in the search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34941 Didier Gautheron changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #1 from Didier Gautheron --- And searching for "le bon" doesn't work anymore too since moving to rest API for search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 --- Comment #2 from Owen Leonard --- Created attachment 156325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156325=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - The "Enroll" and "Cancel enrollment" buttons should look correct and work as expected: - Click the "Enroll" button. - On the enrollment confirmation view, test both the "Finish enrollment" button and the "Cancel" link. - Test "Cancel enrollment" button. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What|Removed |Added Attachment #156324|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 --- Comment #1 from Owen Leonard --- Created attachment 156324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156324=edit Bug 34945: Remove the use of event attributes from OPAC clubs tab This patch removes the use of event attributes (onclick) from the template for the clubs tab shown in the OPAC to a logged-in user. These events are defined now along with the other in-page JS. The patch also makes some general improvements to the template for consistency: - Adding Bootstrap color classes to the "Enroll" and "Cancel enrollment" buttons. - Enhancing the responsive configuration to the DataTable. To test you should have a few patron clubs defined (Tools -> Patron clubs). - Apply the patch and log in to the OPAC. - On the user summary page, click the "Clubs" tab. - Test the "Enroll" and "Cancel enrollment" buttons to confirm that look correct and work as expected. - Test the responsive behavior of the page to confirm that it adjusts well to narrow browser widths. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34945] Remove the use of event attributes from OPAC clubs tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34945 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
