[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #25 from Michaela Sieber --- (In reply to Michaela Sieber from comment #24) In a Third run everything was correct Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35136] Error during database update after Bug 31383
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35136 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Keywords||rel_23_11_candidate --- Comment #2 from Jonathan Druart --- There is an obvious mistake, could you try with this patch please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35136] Error during database update after Bug 31383
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35136 --- Comment #1 from Jonathan Druart --- Created attachment 157724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157724&action=edit Bug 35136: (bug 31383 follow-up) Fix db rev -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35136] Error during database update after Bug 31383
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35136 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #56 from Aleisha Amohia --- Created attachment 157723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157723&action=edit Bug 23111: Use selected default framework if UseACQFrameworkForBiblioRecords set to Don't Use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #55 from Aleisha Amohia --- Created attachment 157722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157722&action=edit Bug 23111: Allow switch to Default framework and use selected default when adding New record This ensures that the correct framework is checked when using the 'Change framework' dropdown in the editor. This also ensures that the selected default framework is used when using the New record button in the Cataloguing home page or from a record detail page. You would also still be able to use the Default framework if chosen. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Attachment #141569|0 |1 is obsolete|| --- Comment #54 from Aleisha Amohia --- Created attachment 157721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157721&action=edit Bug 23111: (follow-up) set default framework on advanced editor This patch ensures the advanced editor considers the default biblio framework. Also fixing bug in atomic update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Attachment #141568|0 |1 is obsolete|| --- Comment #53 from Aleisha Amohia --- Created attachment 157720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157720&action=edit Bug 23111: (follow-up) Add a column to show default framework Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Attachment #141567|0 |1 is obsolete|| --- Comment #52 from Aleisha Amohia --- Created attachment 157719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157719&action=edit Bug 23111: Making is_default a boolean flag Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Attachment #141566|0 |1 is obsolete|| --- Comment #51 from Aleisha Amohia --- Created attachment 157718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157718&action=edit Bug 23111: Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Attachment #141565|0 |1 is obsolete|| --- Comment #50 from Aleisha Amohia --- Created attachment 157717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157717&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 David Nind changed: What|Removed |Added Attachment #157692|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 157716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157716&action=edit Bug 35139: Filter holds to pull on current library and add 'View all libraries' link When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page. Also for big libraries with many branches, page can be very long to load if they want to see a big time period. I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link. I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'. If needed I'll add a system preference to manage the default behavior. Test plan : 1) 1.0) Set system preference 'IndependentBranches' = 'No' 1.1) Create some holds in different libraries 1.2) Go to 'Circulation' > 'Holds to pull' 1.3) Check you see holds of current library 1.4) Change start and end dates and submit 1.5) Click on 'View all libraries' 1.6) You see all holds + start and end dates are unchanged 1.7) Change start and end dates and submit 1.8) You still see all holds + no link 'View all libraries' 2) 2.0) Set system preference 'IndependentBranches' = 'Yes' 2.1) Go to 'Circulation' > 'Holds to pull' 2.2) Check you see holds of current library + no link 'View all libraries' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35133] Accessors defined in AUTOLOAD does not work if called with SUPER
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35133 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- It would be a good idea to link to the previous dev via "Depends on" or at least "See Also" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #9 from David Cook --- (In reply to Dave from comment #5) > Case use for when patrons forget their library card. Staff can scan their > barcode from the staff side account to quickly checkout them on the > self-checkout kiosks. Could you elaborate on that? How would the self-checkout kiosk have access to the staff interface? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- (In reply to Owen Leonard from comment #4) > What is the use case here? If the patron record is already up why scan the > barcode? I'm also curious why we'd need the barcode on the staff interface... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #298 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #283) > Hi Aleisha, > > I rebased the patch set (will re-apply my patches here), because bug 25393 > was pushed before yours, also adding a new circulation condition to the > table. > > This means we need to adjust the column from 31 to 32, but I didn't write > the follow-up for that, because I found what broke the behavior: > > * Turn on UnseenRenewals system preference > > It throws the column count...and then we are back at the default copying > into the input field. > > Could you try to fix that? Hi Katrin, I've done a new fix for this. I noticed the UnseenRenewals circ rule breaks a bunch of other rules in the same way, so maybe we can adopt this new way of identifying those columns in another bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #157709|0 |1 is obsolete|| --- Comment #297 from Aleisha Amohia --- Created attachment 157715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157715&action=edit Bug 8367: (follow-up) Fix for circ rules editor Make sure holds pickup period field is empty when editing a 'default' rule. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602 --- Comment #14 from David Nind --- I've tested again, but I can't replicate the issue before the patch is applied - the behavour before and after the patch is applied seems the same to me. Not sure what I've done wrong here Testing notes (using KTD): 1. For step 3, this is how I set things up to test: - Edited SIPconfig.xml so that the koha institution is "CPL" instead of "kohalibrary" - Restarted the SIP server: koha-sip --restart -v kohadev - Installed telnet in KTD: apt-get install telnet - Telnet to 6001: telnet 127.0.0.1 6001 - Send this command: 9300CNkoha|COkoha|CPCPL| - Commands to checkout items:*! 11YY2022071116350220250711 163502AOCPL|AA2352980862|AB31|ACkoha|BON|BIN| 11YY2022071116350220250711 163502AOCPL|AA2352980862|AB300498|ACkoha|BON|BIN| 11YY2022071116350220250711 163502AOCPL|AA2352980862|AB312392|ACkoha|BON|BIN| - To exit: press enter * Initial patron used was Bobbie: 2352980862 After the patches were applied, the patron used was Henry: 2352935676 The patron number is entered after |AA ! Need to change the items to checkout (after |AB), or check them back in so that they are available Output and results before the patch was applied ~~~ kohadev-koha@kohadevbox:koha(bz32602)$ telnet 127.0.0.1 6001 Trying 127.0.0.1... Connected to 127.0.0.1. Escape character is '^]'. 9300CNkoha|COkoha|CPCPL| 941 11YY2022071116350220250711 163502AOCPL|AA2352980862|AB31|ACkoha|BON|BIN| 121NNY20231023234841AOCPL|AA2352980862|AB31|AJPerl template toolkit /|AH|BV2.00|BHUSD|BT06| 11YY2022071116350220250711 163502AOCPL|AA2352980862|AB300498|ACkoha|BON|BIN 121NNY20231023234859AOCPL|AA2352980862|AB300498|AJCGI programming with Perl /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06| 11YY2022071116350220250711 163502AOCPL|AA2352980862|AB312392|ACkoha|BON|BIN| 121NNY20231023234924AOCPL|AA2352980862|AB312392|AJLady Susan ; The Watsons ; Sanditon /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06| The three items were issued to Bobbie, with no issuing blocked. The tests pass: prove t/db_dependent/SIP/Transaction.t Output and results after the patch was applied ~~~ kohadev-koha@kohadevbox:koha(bz32602)$ telnet 127.0.0.1 6001 Trying 127.0.0.1... Connected to 127.0.0.1. Escape character is '^]'. 9300CNkoha|COkoha|CPCPL| 941 11YY2022071116350220250711 163502AOCPL|AA2352935676|AB31|ACkoha|BON|BIN| 121NNY20231024000235AOCPL|AA2352935676|AB31|AJPerl template toolkit /|AH|BV2.00|BHUSD|BT06| 11YY2022071116350220250711 163502AOCPL|AA2352935676|AB300498|ACkoha|BON|BIN| 121NNY20231024000302AOCPL|AA2352935676|AB300498|AJCGI programming with Perl /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06| 11YY2022071116350220250711 163502AOCPL|AA2352935676|AB312392|ACkoha|BON|BIN| 121NNY20231024000328AOCPL|AA2352935676|AB312392|AJLady Susan ; The Watsons ; Sanditon /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06| The three items were issued to Henry, with no issuing blocked. The tests pass: prove t/db_dependent/SIP/Transaction.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #13 from David Cook --- (In reply to Martin Renvoize from comment #10) > This works really nicely, as such I'm signing off... > > Two little points however.. > > 1) I wonder if we could/should merge these errors into the existing > validation alert rather than having it's own alert box? That was my original intention but that would involve more refactoring. Could be worth doing though. > 2) I did consider whether we should go belt & braces and catch on the server > too.. however I think this is a great improvement without that anyway. I was pondering that too. Probably worth doing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from David Cook --- While I appreciate the sign off, it's not quite ready yet. It doesn't calculate the tab currently for the "Go to field" link. It only works by accident for things like the 245 due to "tabindex" weirdness. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35122] Allow Koha to Print Barcodes that are not in the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35122 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #4) > Go to the labels module and select New > Barcode range. Oh nice! That's a feature I've wanted for many years. Great to see that in there! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #21 from David Nind --- (In reply to Alex Buckley from comment #16) > Hi David, > > Sorry for my delay, I've just back from a long holiday. I hope you are doing > well :) > > I've rebased these patches against master. Ready to test again now. > > Alex Hi Alex. Welcome back! I hope you had a great holiday! (I'm doing well, thanks!) I've now signed off. I've also updated the system preference description, mainly for consistency with other system preferences (such as NOTE in capitals, script name in a code block) as well as some other wording changes. Feel free to remove if you prefer the original description. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #20 from David Nind --- Created attachment 157714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157714&action=edit Bug 26831: (follow-up) Update system preference description Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind changed: What|Removed |Added Attachment #157686|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 157713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157713&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind changed: What|Removed |Added Attachment #157685|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 157712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157712&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind changed: What|Removed |Added Attachment #157684|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 157711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157711&action=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164 --- Comment #4 from Aleisha Amohia --- Created attachment 157710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157710&action=edit Bug 33164: Do not prevent processing of all error messages This follow-up patch removes the use of $exit_required_p completely. The sysprefs BlockReturnOfLostItems and BlockReturnOfWithdrawnItems are handled in other scripts, and should not prevent the processing of all returns error messages when enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33164] Return claim message shows intermittently when BlockReturnOfLostItems enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33164 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 --- Comment #24 from Michaela Sieber --- As far as I can see all titles are harvested now. But the usage per month is not correct in my report. First run 01.-31.01.2023 Second run 01.02.-30.04.2023 Example: Nature (Online ISSN 1476-4687) normally 3000-4000 Unique_Item_Requests per month. Unique_Item_Requests should be: Jan23: 3431 Feb23: 3159 Mar23: 3758 Apr23: 2775 Check Import Logs on Data provider Springer and Download file. The usage numbers for Nature (=ISSN 1476-4687) for Platform nature.com are correct in the downloaded file . Check now the created J1 report See that the usage numbers for February and March are wrong Unique_Item_Requests Feb23: 20 Mar23: 6 usage numbers for Jan and April are correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157356|0 |1 is obsolete|| --- Comment #296 from Katrin Fischer --- Created attachment 157709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157709&action=edit Bug 8367: (follow-up) Fix for circ rules editor Make sure holds pickup period field is empty when editing a 'default' rule. Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157355|0 |1 is obsolete|| --- Comment #295 from Katrin Fischer --- Created attachment 157708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157708&action=edit Bug 8367: (QA follow-up) Fix QA script * Add +x to atomic database update file * Perltidy * Add spans to rewritten tab label for translatability Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157354|0 |1 is obsolete|| --- Comment #294 from Katrin Fischer --- Created attachment 157707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157707&action=edit Bug 8367: Add holds_pickup_period fallback circulation rule Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157352|0 |1 is obsolete|| --- Comment #293 from Katrin Fischer --- Created attachment 157706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157706&action=edit Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157351|0 |1 is obsolete|| --- Comment #292 from Katrin Fischer --- Created attachment 157705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157705&action=edit Bug 8367: (QA follow-up) Update message on Hold waiting pickup report Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=8367 Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157350|0 |1 is obsolete|| --- Comment #291 from Katrin Fischer --- Created attachment 157704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157704&action=edit Bug 8367: (follow-up) possible to delete circ rule Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157349|0 |1 is obsolete|| --- Comment #290 from Katrin Fischer --- Created attachment 157703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157703&action=edit Bug 8367: (follow-up) Remove unnecessary code and atomic update Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157348|0 |1 is obsolete|| --- Comment #289 from Katrin Fischer --- Created attachment 157702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157702&action=edit Bug 8367: (follow-up) Fix tests Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157347|0 |1 is obsolete|| --- Comment #288 from Katrin Fischer --- Created attachment 157701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157701&action=edit Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157346|0 |1 is obsolete|| --- Comment #287 from Katrin Fischer --- Created attachment 157700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157700&action=edit Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157345|0 |1 is obsolete|| --- Comment #286 from Katrin Fischer --- Created attachment 157699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157699&action=edit Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157344|0 |1 is obsolete|| --- Comment #285 from Katrin Fischer --- Created attachment 157698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157698&action=edit Bug 8367: Make database update idempotent Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Attachment #157343|0 |1 is obsolete|| --- Comment #284 from Katrin Fischer --- Created attachment 157697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157697&action=edit Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #283 from Katrin Fischer --- Hi Aleisha, I rebased the patch set (will re-apply my patches here), because bug 25393 was pushed before yours, also adding a new circulation condition to the table. This means we need to adjust the column from 31 to 32, but I didn't write the follow-up for that, because I found what broke the behavior: * Turn on UnseenRenewals system preference It throws the column count...and then we are back at the default copying into the input field. Could you try to fix that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #3 from Katrin Fischer --- Kyle, can you please help resolve? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34456 - Add the ability to download a template rendered report as a file error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc). error: could not build fake ancestor Patch failed at 0001 Bug 34456 - Add the ability to download a template rendered report as a file hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-34456---Add-the-ability-to-download-a-template-mpcxly5w.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #11 from Katrin Fischer --- Created attachment 157696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157696&action=edit Bug 34136: (QA follow-up) Perltidy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #10 from Katrin Fischer --- Created attachment 157695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157695&action=edit Bug 34136: (QA follow-up) Change Report to Reports as category in notices and slips Looking at the other entries for the module in notices we most often use the actual module name: patrons, suggestions, holds, etc. So I updated "Report" to "Reports" to match that pattern. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Katrin Fischer changed: What|Removed |Added Attachment #154227|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 157694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157694&action=edit Bug 34136: Add ability to render a report using a notice template Sometimes it is useful to display the results of a report in a non-table format. We should be able to create notice templates to render reports. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Create a new notice template using the new "Report" option from the "New notice" pulldown. 4) In the "Print" area, paste the following template: [% FOREACH b IN data %] [% b.surname %], [% b.firstname %] Expiration: [% b.dateexpiry %] ID: [% b.borrowernumber %] [% END %] 5) Create a report with the query: SELECT * FROM borrowers 6) Once the report is saved, use the new "Run with template" option to select the template you just created. 7) Note that instead of the results being a paged table, you instead see the results rendered as cards! Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #8 from Katrin Fischer --- I absolutely love the idea of this. But I worry a little about usability: * The templates are likely to work only with specific reports. The list of templates could grow really long. This will create a situation where you have a long list of templates you could apply and a need to 'guess' which would work or belongs to the report. I wonder if we should not create some link between template and report that works/goes with it. * We absolutely need documentation for this: Needs to be added to print, uses a 'data' object with the db columns etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35112] Return claims table showing on all patron tabs and not behaving as normal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35112 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Aleisha Amohia --- Don't want this fix to get missed in 22.11 so have changed the status myself on your behalf Kelly - thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #282 from Katrin Fischer --- Kelly, it looks like you forgot to switch the status here and on some other bugs, please double check when signing off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #17 from Katrin Fischer --- I am still a bit confused by this patch/script. It looks like we always turn an empty line into a . It seems an improvement from previous behavior, but I wonder if it's correct. What I would expect when the html flag is passed: * If the notice template is already HTML, do not make any changes. * If the notice is plain text, wrap in , do not add any additional line breaks. Why is the regex required at all? It seems to add additional breaks where they might not be needed/intended. Especially with TT sometimes it's nice to add some line breaks separating blocks etc. I thik we can now use the letter_id in message_queue to figure out if the template is HTML if that helps things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32607] Add import sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #34 from David Nind --- Patches no longer applies 8-(... kohadev-koha@kohadevbox:koha(bz32607)$ git bz apply 32607 Bug 32607 - Add import sources CRUD 155682 - Bug 32607: Add table and permissions 155683 - Bug 32607: Add Koha::RecordSource(s) classes 155684 - Bug 32607: DBIC schema [DO NOT PUSH] 155686 - Bug 32607: Add record sources admin page 155958 - Bug 32607: Add /record_sources endpoints Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32607: Add table and permissions Applying: Bug 32607: Add Koha::RecordSource(s) classes Applying: Bug 32607: DBIC schema [DO NOT PUSH] Using index info to reconstruct a base tree... M Koha/Schema/Result/Borrower.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 32607: DBIC schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- You removed the "validated" class from the form, this disables all standard validation that already was applied here. An examples: the mandatory field "Name" now uses the standard HTML5 message instead of our own. Email and website no longer validate at all. You need to keep the Validator active and implement your check additionally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34909] Show collection when receiving items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34909 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35072] Invalid usage of "& " in JavaScript intranet-tmpl script redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35072 --- Comment #10 from Katrin Fischer --- Thanks for your patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35072] Invalid usage of "& " in JavaScript intranet-tmpl script redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35072 Katrin Fischer changed: What|Removed |Added Attachment #157681|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 157693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157693&action=edit Bug 35072: Fix invalid usage of "&" in JavaScript intranet-tmpl script redirects These escapes were invalid in these places, as HTML entity escapes are meant to be used only inside of HTML elements/attributes, not inside of JavaScript code. These URLs would be sent out by the browser as-is, and that'd usually work on the default install only coincidentally. Unfortunately, on some setups (such as when using reverse proxies), this would break, and the URL after "&" would have been truncated. This small patch adjusts the URLs in templates to not use wrong escapes, and makes them consistent with how URLs are formatted for JavaScript redirects in most of the templates already. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35140] New: Notify patron when their hold has been placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35140 Bug ID: 35140 Summary: Notify patron when their hold has been placed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Currently there is a emailLibrarianWhenHoldIsPlaced system preference which, when enabled, will send a HOLDPLACED notice to the library to notify that a patron placed a hold. It would be useful to have a similar function to send a notice to a patron when a hold has been placed for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35072] Invalid usage of "& " in JavaScript intranet-tmpl script redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35072 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #17 from David Nind --- Thanks! Getting sha1 and fake ancestor error when applying the patch 8-(.. kohadev-koha@kohadevbox:koha(bz21284)$ git bz apply 21284 Bug 21284 - ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. 157648 - Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. error: sha1 information is lacking or useless (t/db_dependent/ILSDI_Services.t). error: could not build fake ancestor Patch failed at 0001 Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35072] Invalid usage of "& " in JavaScript intranet-tmpl script redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35072 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894
--- Comment #6 from David Nind ---
I tried again after the follow-ups to bug 31383.
The database update runs if there is no previous content.
However, if I add some content, apply the patch, then run the database update I
get the same error:
kohadev-koha@kohadevbox:koha(bz34894)$ updatedatabase
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug-34894-move-OpacSuppressionMessage-to-additional-contents.pl
[20:32:14]: Bug 34894 - Move OpacSuppressionMessage to additional contents
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column
'title' in 'field list' at /kohadevbox/koha/C4/Installer.pm line 741
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33662] Add link to order search to acq module navigation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33662 --- Comment #10 from Katrin Fischer --- Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #7 from Fridolin Somers ---
-if ( C4::Context->preference('IndependentBranches') ){
+if ( C4::Context->only_my_library() ){
This change seems not related to this problem.
It changes behavior for superlibrarians with IndependentBranches = Yes.
So now behavior is different from waitingreserves.pl
I create a new bug report if we agree.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35068] Split 'Renew or check in selected items' button in issues table into seperate buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35068 --- Comment #17 from Lucas Gass --- Owen, thanks for the follow-up. Those icons look good! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31105] Holds to pull counts items from other branches when independentbranches is active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35139 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31105 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 --- Comment #2 from Fridolin Somers --- Created attachment 157692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157692&action=edit Bug 35139: Filter holds to pull on current library and add 'View all libraries' link When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page. Also for big libraries with many branches, page can be very long to load if they want to see a big time period. I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link. I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'. If needed I'll add a system preference to manage the default behavior. Test plan : 1) 1.0) Set system preference 'IndependentBranches' = 'No' 1.1) Create some holds in different libraries 1.2) Go to 'Circulation' > 'Holds to pull' 1.3) Check you see holds of current library 1.4) Change start and end dates and submit 1.5) Click on 'View all libraries' 1.6) You see all holds + start and end dates are unchanged 1.7) Change start and end dates and submit 1.8) You still see all holds + no link 'View all libraries' 2) 2.0) Set system preference 'IndependentBranches' = 'Yes' 2.1) Go to 'Circulation' > 'Holds to pull' 2.2) Check you see holds of current library + no link 'View all libraries' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35136] Error during database update after Bug 31383
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35136 Aleisha Amohia changed: What|Removed |Added CC|alei...@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35130] Limit item types that can be checked in via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35130 Katrin Fischer changed: What|Removed |Added Summary|Limit Item Types that can |Limit item types that can |be checked in Via SIP2 |be checked in via SIP2 Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35128] Move cities to Vue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35128 Katrin Fischer changed: What|Removed |Added Summary|move cities to Vue |Move cities to Vue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35122] Allow Koha to Print Barcodes that are not in the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35122 --- Comment #5 from Katrin Fischer --- (In reply to Kelly McElligott from comment #3) > Yes, this would work in the barcode range choice, but the library would have > to enter the barcode twice each time, as it requires a 'range'. Maybe we could adjust the bug description. Are you thinking about something like an input box where the barcodes could be entered/scanned? Maybe single or multiple outside a range? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35122] Allow Koha to Print Barcodes that are not in the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35122 --- Comment #4 from Katrin Fischer --- (In reply to David Cook from comment #2) > (In reply to Katrin Fischer from comment #1) > > I think we have this with the print barcode range feature? > > Which feature is that? Go to the labels module and select New > Barcode range. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Nick Clemens changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 --- Comment #4 from Nick Clemens --- Created attachment 157691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157691&action=edit Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets This requires enabling MarcItemFieldsToOrder, see bug 34645 Add an inactive Budget and some funds to your system Import a file with multiple biblios Confirm the button hids/displays the funds for all item orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35139 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8074 --- Comment #1 from Fridolin Somers --- See related Bug 8074 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35139] New: Filter holds to pull on current library and add 'View all libraries' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 Bug ID: 35139 Summary: Filter holds to pull on current library and add 'View all libraries' link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page. Also for big libraries with many branches, page can be very long to load if they want to see a big time period. I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link. I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'. If needed I'll add a system preference to manage the default behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35111] Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35111 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095 --- Comment #8 from Caroline Cyr La Rose --- Hi Pedro, Here are the mappings I'm thinking of for the fields in the interface to the fields in biblio/biblioitems and MARC21. I also found the list of KBART fields (I thought it was not very easy to find on their website...) https://groups.niso.org/higherlogic/ws/public/download/16900/RP-9-2014_KBART.pdf starting on page 19, so I added those in the list too. Publication title: publication_title = 245$a (biblio.title) Print-format identifier: print_identifier = 020$a (biblioitems.isbn) for books or 022$a (biblioitems.issn) for serials Online-format identifier: online_identifier = 020$a (biblioitems.isbn) for books or 022$a (biblioitems.issn) for serials Date of first serial issue available online: date_first_issue_online = 008/07-10 (not mapped to db) and 362$a (not mapped to db) before the "-" or 363$i (not mapped to db) ; for serials only Number of first volume available online: num_first_vol_online = 362$a (not mapped to db) before the "-" or 363$a (not mapped to db); for serials only Number of first issue available online: num_first_issue_online = 362$a (not mapped to db) before the "-" or 363$b (not mapped to db); for serials only Date of last serial issue available online: date_last_issue_online = 008/11-14 (not mapped to db) and 362$a (not mapped to db) after the "-", should be in the same 362$a as the "first" or 363$i (not mapped to db), should be in a different 363 than the "first"; for serials only Number of last volume available online: num_last_vol_online = 362$a (not mapped to db) after the "-" should be in the same 362$a as the "first" or 363$a (not mapped to db), should be in a different 363 than the "first"; for serials only Number of last issue available online: num_last_issue_online = 362$a (not mapped to db) after the "-" should be in the same 362$a as the "first" or 363$b (not mapped to db), should be in a different 363 than the "first"; for serials only Title-level URL: title_url = 856$u (biblioitems.url) First author: first_author = 100$a (biblio.author); for books only Embargo information: embargo_info = this one I'm not sure, but probably 506$a (not mapped to db), although the KBART data seems very structured whereas the MARC21 field is a free entry field Coverage depth: coverage_depth = this one I'm not sure either... I looked but can't really find one field that encompasses what is described in the KBART document. Could be 008/24-27 (which is a letter code representing the contents). In doubt, I would put it in 500$a (biblioitems.notes). Someone else may be able to guide us here... Notes: notes = 500$a (biblioitems.notes) Publisher name: publisher_name = 260$b (biblioitems.publishercode) or 264$b (biblioitems.publishercode) Publication type: publication_type = 000/07 (m for monograph or s for serial), KBART only gives those two options even if there is an extensive list in Koha Date the monograph is first published in print: date_monograph_published_print = 008/07-10 (not mapped to db) or 264$c (biblio.copyrightdate); for books only? Date the monograph is first published online: date_monograph_published_online = 008/07-10 (not mapped to db) or 264$c (biblio.copyrightdate); for books only? Number of volume for monograph: monograph_volume = 490$v?... seems weird to me to have a volume without a collection title (biblioitems.volume ); for books only? Edition of the monograph: monograph_edition = 250$a (biblioitems.editionstatement); for books only? First editor: first_editor = probably 700$a if it's a person (not mapped to db), with "edt" in $4; for books only Title identifier of the parent publication: parent_publication_title_id = not sure but probably 773$z for books (not mapped to db); for books only Title identifier of any preceding publication title: preceding_publication_title_id = not sure, but probably 780$z (not mapped to db); for serials only Access type: access_type = 506 ind1 (not mapped to db) 0 for Open access, 1 for fee-based, could also be something else, like 506$f in combination with $2 Note that these aren't definitive and anyone is free to correct or add to them. I don't pretend to know everything, especially when it comes to MARC!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35030] Extend TrackLastPatronActivity with placing article request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35030 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #7 from Lucas Gass --- (In reply to Ed Veal from comment #6) > At the risk of asking for a bit more please. Might we have the option of the > barcode being a printable QR Code? Just asking! One of the barcode type options is QRCode. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #22 from Alex Buckley --- Hi Marcel and Katrin, Thanks both for your comments. I have thought on both of them. I agree that I am not a fan of enhancing the PDF files, especially since it is possible for the user to add a message much too long for the PDF file, and get the problem that David noted in comment #6 However, if a library wants to change the wording of the pdf, as is the use case her, I don't see what other options there are. I agree with Katrin that trying to use the HTML customisations WYSIWG editor could create problems with the pdf - for example if users try to add tables, images, fonts. I suppose one possible workaround could be to shift this to being a notice and so it could be edited from the notices and slips interface. What are your thoughts on that? Then no WYSIWG editor is involved. Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924 --- Comment #15 from Nick Clemens --- (In reply to Emily Lamancusa from comment #9) > It happens because the final renewal message is passed as an error even > though it's not really an error...which isn't ideal. It's easy to fix in > AUTO_RENEWALS, and a bit less so in AUTO_RENEWALS_DGST, but it does make me > wonder if we'd be setting ourselves up for issues with maintainability down > the road. Is there a better way to pass that information? > I adjusted the single renewal notice - the digest looks to me like it will come out correctly. I started trying to look into this, and it got much bigger. We could pass a 'success' flag for the regular notice, then check for the final in the auto_renew_error field. If we just consider it to be 'status' rather than 'error' it feels less bad, adding a new column for tracking final seems overkill to me. If acceptable, I'd like to see this work done on a new bug, rather than changing the structure and adding feature at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924 --- Comment #14 from Nick Clemens --- Created attachment 157690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157690&action=edit Bug 34924: Adjust auto renewal email to reflect success for final renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
