[Koha-bugs] [Bug 34281] Transfer limits have no impact on CanBookBeRenewed

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34281

Anneli Österman  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Anneli Österman  ---
I tried this again without the patch with your new instructions and I'm still
not sure if I understand correct. If the hold is in Centerville and I try to
renew item checked out from Centerville, the renew is blocked by the hold (it
does not require a transfer). But if I try to renew the loan made from the
Midway, it is possible renew (would require transfer to Centerville). To me
this works as it should work, I do not see the original problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35088] With marcflavour=unimarc Z39.50 does not seach Authority LC Records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35088

Rafael Antonio  changed:

   What|Removed |Added

   Priority|P5 - low|P3
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.05
released in||

--- Comment #7 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34171] item_barcode_transform does not work when moving items

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34171

Fridolin Somers  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Set as normal bug instead of enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34547] Add transfer reason to list of checkins

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #12 from Fridolin Somers  ---
Enhancement not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16846] Move C4::Members to the Koha namespace

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
Bug 16846 depends on bug 33947, which changed state.

Bug 33947 Summary: Move GetAllIssues to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33947] Move GetAllIssues to Koha

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|RESOLVED

--- Comment #9 from Fridolin Somers  ---
Enhancement not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12732] Add basket creation date to late orders table for sorting

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #28 from Fridolin Somers  ---
Enhancement not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410

--- Comment #10 from David Cook  ---
(In reply to Blou from comment #9)
> I followed on David's comment and tried a few lazy loading.  Some have a
> good impact (like ZOOM), but others like the TimeZone have no impact because
> it's included in some other module in the Koha::Caches or Koha::Config
> hierarchy. 

Have you run the test suite? We need to make sure that no other code was
relying on C4::Context loading those modules when it's loaded.

> Lazy loading Koha::Config makes no sense, and Cache is cycling back to
> Context, funnily.

That's one of those circular dependencies. 

> I can try some ugly code for the preferences, as a POC.  I hope to have time
> this week, if no one else give it a go.

So bug 28410 isn't the right place to put patches. You'll want to raise
separate tickets and then link them using "Depends on".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

--- Comment #23 from Andrew Fuerste-Henry  ---
re-signed-off with new check and verbose mode!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #157872|0   |1
is obsolete||

--- Comment #22 from Andrew Fuerste-Henry  ---
Created attachment 157880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157880=edit
Bug 34611: Confirm run if pseudonymized transactions found and add verbose
feedback

Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #157871|0   |1
is obsolete||

--- Comment #21 from Andrew Fuerste-Henry  ---
Created attachment 157879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157879=edit
Bug 34611: Add a script to pseudonymize statistics from before a given date

This script takes a date parameter in SQL format and pseudonymizes all
statistics
found before this date.

Only values that can be found will be added, i.e. no deleted patron or item
info
will be present.

Additionally - the values stored will be the current values from patrons and
items, so
some info will be approximate, much as it is when joining from the statistics
table for reporting.

To test:
 1 - Perform some issues/returns/renewals/on-site checkouts
 2 - Make sure Pseudonymization is disabled
 3 - perl misc/maintenance/pseudonymize_statistics.pl
 4 - Script ends and reports that preference is not active
 5 - Enable the pref, and choose some borrower and item fields
NOTE: See bug 28911 if you need a bcrypt key for your koha-conf.xml
 6 - perl misc/maintenance/pseudonymize_statistics.pl
 7 - sudo koha-mysql kohadev
 8 - SELECT * FROM pseudonymized_transactions
 9 - Confirm data is correctly stored
10 - DELETE FROM pseudonymized_transactions;
11 - UPDATE statistics SET datetime = '2023-01-01 00:00:00';
12 - perl misc/maintenance/pseudonymize_statistics.pl -b "2022-12-31 23:59:59";
13 - SELECT * FROM pseudonymized_transactions;
14 - Confirm no entries were made
15 - Select different options in Pseudonmyization prefs, including borrower
attributes
 This wil require defining an attribute that can be kept for
pseudonymization
16 - Confirm options are correctly pseudonymized

Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #157870|0   |1
is obsolete||

--- Comment #20 from Andrew Fuerste-Henry  ---
Created attachment 157878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157878=edit
Bug 34611: Add pseudonymize routine to Koha::Statistics

This patch adds a new routine to pseudonymize a statistic and adjusts
C4::Stats to use this new routine.

Additionally Koha::PseudonymizedTransaction->new_from_statistic is updated to
check for
the existence of objects before using them (in the case of older stats where
things may have been deleted)

Tests are added and can be run using:
1. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/PseudonymizedTransaction.t \
   t/db_dependent/Koha/Pseudonymization.t
=> SUCCESS: New tests pass, old tests keep passing

Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #157869|0   |1
is obsolete||

--- Comment #19 from Andrew Fuerste-Henry  ---
Created attachment 157877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157877=edit
Bug 34611: Unit tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25816] Add OPAC messages in SIP display

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED
  Text to go in the||New system preference
  release notes||'SIP2AddOpacMessagesToScree
   ||nMessage' allows to include
   ||patron OPAC messages in the
   ||SIP2 screen message.
   ||Starting with "Messages for
   ||you: ".
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #13 from Fridolin Somers  ---
Enhancement not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #33 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #32 from Fridolin Somers  ---
"It is alive!", dead records will be reborn Frankenstein's style :D
Great fix, thanks all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35098] ILL batch is not displayed in ILL table

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35098

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|RESOLVED

--- Comment #5 from Fridolin Somers  ---
Depends on Bug 35096 not in 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34990] Backgroundjob->enqueue does not send persistent header

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34990

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.05
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #14 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Sally Lodico  changed:

   What|Removed |Added

 Blocks||35159


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159
[Bug 35159] New edit item limitation to library groups also prevents batch
modification of items owned by other libraries.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35159] New: New edit item limitation to library groups also prevents batch modification of items owned by other libraries.

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159

Bug ID: 35159
   Summary: New edit item limitation to library groups also
prevents batch modification of items owned by other
libraries.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P4
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: slod...@knoxlib.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 20256

The new feature that restricts editing items to owning or group library is
preventing staff from performing batch item modifications to any item,
regardless of owning library, something they could do prior to this addition. A
new permission, "Edit any item including items that would otherwise be
restricted (edit_any_items)", was added to allow users to edit any item
regardless of the user and items' home libraries, but an equivalent permission
for the Batch Item Modification Tool was not created. Either extend the new
edit_any_item permission to include persons with the existing "Perform batch
modification of items (items_batchmod)" permission or create a new permission
that is the equivalent of "edit_any_item" for the Batch Modification Tool.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
[Bug 20256] Add ability to limit editing of items to home library or library
group
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32305] Background worker doesn't check job status when received from rabbitmq

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #38 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35053] Item-level rules not checked if both item_id and biblio_id are passed

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35053

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|23.11.00|23.11.00,23.05.05
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #37 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #36)
> I believe it could have been 118N issues that turned us away from HTML5.

I also see that the HTML5 stuff does not support datetime in the way we need it
to.

I do like Maskito.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35081] "Your concern was sucessfully submitted." untranslatable

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #7 from Fridolin Somers  ---
Depends in Bug 31028 not in 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35081] "Your concern was sucessfully submitted." untranslatable

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.05
released in||

--- Comment #6 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||35081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081
[Bug 35081] "Your concern was sucessfully submitted." untranslatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35081] "Your concern was sucessfully submitted." untranslatable

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||31028
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35101] Clicking the barcode.pl plugin causes screen to jump back to top

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35101

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|23.11.00|23.11.00,23.05.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #6 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35119] Make bibliographic errors more prominent and match current styling

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119
Bug 35119 depends on bug 35099, which changed state.

Bug 35099 Summary: Cannot load records with invalid marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35117] get_marc_components and get_marc_volumes should be more consistent

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35117
Bug 35117 depends on bug 35099, which changed state.

Bug 35099 Summary: Cannot load records with invalid marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014
Bug 34014 depends on bug 35099, which changed state.

Bug 35099 Summary: Cannot load records with invalid marcxml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35099] Cannot load records with invalid marcxml

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #18 from Fridolin Somers  ---
Depends on Bug 26314 not in 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34300] Add link to place a hold on ordered items in baskets

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34300

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721

--- Comment #68 from Fridolin Somers  ---
BTW : 
It would be nice to add library option to plugin hook adding JS and CSS, right
?
Hook added by Bug 20181

Currently one can use, for OPAC, selector "body.branch-LIBRARY"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35158] New: Issue with preventDoubleFormSubmit() and using browser's back button

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35158

Bug ID: 35158
   Summary: Issue with preventDoubleFormSubmit() and using
browser's back button
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

Go to a form that has the preventDoubleFormSubmit() attached when submitting. 

1. Go to a patron account -> Transactions > Create manual invoice 
2. Go to 'Make a payment tab'
3. Click 'Pay selected'
4. Now use the browser's back button to return to the 'Make a payment' screen.
5. You cannot submit again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|One can now add CSS and JS  |With this feature it's
  release notes|in library edition.
|possible to add library
   |This|specific CSS and JavaScript
   |works in conjunction with   |on the library
   |the global 'UserJS' and |administration pages.
   |'UserCSS' functionality and |This
   |allows for multiple OPACs   |works in combination with
   |with different CSS and JS   |the global '*UserJS' and
   |options.|'*UserCSS' functionality
   ||and allows for multiple
   ||OPACs with different CSS
   ||and JavaScript
   ||customizations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

--- Comment #1 from jpl  ---
Quick workaround I came up with. Works for me with Koha 22.11.10.000 Rosalie.
This will only shows the lists when a user is logged in if opacpublic is set to
false.

--- /koha/src/masthead.inc  2023-10-25 23:02:01.538423660 +0200
+++ masthead.inc2023-10-25 23:03:45.558420570 +0200
@@ -37,6 +37,7 @@
 [% END %]
 
 [% IF ( Koha.Preference( 'virtualshelves' ) == 1 ) %]
+   [% IF (( Koha.Preference( 'opacpublic' ) == 0 ) && (
logged_in_user )) || ( Koha.Preference( 'opacpublic' )) %]
 
  Lists
@@ -81,6 +82,7 @@
  
  
 [% END # / IF virtualshelves %]
+[% END %]
  

 [% IF Koha.Preference( 'opacuserlogin' ) == 1 ||  Koha.Preference(
'EnableOpacSearchHistory') || Koha.Preference( 'opaclanguagesdisplay' ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410

--- Comment #9 from Blou  ---
I followed on David's comment and tried a few lazy loading.  Some have a good
impact (like ZOOM), but others like the TimeZone have no impact because it's
included in some other module in the Koha::Caches or Koha::Config hierarchy. 

Lazy loading Koha::Config makes no sense, and Cache is cycling back to Context,
funnily.

I can try some ugly code for the preferences, as a POC.  I hope to have time
this week, if no one else give it a go.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #24 from Katrin Fischer  ---
Thanks a lot Shi Yao!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924

--- Comment #16 from Emily Lamancusa  
---
(In reply to Nick Clemens from comment #15)
> I started trying to look into this, and it got much bigger. We could pass a
> 'success' flag for the regular notice, then check for the final in the
> auto_renew_error field. If we just consider it to be 'status' rather than
> 'error' it feels less bad, adding a new column for tracking final seems
> overkill to me. If acceptable, I'd like to see this work done on a new bug,
> rather than changing the structure and adding feature at the same time.

That sounds like a good solution - and I agree with making that change on a
separate bug. Thanks for taking a look! Will retest (and hopefully sign off!)
in the morning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721

Fridolin Somers  changed:

   What|Removed |Added

  Text to go in the||One can now add CSS and JS
  release notes||in library edition.
   ||This
   ||works in conjunction with
   ||the global 'UserJS' and
   ||'UserCSS' functionality and
   ||allows for multiple OPACs
   ||with different CSS and JS
   ||options.

--- Comment #67 from Fridolin Somers  ---
I add a release note, feel free to modify

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

--- Comment #2 from Lucas Gass  ---
Katrin, is there something that can be done here to help improve translations?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

Lucas Gass  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |normal
   Assignee|martin.renvoize@ptfs-europe |lu...@bywatersolutions.com
   |.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

--- Comment #1 from Lucas Gass  ---
Created attachment 157876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157876=edit
Bug 35157: Remove spans from patronfields.inc

To test:
1. Run any page that contains the "Search patrons" search bar through an HTML
validator and you will see a lot of:

Stray start tag span.
Stray end tag span.

2. Apply patch
3. Try step 1 again, no more errors from the HTML validator.
4. Make sure the patron searches still work when limiting by 'Search field'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34377] Accounting transactions don't show managing librarian info for credits/debits

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377

Katrin Fischer  changed:

   What|Removed |Added

Summary|Accounting transactions |Accounting transactions
   |dondoes not show managing   |don't show managing
   |librarian info for  |librarian info for
   |credits/debits  |credits/debits

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410

--- Comment #8 from Blou  ---
Created attachment 157875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157875=edit
Bug 28410: Use lazy loading to reduce memory footprint of C4/Context.pm

This simply removes some 'use' declarations at the top of the file to
instead use 'require' later on.

The effect can be validated with a simple one-liner (provided KOHA_CONF
and PERL5LIB being set)

perl -e "use C4::Context; while(1){sleep(1);}"

And monitoring the memoring usage in tools like 'top'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34377] Accounting transactions dondoes not show managing librarian info for credits/debits

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34377

Katrin Fischer  changed:

   What|Removed |Added

Summary|accountline-details.pl does |Accounting transactions
   |not show managing librarian |dondoes not show managing
   |info for credits/debits |librarian info for
   ||credits/debits

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #36 from Katrin Fischer  ---
I believe it could have been 118N issues that turned us away from HTML5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting

--- Comment #66 from Fridolin Somers  ---
Enhancement not pushed to 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34531] Hiding Lost card flag and Gone no address flag via BorrowerUnwantedFields hides Patron restrictions

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34531

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.05
released in||

--- Comment #5 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587

--- Comment #27 from Michaela Sieber  ---
(In reply to Pedro Amorim from comment #26)
> 
Great, Thanks for fixing and for your explanations. 

Fingers crossed for 23.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35157] New: The searchfieldstype select element produces invalid HTML

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157

Bug ID: 35157
   Summary: The searchfieldstype select element produces invalid
HTML
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Accessibility
  Assignee: martin.renvo...@ptfs-europe.com
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: martin.renvo...@ptfs-europe.com,
matt.blenkin...@ptfs-europe.com, oleon...@myacpl.org

Run any page that contains the "Search patrons" search bar through an HTML
validator and you will see a lot of:

Stray start tag span.
Stray end tag span.

This is because  tags contain spans.  is not a valid child
element of 

The HTML5 spec:

https://html.spec.whatwg.org/multipage/form-elements.html#the-option-element


There are essentially two options for what can be put inside an 
element:

1. Test
2. Nothing

These spans are added via the patronfields.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #12 from Aleisha Amohia  ---
*** Bug 35156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35156] [Elasticsearch] Fix indexing of batch imported records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35156

--- Comment #2 from Aleisha Amohia  ---


*** This bug has been marked as a duplicate of bug 33576 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34822] BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34822

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #9 from Aleisha Amohia  ---
*** Bug 35156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35156] [Elasticsearch] Fix indexing of batch imported records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35156

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|ASSIGNED|RESOLVED

--- Comment #1 from Aleisha Amohia  ---


*** This bug has been marked as a duplicate of bug 34822 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019

Aleisha Amohia  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35156

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||35156


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35156
[Bug 35156] [Elasticsearch] Fix indexing of batch imported records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35156] [Elasticsearch] Fix indexing of batch imported records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35156

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33019
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
 Depends on||27421
 Status|NEW |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
[Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35156] New: [Elasticsearch] Fix indexing of batch imported records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35156

Bug ID: 35156
   Summary: [Elasticsearch] Fix indexing of batch imported records
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

A background job to update the elastic index after a batch import to the
catalogue is not always being committed, which means the records can't be
searched after they're added to the catalogue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003

David Nind  changed:

   What|Removed |Added

 Attachment #156633|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 157874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157874=edit
Bug 35003: Make cancelled hold requests filter by branch

To recreate:
1. Make sure you have the "Default waiting hold cancellation policy" set to
allow via circulation rules.
2. Make several holds at different branches  holds and set them to waiting
3. Request to cancel those holds, making sure you cancel some for different
branches.
4. Go to waitingreserves.tt and notice that you see all of the holds from all
branches.
5. APPLY PATCH and restart services
6. Vist the waitingreserves.tt page and notice that the "Holds with
cancellation requests" table can now filters by branch.
7. Use the "View all libraries" and make sure you can see all the holds with a
cancellation request.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35003] Holds with cancellation requests table on waitingreserves.tt does not filter by branch

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35003

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35075] "bulkmarcimport" source missing in Marc Overlay Rules settings page

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35075

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
Happy to try and test.

Could you please add a test plan to the commit message? (See the
https://wiki.koha-community.org/wiki/Commit_messages#Test_plan)

It will also need a bug/feature description as well, to keep the QA Team happy.

Thanks.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35062] addbiblio: Allow a framework plugin to add class to prevent submit during ajax call

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35062

David Nind  changed:

   What|Removed |Added

 Attachment #157226|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 157873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157873=edit
Bug 35062: Add class plugin-blocks-submit in addbiblio

Adding this condition in Check() allows you to prevent form submittal
during e.g. an ajax call in a framework plugin.
The plugin adds and removes the class on the corresponding html
element during processing.

Test plan:
Since we do not have a plugin using this class yet, nothing changes now.
Verify that you can still click Save in addbiblio while using standard
plugins. In other words: no change in behavior.

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

--- Comment #59 from Katrin Fischer  ---
(In reply to M from comment #58)
> > 7) Revert changes for line 463 in marc-overlay-rules.tt (or will result in
> >conflict applying the patch), apply the patch and repeat steps 4-5,
> >   verify that the field now was protected from being overwritten.
> 
> Generally it works, but doesn't for field 942 for some reason... It just
> gets removed, while others like 866 are preserved (with exact same overlay
> rules...). Perhaps related to Bug 34191 (meaning that it might be unrelated
> to this patchset)

Don't use the asterisk - then it should work. See: 

Bug 33268 - Overlay rules don't work correctly when source is set to *

But there should be no difference for different fields. Do you have a second
rule for 942 by chance?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35062] addbiblio: Allow a framework plugin to add class to prevent submit during ajax call

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35062

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15834] Ability to limit AutoEmailNewUser to specific patron categories

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15834

--- Comment #7 from Katrin Fischer  ---
Lari, I think your workaround should work. I also documented this on the wiki a
little while ago:
https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Don.27t_generate_e-mail_for_a_patron_category

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

he...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||35155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35155
[Bug 35155] MARCOverlayRules syspref not in manual
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35155] New: MARCOverlayRules syspref not in manual

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35155

Bug ID: 35155
   Summary: MARCOverlayRules syspref not in manual
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
   URL: https://gitlab.com/gnucifer/koha-manual/-/commit/593c5
da008dbc4b074cac9dee167cce9a6dfc250#c5e2c75dc923f21c5b
95185b2f350df00fec661f
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 14957

MARCOverlayRules system pref and functionality introduced in 21.11 never made
it into Koha manual.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
[Bug 14957] Write protecting MARC fields based on source of import
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

--- Comment #18 from Nick Clemens  ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Andrew Fuerste-Henry from comment #11)
> > It's worth noting that running this script repeatedly *did* create duplicate
> > entries in the pseudonymized_transactions table. I don't feel like that's a
> > blocker, but should be documented.
> 
> That's bad. Let's try to fix it.

The whole point is that we shouldn't be able to get to the patron from the
pseudonymized, so pointing out the overlap would seem wrong. It would also get
tricky where one pseudonymized today might provide different patron info than
an original, so detecting duplicates would be flawed.

As a safeguard against accidental repetition I added a rudimentary check - if
there are pseudonymized transactions found before the date you must now confirm
the run or we exit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

--- Comment #17 from Nick Clemens  ---
Created attachment 157872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157872=edit
Bug 34611: Confirm run if pseudonymized transactions found and add verbose
feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

--- Comment #16 from Nick Clemens  ---
Created attachment 157871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157871=edit
Bug 34611: Add a script to pseudonymize statistics from before a given date

This script takes a date parameter in SQL format and pseudonymizes all
statistics
found before this date.

Only values that can be found will be added, i.e. no deleted patron or item
info
will be present.

Additionally - the values stored will be the current values from patrons and
items, so
some info will be approximate, much as it is when joining from the statistics
table for reporting.

To test:
 1 - Perform some issues/returns/renewals/on-site checkouts
 2 - Make sure Pseudonymization is disabled
 3 - perl misc/maintenance/pseudonymize_statistics.pl
 4 - Script ends and reports that preference is not active
 5 - Enable the pref, and choose some borrower and item fields
NOTE: See bug 28911 if you need a bcrypt key for your koha-conf.xml
 6 - perl misc/maintenance/pseudonymize_statistics.pl
 7 - sudo koha-mysql kohadev
 8 - SELECT * FROM pseudonymized_transactions
 9 - Confirm data is correctly stored
10 - DELETE FROM pseudonymized_transactions;
11 - UPDATE statistics SET datetime = '2023-01-01 00:00:00';
12 - perl misc/maintenance/pseudonymize_statistics.pl -b "2022-12-31 23:59:59";
13 - SELECT * FROM pseudonymized_transactions;
14 - Confirm no entries were made
15 - Select different options in Pseudonmyization prefs, including borrower
attributes
 This wil require defining an attribute that can be kept for
pseudonymization
16 - Confirm options are correctly pseudonymized

Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

--- Comment #15 from Nick Clemens  ---
Created attachment 157870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157870=edit
Bug 34611: Add pseudonymize routine to Koha::Statistics

This patch adds a new routine to pseudonymize a statistic and adjusts
C4::Stats to use this new routine.

Additionally Koha::PseudonymizedTransaction->new_from_statistic is updated to
check for
the existence of objects before using them (in the case of older stats where
things may have been deleted)

Tests are added and can be run using:
1. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/PseudonymizedTransaction.t \
   t/db_dependent/Koha/Pseudonymization.t
=> SUCCESS: New tests pass, old tests keep passing

Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Nick Clemens  changed:

   What|Removed |Added

 Attachment #157763|0   |1
is obsolete||
 Attachment #157764|0   |1
is obsolete||
 Attachment #157765|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 157869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157869=edit
Bug 34611: Unit tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

--- Comment #23 from Shi Yao Wang  ---
Created attachment 157868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157868=edit
Bug 32610: Remove data-date_to and tweak comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26077] Batch Item Deletion Error Occurring Frequently with more than 5, 000 records

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26077

Kristi  changed:

   What|Removed |Added

 CC||kkrue...@cuyahogalibrary.or
   ||g

--- Comment #1 from Kristi  ---
We would love to see this improvement. We have a large catalog with high
turnover, so being able to delete large amounts of withdrawn items periodically
is important.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
 CC||shi-yao.w...@inlibro.com

--- Comment #22 from Shi Yao Wang  ---
rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148830|0   |1
is obsolete||

--- Comment #21 from Shi Yao Wang  ---
Created attachment 157867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157867=edit
Bug 32610: Add date extended patron attribute handling to overdues report

This makes sure that the overdues report manages filters for
extended patron attributes of the type date correctly.

To test:
* Make sure you have at least one PA marked as 'searchable'
* Make sure your patron has at east one checked out item
* Go to circulation > overdues
* If you have no overdue items, check "Show any items currently checked out:"
* Verify the list of checkouts displays
* Verify the PA filter option displays with the calendar widget
* Limit to the date in your patron's record - list remains
* Limit to any other date - list empties

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148829|0   |1
is obsolete||

--- Comment #20 from Shi Yao Wang  ---
Created attachment 157866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157866=edit
Bug 32610: Add date extended patron attributes to the OPAC

This makes sure that the attributes are handled correctly
when displayed and edited in the OPAC during address changes
or self registration.

To test:
  * You will need to test different configuration options for
extended patron attributes (PA) in combination with the date option:
* PA displays in OPAC, but is not editable
  * The date will show nicely formatted on the personal details tab.
* PA displays and is editable in the OPAC
  * The date can be edited using the calendar widget
* PA displays, is editabe and mandatory
  * The date is marked as required and you can't save without
it being set.
  * Test the form behaves correctly when requesting changes for an
existing patron account and when self registering.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148828|0   |1
is obsolete||

--- Comment #19 from Shi Yao Wang  ---
Created attachment 157865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157865=edit
Bug 32610: Add date extended patron attributes to patron module

This makes the necessary changes in the patron module of
the staff interface, so the new patron attribute appers and
behaves correctly when editing a patron record.

To test:
* You will need to test different configuration options for
  extended patron attributes (PA) in combination with the date option:
  * PA is a date and not mandatory
* Patron form should have the calendar widget to let you set the date.
  * PA is a date and mandatory
* Patron form shoudl have calendar widget and check that the date is
  set for allowing you to save the record.
  * PA is a date and unique
* For this set the date in one patron record and try to
  set the same date in another. You should not be able to save.
  * PA displays in brief patron information
* Make sure the date displays on the left formatted correctly
  * When the date PAs are saved, they should display nicely formatted
on the details tab.

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148827|0   |1
is obsolete||

--- Comment #18 from Shi Yao Wang  ---
Created attachment 157864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157864=edit
Bug 32610: Add date option to extended patron attributes administration page

With this page it will be possible to configure patron attributes
to be a date.

To test:
* Go to administration > patron attribute types
* Add a new patron attribute of type date
  * Dates cannot be repeatable or linked to an AV category, so:
  * Verify, if you check repeatable, date is disabled
  * Verify, if you select an AV category, date disabled
  * Verify, if you check date, AV category and repeatable are disabled
* Save the new patron attribute
* Edit the patron attribute
  * Verify all settings have been kept/stored correctly

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148826|0   |1
is obsolete||

--- Comment #17 from Shi Yao Wang  ---
Created attachment 157863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157863=edit
Bug 32610: [DO NOT PUSH] DBIC Update

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #148825|0   |1
is obsolete||

--- Comment #16 from Shi Yao Wang  ---
Created attachment 157862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157862=edit
Bug 32610: Add borrower_attribute_types.is_date to the database

* Change to kohastructure.sql for new installations
* Atomic database update to add the column for updating
  installations

Signed-off-by: Philip Orr 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074

Lucas Gass  changed:

   What|Removed |Added

 Attachment #157228|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 157861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157861=edit
Bug 35074: Add support for category_code to writeoff_debts

This patch adds support for passing category_code as a limiter for the
writeoff_debts script.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074

Lucas Gass  changed:

   What|Removed |Added

 Attachment #157227|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 157860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157860=edit
Bug 35074: Add patron relationship alias

This patch adds the 'patron' relationship alias to the Acountline
DBIx::Class schema.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35074] Add --patron_category to writeoff_debts.pl

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35074

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27859] MARC export for search results

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #30 from Lucas Gass  ---
David, unfortunately your tests no longer apply cleanly. (
t/db_dependent/Koha/SearchEngine/Elasticsearch.t ) It looks like a simple fix
where you just need to adjust the number of tests. 

QA Tool:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
   FAIL   valid_template
str/job_progess.inc: not found


I don't see an include in Koha called this. 

Also, don't forget to tidy!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35147] Add classes to Shibboleth text on OPAC login page

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147

Lucas Gass  changed:

   What|Removed |Added

 Attachment #157770|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 157859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157859=edit
Bug 35147: Add classes to Shibboleth text on OPAC login page

This enhancement makes it easier for libraries to change the Shibboleth-related
messages on the OPAC login page.

Libraries can employ OPACUserJS to change the text. For e.g., I can replace the
message "If you do not have a Shibboleth account, but you do have a local
login, then you may login below." by putting the following in OPACUserJS:

$(".shib_local_text").text("If you do not have a staff member account, but are
a member of the library, then you may log in below.");

To test:

1. Go to /cgi-bin/koha/opac-user.pl , or disable the OpacPublic
system preference. Ensure you are logged out of the OPAC.
2. In the staff interface, search for the OPACUserJS system preference under
Koha Administration. Add the following JS and Save:

$(".shib_invalid").text("Test changing the invalid Shibboleth login message.");
$(".shib_title").text("Test changing the Shibboleth login heading.");
$(".shib_url").text("Test changing the Shibboleth account link text.");
$(".shib_local_title").text("Test changing the local login heading.");
$(".shib_local_text").text("Test changing the message that shows if you do not
have a Shibboleth account.");

3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The
invalid Shibboleth login will be a bit harder to test, so if you can't test,
confirm the HTML in the patch looks correct.

Sponsored-by: New Zealand Council for Educational Research
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35147] Add classes to Shibboleth text on OPAC login page

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35149] Add "do nothing" option to CircAutoPrintQuickSlip syspref

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||lu...@bywatersolutions.com

--- Comment #3 from Lucas Gass  ---
Good idea. The CircAutoPrintQuickSlip sys pref is a 'choice' so I think we need
a DB update and change to sysprefs.sql to reflect each choice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050

Owen Leonard  changed:

   What|Removed |Added

 Depends on||35154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154
[Bug 35154] Convert StaffLoginInstructions system preference to additional
contents
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35153] Convert IntranetmainUserblock system preference to additional contents

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154
[Bug 35154] Convert StaffLoginInstructions system preference to additional
contents
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154
[Bug 35154] Convert StaffLoginInstructions system preference to additional
contents
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35154] New: Convert StaffLoginInstructions system preference to additional contents

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154

Bug ID: 35154
   Summary: Convert StaffLoginInstructions system preference to
additional contents
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, testo...@bugs.koha-community.org
Depends on: 31383, 35153
Blocks: 26050

Building on 22318, the StaffLoginInstructions system preference should be
converted to an HTML customization option.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050
[Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
[Bug 31383] Additional contents: We need a parent and child table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153
[Bug 35153] Convert IntranetmainUserblock system preference to additional
contents
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11556] Send any notice to any patron on demand

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item

2023-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   5   >