[Koha-bugs] [Bug 35138] Elastic search - add new facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 --- Comment #12 from Katrin Fischer --- Thank you for including the German translation! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Katrin Fischer changed: What|Removed |Added Attachment #156593|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 158371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158371&action=edit Bug 34328: Add Scottish Gaelic to languages Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Katrin Fischer changed: What|Removed |Added Attachment #156594|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 158372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158372&action=edit Bug 34328: (follow-up) Add description to en_GB This follow-up adds the language description string for Scottish Gaelic to the en_GB translation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Katrin Fischer changed: What|Removed |Added Attachment #156595|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 158373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158373&action=edit Bug 34328: Make update idempotent Signed-off-by: Katrin Fischer Perltidied the atomic update. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Katrin Fischer changed: What|Removed |Added Attachment #158366|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 158374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158374&action=edit Bug 35254: Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 --- Comment #3 from Katrin Fischer --- I really wonder why we didn't stumble on this much sooner? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35223] System preference CurrencyFormat doesn't work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35223 --- Comment #2 from Katrin Fischer --- I was a little short here. The discussion on how to implement different input formats is a long one and we haven't come to a final conclusion/solution so far. I recently wrote up bug 35241 after dicussion with some other devs and I believe it is the approach we should take. It has some of the older bugs linked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35222] Suggestions: Archived should be a status on dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35222 --- Comment #1 from Katrin Fischer --- Hi Holly I was wondering how this would look like. Archived is "boolean", so organizing by Archived would only give you 2 tabs max: archived and not archived. Is that what you were thinking of? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #3 from Katrin Fischer --- I think this is a good improvement, but I see a problem I hadn't thought of before: when editing or creating a new notice/slip, you can change the module on top and then the labels are not changing with it. Should we add the JS to achieve this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Katrin Fischer changed: What|Removed |Added Attachment #158111|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 158375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158375&action=edit Bug 35193: Rename "Message subject" to "File name" when module "Reports" was chosen This changes the form for adding new notices so the "Message subject" is labelled as "File name" when the Reports module was chosen. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Choose to make or edit a reports notice/slip 4) Note the "Message subject" label has been replaced with "File name" for new and existing reports notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer changed: What|Removed |Added Attachment #158284|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 158376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158376&action=edit Bug 35181: Don't pass undef to header It seems passing an undef value causes the headers to be malformed. To test: 1 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 2 - Note 'Invalid-metadata' at top of page, as well as other headers 3 - Apply patch, restart all 4 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 5 - Page should now appear as xml 6 - Edit record 303, or any record with valid metadata in the advanced cataloging editor 7 - Confirm there is no error or alert 8 - Edit record 369 in the advanced cataloging editor 9 - Confirm there is an alert Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26170] Add protected status for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 --- Comment #50 from Katrin Fischer --- I had a look, but it's not obvious to me how to fix :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
--- Comment #99 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #98)
> Until we find such time as to resurrect this, I just wanted to suggest that
> one could create one or more "SOMETYPE_NONOTICE" and wrap your notice in
> something like:
>
> [%- UNLESS reserves.cancellation_reason.match("NONOTICE") %]
>
> [%- END %]
>
> That cancelation notice type will end up being blank and thus won't get sent!
Thx for the workaround :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Katrin Fischer changed: What|Removed |Added Attachment #158368|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 158377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158377&action=edit Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld Signed-off-by: AndrewA Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Katrin Fischer changed: What|Removed |Added Attachment #158369|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 158378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158378&action=edit Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Signed-off-by: AndrewA Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Katrin Fischer changed: What|Removed |Added Attachment #158370|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 158379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158379&action=edit Bug 34557: (follow-up) Tidy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032
--- Comment #9 from Katrin Fischer ---
(In reply to Emmi Takkinen from comment #8)
> (In reply to Marcel de Rooy from comment #5)
> > $hold->set(
> > {
> > priority=> 1,
> > found => undef,
> > waitingdate => undef,
> > expirationdate => $hold->patron_expiration_date,
> > itemnumber => $hold->item_level_hold ? $hold->itemnumber :
> > undef,
> > }
> > )->store({ hold_reverted => 1 });
> >
> > Currently, only this case triggers part of the condition (that could be
> > simplified to reduce repetition) that leads to calling:
> > $self->_set_default_expirationdate;
> > (Unless both dates are still the same..)
> >
> > If they are not, why not respect patron_expiration_date?
> Because I just realized there is a column called patron_expiration_date.
> Somehow this has totally slipped from my attention. You're right, if
> patron_expiration_date exists we should respect it, not generate new one.
> However, what should we do if patron_expiration_date is in past?
It's a really good question. My thought would be to use the existing date
anyway, even if in the past. Some libraries might not auto-cancel those and if
they auto-cancel that will be run nightly, so there is still a moment to
adjust. Maybe we could do an alert or other visual hint?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer changed: What|Removed |Added Attachment #158321|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 158380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158380&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 301396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer changed: What|Removed |Added Attachment #158322|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 158381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158381&action=edit Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer changed: What|Removed |Added Attachment #158323|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 158382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158382&action=edit Bug 34529: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer changed: What|Removed |Added Attachment #158324|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 158383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158383&action=edit Bug 34529: (QA follow-up) Tidy OfflineCirculation.t Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34866] Use template wrapper for breadcrumbs: OPAC part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 --- Comment #6 from Katrin Fischer --- Will these ever end? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34866] Use template wrapper for breadcrumbs: OPAC part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34866] Use template wrapper for breadcrumbs: OPAC part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34866] Use template wrapper for breadcrumbs: OPAC part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Katrin Fischer changed: What|Removed |Added Attachment #158265|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 158384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158384&action=edit Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Recent comments - Most popular - Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - In the OPAC, go to "Register here." Fill out the form and submit your registration. - Check the "Registration complete" page. - Set "PatronSelfRegistrationVerifyByEmail" to "Require" - Submit another registration and check the "Confirm your registration" page. - Visit the registration page passing an invalid token: /cgi-bin/koha/opac-registration-verify.pl?token=foo Check the "Registration invalid" page. - Enable the "ArticleRequests" system preference and log in to the OPAC. - Perform a search which will return results. - Check the search results page - View the detail page for one of the results. - Click "Request article." - Return to the detail page and click "Place hold." - Complete each step of the hold process. - Enable the "OpacAllowSharingPrivateLists" system preference. - Create a private list if necessary. - Click the "Share" link - Locate a serial record and view the detail page. - Click the "More details" link under the "Subscriptions" plan - Enable the system preference "suggestion." - From the logged-in user summary page click "Purchase suggestions" - Click the "New purchase suggestion" link - Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system preferences and log out of the OPAC. - View the purchase suggestions page. - Enable the "OpacCloud" system preference and go to the "Subject cloud" page. (the feature doesn't need to be configured to test). - Populate the "RestrictedPageTitle" and "RestrictedPageContent" system preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl - Remove the contents of "RestrictedPageTitle" and check the page again. - This patch also updates svc/suggestion.tt but I don't know how to test it! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32379] CRASH: Can't call method "itemlost" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32379 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32379] CRASH: Can't call method "itemlost" on an undefined value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32379 Katrin Fischer changed: What|Removed |Added Attachment #158264|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 158385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158385&action=edit Bug 32379: Add check on existing item Simplest fix; bail out with output_error. Test plan: Try /cgi-bin/koha/cataloguing/additem.pl?biblionumber=1&op=saveitem&itemnumber=99 Note: Replace 1 by existing biblionumber, and iitem 99 should not exist. You should get the 404 screen now. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13325] Create a nice view of budget and fund changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Katrin Fischer changed: What|Removed |Added Summary|Add logs for budgets and|Create a nice view of |funds |budget and fund changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29816] Document patron emailer cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29816 --- Comment #2 from Katrin Fischer --- Hi Ray, have you unsuccessfully tried to mark the notice template used as HTML? From looking at the cron I don't see why that wouldn't work. It seems to use the standard procedure for creating emails. The patron emailer documentation on ByWater's blog also included some TT - sadly that is no longer accessible. Maybe by TT you think of specific objects or variables? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805
Katrin Fischer changed:
What|Removed |Added
Keywords||additional_work_needed
--- Comment #23 from Katrin Fischer ---
It looks like this makes the tests failing:
prove -v xt/author/valid-templates.t
# Failed test
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt'
# at xt/author/valid-templates.t line 141.
# file error - parse error -
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
line 103: unexpected token ( Koha.Preference('OnSiteCheckouts'))
# [% IF Koha.Preference('SpecifyDueDate') ||
Koha.Preference('OnSiteCheckouts') %]
# Looks like you failed 1 test of 822.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 --- Comment #24 from Katrin Fischer --- Created attachment 158386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158386&action=edit Bug 28805: (follow-up) Fix non-printable char that breaks tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32119] Cannot add new guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119 Bug 32119 depends on bug 31422, which changed state. Bug 31422 Summary: Library limitations might cause data loss when editing patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What|Removed |Added Attachment #158330|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 158387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158387&action=edit Bug 17798: Confirm hold when printing slip from another patron's account This patch adds a few pieces of information to the print slip button and makes the code confirm the hold As we are printing before the confirm, we also add the ability to pass in the itemnumber to 'ReserveSlip' This is slightly hacky, however, I don't see another way to allow printing without an additional page reload. To test: 1 - Place a title level hold for patron A, for delivery to library B 2 - Attempt to checkout an item from the record above to Patron B from library A 3 - You receive an alert about the hold 4 - Click "Don't check out, confirm hold, and print slip" 5 - Confirm the slip looks correct and has item info 6 - Confirm that item is in transit to fill hold 7 - Revert transit status 8 - Attempt to checkout the item to Patron B from Library B 9 - Click "Don't check out, confirm hold, and print slip" 10 - Confirm slip is correct 11 - Confirm item is marked waiting Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What|Removed |Added Attachment #158331|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 158388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158388&action=edit Bug 17798: Add fieldset for 'Yes, check out (Y)' With the increased text, the buttons don't arrange neatly. Adding a fieldset around the options for 'Yes' mitigates this somewhat - it could do with a bit more styling, however, it also fixes bug 23953 To test: Confirm the 'Yes' options are more clear that they only affect the yes button Confirm the other buttons arrange nicely Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What|Removed |Added Attachment #158332|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 158389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158389&action=edit Bug 17798: (follow-up) Adjust color of fieldset nested in .dialog.alert Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34397] Inconsistencies in Classification sources page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34397 Katrin Fischer changed: What|Removed |Added Attachment #158020|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158390&action=edit Bug 34397: Fix inconsistencies in Classification sources page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the classification configuration administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Test each view to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Classification configuration - New classification source - Edit classification source - New filing rule - Edit filing rule - New splitting rule - Edit splitting rule Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35257] New: Only admin start page uses "circulation desks"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35257 Bug ID: 35257 Summary: Only admin start page uses "circulation desks" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the sidebar and on the desk admin page, we only use "Desks". The administration start page seems to be the only place that uses the term "circulation desk". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35205] Fix duplicate id attribute in desks search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35205] Fix duplicate id attribute in desks search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Katrin Fischer changed: What|Removed |Added Attachment #158227|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158391&action=edit Bug 35205: Fix duplicate id attribute in desks search form This patch updates the header search form for desks administration so that it doesn't contain an HTML id attribute which duplicates one on the desks entry form. To test, apply the patch and make sure the "UseCirculationDesks" system preference is enabled. - Go to Administration -> Circulation desks -> New desk. - Click the "Desk" label in the entry form. Cursor focus should move to the adjacent input field. - Click the "Search desks" label in the header search form to confirm that your cursor moves to the header search form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35205] Fix duplicate id attribute in desks search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35205 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35212] Correct mismatched label on identity provider entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35212 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35212] Correct mismatched label on identity provider entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35212 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35212] Correct mismatched label on identity provider entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35212 Katrin Fischer changed: What|Removed |Added Attachment #158228|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158392&action=edit Bug 35212: Correct mismatched label on identity provider entry form This patch corrects the identity provider form so that the label for the "Allow staff" field has the correct "for" attribute. Currently it is a duplicate of the one for the "Allow OPAC" field. To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider" - Near the bottom of the form, look for the "Allow staff" field. - Clicking the "Allow staff" label should activate the corresponding dropdown. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35215] Make a few assumptions more explicit in Suggestions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35215 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35215] Make a few assumptions more explicit in Suggestions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35215 Katrin Fischer changed: What|Removed |Added Attachment #158177|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158393&action=edit Bug 35215: Add few assumptions in Suggestions.t around emailing Test plan: Without this patch, set pref ReplytoDefault or EmailAddressForSuggestions. Run t/db_dependent/Suggestions.t (FAIL) Fill branch email and reply for CPL branch. Run t/db_dependent/Suggestions.t (FAIL: more errors) Apply patch. Run t/db_dependent/Suggestions.t (PASS) Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35215] Make a few assumptions more explicit in Suggestions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35215 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35241] Markup errors in point of sale template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35241 Katrin Fischer changed: What|Removed |Added Attachment #158285|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158394&action=edit Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled , so it can't be selected. The patch also changes to for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35241] Markup errors in point of sale template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35241 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35219] ERM usage endpoints not showing up in documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35219 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35219] ERM usage endpoints not showing up in documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35219 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35219] ERM usage endpoints not showing up in documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35219 Katrin Fischer changed: What|Removed |Added Attachment #158333|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 158395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158395&action=edit Bug 35219: Fix ERM usage endpoints to show in docs This patch fixes the tags and also adds the tags to the swagger.yaml file to allow the endpoints to be documented correctly. One endpoint has also been deleted as it is no longer required. Test plan: Check the attached files to see that all tags are now prefixed with 'erm_' and that the swagger file now includes an entry for all of these files Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 --- Comment #18 from Katrin Fischer --- I think this is in a somewhat grey area for being a bug fix :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 Katrin Fischer changed: What|Removed |Added Attachment #156732|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 158396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158396&action=edit Bug 34058: Preparation: buildPatronSearchQuery Add table_prefix argument to buildPatronSearchQuery. This allows the buildPatronSearchQuery function to also perform the search on a related table, instead of the default patron table. This is relevant because the query will be performed on the ILL API endpoint, so the table being searched will have to be prefixed with 'patron.', instead of the default 'me.' Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 Katrin Fischer changed: What|Removed |Added Attachment #156733|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 158397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158397&action=edit Bug 34058: Use buildSearchPatronQuery when searching for patrons on left side filters This will now use the centered logic from buildSearchPatronQuery, not only fixing the original issue of not being considering all the terms in the search input, but also reusing already established code. Test plan, k-t-d: 1) Install FreeForm, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a FreeForm ILL request and input 2352935676 in the cardnumber, that's "Henry Acevedo". 3) Go back to the ILL list table, input "henry" in the bottom "Patron" filter input and press the "Search" button, notice it fetches the request correctly. 4) Now do the the same search but with "henry acevedo", notice the request is not retrieved. 5) Apply patch. Repeat. Do the same for the "patron" input field and the "keyword" input field. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34058] ILL - Left filters not considering all terms in input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34058 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34784] Add ability to populate empty item callnumbers for a record based on the itemcallnumber syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #7 from Katrin Fischer ---
I'd like for someone who knows their way around the REST API a little better to
have a second look here.
Most of these are cosmetic and should be quick to follow-up:
1) Needs a follow-up to fix documentation.
+=head3 populate_empty_callnumbers
+
+Controller function that handles deleting a biblio object
2) Spelling
In the item form and the holding table we are using 'call number', but the
patch uses 'callnumber'. I believe we should follow the GUI.
See also: https://wiki.koha-community.org/wiki/Terminology
3) I feel we should include the call number that would be used in the
confirmation question.
if ( confirm(__('Are you sure you want to populate callnumbers for all items
without a callnumber on this record?')) )
4) Please no line breaks in translatable strings!
This is a known issue with Pootle, not sure about Weblate, but translators
often might not know what it is and accidentally remove it.
msg += __('\nReload the page?');
let msg = __('Item populated with the callnumber "%s"\nReload the
page?').format(callnumber);
4) Button in the holdings table
The button for every single item in the holdings table takes up quite a bit of
space. I wonder if we could find a way to make this work a little better. Maybe
a split button with Edit as the main action?
5) Button in the detail page's toolbar (not blocker)
Why not move this into the edit menu?
4) Maintenance script? (not blocker)
I wonder about the use case to require such a one by one change. If you have
itemcallnumber set, this would only apply to items that have been created
before, that have been imported or otherwise added from outside of Koha.
Are there plans for a maintenance script to do this in batch?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 Katrin Fischer changed: What|Removed |Added Summary|Add a hyperlink of the bib |Add link to the |record to items being |bibliographic records when |merged |they are selected for ||merging Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #4 from Katrin Fischer --- Hi Laura, your patch is not quite correct HTML: + ([% record.biblionumber | uri %]) * Your opening tag is not closing * We don't have a link text within the a tag The browsers guess kinda well here, which is why this was probably not found in testing. But if you take a look at the source, you can see that there is an error. I have another suggestion on how to implement this: To display the title, we have: [% INCLUDE 'biblio-title.inc' biblio=record.data %] You can just add a parameter to make that linked to the record: [% INCLUDE 'biblio-title.inc' biblio=record.data link = 1 % -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35258] New: Updating po files locally fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35258 Bug ID: 35258 Summary: Updating po files locally fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr, jonathan.druart+k...@gmail.com gulp po:update --lang de-DE [19:23:06] Using gulpfile /kohadevbox/koha/gulpfile.js [19:23:06] Starting 'po:update'... [19:23:06] Starting 'po_update_marc_marc21'... [19:23:06] Starting 'po_update_marc_unimarc'... [19:23:06] Starting 'po_update_staff'... [19:23:06] Starting 'po_update_opac'... [19:23:06] Starting 'po_update_pref'... [19:23:06] Starting 'po_update_messages'... [19:23:06] Starting 'po_update_messages_js'... [19:23:06] Starting 'po_update_installer'... [19:23:06] Starting 'po_update_installer_marc21'... [19:23:06] Starting 'po_update_installer_unimarc'... [19:23:06] Finished 'po_update_installer' after 643 ms [19:23:06] Finished 'po_update_installer_unimarc' after 645 ms [19:23:06] Finished 'po_update_installer_marc21' after 735 ms [19:23:07] Finished 'po_update_pref' after 891 ms [19:23:07] 'po_update_messages_js' errored after 1.13 s [19:23:07] Error: Command failed: xgettext -L JavaScript --from-code=UTF-8 --package-name Koha --package-version= -k -k__ -k__x -k__n:1,2 -k__nx:1,2 -k__xn:1,2 -k__p:1c,2 -k__px:1c,2 -k__np:1c,2,3 -k__npx:1c,2,3 -kN__ -kN__n:1,2 -kN__p:1c,2 -kN__np:1c,2,3 -k -k$__ -k$__x -k$__n:1,2 -k$__nx:1,2 -k$__xn:1,2 --force-po -o /tmp/koha-xihFUv/Koha-messages-js.pot -f /tmp/koha-xihFUv/files koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue:13: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue:18: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue:45: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue:17: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/FormSelectVendors.vue:48: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue:240: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/Toolbar.vue:12: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue:28: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Home.vue:12: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:28: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:30: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:37: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:40: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:58: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:61: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/Settings.vue:179: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessings.vue:13: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessings.vue:16: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessings.vue:28: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessings.vue:31: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsFormAdd.vue:98: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsFormAdd.vue:100: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsFormAdd.vue:125: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsFormAdd.vue:135: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue:9: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue:12: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsFormAdd.vue:199: warning: RegExp literal terminated too early koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsFormA
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #180 from Katrin Fischer --- I can see we had a lot of iterations here already. I did some testing to help out, but I think I'll leave it to Marcel to finish: 1) QA test tools We have a fail for TT filters: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc FAIL filters wrong_html_filter at line 90 ( XSL - [% filesOption.filename | html %]) wrong_html_filter at line 90 ( XSL - [% filesOption.filename | html %]) wrong_html_filter at line 90 ( XSL - [% filesOption.filename | html %]) ... and a lot of perltidy warns. 2) Export format pull down +XSL - [% filesOption.filename | html %] and other occurences. As we are not exporting an XSL file, it would be nice to rephrase this. Maybe we should just remove XSL in favor of just having the file name? 3) Export format description In the system preference we have: +custom: XSL - Simple Export * Capitalization * We don't export XSL, I believe something like: Simple HTML format would probably be a better match? * It would also guide any other added custom export format, if I understand correctly, so maybe even: Custom export formats, including simple HTML? +$format = "html" if ($format =~ /^xsl\./); It looks like we always assume it will be an HTML file? 4) Commit messages include no test plan. 5) New option for system preference I think we need a database update adding the option to OpacExportOptions and also update sysprefs.sql. 6) I am struggling with adding the sample files to Koha. They are great for testing this, but I am not sure if they are helpful as they are. At the moment, they are incomplete/invalid HTML files. http://www.loc.gov/MARC21/slim";>Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall.Beijing ; O'Reilly, c2012. 7) The path for the custom formats is not configurable. I guess any files added there by libraries could be potentially be overwritten in updates. If this is for custom formats, maybe we should allow for a custom path as well. Overall the concept here feels a little rough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33925] Improve translation of title tags: Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #3 from David Nind --- Some minor changes required: 1. Serial collection - page title for edit serials has brackets with nothing in them: select a couple of editions and click on 'Edit serials' button, browser title page has "Serial edition () > [Serial name] > Serials > Koha (before patch this was "Serial edition [Serial name] > Serials > Koha"). 2. Edit routing list - serial name not in italics for page title: italics used for serial name on other pages, such as the detail page, serial collection; before the patch, the serial name was in italics (Editing routing list for Serial title - with "Serial title" in italics). 3. Check expiration - select a result and click on renew selected subscriptions: pop up window browser title has a ">" at the start: > Serials > Koha (before the patch, the title was "Serials subscription renew > Koha"). 4. Subscription history - serial name not in italics for page title: [Serial details page] > Planning > Manual history - Edit history. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35253] Make materials specified note easier to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35253 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35253] Make materials specified note easier to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35253
David Nind changed:
What|Removed |Added
Attachment #158360|0 |1
is obsolete||
--- Comment #2 from David Nind ---
Created attachment 158398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158398&action=edit
Bug 35253: Add classes to materials specfied message on check in and checkout
To test:
1. APPLY PATCH
2. Add a materials specified message to an item. ( 952$3 )
3. Add the following CSS to your IntranetUserCSS:
.mats_spec_label { color: white; background: purple; }
.mats_spec_message { color: white; background: green; }
4. Checkout that item. Notice the message should be green and the label (Note
about the accompanying materials:) should be purple.
5. Check in that item. Notice the message should be green and the label (Note
about the accompanying materials:) should be purple.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35253] Make materials specified note easier to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35253
David Nind changed:
What|Removed |Added
Text to go in the||This enhancement adds
release notes||classes to the materials
||specified messages that are
||displayed when checking out
||and checking in an item,
||when there is a value for
||an item in 952$3. The new
||classes available for
||customizing IntranetUserCSS
||are mats_spec_label and
||mats_spec_message.
||
||Example
||CSS customization:
||
||.mats_spec_label { color:
||white; background: purple;
||}
|| .mats_spec_message {
||color: white; background:
||green; }
CC||da...@davidnind.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer changed: What|Removed |Added Attachment #153479|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 158399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158399&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] === Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer changed: What|Removed |Added Attachment #153480|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 158400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158400&action=edit Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters * Perltidied the section with tabs in printslip.pl * Fixed indentation and tabs in letter.tt * Added missing TT filters to members-toolbar.inc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer changed: What|Removed |Added Attachment #153481|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 158401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158401&action=edit Bug 32986: (follow-up) Tidy conditional in letter.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer changed: What|Removed |Added Attachment #156800|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 158403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158403&action=edit Bug 32986: (follow-up) Fix CircAutoPrintQuickSlip and remove unecessary module usage Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #29 from Katrin Fischer --- Created attachment 158404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158404&action=edit Bug 32986: (QA follow-up) Rename notices module This renames the notices and slips module from Patrons toolbar (slip) to Patrons (custom slip) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer changed: What|Removed |Added Attachment #153482|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 158402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158402&action=edit Bug 32986: (follow-up) POD Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #30 from Katrin Fischer --- Created attachment 158405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158405&action=edit Bug 32986: (QA follow-up) Remove 'slip' from print dialog This makes it more flexible and the slip can be added to the notice name easily. For example: In German the slip would usually be part of the word, not separate: Gebührenquittung (slip = quittung) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer changed: What|Removed |Added Keywords||rel_23_11_candidate --- Comment #31 from Katrin Fischer --- I think this would make a great addition and is low risk, but: we need some unit tests for the new module. I am setting the keyword and adding my sign-off lines - please hurry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #147 from Katrin Fischer ---
Oi, so many rebases. Sorry we didn't get to this earlier.
1) Can you explain this part of the code please?
+my $last_borrowers_to_anonymise =
$patron->_result->items_last_borrowers->search(
+{
+(
+$older_than_date
+? ( created_on => { '<' =>
$dtf->format_datetime($older_than_date) } )
+: (),
+"itemnumber.damaged" => 0,
+"itemnumber.itemlost" => 0,
+"itemnumber.withdrawn" => 0,
+),
+},
+{ join => ['itemnumber'] }
+);
2) Database updated needs to be reformatted to use the newer template.
3) Terminology / System preference naming
Sorry to be nit-picky about this, but I believe we should stick to the standard
terminology as per our coding guidelines:
* Use AE instead of BE: Anonymise should be Anonymize
* Borrower should be Patron
AnonymiseLastBorrower => AnonymizeLastPatron
AnonymiseLastBorrowerDays => AnonymizeLastPatronDelay/Days
System preference descriptions need to be adapted as well.
4) Cronjob
+use strict;
+use warnings;
--> should be Use Modern::Perl.
5) anonymise_issue_history appears to be unused?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32731] Option for cataloguing tools to also be shown in Tools Home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32731 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #21 from Katrin Fischer --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26468] Item search should include a way to limit by damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26468 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26468] Item search should include a way to limit by damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26468 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26468] Item search should include a way to limit by damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26468 Katrin Fischer changed: What|Removed |Added Attachment #157200|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 158406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158406&action=edit Bug 26468: Add damaged as a searchable status in item search This patch removes the Damaged radio box options ( Ignore, yes, no ) in favor a full damage status search option To test: 1. APPLY PATCH, restart services. 2. Make sure you mark some items as damaged. 3. Go to the item and search and limit by 'Damaged' 4. You should only see your 'Damaged' items. 5. Export the results as a CSV, make sure the CSV is well-formed and accurate. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Perltidied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26468] Item search should include a way to limit by damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26468 --- Comment #8 from Katrin Fischer --- I like this, but it really gets more and more urgent that we get table configuration added to the item search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34708] Ability to modify an order line to increase quantity of ordered item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34708 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Ability to modify an|Ability to modify an order |orderline to increase |line to increase quantity |quantity of ordered item|of ordered item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34708] Ability to modify an order line to increase quantity of ordered item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34708 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34708] Ability to modify an order line to increase quantity of ordered item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34708 Katrin Fischer changed: What|Removed |Added Attachment #156039|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 158407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158407&action=edit Bug 34708: Add ability to modify orderline to increase quantity This enhancement allows libraries to modify an existing orderline and increase the quantity in the order. The quantity is increased by adding more items to the order, through the usual Item for which is visible when adding or modifying an order. To test: 1. Ensure you have a budget, fund, vendor etc. to use the Acquisitions module 2. Open a new basket. Make sure you do NOT check the 'orders are standing' option 3. Add an order to the basket using any method. Add an item or more to this orderline and save the order to the basket 4. Click Modify to edit the orderline 5. Notice the quantity text field. Try to directly change this number. You'll get an error pop-up and be redirected back to the basket. 6. Apply the patch, restart services, refresh the basket page 7. Click Modify to edit the orderline 8. Notice the item form and Items list table is visible with your existing item(s) for this order. There should be no Action buttons as actions can't be done on an existing item order. 9. Confirm you are able to add more items to the Items list and to the order by filling out the form and clicking 'Add item' as normal. Confirm the quantity increases accordingly. 10. Confirm the Edit and Delete buttons for newly added items work as expected 11. Save and confirm the quantity for the orderline has increased 12. Confirm this behaviour persists with the other methods of adding new orders to a basket Sponsored-by: Pymble Ladies' College Signed-off-by: Katariina Hanhisalo Signed-off-by: Katrin Fischer Perltidy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- Please rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
