[Koha-bugs] [Bug 35024] Do not wrap PO files

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35024

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|23.11.00,23.05.6,22.11.12,2 |23.11.00,23.05.06,22.11.12,
released in|2.05.17,21.11.26|22.05.17,21.11.26

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31041] Cashup summary modal printing issue

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31041

--- Comment #27 from Fridolin Somers  ---
(In reply to Katrin Fischer from comment #25)
> (In reply to Fridolin Somers from comment #24)
> > Pushed to 23.05.x for 23.05.06
> 
> This one cause a problem - you will need bug 35295 as well!

Also backported

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34959] Translator tool generates too many changes

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34959

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|23.11.00,23.05.6,22.11.12,2 |23.11.00,23.05.06,22.11.12,
released in|2.05.17,21.11.26|22.05.17,21.11.26

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35333] Koha::Patron->add_guarantor not checking anything

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35333

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #6 from Victor Grousset/tuxayo  ---
(In reply to Katrin Fischer from comment #3)
> I tried without the patch, but got the 404 - can you please check?
> 
> http://localhost:8080/cgi-bin/koha/opac-MARCdetail?biblionumber=119

This URL ↑↑ goes to opac-MARCdetail but it should be opac-MARCdetail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #41 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #40)
> I didn't know that bug 20630 would be necessary. I though it was already
> done in the wild by some providers tweaking their setup to manage to have
> multiple instances sharing the same workers.

If they are, then they're using customized code. 

--

Overall, if folk want to keep going down this path, then by all means they
should. All I would ask is that they have a configuration option for it in
koha-conf.xml which defaults to off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #40 from Victor Grousset/tuxayo  ---
(In reply to David Cook from comment #39)
> (In reply to Martin Renvoize from comment #38)
> > Are tenants not isolated already?  Plugins, by default, go into
> > /var/lib/Koha/site/... and run under the instance user.
> 
> Yeah, currently they're separated. Maybe I'm misunderstanding what Victor
> was saying. I thought he was talking about a scenario with plugins in a bug
> 20630 world where they wouldn't be separated.

I didn't know that bug 20630 would be necessary. I though it was already done
in the wild by some providers tweaking their setup to manage to have multiple
instances sharing the same workers.
Actually even in that case, their number of workers would still be reasonable
vs their number of CPU threads. So there wouldn't even be a blocker here.
That, in addition to the earlier point of plugins being (unavoidably? no matter
how Koha evolves?) shared if workers are shared so it's nonviable to allow
tenants to manage them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

--- Comment #9 from Victor Grousset/tuxayo  ---
> Note that when the work was originally done, readingrec.tt was tracking issues
> (which I believe is all the checkouts of an item)

An issue is the historic name of a checkout.
https://wiki.koha-community.org/wiki/Terminology#I
That can create confusion when looking at history or places where it's not
practical to change ^^"

So it's likely the same in that case.


> Additional testing to the previous test plans could also be done by visiting
> the readingrec page to make sure everything is ok:
> /cgi-bin/koha/members/readingrec.pl?cardnumber=42

Looks good :)


> I think the original string "Note: X out of Y renewals have been logged" was 
> a way to let the user now that only X amount of renewals corresponded to the 
> current checkout, out of a Y total, if that is the case then it's not needed 
> anymore. But I'm not 100%, this is confusing.

Looking more at it: the data-renewals attribute changed by these patches is
what is used by the `if (data.length < renewals)` in checkout_renewals_modal.js
so I'm pretty sure it's rendered obsolete.

As for the cleanup it seems to me that it's the following that needs to be
removed:

checkout_renewals_modal.js:
   if (data.length < renewals) {...}

checkout_renewals.inc:


What does it looks like to you? And to which degree of certainty? ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #158902|0   |1
is obsolete||

--- Comment #2 from Phil Ringnalda  ---
Created attachment 158959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158959=edit
Bug 35328: Add a notes pop-up for authority records to authority search results

This enhancement makes authority record notes (6xx) more accessible in a
special Notes pop-up, available in all authority search result lists.

To test:
1) In the staff interface, go to the Authorities module and conduct a search.
Any records with 6xx fields should show with an italicised Notes link under the
heading. Click on the Notes link for each record and confirm the correct notes
for that record show.
2) Test this in the following staff interface pages:
- authority plugin when cataloguing a biblio record
- batch authority record modification
- batch authority record deletion
3) Test the Notes pop-up is available in the OPAC authority search
4) Confirm the Notes link does NOT show if there is no 6xx field in the record

Sponsored-by: Education Services Australia SCIS
Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Testing notes (using KTD):

1. Enable the ILS-DI system preference.
2. Visit
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=Describe=GetAvailability
3. Search the page for english, and notice that english is not capitalised
4. Apply the patch, restart_all
5. Refresh the page
6. Note that English is now capitalised

OR review the diff for the patch...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

David Nind  changed:

   What|Removed |Added

 Attachment #158901|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 158958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158958=edit
Bug 35327: Fix capitalization of language name

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Can confirm that this is not an issues on master, and that the patch fixes the
issue on 23.05.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

David Nind  changed:

   What|Removed |Added

 Attachment #15|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 158957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158957=edit
Bug 35307: Add a hidden input for expired holds

To test:
 1 - Place 3 holds on a bib, each for a different patron
 2 - IN the db, set the first hold to be expired:
UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1;
 3 - Refresh the holds page for the biblio
 4 - Note the first hold now says 'Expired' in the expiration date column
 5 - Set an expiration date for the last hold
 6 - Click 'Update holds'
 7 - Note the date is applied to the second hold
 8 - Delete the holds
 9 - Apply patch
10 - Repeat 1-6
11 - Confirm only the correct hold is updated

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35283] XSLT 583 Action note is missing subfield h and x in staff interface

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283

--- Comment #13 from David Cook  ---
(In reply to Katrin Fischer from comment #11)
> But then couldn't have any field private information? There is no note on
> the field that indicates any internal use in the documentation and from the
> example it seems like you'd want to see that (if you want your 583 to
> display):
> 
> $h - Jurisdiction
> 
> Name of a person, an institution, or a position or function within an
> institution, in whom or in which responsibility for an action is vested.
> 583   ##$atransfer$c19770613$huniversity archives

The "Name of a person" part is what bothers me. It seems strange for the name
of a staff member to be shown to the public. It just seems implicitly internal
to me. 

But I think I see what you're saying. Yeah, I think a number of these subfields
could have private information. That's why I think it's not a problem hehe. 

I think that's why they have the First Indicator controlling "Private" and "Not
private".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23124] Fields in DefaultPatronSearchFields are not validated and can break patron searching

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124

David Cook  changed:

   What|Removed |Added

Summary|trailing spaces in  |Fields in
   |DefaultPatronSearchFields   |DefaultPatronSearchFields
   |can break patron searching  |are not validated and can
   ||break patron searching

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124

--- Comment #3 from David Cook  ---
(In reply to Jonathan Druart from comment #1)
> I think we should fix it on top of bug 22844.

That would be a good alternative of course

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23124] trailing spaces in DefaultPatronSearchFields can break patron searching

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
I'm going to rename this one as it's part of a larger problem where fields in
DefaultPatronSearchFields aren't validated and so a mistake in this syspref
will break patron search.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #39 from David Cook  ---
(In reply to Martin Renvoize from comment #38)
> Are tenants not isolated already?  Plugins, by default, go into
> /var/lib/Koha/site/... and run under the instance user.

Yeah, currently they're separated. Maybe I'm misunderstanding what Victor was
saying. I thought he was talking about a scenario with plugins in a bug 20630
world where they wouldn't be separated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #11 from Katrin Fischer  ---
Hi Brendan, always happy to have a new tester around! Let us know if we can
help with anything :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #6 from Katrin Fischer  ---
I confirm that it does on longer break the other validation, but I am not sure
if it's the right way to do it. Adding Owen in hope of some guidance.

Also: Your hint displays as:  % - Example: 7.5 % - that doesn't look quite
right yet.

I wonder if using a standard class of Validator would be better here? We could
use number like we do on Bug 34169 - Add validation for monetary input fields
in acquisition module, but maybe with its own class and hint?

That would also make it reusable - the discount is also set on the order form
and there might be other use cases like the search field weighting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

--- Comment #7 from Martin Renvoize  ---
This was also meant to be a tiny and quick follow up to the previous bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Katrin Fischer  changed:

   What|Removed |Added

Summary|There are performance   |Performance issues with
   |issues with edifactmsgs |edifactmsgs when you have a
   |when you have a large   |large number of messages
   |number of messages  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

--- Comment #6 from Martin Renvoize  ---
I used a span with clearfix as that's three interface pattern is seen to date
for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279

--- Comment #5 from Katrin Fischer  ---
I believe this is not only a technical issue but also an issue of better
documentation. We need to enable people to achieve at least the same results as
with 'hungry alligators' in an easy to understand way. Then we can build on it
for more complex things.

And we will need a deprecation period.

But I think we should do it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35339] New: numSearchRSSResults doesn't work

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35339

Bug ID: 35339
   Summary: numSearchRSSResults doesn't work
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: noemie.lab...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Preference numSearchRSSResults is supposed to limit the number of results in
the RSS feed, but it doesn't. The RSS feed shows the number of results that is
specified in OPACnumSearchResults instead.

Test :
1. Fill numSearchRSSResults with a number, let's say 20.
2. Fill OPACnumSearchResults with a number, let's say 50.
3. Go to your OPAC and search for something with more than 50 results.
4. Click on the RSS feed button. The RSS feed will show 50 results instead of
20.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279

--- Comment #4 from Martin Renvoize  ---
This has been stuck for a very long time with minor flurries of activity over
the years.

I'd love to see a concerted effort some time. I've added it to the roadmap, but
we need a commitment from multiple parties to actually work on it, test etc. 
we

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15277

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31510

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should move to TT instead

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||15279


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279
[Bug 15279] Deprecate bespoke syntax for Slips and Notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||31510
 CC||martin.renvoize@ptfs-europe
   ||.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31510
[Bug 31510] The notice template tag helper still uses <<>> sytnax.. we should
move to TT instead
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #15 from Lucas Gass  ---
(In reply to Marcel de Rooy from comment #13)
> Just mentioning: We also have shared lists. A staff member could share a
> list with staff members of choice.

They could share a public list that only staff could edit. Wouldn't this still
be a publicly accessible list? Sounds like we need what Donna and Dani both
mentioned:

Public lists (visible everywhere)
Private lists (visible by the user only )
Staff only (visible only to staff)

Now would that be visible to all staff, or only staff with certain permssions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35338] New: Error in SQL syntax when upgrading to 22.06.00.084

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35338

Bug ID: 35338
   Summary: Error in SQL syntax when upgrading to 22.06.00.084
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

I have done a few upgrades to 22.11.x and 23.05.x now, but I have not seen this
error before: 

Upgrade to 22.06.00.084  [21:21:43]: Bug 31162 - Add primary key to
erm_eholdings_packages_agreements
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error
in your SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near 'CONSTRAINT
erm_eholdings_packages_agreements_uniq,
ADD PRIMARY K' at line 3 at /usr/share/koha/lib/C4/Installer.pm
line 741

I can find that constraint in two places: 

* 220600079.pl:

unless ( TableExists('erm_eholdings_packages_agreements') ) {
$dbh->do(q{
CREATE TABLE `erm_eholdings_packages_agreements` (
`package_id` INT(11) NOT NULL COMMENT 'link to the
package',
`agreement_id` INT(11) NOT NULL COMMENT 'link to the
agreement',
UNIQUE KEY `erm_eholdings_packages_agreements_uniq`
(`package_id`, `agreement_id`),
CONSTRAINT `erm_eholdings_packages_agreements_ibfk_1`
FOREIGN KEY (`package_id`) REFERENCES `erm_eholdings_packages` (`package_id`)
ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT `erm_eholdings_packages_agreements_ibfk_2`
FOREIGN KEY (`agreement_id`) REFERENCES `erm_agreements` (`agreement_id`) ON
DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
COLLATE=utf8mb4_unicode_ci;
});
say $out "Added new table 'erm_eholdings_packages_agreements'";
}

* 220600084.pl:

unless ( primary_key_exists('erm_eholdings_packages_agreements') ){
$dbh->do(q{
ALTER TABLE erm_eholdings_packages_agreements
DROP FOREIGN KEY erm_eholdings_packages_agreements_ibfk_1,
DROP FOREIGN KEY erm_eholdings_packages_agreements_ibfk_2,
DROP CONSTRAINT erm_eholdings_packages_agreements_uniq,
ADD PRIMARY KEY(`package_id`, `agreement_id`)
});
$dbh->do(q{
ALTER TABLE erm_eholdings_packages_agreements
ADD CONSTRAINT `erm_eholdings_packages_agreements_ibfk_1`
FOREIGN KEY (`package_id`) REFERENCES `erm_eholdings_packages` (`package_id`)
ON DELETE CASCADE ON UPDATE CASCADE,
ADD CONSTRAINT `erm_eholdings_packages_agreements_ibfk_2`
FOREIGN KEY (`agreement_id`) REFERENCES `erm_agreements` (`agreement_id`) ON
DELETE CASCADE ON UPDATE CASCADE
});
}


Database version: MariaDB 5.7.34-0ubuntu0.18.04.1-log

OS: 
Distributor ID: Ubuntu
Description:Ubuntu 20.04.6 LTS
Release:20.04
Codename:   focal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35337] New: Patron flags should be transitioned over to restrictions

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35337

Bug ID: 35337
   Summary: Patron flags should be transitioned over to
restrictions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The existence of patron flags seem arbitrary, like leftovers from before
restrictions.  It seems like you could accomplish the same thing with just
restrictions.

I would suggest removal of the flags, and incorporate a Authorized Value that
could be customized with preset restrictions, including the former flags.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35336] New: Add a notification to patrons when a restriction is applied to their account

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35336

Bug ID: 35336
   Summary: Add a notification to patrons when a restriction is
applied to their account
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Some libraries may want the option to notify patrons when a restriction is
placed on their account.  We should add these notifications to the templates,
and allow a checkbox (that can be on or off by default in prefs) to send a
notification to patrons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35012] Framework item plugins fire twice on Acquisition item blocks

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35012

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|23.11.00|23.11.00,23.05.06
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #18 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #10 from David Gustafsson  ---
The attached patch needs some more work. Have done some manual testing and I
think it's probably ok, but need to add tests before ready for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35276] Suggestions form crashes on Unknown column 'auth_forwarded_hash' when logging in

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35276

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|23.11.00|23.11.00,23.05.06
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

--- Comment #9 from David Gustafsson  ---
Created attachment 158956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158956=edit
Bug 33268: Overlay rules don't work correctly when source is set to *

Fallback to overlay rules with wildcard filter if no match
found for exact filter match.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35306] Expired holds are not displayed correctly in staff interface

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Depends on Bug 33575 not in 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35298] Flatpickr makes focus handler in dateaccessioned plugin useless

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35298

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|23.11.00|23.11.00,23.05.06
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33948] Replace GetAllIssues with Koha::Checkouts - staff

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33948

Peter Vashchuk  changed:

   What|Removed |Added

 CC||stalkern...@gmail.com

--- Comment #9 from Peter Vashchuk  ---
Created a ticket where the fix for this problem will be provided ->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] New: Circulation history tab in patron information causes 500 error

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

Bug ID: 35335
   Summary: Circulation history tab in patron information causes
500 error
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: stalkern...@gmail.com
  Reporter: stalkern...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To test: 
1. Change syspref: RecordStaffUserOnCheckout to "record" 
2. Choose a customer who has borrowed something before=has circulation history
(e.g. customer 209 in koha-kktest
https://koha-kktest.lib.helsinki.fi/cgi-bin/koha/mainpage.pl) and see that
circulation history is can be seen.  
3. Borrow something and see circulation history now -> got internal error
(example customer id 232).  
4. Change RecorsStaffUserOnCheckout to "don't record". 
5. See the previous customer's circulation history now, should work as
supposed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33948] Replace GetAllIssues with Koha::Checkouts - staff

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33948

Andrii Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

--- Comment #8 from Andrii Nugged  ---
koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt

[% issue.firstname | html %] [% issue.surname | html %]

changed to:

[% SET issuer = checkout.issuer %]
[% issuer.firstname | html %] [% issuer.surname | html %]

that leads to error:

Koha::Patron->issuer_id is not covered by tests!

should be:


issuer.borrowernumber

I suppose.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Pedro Amorim  changed:

   What|Removed |Added

 Version(s)|23.11.00,23.05.06   |23.11.00,23.05.06,22.11.12
released in||

--- Comment #36 from Pedro Amorim  ---
(In reply to Jonathan Druart from comment #35)
> Pedro, why not backporting this one?

Thanks Jonathan, I've revisited and rebased it. Pushed to 22.11.x for 22.11.12.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Pedro Amorim  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing randomly

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199
Bug 31199 depends on bug 35284, which changed state.

Bug 35284 Summary: No more delay between 2 DT requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309
Bug 35309 depends on bug 35284, which changed state.

Bug 35284 Summary: No more delay between 2 DT requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #59 from Kyle M Hall  ---
Created attachment 158955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158955=edit
Bug 30070: (QA follow-up) Make qa script happy

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #58 from Kyle M Hall  ---
Created attachment 158954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158954=edit
Bug 30070: Remove 'Configure' option from datatable

This passes 0 for table_settings effectively removing the 'Configure'
option from the table. We haven't set up the background logic for table
settings for this table and I don't believe there's a real use case for
that here at the moment.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #57 from Kyle M Hall  ---
Created attachment 158953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158953=edit
Bug 30070: Improve view message modal display

The display had some old specific styling added, we can just use
modal-lg from the bootstrap library now to make the display more
consistent with other modals.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #56 from Kyle M Hall  ---
Created attachment 158952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158952=edit
Bug 30070: (follow-up) Filter out deleted files on the API

EDI uses a 'deleted' flag in the table to denote deleted files, we
should filter those out of the API response.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #55 from Kyle M Hall  ---
Created attachment 158951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158951=edit
Bug 30070: (follow-up) Further javascript fixes

This fixes an issue with the datatables when a message file is found to
be missing the linked vendor or basket details.  This removes the
datatables error: DataTables warning: table id=edi_msgs - Requested
unknown parameter '4' for row 12, column 4.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #54 from Kyle M Hall  ---
Created attachment 158950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158950=edit
Bug 30070: (follow-up) Fix javascript errors

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #53 from Kyle M Hall  ---
Created attachment 158949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158949=edit
Bug 30070: Add koha_obejct_class(s) to EdifactMessage

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #52 from Kyle M Hall  ---
Created attachment 158948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158948=edit
Bug 30070: Add unit tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #51 from Kyle M Hall  ---
Created attachment 158947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158947=edit
Bug 30070: (follow-up) Return unless the related object exists

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #50 from Kyle M Hall  ---
Created attachment 158946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158946=edit
Bug 30070: Update edifactmsgs to use the API

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #49 from Kyle M Hall  ---
Created attachment 158945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158945=edit
Bug 30070: Add fetch endpoint for EDI Files

This patch adds a simple EDI Files listing REST endpoint

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #158933|0   |1
is obsolete||
 Attachment #158934|0   |1
is obsolete||
 Attachment #158935|0   |1
is obsolete||
 Attachment #158936|0   |1
is obsolete||
 Attachment #158937|0   |1
is obsolete||
 Attachment #158938|0   |1
is obsolete||
 Attachment #158939|0   |1
is obsolete||
 Attachment #158940|0   |1
is obsolete||
 Attachment #158941|0   |1
is obsolete||
 Attachment #158942|0   |1
is obsolete||
 Attachment #158943|0   |1
is obsolete||

--- Comment #48 from Kyle M Hall  ---
Created attachment 158944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158944=edit
Bug 30070: Add Koha Objects for EDI Message Files

This patch adds the Koha Object based classes assocaited with the
edifact_message table. This table actually contains the raw message
files which may well each contain multiple edifact messages.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33633] Check if email exists

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633

--- Comment #10 from Christopher Brannon  ---
Perhaps Koha could just have an option for both email and SMS that if an email
or number for SMS is given, it automatically just sends a verification link to
the destination.  The address is listed as unverified in the patron account and
unusable until the patron responds.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35320] Deleting a patron doesn't use AnonymusPatron to anonymize the circulation history

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35320

--- Comment #2 from Noémie Labine  ---
No, the entries are not gone, but to me it would make more sens to group all of
the old issues that don't have a patron anymore (because of anonymization or
deletion) under the AnonymousPatron's name so that if they look at their stats
or in the circulation history of a document, they don't have null entries AND
entries under the AnonymousPatron's name.

If they use an SQL query to look at their old issues and they group the issues
using different borrower's criterias, they would have a null entry and then an
entry for the AnonymousPatron. It would just be more user-friendly I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35334] Give ability to add context to custom Pages in the staff client

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35334

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158932|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 158943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158943=edit
Bug 30070: Remove 'Configure' option from datatable

This passes 0 for table_settings effectively removing the 'Configure'
option from the table. We haven't set up the background logic for table
settings for this table and I don't believe there's a real use case for
that here at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158931|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Created attachment 158942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158942=edit
Bug 30070: Improve view message modal display

The display had some old specific styling added, we can just use
modal-lg from the bootstrap library now to make the display more
consistent with other modals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158930|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize  ---
Created attachment 158941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158941=edit
Bug 30070: (follow-up) Filter out deleted files on the API

EDI uses a 'deleted' flag in the table to denote deleted files, we
should filter those out of the API response.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158929|0   |1
is obsolete||

--- Comment #44 from Martin Renvoize  ---
Created attachment 158940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158940=edit
Bug 30070: (follow-up) Further javascript fixes

This fixes an issue with the datatables when a message file is found to
be missing the linked vendor or basket details.  This removes the
datatables error: DataTables warning: table id=edi_msgs - Requested
unknown parameter '4' for row 12, column 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

--- Comment #35 from Jonathan Druart  ---
Pedro, why not backporting this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158928|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 158939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158939=edit
Bug 30070: (follow-up) Fix javascript errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158927|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 158938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158938=edit
Bug 30070: Add koha_obejct_class(s) to EdifactMessage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158926|0   |1
is obsolete||

--- Comment #41 from Martin Renvoize  ---
Created attachment 158937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158937=edit
Bug 30070: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158925|0   |1
is obsolete||

--- Comment #40 from Martin Renvoize  ---
Created attachment 158936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158936=edit
Bug 30070: (follow-up) Return unless the related object exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158924|0   |1
is obsolete||

--- Comment #39 from Martin Renvoize  ---
Created attachment 158935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158935=edit
Bug 30070: Update edifactmsgs to use the API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158923|0   |1
is obsolete||

--- Comment #38 from Martin Renvoize  ---
Created attachment 158934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158934=edit
Bug 30070: Add fetch endpoint for EDI Files

This patch adds a simple EDI Files listing REST endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158922|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 158933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158933=edit
Bug 30070: Add Koha Objects for EDI Message Files

This patch adds the Koha Object based classes assocaited with the
edifact_message table. This table actually contains the raw message
files which may well each contain multiple edifact messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

--- Comment #8 from David Gustafsson  ---
To summarize how the rules would be applied in a less convoluted way, for a
specific tag and context:

First all the rules for the matching module filter combination (context) are
evaluated, if there is a match, that rule applies.

If no rule was matched then rules for the wildcard filter are evaluated.

There is another issue to address, and that is module priority. Say we have two
or more matching context with different modules, which one applies? I think
this is an oversight in the current implementation, and we have to make sure we
loop through modules in a specific predefined order. Right now we just loop
though the hash keys of "context" provided to the function merge_record in
effect resulting in random order. I will have a go at patch addressing both the
merging issue, and priority of modules.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34413] Flat picker birth date field does not display properly on initial load on iOS

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34413

--- Comment #13 from Christopher Brannon  ---
(In reply to Pedro Amorim from comment #12)
> Nice work everyone!
> 
> Pushed to 22.11.x for next release

Grateful for that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857

--- Comment #21 from Christopher Brannon  ---
(In reply to Pedro Amorim from comment #20)
> Nice work everyone!
> 
> Pushed to 22.11.x for next release

Nice!  Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #36 from Martin Renvoize  ---
Created attachment 158932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158932=edit
Bug 30070: Remove 'Configure' option from datatable

This passes 0 for table_settings effectively removing the 'Configure'
option from the table. We haven't set up the background logic for table
settings for this table and I don't believe there's a real use case for
that here at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35334] New: Give ability to add context to custom Pages in the staff client

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35334

Bug ID: 35334
   Summary: Give ability to add context to custom Pages in the
staff client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org

Currently when creating a page for the staff client using the Pages tool, the
page gets categorized under Tools which reflects in the breadcrumbs and the
left navbar on the page itself.

It would be nice if when creating a page for the staff client, one could define
the logical context of the custom page and give it the associated breadcrumbs
and navbar.

As an example, we have a page that curates a list of clean-up reports.
Currently the breadcrumbs and left navbar are for "Tools" which is confusing
for staff users. It would be helpful if when creating the page we could
categorize it as "Reports" so that it would get the breadcrumbs and left nav
used within the reports module.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #35 from Martin Renvoize  ---
Created attachment 158931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158931=edit
Bug 30070: Improve view message modal display

The display had some old specific styling added, we can just use
modal-lg from the bootstrap library now to make the display more
consistent with other modals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #34 from Martin Renvoize  ---
Created attachment 158930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158930=edit
Bug 30070: (follow-up) Filter out deleted files on the API

EDI uses a 'deleted' flag in the table to denote deleted files, we
should filter those out of the API response.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #33 from Martin Renvoize  ---
Created attachment 158929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158929=edit
Bug 30070: (follow-up) Further javascript fixes

This fixes an issue with the datatables when a message file is found to
be missing the linked vendor or basket details.  This removes the
datatables error: DataTables warning: table id=edi_msgs - Requested
unknown parameter '4' for row 12, column 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158920|0   |1
is obsolete||

--- Comment #32 from Martin Renvoize  ---
Created attachment 158928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158928=edit
Bug 30070: (follow-up) Fix javascript errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158918|0   |1
is obsolete||

--- Comment #31 from Martin Renvoize  ---
Created attachment 158927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158927=edit
Bug 30070: Add koha_obejct_class(s) to EdifactMessage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158915|0   |1
is obsolete||

--- Comment #30 from Martin Renvoize  ---
Created attachment 158926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158926=edit
Bug 30070: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158914|0   |1
is obsolete||

--- Comment #29 from Martin Renvoize  ---
Created attachment 158925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158925=edit
Bug 30070: (follow-up) Return unless the related object exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158913|0   |1
is obsolete||

--- Comment #28 from Martin Renvoize  ---
Created attachment 158924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158924=edit
Bug 30070: Update edifactmsgs to use the API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158912|0   |1
is obsolete||

--- Comment #27 from Martin Renvoize  ---
Created attachment 158923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158923=edit
Bug 30070: Add fetch endpoint for EDI Files

This patch adds a simple EDI Files listing REST endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158911|0   |1
is obsolete||

--- Comment #26 from Martin Renvoize  ---
Created attachment 158922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158922=edit
Bug 30070: Add Koha Objects for EDI Message Files

This patch adds the Koha Object based classes assocaited with the
edifact_message table. This table actually contains the raw message
files which may well each contain multiple edifact messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35273] When editing items on receive, aqorders_items is not updated correctly

2023-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >