[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477

Anni Rajala  changed:

   What|Removed |Added

 CC||anni.raj...@turku.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #96 from Emmi Takkinen  ---
Tried to test this, but patches do not apply. Received this error:

Applying: Bug 25260: Atomic update
Using index info to reconstruct a base tree...
M   C4/Installer.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Installer.pm
CONFLICT (content): Merge conflict in C4/Installer.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 25260: Atomic update
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-25260-Atomic-update-pnuVUG.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #6 from Marcel de Rooy  ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35358] Koha/I18N: The PO directory has not been found.

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358

--- Comment #1 from Marcel de Rooy  ---
Did you grep for more occurrences of the po folder in the codebase when
remvoving it ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35358] Koha/I18N: The PO directory has not been found.

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358

Marcel de Rooy  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35358] New: Koha/I18N: The PO directory has not been found.

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358

Bug ID: 35358
   Summary: Koha/I18N: The PO directory has not been found.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

The PO directory has not been found. There is a problem in your Koha
installation. at /usr/share/koha/Koha/I18N.pm line 197.

Related to recent removal of all PO files from codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277

--- Comment #13 from Marcel de Rooy  ---
Sorry, string freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to stable
 Version(s)||23.05.06
released in||

--- Comment #7 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |In Discussion

--- Comment #3 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #0)
> See bug 35284, fnSetFilteringDelay is no longer working and should be
> removed.

Okay.

> However it's used in fnAddFilters which is used in different places that
> certainly need to be adjusted (using searchDelay? simply removing the delay?)

And now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35174] Remove .po files from the codebase

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35174

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #11 from Fridolin Somers  ---
(In reply to Jonathan Druart from comment #9)
> RMaints, ignore this.

OK not backported

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35266] opac-MARCdetail: Can't call method "metadata" on an undefined value

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35266

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.11.00|23.11.00,23.05.06
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #9 from Fridolin Somers  ---
Pushed to 23.05.x for 23.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

--- Comment #5 from Victor Grousset/tuxayo  ---
(In reply to Andrew Fuerste-Henry from comment #3)
> With the patch applied, the SMS Number field still shows up under the
> messaging pref box on moremember.pl. It kinda feels like setting it in
> BorrowerUnwanted should also hide it on moremember.pl.
> Also, I just filed bug 35356 to suggest we not show SMS Number on
> moremember.pl at all if the patron doesn't have a value for that in their
> record.

Good observation thanks for the new ticket :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159068|0   |1
is obsolete||

--- Comment #4 from Victor Grousset/tuxayo  ---
Created attachment 159074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159074&action=edit
Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField

To test:
1. Add a value to SMSSendDriver like 'Emial'.
2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number
(smsalertnumber)"
3. Go to members/memberentry.pl and see the field is not hidden.
4. APPLY PATCH
5. Try step 3 again and this time the field should be properly hidden.

Note: This patch also includes some indentation changes.
Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

Nick Clemens  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] New: Item not removed from holds queue when checked out to a different patron

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

Bug ID: 35357
   Summary: Item not removed from holds queue when checked out to
a different patron
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When an item is selected for a hold via the holds queue, it is removed from the
queue if checked out to the selected patron. If staff allow another patron to
checkout the book, however, the item is not removed from the queue, and staff
spend time trying to find an item that is not available.


To recreate:
1 - Place a next available hold on a title
2 - Run the holds queue to generate an entry for this
3 - Go to Circulation->Holds queue
4 - Verify you see an item selected
5 - Copy the barcode
6 - Check the item out to a different patron
7 - Confirm the checkout
8 - Reload the holds queue, the item is still there

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Nick Clemens  changed:

   What|Removed |Added

 Attachment #159057|0   |1
is obsolete||

--- Comment #20 from Nick Clemens  ---
Created attachment 159073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159073&action=edit
Bug 35216: Rename error to issuingimpossible

Test plan:
1 - Apply two patches
2 - Confirm code changes make sense
3 - Confirm you can check out items
4 - Confirm checkout blocks still block

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Nick Clemens  changed:

   What|Removed |Added

 Attachment #159056|0   |1
is obsolete||

--- Comment #19 from Nick Clemens  ---
Created attachment 159072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159072&action=edit
Bug 35216: Rename question to needsconfirmation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30533] Add exact search option for patrons

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30533

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22221] Changing an item to a Lost Status on an item level hold does not change the hold

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13498] 'email' templates used for printing slips

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31424] Prompt to change patron messaging if email/SMS absent or changed

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31424

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again.

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10756] Add carousel/coverflow display of new titles to the OPAC

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16605] All notices should give the ability to unsubscribe or flag account for a wrong email address used

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16821] Display complete facets for home libraries, locations, item types

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31746] Patron record saves when cardnumber required and value entered is whitespace

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31746

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31925] AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3935] Schedule tasks periodically

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9081] Opac news not output on checkin and checkout notices

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14787] Allow confirm/continue option to circ warnings at checkout (i.e. OverduesBlockCheckout)

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #153287|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 159071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159071&action=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust
Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #153286|0   |1
is obsolete||

--- Comment #10 from Aleisha Amohia  ---
Created attachment 159070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159070&action=edit
Bug 32142: Add issued_or_reserved option to HoldFeeMode syspref

Database updates

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19098] Additional logic for 260/RDA 264 fields

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19098

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

--- Comment #17 from Victor Grousset/tuxayo  ---
(In reply to Katrin Fischer from comment #12)
> I was wondering: could it be this was the fallback? In old installations
> there was no table for the renewals, I believe the text displayed in this
> case when there are no entries int he renewals table, but renewals happened
> before the table was added.

(In reply to Katrin Fischer from comment #14)
> We are not even on a version with the table yet, I'd like to keep it then :)

So is it about backportability?

---

(In reply to Katrin Fischer from comment #16)
> I think in testing we need to make sure that there is no regression when
> there are no entries in the table, but the renewals count on the checkout is
> > 0 (maybe also needs a last renewed date if you are faking the data).

How should it be possible to get no entries in the table but renewals count on
the checkout > 0 ?

The table created like that, right?:

var items = data.map(function(item) {
return createLi(item);
});

It's the same `data` as the previous `if (data.length < renewals)`. Or maybe
there is still a way to have the two compared values different?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #151793|0   |1
is obsolete||

--- Comment #8 from Aleisha Amohia  ---
Created attachment 159069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159069&action=edit
Bug 27269: Move GetMarcSubjects to Koha namespace

This patch moves C4::Biblio::GetMarcSubjects to
Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be
used in templates and notices.

To test:
1. Find a record that has a subject (6xx).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm subjects show as
normal.
4. Click 'send' and confirm the email sent shows the subjects as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the ubjectsas normal.
6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt)
7. Log in to the OPAC. Find the record and add it to the cart and a list
8. View the cart and click 'more details'. Confirm subjects show as
normal.
9. Click 'send' and confirm the email sent shows the subjects as normal.
10. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the subjects as normal.
11. View the record detail page and confirm the subjects show as normal.
12. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23124] Fields in DefaultPatronSearchFields are not validated and can break patron searching

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124

David Cook  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from David Cook  ---
(In reply to Nick Clemens from comment #4)
> This field is now controlled by a selection editor - so doesn't accept
> manual input - can we consider this fixed?

Yeah that works for me

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #58 from Pablo López Liotti  ---
(In reply to Katrin Fischer from comment #57)
> (In reply to Pablo López Liotti from comment #56)
> > Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a
> > marc fields to make a full item call number.
> > 
> > The ITEMCALLNUMBER syspref holds '080a,092a' value.
> > The 952$o subfield in BKS framework have plugin->callmunber.pl value.
> > I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.
> > 
> > Executing additems.pl only it shows '025' in the form.
> > 
> > Any ideas?
> > 
> > Thks
> > Pablo
> 
> Hi Pablo, this bug is not related to your problem. When in doubt: ask on the
> mailing list or in the IRC chat first :) But: as stated in the system
> preference description, only the first field listed with a value will be
> used. So the preference is behaving as expected. You can currently not
> combine contents from different fields. You could file a new and separate
> enhancement request bug for this.

Thks Katrin, yes, I continued testing many times and understand that take only
a field. 
For the call number as we make (with 2 fields), don´t be useful. 
Maybe works for us if we put UDC in 080$a and complete call number (UDC +
Cutter for topographic) in 092$a. It´s a repetition but by the moment...
The other way is complete the item form in 952$o subfield.
As I understand many libraries (in Latin Américas at least) use that
combination . 
This enhancemente will be most useful for many people. 

Thks again, cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Andrew Fuerste-Henry  ---
This works as described. 
With the patch applied, the SMS Number field still shows up under the messaging
pref box on moremember.pl. It kinda feels like setting it in BorrowerUnwanted
should also hide it on moremember.pl.
Also, I just filed bug 35356 to suggest we not show SMS Number on moremember.pl
at all if the patron doesn't have a value for that in their record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35356] New: SMS number field shows on moremember.pl even when null

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356

Bug ID: 35356
   Summary: SMS number field shows on moremember.pl even when null
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Generally, the patron record details on moremember.pl don't show the labels for
fields for which there is no data -- for example, if your patron doesn't have
an email address, we don't show the Email field at all. However, we're not
consistent about this with SMS Number. If the SMSSendDriver syspref has a
value, then every patron will show "SMS Number" under the messaging prefs table
on moremember.pl, even if they don't have any value there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #159054|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 159068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159068&action=edit
Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField

To test:
1. Add a value to SMSSendDriver like 'Emial'.
2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number
(smsalertnumber)"
3. Go to members/memberentry.pl and see the field is not hidden.
4. APPLY PATCH
5. Try step 3 again and this time the field should be properly hidden.

Note: This patch also includes some indentation changes.
Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29490] Preview for more notices

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490

--- Comment #2 from Katrin Fischer  ---
For a workaround when testing SendAllEmailsTo could be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #57 from Katrin Fischer  ---
(In reply to Pablo López Liotti from comment #56)
> Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a
> marc fields to make a full item call number.
> 
> The ITEMCALLNUMBER syspref holds '080a,092a' value.
> The 952$o subfield in BKS framework have plugin->callmunber.pl value.
> I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.
> 
> Executing additems.pl only it shows '025' in the form.
> 
> Any ideas?
> 
> Thks
> Pablo

Hi Pablo, this bug is not related to your problem. When in doubt: ask on the
mailing list or in the IRC chat first :) But: as stated in the system
preference description, only the first field listed with a value will be used.
So the preference is behaving as expected. You can currently not combine
contents from different fields. You could file a new and separate enhancement
request bug for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] Add API endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||andre...@dubcolib.org

--- Comment #3 from Andrew Fuerste-Henry  ---

> 3) Browse to /api/va/patrons/$id/holds/previous where $id is the
>borrowernumber

Note this should be "/api/v1/patrons..."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] Add API endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #159055|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 159067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159067&action=edit
Bug 35353: Add api endpoint to fetch patron's previous holds

We have an endpoint to fetch a patron's current holds (
/api/va/patrons/$id/holds ) but some external services need to get previous
holds to see if they were completed/canceled/etc.

Test Plan:
1) Create some holds for a patron
2) Complete or cancel those holds
3) Browse to /api/va/patrons/$id/holds/previous where $id is the
   borrowernumber
4) You should get a list of previous holds!

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10958] No need for home link on home page

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958

Katrin Fischer  changed:

   What|Removed |Added

Summary|no need for home link on|No need for home link on
   |home page   |home page

--- Comment #14 from Katrin Fischer  ---
We haven't been asked to change this so far. What about accessibility? Would it
be useful to keep it for orientation?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21106] oai.pl XML output doesn't validate against OAI-PMH XML schema

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21106

--- Comment #3 from Pablo AB  ---
I recently try again. Beside a warning related to Content type encoding (not
sure why) returns an error twice with verb ListMetadataFormats:

> Schema http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd not found!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341

--- Comment #5 from Katrin Fischer  ---
(In reply to Matt Blenkinsop from comment #3)
> No it doesn't look like it - this is a separate issue spotted by one of our
> customers
> 
> Bug 34826 is the most similar but I think that one relates more to bug 34269

Thanks for checking!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348

--- Comment #10 from Aleisha Amohia  ---
Created attachment 159066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159066&action=edit
Bug 33348: Tests

prove Koha/SearchEngine/Elasticsearch/Search.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes and needs protection against cyclic relations

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #7 from Liz Rea  ---
We've seen this too! 

   authid: 25088
 authtypecode: UNIF_TITLE
  datecreated: 2023-11-15
modification_time: 2023-11-15 12:02:37
   origincode: NULL
authtrees:
24939,25086,25088;24939,25083,25086,25088;24939,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25083,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;24939,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;5794,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;25085,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;5794,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088;25085,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088,25086,25088

[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150480|0   |1
is obsolete||

--- Comment #67 from Aleisha Amohia  ---
Created attachment 159065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159065&action=edit
Bug 20844: (follow-up) Fixes for lists, objects, templates, tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150350|0   |1
is obsolete||

--- Comment #66 from Aleisha Amohia  ---
Created attachment 159064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159064&action=edit
Bug 20844: (follow-up) Get working with transfers

Test:

1) Change branch to Branch B
2) Place a biblio-level hold at Branch B
3) Change branch to Branch A
4) Check in item at Branch A and set waiting and trigger transfer
5) Go to edit item and set item as lost
6) Check borrower's notices tab and confirm the lost_waiting_hold notice
was enqueued
7) Follow test plan again with item-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150349|0   |1
is obsolete||

--- Comment #65 from Aleisha Amohia  ---
Created attachment 159063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159063&action=edit
Bug 20844: (follow-up) SendLostHoldNotices

This patch adds a new syspref SendLostHoldNotices

Test:
1) Update database and restart memcached
2) Enable the SendLostHoldNotices system preference
3) Place a hold on an item
4) Check in the item and set the hold to waiting
5) Go to edit the item and set an item lost status
6) Check the borrower's notices and confirm the notice has been enqueued
7) Confirm the notice is not sent twice when reverting or cancelling the
hold
8) Confirm notice enqueues as expected for a bib-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150348|0   |1
is obsolete||

--- Comment #64 from Aleisha Amohia  ---
Created attachment 159062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159062&action=edit
Bug 20844: Revert or cancel lost holds

This patch introduces the RevertLostBibLevelHolds syspref. When an item
is marked as lost, if there is a bib-level hold on it waiting, the hold
is reverted. If there is an item-level hold on it waiting, there is an
alert box asking if the library would like to revert the hold or cancel
it.

Test:

1) Update database and restart memcached/plack
2) Place a hold on Biblio A
3) Check in Item A from Biblio A and set the hold as waiting
4) Edit Item A and give it a lost status (952$1, you may need to edit
your MARC frameworks to have this visible in the Editor)
5) Look at your hold. Notice it is still waiting.
6) Go to Administration -> System preferences. Find the
RevertLostBibLevelHolds system preference and enable it.
7) Cancel your hold and remove Item A's lost status. Place another biblio-level
hold on the same biblio
8) Check in Item A from Biblio A and set the hold as waiting
9) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
10) Edit Item A and give it a lost status
11) Once the page reloads, go to view your hold. It should no longer be
waiting and have no item allocated.
12) Cancel your hold and remove Item A's lost status. Place an item-level hold
on Item A
13) Check in Item A and set the hold as waiting
14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
15) Give Item A a lost status and save changes
16) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
17) Confirm your hold is no longer waiting, but the item is still
allocated
18) Remove Item A's lost status
19) Check in Item A and set the hold as waiting
20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
21) Give Item A a lost status and save changes
22) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
23) Confirm the hold is now cancelled
24) Remove Item A's lost status
25) Place an item-level hold on Item A
26) Check in Item A and set the hold as waiting
27) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
28) Give Item A a lost status and save changes
29) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
30) Confirm your hold is no longer waiting, but the item is still
allocated
31) Remove Item A's lost status
32) Check in Item A and set the hold as waiting
33) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
34) Give Item A a lost status and save changes
35) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
36) Confirm the hold is now cancelled
37) Remove Item A's lost status
38) Place an item-level hold on Item A. Check in Item A and set the hold
as waiting
39) Place an item-level hold on Item B (same biblio) for another borrower.
Check in
Item B and set the hold as waiting.
40) Give both Items A and B lost statuses.
41) Confirm that both Items are included in the alert box on page when
editing items (cataloguing/additem.pl)
42) Confirm that both Items have individual alert boxes on the Items tab
(catalogue/moredetail.pl)
43) Confirm tests pass t/db_dependent/Reserves.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29490] Preview for more notices

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

--- Comment #1 from Lisette Scheer  ---
Yes, this would be especially helpful for new libraries coming to Koha who need
to test notices before crons are turned on.

You can do it by running the message queue in a very targeted way, but that
takes more back end work, making it less accessible to libraries. 

Also, changes to overdue notices need to wait until the overdues run overnight
to make sure nothing goes wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35355] New: Add ability to auto print holds slips through autofillholds system preference

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35355

Bug ID: 35355
   Summary: Add ability to auto print holds slips through
autofillholds system preference
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be nice to expand or enhance the autofillholds functionality. If a
patron places a hold in the OPAC, it would be nice that a hold slip is auto
printed. Another option would be to add an optional notification in the staff
interface home screen that says something like "pending holds" with a print
button to print the hold slips. "Pending holds" would have to be updated in
real time to provide ultimate functionality.

This would be very useful for Archives in which materials must be retrieved
upon request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150800|0   |1
is obsolete||

--- Comment #68 from Aleisha Amohia  ---
Created attachment 159061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159061&action=edit
Bug 24194: (follow-up) Throw an error if expiration date used

Signed-off-by: Nicolas Giraud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #150799|0   |1
is obsolete||

--- Comment #67 from Aleisha Amohia  ---
Created attachment 159060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159060&action=edit
Bug 24194: Add ReserveExpiration system preference to disable expiration date
options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can
see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you
can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as waiting. Notice that an expiration date has
now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system
preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date
field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field
disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice
that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind 
Signed-off-by: Nicolas Giraud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35264] Update patron import to use protected column

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264
Bug 35264 depends on bug 26170, which changed state.

Bug 26170 Summary: Add protected status for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26170] Add protected status for patrons

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/754
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520

--- Comment #10 from Pablo AB  ---
After this bug being fixed, I tried again:

Unpacking koha-common (23.05.04-2) over (22.05.16-2) ...

[...]

Upgrade to 22.06.00.077  [17:29:18]: Bug 31713 - Add ACCOUNTS_SUMMARY slip
notice
Added new letter 'ACCOUNTS_SUMMARY' (print)
Upgrade to 22.06.00.078  [17:29:18]: Bug 24860 - Add ability to place item
group level holds
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create table
`koha_myinstance`.`#sql-e9_19a4` (errno: 150 "Foreign key constraint is
incorrectly formed") at /usr/share/koha/lib/C4/Installer.pm line 741

dpkg: error processing package koha-common (--configure):
 installed koha-common package post-installation script subprocess returned
error exit status 1

I should file a new issue, or this one should be reopened?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
I had a go at testing.

Just to clarify, in case I got something wrong:

1. With --confirm it should do what it is supposed to do (it did for me)

2. Without --confirm it should show what it would change (this didn't work as
expected for me - see 3 and 4)

3. Without --confirm and with only one option, the help is shown, for example:
./misc/cronjobs/writeoff_debts.pl --added-after 2023-06-20

4. Without --confirm with two or more options, it will show what would change,
for example: ./misc/cronjobs/writeoff_debts.pl --added-after 2023-06-20 -v

This is after the patch was applied and transactions set up and date of one
transaction changed to earlier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35345] Pass custom SQL to rebuild_elasticsearch.pl

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35345

--- Comment #7 from Katrin Fischer  ---
(In reply to Thomas Klausner from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > rebuild_zebra.pl as well!
> 
> rebuild_zebra.pl already has a --where flag :-)
> 
> (but it's not using DBIx::Class/Koha::BiblioUtils etc, but directly building
> a query and executing it via DBI)

Yes, you asked about examples and when checking I realized that the Zebra
equivalent already had such a parameter as well. So having it for Elastic too
makes even more sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #6 from Barbara Johnson  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32420] Set focus for cursor to barcode input box in batch item modification

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35354] New: Update language in System Preference EmailLibrarianWhenHoldisPlaced

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354

Bug ID: 35354
   Summary: Update language in System Preference
EmailLibrarianWhenHoldisPlaced
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The system preference, emaillibrarianwhenholdisplaced, states, "sending an
email to the Koha administrator email address whenever a hold request is
placed". However, this will be sent to the library's email address if they are
set up in  Libraries . The fact that Koha says the email gets sent out to the
Koha Admin Email would not be helpful for multi-site libraries within Koha.
With more in the system preference, libraries could know more about how this
will work for their set up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Pablo López Liotti  changed:

   What|Removed |Added

 CC||palio...@mdp.edu.ar

--- Comment #56 from Pablo López Liotti  ---
Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a
marc fields to make a full item call number.

The ITEMCALLNUMBER syspref holds '080a,092a' value.
The 952$o subfield in BKS framework have plugin->callmunber.pl value.
I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.

Executing additems.pl only it shows '025' in the form.

Any ideas?

Thks
Pablo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557

Dave  changed:

   What|Removed |Added

 CC||ddagh...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

David Gustafsson  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #15 from David Gustafsson  ---
Added tests for module priority when multiple module filters matches, and ran
qa-script. Should now be ready for signoff.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348

--- Comment #2 from Martin Renvoize  ---
Work in progress here.. still more work to do and a test plan to follow

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348

--- Comment #1 from Martin Renvoize  ---
Created attachment 159059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159059&action=edit
Bug 35348: Add cookies link to opac footer

This patch adds a link to prompt the cookies info dialogue into the opac
footer when the CookieConsent feature is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

--- Comment #14 from David Gustafsson  ---
Created attachment 159058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159058&action=edit
Bug 33268: Add tests for context module priority

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #18 from Nick Clemens  ---
still needs work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #17 from Nick Clemens  ---
(In reply to Brendan Lawlor from comment #14)
> I tried testing this again, but when I tested circ, searching for a patron
> raised errors that $error and $question were undefined.
> 
Ah, bookings introduced new uses, patches updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #16 from Nick Clemens  ---
Created attachment 159057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159057&action=edit
Bug 35216: Rename error to issuingimpossible

Test plan:
1 - Apply two patches
2 - Confirm code changes make sense
3 - Confirm you can check out items
4 - Confirm checkout blocks still block

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

Nick Clemens  changed:

   What|Removed |Added

 Attachment #159039|0   |1
is obsolete||
 Attachment #159040|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 159056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159056&action=edit
Bug 35216: Rename question to needsconfirmation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] Add API endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add api endpoint to fetch   |Add API endpoint to fetch
   |patron's previous holds |patron's previous holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] Add api endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

--- Comment #1 from Kyle M Hall  ---
Created attachment 159055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159055&action=edit
Bug 35353: Add api endpoint to fetch patron's previous holds

We have an endpoint to fetch a patron's current holds (
/api/va/patrons/$id/holds ) but some external services need to get previous
holds to see if they were completed/canceled/etc.

Test Plan:
1) Create some holds for a patron
2) Complete or cancel those holds
3) Browse to /api/va/patrons/$id/holds/previous where $id is the
   borrowernumber
4) You should get a list of previous holds!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] Add api endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] Add api endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35353] New: Add api endpoint to fetch patron's previous holds

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353

Bug ID: 35353
   Summary: Add api endpoint to fetch patron's previous holds
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
CC: tomasco...@gmail.com

We have an endpoint to fetch a patron's current holds (
/api/va/patrons/$id/holds ) but some external services need to get previous
holds to see if they were completed/canceled/etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

--- Comment #2 from Jonathan Druart  ---
Are you sure? IMO the correct fix is s/issuer.issuer_id/issuer.borrowernumber,
next line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #14 from Brendan Lawlor  ---
I tried testing this again, but when I tested circ, searching for a patron
raised errors that $error and $question were undefined.

Could not compile /kohadevbox/koha/circ/circulation.pl: Global symbol "$error"
requires explicit package name (did you forget to declare "my $error"?) at
/kohadevbox/koha/circ/circulation.pl line 391.
Global symbol "$error" requires explicit package name (did you forget to
declare "my $error"?) at /kohadevbox/koha/circ/circulation.pl line 392.
Global symbol "$question" requires explicit package name (did you forget to
declare "my $question"?) at /kohadevbox/koha/circ/circulation.pl line 427.
Global symbol "$question" requires explicit package name (did you forget to
declare "my $question"?) at /kohadevbox/koha/circ/circulation.pl line 448.
BEGIN not safe after errors--compilation aborted at
/kohadevbox/koha/circ/circulation.pl line 714.
 at /usr/share/perl5/CGI/Compile.pm line 144

I looked at the code for those lines and replaced a couple more instances of
$error with $issuingimpossible and $question with $needsconfirmation. That
resolved the error, and I could look up a patron and checkout items.

But if I checked out an item that was already checked out I got the same error
when testing the first patch:
Can't use string ("RENEW_ISSUE") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/circ/circulation.pl line 420

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151

--- Comment #7 from Pedro Amorim  ---
I'll be looking into this when I get the chance, it's in my pile!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35273] When editing items on receive, aqorders_items is not updated correctly

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273

--- Comment #17 from Klas Blomberg  ---
Tanks - now it's working in both languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331

--- Comment #16 from Pedro Amorim  ---
Brilliant, David. Thank you, you're awesome!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

--- Comment #1 from Lucas Gass  ---
Created attachment 159054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159054&action=edit
Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField

To test:
1. Add a value to SMSSendDriver like 'Emial'.
2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number
(smsalertnumber)"
3. Go to members/memberentry.pl and see the field is not hidden.
4. APPLY PATCH
5. Try step 3 again and this time the field should be properly hidden.

Note: This patch also includes some indentation changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

--- Comment #1 from Peter Vashchuk  ---
Created attachment 159053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159053&action=edit
Bug 35335: Fix 500 error on circulation history tab

The 500 error was caused by this problem:
Koha::Patron->issuer is not covered by tests!

To reproduce:
1. Change syspref RecordStaffUserOnCheckout to "record"
2. Choose a customer who has borrowed something before (has circulation
history) and go to that customers Circulation History tab to check if it can be
seen.
3. Borrow something and go check that customer again, but this time you will
see 500 error.
4. Apply the patch.
5. Check customer's Circulation History tab again, now it should work as
intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >