[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #17 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #16) > Hi Emmi, I just came across bug 35306 that seems to be related and maybe > explains what we have been wondering about here. So it seems and expiration date is now displayed as plain text. However with these patches expiration date changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #7 from Marcel de Rooy --- This really is a rabbit hole ;) This = smart rules.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #18 from Emmi Takkinen --- (In reply to Emmi Takkinen from comment #17) > (In reply to Katrin Fischer from comment #16) > > Hi Emmi, I just came across bug 35306 that seems to be related and maybe > > explains what we have been wondering about here. > > So it seems and expiration date is now displayed as plain text. However with > these patches expiration date changes. Hmm, weird after several testes this doesn't happen anymore. Setting status back to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35358] Koha/I18N: The PO directory has not been found.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358 --- Comment #2 from Jonathan Druart --- Please read the dedicated wiki page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35358] Koha/I18N: The PO directory has not been found.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358 --- Comment #3 from Jonathan Druart --- https://wiki.koha-community.org/wiki/Translation_files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #4 from Jonathan Druart --- The delay is still used for colum filters. Global search is limited by searchDelay -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #18 from Katrin Fischer --- It's not about porting back, but about data. The checkouts_renewals table was added in 22.11, so in Koha terms not that long ago. Before that we had no data bout individual renewals, just the last renewal date and the number of renewals, both stored in issues. So when updating, the checkouts_renewals table was not filled retroactively, because it was not possible. Instead the GUI reacts to it - if there are entries in checkouts_renewals it can show them. If not it shows just summary information. We need to keep that working, as libraries still have tons of old data, but dev environments usually don't. I already suggested how to fake it: (In reply to Katrin Fischer from comment #16) > I think in testing we need to make sure that there is no regression when > there are no entries in the table, but the renewals count on the checkout is > > 0 (maybe also needs a last renewed date if you are faking the data). In issues:Ö increment the number in renewals_count and add a lastreneweddate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35358] Koha/I18N: The PO directory has not been found.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358 --- Comment #4 from Marcel de Rooy --- There is a lot of noise in the logs from this warn. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35358] Koha/I18N: The PO directory has not been found.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35358 --- Comment #5 from Marcel de Rooy --- Lots of: [2023/11/17 09:03:52] [WARN] The PO directory has not been found. There is a problem in your Koha installation. at /usr/share/koha/Koha/I18N.pm line 197. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34671] Collapsing fields in patron form allows saving without mandatory fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34671
--- Comment #22 from Emmi Takkinen ---
(In reply to Marcel de Rooy from comment #20)
> +ignore: "",
> Default should be :hidden. Does this make a difference?
Hmm, if ignore setting isn't set then yes, default is ":hidden". That's why it
has to be set as ignore: "" so that all fields are validated no matter if
they're hidden or not. If we add class to this setting, only those fields are
ignored.
> Comparing with
> +if($(".new_guarantor_relationship").is(":hidden")){
> +$(".new_guarantor_relationship").addClass("ignore_validation");
> +}
>
> -ignore: "",
> +ignore: ".ignore_validation",
>
> Also third patch.
> My first thought here is that we are doing things too complicated?
How form validation works does make things complicated because the way it works
(as stated above). I did at one point test if we could leave class "required"
out if field is hidden but I can't remember if it's even possible or less
complicated to achieve than new class.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341
--- Comment #8 from Marcel de Rooy ---
I think that we are not going in the right direction here with the hidden
backup inputs. We are trying to solve a flatpickr issue here. We should do that
differently.
Seeing several related bugs in the smart rules. Just listing a few:
[1] This is incorrect. The i is the column starting from 0.
} else if ( i == 5 || i == 6 || i == 27 || i == 28 || i
== 29 || current_input_id === "holds_pickup_period" ) {
// If the value is not an integer for
// - "Current checkouts allowed"
// - "Current on-site checkouts allowed"
// - "Holds allowed (total)"
// - "Holds allowed (daily)"
// - "Holds per record (count)"
// - "Holds pickup period (day)"
// The value is "Unlimited" (or an equivalent
translated string)
// an it should be set to an empty string
Current checkouts allowed should be 4?
Because 6 is listed, it is now cleared. (Loan period should allow a zero?)
[2] There is a check on overwriting the edit rule. But shouldnt there be a
check too about warning to overwrite a current rule when saving a blank rule ?
Out of scope.
[3] Flatpickr fields should be cleared in edit rule when saving/submitting.
[4] If you do not click in the flatpickr field, the date is not saved! (This is
in my test patch.) The input is still empty. We should trigger flatpickr to
fill it before.
Will submit a test patch which is not finished but gives an idea of the
solution that I am thinking of.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293
Thibaud Guillot changed:
What|Removed |Added
Attachment #90955|0 |1
is obsolete||
Attachment #90956|0 |1
is obsolete||
Attachment #90957|0 |1
is obsolete||
--- Comment #44 from Thibaud Guillot ---
Created attachment 159075
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159075&action=edit
Bug 14293: The suspension should be calculated in days
There was a mismatch between bug 13909 and bug 5549.
The get_chargeable_units call from _debar_user_on_return should specify
that we want a suspension in days.
However I don't understand the comment let by the author of bug 5549
f61a9617184ec4b24100c1d99150bfd4ebf13336
1/
> finedays is in days, so hourly loans must multiply by 24
Yes but the suspension is in days, so no need to * 24
2/ And we should have a look on this one too:
> grace period is measured in the same units as the loan
But the grace period is always in days. On the circ rules the column is
"Fine grace period (day)".
I think we should replace
DateTime::Duration->new( $unit => $issuingrule->{firstremind} );
with
DateTime::Duration->new( days => $issuingrule->{firstremind} );
Anyway, we definitelly need more tests in this area!
Test plan:
1/ Define an issuing rule with a unit=hour
2/ Set a suspension in days
3/ Check an item out and specify a past due date.
4/ Check the item in
5/ The patron should be debarred correctly
Signed-off-by: Nick Clemens
Signed-off-by: Arthur Suzuki
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #45 from Thibaud Guillot --- Created attachment 159076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159076&action=edit Bug 14293: Rebasing tests --Including:-- Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine Signed-off-by: Arthur Suzuki Signed-off-by: Mark Tompsett Bug 14293: Add more tests and fix floor/ceil Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #9 from Marcel de Rooy --- Created attachment 159077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159077&action=edit Bug 35341: Testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Thibaud Guillot changed: What|Removed |Added CC||thibaud.guil...@biblibre.co ||m --- Comment #46 from Thibaud Guillot --- Hello, I'll try to move this patch forward, I rebased the patch first before adding the "when to charge" option so that everyone can test it under fresh master conditions. Thanks for your feedback -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Thibaud Guillot changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 Pedro Amorim changed: What|Removed |Added Attachment #158976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #19 from Pedro Amorim --- Talked to Katrin about this. She is right. I made the 4th patch obsolete. The message "X out of Y renewals have been logged" refers to the fact that a checkout may have a renewals_count > 0 in the issues tables but not have a corresponding entry in checkout_renewals. This will happen for renewals that happened prior to bug 30275, and the reason behind this is because the data to be moved on to the new checkout_renewals table didn't exist and inserting fake data wouldn't make sense either. The above was the background I was missing. To reproduce the issue she mentions (with all patches applied - including the (QA follow-up): Remove obsolete code patch), clean k-t-d: 1) Checkout barcode 303154 for patron of cardnumber=42 2) Renew it through the database (emulating how the database worked prior to bug 30275), run query: update issues set renewals_count = 3 where issue_id = 1; 3) Visit /cgi-bin/koha/members/readingrec.pl?cardnumber=42 4) Notice "number of renewals" is 3. Click on "View", notice the modal is empty. 5) Remove the last patch, however you want, suggestions: git reset --hard git revert 6) Restart plack, repeat 3) Notice it now says "Note: 0 out of 3 renewals have been logged" as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159059|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 159078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159078&action=edit Bug 35348: Add cookies link to opac footer This patch adds a link that opens the cookies info dialogue to the opac footer when the CookieConsent feature is enabled. Test plan 1) Enable CookieConsent 2) On the OPAC you should now see a 'Cookies' link at the bottom of the page. 3) Clicking the link should open the "Cookie consent" modal where you can see the details of the cookies you have accepted and change your choices. 4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of 'Cookies' in the same footer bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 --- Comment #4 from Martin Renvoize --- Created attachment 159079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159079&action=edit Bug 35348: Ensure users can access cookie details in staff client We remove the check on JSConsents content so that when cookie consent is enabled we retain the option for users to get more information about what cookies are being used. Test plan 1) Enable CookieConsents 2) Do not add any tracking cookies for the staff client into CookieConsentedJS preference 3) Note that 'My consents' appears in the user menu 4) Clicking 'My consents' opens the 'Cookie consent' modal displaying information about the cookies used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 --- Comment #5 from Martin Renvoize --- Created attachment 159080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159080&action=edit Bug 35348: Remove cookie consents link from opac consents The cookies details modal is now visible for all users from a footer link, we no longer need it under the 'Consents' tab for logged in users. Test plan 1) Enable CookieConsent and add a placholder tracker cookie to CookieConsentedJS preference 2) Log into the OPAC 3) Note that the 'Consents' link no longer appears in the users page. 4) Enable 'PrivacyPolicyConsent' 5) Note that the 'Consents' link now appears but on navigating to it there is no link for Cookie consents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||m.de.r...@rijksmuseum.nl, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35347] 'More information' should always display in cookie consent bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35346] 'Accept essential cookies' should always appear if CookieConsent is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792 Martin Renvoize changed: What|Removed |Added Depends on|27378 |34793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Blocks|34792 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792 [Bug 34792] CookieConsentBar content feels mis-aligned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Blocks||34792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792 [Bug 34792] CookieConsentBar content feels mis-aligned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #156299|0 |1 is obsolete|| --- Comment #12 from PTFS Europe Sandboxes --- Created attachment 159081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159081&action=edit Bug 29560: Add link_marc_host to Koha::Biblio This patch adds the new `link_marc_host` method to Koha::Biblio to facilitate adding a host link to the marc record of this biblio. Signed-off-by: Tuomas Kunttu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #156300|0 |1 is obsolete|| --- Comment #13 from PTFS Europe Sandboxes --- Created attachment 159082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159082&action=edit Bug 29560: Add option to create MARC Links when bundling items This patch add a checkbox to the 'Add to bundle' modal allowing the user to optionally add MARC links between the new child record and the current biblio. For MARC21 this will result in a 773 pointing to the host from the item record and for UNIMARC a 461 field will be added. Signed-off-by: Tuomas Kunttu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Tuomas Kunttu changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tuomas.kun...@kouvola.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Anni Rajala changed: What|Removed |Added CC||anni.raj...@turku.fi Status|Needs Signoff |Failed QA --- Comment #22 from Anni Rajala --- I tested this and although this worked otherwise as described in latest test plan, there is a column "item_type" in the table settings that doesn't seem to have a purpose? The column "item_type" is not mentioned in test plan and it didn't seem to have any effect 'cause there isn't such colum in the list view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #8 from Martin Renvoize --- I grabbed Nick.. he thinks the Facet Order does still matter. So we can move this bug forward as is.. but we'll want to tackle any change to the facet side in another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #9 from Martin Renvoize --- (In reply to Martin Renvoize from comment #8) > I grabbed Nick.. he thinks the Facet Order does still matter. > > So we can move this bug forward as is.. but we'll want to tackle any change > to the facet side in another bug. In other words.. bug 35249 is still valid I'm afraid Owen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize changed: What|Removed |Added Attachment #158582|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 159083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159083&action=edit Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Anneli Österman changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||anneli.osterman@koha-suomi. ||fi --- Comment #10 from Anneli Österman --- We tested this but could not reproduce the problem. 1. Notforloan item cannot be checked out with the provided systempreferences. 2. If you check in a not for loan item without checkin in it first, Koha only tells that the item was not onloan. 3. If you allow checkin out of notforloan items and then do the check out and check in, Koha does not tell anything about the notforloan status. Even when ONLYMESSAGE is configured to UpdateNotForLoanStatusOnCheckin. 4. The notforloan status did not dissapear on check in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35359] New: Granular Cataloging permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35359 Bug ID: 35359 Summary: Granular Cataloging permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jza...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl This enhancement to permissions for cataloging would allow library staff to add brief bibs (less than full MARC cataloging) and attach items without allowing them to edit full MARC bibs and without involving the name authority file. 1 - Add a new field/value/permission for users - 'Cataloging level' 2 - Save this cataloging level in the DB when a user adds/edits/updates a bibliographic record 3 - If a record is saved with a higher level than the current user, the user will not be able to edit the bibliographic record 4 - Add to the details page an input/dropdown to allow adjusting the current level for a record - users will only be able to adjust the level to their current level or below 5 - When editing a record, a user of a higher level will have the option to save at their level, or retain the current level 6 - Cataloging levels will be reportable in the Koha reports module 7 - Cataloging levels will be visible on the record details page 8 - An interface will be provided for defining the allowed cataloging levels, allowing to specify as many levels as are needed and make it simple to assign these to a patron [i.e. Staff member]. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35359] Granular Cataloging permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35359 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22317] Performance issues with large number of funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22317 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35359] Granular Cataloging permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35359 Jessie Zairo changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32607] Add import sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #47 from Tomás Cohen Arazi --- (In reply to David Nind from comment #46) > Some comments from testing: > > 1. I'm not sure that I understand what this does, but I assume that it sets > the foundation for being able to limit the editing of bibliographic records > from specific sources to specific staff patrons. More to come... I'll leave > it to someone else to write the release note. Right, this will pair with a new column for the bibliographic metadata table, telling where the record came from. API requests adding/modifying records will need to provide the generated token in the headers to be accepted to be identified as the that particular record source. The patron linking is added so only that patron is allowed to 'represent' that record source (in case of the token being shared, etc). The idea is to later merge the sources listed in the overlay rules as system-defined sources as well. > 2. Tests pass: >- prove t/db_dependent/Koha/RecordSource.t >- prove t/db_dependent/api/v1/record_sources.t > > 3. Editing a record source - I can't edit Name or User fields (the only two > options), so I'm not sure why editing is an option, as you get this error > message: "Something went wrong: Error: Read-only." This is an error. Will try to take a look ASAP. > 4. Applying the patch and getting things to work: >4.1 Apply the patch: use interactive mode and # out the DBIC patch >4.2 Run updatedatabase >4.3 Run dbic >4.4 reset_all Thanks for taking your time on this one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35359] Granular Cataloging permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35359 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35359] Granular Cataloging permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35359 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 --- Comment #23 from Lucas Gass --- (In reply to Anni Rajala from comment #22) > I tested this and although this worked otherwise as described in latest test > plan, there is a column "item_type" in the table settings that doesn't seem > to have a purpose? The column "item_type" is not mentioned in test plan and > it didn't seem to have any effect 'cause there isn't such colum in the list > view. Thanks for testing Anni. I neglected to include item-level_itypes in my test plan. Patch incoming with an adjusted test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What|Removed |Added Attachment #158626|0 |1 is obsolete|| --- Comment #24 from Lucas Gass --- Created attachment 159084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159084&action=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Brendan Lawlor changed: What|Removed |Added Attachment #159072|0 |1 is obsolete|| --- Comment #21 from Brendan Lawlor --- Created attachment 159085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159085&action=edit Bug 35216: Rename question to needsconfirmation Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Brendan Lawlor changed: What|Removed |Added Attachment #159073|0 |1 is obsolete|| --- Comment #22 from Brendan Lawlor --- Created attachment 159086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159086&action=edit Bug 35216: Rename error to issuingimpossible Test plan: 1 - Apply two patches 2 - Confirm code changes make sense 3 - Confirm you can check out items 4 - Confirm checkout blocks still block Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kevin Carnes changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #14 from Kevin Carnes --- Created attachment 159087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159087&action=edit Bug 33847: Rewrite to use SQL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Nick Clemens changed: What|Removed |Added Attachment #136213|0 |1 is obsolete|| Attachment #136214|0 |1 is obsolete|| Attachment #136263|0 |1 is obsolete|| Attachment #139978|0 |1 is obsolete|| Attachment #145920|0 |1 is obsolete|| Attachment #147497|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 159088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159088&action=edit Bug 18064: Add syspref to launch longOverdue script with calendar support The problem here is that the longOverdue script does not support calendars and when libraries set their holidays, long overdues do not take this into account. For example, during the covid pandemic, some libraries were closed for days, maybe months, but longOverdue didn't care and set "lost" or other values on the items. This fix / enhancement based on taking calendars into account to test it, regardless of your rules related to longOverdue, I propose this test plan: Test plan : 1) For clearer vision on what the patch does, have at least "2" libraries 2) Go to Tools/Calendar and place holidays, on each of the libraries for example, of any kind (special, repeated, as you want) 3) Manually run the misc/cronjobs/longoverdue.pl script with the -v (verbose) argument to get as much information as possible 4) You will see a common "block", with today's date + 366 days (by default if you don't pass any arguments to the script), holidays are not taken into account in this date range 5) Apply my patch 6) Launch the updatedatabase 7) Set the new system preference "LongOverdueNoticeCalendar" to "use calendar" 8) Repeat step 3 9) You will see in output one line per library and according to the number of days off in the interval of dates, the start date of the analysis will have been postponed by as many days in order to take these holidays into account. If something is not completely clear, we can of course discuss it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #36 from Nick Clemens --- Rebased and squashed. As far as I can tell, this correctly fetches the calendar per branch, however, the items queries do not take branches into account - so we run a query per branch with different date ranges, but don't limit the items by branch. I think we also need a switch here to control how we will decide which branch to apply - is it the patron's branch? the item's home/holding branch? I think this could follow CircControl - but needs some logic Moving to Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||9596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 [Bug 9596] Allow longoverdue.pl to be configured by library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||18064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #11 from Owen Leonard --- (In reply to Martin Renvoize from comment #9) > In other words.. bug 35249 is still valid I'm afraid Owen :) That's fine... I was trying to wait for Bug 34913 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #37 from Andrew Fuerste-Henry --- (In reply to Nick Clemens from comment #36) > Rebased and squashed. > > As far as I can tell, this correctly fetches the calendar per branch, > however, the items queries do not take branches into account - so we run a > query per branch with different date ranges, but don't limit the items by > branch. > > I think we also need a switch here to control how we will decide which > branch to apply - is it the patron's branch? the item's home/holding branch? > I think this could follow CircControl - but needs some logic > > Moving to Failed QA. That's a great point, though I'm not at all happy about it. Longoverdue does not currently have any concept of branch-specificity (see BZ 9596). There is no branch-agnostic calendar. This one can't move forward without BZ 9596. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35360] New: Inconsistent use/look of 'Cancel hold(s)' button on circ/waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35360 Bug ID: 35360 Summary: Inconsistent use/look of 'Cancel hold(s)' button on circ/waitingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If you go to circ/waitingreserves.pl there are 3 tabs: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. It would be nice if things were a bit more consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 --- Comment #4 from Andrew Fuerste-Henry --- Bug 31157 created a system preference to determine which library's rules to follow when generating overdue notices and restrictions. I think it'd make sense to create a comparable system preference for long overdue notices. It wouldn't be *wrong* to make long overdues just follow the syspref for overdues, but it does feel like someone's going to come up with a compelling need for the distinction sooner or later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Andrew Fuerste-Henry changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #4 from Martin Renvoize --- Created attachment 159089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159089&action=edit Bug 34793: Add default HTML Customisations for cookie information This patch adds some default html customisation content for the cookie consent feature. Test plan 1) Run through the installer and pick to import the sample news items 2) Confirm that after enabling the CookieConsent preference that the default content appears in the cookie bar at the bottom of the page and in the modal that appears after clicking 'More information' Mentored-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #5 from Martin Renvoize --- Created attachment 159090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159090&action=edit Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' The modal is not always about consent, but rather about displaying the libraries cookie policy. It makes sense to update the heading to reflect that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #6 from Martin Renvoize --- Aude did all the hard work here putting together the text, I just helped to construct the patch and upload it. Great work Aude, I think it looks much better now as a feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159078|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 159091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159091&action=edit Bug 35348: Add cookies link to opac footer This patch adds a link that opens the cookies info dialogue to the opac footer when the CookieConsent feature is enabled. Test plan 1) Enable CookieConsent 2) On the OPAC you should now see a 'Cookies' link at the bottom of the page. 3) Clicking the link should open the "Cookie consent" modal where you can see the details of the cookies you have accepted and change your choices. 4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of 'Cookies' in the same footer bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159079|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 159092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159092&action=edit Bug 35348: Ensure users can access cookie details in staff client We remove the check on JSConsents content so that when cookie consent is enabled we retain the option for users to get more information about what cookies are being used. Test plan 1) Enable CookieConsents 2) Do not add any tracking cookies for the staff client into CookieConsentedJS preference 3) Note that 'My consents' appears in the user menu 4) Clicking 'My consents' opens the 'Cookie consent' modal displaying information about the cookies used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159080|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 159093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159093&action=edit Bug 35348: Remove cookie consents link from opac consents The cookies details modal is now visible for all users from a footer link, we no longer need it under the 'Consents' tab for logged in users. Test plan 1) Enable CookieConsent and add a placholder tracker cookie to CookieConsentedJS preference 2) Log into the OPAC 3) Note that the 'Consents' link no longer appears in the users page. 4) Enable 'PrivacyPolicyConsent' 5) Note that the 'Consents' link now appears but on navigating to it there is no link for Cookie consents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Attachment #159089|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 159094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159094&action=edit Bug 34793: Add default HTML Customisations for cookie information This patch adds some default html customisation content for the cookie consent feature. Test plan 1) Run through the installer and pick to import the sample news items 2) Confirm that after enabling the CookieConsent preference that the default content appears in the cookie bar at the bottom of the page and in the modal that appears after clicking 'More information' Mentored-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Attachment #159090|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 159095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159095&action=edit Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' The modal is not always about consent, but rather about displaying the libraries cookie policy. It makes sense to update the heading to reflect that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #9 from Martin Renvoize --- Quick typo fix applied ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35361] New: Search filter on receive orders page crashes the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361
Bug ID: 35361
Summary: Search filter on receive orders page crashes the
system
Change sponsored?: ---
Product: Koha
Version: 23.05
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: andreas.jons...@kreablo.se
CC: tomasco...@gmail.com
The search filter for the table on the page acqui/parcel.pl generates the below
api-request, which results in the below sql query. Note how the LIMIT clause
is applied to the sub-query, not the whole query. For us, this specific query
actually yielded a search result of in total over 171 000 rows.
GET
/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&q={"-and":[{"basket.vendor_id":5},[[{"basket.name":{"like":"%97891%"}}],[{"basket.basket_group.name":{"like":"%97891%"}}],[{"me.order_id":{"like":"%97891%"}}],[{"biblio.title":{"like":"%97891%"}},{"biblio.author":{"like":"%97891%"}},{"biblio.isbn":{"like":"%97891%"}},{"biblio.publisher":{"like":"%97891%"}},{"me.internal_note":{"like":"%97891%"}},{"me.vendor_note":{"like":"%97891%"}}],[{"me.replacement_price":{"like":"%97891%"}}],[{"me.quantity":{"like":"%97891%"}}],[{"me.ecost":{"like":"%97891%"}}],[{"fund.name":{"like":"%97891%"}}]]]}&_match=contains&_order_by=+basket.name
HTTP/1.1
SELECT `me`.`ordernumber`, `me`.`biblionumber`, `me`.`deleted_biblionumber`,
`me`.`entrydate`, `me`.`quantity`, `me`.`currency`, `me`.`listprice`,
`me`.`datereceived`, `me`.`invoiceid`, `me`.`freight`, `me`.`unitprice`,
`me`.`unitprice_tax_excluded`, `me`.`unitprice_tax_included`,
`me`.`quantityreceived`, `me`.`created_by`, `me`.`datecancellationprinted`,
`me`.`cancellationreason`, `me`.`order_internalnote`, `me`.`order_vendornote`,
`me`.`purchaseordernumber`, `me`.`basketno`, `me`.`timestamp`, `me`.`rrp`,
`me`.`replacementprice`, `me`.`rrp_tax_excluded`, `me`.`rrp_tax_included`,
`me`.`ecost`, `me`.`ecost_tax_excluded`, `me`.`ecost_tax_included`,
`me`.`tax_rate_bak`, `me`.`tax_rate_on_ordering`, `me`.`tax_rate_on_receiving`,
`me`.`tax_value_bak`, `me`.`tax_value_on_ordering`,
`me`.`tax_value_on_receiving`, `me`.`discount`, `me`.`budget_id`,
`me`.`budgetdate`, `me`.`sort1`, `me`.`sort2`, `me`.`sort1_authcat`,
`me`.`sort2_authcat`, `me`.`uncertainprice`, `me`.`subscriptionid`,
`me`.`parent_ordernumber`, `me`.`orderstatus`, `me`.`line_item_id`,
`me`.`suppliers_reference_number`, `me`.`suppliers_reference_qualifier`,
`me`.`suppliers_report`, `me`.`estimated_delivery_date`,
`me`.`invoice_unitprice`, `me`.`invoice_currency`, `basket`.`basketno`,
`basket`.`basketname`, `basket`.`note`, `basket`.`booksellernote`,
`basket`.`contractnumber`, `basket`.`creationdate`, `basket`.`closedate`,
`basket`.`booksellerid`, `basket`.`authorisedby`,
`basket`.`booksellerinvoicenumber`, `basket`.`basketgroupid`,
`basket`.`deliveryplace`, `basket`.`billingplace`, `basket`.`branch`,
`basket`.`is_standing`, `basket`.`create_items`, `basket_group`.`id`,
`basket_group`.`name`, `basket_group`.`closed`, `basket_group`.`booksellerid`,
`basket_group`.`deliveryplace`, `basket_group`.`freedeliveryplace`,
`basket_group`.`deliverycomment`, `basket_group`.`billingplace`,
`biblio`.`biblionumber`, `biblio`.`frameworkcode`, `biblio`.`author`,
`biblio`.`title`, `biblio`.`medium`, `biblio`.`subtitle`,
`biblio`.`part_number`, `biblio`.`part_name`, `biblio`.`unititle`,
`biblio`.`notes`, `biblio`.`serial`, `biblio`.`seriestitle`,
`biblio`.`copyrightdate`, `biblio`.`timestamp`, `biblio`.`datecreated`,
`biblio`.`abstract`, `biblioitem`.`biblioitemnumber`,
`biblioitem`.`biblionumber`, `biblioitem`.`volume`, `biblioitem`.`number`,
`biblioitem`.`itemtype`, `biblioitem`.`isbn`, `biblioitem`.`issn`,
`biblioitem`.`ean`, `biblioitem`.`publicationyear`,
`biblioitem`.`publishercode`, `biblioitem`.`volumedate`,
`biblioitem`.`volumedesc`, `biblioitem`.`collectiontitle`,
`biblioitem`.`collectionissn`, `biblioitem`.`collectionvolume`,
`biblioitem`.`editionstatement`, `biblioitem`.`editionresponsibility`,
`biblioitem`.`timestamp`, `biblioitem`.`illus`, `biblioitem`.`pages`,
`biblioitem`.`notes`, `biblioitem`.`size`, `biblioitem`.`place`,
`biblioitem`.`lccn`, `biblioitem`.`url`, `biblioitem`.`cn_source`,
`biblioitem`.`cn_class`, `biblioitem`.`cn_item`, `biblioitem`.`cn_suffix`,
`biblioitem`.`cn_sort`, `biblioitem`.`agerestriction`,
`biblioitem`.`totalissues`, `items`.`itemnumber`, `items`.`biblionumber`,
`items`.`biblioitemnumber`, `items`.`barcode`, `items`.`dateaccessioned`,
`items`.`booksellerid`, `items`.`homebranch`, `items`.`price`,
`items`.`replacementprice`, `items`.`replacementpricedate`,
`items`.`datelastborrowed`, `items`.`datelastseen`, `items`.`stack`,
`items`.`notforloan`, `items`.`damaged`, `items`.`damaged_on`,
`items`.`itemlost`, `items`.`itemlost_on`, `ite
[Koha-bugs] [Bug 35362] New: Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Bug ID: 35362 Summary: Update patron module pop-up windows with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34343 I would like to update two pop-up windows in the patron module to be consistent with Bug 34343 and its children: - Brief patron view - Update child to adult category selection Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34343] Z39.50 search background not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What|Removed |Added Blocks||35362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 [Bug 35362] Update patron module pop-up windows with consistent footer markup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #3 from Andrew Fuerste-Henry --- This works, but could be presented more clearly. Your syspref names strongly imply that one preference controls the behavior of the web-based self checkout while the other controls the behavior of the web-based self check-in. However that is not quite the case. I suggest rewording the sysprefs thus: CircConfirmItemPartsSCI: (Allow / Don't allow) multi-part items to be checked in via the web-based self check-in and self checkout modules. CircConfirmItemPartsSCO: (Allow / Don't allow) multi-part items to be checked out via the web-based self checkout module. This clarifies the difference between the two sysprefs, clarifies that they're not about SIP or any other interface, and makes the wording consistent with SelfCheckInModule and WebBasedSelfCheck. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #1 from Owen Leonard --- Created attachment 159096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159096&action=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34884] Allow styling and customization of checkout screen by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34884 --- Comment #1 from Rebecca Coert --- +1 Having this functionality would be a great help to our public services staff. We have several "special loan" patron categories and this easy-to-notice visual alert would remind staff to not/loan particular items to that patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall changed: What|Removed |Added Attachment #157711|0 |1 is obsolete|| Attachment #157712|0 |1 is obsolete|| Attachment #157713|0 |1 is obsolete|| Attachment #157714|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall --- Created attachment 159097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159097&action=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #24 from Kyle M Hall --- Created attachment 159098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159098&action=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #25 from Kyle M Hall --- Created attachment 159099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159099&action=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #26 from Kyle M Hall --- Created attachment 159100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159100&action=edit Bug 26831: (follow-up) Update system preference description Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #27 from Kyle M Hall --- Created attachment 159101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159101&action=edit Bug 26831: (follow-up) Tidy code for qa script Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #28 from Kyle M Hall --- Created attachment 159102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159102&action=edit Bug 26831: (follow-up) Tidy cleanup_database.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #32 from Thomas Klausner ---
Created attachment 159103
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159103&action=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
This is a slightly improved version of Zenos patch: I (domm) have converted the
code in Koha::Biblio to a more DBICy style and packed it into a transaction (as
requested in Comment 23)
The QA script complains about files being less tidy, but if we add the perltidy
changes to this commit I'm afraid the actual change will be much less clear to
review. So I did not run perltidy on the changed files.
To test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another
one from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) Write a JSON file with inside the field 'biblio_id_to_merge' and the
biblionumber from wihich to merge.
As example:
{
"biblio_id_to_merge" : 9
}
6) Execute an API call with correct headers and location. For example:
curl -s -u koha:koha --header "Content-Type: application/json" --header
"Accept: application/marc-in-json"
--request POST
"http://127.0.0.1:8080/api/v1/biblios/262/merge"; -d @file.json
You must to setup the headers and to use a json file with parameters
7) The record with the id 9 is deleted now, the record with 262 has all
items, etc attached,
the return is: return code 200 and the changed record 262 in
marc-in-json format
8) It is possible to override biblio data with an external bib record. You
need to put external bib record
into the json file in marc-in-json format. To write use the json file
uploaded as example
You need to fill the fields 'rules' and 'datarecord'. The field 'rules'
must contains 'override_ext'
To do the call:
curl -s -u koha:koha --header "Content-Type: application/json"
--header "Accept: application/marc-in-json"
--request POST
"http://127.0.0.1:8080/api/v1/biblios/XXX/merge"; -d @file_with_recod.json
9) The record in 'biblio_id_to_merge' is deleted now, in biblio XXX now
there are the bibliographic data
of field 'datarecord' of json file, the return is: return code 200 and
the changed record XXX in marc-in-json format
10) Go into intranet and do a search. Select two or (better) more record.
11) Merge them; merge must be a success.
12) Test with prove -v t/db_dependent/Koha/Biblio.t
13) Test with prove -v t/db_dependent/api/v1/biblios.t
To test with curl the step 8 you can customize the json file attached in
bugzilla.
The marc-in-json record inside follows the MAR21 standard
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: Zeno Tajoli
Co-authored-by: Thomas Klausner
Co-authored-by: Mark Hofstetter <>
Signed-off-by: Jan Kissig
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35363] New: Update transfer order pop-up window with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 Bug ID: 35363 Summary: Update transfer order pop-up window with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34343 I would like to update the transfer order pop-up window in Acquisitions to be consistent with Bug 34343 and its children. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34343] Z39.50 search background not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What|Removed |Added Blocks||35363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 [Bug 35363] Update transfer order pop-up window with consistent footer markup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Thomas Klausner changed: What|Removed |Added CC||d...@plix.at -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall --- Can we get unit tests for the new methods? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35363] Update transfer order pop-up window with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
