[Koha-bugs] [Bug 35373] New: Remove comment about bug 8000 in gather_print_notices.pl

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35373

Bug ID: 35373
   Summary: Remove comment about bug 8000 in
gather_print_notices.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

misc/cronjobs/gather_print_notices.pl has this: 

directory => $output_directory,
files => $files,
from  => C4::Context->preference('KohaAdminEmailAddress'),# Should be
replaced if bug 8000 is pushed
to=> $email,
transport => $transport,

Bug 8000 was pushed in 2019, but seems related to the "to" address, not the
"from": 

"This enhancement adds a system preference 'SendAllEmailsTo' which, when
populated with a valid email address, will redirect all outgoing mail from Koha
to this address. This feature is intended for use during testing/setup of Koha,
to prevent spamming users."

So maybe the code changed from underneath the comment? Seems like we can remove
this comment to avoid future confusion?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792

--- Comment #2 from Owen Leonard  ---
(In reply to Owen Leonard from comment #1)
> I understand what you mean, but

Hahaha I didn't realize I submitted that unformed thought! I'm almost done with
a patch that I think satisfies the requirements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31630] Batch item deletion no longer shows which items were not removed

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630

Sryan  changed:

   What|Removed |Added

 CC||sr...@lewistonschools.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35372] Support for empty AdvancedSearchTypes

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372

--- Comment #1 from Aleisha Amohia  ---
Created attachment 159149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159149&action=edit
Bug 35372: Add support for AdvancedSearchTypes to be empty and disabled

This enhancement makes it possible to leave the AdvancedSearchTypes system
preference empty if your library would like to disable the item filter tabs
available on the staff interface advanced search. It also adds a message to the
system preference description to describe this.

To test:

1. Go to Koha Administration -> system preferences. Search for the
AdvancedSearchTypes system preference and remove its contents, so it is saved
empty.
2. Go to advanced search in the staff interface. Notice the item types tab
still shows as a filter option.
3. Apply the patch, restart services and refresh the advanced search
4. Confirm the item types tab no longer shows.
5. Add something back to the AdvancedSearchTypes system preference i.e.
itemtypes, ccode
6. Go back to advanced search and confirm your expected tabs show as normal

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35372] Support for empty AdvancedSearchTypes

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||35372


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372
[Bug 35372] Support for empty AdvancedSearchTypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||35372


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372
[Bug 35372] Support for empty AdvancedSearchTypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35372] Support for empty AdvancedSearchTypes

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored
 Depends on||12478, 33186
 Status|NEW |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186
[Bug 33186] Use template wrapper for tabs on search history and advanced search
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35372] New: Support for empty AdvancedSearchTypes

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372

Bug ID: 35372
   Summary: Support for empty AdvancedSearchTypes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Some organisations using Koha do not have holdings/items, and would like to be
able to hide the advanced search 'items' panels, controlled by the
AdvancedSearchTypes system preference. However if this is left empty, item
types filters still show by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

   Assignee|ivan.dzi...@inlibro.com |emily-rose.francoeur@inLibr
   ||o.com
 Status|Failed QA   |Needs Signoff

--- Comment #194 from Emily-Rose Francoeur  
---
Created attachment 159148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159148&action=edit
XSLT test files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33619] the "update sql" window isn't showing obsolete fields and their new names.

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33619

Marie-Luce Laflamme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Marie-Luce Laflamme  ---
I'm not sure how, but this behaviour has disappeared.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #193 from Emily-Rose Francoeur  
---
Created attachment 159147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159147&action=edit
Bug 17385: (QA follow-up) Add CustomXSLTExportPath & improve descriptions

Here is a summary the corrections :
 - Addressed all warnings and failures identified by the QA testing tool
 - Revised the description of the export format (Removed all instances of 'XSL
- ')
 - Updated the description of the custom option in the OpacExportOptions system
   preference
 - Corrected the MARC21_simple_export.xsl file to generate a valid HTML file
 - Introduced the new preference system CustomXSLTExportPath, allowing users to
choose the path for the custom XSL files
 - Updated the sysprefs.sql file for OpacExportOptions and CustomXSLTExportPath
 - Added a new atomic update file for OpacExportOptions and
CustomXSLTExportPath
 - Updated XSLT tests (t/db_dependent/XSLT.t)

NEW TEST PLAN
Prerequisites:
 - Have more than one record in your catalog

Test steps:
1) Search for a record in the intranet
2) Click on the 'Save' button and observe the dropdown menu
---> There is no 'Simple Export' in the dropdown menu
3) Apply the patch
4) In 'Koha administration > System preferences' search 'OpacExportOptions'
5) Enable 'Simple HTML formats' and click on 'Save all OPAC preferences'
6) Repeat steps 1 and 2
---> There is now 'Simple Export' option in the dropdown menu
7) Click on 'Simple Export'
---> a .html file should be downloaded
---> you should see the record informations in the downloaded file
8) Add some item to your Cart
9) Open your Cart
10) Click on the 'Download' button, then click on 'Simple Export'
---> a .html file should be downloaded
---> you should see the records informations in the downloaded file
11) Add some items to a list
12) Open the list
13) Click on the 'Download list' button, then click on 'Simple Export'
---> a .html file should be downloaded
---> you should see the records informations in the downloaded file
14) Do the same steps in OPAC (steps 6 to 13)
15) On your computer, create a folder that will contain the xsl files in the
attachment
16) In the intranet, go to 'Koha administration > System preferences' and
search for 'CustomXSLTExportPath'
17) Write the full path to your created folder and click on the 'Save all
Cataloging preferences'
18) Repeat steps 6 to 14 (no need to download this time, only check that
'Simple Export 1' and 'Simple Export 2' are displaying when you click on the
'Save'/'Download'/'Download list' button)
19) In the system preferences search for OpacExportOptions and disable 'Simple
HTML formats'
20) Repeat steps 6 to 13 in OPAC
---> Notice that 'Simple Export 1' and 'Simple Export 2' are not in the
menu anymore
21) Run 'prove t/db_dependent/XSLT.t'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

 Attachment #156819|0   |1
is obsolete||

--- Comment #192 from Emily-Rose Francoeur  
---
Created attachment 159146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159146&action=edit
Bug 17385: Add custum export format option to the cart and the lists and fix
tests for CustomXSLTExportList

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

 Attachment #156818|0   |1
is obsolete||

--- Comment #191 from Emily-Rose Francoeur  
---
Created attachment 159145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159145&action=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :


$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
#   Failed test 'This list comes from the cache and that is fine'
#   at t/db_dependent/XSLT.t line 122.
#  got: '1'
# expected: '2'
# Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL


This one works fine :


$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS


Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

 Attachment #156817|0   |1
is obsolete||

--- Comment #190 from Emily-Rose Francoeur  
---
Created attachment 159144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159144&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

 Attachment #156816|0   |1
is obsolete||

--- Comment #189 from Emily-Rose Francoeur  
---
Created attachment 159143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159143&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Emily-Rose Francoeur  changed:

   What|Removed |Added

 Attachment #156815|0   |1
is obsolete||

--- Comment #188 from Emily-Rose Francoeur  
---
Created attachment 159142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159142&action=edit
Bug 17385: Add custom export XSLT

Rebase

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Owen Leonard  ---
I understand what you mean, but

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32025] Adding in a column for "checked in by' in patron's circulation history page

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32025

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910

Rhonda Kuiper  changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

--- Comment #5 from Rhonda Kuiper  ---
This sounds like a great solution to the problem we are also facing.  We did
all the complicated setup to get items.location and items.permanent_location to
operate independently for Displays.  But this function keeps breaking with each
update.  Currently, there is a bug 31187 which is trying to address the broken
function in the batch editor.  Having a sys pref to specify our display
locations to act like CART and PROC would be great.  I am imagining it would
work like this:  we set the location to DISPLAY for an item or a batch of
items. The system knows that DISPLAY is a special case and doesn't update the
permanent_location. Then when the item is checked out and then returned, the
location will show the original location.  Great idea!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35153] Convert IntranetmainUserblock system preference to additional contents

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35154] Convert StaffLoginInstructions system preference to additional contents

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

Nick Clemens  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34854] Add ability to skip Talking Tech Itiva notifications for a patron if a given field matches a given value

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34854

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||martin.renvoize@ptfs-europe
   ||.com
 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34854] Add ability to skip Talking Tech Itiva notifications for a patron if a given field matches a given value

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34854

--- Comment #4 from Martin Renvoize  ---
Created attachment 159141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159141&action=edit
Bug 34854: (follow-up) Param name change + POD

This patch updates the parameter name to more clearly define what it's
used for and also adds missing documentation.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34854] Add ability to skip Talking Tech Itiva notifications for a patron if a given field matches a given value

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34854

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158278|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 159140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159140&action=edit
Bug 34854: Add ability to skip Talking Tech Itiva notifications for a patron if
a given field matches a given value

Because some notices are mandatory, some libraries would like to allow patrons
to opt-in to phone notices. The request is to be able to decide if a patron
should get a notice based on the value of a given field ( usually sort1 or
sort2 ).

Test Plan:
1) Apply this patch
2) Enable TalkingTechItivaPhoneNotification
3) Set up some overdue items for a patron
4) Enable phone notices for overdues in the notice status triggers
5) Run the outbound script for OVERDUE with -t OVERDUE
6) Note the output the output contains a line for that patron
7) Set the sort1 field for that patron to TEST
8) Run the script again, adding in the option "-i sort1:TEST"
9) Note the ouput no longer contains that patron!

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35371] New: Display item statuses on the checked in table

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35371

Bug ID: 35371
   Summary: Display item statuses on the checked in table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Libraries have requested to have a column in the checked in table that displays
the item's status.They have requested this because checking items can
periodically be slow depending on bandwidth and connection, causing staff
members to miss Holds, transfers, or proper checkin of items. A column with
hold status or any relevant info will help staff see if it's on hold or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

--- Comment #5 from Peter Vashchuk  ---
Created attachment 159139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159139&action=edit
Bug 35335: Fix 500 error on circulation history tab

The 500 error was caused by this problem:
Koha::Patron->issuer is not covered by tests!

To reproduce:
1. Change syspref RecordStaffUserOnCheckout to "record"
2. Choose a customer who has borrowed something before (has circulation
history) and go to that customers Circulation History tab to check if it can be
seen.
3. Borrow something and go check that customer again, but this time you will
see 500 error.
4. Apply the patch.
5. Check customer's Circulation History tab again, now it should work as
intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #159138|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #159053|0   |1
is obsolete||

--- Comment #4 from Peter Vashchuk  ---
Created attachment 159138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159138&action=edit
Bug 35335: Fix 500 error on circulation history tab

The 500 error was caused by this problem:
Koha::Patron->issuer is not covered by tests!

To reproduce:
1. Change syspref RecordStaffUserOnCheckout to "record"
2. Choose a customer who has borrowed something before (has circulation
history) and go to that customers Circulation History tab to check if it can be
seen.
3. Borrow something and go check that customer again, but this time you will
see 500 error.
4. Apply the patch.
5. Check customer's Circulation History tab again, now it should work as
intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35364] Update serials pop-up windows with consistent footer markup

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364

Owen Leonard  changed:

   What|Removed |Added

Summary|Update label creator pop-up |Update serials pop-up
   |windows with consistent |windows with consistent
   |footer markup   |footer markup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31608] ShowComponentRecords doesn't display components if UseControlNumber is turned on

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31608

Magnus Enger  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||mag...@libriotech.no

--- Comment #4 from Magnus Enger  ---
So the question then is perhaps if this was never implemented with
UseControlNumber, or if it was implemented and some bug snuck in and made it
not work any more? 

In t/db_dependent/Koha/Biblio.t there is a set of subtests labeled
"get_components_query", which seems to be testing with UseControlNumber both
off and on. And the tests pass. 

The original bug 11175 has this patch: 
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126882
"Taking the code in bug 15851 as inspiration this patch also adds proper
handling for UseControlNumber vs EasyAnalytics style 773 linking and
ensures we only return analytic component parts and no other records
containing 773's."

Sounds to me like it should work. I'm changing this from "enh" to "normal bug".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC field 999

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

--- Comment #8 from Hans Pålsson  ---
(In reply to Magnus Enger from comment #6)
> (In reply to Hans Pålsson from comment #5)
> > Magnus, is there an easy way to get around this with a fix?
> 
> It's been a long time since I looked at this, but from the comments above it
> sounds like it should be possible to add a "next" and avoid the problem.

Magnus, we actually did find a strange thing in our installation. By removing
the plugin Biblibre Dibspayment and the db-tables allocated to it posts
actually get imported (!) with 999 correctly. So Insert seems to work. However
Update removes 999 from posts which is not wanted behavior. We will try to
protect 999 using MarcOverlayRules. I think this should be known since Dibs
payment-plugin has nothing to do with import of posts.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35370] New: There should be a system preference to disable checking for holds when issuing an item

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35370

Bug ID: 35370
   Summary: There should be a system preference to disable
checking for holds when issuing an item
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some library systems want the patron with an item in hand to always be able to
checkout the item. It should be possible to configure Koha to ignore holds when
issuing items

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15977] Optional double screen message in Patron Info/Status

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15977

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35369

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35369] SIP default 'Greetings from Koha.' message for patrons should be optional and configurable

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35369

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15977

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35369] New: SIP default 'Greetings from Koha.' message for patrons should be optional and configurable

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35369

Bug ID: 35369
   Summary: SIP default 'Greetings from Koha.' message for patrons
should be optional and configurable
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be nice to have a syspref / sip configuration option to remove or
customize this message without having to use regex on the AF field

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

--- Comment #22 from Pedro Amorim  ---
(In reply to Victor Grousset/tuxayo from comment #21)
> Does the way old data was let in issues.renewals_count means that the
> current strategy is to not bother with temporary inconsistency after
> migration? Then, current patches here are in line with that.

I would say so, I don't think tackling the temporary inconsistency is
cost-effective, because the inconsistency only happens in the items page and
the items page only considers current checkouts. After an upgrade it's only a
matter of time until all current renewals exist in the checkout_renewals table.
Patron circulation history shows everything.

There may be some other things worth improving here, personally I don't think
the string "«Note: 1 out of 2 renewals have been logged»" is a clear enough way
of conveying to the staff user what is happening or has happened, i.e. a person
who does not know the history behind these datatabase tables will likely not
fully understand what that string is referring to (in my opinion anyway, I
didn't and was thrown off by it, but that's me!). But I also don't have a
better suggestion right now!

(In reply to Victor Grousset/tuxayo from comment #21)
> I see, because the old data isn't migrated due to missing date, it's left
> here and all places might need to account for two sources of renewals.

This is not my understanding of the situation, but I may be wrong.
My understanding is that old data was not migrated due to missing datA, not
date.
Before the checkout_renewals table, renewals information just wasn't logged
individually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35346] 'Accept essential cookies' should always appear if CookieConsent is enabled

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346

David Nind  changed:

   What|Removed |Added

 Attachment #159050|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 159137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159137&action=edit
Bug 35346: Update template logic to display 'Essential'

This patch updates the cookie consent template logic to always display
the 'Accept essential cookies' button and only expose the 'Accept all
cookies' button when there are additional cookies to accept, i.e. when
JSConsents is populated.

Test plan
1) Enable CookieConsent
2) Note you see 'Accept essential cookies' in both OPAC and Staff client
   until you have accepted them
3) Add a cookie to ConsentJS
4) Note that you will now see 'Accept all cookies' as well as the 'Accept
   essential cookies' button.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35346] 'Accept essential cookies' should always appear if CookieConsent is enabled

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35347] 'More information' should always display in cookie consent bar

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347

David Nind  changed:

   What|Removed |Added

 Attachment #159045|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 159136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159136&action=edit
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35347] 'More information' should always display in cookie consent bar

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #17 from David Nind  ---
(In reply to Martin Renvoize from comment #13)
> PS, I set up a sandboxes with the full set of bugs applied if, it includes
> the follow-up I just added here too.
> 
> http://opac-cookies.sandboxes.ptfs-europe.co.uk

Thanks Martin! I had missed the other bugs. I can see the bigger picture now...

Thanks also for fixing the CSS for the OPAC display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Attachment #159132|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 159135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159135&action=edit
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Attachment #159095|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 159134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159134&action=edit
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Attachment #159094|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 159133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159133&action=edit
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35368] New: "Add a checkout" shows up twice in online documentation

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35368

Bug ID: 35368
   Summary: "Add a checkout" shows up twice in online
documentation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
CC: tomasco...@gmail.com

https://api.koha-community.org/Development.html#tag/checkouts/operation/addCheckout

https://api.koha-community.org/Development.html#tag/checkouts/operation/addCheckoutPublic

I think we should add (public) to one of the headings.

... also should we maybe have it read: "check out an item"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939

Lari Strand  changed:

   What|Removed |Added

 CC||irina.halmi...@joensuu.fi

--- Comment #14 from Lari Strand  ---
*** Bug 34680 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34680] Renewal due date -> different due times (HH:MM) depending on the input method

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34680

Lari Strand  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||lmstr...@gmail.com
 Status|NEW |RESOLVED

--- Comment #1 from Lari Strand  ---
This seems to be a duplicate of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939.

*** This bug has been marked as a duplicate of bug 34939 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #13 from Martin Renvoize  ---
PS, I set up a sandboxes with the full set of bugs applied if, it includes the
follow-up I just added here too.

http://opac-cookies.sandboxes.ptfs-europe.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies

2023-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793

--- Comment #12 from Martin Renvoize  ---
Created attachment 159132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159132&action=edit
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/