[Koha-bugs] [Bug 34142] Add column sub_location to items table

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142

--- Comment #8 from Emmi Takkinen  ---
(In reply to Owen Leonard from comment #7)
> I see the new column in the items table but when I save an item with the new
> field nothing shows up in items.sub_location. I only see the data in
> more_subfields_xml.
> 
> Even after manually adding data to items.sub_location, I don't see the
> information appearing in circ/returns.tt. On the detail page I see the
> authorized value code instead of the description.
It's hard to say what is going on here. I installed patches from a scratch and
everything works as expected when adding new item. But I don't see it on detail
page or in returns page. 

> Should sub-location appear in every place where location appears? (if so
> please see Bug 35059)
It could, I'll add it after I fix those other pages.

> Should sub-location only display when a location is defined?
I think it should be displayed even if location is not defined.

> Shouldn't the new column in the table have the same capacity as
> items.location? The new one is varchar(10) instead of item.location's
> varchar(80)
I don't see why not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #50 from Marcel de Rooy  ---
 FAIL
   FAIL   git manipulation
The file has been added and deleted in the same patchset

 OK C4/Circulation.pm

 WARN   C4/Overdues.pm
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 122,
now: 125)

 WARN   t/db_dependent/Circulation/maxsuspensiondays.t
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 52,
now: 77)


Processing additional checks

* Signed-off-by line 'Signed-off-by: Arthur Suzuki
' seems invalid
* Signed-off-by line 'Signed-off-by: Mark Tompsett
' seems invalid
* Signed-off-by line 'Signed-off-by: Mark Tompsett
' seems invalid

Running tests (1)
* Proving
/usr/share/koha/t/db_dependent/Circulation/maxsuspensiondays.t KO!
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Incorrect datetime value: 'SCALAR(0x5595a6847398)' for column
`koha_myclone`.`borrowers`.`updated_on` at row 1 at
/usr/share/koha/Koha/Object.pm line 170
 Invalid value passed, borrowers.updated_on=SCALAR(0x5595a6847398) expected
type is datetime # Looks like your test exited with 11 before it could output
anything.
 /usr/share/koha/t/db_dependent/Circulation/maxsuspensiondays.t ..
Dubious, test returned 11 (wstat 2816, 0xb00)
 Failed 4/4 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #159018|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 159228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159228=edit
Bug 35309: Remove DT's fnSetFilteringDelay

On bug 35284 we added the delay on the column filters using dt's
throttle builtin function.

From doc:
https://datatables.net/plug-ins/api/fnSetFilteringDelay
"""
Please note that this plug-in has been deprecated and the dt-init searchDelay
option in DataTables 1.10 should now be used. This plug-in will not operate
with v1.10+.

Test plan:
Note that column filtering still work as before (test on different
tables, see bug 35284 for the list)

Signed-off-by: Lucas Gass 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35309] Remove DT's fnSetFilteringDelay

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35309

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #159226|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 159227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159227=edit
Bug 35393: Fix Objects.t - filter_by_last_update

Test plan:
Keep awake until just after midnight :)
Run t/db_dependent/Koha/Objects.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Marcel de Rooy  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #2 from Marcel de Rooy  ---
Pushing into the queue of Tomas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

--- Comment #1 from Marcel de Rooy  ---
Created attachment 159226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159226=edit
Bug 35393: Fix Objects.t - filter_by_last_update

Test plan:
Keep awake until just after midnight :)
Run t/db_dependent/Koha/Objects.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35393] New: Fix Objects.t for a Jenkins failure when run just after midnight

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35393

Bug ID: 35393
   Summary: Fix Objects.t for a Jenkins failure when run just
after midnight
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

# Subtest: Parameters older_than, younger_than
ok 1 - All updated yesterday
not ok 2 - Yesterday, truncated from is inclusive
ok 3 - Yesterday, not truncated, one hour too late
ok 4 - Yesterday - 1h, not truncated, within time frame

Run around 12:20 AM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

--- Comment #12 from Jonathan Druart  ---
Ideally we should redesign C4::Auth::get_template_and_user to not pass the
lists in this case. But... well... you know... :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #159188|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  ---
Created attachment 159225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159225=edit
Bug 33244: Do not show lists in OPAC if OpacPublic is disabled

This patch updates markup and CSS in the OPAC header so that the Cart
and Lists controls don't appear when OpacPublic is disabled.

The patch also moves the "Your cookies" link into the group of links
with "Log in to your account" and "Search history." This makes the
template logic a little simpler and also seems like a more logical
grouping.

To test, apply the patch and enable the CookieContent system preference.

- View the OPAC with the OpacPublic system preference enabled.
- If necessary, click the "Accept all cookies" button.
- The "Your cookies" link should now appear in the header between the
  log-in link and the search history link.
- Test the page at various browser widths to confirm that the header
  still responds well to changes.
- Go back to system preferences in the staff client and change the
  OpacPublic system preference to "disabled."
- Return to the OPAC and refresh the page. You should be redirected to
  the login page, and the Cart and Lists buttons should no longer appear
  in the header.
- The links in the header for login and cookies should look correct at
  various browser widths.

Signed-off-by: David Cook 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

--- Comment #10 from Jonathan Druart  ---
I could have guessed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33948] Replace GetAllIssues with Koha::Checkouts - staff

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33948

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35366


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35366
[Bug 35366] Circulation history of patron is only visible when there is a
current checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35366] Circulation history of patron is only visible when there is a current checkout

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35366

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||33948
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 CC||jonathan.druart+koha@gmail.
   ||com
   Keywords||rel_23_11_candidate


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33948
[Bug 33948] Replace GetAllIssues with Koha::Checkouts - staff
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35366] Circulation history of patron is only visible when there is a current checkout

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35366

--- Comment #1 from Jonathan Druart  ---
Created attachment 159224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159224=edit
Bug 35366: (bug 33948 follow-up) Fix display of old checkouts if no checkouts
exist

Same patch as
  commit bee2b3d33ed6030b5a63d22148b9955a9897e51d
  Bug 33949: Fix display of old checkouts if no checkouts exist

But for the staff interface.

"""
If we pass an empty array from the perl controller, we retrieve an empty
string from the template, and the merge does not work.

This patch fixes the following bug:
Pick a patron without checkout history
Check them an item out and check it in
=> The table is empty, whereas it should display the item that has been
checked in.
"""

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35366] Circulation history of patron is only visible when there is a current checkout

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35366

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35392


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392
[Bug 35392] HTML in translatable string
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35392] HTML in translatable string

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe
   |com |.com
 Depends on||34587

--- Comment #2 from Jonathan Druart  ---
(In reply to Caroline Cyr La Rose from comment #1)
> I found the same type of string again
> 
> Job for report type %s has been queued,  href="/cgi-bin/koha/admin/background_jobs.pl?op=view=%s"
> target="_blank">click here to check its progress.
> 
> at
> 
> koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/
> UsageStatisticsDataProvidersList.vue:249

Yes, given the code that's expected:
248 message += this.$__(
249 'Job for report type
%s has been queued, click here to check its progress.'
250 ).format(job.report_type,
job.job_id)

Could be improved however.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587
[Bug 34587] Add a Usage Statistics module to ERM
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

--- Comment #12 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509

--- Comment #9 from David Cook  ---
(In reply to Katrin Fischer from comment #8)
> I am not sure I understand the difference between view and list, can you
> explain?

To me, I think "list" would align better with the REST API. It would be a
permission that lets you GET a list of borrowers. 

For the patron detail page, I suppose that might be a list of 1 borrower
conceptually...

I suggested "view" since it implies a read-only permission but it doesn't
really describe much beyond that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

--- Comment #38 from David Cook  ---
(In reply to Lari Strand from comment #37)
> I'm also wondering why we haven't updated the version of the Datatables
> libraries. Should it be updated? We have 4 years of commits missing. 1.13.8
> seemed to work out of the box on my dev install of 22.11.

Yes, it should be updated. It's a big job which is still in progress.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

--- Comment #9 from David Cook  ---
(In reply to David Cook from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > "Log in to your account" is now on the left, is that expected?
> 
> The test plan should've said that you need to run "perl build-resources.PL"
> to re-generate the CSS. 

I should've noted it when testing due to its absence. My bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

--- Comment #8 from David Cook  ---
(In reply to Jonathan Druart from comment #7)
> "Log in to your account" is now on the left, is that expected?

The test plan should've said that you need to run "perl build-resources.PL" to
re-generate the CSS. 

If you don't, it will appear on the left. But if you do run it, then "Log in to
your account" is still on the right as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #11 from Victor Grousset/tuxayo  ---
> 2. Check an item out and in to a patron

"and in" doesn't seem necessary. So we can circumvent Bug 35366, David had to
do the same.

Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35335] Circulation history tab in patron information causes 500 error

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159157|0   |1
is obsolete||

--- Comment #10 from Victor Grousset/tuxayo  ---
Created attachment 159219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159219=edit
Bug 35335: Fix 500 on circulation history

Koha::Patron->issuer is not covered by tests!

Test plan:
1. Set RecordStaffUserOnCheckout to "record"
2. Check an item out and in to a patron
3. Go to their circulation history
=> Without the patch you get an error
=> With this patch applied the table displayed correct. The "checkout by"
column contains the name and the link to the librarian

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

--- Comment #24 from Katrin Fischer  ---
Maybe we should move discussion about improving the GUI to a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509

--- Comment #8 from Katrin Fischer  ---
I am not sure I understand the difference between view and list, can you
explain?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35392] HTML in translatable string

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392

--- Comment #1 from Caroline Cyr La Rose  ---
I found the same type of string again

Job for report type %s has been queued, click here to check its progress.

at

koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersList.vue:249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35392] New: HTML in translatable string

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392

Bug ID: 35392
   Summary: HTML in translatable string
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ERM
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: caroline.cyr-la-r...@inlibro.com
CC: jonathan.druart+k...@gmail.com,
jonathan.fi...@ptfs-europe.com,
martin.renvo...@ptfs-europe.com,
matt.blenkin...@ptfs-europe.com,
pedro.amo...@ptfs-europe.com

This string appears as is in Weblate to be translated, HTML tags and all

Job for uploaded file has been queued, click here to check its progress.

Usually, HTML tags don't appear. I'm not sure what is different for this one.
Probably something to do with JS or Vue?

For reference, the line is

koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFileImport.vue:93

Furthermore, while we are there to correct it, we should also correct the
"click here" link. I understand it is not an accessible way of making links.

All other job queue messages look like this

H1 Title: The job has been enqueued!
Text: It will be processed as soon as possible.
Link: View detail of the enqueued job

See for example
https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt#L78

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA
   Severity|minor   |enhancement

--- Comment #4 from Victor Grousset/tuxayo  ---
> Generally, the patron record details on moremember.pl don't show the labels 
> for fields for which there is no data -- for example, if your patron doesn't 
> have an email address, we don't show the Email field at all. However, we're 
> not consistent about this with SMS Number

Even though, this really looks more like an enhancement.

Regardless, I noticed too late ^^ It works, makes sense, QA script happy, code
looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #4 from Andreas Jonsson  ---
Replacing "prefetch" with "join" actually solves this problem.   Why are we
using "prefetch"?  This is what the documentation has to say:

"Prefetch does a lot of deep magic. As such, it may not behave exactly as you
might expect."

On the other hand, the documentation also says:

"...,  only the prefetch technique will deal sanely with fetching related
objects over a has_many relation. "

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159117|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 159214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159214=edit
Bug 35356: Show SMS labels only when data exists

To test:
APPLY PATCH
1. Set SMSSendDriver = Email
2. Admin > SMS cellular providers, have at least 1.
3. Go to the members/moremember.pl
4. If the patron has no SMSnumber or SMS provider then niether of the labels
should appear.
5. Add both a SMSnumber and SMS provider, make sure the data appears correctly
on members/moremember.pl.

Signed-off-by: Andrew Fuerste Henry 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #3 from Andreas Jonsson  ---
Created attachment 159213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159213=edit
Bug 35361: Replace prefetch with join in REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35391] In new order empty first item type is selected

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35391

--- Comment #3 from Fridolin Somers  ---
Created attachment 159212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159212=edit
Bug 35391: In new order empty add empty value in item types select

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35391] In new order empty first item type is selected

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35391

--- Comment #2 from Fridolin Somers  ---
(In reply to Fridolin Somers from comment #1)
> Item type should be mandatory like title ?

Depends on item type level item or record maybe

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35391] In new order empty first item type is selected

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35391

--- Comment #1 from Fridolin Somers  ---
Item type should be mandatory like title ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35391] In new order empty first item type is selected

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35391

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35391] New: In new order empty first item type is selected

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35391

Bug ID: 35391
   Summary: In new order empty first item type is selected
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

When creating a new order from suggestion or new empty record, the first item
type is selected.
There should be an empty value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #2 from Andreas Jonsson  ---
This is apparently a known issue with DBIx:
https://rt.cpan.org/Public/Bug/Display.html?id=59764

Open since 2010 with priority "low".

Do we have a plan to move away from DBIx?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #21 from Shi Yao Wang  ---
rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #144471|0   |1
is obsolete||

--- Comment #20 from Shi Yao Wang  ---
Created attachment 159211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159211=edit
Bug 26573: Remove remaining reference to category_code column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #144470|0   |1
is obsolete||

--- Comment #19 from Shi Yao Wang  ---
Created attachment 159210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159210=edit
Bug 26573: Limit patron attribute types to more than one patron category

Test plan:
1. Create patron attribute types, some with a category limit, some
   without
2. Apply patch
3. Run installer/data/mysql/updatedatabase.pl
4. Run misc/devel/update_dbix_class_files.pl --koha-conf
5. Restart koha
6. Verify that existing category limits were kept
7. Create a new patron attribute type and select multiple category
   limits. Verify that they have been saved correctly.
8. Edit this patron attribute type and modify category limits. Verify
   that the changes have been saved correctly
9. Go to the patron creation form, and verify that patron attributes are
   shown/hidden accordingly when categorycode is changed.
10. Go to patron batch modification tool, enter a cardnumber (or a
borrowernumber) and submit the form to go to the next step.
Now select a patron attribute type that has category limits and
verify that the message shown to the right is correct

Signed-off-by: Aude Charillon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #60 from Pablo López Liotti  ---
(In reply to Victor Grousset/tuxayo from comment #59)
> Hi :)
> 
> (In reply to Pablo López Liotti from comment #58)
> > This enhancemente will be most useful for many people. 
> 
> Here is the place to open a new ticket:
> https://bugs.koha-community.org/bugzilla3/enter_bug.cgi
> 
> Here is documentation about opening tickets, mostly centered on proper bugs
> (stuff broken) but still has some info about enhancements/new feature
> requests:
> https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines

Thks so much Victor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35390] New: Display all types of sites associated with orders in acqui/lateorders.pl and acqui/histsearch.pl

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35390

Bug ID: 35390
   Summary: Display all types of sites associated with orders in
acqui/lateorders.pl and acqui/histsearch.pl
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathsaby...@gmail.com
QA Contact: testo...@bugs.koha-community.org

In acqui/lateorders.pl and acqui/histsearch.pl we should be able to display (or
hide if not needed...) :
- BASKET Delivery place
- BASKET Billing place
- BASKET GROUP Delivery place
- BASKET GROUP Billing place
- BASKET Managing library
and
- BASKET Managed by

I cannot test on master, but this is not the case in 22.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361

--- Comment #1 from Andreas Jonsson  ---
This is just an instance of a much bigger problem with DBIx.

For instance the SQL code of an ordinary borrower search looks like this, once
again, the LIMIT-clause is applied on the subquery:

SELECT `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`,
`me`.`firstname`, `me`.`middle_name`, `me`.`title`, `me`.`othernames`,
`me`.`initials`, `me`.`pronouns`, `me`.`streetnumber`, `me`.`streettype`,
`me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`,
`me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`,
`me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`,
`me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`,
`me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`,
`me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`,
`me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`password_expiration_date`,
`me`.`date_renewed`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`,
`me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`,
`me`.`contacttitle`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`,
`me`.`password`, `me`.`secret`, `me`.`auth_method`, `me`.`flags`,
`me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`,
`me`.`altcontactfirstname`, `me`.`altcontactsurname`,
`me`.`altcontactaddress1`, `me`.`altcontactaddress2`,
`me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`,
`me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`,
`me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_fines`,
`me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`,
`me`.`updated_on`, `me`.`lastseen`, `me`.`lang`, `me`.`login_attempts`,
`me`.`overdrive_auth_token`, `me`.`anonymized`, `me`.`autorenew_checkouts`,
`me`.`primary_contact_method`, `extended_attributes`.`id`,
`extended_attributes`.`borrowernumber`, `extended_attributes`.`code`,
`extended_attributes`.`attribute` FROM (SELECT `me`.`borrowernumber`,
`me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`middle_name`,
`me`.`title`, `me`.`othernames`, `me`.`initials`, `me`.`pronouns`,
`me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`,
`me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`,
`me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`,
`me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`,
`me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`,
`me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`,
`me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`,
`me`.`password_expiration_date`, `me`.`date_renewed`, `me`.`gonenoaddress`,
`me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`, `me`.`contactname`,
`me`.`contactfirstname`, `me`.`contacttitle`, `me`.`borrowernotes`,
`me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`secret`,
`me`.`auth_method`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`,
`me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`,
`me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`,
`me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`,
`me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`,
`me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_fines`,
`me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`,
`me`.`updated_on`, `me`.`lastseen`, `me`.`lang`, `me`.`login_attempts`,
`me`.`overdrive_auth_token`, `me`.`anonymized`, `me`.`autorenew_checkouts`,
`me`.`primary_contact_method` FROM `borrowers` `me` LEFT JOIN
`borrower_attributes` `extended_attributes` ON
`extended_attributes`.`borrowernumber` = `me`.`borrowernumber` WHERE ( ( (
`me`.`borrowernumber` LIKE '%nil%' OR `me`.`email` LIKE '%nil%' OR
`me`.`surname` LIKE '%nil%' OR `me`.`firstname` LIKE '%nil%' OR
`me`.`othernames` LIKE '%nil%' OR `me`.`cardnumber` LIKE '%nil%' OR
`me`.`userid` LIKE '%nil%' OR `me`.`B_address` LIKE '%nil%' OR
`me`.`middle_name` LIKE '%nil%' ) OR ( `me`.`borrowernumber` LIKE '%nil%' OR
`me`.`email` LIKE '%nil%' OR `me`.`surname` LIKE '%nil%' OR `me`.`firstname`
LIKE '%nil%' OR `me`.`othernames` LIKE '%nil%' OR `me`.`cardnumber` LIKE
'%nil%' OR `me`.`userid` LIKE '%nil%' OR `me`.`B_address` LIKE '%nil%' OR
`me`.`middle_name` LIKE '%nil%' ) OR ( `extended_attributes`.`attribute` LIKE
'%nil%' AND ( `extended_attributes`.`code` = 'BUSS' OR
`extended_attributes`.`code` = 'MEROPPET' ) ) ) ) GROUP BY
`me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`, `me`.`firstname`,
`me`.`middle_name`, `me`.`title`, `me`.`othernames`, `me`.`initials`,
`me`.`pronouns`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`,
`me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`,
`me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`,

[Koha-bugs] [Bug 35284] No more delay between 2 DT requests

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35284

Lari Strand  changed:

   What|Removed |Added

 CC||lmstr...@gmail.com

--- Comment #37 from Lari Strand  ---
I resolved the issue (in 22.11 without these patches) by setting a timeout in
koha-tmpl/intranet-tmpl/prog/js/datatables.js that waits after typing has
finished to the column filter field before filtering happens. This way we do
not need to limit the amount of events fired (throttling) and the system feels
responsive at all times, even with heavy filtering going on and lots of typing
to the filter field.

function delay(callback, ms) {
var timer = 0;
return function() {
  var context = this, args = arguments;
  clearTimeout(timer);
  timer = setTimeout(function () {
callback.apply(context, args);
  }, ms || 0);
};
  }

$( input_type, this ).on( 'keyup change', (delay(function
() {
if ( table_dt.column(i).search() !== this.value ) {
if ( input_type == "input" ) {
table_dt
.column(i)
.search( this.value )
.draw();
} else {
table_dt
.column(i)
.search( this.value.length ?
'^'+this.value+'$' : '', true, false )
.draw();
}
}
},500 )));

Something among those lines. 500ms at the bottom is a hardcoded wait time until
the keyup or change event fires for which the value could be fetched from
somewhere else is hard coding is an issue. Could this be a suitable/better
approach still for filtering columns?

I'm also wondering why we haven't updated the version of the Datatables
libraries. Should it be updated? We have 4 years of commits missing. 1.13.8
seemed to work out of the box on my dev install of 22.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11858] RFID for circulation using RFIDHub

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858

--- Comment #13 from Magnus Enger  ---
(In reply to Marcel de Rooy from comment #12)
> (In reply to Viktor Sarge from comment #8)
> Do you have details about the RFID scanner you are using btw?

Viktor is no longer working with Koha, so you might not get an answer from him.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2244] RFID Cataloguing - Programming RFID tags from Koha

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19814] Batch Check-in function

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11858

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11858] RFID for circulation using RFIDHub

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19814

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11858] RFID for circulation using RFIDHub

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #12 from Marcel de Rooy  ---
(In reply to Viktor Sarge from comment #8)
> The RFID scanners just send the barcodes one at a time
> and rely on the fact that the barcode box has focus. The RFID scanner can
> then just pretend to be a keyboard. The problem has been page load times.
> Before with a load time of generally in the 1,5 - 2,5 span with some
> transactions taking perhaps 3,5-4 seconds we had to set the RFID scanners to
> wait up to 5 seconds between every barcode. Now with Plack they have been
> able to set the delay to 1 second. 

Linking bug 19814 (still NEW) to this one. This is about getting batch checkin
just like we alrady have batch checkout for some time.

Do you have details about the RFID scanner you are using btw?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520

--- Comment #13 from Jonathan Druart  ---
Why didn't we fix the problematic DBRev here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520

--- Comment #12 from Jonathan Druart  ---
(In reply to Pablo AB from comment #10)
> I should file a new issue, or this one should be reopened?

Yes, please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520

--- Comment #11 from Jonathan Druart  ---
(In reply to Matt Blenkinsop from comment #9)
> Nice work everyone!
> 
> Pushed to oldstable for 22.11.x

Wrong commit

commit 2ce9f0ce5b6a0c502f3e329ad80ec85322047257

+$VERSION = "22.11.11.001";

 $VERSION = "22.11.11.000";

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #7 from Jonathan Druart  ---
"Log in to your account" is now on the left, is that expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35387] Capitalization: 'name' label in preservation module

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387

--- Comment #7 from Jonathan Druart  ---
Created attachment 159209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159209=edit
Bug 35387: (follow-up) Capitalize 'barcode'

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35387] Capitalization: 'name' label in preservation module

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #159199|0   |1
is obsolete||
 Attachment #159207|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  ---
Created attachment 159208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159208=edit
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35387] Capitalization: 'name' label in preservation module

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19814] Batch Check-in function

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #30 from Marcel de Rooy  ---
We're about six years further and many people would like the feature (we too)
but nothing happened?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35387] Capitalization: 'name' label in preservation module

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 159207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159207=edit
Bug 35387: (follow-up) Capitalize 'barcode'

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477

Emmi Takkinen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477

--- Comment #6 from Emmi Takkinen  ---
Created attachment 159206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159206=edit
Bug 32477: Launch function hideColumns after changing datatables settings

Hiding columns in batch item modification breaks if page is
loaded again. If one hides e.g. column
"Source of classification or shelving scheme" and then loads
the page column "Holds" disappears. Also behaviour of checbox
changes for "Source of classification..." column. This happens
because we launch function "hideColumns" before changing
datatables settings and "hidden" column with class "sorting_1"
is still present.

To test:
1. Find items to modify and modify them with batch item
modification tool.
2. In modification page, hide column "Source of classification or
shelving scheme". Confirm correct column is hidden.
3. Reload the page or modify items again.
=> Note that column "Holds" is now hidden and checking checkbox
for column "Source of classification..." behaves incorrectly (unchecked
checkbox shows column, checked hides it)
4. Apply this patch.
5. Repeat steps 1, 2 and 3.
=> Confirm correct column is now hidden when page is loaded again
and checkbox works correctly.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070

--- Comment #5 from Julian Maurice  ---
Added a test, and forked the kitchen sink plugin so that it's easier to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070

Julian Maurice  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070

--- Comment #4 from Julian Maurice  ---
Created attachment 159205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159205=edit
Bug 35070: Add plugin hook template_include_paths

It allows to add paths to Template::Toolkit's INCLUDE_PATH option

http://template-toolkit.org/docs/manual/Config.html#section_INCLUDE_PATH

Test plan:
1. Install the modified kitchen sink plugin:

git clone --branch template-include-paths \
https://github.com/jajm/dev-koha-plugin-kitchen-sink.git

2. Run misc/devel/install_plugins.pl
3. Restart memcached and koha
4. Go to Administration -> Manage Plugins
5. Run the KitchenSink plugin's tool
6. Click on "Schedule greeting"
7. Go to Administration -> Manage jobs
8. If you don't see any jobs, uncheck "Current jobs only"
9. You should see a job of type "Unknown job type
   'plugin_kitchensink_greeter". Click on the "View" button
10. Under the Report section you should see "This is the report block"
11. Under the Detailed messages section you should see "This is the
detail block"
12. Open the browser console, you should see a message "This is the js
block"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477

Emmi Takkinen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi
   |ity.org |

--- Comment #5 from Emmi Takkinen  ---
We launch function "hideColumns" too early. When page loads, dataTable still
has "hidden" column with class "sorting_1" in it. That's why number of columns
doesn't match to the columns which are actually present in the table and
"hideColumns" hides column before next to the column we actually want to hide.
Moving function after removing that extra column seems to solve the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #77 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #76)
> I found this report after breaking my head about how to add transfers
> without a date sent ;)

Added two reports to lower possible confusion. Bug 35388 and bug 35389.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35389

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22569
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #2 from Marcel de Rooy  ---
Very trivial: self SO

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

--- Comment #1 from Marcel de Rooy  ---
Created attachment 159204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159204=edit
Bug 35389: Hide 'Transfer to send' if StockRotation disabled

Test plan:
Disable StockRotation pref. Check if report is hidden on circ home.
Enable. Check if report is visible.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] New: Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Bug ID: 35389
   Summary: Hide 'Transfers to send' on circulation home page when
stock rotation is disabled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35388] Add comment to circ/transfers_to_send.pl about limited use in stock rotation context

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35388

Marcel de Rooy  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35388

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35388] Add comment to circ/transfers_to_send.pl about limited use in stock rotation context

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35388

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22569

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35388] Add comment to circ/transfers_to_send.pl about limited use in stock rotation context

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35388

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Marcel de Rooy  ---
Comments only: Self SO

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35388] Add comment to circ/transfers_to_send.pl about limited use in stock rotation context

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35388

--- Comment #1 from Marcel de Rooy  ---
Created attachment 159203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159203=edit
Bug 35388: Add comment to 'Transfers to send'

Test plan:
Read the patch.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35388] Add comment to circ/transfers_to_send.pl about limited use in stock rotation context

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35388

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35388] New: Add comment to circ/transfers_to_send.pl about limited use in stock rotation context

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35388

Bug ID: 35388
   Summary: Add comment to circ/transfers_to_send.pl about limited
use in stock rotation context
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #76 from Marcel de Rooy  ---
I found this report after breaking my head about how to add transfers without a
date sent ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477

--- Comment #4 from Emmi Takkinen  ---
(In reply to Emmi Takkinen from comment #3)
> Apparently this happens because columns still have attribute
> "checked=checked" even if class "selected" is removed. Then we do this:
> 
> if ($(this).prop("checked")) {
> showColumn(num);
>  } else {
> hideColumn(num);
> }
> 
> So solution could simply be that we need to set checked attributed as false,
> not just remove class "selected".

Hmm, I should have mentioned here that this is just part of problem. Another
one  is that function "hideColumns" hides wrong columns when tool is launched
again. Which is weird, code looks OK to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/