[Koha-bugs] [Bug 35416] Advanced editor interface hang when trying to edit an existing catalogue record

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35416

Iming Chan  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35416] Advanced editor interface hang when trying to edit an existing catalogue record

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35416

--- Comment #1 from Iming Chan  ---
Created attachment 159316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159316=edit
Page error messages via F12

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35421] Is "A guarantor cannot be a guarantee." still correct?

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi

--- Comment #1 from Emmi Takkinen  ---
This error is triggered when patron added as guarantor is a child OR has
categorycode which has setting "can_be_guarantee" on. So it's still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34962] Add a system messages feature to Koha to report issues and failures in a more visible way

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34962

--- Comment #2 from David Cook  ---
If/when we have a Content-Security-Policy, this could be useful for CSP
violation reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26611] Required match checks don't work for authority records

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611

ryszard@gmail.com changed:

   What|Removed |Added

 CC||ryszard@gmail.com

--- Comment #11 from ryszard@gmail.com ---
Hello.
Solution to the problem in version 22.11 (it worked for me)

/C4/Matcher.pm

line ~~33

 remove_spaces
 upper_case
 );
+use C4::AuthoritiesMarc qw( GetAuthority );

 =head1 NAME

Line ~~703

foreach my $result (@$authresults) {
 my $id = $result->{authid};
- my $target_record = Koha::Authorities->find( $id )->record;
+ my $target_record = GetAuthority($id);
 $matches->{$id}->{score} += $matchpoint->{'score'};
 $matches->{$id}->{record} = $target_record;
}

my first comment, sorry for the syntax

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27919] Split claims return from LOST

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

--- Comment #7 from Lisette Scheer  ---
If an item is marked long overdue lost, then is claimed returned, then is
returned, the lost fine won't be refunded, even if the circulation rules say it
should be.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34962] Add a system messages feature to Koha to report issues and failures in a more visible way

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34962

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35421] Is "A guarantor cannot be a guarantee." still correct?

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28965] Add public routes for lists

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

--- Comment #8 from David Cook  ---
Seems like there's a few of us keen on this one. Let's get this one in? 

I'm hoping to tackle bug 18148 before the end of the year, but it relies on
having a public list endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410

--- Comment #3 from David Cook  ---
(In reply to Katrin Fischer from comment #2)
> For me 'online resources' is the broader term which I think would be a
> better fit since currently we show all links together, not differentiating
> between full text and other links (covers, TOCs, reviews, etc.).

Sounds good to me!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35427] New: Cancelling item-level hold from requestspecific_info on request.pl breaks link to biblio record

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35427

Bug ID: 35427
   Summary: Cancelling item-level hold from requestspecific_info
on request.pl breaks link to biblio record
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To recreate:
Have a bibliographic record with at least one item-level hold.
Go to place one more hold (item-level or record-level, doesn't matter), but
before placing the hold, cancel one of the item-level holds from the
information tab in the requestspecific_info holdings table.
When you confirm the cancellation, the next screen is a return to request.pl,
but with no valid biblionumber, and the heading Place a hold on No
bibliographic record.
Backtrack to the initial record, and note that the cancellation did not
actually complete.

Observed in both 22.11 and 22.05, so likely an older issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24319] When RenewSerialAddsSuggestion is used, use existing record when ordering from suggestion

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24319

--- Comment #1 from Caroline Cyr La Rose  ---
I just tried this in 23.05 and it seems to use the same record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694

--- Comment #36 from Victor Grousset/tuxayo  ---
(In reply to Jan Kissig from comment #35)
> @Victor, yes I meant to signoff these 4 patches, just getting familiar with
> git bz and hope that it worked now as expected

All looks good :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35115] ERM - Potential MARC data loss when importing titles from list

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115

--- Comment #22 from Victor Grousset/tuxayo  ---
(In reply to Pedro Amorim from comment #21)
> (In reply to Victor Grousset/tuxayo from comment #17)
> > > 27 - Edit the eholdings title for one of the records, changing the title 
> > > field
> > > 28 - Save and view record details
> > > 29 - Confirm record is intact and title updated
> > 
> > Just to be sure, title update should only be from eholding to record, right?
> > And not from record to eholding.
> 
> Correct, yes.

Great, no issues then.


> I'm converting my SO to PQA here.

Perfect, that was the plan :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ...

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Owen Leonard  ---
How about:

Some patrons have requested privacy after their items are checked in, but the
AnonymousPatron preference is not set correctly. Set it to a valid borrower
number or checkins for these patrons will fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425

--- Comment #1 from Slava Shishkin  ---
Created attachment 159313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159313=edit
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record. 
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea 
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click 
   on the "::" icon in front of the dragged item. And text selection 
   works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425

Slava Shishkin  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35426] Improve layout of bookings modal form

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426

--- Comment #1 from Owen Leonard  ---
Created attachment 159312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159312=edit
Bug 35426: Improve layout of bookings modal form

This patch changes the class on the bookings modal form's fieldset in
order to make the form work better in the small space offered by the
modal.

Also changed: The hint for the patron search field has been moved below
the field for consistency.

To test, apply the patch and search for a title in the staff interface.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
"Yes."
- Click the "PLace booking" button in the toolbar.
  - The bookings modal form should appear, and the form layout should be
improved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35426] Improve layout of bookings modal form

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25835] Include Overdue Report (under Circulation Module) as a Staff Permission

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25835

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
I'm ruling this a bug rather than an enhancement. Either the existing
permission should be renamed to reflect its limited scope, or its scope should
be expanded to include the Overdues With Fines report.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35426


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426
[Bug 35426] Improve layout of bookings modal form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35426] New: Improve layout of bookings modal form

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426

Bug ID: 35426
   Summary: Improve layout of bookings modal form
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 29002

The bookings modal form, triggered on the staff interface page when you click
the "Place bookings" button, has an awkward layout because the fieldset with
"rows" class doesn't work well there. Changing the class to "brief" makes it
work better.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002
[Bug 29002] Add ability to book items ahead of time
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35419


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419
[Bug 35419] Update page title for bookings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

Owen Leonard  changed:

   What|Removed |Added

 Depends on||29002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002
[Bug 29002] Add ability to book items ahead of time
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35425] New: Sortable prevents mouse selection of text inside child input/textarea elements

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425

Bug ID: 35425
   Summary: Sortable prevents mouse selection of text inside child
input/textarea elements
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: slavashish...@gmail.com
  Reporter: slavashish...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Depends on: 35383

To reproduce:
1. Open any biblio and edit that record. 
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea fields
with a mouse is not possible - it starts dragging instantly.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383
[Bug 35383] Dragging and dropping subfield of repeated tags doesn't work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383

Slava Shishkin  changed:

   What|Removed |Added

 Blocks||35425


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425
[Bug 35425] Sortable prevents mouse selection of text inside child
input/textarea elements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

--- Comment #2 from Owen Leonard  ---
Created attachment 159310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159310=edit
Bug 35419: Update page title for bookings

This patch updates the structure of the Bookings list page so that the
title can be better translated.

To test, apply the patch and locate a bibliographic record in the
staff interface catalog.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
"Yes."
- Click the "Bookings" menu item in the left-hand sidebar.
- Check that the page title looks correct and consistent with
  breadcrumbs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708

Amaury GAU  changed:

   What|Removed |Added

  Documentation||amaury@bulac.fr
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/756

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

Owen Leonard  changed:

   What|Removed |Added

Summary|Update breadcrumbs and page |Update page title for
   |titles for bookings |bookings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383

--- Comment #5 from Slava Shishkin  ---
(In reply to Marcel de Rooy from comment #4)

thanks, that makes a sense,

I can wrap up it in "if",

if (typeof Sortable !== 'undefined') {
$(clone).find("ul.sortable_subfield").each((i, e) => {
Sortable.create(e, {
animation: 150,
});
});
}

but the best then is to make a callback option for CloneSubfield and leave
Sortable.create code in files where it resides,

but that also leads to refactoring of onclick="CloneSubfield... to modern way
how we doing that in our codebase by moving that listener to JS document ready
block

Marcel, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35408] ERM > Titles > Import from a list gives an invalid link to the import job

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408

Matt Blenkinsop  changed:

   What|Removed |Added

 Attachment #159284|0   |1
is obsolete||

--- Comment #2 from Matt Blenkinsop  ---
Created attachment 159309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159309=edit
Bug 35408: Fix import job link

After importing titles from a list there is a link to the background job
that is displayed.
This link points to /cgi-bin/koha/admin/background_jobs/:id
There is a route to this path in routes/erm.js, to redirect to the
correct URI /cgi-bin/koha/admin/background_jobs.pl?op=view=:id
However this link will not work if we are accessing it from outside the
ERM app/module, or if we are opening it in a new tab/window.

The idea was interesting, but does not work...

Test plan:
Create a new ERM local package, a new list (virtual shelf), add some
items to the list.
Go to E-resource management > eHoldings > Local > Titles > Import from a list
Click "import"
Notice the "see job" link and click it

=> Confirm that with this patch applied you can open it in a new tab
without getting a 404

Signed-off-by: Matt Blenkinsop 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

--- Comment #19 from Kyle M Hall  ---
Created attachment 159308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159308=edit
Bug 18139: Add/update unit tests

Signed-off-by: Eric Gosselin 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35408] ERM > Titles > Import from a list gives an invalid link to the import job

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #61542|0   |1
is obsolete||
  Attachment #61663|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 159307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159307=edit
Bug 18139: Display the rule critera used to determin the checkout limits to the
template

The too many checked out message can be very confusing for librarians
when the limit specified is more or less than the number of checkouts
the patron already has. We should make it clear to the librarian that
his is only counting certain types of checkouts by giving them the
issuing rule criteria used.

Test Plan:
1) Apply this patch
2) Try to check out more items than the circ rules allow for
   regular and on-site checkouts

Signed-off-by: Eric Gosselin 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35421] Is "A guarantor cannot be a guarantee." still correct?

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421

Owen Leonard  changed:

   What|Removed |Added

  Component|Templates   |Patrons
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
 CC||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

--- Comment #9 from Matt Blenkinsop  ---
Created attachment 159306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159306=edit
Bug 35026: Add unit tests

This commit adds a set of unit tests for the new methods in Koha::MarcOrder

The two controller functions at the start of the file have not been included as
they simply call the functions in these tests

The _stage_file method is also not included as this is a copy of the existing
file staging code with the background job functionality removed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

--- Comment #8 from Matt Blenkinsop  ---
Created attachment 159305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159305=edit
Bug 35026: Make add_items_from_import_record DRY

This patch improves the code in add_items_from_import_record to make sure that
the code is not repeating itself

It also fixes a minor error in the template file and rebases in changes from
bugs 35254 and 33170

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

Matt Blenkinsop  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34962] Add a system messages feature to Koha to report issues and failures in a more visible way

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34962

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24319] When RenewSerialAddsSuggestion is used, use existing record when ordering from suggestion

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24319

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35422] Unexpected translation string for Suggestions template

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422

--- Comment #1 from Owen Leonard  ---
Created attachment 159304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159304=edit
Bug 35422: Fix translation of suggestions title tag

This patch corrects a missed instance of a string in the title tag which
should have been wrapped in the translation function [% t() %]

To test, apply the patch and go to Suggestions.

- Click "New purchase suggestion"
- The title of the page should be correct: "Add suggestion"
- Confirm that translation is improved:
  - Update and reinstall active translations (for instance fr-FR):
perl misc/translator/translate update fr-FR
  - Check the corresponding po file, in this case fr-FR-messages.po
  - There should be an entry for the string "Add suggestion"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35422] Unexpected translation string for Suggestions template

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24318] When RenewSerialAddsSuggestion is used, treat suggestion as "order from subscription"

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24318

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27340] We should introduce Koha::PickupLocation(s)

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27340

Lisette Scheer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35424

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35424] Add ability to select desk for pickup at time of hold creation

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35424

Lisette Scheer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27340

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35424] New: Add ability to select desk for pickup at time of hold creation

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35424

Bug ID: 35424
   Summary: Add ability to select desk for pickup at time of hold
creation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Libraries that have multiple pickup locations (drive up window, locker, public
self serve, behind desk for specialty items, etc) currently have to create
branches for each pickup location if they want patrons to be able to select
where the hold will be picked up. 

It would be great if instead, desks could be selected. 

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35422] Unexpected translation string for Suggestions template

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35422] Unexpected translation string for Suggestions template

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422

Katrin Fischer  changed:

   What|Removed |Added

Summary|Unexpected tranlsation  |Unexpected translation
   |string for Suggestions  |string for Suggestions
   |template|template
 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35422] Unexpected tranlsation string for Suggestions template

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35413] Terminology: Manage issues (issue_manage)

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413

--- Comment #1 from Owen Leonard  ---
Created attachment 159303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159303=edit
Bug 35413: Terminology: Manage issues (issue_manage)

This patch updates several files which use the term "issues" without
context, changing them to "Vendor issues." Unchanged is the vendor
issues page template, vendor_issues.tt, which is updated in Bug 35417.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- You should see a "Vendor issues" link in the sidebar.
- Go to Patrons and search for a patron. View the patron's details.
- Click More -> Set permissions.
- Under Acquisitions management you should see "Manage vendor issues
  (issue_manage)"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35413] Terminology: Manage issues (issue_manage)

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417

--- Comment #1 from Owen Leonard  ---
Created attachment 159302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159302=edit
Bug 35417: Update breadcrumbs and page titles for vendor issues

This patch updates the vendor issues template so that title and
breadcrumbs follow the same pattern on other updated templates:
Translatable strings in the title and breadcrumbs using the template
WRAPPER.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- Click the "Isssues" link in the sidebar.
- Check that the page title and breadcrumbs are correct in each
  variation of the page:
  - The main page
  - New vendor issue
  - Modify vendor issue
  - Issue deletion confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35423] New: AuthoritiesMarc: Warnings substr outside of string and Use of uninitialized value $type in string eq

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423

Bug ID: 35423
   Summary: AuthoritiesMarc: Warnings substr outside of string and
Use of uninitialized value $type in string eq
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

In full:

substr outside of string at /usr/share/koha/C4/AuthoritiesMarc.pm line 1041.
Use of uninitialized value $type in string eq at
/usr/share/koha/C4/AuthoritiesMarc.pm line 1044.

May be found in your logs (depending on data) when calling SearchAuthorities.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35422] New: Unexpected tranlsation string for Suggestions template

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422

Bug ID: 35422
   Summary: Unexpected tranlsation string for Suggestions template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

This string didn't get broken up as expected:

koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:11 

%s %s %s %s  %s Add suggestion  %s %s %s  %s %s
 %s  %s %s

Maybe we need to wrap the "Add suggestion" as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #38 from Lucas Gass  ---
Cleave.js has been revived/reborn as cleave-zen:

https://github.com/nosir/cleave-zen
https://github.com/nosir/cleave.js/issues/723

In my opinion this is the best, and smartest, masking library available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35053] Item-level rules not checked if both item_id and biblio_id are passed

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35053

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #10 from Emily Lamancusa  
---
*** Bug 33477 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33477] POST /holds/ allows invalid item-level hold if biblio_id and item_id are both specified

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33477

Emily Lamancusa  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Emily Lamancusa  ---


*** This bug has been marked as a duplicate of bug 35053 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35421] New: Is "A guarantor cannot be a guarantee." still correct?

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421

Bug ID: 35421
   Summary: Is "A guarantor cannot be a guarantee." still correct?
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

With the ability to have adults guarantee for adults, I believe the above might
no longer be true.

Found while translating in
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:190

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417

Owen Leonard  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35417] Update breadcrumbs and page titles for vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35420] New: Update page titles and breadcrumbs for Serial alert subscriptions in the OPAC patron account

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35420

Bug ID: 35420
   Summary: Update page titles and breadcrumbs for Serial alert
subscriptions in the OPAC patron account
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Alert subscriptions for %s  Patrons  Koha

I am also not sure if Alert subscriptions is the best description. At the
moment the only alerts you can subscribe to are email alerts for new serial
issues.

Maybe: New serials alerts? Serial issue alerts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

--- Comment #14 from Pedro Amorim  ---
Thanks Joubu, we fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit
   |.com|y.org

--- Comment #157 from Martin Renvoize  ---
Nice clean rebase, all workings as described here now.

Signing off and passing back for a final QA round.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159294|0   |1
is obsolete||

--- Comment #156 from Martin Renvoize  ---
Created attachment 159301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159301=edit
Bug 23260: Add cronjob anonymize_last_borrowers.pl

This patch adds the feature to anonymize patrons from items_last_borrower
table. This code is run from batch_anonymize script, which is triggered from a
new cron job anonymize_last_borrowers.pl

To test:
 1) apply this patch and the previous ones
 2) perl installer/data/mysql/updatedatabase.pl
 3) set StoreLastBorrower preference to Allow.
 4) set AnonymousPatron preference to a valid patron id
 5) Create a Check out followed by a Check in.
CHECK => a row should appear in items_last_borrower table with the borrower
and the item number.
 6) In mysql, update created_on of items_last_borrower and returndate of
old_issues to two days earlier.
 7) perl misc/cronjobs/anonymize_last_borrowers.pl
CHECK => borrower number in items_last_borrower is not anonymized yet.
 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in
items_last_borrower to three days earlier.
 9) set AnonymizeLastBorrower to 'Anonymize' and AnonymizeLastBorrowerDays to 2
days.
10) perl misc/cronjobs/anonymize_last_borrowers.pl
SUCCESS => borrower number in items_last_borrower changed to
AnonymousPatron id
11) repeat step 8
12) set AnonymousPatron preference to 0
13) perl misc/cronjobs/anonymize_last_borrowers.pl
SUCCESS => borrower number in items_last_borrower changed to null
14) prove t/db_dependent/Koha/Patrons.t

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159293|0   |1
is obsolete||

--- Comment #155 from Martin Renvoize  ---
Created attachment 159300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159300=edit
Bug 23260: Unit tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159292|0   |1
is obsolete||

--- Comment #154 from Martin Renvoize  ---
Created attachment 159299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159299=edit
Bug 23260: Add anonymize_last_borrowers method to Patrons.pm

This patch adds a new routine to allow anonymizing the items_last_borrower
table

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159291|0   |1
is obsolete||

--- Comment #153 from Martin Renvoize  ---
Created attachment 159298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159298=edit
Bug 23260: Database updates and new system preferences AnonymizeLastBorrower /
AnonymizeLastBorrowerDays

This patch alters the items_last_borrowers table to allow for NULL borrowers

It also adds two new system preferences to allow controlling the anonymization
of items_last_borrower data

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update breadcrumbs and page titles for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

--- Comment #1 from Katrin Fischer  ---
I can see some suspicious strings in translations that indicate, that we should
also update those to the new structure:

Bookings for %s  Bookings  Circulation  Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] New: Update breadcrumbs and page titles for bookings

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

Bug ID: 35419
   Summary: Update breadcrumbs and page titles for bookings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412

--- Comment #1 from Owen Leonard  ---
Created attachment 159297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159297=edit
Bug 35412: Fix incorrect capitalization: Toggle Dropdown

This patch corrects incorrect capitalization in the last-borrower
include file. The string his hidden except to screen readers, so visual
confirmation isn't straightforward. Viewing the diff should be enough to
confirm this single character change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35397] SIP2AddOpacMessagesToScreenMessage syspref description issue

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35397

Owen Leonard  changed:

   What|Removed |Added

 Attachment #159241|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 159296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159296=edit
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description

The original syspref description contained an extra  '- Use' and reads
weird.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35397] SIP2AddOpacMessagesToScreenMessage syspref description issue

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35397

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #159276|0   |1
is obsolete||

--- Comment #14 from PTFS Europe Sandboxes  ---
Created attachment 159295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159295=edit
Bug 34479: Add new files to templates

This patch adds two newly created files to the templates to allow the patron
selection history to be wiped or persisted as appropriate

Test plan as per previous commit

Signed-off-by: Sharon Dugdale 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21246] Extend the 'Last patron' navigation feature to 'Last X patrons'

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||**Sponsored by** *ByWater
  release notes||Solutions*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|In Discussion   |RESOLVED
 CC||n...@bywatersolutions.com

--- Comment #2 from Nick Clemens  ---
That module was removed from the patches - closing this

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #152 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #147)
> Oi, so many rebases. Sorry we didn't get to this earlier.
> 
> 1) Can you explain this part of the code please?
> 
> +my $last_borrowers_to_anonymise =
> $patron->_result->items_last_borrowers->search(
> +{
> +(
> +$older_than_date
> +? ( created_on => { '<' =>
> $dtf->format_datetime($older_than_date) } )
> +: (),
> +"itemnumber.damaged"   => 0,
> +"itemnumber.itemlost"  => 0,
> +"itemnumber.withdrawn" => 0,
> +),
> +},
> +{ join => ['itemnumber'] }
> +);

This fetches the items_last_borrower rows to anonymise, joining to the items
table to avoid removing info from items that are no longer in circulation where
the last borrower is likely to be responsible for that status

> 2) Database updated needs to be reformatted to use the newer template.

OK

> 3) Terminology / System preference naming
> 
> Sorry to be nit-picky about this, but I believe we should stick to the
> standard terminology as per our coding guidelines:
> 
> * Use AE instead of BE: Anonymise should be Anonymize
> * Borrower should be Patron
> 
> AnonymiseLastBorrower => AnonymizeLastPatron
> AnonymiseLastBorrowerDays => AnonymizeLastPatronDelay/Days
> 
> System preference descriptions need to be adapted as well.

changed 'ise' to 'ize'
As the table is 'items_last_borrower' and we are referring to 'the patron that
last borrowed' I think borrower actually makes more sense in this case

> 4) Cronjob
> 
> +use strict;
> +use warnings;
> 
> --> should be Use Modern::Perl.

OK


> 5) anonymise_issue_history appears to be unused?

It looks like this has been through multiple coders and revisions - all
squashed - unused routine removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35221] TrackLastPatronActivityTriggers description is misleading

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31014] Minor UI problems in QOTD editor tool

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31014

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #151 from Nick Clemens  ---
Created attachment 159294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159294=edit
Bug 23260: Add cronjob anonymize_last_borrowers.pl

This patch adds the feature to anonymize patrons from items_last_borrower
table. This code is run from batch_anonymize script, which is triggered from a
new cron job anonymize_last_borrowers.pl

To test:
 1) apply this patch and the previous ones
 2) perl installer/data/mysql/updatedatabase.pl
 3) set StoreLastBorrower preference to Allow.
 4) set AnonymousPatron preference to a valid patron id
 5) Create a Check out followed by a Check in.
CHECK => a row should appear in items_last_borrower table with the borrower
and the item number.
 6) In mysql, update created_on of items_last_borrower and returndate of
old_issues to two days earlier.
 7) perl misc/cronjobs/anonymize_last_borrowers.pl
CHECK => borrower number in items_last_borrower is not anonymized yet.
 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in
items_last_borrower to three days earlier.
 9) set AnonymizeLastBorrower to 'Anonymize' and AnonymizeLastBorrowerDays to 2
days.
10) perl misc/cronjobs/anonymize_last_borrowers.pl
SUCCESS => borrower number in items_last_borrower changed to
AnonymousPatron id
11) repeat step 8
12) set AnonymousPatron preference to 0
13) perl misc/cronjobs/anonymize_last_borrowers.pl
SUCCESS => borrower number in items_last_borrower changed to null
14) prove t/db_dependent/Koha/Patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #150 from Nick Clemens  ---
Created attachment 159293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159293=edit
Bug 23260: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #149 from Nick Clemens  ---
Created attachment 159292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159292=edit
Bug 23260: Add anonymize_last_borrowers method to Patrons.pm

This patch adds a new routine to allow anonymizing the items_last_borrower
table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Nick Clemens  changed:

   What|Removed |Added

 Attachment #157106|0   |1
is obsolete||
 Attachment #157107|0   |1
is obsolete||
 Attachment #157108|0   |1
is obsolete||
 Attachment #157109|0   |1
is obsolete||
 Attachment #157110|0   |1
is obsolete||
 Attachment #157111|0   |1
is obsolete||
 Attachment #157112|0   |1
is obsolete||
 Attachment #157113|0   |1
is obsolete||
 Attachment #157114|0   |1
is obsolete||
 Attachment #157115|0   |1
is obsolete||
 Attachment #157116|0   |1
is obsolete||

--- Comment #148 from Nick Clemens  ---
Created attachment 159291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159291=edit
Bug 23260: Database updates and new system preferences AnonymizeLastBorrower /
AnonymizeLastBorrowerDays

This patch alters the items_last_borrowers table to allow for NULL borrowers

It also adds two new system preferences to allow controlling the anonymization
of items_last_borrower data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34716] Typo in tools/stockrotation.tt

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34716

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

--- Comment #13 from Matt Blenkinsop  ---
I think you can do it via the sandbox using the actions dropdown - that will
sign off all the patches and change the bug for you, just click "Sign off
patches" from the dropdown

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

--- Comment #12 from Matt Blenkinsop  ---
Great, thanks Sharon! If you change the bug status to "Signed off" it will move
into the QA queue and you'll get your name in the release notes for the version
that this patch is released in :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34942] Typo: brower

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Text to go in the|This fixes a typo in a  |
  release notes|message used in the |
   |advanced cataloguing editor |
   |when macros are converted   |
   |from being stored in the|
   |browser to being stored in  |
   |the database - 'brower' to  |
   |'browser'.  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34820] Improve inventory tool message for items with non-matching notforloan values

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34820

Martin Renvoize  changed:

   What|Removed |Added

   Severity|minor   |enhancement
Summary|Clarify inventory tool  |Improve inventory tool
   |message for items with  |message for items with
   |non-matching notforloan |non-matching notforloan
   |value   |values
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32984] The EDIFACT message that receives an item should be linked on the 'Acquisition details' tab on catalogue details page

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32984

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|**Sponsored by** *PTFS  |**Sponsored by** *PTFS
  release notes|Europe* |Europe Ltd*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34587] Add a Usage Statistics module to ERM

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This feature adds the
  release notes||ability to create Data
   ||Providers and harvest usage
   ||data in COUNTER format.
   ||Data Providers (or Data
   ||Platforms) are the
   ||organisations who provide
   ||usage statistics for your
   ||electronic resources. This
   ||could be a vendor or a
   ||platform provider. The data
   ||provider record contains
   ||information about SUSHI
   ||credentials and any COUNTER
   ||data which has been
   ||harvested from the
   ||provider. There is also the
   ||ability to create custom
   ||reports using this COUNTER
   ||data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|For vendors who, in |For vendors who, in
  release notes|particular, provide |particular, provide
   |electronic services (e.g.   |electronic services (e.g.
   |eJournal providers) it is   |eJournal providers) it is
   |useful to be able to record |useful to be able to record
   |service issues.
|service issues.
   |
   |
   |This new|This new
   |feature allows for  |feature allows for
   |recording such details, for |recording such details, for
   |example logging login   |example logging login
   |problems, service   |problems, service
   |interruptions and incorrect |interruptions and incorrect
   |availability.
  |availability.
   |
   |
   |This is |This is
   |important as evidence when  |important as evidence when
   |submitting contract |submitting contract
   |negotiations and judging|negotiations and judging
   |vendor performance against  |vendor performance against
   |existing contracts. |existing contracts.
   ||
   ||**Sponsored by** *Bywater
   ||Solutions* and *PTFS Europe
   ||Ltd*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35418] SUSHI harvest hangs

2023-11-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35418

Pedro Amorim  changed:

   What|Removed |Added

   Keywords||Sandbox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >