[Koha-bugs] [Bug 35647] Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35647] Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647 David Nind changed: What|Removed |Added Attachment #160279|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 160280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160280=edit Bug 35647: Use callback when waiting for Coce to load 1. Turn on all CoceProviders and IntranetCoce. 2. Set CoceHost to 'https://coce.bywatersolutions.com' 3. Do a search and notice that no Coce images load on the results page. 4. Apply patch, clear browser cache and try again. 5. Images should load. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35647] Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35552] Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35552
Igor Baptista da Costa changed:
What|Removed |Added
CC||igor.bapti...@neki-it.com.b
||r
--- Comment #4 from Igor Baptista da Costa ---
Hello Victor,
I was facing the same error when updating koha from version 20.11 to 23.11 and
was able to solve it.
The error:
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change
column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1'
at /usr/share/koha/lib/C4/Installer.pm line 741
happens because the file of database patch that fix the "Bug 28966 - Holds
queue view too slow to load for large numbers of holds", of the koha version
23.06.00.013, tries to run an alter statment that change the column
"itemnumber" to primary key, but this column already is a foreign key, so this
alter statment fails.
(the file that im talking about:
https://github.com/Koha-Community/Koha/blob/23.11.x/installer/data/mysql/db_revs/230600013.pl
in your server if the koha was installed from the package manager using
koha-common the path for this file is:
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/230600013.pl)
So, I changed this file to before run the alter statment that turns the column
"itemnumber" into primary key, I added some code to drop the foreign key
"tmp_holdsqueue_ibfk_1" (that refers to the "itemnumber" column) and it index,
and after that run the alter statment, and after the alter statment it
recreates the foreign key. This is what the code looks like:
use Modern::Perl;
return {
bug_number => "28966",
description => "Holds queue view too slow to load for large numbers of
holds",
up => sub {
my ($args) = @_;
my ( $dbh, $out ) = @$args{qw(dbh out)};
unless ( primary_key_exists( 'tmp_holdsqueue', 'itemnumber' ) ) {
if (foreign_key_exists('tmp_holdsqueue', 'tmp_holdsqueue_ibfk_1'))
{
$dbh->do(
q{ALTER TABLE tmp_holdsqueue DROP FOREIGN KEY
tmp_holdsqueue_ibfk_1}
);
$dbh->do(
q{ALTER TABLE tmp_holdsqueue DROP INDEX
tmp_holdsqueue_ibfk_1}
);
}
$dbh->do(
q{ALTER TABLE tmp_holdsqueue ADD PRIMARY KEY (itemnumber)}
);
$dbh->do(
q{ALTER TABLE tmp_holdsqueue ADD KEY `tmp_holdsqueue_ibfk_1`
(`itemnumber`), ADD CONSTRAINT `tmp_holdsqueue_ibfk_1` FOREIGN KEY
(`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE
CASCADE}
);
}
say $out "Set primary key for table 'tmp_holdsqueue' to 'itemnumber'";
},
};
Regards,
Igor Baptista from Neki-it.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kris changed: What|Removed |Added CC||kbec...@jcls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35647] Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647 --- Comment #2 from Lucas Gass --- Created attachment 160279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160279=edit Bug 35647: Use callback when waiting for Coce to load 1. Turn on all CoceProviders and IntranetCoce. 2. Set CoceHost to 'https://coce.bywatersolutions.com' 3. Do a search and notice that no Coce images load on the results page. 4. Apply patch, clear browser cache and try again. 5. Images should load. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35647] Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35647] Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647 --- Comment #1 from Lucas Gass --- There is a wait_for_images() callback used elsewhere, it seems like we need it here too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35647] New: Coce images won't load on the staff results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35647
Bug ID: 35647
Summary: Coce images won't load on the staff results page
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
To recreate:
1. Turn on all CoceProviders and IntranetCoce.
2. Set CoceHost to 'https://coce.bywatersolutions.com'
3. Do a search and notice that no Coce images load on the results page.
4. In intranet-tmpl/js/coce.js add a debug line inside the
`$("[id^=coce-thumbnail]").each(function() {` loop.
5. Nothing happens! This div is being prematurely removed via
intranet-tmpl/prog/js/pages/results.js
I don't think it is safe to remove the Coce div's without first knowing that
KOHA.coce is finished. In results.js:
102 $(window).load(function() {
103 verify_cover_images();
104 });
Just using a window load is not good enough. We either need to not remove the
div ( hiding it is safer ) or we need to use a callback, promise, or
async/await.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Dani Elder changed: What|Removed |Added CC||danielle.elder@law.utexas.e ||du -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #44 from Nick Clemens --- Hi all, I didn't see this and ended up working on 35646 - I think it meets the same basic need, but with a slightly different implementation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | --- Comment #3 from Nick Clemens --- Note: this patch doesn't affect the command line indexing script which allows you to pass a commit size defining how many records to send -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #2 from Nick Clemens --- Created attachment 160278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160278=edit Bug 35086: Add chunk_size option to elasticsearch configuration Whne performing batch operations we can send a large numebr of records for reindexing at once. Currently this can create requetss that are too large for Elasticsearch to process. We need to break these requests into chunks/ This patch adds a chunk_size configuration to the elasticsearch stanza in koha-conf.xml If blank we default to 5000. To test: 0 - Have Koha using Elasticsearch 1 - Create and download a report of all barcodes: SELECT barcode FROM items 2 - Batch modify these items 3 - Note a single ESindexing job is created 4 - Create and download a report of all authority ids: SELECT auth_header.authid FROM auth_header 5 - Setup a marc modification template, and batch modify all the authorities 6 - Again note a single ES backgorund job is created 7 - Apply patch 8 - Repeat the modifications above - you still get a single job 9 - Edit koha-conf.xml and add 250 to elasticsearch stanza 10 - Repeat modifications - you now get several background ES jobs 11 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #15 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #8) > > * We absolutely need documentation for this: Needs to be added to print, > uses a 'data' object with the db columns etc. For the manual, I only reproduced the example that was here as I don't know a lot of TT except the very basic basics. We should definitely have a wiki page about this... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Bug 34456 depends on bug 34136, which changed state. Bug 34136 Summary: Add ability to render a report using a notice template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/803 CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED Documentation||Caroline Cyr La Rose contact|| Resolution|--- |FIXED --- Comment #14 from Caroline Cyr La Rose --- This is a very interesting feature! Thank you all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 Nick Clemens changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 --- Comment #3 from Nick Clemens --- Created attachment 160277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160277=edit Bug 35646: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646
Nick Clemens changed:
What|Removed |Added
Attachment #160275|0 |1
is obsolete||
--- Comment #2 from Nick Clemens ---
Created attachment 160276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160276=edit
Bug 35646: Allow use of publication date fields in serial numbering pattern
This patch extends the numbering pattern field to accept subsitituations for:
{Year} {Day} {DayName} {Month} {MonthName}
These fields are based on the publication date for the serial issue.
To test:
0 - Apply patch
1 - Setup a enw numbering pattern
Serials->Manage numbering patterns + New numbering pattern
2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Day}
{MonthName} {DayName}
3 - Populate X/Y/Z in the table as you wish, these should be unaffected by
patch
4 - Set a Frequency / First issue plublication date / Subscription length
5 - Click 'Test pattern'
6 - Confirm the dates in the Number match the publication date values
7 - Try with different frequencies to confirm they match
8 - Save the pattern
9 - Create a new subscription and use the new pattern
10 - Confirm it works as expected
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Laura O'Neil changed: What|Removed |Added CC||la...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #4 from Esther Melander --- Tested this and the search does return results. I added 7 patrons to a routing list for one serial. When I search the serials, I didn't fill out any fields but checked the routing list box. The search results are unexpected. My serial was listed 7 times. I would have expected only one search result because only one serial had a routing list Is this search supposed to return serial titles with a routing list? If this is the case, there should have only been one search result. Or is the search intended to list patrons on a routing list and the associated title? If this is the case, the patron name should have be included in the table of search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35646 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22188 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646
--- Comment #1 from Nick Clemens ---
Created attachment 160275
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160275=edit
Bgg 35646: Allow use of publication date fields in serial numbering pattern
This patch extends the numbering pattern field to accept subsitituations for:
{Year} {Day} {DayName} {Month} {MonthName}
These fields are based on the publication date for the serial issue.
To test:
0 - Apply patch
1 - Setup a enw numbering pattern
Serials->Manage numbering patterns + New numbering pattern
2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Day}
{MonthName} {DayName}
3 - Populate X/Y/Z in the table as you wish, these should be unaffected by
patch
4 - Set a Frequency / First issue plublication date / Subscription length
5 - Click 'Test pattern'
6 - Confirm the dates in the Number match the publication date values
7 - Try with different frequencies to confirm they match
8 - Save the pattern
9 - Create a new subscription and use the new pattern
10 - Confirm it works as expected
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35646] New: Allow using the publication date parts for serial numbering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 Bug ID: 35646 Summary: Allow using the publication date parts for serial numbering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Sometimes libraries want date fields based on publication date included in the numbering, say for a weekly serial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35575] Acquisition framework fails to display required next 942 $c when defined as mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35575 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org --- Comment #4 from Angela Berrett --- We would like to see the ability to configure this hardcoded form as well. Mainly, the ability to apply the item templates to this form so it can autofill certain fields when the item is created from here. This may be a completely different issue, but we have talked about other changes we would appreciate the ability to make. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32489] Add check out date, number of renewals, numbers of overdue days in list of overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32489 Laura Escamilla changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Esther Melander changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #12 from Esther Melander --- Created attachment 160274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160274=edit Status is cutoff The test plan does work, but the status is cut off in the modal window. Might need some adjustment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32489] Add check out date, number of renewals, numbers of overdue days in list of overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32489 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 ByWater Sandboxes changed: What|Removed |Added Attachment #160259|0 |1 is obsolete|| --- Comment #11 from ByWater Sandboxes --- Created attachment 160273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160273=edit Bug 35628: Display status in table appropriately Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #10 from Martin Renvoize --- Created attachment 160272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160272=edit Bug 35628: Display status strings instead of codes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #160258|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 160271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160271=edit Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #160257|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 160270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160270=edit Bug 35628: Add status to ticket definition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #160256|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 160269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160269=edit Bug 35628: Schema update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #160255|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 160268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160268=edit Bug 35628: Add status to tickets table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35630] Add ability to log changes to Authorized Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35645] Modification Log only show changed values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35645 --- Comment #1 from Angela Berrett --- Created attachment 160267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160267=edit Current Koha modification log view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Mike Barrette changed: What|Removed |Added CC||mbarre...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35645] New: Modification Log only show changed values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35645 Bug ID: 35645 Summary: Modification Log only show changed values Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: angela.berr...@familysearch.org QA Contact: testo...@bugs.koha-community.org CC: angela.berr...@familysearch.org, gmcha...@gmail.com Created attachment 160266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160266=edit OLIB cataloging system item modification log The modification logs for a bib record puts all bibliographic and item information in a single text box when an edit occurs. For easier reading it would be nice to only show the fields/information that were modified. A previous catalog our library used would show a single line per change when an item was modified. It would show the date | person who made the change | old value | new value. This kept an accurate history and made reviewing the changes easy to read. As there is a single modification page for all items on a bib record the object column identifying which item was changed would need to be included. A similar table could be created for bib record modifications identifying the MARC field that was changed either in the Object column or in its own column, along with the old and new values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34575] Patron search results: Customise the fields displayed in Name column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34575 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Sally --- Brilliant, thanks so much, Pedro - exactly what I needed! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597 Lucas Gass changed: What|Removed |Added Attachment #160253|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 160265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160265=edit Bug 35597: logaction when modifying or deleteing suggestions To test: 1. Apply patch, restart services, updatedatabase 2. Search for the system preference 'SuggestionsLog', it should be off. Turn it on. 3. Create a purhase suggestion 4. Go to Tools > Log viewer. In modules check 'Suggestions' 5. You should see your newly created suggestion. 6. Modify the suggestion and check the logs again, the modification should be logged. 7. Delete the suggestion, the deletion should be logged. 8. Do a purchase suggestion via the OPAC. 9. Check the logs to see the newly created suggestion, the interface should be OPAC. 10. Turn of SuggestionsLog 11. No changes of any kind should be logged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597 Lucas Gass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34575] Patron search results: Customise the fields displayed in Name column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34575 Biblibre Sandboxes changed: What|Removed |Added Attachment #160229|0 |1 is obsolete|| --- Comment #5 from Biblibre Sandboxes --- Created attachment 160264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160264=edit Bug 34575: Add a CSS class to patron email Adds a CSS class to the patron email section in the 'name-address' column of search results in members-home.pl No functional behaviour change. Signed-off-by: Sally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 ByWater Sandboxes changed: What|Removed |Added Attachment #160244|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 160263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160263=edit Bug 31297: Allow null value for description in subscription_numberpatterns To test: 1 - Go to Serials 2 - Add a enw subscription 3 - Select Vendor and record, click next 4 - Select Numbring pattern: Number, or any to populate forms 4 - Click 'show advanced pattern' 5 - 'Modify pattern' 6 - Add a new name 7 - 'Save as new pattern' 8 - Nothin happens 9 - Check logs: C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /kohadevbox/koha/serials/create-numberpattern.pl line 58 10 - Apply patch 11 - Update database 12 - Restart all 13 - Click save again 14 - Success! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35644] Remove/edit Last Seen date on an item when it was incorrectly marked as seen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35644 Angela Berrett changed: What|Removed |Added Priority|P4 |P5 - low -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35644] New: Remove/edit Last Seen date on an item when it was incorrectly marked as seen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35644 Bug ID: 35644 Summary: Remove/edit Last Seen date on an item when it was incorrectly marked as seen Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P4 Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: angela.berr...@familysearch.org QA Contact: testo...@bugs.koha-community.org CC: angela.berr...@familysearch.org, gmcha...@gmail.com Items are run through inventory and marked as Seen. Sometimes a barcode was keyed in wrong or the barcode was incorrectly assigned (switched between two copies of the same book) and that book was not actually seen. When editing an item record the field for Date Last Seen is not listed and therefore not editable. We would like the ability to clear or adjust the date in this field for books that were accidentally run through Inventory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35641] Reduce DB calls when performing inventory on a list of barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35641 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35641] Reduce DB calls when performing inventory on a list of barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35641 ByWater Sandboxes changed: What|Removed |Added Attachment #160241|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 160262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160262=edit Bug 35641: Reduce DB lookups when sending a list of barcodes to inventory This patch does three things: 1 - Removes a specific query for withdrawn status of each item scanned - we can use the withdrawn field 2 - Removes a specific query for checkouts on each item scanned - we can use the onloan field a - additionally we don't need to fetch the checkout as we check it in to the homebranch, this is likely incorrect - we should use the current branch, but I preserve behavior for now 3 - Fetches the items ahead of time and builds a hash based on barcode, reduces DB lookups, may raise memory usage To test: 1 - Checkout some items 2 - Withdraw some items 3 - Generate a lsit of barcodes including some checked out items and some withdrawn items 4 - Enter that list of barcodes into inventory tool 5 - Note your results 6 - Apply patch 7 - Issue the items again 8 - Repeat inventory 9 - Confirm results are the same as before patch Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Nick Clemens --- The tests here randomly fail - using builder to create the renewals seems to sometimes create a related checkotu object, and sometimes a related old checkotu object - I think you need to generate the correct data using AddIssue/AddRenew/MarkIssueReturned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Martin Renvoize changed: What|Removed |Added Attachment #160211|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Martin Renvoize changed: What|Removed |Added Attachment #160212|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Martin Renvoize changed: What|Removed |Added Attachment #160213|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Martin Renvoize changed: What|Removed |Added Attachment #160214|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 160261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160261=edit Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 --- Comment #5 from Martin Renvoize --- Created attachment 160260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160260=edit Bug 32435: Add TICKET_RESOLUTION authorized value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #5 from Martin Renvoize --- Created attachment 160259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160259=edit Bug 35628: Display status in table appropriately -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #4 from Martin Renvoize --- Created attachment 160258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160258=edit Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #3 from Martin Renvoize --- Created attachment 160257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160257=edit Bug 35628: Add status to ticket definition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #2 from Martin Renvoize --- Created attachment 160256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160256=edit Bug 35628: Schema update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #1 from Martin Renvoize --- Created attachment 160255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160255=edit Bug 35628: Add status to tickets table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 --- Comment #1 from Owen Leonard --- Created attachment 160254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160254=edit Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7 This patch upgrades the HC Sticky library in the OPAC and staff interface to the latest version, 2.2.7. The file is moved to its own directory for consistency's sake. To test, apply the patch and clear your browser cache if ncessary. Test pages in the OPAC and staff interface which use the "sticky" heading feature. As you scroll down the header should "stick" to the top of the viewport. For example: - Administration -> System preferences - Catalog -> Search results - Cataloging -> Basic MARC editor - Patrons -> Add or edit patron - Lists -> List contents In the OPAC: - Catalog search results - Lists -> List contents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597 Lucas Gass changed: What|Removed |Added Attachment #160223|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 160253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160253=edit Bug 35597: logaction when modifying or deleteing suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED CC||caroline.cyr-la-rose@inlibr ||o.com Documentation||Caroline Cyr La Rose contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/803 Status|Needs documenting |RESOLVED --- Comment #35 from Caroline Cyr La Rose --- This is a very cool feature! Thanks everyone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off CC||n...@bywatersolutions.com --- Comment #18 from Nick Clemens --- (In reply to Katrin Fischer from comment #16) > I think that the option to immediately "delete circulation history" from the > patron account in the OPAC doesn't work correctly yet. I have no more > issues, but there is still a renewal entry that has the renewer_id of my > user. > > The immediately deletion should always work, independent of the privacy > setting. This works in my testing - the renewal from the opac is cleared - the renewal from the staff remains, I used a different patron on staff and opac side. When I used the same patron, both renewals were anonymized - again, this makes sense. In this case, the original renewal with the staff patron for the other account remained, and I htink this is correct too - the patron gets anonymized - other staff don't -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Owen Leonard changed: What|Removed |Added Blocks||35643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35584] Missing licenses in about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard changed: What|Removed |Added Blocks||35643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35643] New: Upgrade HC Sticky library from v2.2.3 to v2.2.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 Bug ID: 35643 Summary: Upgrade HC Sticky library from v2.2.3 to v2.2.7 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 35584, 21751 The copy of HC Sticky we use is from 2018. We can upgrade it to a version which was released in 2021. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 [Bug 21751] fixFloat toolbar not displaying properly in Chrome https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 [Bug 35584] Missing licenses in about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35154] Convert StaffLoginInstructions system preference to additional contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Pedro Amorim changed: What|Removed |Added Attachment #159616|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 160252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160252=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35154] Convert StaffLoginInstructions system preference to additional contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35642] Upgrade Font Face Observer library from v2.0.3 to v2.3.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 --- Comment #1 from Owen Leonard --- Created attachment 160251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160251=edit Bug 35642: Upgrade Font Face Observer library from v2.0.3 to v2.3.0 This patch upgrades the Font Face Observer library from v2.0.3 to the latest release, v2.3.0. The file is moved to its own directory for consistency's sake. To test, apply the patch and clear your browser cache. - Load any page in the OPAC. - The custom font we supply for the OPAC (Noto Sans) should load correctly. - If you want to see more about the functionality of the library, use your browser's developer tools to simulate a slow connection. - The page should load with a default sans-serif font first, and then the downloaded font will be applied. Note: If you throttle your connection speed *too* much, the loading of the custom font will time out and you'll only see the default sans-serif font. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35642] Upgrade Font Face Observer library from v2.0.3 to v2.3.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 --- Comment #27 from Nick Clemens --- Created attachment 160250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160250=edit Bug 28012: (QA follow-up) Add numeric imput mode to display order field Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 --- Comment #26 from Nick Clemens --- Created attachment 160249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160249=edit Bug 28012: Creating numbering pattern: mark mandatory fields required If any of these fields were missing, notably the Numbering formula then saving the new numbering pattern silently failed, it didn't give any error but it didn't save any new pattern either. Note that there is a plan to make description field optional, so even if it currently is mandatory on the DB level we leave it optional here (and due to people using production DB's in non-strict mode which allows this to be optional). To test: 1) After applying this patch make sure all the 3 fields must be filled in /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new page and it cannot be saved without those. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Nick Clemens changed: What|Removed |Added Attachment #141947|0 |1 is obsolete|| Attachment #141948|0 |1 is obsolete|| --- Comment #25 from Nick Clemens --- Created attachment 160248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160248=edit Bug 28012: Use definedness test instead of bool when checking whether to null fields Saving a new numbering pattern didn't work without having to fill all the fields, even those that are not mandatory. To test: 1) Go to /cgi-bin/koha/serials/subscription-numberpatterns.pl and try creating a new pattern, notice that only Name and Description are mandatory after applying this patch 2) Make sure editing existing numbering patterns still works Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Nick Clemens changed: What|Removed |Added Blocks||28012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 [Bug 28012] Error on saving new numbering pattern -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28012] Error on saving new numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA Depends on||31297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 [Bug 31297] Cannot add new subscription patterns from edit subscription page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #8 from Tomás Cohen Arazi --- (In reply to David Nind from comment #4) > The tests for the first two patches pass, both before and after the patches > are applied. > > I'm not sure for the third patch what features/things to test to make sure > they work as expected. Hi, this changes are pretty trivial code-wise. For the third patch you would need to: * Have something set on `RisExportAdditionalFields` and export a record as RIS- It should still work as usual. * Have something set on `MarcFieldsToOrder` and add an order using an ISO2709 (mrc) file. Should work as usual * Have something set for `UpdateItemWhenLostFromHoldList` and a couple pending holds. I'm not sure how to trigger it but it seems to be possible to mark a hold as lost from the pending list, and it should honor the setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 160247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160247=edit Bug 33431: Fix remaining cases This patch tweaks three remaining cases, that are not covered by tests. To test: 1. Apply this patch 2. Make use of those places => SUCCESS: No behavior change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 160246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160246=edit Bug 33431: Make C4::Record use C4::Context->yaml_preference This patch makes what the title says. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Rec* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Attachment #149236|0 |1 is obsolete|| Attachment #149237|0 |1 is obsolete|| Attachment #149238|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 160245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160245=edit Bug 33431: Make C4::Circulation use C4::Context->yaml_preference This patch removes manual YAML handling for sysprefs in C4::Circulation. It also makes C4::Context->yaml_preference not warn when undef is retrieved from the sysprefs. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Circulation* => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard changed: What|Removed |Added Blocks||35642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 [Bug 35642] Upgrade Font Face Observer library from v2.0.3 to v2.3.0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35584] Missing licenses in about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard changed: What|Removed |Added Blocks||35642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 [Bug 35642] Upgrade Font Face Observer library from v2.0.3 to v2.3.0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35642] New: Upgrade Font Face Observer library from v2.0.3 to v2.3.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 Bug ID: 35642 Summary: Upgrade Font Face Observer library from v2.0.3 to v2.3.0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 35584, 20554 The copy of Font Face Observer we use in the OPAC is from 2016. We can upgrade it to a version which was released in 2022. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 [Bug 20554] New OPAC CSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 [Bug 35584] Missing licenses in about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35392] HTML in translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 --- Comment #17 from Pedro Amorim --- @Joubu, are we able to move on here? I don't want my patches to be the cause of holding off this bug. Please advise. If you decide to obsolete my patches please note that they're also fixing Tomas' original patch: 1) Has a typo "$this." 2) Only addresses UsageStatisticsDataProvidersList.vue. Does not address UsageStatisticsDataProvidersFileImport.vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Nick Clemens changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |n...@bywatersolutions.com |com | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Nick Clemens changed: What|Removed |Added Attachment #138892|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 160244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160244=edit Bug 31297: Allow null value for description in subscription_numberpatterns To test: 1 - Go to Serials 2 - Add a enw subscription 3 - Select Vendor and record, click next 4 - Select Numbring pattern: Number, or any to populate forms 4 - Click 'show advanced pattern' 5 - 'Modify pattern' 6 - Add a new name 7 - 'Save as new pattern' 8 - Nothin happens 9 - Check logs: C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /kohadevbox/koha/serials/create-numberpattern.pl line 58 10 - Apply patch 11 - Update database 12 - Restart all 13 - Click save again 14 - Success! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #34 from Pedro Amorim --- Not a blocker, but why the design decision of restricting a date attribute type to not be able to also be repeatable? I can't find many good examples of how a repeatable date field would be useful, but I don't understand why we wouldn't allow it either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #33 from Pedro Amorim --- Failing QA here: - Missing tests - import_borrowers.tt should check if a given patron_attribute that's being added is is_date and validate the data accordingly, else the following bug may occur: 1) Create a patron attribute type of is_date as per the original test plan, named 'date' 2) Import a patron, visit: /cgi-bin/koha/tools/import_borrowers.pl 3) Click "Download a Starter CSV file with all the columns." and add a cardnumber, categorycode, branchcode and on the patron_attributes column put date:test 4) Import, notice the import is successful, now visit that patron edit page (do a search for the imported cardnumber), e.g. example for patron id 289: /cgi-bin/koha/members/moremember.pl?borrowernumber=289 5) Notice it blows up with error: Template process failed: undef error - The given date (teste) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 205. at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35639] Long SMS messages are not sent if they exceed the character limitation of the messaging driver
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35639 Emily-Rose Francoeur changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35639] Long SMS messages are not sent if they exceed the character limitation of the messaging driver
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35639 Emily-Rose Francoeur changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||emily-rose.francoeur@inLibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35639] Long SMS messages are not sent if they exceed the character limitation of the messaging driver
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35639 --- Comment #1 from Emily-Rose Francoeur --- Created attachment 160243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160243=edit Bug 35639: Trim the messages that are too long before sending them via SMS I created a new system preference, SMSSendMaxChar, which allows you to set a limit for the number of characters in SMS messages to send. When a limit is set, messages that exceed it will be trimed. TEST PLAN 1) Apply the patch 2) Run prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18783] Allow automatic claims for serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
