[Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587

--- Comment #7 from Aleisha Amohia  ---
(In reply to Pedro Amorim from comment #5)
> Test plan works as described, but this patch is causing
> - prove t/db_dependent/Circulation/Branch.t
> to fail.

Thank you for testing, great catch. I've updated the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #160215|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 160305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160305&action=edit
Bug 35587: Do not trigger transfer if lost item returned and
BlockReturnOfLostItems enabled

This fixes current buggy behaviour - when BlockReturnOfLostItems is enabled, no
transfer should be triggered and the lost status should be retained.

To test:

1. Go to Koha Administration -> Global system preferences
2. Set the BlockReturnOfLostItems system preference to Block
3. Enable the AutomaticItemReturn system preference (this is simply to make
testing a bit faster)
4. Take note of your logged in library
5. Search for an item where the home library is NOT the same as your logged in
library
6. Edit this item and give it a lost status
7. Check in the item
8. Notice the item is returned and a transfer is automatically triggered
9. If you go to the item record page, the lost status has been remove

10. Apply the patch and restart services

11. Edit the item again and give it a lost status. This will also cancel the
transfer
12. Check in the item
13. Confirm the transfer is NOT triggered and the lost status is retained as
expected.
14. Go back to system preferences and disable the BlockReturnOfLostItems system
preference (set to "Don't block")
15. Check in the item
16. Confirm the transfer is triggered and lost status is removed

17. Confirm tests pass

prove t/db_dependent/Circulation/Returns.t
prove t/db_dependent/Circulation/Branch.t

Sponsored-by: Pymble Ladies' College
Signed-off-by: Esther 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
Just a couple of comments from testing:

1. Since it only logs modifications and deletions, then the description for the
system preference needs updating (currently says "Don't log/Log any changes to
purchase suggestions (create, modify, delete).")

2. For deletions, the info column is empty - should this have the details for
the suggestion before it is deleted?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35652] Notices and Slips table has inconsistent module names

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35652

--- Comment #1 from Katrin Fischer  ---
There is a practical reason for them to be specific: all the notices added as
claim acquisition will appear in the drop down when sending claim emails. You
can have multiple notices there and the module is used to 'pull them' into the
pull down. Same for serials claims.

Both modules also have other notices: order emails for acq and the new issue
alert email for serials. So I think combining into just the module would not
work well.

The acq order email also has its own module. Currently you can only add one
notice, but I was hoping to make that more flexible at some point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23460] Be able to specify a default item type, to allow Koha to do things to items that don't have itypes?

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23460

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX
 CC||wizzy...@gmail.com

--- Comment #4 from Liz Rea  ---
This does seem better lately due to fixes in other areas. I think we can put
this one to bed.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35653] New: Allow the patron import script to log it's output to the action_logs cron logging

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653

Bug ID: 35653
   Summary: Allow the patron import script to log it's output to
the action_logs cron logging
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

It would be so neat if the import_patrons.pl command line tool had the option
to send the brief output to the in-Koha action_logs cron logs, so at least
libraries could see easily that the cron had run. Bonus points for useful info
in there like what it currently can output on the command line: 


Import complete:
Imported:0
Overwritten: 1981
Skipped: 0
Invalid: 0
Total:   1981

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This makes 'Check the
  release notes||logs..' messages more
   ||consistent across Koha,
   ||including the use of full
   ||stops. It also fixes up
   ||other related
   ||inconsistencies. These
   ||changes should make
   ||translations easier as
   ||well.

--- Comment #5 from David Nind  ---
A nice tidy up! Thanks Tomás.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

David Nind  changed:

   What|Removed |Added

 Attachment #160296|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 160304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160304&action=edit
Bug 35650: (follow-up) Other cases found

while editing files for the main patch, I noticed some tiny cases.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

David Nind  changed:

   What|Removed |Added

 Attachment #160295|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 160303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160303&action=edit
Bug 35650: Standardize on 'Check the logs for details.'

This patch makes the 'Check the logs..' messages more consistent across
the codebase.

To test:
1. Run:
   $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.'
=> FAIL: Several forms show up
2. Apply this patch
3. Repeat 1
=> SUCCESS: Empty result.
4. Run:
   $ git grep -e 'Check the logs for details\.'
=> SUCCESS: Consisten results show
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enables breaking large
  release notes||Elasticsearch or Open
   ||Search indexing requests
   ||into smaller chunks (for
   ||example, from batch
   ||modifications). It adds a
   ||chunk_size configuration to
   ||the elasticsearch section
   ||in koha-conf.xml (for
   ||example:
   ||250). So instead of sending a
   ||single background request
   ||for indexing, which could
   ||exceed the limits of the
   ||search server or take up
   ||too many resources, this
   ||limits index update
   ||requests to a more
   ||manageable size.
   ||
   ||NOTE:
   ||This doesn't change the
   ||command line indexing
   ||script, as this already
   ||allows passing a commit
   ||size defining how many
   ||records to send.
 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
I've signed off, as everything in the test plan worked.

However, I did note one thing when updating authority records:

1. Starting fresh (patch applied, shutting down KTD, then starting up again so
that there are no previous jobs, adding the 250,
restarting everything).

2. After updating all the authority records by adding text to 680$1, there are
1320 entries for jobs:
   - the last 7 job entries (1314-1320) are for the elastic search index
updates, split into 250 chunks (1320 is for 206 record updates)
   - the first job entry (1) is for the batch authority record modification
(1706 modifications)
   - the rest of the job entries (2-1313) are for Elasticsearch index updates
to individual bibliographic records (from a sample I checked)

3. I'm assuming that the individual bibliographic record updates are because
the authority terms updated are linked to them.

4. I don't know whether this is what is expected, or whether there are plans to
chunk the subsequent individual bibliographic records updated because of
authority term changes. Or whether that is even possible.

5. Irrespective of that, this is still a great improvement!

Testing notes (using KTD):

1. I tested using ES8 (ktd --es8 up).

2. For the modification of bibliographic records, I updated the 'z - Public
note' with some text.

3. For the modification of authority records, I had a rule to add some text to
680$i subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33036] REST API: Merge biblio records

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036

--- Comment #44 from Zeno Tajoli  ---
I check the patches of Jonathan and for me are OK.

I add a new little patch because there is a new test inside
t/db_dependent/API/v1/biblios.t (bug 35574).

Now there is only JSON for inputting a MARC record because inside JSON I also
insert other parameters ["biblio_id_to_merge", rules", "framework_to_use"]

I don't know how to pass them without using JSON.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33036] REST API: Merge biblio records

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036

--- Comment #43 from Zeno Tajoli  ---
Created attachment 160302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160302&action=edit
Update of test number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

 Attachment #160278|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 160301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160301&action=edit
Bug 35086: Add chunk_size option to elasticsearch configuration

Whne performing batch operations we can send a large numebr of records for
reindexing at once.
Currently this can create requetss that are too large for Elasticsearch to
process. We need
to break these requests into chunks/

This patch adds a chunk_size configuration to the elasticsearch stanza in
koha-conf.xml

If blank we default to 5000.

To test:
0 - Have Koha using Elasticsearch
1 - Create and download a report of all barcodes:
SELECT barcode FROM items
2 - Batch modify these items
3 - Note a single ESindexing job is created
4 - Create and download a report of all authority ids:
SELECT auth_header.authid FROM auth_header
5 - Setup a marc modification template, and batch modify all the authorities
6 - Again note a single ES backgorund job is created
7 - Apply patch
8 - Repeat the modifications above - you still get a single job
9 - Edit koha-conf.xml and add 250 to elasticsearch
stanza
10 - Repeat modifications - you now get several background ES jobs
11 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35652] New: Notices and Slips table has inconsistent module names

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35652

Bug ID: 35652
   Summary: Notices and Slips table has inconsistent module names
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The Notices and Slips table has a couple of inconsistent module names. For
example the module "Claim acquisition" for the ACQCLAIM notice should probably
be "Acquisition". As more notices are added it would make it easier to search
and sort the notices if the notices are grouped with their proper module.

Claim acquisition -> Acquisition
Serials (new issue) -> Serials

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35522] Error in Upgrading: ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /u

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35522

--- Comment #2 from Victor Zuniga  ---
Hi Harsha,

Please take a look at ticket #35552:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35552

Igor pointed me in the right direction. After replacing the content of the
file:

/usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/230600013.pl

with the code Igor shared on the ticket, I was able to complete the upgrade
process.

Best,

Victor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35552] Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35552

Victor Zuniga  changed:

   What|Removed |Added

 CC||hb...@ou.ac.lk

--- Comment #6 from Victor Zuniga  ---
*** Bug 35522 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35522] Error in Upgrading: ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /u

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35522

Victor Zuniga  changed:

   What|Removed |Added

 CC||vctrzun...@gmail.com
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Victor Zuniga  ---


*** This bug has been marked as a duplicate of bug 35552 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35552] Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35552

--- Comment #5 from Victor Zuniga  ---
Hi Igor,

This did the trick. Thanks so much for your help!

Victor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646

lthor...@cuyahogalibrary.org  changed:

   What|Removed |Added

 CC||lthor...@cuyahogalibrary.or
   ||g

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160209|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 160300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160300&action=edit
Bug 35629: Remove redundant code

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160254|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 160299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160299&action=edit
Bug 35643: Upgrade HC Sticky library from v2.2.3 to v2.2.7

This patch upgrades the HC Sticky library in the OPAC and staff
interface to the latest version, 2.2.7. The file is moved to its own
directory for consistency's sake.

To test, apply the patch and clear your browser cache if ncessary.

Test pages in the OPAC and staff interface which use the "sticky"
heading feature. As you scroll down the header should "stick" to the top
of the viewport. For example:

- Administration -> System preferences
- Catalog -> Search results
- Cataloging -> Basic MARC editor
- Patrons -> Add or edit patron
- Lists -> List contents

In the OPAC:

- Catalog search results
- Lists -> List contents

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160277|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 160298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160298&action=edit
Bug 35646: Unit tests

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160276|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 160297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160297&action=edit
Bug 35646: Allow use of publication date fields in serial numbering pattern

This patch extends the numbering pattern field to accept subsitituations for:
{Year} {Day} {DayName} {Month} {MonthName}

These fields are based on the publication date for the serial issue.

To test:
0 - Apply patch
1 - Setup a enw numbering pattern
Serials->Manage numbering patterns + New numbering pattern
2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Day}
{MonthName} {DayName}
3 - Populate X/Y/Z in the table as you wish, these should be unaffected by
patch
4 - Set a Frequency /  First issue plublication date / Subscription length
5 - Click 'Test pattern'
6 - Confirm the dates in the Number match the publication date values
7 - Try with different frequencies to confirm they match
8 - Save the pattern
9 - Create a new subscription and use the new pattern
10 - Confirm it works as expected

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35651] New: Toggle for Advanced Editor should not show to staff without advanced_editor permissions

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35651

Bug ID: 35651
   Summary: Toggle for Advanced Editor should not show to staff
without advanced_editor permissions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Bug 34275 introduces a toggle button for users to move from the basic editor to
the advanced editor easily.  Currently, this toggle button shows to staff
without the advanced editor permission. If a staff chooses to try to toggle to
the advanced editor, they will be logged out.  It would be best to not show the
toggle button if the staff member does not have the advanced_editor permission.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 160296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160296&action=edit
Bug 35650: (follow-up) Other cases found

while editing files for the main patch, I noticed some tiny cases.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 160295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160295&action=edit
Bug 35650: Standardize on 'Check the logs for details.'

This patch makes the 'Check the logs..' messages more consistent across
the codebase.

To test:
1. Run:
   $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.'
=> FAIL: Several forms show up
2. Apply this patch
3. Repeat 1
=> SUCCESS: Empty result.
4. Run:
   $ git grep -e 'Check the logs for details\.'
=> SUCCESS: Consisten results show
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|oleon...@myacpl.org |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] New: 'Check the logs' string dot-inconsistent

2023-12-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

Bug ID: 35650
   Summary: 'Check the logs' string dot-inconsistent
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I found this when translating. If you run:

$ git grep 'Check the logs'

you will notice in most cases the structure is:

. Check the logs.
or
. Check the logs for details

But in some the dot is missing. The inconsistency causes (probably) the
constant changes in the translation system in which the same string sometimes
has the dot, sometimes it doesn't and it is changed all the time the same way.

I think the correct form is to use the dot, and is also the more widespread. So
I'm proposing to stick with using the dot:

$ git grep 'Check the logs' | wc -l
  31

$ git grep 'Check the logs\.' | wc -l
  17

$ git grep 'Check the logs ' | wc -l
  3

$ git grep -e 'Check the logs\"' -e 'Check the logs<' | wc -l
  11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/