[Koha-bugs] [Bug 35701] Cannot use i18n.inc from MACRO block?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED Severity|major |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #20 from Julian Maurice --- Created attachment 160565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160565&action=edit Bug 35070: Fix get_enabled_plugins when database is not created yet Koha::Plugins::get_enabled_plugins is called by Koha::Plugins::call which is called by C4::Templates->new, which is used in the web installer when the database is not created yet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #21 from Julian Maurice --- I didn't try t/db_dependent/selenium/00-onboarding.t but I was able to reproduce the error by running the web installer. After the patch I was able to complete the installation and the onboarding process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #6 from Martin Renvoize --- Thanks for the testing Nick, I had a feeling we might have some straggling issues from this so it got me digging back into the transfers tree.. at least some of those issues have my attention already. I'll post once I've identified the relevant bugs and code :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #7 from Martin Renvoize --- Hmm.. this sounds like the order_by in the relation isn't catching properly :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35706] New: Typo "Amoung" in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35706 Bug ID: 35706 Summary: Typo "Amoung" in manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Amount tendered: enter the actual amount handed to you by the patron. The amount tendered must be equal or greater than 'Amoung being paid'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 --- Comment #4 from Pedro Amorim --- (In reply to David Nind from comment #3) > This does fix the issue, and I have signed off. > > However, some comments - not sure how hard these are to do or whether it > depends on the ILL plugin (I'm assuming this is the case): > > 1. If the "Destination library" is not selected, then the message at the top > says: "Please Note: Branch is a mandatory field.". In my view the error > should match the UI, that is, instead of "Branch" it should say "Destination > library is required" > > 2. The normal UI for forms in the OPAC (from what I can see) is to have > "Required" under the field name, and then a message if mandatory fields are > not completed. I assume that this depends on how the ILL plugin works/coded > though. Hi David, thanks for testing! Your assumptions are correct. The form and its behavior is dependent on the specific ILL backend which the request is being created to, in this example it's FreeForm. In bug 35570 I'm submitting work to add FreeForm to Koha core, to become a backend available out of the box instead of it being required to install an external one in order to make use of the ILL module. I mention bug 35570 because once that's gone through, these sort of enhancements can be worked directly into Koha, and have at least the Koha native backend be consistent with everything else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35706] Typo "Amoung" in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35706 --- Comment #1 from Katrin Fischer --- There is another a little below: Change to give: if the amount tendered is greater than the amoung being paid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25253] Allow to apply modification template when exporting checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25253 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin Somers --- Must be applyed on top of Bug 24679 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35685] ILL - OPAC request creation error if submitted empty while ILLModuleDisclaimerByType is in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35685 --- Comment #5 from David Nind --- (In reply to Pedro Amorim from comment #4) ... > Hi David, thanks for testing! > Your assumptions are correct. The form and its behavior is dependent on the > specific ILL backend which the request is being created to, in this example > it's FreeForm. > > In bug 35570 I'm submitting work to add FreeForm to Koha core, to become a > backend available out of the box instead of it being required to install an > external one in order to make use of the ILL module. > I mention bug 35570 because once that's gone through, these sort of > enhancements can be worked directly into Koha, and have at least the Koha > native backend be consistent with everything else. Thanks Pedro! I'll look at signing that one off over the next few days. I'll keep an eye out for other ILL bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #8 from Martin Renvoize --- Nope, the ordering works.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz ✔ ❤ ★
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #271 from Slava Shishkin --- Created attachment 160566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160566&action=edit Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz ✔ ❤ ★
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Slava Shishkin changed: What|Removed |Added Attachment #160566|0 |1 is obsolete|| --- Comment #272 from Slava Shishkin --- Created attachment 160567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160567&action=edit Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz ✔ ❤ ★
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Slava Shishkin changed: What|Removed |Added Attachment #160567|0 |1 is obsolete|| --- Comment #273 from Slava Shishkin --- Created attachment 160568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160568&action=edit Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ - test line for the commit message - and one more test line for message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] New: Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Bug ID: 35707 Summary: Item statuses in the holdings table on biblio details should appear one per line Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The item status field may contain more than one status message, but currently, those messages are one after the other as opposed to one above the other. It would be clearer to display them one above the other. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 --- Comment #1 from Martin Renvoize --- Created attachment 160569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160569&action=edit Current display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 --- Comment #2 from Martin Renvoize --- Created attachment 160570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160570&action=edit Proposed change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 --- Comment #3 from Martin Renvoize --- Created attachment 160571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160571&action=edit Bug 35707: Add clearfix to item statuses This patch adds the clearfix class to each of item status/availabiliy spans. This has the effect of pushing each status onto it's own line. Test plan 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two status's, one above the other as displayed in the screenshots attached to the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707 Martin Renvoize changed: What|Removed |Added CC||da...@davidnind.com, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #14 from Nick Clemens --- Created attachment 160572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160572&action=edit Bug 35086: (follow-up) Use 5000 as example in conf file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 --- Comment #15 from Nick Clemens --- (In reply to Jonathan Druart from comment #13) > you have 500 in conf and 5000 in pm, is that expected? 500 seemed a more reasonable size in my head, but 5000 is more consistent with our default indexing so I updated it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35587] Items lose their lost status when check-in triggers a transfer even though BlockReturnOfLostItems is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587 --- Comment #13 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] New: System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Bug ID: 35708 Summary: System parameter AutoRenewalNotices defaults to deprecated option Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: anke.br...@gwdg.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When installing Koha, the deprecated option "(Deprecated) according to --send-notices cron switch" is set by default in the system preference "AutoRenewalNotices". It would be nicer to have another option as default, e.g. "according to patron messaging preferences" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |anke.br...@gwdg.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35598] selenium/authentication_2fa.t is still failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35598 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 Martin Renvoize changed: What|Removed |Added Depends on||29234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 Martin Renvoize changed: What|Removed |Added Blocks||35100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #79 from Katrin Fischer --- Hm, a bugfix depending on an enhancement can be an issue as it makes backporting hard or impossible. Any chance we could get a bugfix for the stable versions independent of bug 29440? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35709] New: Renew selected items button is inactive when overdue items are preselected automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35709 Bug ID: 35709 Summary: Renew selected items button is inactive when overdue items are preselected automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: anneli.oster...@koha-suomi.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Renew or checkin selected items button were seperated to two buttons (wich is great). When you go to patron's checkouts and there are overdue items, they are selected automatically for renewal (as previously). But now the Renew selected items button is inactive and you have to click one of the overdue items on the Renew colum to activate the button. And click it again to renew that one too. This happens in both cgi-bin/koha/members/moremember.pl and cgi-bin/koha/circ/circulation.pl pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #9 from Nick Clemens --- Created attachment 160573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160573&action=edit Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode This page is a single form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #80 from M --- I don't think that it would be viable at all at this point... Imo they should be either backported both or neither of them. Otherwise I'm not even sure if it applies to the original unpatched scripts without breakage or side-effects. I don't think cherry-picking only parts of this for backport is worth it. Not to mention that commit "Enable bulkmarcimport overlay context" itself also depends on fixes from the refactor made in the other bug. If we're extra-careful, it could be even dubious if they should be backported at all, in case someone might currently depend on old slightly broken behavior of the scripts, such as having "*" overlay rules that were completely ignored despite code suggesting otherwise. I previously suggested merging it as bugfix in November, but before 23.11 was actually officially released. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35709] Renew selected items button is inactive when overdue items are preselected automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35709 --- Comment #1 from Anneli Österman --- Created attachment 160574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160574&action=edit Renew selected items button is inactive Screenshot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35704] Parent and child itemtype hold limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 --- Comment #1 from Katrin Fischer --- The parent/child itemtype feature is currently only used for the number of checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35070] Koha plugins implementing "background_jobs" hook can't provide view template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35070 --- Comment #22 from Katrin Fischer --- Pushed the follow-up to master. Thanks for taking care of this so quickly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35710] New: Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35710 Bug ID: 35710 Summary: Indexing problem with "&" symbol in Zebra. Some biblio-records with "&" symbol are not searching Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: yuriy.kots...@oa.edu.ua I find a problem in my academy koha instance. My librarians can't find some biblio-records. I check database and figured out that records looks good. So, I decided to rebuild zebra index. During rebuilding where a lot of errors. Simple analyses show, that problem was with "&" symbol. Example below: ... Wide character in warn at /usr/share/koha/lib/C4/Biblio.pm line 1199. problem with :423324 : :42: parser error : xmlParseEntityRef: no name Norton & Company ^ http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"; xmlns="http://www.loc.gov/MARC21/slim";> 00516nam a22002177a 4500 UA-OsUOA 133930 ta 20181112b un | 00| 0 ukr d 51 BK UA-OsUOA eng UA-OsUOA UA-OsUOA The Principles of Mathematics B. Russell 535 p. с. 2 eng 51 New York Norton & Company 1951 51 Математика UDC 423324 423324 2 Юрій Анатолійович Коцюк error retrieving biblio 423324 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 686. ... One more example: ... Wide character in warn at /usr/share/koha/lib/C4/Biblio.pm line 1199. problem with :423001 : :43: parser error : EntityRef: expecting ';' http://zt.knteu.kiev.ua/index.php?option=com_content&view ^ :43: parser error : EntityRef: expecting ';' ld code="u">http://zt.knteu.kiev.ua/index.php?option=com_content&view=article&id ^ :43: parser error : EntityRef: expecting ';' http://zt.knteu.kiev.ua/index.php?option=com_content&view=article&id=2349&Itemid ^ :43: parser error : EntityRef: expecting ';' .knteu.kiev.ua/index.php?option=com_content&view=article&id=2349&Itemid=721&lang ^ ... It's looks like script try use ampersand sequence... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns changed: What|Removed |Added Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #68 from Katrin Fischer --- I reviewed the patch more closely today and tested. We'll need some more small fixes: 1) +bug_number => "BUG_30230", This is wrong and should be just 30230. 2) Please add view to the permission descriptions in the SQL and template file: +"INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (4, 'list_borrowers', 'Search and list patrons')" 3) In the main navigation (not start page, but on top) the Patrons module is missing with only catalogue and list_borrowers permission. I quite like the way how this lets you limit patron search to your own library in combination with library groups. When view_borrower_infos_from_any_libraries is added, I can search them all. But I am not required to also give edit_borrowers. This is nice. Please help to finish this! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35708] System parameter AutoRenewalNotices defaults to deprecated option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35708 Anke Bruns changed: What|Removed |Added CC||anke.br...@gwdg.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35711] New: Compatibility levels before 10 are deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35711 Bug ID: 35711 Summary: Compatibility levels before 10 are deprecated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com Seeing this when trying to build custom packages: dh clean --fail-missing --with bash-completion dh: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_auto_clean -O--fail-missing dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) dh_clean -O--fail-missing dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use) No idea what it means, but see bug 18908 for a similar fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35711] Compatibility levels before 10 are deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35711 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18908 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18908] Warning "Compatibility levels before 9 are deprecated"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18908 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35711 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35504] Release team 24.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #22 from Katrin Fischer --- I think we didn't get the wiki bit right, it currently still lists me (I haven't signed up :) ), and we are missing George Williams and Mason James, but we should have them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35712] New: Record issue_id in old_reserves for completed holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35712 Bug ID: 35712 Summary: Record issue_id in old_reserves for completed holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org CC: n...@bywatersolutions.com There is not currently a direct data linkage between a filled hold in old_reserves and the checkout that filled it in (old_)issues. It'd be helpful if we could put the issue_id into the old_reserves table to make that explicit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35713] New: Update or remove debian/docs/LEEME.Debian?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713 Bug ID: 35713 Summary: Update or remove debian/docs/LEEME.Debian? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com The file was added by bug 7197 in 2011, but has never been updated. I don't know Spanish, but I have a hunch it might need an update after all these years. Or maybe it can be removed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35504] Release team 24.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #23 from Katrin Fischer --- Out of interest - how do the entries sort? I notice that it's not alphabetic, but also not following the sequence of the YAML file (for me RM is last QAM is first, but in the file RM would be first and QAM somehwere in the middle) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35504] Release team 24.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #19) > > 1. What is DT_delay for? > > We want to make sure the AJAX request is there. In some cases (see bug > 35284), the wait_for_ajax was called but the AJAX request was not triggered > yet, so we didn't wait for it to finished. Ouch, yet another bad thing that can happen >_< Thankfully, I had no sign of that happening in my +2000 runs. But it might happen on the CI thanks to Murphy's law. So I added it in my WIP patch. - > > 2. I only though of it just now: instead of having the flag > > window._pageFullyReady, should the problematic buttons be hidden in the > > HTML? (and maybe have a dummy button with a loading icon in place to show > > the user that stuff it loading) And then the stuff in $(document).ready() > > makes them visible after setting the onclick callback. And the test just > > waits for the button to be visible instead of the flag to be set. > > We should not need more than wait_for_ajax here IMO. That's not what is happening here. The wait_for_page_fully_ready uses are for distinct places than wait_for_ajax. Each time it's about not clicking the "Show checkouts" button before it's callback is set. So no XHR involved here to wait for as an alternative. > If it takes more than > 10 sec then there is something wrong somewhere else. That's another thing than the use of wait_for_page_fully_ready. At least on my machine, the XHR can indeed take more than 10 sec to return (and still work), many times over all my runs. I'm not sure there is really a problem other than a perfect storm that makes the request horribly slow sometimes. > We could extend the > delay specifically for this call. That's precisely what it done in my patch. That's why I had to turn max_retries from a constant to a field with accessors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #160511|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 Victor Grousset/tuxayo changed: What|Removed |Added URL||https://gitlab.com/tuxayo/K ||oha/-/commits/bug-35506-sel ||enium-regressions.t-failing ||-randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30681] Allow overlay protection of MARC data by subfield
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30681 Rhonda Kuiper changed: What|Removed |Added CC||rkui...@roundrocktexas.gov --- Comment #2 from Rhonda Kuiper --- I agree that protecting MARC information on a subfield level would be WONDERFUL! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #21 from Jonathan Druart --- window._pageFullyReady I don't understand how this is useful. Selenium should wait for the page to be loaded before starting the tests. If it's because of async statements, then this won't help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35714] New: Clicking Print slips when no letter template selected causes error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35714 Bug ID: 35714 Summary: Clicking Print slips when no letter template selected causes error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Preservation Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charil...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: jonathan.druart+k...@gmail.com In the preservation module, a "Letter template for printing slip" can be selected when creating a processing. This is not a required field; the field is blank by default. When viewing a train that uses a processing where no letter template have been specified, I still see the Print slips button in the Items table actions. When I select items, the button becomes clickable. When I click on it, I get an error page (probably because there is no specified notice for Koha to use!) On master, the error page starts with the lines: Error trace No letter_code at /kohadevbox/koha/preservation/print_slip.pl line 45. at /usr/lib/aarch64-linux-gnu/perl-base/Carp.pm line 289 On a system recently upgraded to 23.11, I am getting a 500 error at /cgi-bin/koha/preservation/print_slip.pl?train_item_id=1&train_item_id=2_blank It would be better if either: - the "Letter template for printing slip" field had the Train item slip selected by default; - or, the Print slip button didn't appear at all when no letter templates are selected in the processing settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35715] New: Pick items to add to train directly from those in the waiting list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35715 Bug ID: 35715 Summary: Pick items to add to train directly from those in the waiting list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Preservation Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charil...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: jonathan.druart+k...@gmail.com In the preservation module, you have to add your items to the waiting list before you can add them to a train. When adding items to a train from the Trains > Show train page (at /cgi-bin/koha/preservation/trains/1/items/add), the only option is to scan the item's barcode. I understand that makes sense for library staff who are located close to the physical items. However, it would be very useful if all the items in the waiting list could also be displayed on this page, so staff could select them from the list instead of re-scanning all the ones they need. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35100] Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35100 --- Comment #9 from Martin Renvoize --- Created attachment 160575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160575&action=edit Bug 35100: Various fixes 1) Don't automagically always set a transfer to in transit on checkin.. wait for the user to actually confirm that's the case 2) New transfers triggered by a hold should take precidence, so hide transfers for any other reason from display 3) Remove current_branchtransfers prefect from detail.pl as doing a prefetch completely nukes the order_by that this transfer method relies heavily upon to get the right modified FIFO transfer of the queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35155] MARCOverlayRules syspref not in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35155 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 Rasa Satinskiene changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/772 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #4 from Rasa Satinskiene --- Manual updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #22 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #21)
> window._pageFullyReady
>
> I don't understand how this is useful. Selenium should wait for the page to
> be loaded before starting the tests.
No, it's not about the page to be loaded. It's about $(document).ready() to
have finished all it's content. The event Selenium waits for is the same as the
one $(document).ready() waits for IIUC.
So they both start at the same time and from time to time, Selenium reaches the
"Show checkouts" button before $(document).ready() {[...]} has reached the
point where it give the button it's callback. So Selenium click on an inactive
button and nothing happens. That's what I understood from the screenshots
showing the button looking like blocked in the pressed position and Koha no
doing the expected action. And it seems confirmed by the usage of
window._pageFullyReady preventing the issue.
> If it's because of async statements, then this won't help.
I don't know if the following is async, whether attaching the callback is
async. But by the time it reaches setting window._pageFullyReady. Then the
button is functional and all works as expected.
$('#issues-table-load-now-button').click(function(){
[]
});
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #23 from Victor Grousset/tuxayo --- I commented the calls to wait_for_page_fully_ready and after 7 run, I got again this error: Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 349. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #24 from Victor Grousset/tuxayo --- After rerunning 2 times, I got the other error # Failed test 'Checkouts table must be correctly aligned' # at t/db_dependent/selenium/regressions.t line 213. # got: '' # expected: '1' # thead: 0 ; tfoot: 18 ; tbody: 0 So the two main errors of this ticket are fixed by wait_for_page_fully_ready. I'm not even sure wait_for_ajax fixed anything the CI was hitting. But anyway, I needed them on my PC to be able to do a lot of runs of 'Encoding in session variables' and 'Checkouts table must be correctly aligned' without having interruptions due to long XHR responses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35716] New: Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716 Bug ID: 35716 Summary: Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: jonathan.druart+k...@gmail.com, julian.maur...@biblibre.com, m.de.r...@rijksmuseum.nl, martin.renvo...@ptfs-europe.com, tomasco...@gmail.com There are some JS assets duplicated in koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl. 100% match: ./koha-tmpl/opac-tmpl/bootstrap/js/i18n.js ./koha-tmpl/intranet-tmpl/js/i18n.js 100% match: ./koha-tmpl/opac-tmpl/bootstrap/js/Gettext.js ./koha-tmpl/intranet-tmpl/js/Gettext.js ~95% match: ./koha-tmpl/opac-tmpl/bootstrap/js/coce.js ./koha-tmpl/intranet-tmpl/js/coce.js ~95% match: ./koha-tmpl/opac-tmpl/bootstrap/js/cookieconsent.js ./koha-tmpl/intranet-tmpl/prog/js/cookieconsent.js ~80% match: ./koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js ./koha-tmpl/intranet-tmpl/prog/js/ill-availability.js ~50% match: ./koha-tmpl/opac-tmpl/bootstrap/js/basket.js ./koha-tmpl/intranet-tmpl/prog/js/basket.js Some of the differences in the above pairs may have been due to requirements specific to only staff or to only OPAC, or it may also have been the case that they have fallen out of sync over the years with some enhancements being added to one of the pair and not the other. I don't know what the best solution for this would be (if one is needed) but developing bug 35604 I need to have the same JS file on both intra and OPAC and feels bad to have to copy the same file to 2 different places. I'm only looking for JS files but I know this is also the case for images, maybe some CSS and other assets. Could we consider having a koha-tmpl/shared-tmpl directory, or have some of these overlapping assets only exist once and have them be duplicated for each interface during build, or yet another better option? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25163] Add the ability to bulk attach items to a bib record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25163 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35704] Add hold limits to Parent Child Item Types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 Lisette Scheer changed: What|Removed |Added Summary|Parent and child itemtype |Add hold limits to Parent |hold limits not enforced as |Child Item Types |expected| --- Comment #2 from Lisette Scheer --- ah, I misunderstood. I'm renaming this into an enhancement request: Parent and child itemtype hold limits not enforced as expected -> Add hold limits to Parent Child Item Types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35691] Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or ||g --- Comment #1 from Kristi --- There are power users that like to receive single notifications for other types of notices like hold filled. The non-digestible version of this remains, so I would suggest both options (single or digests only) to remain for autorenewal notices. Unless, unlike hold filled, there is only one possible time per day that the autorenewal message would be sent out? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] New: Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Bug ID: 35717 Summary: Add an ordernumber column to suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org This is bug 28844 reworked with the relationship defined in the reverse way. There can be multiple suggestions for the same title currently (the check for duplicate suggestions includes the suggestedby field in the search, so only a single patron is prevented from requesting the same book twice) While we can order only from a single suggestion, bug 19358 and 31632 seek to allow linking multiple suggestions to an order, I believe we need to define the relationship this way now, to allow for future changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #1 from Nick Clemens --- Created attachment 160576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160576&action=edit Bug 35717: DB changes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #2 from Nick Clemens --- Created attachment 160577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160577&action=edit Bug 35717: DBIC schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #3 from Nick Clemens --- Created attachment 160578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160578&action=edit Bug 35717: Add link between suggestions and orders Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #4 from Nick Clemens --- Created attachment 160579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160579&action=edit Bug 35717: Remove GetSuggestionInfoFromBiblionumber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #5 from Nick Clemens --- Created attachment 160580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160580&action=edit Bug 35717: Replace GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #6 from Nick Clemens --- Created attachment 160581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160581&action=edit Bug 35717: Remove GetSuggestionFromBiblionumber Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #7 from Nick Clemens --- Created attachment 160582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160582&action=edit Bug 35717: Adjust other calls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 --- Comment #8 from Nick Clemens --- Created attachment 160583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160583&action=edit Bug 35717: Tidy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35717 --- Comment #53 from Nick Clemens --- I reworked this with the relationship built the other way on bug 35717 I can attempt the update there, however, I think a better path is to allow a GUI way for the suggestions to be correctly linked, or to attempt to update and provide a way to correct if needed. I will be working on 19358 and 31632 this cycle which will be part of the GUI. Please let me know if we can agree to continue this work on 35717 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28844 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35718] New: Remove ES6 warnings from JavaScript system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718
Bug ID: 35718
Summary: Remove ES6 warnings from JavaScript system preferences
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
When using any of the UserJS system preferences there are warnings if you use
any ES6 features/syntax.
To recreate:
1. Add some JS like this to any of the UserJS system preferences:
$(document).ready( function() {
let something = 1;
const another_thing = 2;
let an_arrow_function = (a, b) => a + b;
console.log( an_arrow_function(something, another_thing) );
});
2. Notice the icons and warnings to the left of the line numbers:
let is available in ES6
const is available in ES6
arrow_function_syntax is available in ES6
ES6 syntax is pretty commonly used now, I don't think we need those warnings.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718
--- Comment #1 from Lucas Gass ---
Created attachment 160584
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160584&action=edit
Bug 35718: Remove ES6 warns from JS system preferences
To test:
1. Add some JS like this to any of the UserJS system preferences:
$(document).ready( function() {
let something = 1;
const another_thing = 2;
let an_arrow_function = (a, b) => a + b;
console.log( an_arrow_function(something, another_thing) );
});
2. Notice the icons and warnings to the left of the line numbers:
let is available in ES6
const is available in ES6
arrow_function_syntax is available in ES6
3. APPLY PATCH
4. Try steps 1 and 2 again, the warnings should be gone.
5. Check that the JavaScript still works, in my example it should console.log
3.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- I'd like to test, but I'm not sure of the exact steps for step 1 of the test plan (using KTD). This is what I tried, but I couldn't trigger the error: 1. Koha repository - checkout 23.05.x: git checkout 23.05.x 2. KTD: start up as normal (I didn't change the KOHA_IMAGE in .env) 3. From the KTD shell check out 23.11.x: ktd --shell git checkout 23.11.x 4. Restart everything: restart_all 5. Go to the staff interface 6. Upgrade starts - Use koha_kohadev as the user and password as the password - Grant more privileges to the koha_kohadev user: . mysql -uroot -ppassword -hkoha-db-1 . use mysql . grant all on koha_kohadev.* to koha_kohadev; . flush privileges; 7. No errors when updating the database structure I also tried using an earlier version: 1. Koha repository - checkout 22.11.x: git checkout 22.11.x 2. KTD - change KOHA_IMAGE in .env: . edit .env: KOHA_IMAGE=22.11 . ktd pull . ktd up ... same as above - step 3 onwards Do I have to manually alter the database tables so the conditions for the error to occur are in place before the upgrade? Happy to try again, otherwise I will leave to someone who is more familiar with how to work with different versions of Koha using KTD and doing upgrades. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32551] API requests don't carry language related information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32551] API requests don't carry language related information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 Nick Clemens changed: What|Removed |Added Attachment #160358|0 |1 is obsolete|| Attachment #160359|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 160585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160585&action=edit Bug 32551: Regression tests Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32551] API requests don't carry language related information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551 --- Comment #9 from Nick Clemens --- Created attachment 160586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160586&action=edit Bug 32551: HTTP_ACCEPT_LANGUAGE legacy CGI variable not set in Mojolicious This patch addresses the fact some of our code still relies on those CGI-era ENV variables. In particular, C4::Laguages::getlanguage expects it to calculate the most suitable language. As this is reported as required, I provide a fix. I did a `git grep HTTP_` on the codebase, and the only other occurences are: * C4::Output (HTTP_X_REQUESTED_WITH) * C4::Context (HTTP_USER_AGENT, HTTP_X_FORWARDED_FOR) * C4::Auth_with_shibboleth (using HTTP_ variables for matchpoints) * Some handling on the 'Koha as a Mojo app' code * Some .pl script not relevant to this report I decided to limit this patch to the requested header which seems harmless. I leave the other cases. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ qa -c 1 => FAIL: Tests fail! 3. Apply this patch 4. Run: k$ qa -c 2 => SUCCESS: Tests pass! All green! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650 Nick Clemens changed: What|Removed |Added Attachment #160303|0 |1 is obsolete|| Attachment #160304|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 160587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160587&action=edit Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650 --- Comment #7 from Nick Clemens --- Created attachment 160588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160588&action=edit Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Nick Clemens changed: What|Removed |Added Attachment #160476|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 160589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160589&action=edit Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage issue_manage inserted into the DB but issues_manage is tested in the controller script. Test plan: git grep issues_manage should no longer return any results Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35452] Provide more info when using Link authorities automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35452 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35452] Provide more info when using Link authorities automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35452 Nick Clemens changed: What|Removed |Added Attachment #159416|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 160590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160590&action=edit Bug 35452: Provide more info when using Link authorities automatically Test plan 1 Edit a record and add several 7xx and 6xx 2 Click on Link authorities automatically and check that the result only shows the field numbers 3 Apply patch, restart services 4 Click on Link authorities automatically and check that the result shows the field numbers and the info of the entry Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
