[Koha-bugs] [Bug 35813] When placing a booking, we should feedback successful placements

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813

--- Comment #5 from Martin Renvoize  ---
Thanks Owen :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35813] When placing a booking, we should feedback successful placements

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #161048|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

--- Comment #7 from Victor Grousset/tuxayo  ---
(In reply to Victor Grousset/tuxayo from comment #4)
> testing note: Turns out it's not related to imports. It's just multiple item
> additions. For example adding an order from an existing record or a new
> empty record was also affected and fixed.

Also, as far as I tested, it doesn't impact the final saved order. I couldn't
get a difference between orders when hitting the bug or not (with new empty
record, exiting record, staged file). The total doesn't seem to come from the
form so it's correct.

That divergence is weird though. @Thibaud if you indeed can reproduce an issue
with the saved order, feel free to add a mention it in "Text to go in the
release notes" in the ticket. (and if you can, fill it because it's empty now)

@Michał did you got that part of step 5 of the original test plan? «and if you
save "0" price will be set»

Anyway, updated commit title and test plan to simplify and keep only the stuff
that is certain. Patch can still move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #161082|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

--- Comment #6 from Victor Grousset/tuxayo  ---
Created attachment 161083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161083&action=edit
Bug 35514: Fix total cost update when adding multiple items to order

Test plan:

1) Create a basket and add an order line to go on neworderempty.pl
   (the new order form)
2) Choose to add one item and repeat the operation
3) See on form that the total cost is updated without update vendor
   price
4) Now add multiple items, for example, "2" you will see that the total
   cost is not updated
5) Apply this patch, refresh form and repeat steps 3 to 5

Signed-off-by: Michał Dudzik 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #161081|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 161082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161082&action=edit
Bug 35514: Fix costs update when adding multiple items from staged file

Test plan:

1) Stage a file with records
2) Create a basket and add order line from imported records to go on
   neworderempty.pl
3) Choose to add one item and repeat the operation
4) See on form that the total cost is updated without update vendor
   price
5) Now add multiple items, for example, "2" you will see that the total
   cost is not updated
6) Apply this patch, refresh form and repeat steps 3 to 5

Signed-off-by: Michał Dudzik 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net
Summary|Total prices not updated|New order line form: Total
   |when importing records from |prices not updated when
   |staged file with multiple   |adding multiple items
   |items added |

--- Comment #4 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

testing note: Turns out it's not related to imports. It's just multiple item
additions. For example adding an order from an existing record or a new empty
record was also affected and fixed.

Feel free to better phrase the title. The "New order line form:" part is my
attempt to make it more clear which page in the order process it is. I got a
bit lost in the workflow that includes before finding the right page. (maybe
it's more obvious now that there isn't a the import part)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #160564|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 161081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161081&action=edit
Bug 35514: Fix costs update when adding multiple items from staged file

Test plan:

1) Stage a file with records
2) Create a basket and add order line from imported records to go on
   neworderempty.pl
3) Choose to add one item and repeat the operation
4) See on form that the total cost is updated without update vendor
   price
5) Now add multiple items, for example, "2" you will see that the total
   cost is not updated and if you save "0" price will be set
6) Apply this patch and repeat step 5

Signed-off-by: Michał Dudzik 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35825] New: User without edit_any_item permission gets "Edit item" and "Delete item" options on restricted item

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35825

Bug ID: 35825
   Summary: User without edit_any_item permission gets "Edit item"
and "Delete item" options on restricted item
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: geo...@nekls.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 161080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161080&action=edit
Screenshot of edit_delete problem

When a borrower does not have edit_any_item permission they do not see "Edit"
or "Delete" on the action button drop-up menu for restricted items on
additem.pl, but they do see the "Edit item" and "Delete item" options when they
click on the cells in the row of that same restricted item.

These "Edit item" and "Delete item" options don't work when you click on them
(which is good).  All they do is take the user back to the details page of the
bibliographic record.  But there is no message or warning or any other
indication that the operation has failed - other than the fact that the item is
not modified or deleted.

This is confusing for library staff.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] 'cardnumber' overwritten with userid when not maped (LDAP auth)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 161079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161079&action=edit
Bug 29930: Cardnumber incorrectly set to userid on LDAP auth if cardnumber not
mapped

In the sub the userId was given, but the cardnumber was expected, therefore at
every login the cardnumber changed to the userId.

To test:
1. Login to the OPAC with an LDAP account that has a cardnumber which is
different to the userId
2. Check the patron record's cardnumber.
3. The cardnumber should equal to the userId
4. Apply the patch.
5. Login to the OPAC with an LDAP account that has a cardnumber which is
different to the userId
6. Check the patron record's cardnumber.
7. The cardnumber should be the same as before

Signed-off-by: Alexander Wagner 
Signed-off-by: Tomas Cohen Arazi 
Extra test plan:
1. Apply the regression tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Auth_with_ldap.t
=> FAIL: Tests fail! 'cardnumber' incorrectly overwritten
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] 'cardnumber' overwritten with userid when not maped (LDAP auth)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #154347|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 161078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161078&action=edit
Bug 29930: Regression tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] 'cardnumber' overwritten with userid when not maped (LDAP auth)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Component|Patrons |Authentication
 CC||dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] 'cardnumber' overwritten with userid when not maped (LDAP auth)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Auth with LDAP: Update tag  |'cardnumber' overwritten
   |leads to unwanted updates   |with userid when not maped
   ||(LDAP auth)
 Status|ASSIGNED|Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the display of
  release notes||item status column in the
   ||staff interface holdings
   ||table for a record. If
   ||there is more than one
   ||status to display, they are
   ||now displayed on separate
   ||lines, instead of running
   ||together as one continuous
   ||line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes issues with
  release notes||patron search, and
   ||remembering the patrons
   ||selected after performing
   ||an action (such as Add to
   ||patron list, Merge selected
   ||patrons, Batch patron
   ||modification). Remembering
   ||selected patrons was
   ||introduced in Koha 22.11,
   ||bug 29971.
   ||
   ||Previously, the
   ||patrons selected after
   ||running an action were
   ||kept, and this either
   ||caused confusion, or could
   ||result in data loss if
   ||other actions were taken
   ||with new searches.
   ||
   ||Now,
   ||after performing a search
   ||and taking one of the
   ||actions available, you are
   ||now prompted with "Keep
   ||patrons selected for a new
   ||operation". When you return
   ||to the patron search:
   ||- If
   ||the patrons are kept: those
   ||patrons should still be
   ||selected
   ||- If the patrons
   ||aren't kept: the patron
   ||selection history is empty
   ||and no patrons are selected
   Keywords||release-notes-needed

--- Comment #28 from David Nind  ---
Could someone edit the "Text to go in the release notes"? I've had a go, but I
wasn't involved in testing, so I'm not sure whether I am describing this
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35823] When uploading a MARC file to a basket it is showing inactive funds without them being selected

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823

Laura Escamilla  changed:

   What|Removed |Added

 Blocks||35824


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35824
[Bug 35824] Statistic 1 and Statistic 2 dropdowns are not showing when
uploading to a basket using MARC files
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35824] Statistic 1 and Statistic 2 dropdowns are not showing when uploading to a basket using MARC files

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35824

Laura Escamilla  changed:

   What|Removed |Added

 Depends on||35823


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823
[Bug 35823] When uploading a MARC file to a basket it is showing inactive funds
without them being selected
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35824] New: Statistic 1 and Statistic 2 dropdowns are not showing when uploading to a basket using MARC files

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35824

Bug ID: 35824
   Summary: Statistic 1 and Statistic 2 dropdowns are not showing
when uploading to a basket using MARC files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

1) Create two budgets -- let's say 'Active Budget 2024' and 'Inactive Budget
2024'
2) Create 'Fund1' in Active Budget 2024 and 'Fund2' in Inactive Budget 2024.
Make sure to select a Statistic 1 and Statistic 2 for both funds. 
3) Mark Inactive Budget 2024 as inactive.
4) Create a vendor and new basket if not already available. Add to the basket
using either a new MARC file or a staged MARC file. 
5) When adding the items to the order click on "Fund" and select 'Fund1'.
Notice that the drop down for statistic 1 and statistic 2 are not showing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35823] New: When uploading a MARC file to a basket it is showing inactive funds without them being selected

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823

Bug ID: 35823
   Summary: When uploading a MARC file to a basket it is showing
inactive funds without them being selected
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

1) Create two budgets -- let's say 'Active Budget 2024' and 'Inactive Budget
2024'
2) Create 'Fund1' in Active Budget 2024 and 'Fund2' in Inactive Budget 2024.
3) Mark Inactive Budget 2024 as inactive.
4) Create a vendor and new basket if not already available. Add to the basket
using either a new MARC file or a staged MARC file. 
5) When adding the items to the order click on "Fund" and notice that 'Fund2'
is appearing in the dropdown despite the "Show inactive funds" box not being
ticked.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #126 from Hammat wele  ---
Created attachment 161077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161077&action=edit
Bug 27113: Fix the Input Size of the Catalog Search Bar

This patch addresses the sizing issue with the catalog search bar, ensuring
that the input zone now covers the entire white bar area.

TEST PLAN:

   1) Apply the patches that precede this one.
   2) Activate IntranetAutocompleteElasticSearch and
  OPACAutocompleteElasticSearch in the system preferences.
   2) Click "Catalog search" in the navigation bar.
   3) Click on the right side of the white area of the search bar.
   4) Confirm that it does not allow you to start typing unless you click on
the left side of the search bar.
   5) Apply this patch.
   6) Repeat steps 2 and 3.
   7) Verify that this time it allows you to type in the search bar even if you
click on the right side of the searc  h bar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Hammat wele  changed:

   What|Removed |Added

 Attachment #161076|0   |1
is obsolete||
 Attachment #161076|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35822] New: Apostrophe in the POS cash register name / description causes errors

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35822

Bug ID: 35822
   Summary: Apostrophe in the POS cash register name / description
causes errors
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1. Enable the Point of Sale syspref. 
2. Configure a cash register with an apostrophe in the name & description. For
example: Laura's Cash Register
3. Configure an item for purchase. 
4. Using the POS collect a payment for an item. 
5. View the Transaction History for the cash register. Notice that nothing is
showing in any of the tables. 
6. Select a date range for displaying transactions. Example: 1/10/2024 to
1/16/2024. Notice that the past sales table appears but is showing "DATA" and
has data like "{ "type": "credit", "identifier": "", "description": "Purchase
(Cash)", "amount": "16.00", "timestamp": "01/16/2024 16:33" }" in the table. 
7. Edit the cash register so that it no longer has an apostrophe in the name
nor description. View the Transaction History page again. All tables are
showing as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #125 from Hammat wele  ---
Created attachment 161076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161076&action=edit
Bug 27113: Fix the Input Size of the Catalog Search Bar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Hammat wele  changed:

   What|Removed |Added

 Attachment #160142|0   |1
is obsolete||
 Attachment #160142|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35798] Record overlay rules are needed for Authorities

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35798

cecil  changed:

   What|Removed |Added

 CC||chilly...@washoecounty.us

--- Comment #1 from cecil  ---
Specifically the 667 field for non public notes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086

David Nind  changed:

   What|Removed |Added

  Text to go in the|This enables breaking large |This enables breaking large
  release notes|Elasticsearch or Open   |Elasticsearch or Open
   |Search indexing requests|Search indexing requests
   |into smaller chunks (for|into smaller chunks (for
   |example, from batch |example, when updating many
   |modifications). It adds a   |records using batch
   |chunk_size configuration to |modifications).
   |the elasticsearch section   |
   |in koha-conf.xml (the   |This means
   |default is 5,000:   |that instead of sending a
   |5000). So instead of sending  |for indexing, which could
   |a single background request |exceed the limits of the
   |for indexing, which could   |search server or take up
   |exceed the limits of the|too many resources, it
   |search server or take up|limits index update
   |too many resources, this|requests to a more
   |limits index update |manageable size.
   |requests to a more  |
   |manageable size.
   |The
   |
   |default chunk size is
   |NOTE:   |5,000. To configure a
   |This doesn't change the |different chunk size, add a
   |command line indexing   | directive to
   |script, as this already |the elasticsearch section
   |allows passing a commit |of the instance's
   |size defining how many  |koha-conf.xml (for example:
   |records to send.|2000).
   ||
   ||NOTE: This doesn't
   ||change the command line
   ||indexing script, as this
   ||already allows passing a
   ||commit size defining how
   ||many records to send.

--- Comment #23 from David Nind  ---
Tweaked the release notes text - feel free to improve!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #9 from Victor Grousset/tuxayo  ---
CCing Lucas to have confirmation about what they signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||vic...@tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo  ---
What's the status of 1st attachment?
"Bug 34585: Add data-code attribute to chargeperiod_charge_at selector"

Is it valid?
Was is applied when signing off?
It doesn't change the same area of the code so it's not sure it's an old
version. And it has a different test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34299] Add Acquisitions functionality to Library Groups

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34299

he...@bywatersolutions.com changed:

   What|Removed |Added

 CC||he...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #12 from Tomás Cohen Arazi  ---
Ok, I wrote some tests. Wrapping them up together later or early morning
tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #7 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #6)
> Cannot teat right now but not sure nack will re-enqueue btw

https://www.rabbitmq.com/stomp.html
"""
NACK frames can optionally carry the requeue header which controls whether the
message will be requeued or discarded/dead lettered. Default value is true.
"""

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #6 from Jonathan Druart  ---
Cannot teat right now but not sure nack will re-enqueue btw

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #5 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #4)
> I'm not 100% confident with my patch, but sending in case it might open for
> another options to solve the issue. The idea is to not ACK if the job is not
> found, making rabbit resend the notification to subscribers.

Shouldnt you have the ack in the catch then? Otherwise the "frame not
processed" situation will have the frame reenqueued endlessly (?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35821] Add option to log a run of export_records.pl to the Koha cron log

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35821

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
Log start and end :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698

--- Comment #3 from Kristi  ---
(In reply to Felicity Brown from comment #2)
> This would be a fantastic solution to a problem we've been having with
> re-orders of older titles, where we get the newer edition as a replacement.
> Our current workaround creates some pretty yucky metadata.

Same for us.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107

--- Comment #8 from Kyle M Hall  ---
Created attachment 161075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161075&action=edit
Bug 35107: Add tests

prove t/db_dependent/Koha/Illrequest.t

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107

--- Comment #7 from Kyle M Hall  ---
Created attachment 161074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161074&action=edit
Bug 35107: (QA follow-up) Use extended_attributes

Addressing the warning:
illrequestattributes is DEPRECATED in favor of extended_attributes

No functional behaviour change here

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #158072|0   |1
is obsolete||
 Attachment #159271|0   |1
is obsolete||
 Attachment #159272|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 161073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161073&action=edit
Bug 35107: Show type disclaimer value and date in request details

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Set ILLModuleDisclaimerByType system preference , visit:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans#interlibrary_loans_Workflow
3) Copy the example code, click the 'Click to edit' link to open the text area,
and paste the example yaml:
all:
 text: |
  HTML title
  This is an HTML paragraph
  This is another HTML paragraph
 av_category_code: YES_NO
article:
 text: copyright text for all article type requests
 av_category_code: YES_NO
 bypass: 1
4) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put'9780822370451' in ISBN, put '42' in the cardnumber, and
pick a library
6) You should now be in the type disclaimer stage, click 'Submit'
7) Notice the disclaimer value and date are displayed under 'Details from
supplier'
8) Click the top 'Switch provider' button and pick BLDSS
9) You should get one result, click the 'Request BLL01018665793' link to finish
the migration
10) You should now be in the ILL table, click the request that was just
migrated to BLDSS
11) Notice the type disclaimer information is no longer visible
12) Apply patch, restart plack: koha-plack --restart kohadev
13) Refresh the BLDSS request, the information should now be visible in the
'Request details' section

Signed-off-by: Richard Bridgen 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698

Felicity Brown  changed:

   What|Removed |Added

 CC||felicity.brown@montgomeryco
   ||untymd.gov

--- Comment #2 from Felicity Brown  ---
This would be a fantastic solution to a problem we've been having with
re-orders of older titles, where we get the newer edition as a replacement. Our
current workaround creates some pretty yucky metadata.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35651] Toggle for advanced editor should not show to staff without advanced_editor permissions

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35651

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the display of
  release notes||the button to access the
   ||advanced editor. It now
   ||only displays when the
   ||staff patron has the
   ||correct permissions ("Use
   ||the advanced cataloging
   ||editor (requires
   ||edit_catalogue)").

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #4 from Liz Rea  ---
(In reply to Lucas Gass from comment #3)
> Created attachment 161072 [details] [review]
> Bug 35535: Do not pass value of NULL on returns.tt when cancelling hold
> 
> To test:
> 1. APPLY PATCH
> 2. Check in an item having awaiting hold there comes a pop-up window. There
> is a button saying Cancel hold.
> 3. Cancel the hold without giving a reason.
> 4. Check that the hold has been properly canceled.

Noting that the case in which this manifests is when there are no authorized
values defined for the category of HOLD_CANCELLATION - so delete those before
you test this (if you have some defined) :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

--- Comment #3 from Lucas Gass  ---
Created attachment 161072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161072&action=edit
Bug 35535: Do not pass value of NULL on returns.tt when cancelling hold

To test:
1. APPLY PATCH
2. Check in an item having awaiting hold there comes a pop-up window. There is
a button saying Cancel hold.
3. Cancel the hold without giving a reason.
4. Check that the hold has been properly canceled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

--- Comment #2 from Lucas Gass  ---
We can just not pass NULL and use a blank/empty value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Lucas Gass  changed:

   What|Removed |Added

Version|23.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #4 from Tomás Cohen Arazi  ---
I'm not 100% confident with my patch, but sending in case it might open for
another options to solve the issue. The idea is to not ACK if the job is not
found, making rabbit resend the notification to subscribers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #161071|Bug 35819: Notify NACK when |[ALTERNATE] Bug 35819:
description|Job ID not found|Notify NACK when Job ID not
   ||found

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 161071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161071&action=edit
Bug 35819: Notify NACK when Job ID not found

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208

Rhonda Kuiper  changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

--- Comment #4 from Rhonda Kuiper  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #3 from Barbara Johnson  ---
This would be so helpful.  We use a higher ratio in order to better manage our
budget.  Having to change it every time (and make sure all staff know that they
should be changing it) takes extra time.  Maybe this could be a system
preference instead of being hard coded.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35821] New: Add option to log a run of export_records.pl to the Koha cron log

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35821

Bug ID: 35821
   Summary: Add option to log a run of export_records.pl to the
Koha cron log
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Libraries often have export jobs scheduled to send MARC records here and there.
It would be cool if we could have the cron job optionally log it's run to the
action_logs via the cron log.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

--- Comment #9 from Martin Renvoize  ---
Created attachment 161070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161070&action=edit
Bug 34853: Switch to 'div' as suggested

This patch switches us from '' to '' so
we're just using a block level elemenet instead of manipulating an
inline element to act like a block.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34853] Move EDI link to new line in invoice column of acquisition details display

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34853

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #155954|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 161069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161069&action=edit
Bug 34853: Add clearfix span to Invoice links

This patch adds a clearfix span around the invoicenumber and EDI message
display texts which should result in them each having their own line.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35607] Multi-receiving only receives orders visible on the screen

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35607

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #29 from Katrin Fischer  ---
I really like seeing us move settings like this into the system preference/GUI.
It makes it much easier to manage different settings for servers with multiple
instances. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

--- Comment #71 from Thibaud Guillot  ---
Created attachment 161068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161068&action=edit
Bug 30230: (follow-up) Add list permission on home-search include and update
atomic update file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35820] New: Table on Hold ratios page at circ/reserveratios.pl has wrong id

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35820

Bug ID: 35820
   Summary: Table on Hold ratios page at circ/reserveratios.pl has
wrong id
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org

The table at circ/reserveratios.pl currently has an id of "holdst". The table
settings page says that table id should be "holds-ratios".

"holdst" is the id for the holds queue table at circ/view_holdsqueue.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #104 from Katrin Fischer  ---
It applies, not sure what went wrong here, testing now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #2 from Jonathan Druart  ---
Created attachment 161067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161067&action=edit
Bug 35819: Retry to fetch job if does not enqueued yet

If a job has been enqueued in the middle of a txn, the worker will fetch
the job but fail because it's not in the DB yet.

The uglier but most effective (as a quick fix and easily backportable
fix) is to... wait a bit.
This patch suggests to sleep 1sec and retry, 10 times.

It should be enough for the majority of the jobs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707

--- Comment #9 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35707] Item statuses in the holdings table on biblio details should appear one per line

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35707

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35663] Wording on OPAC privacy page is misleading

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663

--- Comment #9 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35663] Wording on OPAC privacy page is misleading

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35474] Add icon for protected patrons

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474

--- Comment #5 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35474] Add icon for protected patrons

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

--- Comment #6 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35419] Update page title for bookings

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35379] 'searchfield' parameter name misleading when translating

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35379

--- Comment #5 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35379] 'searchfield' parameter name misleading when translating

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35379

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Jonathan Druart  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au,
   ||m.de.r...@rijksmuseum.nl,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #1 from Jonathan Druart  ---
We should have a "retry" mechanism for background jobs, or enqueuing with
delay, or both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35663] Wording on OPAC privacy page is misleading

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35663

Katrin Fischer  changed:

   What|Removed |Added

Summary|opac-privacy.pl wording is  |Wording on OPAC privacy
   |misleading  |page is misleading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #63 from Julian Maurice  ---
The bug found by Katrin in comment 51 needs to be fixed too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114

--- Comment #7 from Thibaud Guillot  ---
I've tried to be more complete with this test plan, but it's a bit tricky to
test, so I suggest you modify your data to obtain an example of bad behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19037

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18139
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #157495|0   |1
is obsolete||

--- Comment #6 from Thibaud Guillot  ---
Created attachment 161066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161066&action=edit
Bug 35114: Fix calculation around basketgroup and basket details

Currently calculation on basketgroup is performed on ecost (tax_included and
tax_excluded) while in basket detail it's on ecost only if unitprice is
not defined. So I keep the same logic in basketgroup and I took the
opportunity to remove a call to get_rounded_price on quantity (not
logic).

Test plan:

1) To test it you must have some items with differents values on
ecost_tax_* and unitprice_tax_*. Both have 6 decimal places, but
problems arise when the value (calculated for ecost_tax_*) has a 3rd
decimal greater than or equal to 5. So I you have already this case in
your datas create a basket with this item otherwise you can modify your
database to reproduce the bad behavior. e.g set a ecost_tax_included to
'18.655000' and '18.65' for unitprice.

2) After the basket has been created, and in a basketgroup, go to basketgroup
and check the amount.
Click to see the details of the linked basket, the total will be different
because the rounded total
displayed previously (basketgroup) is based on the ecost_tax_* and so 18.655000
will become 18.66.
In the detail based on the unitprice, which is 18.65, the difference will
be one cent on the total.
Not much, but it's only a record... it's not precise (in accounting terms).

3) Apply this patch and repeat step 2)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #103 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #102)
> *ping* Still waiting for a rebase.

The patch set is applying to current master cleanly for me! Are you getting
conflicts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

Andreas Jonsson  changed:

   What|Removed |Added

 CC||andreas.jons...@kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #62 from Marcel de Rooy  ---
It needs a rebase from Julian. And my final QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #61 from Martin Renvoize  ---
I'm confused.. what's the current state of this.. what needs doing to get it
over the finish line?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
Hi all, I'm not *that* familiar with the LDAP code, but I reverse engineered
how it works (on its interaction with Net::LDAP) for writing those mocked
tests, so I could help.

At first sight, it doesn't look like a harmless tiny change. That 15 year old
line seems to deal with how the `cardnumber` is set. So tests cannot be
skipped.

Looking at the code, what we have is:

1. LDAP login
2. Login ok => Locally query the patron on the DB. At this point, the
user-entered identifier is compared to `borrowers.userid` and then
`borrowers.cardnumber`. At this point we have the Koha-defined `cardnumber`
(nullable) and the `userid` (nullable on the DB, but auto-generated if NULL, by
Koha::Patron->store).
3. In either case, %borrower is populated with the mapped data from the LDAP
response, and using the user-introduced identifier as cardnumber...
=> SEEMS incorrect

I agree at this point we actually know the local userid and cardnumber and the
current code is naive in terms of how data is cared about.

My understanding is that the patch is correct, meaning that if there's a
mapping for the cardnumber, the loop in ldap_entry_2_hash() would overwrite it
anyway. So we are just avoiding the cardnumber being set incorrectly when it is
not mapped.

Will try to provide a test for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Katrin Fischer  changed:

   What|Removed |Added

 CC||clemens.tub...@kit.edu,
   ||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35092


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092
[Bug 35092] [OMNIBUS] Remaining background job/worker issues
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35092] [OMNIBUS] Remaining background job/worker issues

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||35819


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819
[Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race
condition)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #5 from Katrin Fischer  ---
Please also update the circulation sidebar with the same preference check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29346] Real-time holds queue update

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35819


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819
[Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race
condition)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] New: "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Bug ID: 35819
   Summary: "No job found" error for BatchUpdateBiblioHoldsQueue
(race condition)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 29346

A BatchUpdateBiblioHoldsQueue job is triggered from AddRenewal if
RealTimeHoldsQueue is set.

It is executed inside a transaction and the worker can receive the job to
process before the transaction has been committed (and so before the job exists
in the DB).

The call stack is:
opac-renew: AddRenewal
In C4::Circulation::AddRenewal
3234 $schema->txn_do(sub{
3302 $item_object->store({ log_action => 0, skip_record_index => 1 }); 

In Koha::Item->store
 223 Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue(
 224 {
 225 biblio_ids => [ $self->biblionumber ]
 226 }   
 227 ) unless $params->{skip_holds_queue} or
!C4::Context->preference('RealTimeHoldsQueue');

To recreate:
Turn on RealTimeHoldsQueue
Check an item in to a patron
At the OPAC, renew the checkout

=> Job 109 not found, or has wrong status main::
/kohadevbox/koha/misc/workers/background_jobs_worker.pl


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
[Bug 29346] Real-time holds queue update
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >