[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774

--- Comment #6 from David Nind  ---
(In reply to Lucas Gass from comment #3)

> David, this is my fault. I attached the wrong test plan.

No problem!

Now signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774

David Nind  changed:

   What|Removed |Added

 Attachment #161122|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 161127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161127&action=edit
Bug 35774: Use itemnumber instead of biblioitemnumber

With Bug 33639 already pushed to master there should be NO change in behavior.

To test:
1. APPLY PATCH
2. Create one or more item groups for a bib if needed
3. Create a new item, and at the bottom of the 'Add item' screen, select the
item group to which you want this item added. Save.
4. The item should succesffuly be added to the item group.
5. Add a new item and to the same record and this time try the 'Create a new
item group' from the dropdown.
6. Name the new item group.
7. Make sure it is correctly added to the item group.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193

--- Comment #21 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #17)
> (In reply to Jonathan Druart from comment #15)
> I understand that the goal is that a renewal should be prevented, if there
> is a another pending hold where the pickup library matches the holding
> branch (checkout library) of the item to be renewed. Is that correct?
> 
> I think it might be unlikely for a patron to place multiple holds on a
> record for pick-up at different libraries, but it would be possible. So
> looping through all existing holds seems logical to me. 
> 
> But I am feeling unsure here about why we are interested in the holds of a
> specific patron... are we not interested in looking at the holds for this
> specific record in general?

Thank you both for your thoughts.

I ended up taking out the loop entirely because at that point we are already
looping through the fillable holds on this biblio. Hopefully that will suffice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110437|0   |1
is obsolete||

--- Comment #20 from Aleisha Amohia  ---
Created attachment 161126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161126&action=edit
Bug 25193: Add AllowRenewalIfOtherItemsAvailableLocation syspref

This syspref works in conjunction with AllowRenewalIfOtherItemsAvailable
syspref. It has two options - allow renewal if other items are available
to fill holds at any branch, or only at the hold's pickup branch.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> system preferences. Search for
AllowRenewalIfOtherItemsAvailable. Notice the two sysprefs exist in the
same row. By default they should be set to "Don't allow" and "at any
library".
3) Set up a biblio with two items. Have both items held at Branch A.
4) Check out Item A to Borrower A.
5) Place a biblio-level reserve for Borrower B with pickup branch at
Branch A.
6) View Borrower A's checkouts. Confirm you cannot renew Item A ('On
hold' message).
7) Edit Item B, set the current location to Branch B. The items should
now have different locations.
8) Enable the AllowRenewalIfOtherItemsAvailable syspref. Leave the
AllowRenewalIfOtherItemsAvailableLocation syspref set to "at any library".
9) View Borrower A's checkouts. Confirm you CAN renew Item A (because
Item B can fill Borrower B's reserve).
10) Set the AllowRenewalIfOtherItemsAvailableLocation syspref to "at the
hold's pickup library". Keep AllowRenewalIfOtherItemsAvailable syspref
enabled.
11) View Borrower A's checkouts. Confirm you CANNOT renew Item A
(because Item B cannot fill Borrower B's reserve due to being at a
 different branch).
12) Edit Item B, set the current location to Branch A. The items should
have the same location now.
13) View Borrower A's checkouts. Confirm you CAN renew Item A.

Sponsored-by: Chartered Accountants Australia & New Zealand

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193

Aleisha Amohia  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35816] Email Notification Alert for Purchase Suggestion don’t properly work

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35816

Jimmy  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #2 from Jimmy  ---
currently my  version is 23.05.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #12 from Lucas Gass  ---
(In reply to Andrew Fuerste-Henry from comment #11)
> Hi these patches applied, I'm getting an error when attempting to receive an
> order tied to a suggestion. It looks like maybe an undefined basket number?

I don't recreate this. Did you updatedatabase after applying the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161121|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 161125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161125&action=edit
Bug 33464: Add page-section to "Orders by fund" result list

This updates the results table for the "Orders by fund"
report with the common white background.

To test:
* Go to Reports > Orders by fund
* Search for orders (you might have to add one)
* Verify the results table is missing the common
  white background
* Appyl patch
* Reload page and verify styling is improved

Signed-off-by: David Nind 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464

Lucas Gass  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33457] Improve display of fund users when the patron has no firstname

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161064|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 161124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161124&action=edit
Bug 33457: Improve display of fund users when the patron has no firstname

This patch updates the way the fund modification page handles patron
names so that a patron with only a first name or only a surname will
have their name appear correctly when selected as a manager or a user.

To test, apply the patch if necessary, create a patron with only a first
name and one with only a surname and give them acquisitions permissions.

- Go to Administration -> Funds.
- Edit a fund.
- Click 'Add users'.
- Select a user, only staff users will be searchable
- Select one of the patrons you created.
  - The patron name should appear correctly
  - Test with both your first name only patron and your last name only
patron.
- Perform the same test with the 'Select owner' process.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33457] Improve display of fund users when the patron has no firstname

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35300] Add page-section to table of invoice files

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160612|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 161123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161123&action=edit
Bug 35300: Add page-section to invoice files page

To test:
* Enable AcqEnableFiles system preference
* Go to acquisitions
* Search for a vendor and receive shipment
* Enter an invoice number and create new invoice
* Finish receive
* Click on 'manage invice files' link
* Upload a sample file
* Verify the table is missing the usual white background
* Apply patch
* Verify the the table now displays with the usual white
  background

Signed-off-by: David Nind 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35300] Add page-section to table of invoice files

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35300] Add page-section to table of invoice files

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35300

Lucas Gass  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #106 from Katrin Fischer  ---
I think I messed the bugzilla step or typoed "yes" again - I'll check in the
morning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] 'cardnumber' overwritten with userid when not mapped (LDAP auth)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Katrin Fischer  changed:

   What|Removed |Added

Summary|'cardnumber' overwritten|'cardnumber' overwritten
   |with userid when not maped  |with userid when not mapped
   |(LDAP auth) |(LDAP auth)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160994|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 161122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161122&action=edit
Bug 35774: Use itemnumber instead of biblioitemnumber

With Bug 33639 already pushed to master there should be NO change in behavior.

To test:
1. APPLY PATCH
2. Create one or more item groups for a bib if needed
3. Create a new item, and at the bottom of the 'Add item' screen, select the
item group to which you want this item added. Save.
4. The item should succesffuly be added to the item group.
5. Add a new item and to the same record and this time try the 'Create a new
item group' from the dropdown.
6. Name the new item group.
7. Make sure it is correctly added to the item group.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774

--- Comment #3 from Lucas Gass  ---
(In reply to David Nind from comment #2)
> I think I'm missing something for testing this bug.
> 
> Should I notice any change in behaviour before and after the patch is
> applied? Everything seems to work the same for me.
> 
> Also, I'm confused about step 5:
> 
> 1. If you add a new item, put a value to 952$h, then add to a group, then
> the 952$h shouldn't change. (This is the behaviour I'm seeing.)
> 
> OR
> 
> 2. If existing items have a value in 952$h, then when you add a new item, it
> should increment?
> 
> OR
> 
> 3. Something else?

David, this is my fault. I attached the wrong test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Martin Renvoize  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #13 from Emily Lamancusa  
---
I can't recreate either...but I wonder if it has something to do with the
sql_mode? I can't seem to find or remember where it's configured, but if I
recall correctly, the dev environment is set to strict mode, and production
environments usually aren't, right?

This page https://bugs.mysql.com/bug.php?id=93838 indicates that trying to make
a nullable column non-nullable will actually succeed in strict mode but throw a
"cannot change column used in foreign key constraint" in non-strict mode. (The
logic being that, in non-strict mode, null values will be filled with a default
value that may violate the foreign key constraint, whereas in strict mode the
command will not be allowed to execute if there are any existing null values in
the data.)

Maybe adding a primary key follows the same logic, and will fail only in
non-strict mode?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #3 from Andreas Jonsson  ---
Provided that all rows with all values being "infinity" and all columns with
all values being "infinity" is removed from the cost matrix beforehand and
there's still something left in the matrix, then there must exist at least one
pairing with finite cost that the algorithm will produce as result.

And if the matrix is empty the greedy algorithm wouldn't find any allocations
either.

So, I'd say that we do not need the greedy algorithm.

I think that my reasoning about different values to represent infinity was a
bit confused.  If a single large constant is used to represent infinity the
result of the algorithm will still maximize the number of finite valued
pairings, provided that the value representing infinity is larger than the
total cost of any finite cost assignment.  It might still be a good idea to use
different values to represent infinity to prefer not filling holds towards the
end of the queue if not all holds can be filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35269] Koha::Item->update_item_location should be named `trigger_location_update`

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35269
Bug 35269 depends on bug 21159, which changed state.

Bug 21159 Summary: Update item shelving location (952$c) on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Status|Needs documenting   |RESOLVED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/819
  Documentation||Caroline Cyr La Rose
contact||
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464

David Nind  changed:

   What|Removed |Added

 Attachment #161020|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 161121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161121&action=edit
Bug 33464: Add page-section to "Orders by fund" result list

This updates the results table for the "Orders by fund"
report with the common white background.

To test:
* Go to Reports > Orders by fund
* Search for orders (you might have to add one)
* Verify the results table is missing the common
  white background
* Appyl patch
* Reload page and verify styling is improved

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35092] [OMNIBUS] Remaining background job/worker issues

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35815

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35815] [Elasticsearch] Fix indexing of bibliographic records when items are deleted

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35815

David Nind  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35092

--- Comment #4 from David Nind  ---
I've tested using Koha 22.11 and ES6, and I couldn't replicate the issue.

Adding bug 35092 in case those working on the background job/worker issues have
any comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35831] Move UpdateItemLocationOnCheckout to Checkout policy section

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35831

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com
   Severity|enhancement |trivial
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35831] Move UpdateItemLocationOnCheckout to Checkout policy section

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35831

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 161120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161120&action=edit
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35831] Move UpdateItemLocationOnCheckout to Checkout policy section

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35831

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35831] New: Move UpdateItemLocationOnCheckout to Checkout policy section

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35831

Bug ID: 35831
   Summary: Move UpdateItemLocationOnCheckout to Checkout policy
section
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The UpdateItemLocationOnCheckout system preference introduced in bug 21159 has
been put under Circulation > Checkin policy. As this affect items on checkout,
I think it should go under Circulation > Checkout policy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35827] Ability to define item creation option for a vendor

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35827

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33725] Add item's collection code to search results location column in staff interface

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33725

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/818
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED
  Documentation||Caroline Cyr La Rose
contact||

--- Comment #9 from Caroline Cyr La Rose  ---
I redid the screenshots.

The specifics of what is displayed is not detailed in the manual, so there was
nothing to change in the text itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17507] Can upload the same .koc file twice

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507

--- Comment #7 from Christopher Brannon  ---
Maybe the file simply needs to be updated after being uploaded with an
indicator that it has been uploaded.  Can't be uploaded again unless someone
physically opens the file and changes the indicator manually?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17507] Can upload the same .koc file twice

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507

--- Comment #6 from Christopher Brannon  ---
Maybe the file simply needs to be updated after being uploaded with an
indicator that it has been uploaded.  Can't be uploaded again unless someone
physically opens the file and changes the indicator manually?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34298] Duplicate existing orders is missing page section on order list

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34298

David Nind  changed:

   What|Removed |Added

 Attachment #161018|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 161119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161119&action=edit
Bug 34298: Add page-section to duplicated orders list

When creating an order from an existing order (copy),
on the third page, the page section was  missing on the
table.

To test:
* Create a basket with an order, close the basket.
* Create a second basked
* Create a new order line using:
  "From existing orders (copy)"
* Search for your previous order and select it for copy - Next
* Select a fund - Duplicate orders
* Verify that the table with the order lines to create
  doesn't have the white background
* Apply patch
* Reload page - the table now should appear styled correctly

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34298] Duplicate existing orders is missing page section on order list

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34298

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32740] Add a new option patron home library to OverdueNoticeFrom

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/817
 Status|Needs documenting   |RESOLVED
  Documentation||Caroline Cyr La Rose
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

--- Comment #8 from Brendan Lawlor  ---
Thanks for the helpful link Emily, I hadn't found that part of the code yet.

It's a good example to show how to split an input string into an array and then
wrap the elements in quotes and separate them by commas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35251] Issue table does not recalculate number of checkouts after a check in

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35251
Bug 35251 depends on bug 35068, which changed state.

Bug 35068 Summary: Split 'Renew or check in selected items' button in issues 
table into separate buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35068

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35068] Split 'Renew or check in selected items' button in issues table into separate buttons

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35068

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/816
 Status|Needs documenting   |RESOLVED
  Documentation||Caroline Cyr La Rose
contact||
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35802] Note date when patron password was last changed

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35802

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35729] Amazon images don't work for ISBNs starting with 979

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] Performance issues with edifactmsgs when you have a large number of messages

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #105 from Nick Clemens  ---
This appears to be pushed to master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #160610|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 161118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161118&action=edit
Bug 35323: Fix hint for OpacMoreSearches HTML customization

There was some confusion on where this content appears.
This patch fixes the description shown as hint in the HTML
customizations tool when when the OpacMoreSearches entry is
selected.

To test:
* Before appyling the patch
* Add a new HTML customization for OpacMoreSearches
* Verif hint showing below the pull down
* Set a title and a publication date in the past
* Enter a short text, like "Koha" as content
* Save
* Go to the OPAC, verify text shows in the navigation
* Apply patch
* Verify hint is now correct

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35815] [Elasticsearch] Fix indexing of bibliographic records when items are deleted

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35815

--- Comment #3 from Aleisha Amohia  ---
(In reply to David Nind from comment #2)
> I had a go at testing on the current master using koha-testing-docker (KTD).
> 
> I couldn't replicate the issue using Elasticsearch 7 and 8, and Open Search
> 1 and 2.
> 

That's a good point - it was definitely happening with ES 6, I'm not sure if it
happened with ES 7. We might no longer be supporting ES 6 and since this patch
was written we have actually upgraded to ES 7 locally anyway so it might not be
needed... however I believe it is consistent with other ES indexing fixes I've
seen recently in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7223] Move borrowerRelationship to authorised values list

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7223

Catrina Berka  changed:

   What|Removed |Added

 CC||catr...@bywatersolutions.co
   ||m

--- Comment #2 from Catrina Berka  ---
+1 Would be much more intuitive than editing a list with pipes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #4 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159543|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 161117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161117&action=edit
Bug 35407: Correct terminology: Show fewer collections

In the OPAC, the "Show more" and "Show less" links have aria-labels to
make their function clearer to screen readers. The collection and item
type controls need corrected terminology, and the links also need to
have their template filter corrected (html, not uri).

To test, apply the patch and perform a catalog search in the OPAC.

- Test that the "Show more" and "Show less" links in the facets sidebar
  work correctly to expand and collapse the lists of facets.
- It's not necessary to test with a screen reader. You can view the
  source to confirm the markup on the "Show more collections" and "Show
  more item types" links.

  Before:
  Show
more

  After:
  Show more

Signed-off-by: Lucas Gass 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

--- Comment #10 from Owen Leonard  ---
Created attachment 161116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161116&action=edit
Bug 35597: Log creation on suggestion from staff or OPAC

To test:
1. Apply patch, restart services, updatedatabase
2. Search for the system preference 'SuggestionsLog', it should be off.
   Turn it on.
3. Create a purhase suggestion
4. Go to Tools > Log viewer. In modules check 'Suggestions'
5. You should see your newly created suggestion.
6. Create a suggestion from the OPAC.
7. You should see your newly created OPAC suggestion.
8. Modify the suggestion and check the logs again, the modification
   should be logged.
9. Delete the suggestion, the deletion should be logged.
10. Do a purchase suggestion via the OPAC.
11  Check the logs to see the newly created suggestion, the interface
should be OPAC.
12. Turn off SuggestionsLog
13. No changes of any kind should be logged.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

Owen Leonard  changed:

   What|Removed |Added

 Attachment #160265|0   |1
is obsolete||
 Attachment #161114|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 161115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161115&action=edit
Bug 35597: logaction when modifying or deleteing suggestions

To test:
1. Apply patch, restart services, updatedatabase
2. Search for the system preference 'SuggestionsLog', it should be off.
   Turn it on.
3. Create a purhase suggestion
4. Go to Tools > Log viewer. In modules check 'Suggestions'
5. You should see your newly created suggestion.
6. Modify the suggestion and check the logs again, the modification
   should be logged.
7. Delete the suggestion, the deletion should be logged.
8. Do a purchase suggestion via the OPAC.
9. Check the logs to see the newly created suggestion, the interface
   should be OPAC.
10. Turn of SuggestionsLog
11. No changes of any kind should be logged.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058

Owen Leonard  changed:

   What|Removed |Added

 Depends on||34913

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17507] Can upload the same .koc file twice

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17507

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #5 from Marie-Luce Laflamme  ---
We had an incident this year, where the same .koc file was uploaded again, just
three days after the first one. Unfortunately, this caused a bit of a mess in
the 'old_issues' table.
For example, I've spotted loans where the 'old_issues.returndate' (2023-12-08
10:23:49) seems to be time-travelling back before the 'issuedate' (2023-12-08
12:40:08).

Is there a way to prevent multiple uploads of the same file?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

--- Comment #8 from Lucas Gass  ---
Created attachment 161114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161114&action=edit
Bug 35597: Log creation on suggestion from staff or OPAC

To test:
1. Apply patch, restart services, updatedatabase
2. Search for the system preference 'SuggestionsLog', it should be off. Turn it
on.
3. Create a purhase suggestion
4. Go to Tools > Log viewer. In modules check 'Suggestions'
5. You should see your newly created suggestion.
6. Create a suggestion from the OPAC.
7. You should see your newly created OPAC suggestion.
8. Modify the suggestion and check the logs again, the modification should be
logged.
9. Delete the suggestion, the deletion should be logged.
10. Do a purchase suggestion via the OPAC.
11. Check the logs to see the newly created suggestion, the interface should be
OPAC.
12. Turn off SuggestionsLog
13. No changes of any kind should be logged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35597] Purchase Suggestion changes aren't logged

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058

Owen Leonard  changed:

   What|Removed |Added

 Attachment #119321|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058

Owen Leonard  changed:

   What|Removed |Added

 Attachment #119165|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33230] allowlist for SIP fields sent

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33230

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
Even better would be the ability to specify this in the SIP user's interface

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

--- Comment #9 from Victor Grousset/tuxayo  ---
> On the other hand, I do have the corrected behavior after applying my patch

yes, I never seen an issue with your patch.

It's the part of step 5 of the original test plan «and if you save "0" price
will be set»
I never see that initial issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25843] Add REST API route for patron information update requests

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25843

--- Comment #1 from Martin Renvoize  ---
This came up in conversation here today too.. it would be nice to have API's
for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25843] Add REST API route for patron information update requests

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25843

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15725] Separate permission for merging records

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15725

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21555] Merging Patrons allows for all patrons to be selected

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30303] Add ability to select which values to retain when merging patrons

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30303

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #3 from Rebecca Coert  ---
This would be very useful, especially if the Registration Date field was
included.  I often merge newer accounts (with the correct information) for
users that have returned, but have an old/expired account.  It would be nice to
keep their original registration date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35220] Merging patrons can cause lock timeouts

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35220

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35830] New: Add separate permission for Merging Patrons

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35830

Bug ID: 35830
   Summary: Add separate permission for Merging Patrons
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rco...@arlingtonva.us
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently, the ability to Merge Patrons is lumped under the "Add, modify, and
view patron information" (edit_borrowers).  Merging patron records is more
powerful than the ability to add/modify/view a patron record. 

My request is to have this as a separate permission, similar to that of
delete_borrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35829] Codename for 24.05

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35829

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Owen Leonard  changed:

   What|Removed |Added

 Attachment #161112|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 161113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161113&action=edit
Bug 35535: Allow for cancellation of holds with or without a reason

TO TEST:
1. APPLY PATCH
2. Have at least 1 HOLD_CANCELLATION auth value.
3. Check in a waiting hold and make sure you can cancel a hold when
   selecting the reason.
4. Also try a cancelling this hold without giving a reason.
5. Delete all HOLD_CANCELLATION auth values.
6. Try checking in another hold, there should be no dropdown for
   choosing a reason.
7. The hold should cancel.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #7 from Emily Lamancusa  ---
Multi-select in reports would be awesome!

This bug adding List parameters might be a good reference for processing the
multi-select parameters:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 (The
list-specific code is currently in Koha/Report.pm, lines 172-183 / near the end
of prep_report()) I'm not sure if a list passes the parameters in exactly the
same way as a multi-select drop-down, but hopefully that's a helpful starting
point?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161072|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 161112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161112&action=edit
Bug 35535: Allow for cancellation of holds with or without a reason

TO TEST:
1. APPLY PATCH
2. Have at least 1 HOLD_CANCELLATION auth value.
3. Check in a waiting hold and make sure you can cancel a hold when selecting
the reason.
4. Also try a cancelling this hold without giving a reason.
5. Delete all HOLD_CANCELLATION auth values.
6. Try checking in another hold, there should be no dropdown for choosing a
reason.
7. The hold should cancel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33961] In-built Offline circulation tool no longer working and should be removed

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33961

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||Caroline Cyr La Rose
contact||
 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/815

--- Comment #11 from Caroline Cyr La Rose  ---
In accordance with the "one manual (to rule them all)", I only added a bunch of
notes to indicate that this was deprecated, rather than removing the section.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

--- Comment #6 from Lucas Gass  ---
(In reply to David Nind from comment #5)
> With the patch applied and no values in HOLD_CANCELLATION authorized value,
> when I go to cancel the hold:
> - There is no cancellation reason dropdown list before the cancel hold button
> - I can't escape out of the pop-up modal window

Thanks David, it looks like that happens with or without the patch but let's
fix it all here. New patch incoming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

--- Comment #2 from Kyle M Hall  ---
(In reply to Andreas Jonsson from comment #1)
> Created RFC:
> https://wiki.koha-community.org/wiki/
> Optimize_holds_queue_building_using_the_Hungarian_Algorithm

This all looks really great but I'm worried about:

Items that cannot be assigned to fill any current hold and holds that cannot be
filled by any available item should have been sorted out before applying the
algorithm, so there must be at least one item that can be assigned to one hold,
and it would be unsatisfying if the algorithm failed to produce any allowed
item assignment at all.

I think the implication here is we must find the holdabilty of each item for
each hold before we assign items to holds. I think that makes our current
greedy algorithm at worst compares the first hold to all items, the second hold
to all items less one, the third hold to all items less two and so forth. I
tried to write the big O for these and mangled them so bad I thought it best to
leave them out :)

If I am correct about this, I think we need to retain the option to use the
greedy algorithm. Did I miss something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35829] Codename for 24.05

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35829

--- Comment #1 from Martin Renvoize  ---
Henriette (as in https://www.loc.gov/loc/lcib/0605/avram.html) came out as a
popular vote at the community meeting above.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35816] Email Notification Alert for Purchase Suggestion don’t properly work

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35816

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Magnus Enger  ---
(In reply to Jimmy from comment #0)
> Staff always received a “New Purchase Suggestion Email” notice from the same
> record every exchange status to “Accepted” and “In-Ordered”. The notice for
> “New Purchase Suggestion Email’ should be received once after patron submits
> the purchase suggestion form.

Which version are you using? I think we are seeing the same problem on Koha
22.11.12. Looks like suggestions are generating too many messages, and messages
of the wrong kind.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35829] New: Codename for 24.05

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35829

Bug ID: 35829
   Summary: Codename for 24.05
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

In bug 35504 I proposed that we add a codename to this cycle's release to
celebrate our first female release manager coming into role.

At our general meeting on 17 January we opted to open a bug to discus
proposals.. I think we all think it's a good idea to mark this cycle :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35810] Add back to top button on staff result page

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810

Owen Leonard  changed:

   What|Removed |Added

 Attachment #161034|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 16
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16&action=edit
Bug 35810: Add back to top button to staff result page

Test plan:

1) Apply this patch and rebuild css with 'yarn build'
2) Perform a search from catalogue
3) Scroll down to see the button appear and scroll up to see it
   disappear

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35810] Add back to top button on staff result page

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35812] Should specify canonical URLs to help search indexers

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35812

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #154999|0   |1
is obsolete||

--- Comment #27 from Pedro Amorim  ---
Created attachment 161110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161110&action=edit
Bug 34431: (QA follow-up) Fix duplicate backend options

Prevent adding backend option if the option already exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #154410|0   |1
is obsolete||

--- Comment #26 from Pedro Amorim  ---
Created attachment 161109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161109&action=edit
Bug 34431: Add status and status_alias filters to clear

Signed-off-by: Stephen Graham 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #154409|0   |1
is obsolete||

--- Comment #25 from Pedro Amorim  ---
Created attachment 161108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161108&action=edit
Bug 34431: Update tests

Signed-off-by: Stephen Graham 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #154408|0   |1
is obsolete||

--- Comment #24 from Pedro Amorim  ---
Created attachment 161107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161107&action=edit
Bug 34431: Add a status_alias filter input, if any status_alias exist

This patch also makes it so that the status input filter is enabled by default,
and shows all existing statuses by default, or all existing statuses for a
specific backend, if and when selected.

Signed-off-by: Stephen Graham 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #154407|0   |1
is obsolete||

--- Comment #23 from Pedro Amorim  ---
Created attachment 161106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161106&action=edit
Bug 34431: Show both status and status_alias - if exists - in table column

Signed-off-by: Stephen Graham 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #154406|0   |1
is obsolete||

--- Comment #22 from Pedro Amorim  ---
Created attachment 161105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161105&action=edit
Bug 34431: Allow for x-koha-embed in ill/backends endpoint

Signed-off-by: Stephen Graham 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >