[Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting)

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535

Brenda  changed:

   What|Removed |Added

 CC||bow...@washoecounty.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35853] New: "Thankyou" all one word in English language defaults for TICKET notices

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35853

Bug ID: 35853
   Summary: "Thankyou" all one word in English language defaults
for TICKET notices
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ephettepl...@cca.edu
QA Contact: testo...@bugs.koha-community.org

The English language "TICKET_*" notices for the recent feature Catalog Concerns
all spell "Thank you" without a space between the two words as "Thankyou". I
searched for "thankyou" in the code base and see the misspelling here in a db
revision:
https://github.com/Koha-Community/Koha/blob/b54da05c73c9ea5b04d3552b34fcc636b0a71851/installer/data/mysql/db_revs/221200010.pl#L97

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #82 from Lucas Gass  ---
This needs to be BLOCKED until Bug 35840 moves.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Blocks||16122


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122
[Bug 16122] Item record needs to keep local use count
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Depends on||35840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840
[Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn
and statistical patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #11 from Lucas Gass  ---
This one needs to go 'In discussion'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #10 from Lucas Gass  ---
> Are you saying it should add 2 entries to the stats table if a checked out
> item is checked out to the stats patron? 1 for localuse and 1 for a return?
> Seems like it should be one or the other, not both.

Im 2nd guessing now. I'm thinking that if it actually does a return it should
be logged as such but NOT logged as a localuse.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #9 from Lucas Gass  ---
(In reply to Emily Lamancusa from comment #8)
> Works for me! Just one tweak to line 2476:
> 
> - }) unless $localuse;
> + }) unless ( $localuse && $stat_type eq 'localuse' );
> 
> Otherwise, when there is an actual return, it skips logging that, too.

Are you saying it should add 2 entries to the stats table if a checked out item
is checked out to the stats patron? 1 for localuse and 1 for a return? Seems
like it should be one or the other, not both.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25835] Include overdue report (under circulation module) as a staff permission

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25835

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32551] API requests don't carry language related information

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32551

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #12 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35567] Host-item in "Show analytics" link can be translated

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35567

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #7 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35686] Case missing from installer step 3 template title

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35686

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Lucas Gass  ---
Merge conflicts with 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #11 from Lucas Gass  ---
Quite a few merge conflicts with 23.05.x, no backport. If needed please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35650] 'Check the logs' string dot-inconsistent

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35650

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
Doesn't apply cleanly to 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Brendan Lawlor  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #160995|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

--- Comment #9 from Brendan Lawlor  ---
Created attachment 161224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161224=edit
Bug 35746: Add multiselect to report dropdowns

This work in progress patch adds the ability to use multi select in report
dropdowns.

It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>

Currently this works but fails qa scripts because of some forbidden regex

Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <<<>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
 WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #64 from Emily Lamancusa  
---
I'll take a look at this early next week. I think I can get others from MCPL to
test too - we have bibs with hundreds of items, and would definitely like to
see performance improvements on that move forward!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972

--- Comment #6 from Emily Lamancusa  ---
Thanks for testing, David!

It looks like returns.pl is using GetOtherReserves to initiate the item
transfer (i.e. add it to the branchtransfers table) - but not to put the hold
into the Transit status. In fact, GetOtherReserves doesn't even try to put the
hold into the Transit status.

returns.pl already imports ModItemTransfer...why not trigger the item transfer
directly when confirming the hold? (Notably, the current code calls
GetOtherReserves both before and after prompting the user to confirm the
transfer, so it's initiating a transfer before confirming whether it should!)

I still think the way to go is remove side effects from GetOtherReserves, and
have returns.pl initiate the transfer directly (at the correct time). I'll work
on a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #8 from Emily Lamancusa  ---
Works for me! Just one tweak to line 2476:

- }) unless $localuse;
+ }) unless ( $localuse && $stat_type eq 'localuse' );

Otherwise, when there is an actual return, it skips logging that, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35713] Remove debian/docs/LEEME.Debian

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35713

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35757] Sushi service and counter registry tests are failing

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35757

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED
 CC||lu...@bywatersolutions.com

--- Comment #13 from Lucas Gass  ---
Not needed in 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 CC||lu...@bywatersolutions.com

--- Comment #22 from Lucas Gass  ---
Missing dependencies for 23.05.x, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35598] selenium/authentication_2fa.t is still failing randomly

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35598

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.02   |24.05.00,23.11.02,23.05.08
released in||

--- Comment #12 from Lucas Gass  ---
Backported to 23.05.x for upcoming 23.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #7 from Lucas Gass  ---
(In reply to Emily Lamancusa from comment #5)
> Hmmm...looking at the patch from 27992, all of the checking for holds,
> recalls, return claims, and lost or withdrawn statuses is based on the
> return values from AddReturn. So avoiding the call when the item isn't
> checked out would undo a lot of the functionality for 27992. (I did a quick
> test on master and confirmed this.) Wouldn't it be better to skip logging
> the local use in CanBookBeIssued if RecordLocalUseOnReturn is enabled
> (probably with a comment in the code that it is being skipped because
> AddReturn will log the local use in that case)?
> 
> Either way, this is also going to need a unit test. :)

Maybe this? If you like this better I'll write a unit test. Let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161217|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 161223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161223=edit
Bug 35840: Fix Local use being double-counted in CanBookBeIssued

To test:
1. APPLY PATCH, restart_all
2. Turn on RecordLocalUseOnReturn
3. Create a Statistical patron.
4. Check an item out to a regular patron.
5. Check the item out to a Statistical patron.
6. This should trigger a return and you will see 2 entries in the statistics
table, one for localuse and one for a return.
7. Try checking out an item to the Stats patron that is NOT checked out.
8. You should only see 1 entry, localuse, in the statistics table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35769] Untranslatable strings when placing holds in staff

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
Testing notes (using koha-testing-docker):

1. Replicate the issue:
   1.1 Install another language: sudo koha-translate --install 
--dev  (sudo koha-translate --install fr-CA --dev kohadev)
   1.2 Enable the language in the staff interface: Administration > System
preferences > I18N/L10N > language > select the language you installed (for
example: Français (fr-CA)) > Save all I18N/L10N...
   1.3 Check the -staff-prog.po file for these phrases (in
misc/translator/po directory) - they are not found:
   - Please select a pickup location for the item
   - Please select a pickup location for this hold
   - Please make sure all selected titles have a pickup location set
   - Please select at least one title
   1.4 Change the staff interface to the language you have installed
   1.5 Perform actions that generate the messages and note that they are in
English:
   - Please make sure all selected titles have a pickup location set: 
 . Perform a search that returns multiple results
 . Select several of the results and then click the 'Place hold' button
 . Enter a patron and for the hold screen make sure the pickup location
is empty, and click 'Place hold'
 . Pop up message is not translated and is still in English
   - Not sure how to generate the other ones

2. Apply the patch.

3. Update the translations: gulp po:update --lang  (gulp
po:update --lang fr-CA) 

4. Compare the strings changed in the patch (see step 1.3), with strings
appearing in -staff-prog.po - they should all now be found in
the file.

5. Add a translation for the strings and remove the "fuzzy" line.

6. Update the language: sudo koha-translate --update  --dev
 (sudo koha-translate --install fr-CA --dev kohadev)

7. Repeat step 1.5 - verify that the translated content is now used.

8. Verify that the translated page works correctly, and that there are no
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35769] Untranslatable strings when placing holds in staff

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769

David Nind  changed:

   What|Removed |Added

 Attachment #161011|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 161222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161222=edit
Bug 35769: Fix untranslatable strings in request.tt

This fixes some strings in the JavaScript part of the
template that were missing from the po files.

This is one way to test:
* Apply patch
* Run gulp po:update --lang 
* Compare strings changed in the patch, with strings
  appearing in -staff-prog.po
* Translate the strings and remove "fuzzy" line
* In k-t-d, run:
  sudo koha-translate --install  --dev 
* Verify that now the translated version of the template contains
  your translated strings
* Verify the translated page works correctly, no errors

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35769] Untranslatable strings when placing holds in staff

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

--- Comment #26 from Victor Grousset/tuxayo  ---
(In reply to Marcel de Rooy from comment #24)
> Hmm ignoring:
> * Commit title does not start with 'Bug X: ' - 613004bd82

It was just "Bug 35687 - " vs "Bug 35687: "

---

Thanks Emily and Marcel for the testing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #161179|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

--- Comment #25 from Victor Grousset/tuxayo  ---
Created attachment 161221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161221=edit
Bug 35687: Upgrade to 23.06.00.013 may fail

There are reports that this update triggers the error Cannot change column
'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1'

Test Plan:
1) Upgrade to post 23.06.00.013
2) Note the failure
3) Apply this patch set
4) Run updatedatabase.pl
5) Update should succeed!

Signed-off-by: Emily Lamancusa 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35386] Add ability to configure renewal branch when not specified in API request

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386

--- Comment #8 from Nick Clemens  ---
(In reply to Tomás Cohen Arazi from comment #5)
> I think decoupling the default from the OPAC would be correct, though. So
> I'd rename the bug.

Renamed


(In reply to Brendan Lawlor from comment #6)
> I think it's a good idea to have the default configurable by the library
> with the setting in addition to being able to use the header so I think this
> is the correct behavior.

Agreed :-)


This should be ready for sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35386] Add ability to configure renewal branch when not specified in API request

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386

--- Comment #7 from Nick Clemens  ---
(In reply to Brendan Lawlor from comment #3)
> When I tested this out I confirmed before the patch the branch recorded for
> the renewal is the API user's homebranch.
> 
> When I applied the patch I noticed the system preference
> RESTAPIRenewalBranch defaults to 'APIRenew' and when I made a post to
> {{base_url}}/api/v1/checkouts/1/renewal
> the branch recorded in the statistics table as 'API Renew' According to the
> test plan it should default to the branch of the api user.

I only see this if I look at the preference before running updatedatabase
If the update has not been run to set the default then the interface will
display the first option in the list

> Also one of the options for RESTAPIRenewalBranch is NULL, which did work to
> record the branch in the statistics as NULL, but I'm not sure if that is an
> intended option.

This was intended to match the OPacRenewalBranch options

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35386] Add ability to configure renewal branch when not specified in API request

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386

Nick Clemens  changed:

   What|Removed |Added

Summary|Renewals via the API are|Add ability to configure
   |recorded using the branch   |renewal branch when not
   |of the API account used |specified in API request

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

--- Comment #4 from Nick Clemens  ---
(In reply to Nick Clemens from comment #0)
> While we should make parts of this atomic, I don't think the entire job
> should succeed or fail on an error. I think we should commit each item, then
> each bib, then continue.

Each item and bib are singular actions - I don't actually think we need any
transactions at this level at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

--- Comment #3 from Nick Clemens  ---
Created attachment 161220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161220=edit
Bug 35165: Tidy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

--- Comment #2 from Nick Clemens  ---
Created attachment 161219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161219=edit
Bug 35165: Do not delete items in a transaction

We are testing the deletion with safe_delete before removing, beyond that I
think the intent
was to delete all of the items, deleting some is better than not deleting any.

To test:
1 - Apply patch, restart all
2 - Submit a batch deletion
3 - Confirm items are deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24956] Add ability to define emergency/override circ rules

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35852] New: Routing list should link to patron

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35852

Bug ID: 35852
   Summary: Routing list should link to patron
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 161218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161218=edit
Routing list with no link to the patron account

It would be nice if the routing list in the serials module would link to the
borrower. Right now the routing list only lists the borrowers name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14216] Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account.

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14216

--- Comment #4 from Katrin Fischer  ---
(In reply to Christopher Brannon from comment #3)
> This is the first I've heard of this notice and NotifyPasswordChange.  When
> was this added?
> 
> Regardless, we need to expand on this to include other important changes to
> the account.

22.11: Bug 25936 - Notify users if their password has changed

I just wanted to update on the second point, a notice for other data makes
sense as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35851] New: Add ability to batch update the fund code on a paid invoice

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35851

Bug ID: 35851
   Summary: Add ability to batch update the fund code on a paid
invoice
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

We had an invoice with a lot of titles on it where they all got paid from the
wrong fund. We had to go to the invoice and use the 'Modify Fund' link to
individually change the fund for all 24 items on the invoice. It would be great
if there was a way to do this in a batch.  Perhaps there could be checkboxes
next to each title on the invoice and a button to do a batch update that would
allow the user to select the fund code to move the items to.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31006] Add ability to make batch changes to order lines in a basket

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31006

--- Comment #4 from Barbara Johnson  ---
+1 

I just ran into this situation.  We made a large order and it accidentally got
applied to the incorrect fund.  Now we have to reopen the basket and use the
'Modify' link to individually change the fund for all 75 items in the basket. 
It would be such a timesaver if there was a way to batch modify the fund.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31006] Add ability to make batch changes to order lines in a basket

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31006

--- Comment #3 from Barbara Johnson  ---
Ignore comment #2 made by me.  I apparently put it on the wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Signed Off  |Failed QA

--- Comment #5 from Emily Lamancusa  ---
Hmmm...looking at the patch from 27992, all of the checking for holds, recalls,
return claims, and lost or withdrawn statuses is based on the return values
from AddReturn. So avoiding the call when the item isn't checked out would undo
a lot of the functionality for 27992. (I did a quick test on master and
confirmed this.) Wouldn't it be better to skip logging the local use in
CanBookBeIssued if RecordLocalUseOnReturn is enabled (probably with a comment
in the code that it is being skipped because AddReturn will log the local use
in that case)?

Either way, this is also going to need a unit test. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27438] Accessibility: Screen Options

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27438

Chris Rowlands  changed:

   What|Removed |Added

 CC||chris.rowlan...@nhs.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35849] Become some patron

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35849

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35849] Become some patron

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35849

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
I agree this could be useful. I also agree it has big privacy implications and
needs to be a feature that can be easily disabled system-wide and have its own
specific permission when in use.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33459] Patrons need messaging preferences for other notices

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33459

--- Comment #1 from Christopher Brannon  ---
Ideally, we might need to consider revamping the preferences a bit.

First, the category messaging defaults should include all notices, including
overdues.  Overdues can still be controlled by triggers and do all the extra
stuff they do, but we should have ALL notices defined in the defaults.

Second, we should decide if multiple formats/methods should be able to be
selected at the same time.  If so, then the system should honor that.  I don't
think the phones honor that at this time.  But we should also have a setting to
determine if these can be all used at once, or if the patron must choose only
one method for each notification or for all notifications.

Third, the patron should have an override setting in the messaging preferences
to use define their own changes.  If switched off, it greys out the changes
(doesn't erase them) and uses the category defaults.  If on, it supersedes the
category defaults.  The only thing they should not be able to override is the
categories setting of allowing multiple formats or only one for each message.

There is also a Main contact method in the patron account which is confusing. 
I think the intent of this setting is to indicate to staff how they would be
preferred to be contacted outside of what is set in the messaging preferences. 
If that is the case, it should be renamed to "Preferred method of contact
outside of notices".  Otherwise, it should be move to the messaging preferences
and serve a more functional role.

Just some ideas.  Maybe too much for this one bug, but we need to move in this
direction, because notifications continue to grow, and we continue to neglect
what staff/patrons have control over.  It is definitely not clear how the
notifications that are not in the preferences are being delivered in general.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161212|0   |1
is obsolete||

--- Comment #4 from Biblibre Sandboxes  ---
Created attachment 161217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161217=edit
Bug 35840: Only AddReturn if item is onloan

To test:
1. APPLY PATCH, restart_all
2. Turn on RecordLocalUseOnReturn
3. Create a Statistical patron.
4. Check an item out to a regular patron.
5. Check the item out to a Statistical patron.
6. This should trigger a return and you will see 2 entries in the statistics
table, one for localuse and one for a return.
7. Try checking out an item to the Stats patron that is NOT checked out.
8. You should only see 1 entry, localuse, in the statistics table.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32137] Use current patron contact info when resending notices

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

Emily Lamancusa  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32137] Use current patron contact info when resending notices

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

Emily Lamancusa  changed:

   What|Removed |Added

Summary|Resend notices with updated |Use current patron contact
   |info|info when resending notices
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14216] Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account.

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14216

--- Comment #3 from Christopher Brannon  ---
This is the first I've heard of this notice and NotifyPasswordChange.  When was
this added?

Regardless, we need to expand on this to include other important changes to the
account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #81 from Lucas Gass  ---
(In reply to Andrew Fuerste-Henry from comment #72)
> When I have RecordLocalUseOnCheckin enabled and check an item out to a
> statistical patron, Local Use for that item goes up by 2. That seems wrong,
> but also doesn't appear to be new, exactly. Without this patch, if I have
> RecordLocalUseOnCheckin enabled and check an item out to a statistical
> patron I get 2 local use lines in statistics. I'm going to file a new bug
> for this issue, I only mention it here because I almost marked this one
> Failed QA thinking it was new behavior rather than old behavior made more
> obvious.

Thanks Andrew! I have added a patch to Bug 35840 in an attempt to fix this
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161211|0   |1
is obsolete||

--- Comment #9 from Biblibre Sandboxes  ---
Created attachment 161216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161216=edit
Bug 30047: Unit tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161210|0   |1
is obsolete||

--- Comment #8 from Biblibre Sandboxes  ---
Created attachment 161215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161215=edit
Bug 30047: Add new heading field to auth_header table

This patch adds a new heading field containing the display form of the
authority record

NOTE: If trying to save an auhority in the 'DEFAULT' framework, you will get an
error, you should not be
using DEFAULT for authorities and we should remove from the list on another bug

To test:
1 - Apply patches
2 - Update database
3 - Restart all
4 - Create a new authority, save.
5 - Do this for various types
6 - View the db records:
SELECT * FROM auth_header\G
7 - Note new heading field is populated correctly
8 - Edit your new authorities
9 - Confirm the heading field is updated correctly
10 - Import some authorities and confirm heading generated correctly
11 - Import auth via Z39.50 and confirm heading generated correctly

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161209|0   |1
is obsolete||

--- Comment #7 from Biblibre Sandboxes  ---
Created attachment 161214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161214=edit
Bug 30047: DO NOT PUSH - Schema updates

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161208|0   |1
is obsolete||

--- Comment #6 from Biblibre Sandboxes  ---
Created attachment 161213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161213=edit
Bug 30047: DB Updates

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #3 from Lucas Gass  ---
Created attachment 161212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161212=edit
Bug 35840: Only AddReturn if item is onloan

To test:
1. APPLY PATCH, restart_all
2. Turn on RecordLocalUseOnReturn
3. Create a Statistical patron.
4. Check an item out to a regular patron.
5. Check the item out to a Statistical patron.
6. This should trigger a return and you will see 2 entries in the statistics
table, one for localuse and one for a return.
7. Try checking out an item to the Stats patron that is NOT checked out.
8. You should only see 1 entry, localuse, in the statistics table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #2 from Lucas Gass  ---
This is due to Bug 27992, which adds a call to AddReturn

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

Lucas Gass  changed:

   What|Removed |Added

 Blocks||35840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840
[Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn
and statistical patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Depends on||27992


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992
[Bug 27992] When recording local use with statistical patron items are not
checked in
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
Summary|Local use is double-counted |Local use is double-counted
   |when using both |when using both
   |RecordLocalUseOnCheckin and |RecordLocalUseOnReturn and
   |statistical patrons |statistical patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

--- Comment #5 from Nick Clemens  ---
Created attachment 161211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161211=edit
Bug 30047: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

--- Comment #4 from Nick Clemens  ---
Created attachment 161210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161210=edit
Bug 30047: Add new heading field to auth_header table

This patch adds a new heading field containing the display form of the
authority record

NOTE: If trying to save an auhority in the 'DEFAULT' framework, you will get an
error, you should not be
using DEFAULT for authorities and we should remove from the list on another bug

To test:
1 - Apply patches
2 - Update database
3 - Restart all
4 - Create a new authority, save.
5 - Do this for various types
6 - View the db records:
SELECT * FROM auth_header\G
7 - Note new heading field is populated correctly
8 - Edit your new authorities
9 - Confirm the heading field is updated correctly
10 - Import some authorities and confirm heading generated correctly
11 - Import auth via Z39.50 and confirm heading generated correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

--- Comment #3 from Nick Clemens  ---
Created attachment 161209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161209=edit
Bug 30047: DO NOT PUSH - Schema updates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

--- Comment #2 from Nick Clemens  ---
Created attachment 161208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161208=edit
Bug 30047: DB Updates

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34070] background_jobs_worker.pl floods logs when not connecting

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34070

--- Comment #5 from Magnus Enger  ---
I had a similar problem today and finally got round to digging a bit deeper
into RabbitMQ. Here are some of the things I found: 

$ sudo rabbitmq-diagnostics check_virtual_hosts
Checking if all vhosts are running on node rabbit@kohaswe ...
Error:
Some virtual hosts on node rabbit@kohaswe are down:
/

$ sudo rabbitmqctl list_queues --offline state name
Timeout: 60.0 seconds ...
Listing queues for vhost / ...
state   name
downkoha_mykoha-batch_authority_record_modification
downkoha_mykoha-batch_item_record_modification
downkoha_mykoha-long_tasks
...

$ sudo rabbitmqctl restart_vhost
Trying to restart vhost '/' on node 'rabbit@kohaswe' ...
Error:
Failed to start vhost '/' on node 'rabbit@kohaswe'Reason: {:shutdown,
{:failed_to_start_child, :rabbit_vhost_process, {:badmatch, {:error,
{{{:badmatch, {:error, {:not_a_dets_file,
'/var/lib/rabbitmq/mnesia/rabbit@kohaswe/msg_stores/vhosts/628WB79CIFDYO9LJI6DKMI09L/recovery.dets'}}},
[{:rabbit_recovery_terms, :open_table, 1, [file:
'src/rabbit_recovery_terms.erl', line: 199]}, {:rabbit_recovery_terms, :init,
1, [file: 'src/rabbit_recovery_terms.erl', line: 179]}, {:gen_server, :init_it,
2, [file: 'gen_server.erl', line: 374]}, {:gen_server, :init_it, 6, [file:
'gen_server.erl', line: 342]}, {:proc_lib, :init_p_do_apply, 3, [file:
'proc_lib.erl', line: 249]}]}, {:child, :undefined, :rabbit_recovery_terms,
{:rabbit_recovery_terms, :start_link, ["/"]}, :transient, 3, :worker,
[:rabbit_recovery_terms]}}

I found a solution to the problem here:
https://stackoverflow.com/questions/58689551/rabbitmq-vhost-is-down-for-user-xyz-even-after-user-has-all-access
and after effectively wiping all the queues, I got things running again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35850


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850
[Bug 35850] Use template wrapper for tabs: Header search forms
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35850] New: Use template wrapper for tabs: Header search forms

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35850

Bug ID: 35850
   Summary: Use template wrapper for tabs: Header search forms
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 32571

Continuing the work of Bug 32571, I would like to update the header search form
include files in the staff client to use the new WRAPPER for tabs


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571
[Bug 32571] Use template wrapper to build tabbed components
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35849] New: Become some patron

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35849

Bug ID: 35849
   Summary: Become some patron
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexander.wag...@desy.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Especially, when configuring stuff that others will acutally use or to
understand an error reported, it comes in handy if one could actually
_become_ the user in question to see exactly what she sees based on
her permissions and settings. (One can of course set up a nubmer of
dummy users for this during installation and peek over her sholder in
production.)

Therefore this proposes a kind of `su - ` functionality for Koha on
the web.

Usually a function like this will required pretty high administrative
rights and it also comes with some implications wrt to privacy. In
real life I usually use such a function pretty rarely and usually with
the patron on the phone. "I do not really understand what you are
seing right now. Mind if I _become_ you to see it as you do?" And
there are even some regulations when I am allowed to do this. Still
during setup of a new system especially if you are new to Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34355] Automated MARC record ordering process

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355

--- Comment #41 from Jessie Zairo  ---
Test Plan
1) Create an sFTP server (1 set up for each unique vendor) and share the
credentials with the vendor who will be sending the test data
2)apply patch
3) navigate to Administration -> Acquisition parameters -> MARC order accounts
4) click New Account
5)Enter the following details
 a) Vendor:
 b) Budget:This budget will be used as the fallback value if the MARC records
do not contain a mapped value for a budget code.
 c)Description:
 d)Download directory:The download directory specifies the directory in your
koha installation that should be searched for new files.
 e)Match field:(Optional): If you have files from multiple vendors in the same
file directory, the match field is the field in the marc record that will be
checked to see if the file should be processed by this account.
 f)Match value: (Optional): This is the value that will be checked against the
match field to see if the file matches this account. If it does it will be
processed by this account, if not it will be skipped.
6) enter File import settings
7) enter Record matching settings
8) select if it should check for embedded item record data
9) click submit
10) drop test file in sFTP server (run manually or have a cron run to pick up
the file)
11) file should load in basket for said vendor and create orders.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35848] New: Update front page for Koha 23.11

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35848

Bug ID: 35848
   Summary: Update front page for Koha 23.11
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: mag...@libriotech.no

It still says "Introducing Koha 23.05".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jacob.om...@ptfs-europe.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35831] Move UpdateItemLocationOnCheckout to Checkout policy section

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35831

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #161120|0   |1
is obsolete||

--- Comment #3 from PTFS Europe Sandboxes  ---
Created attachment 161207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161207=edit
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

Signed-off-by: Aude 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35831] Move UpdateItemLocationOnCheckout to Checkout policy section

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35831

Aude Charillon  changed:

   What|Removed |Added

 CC||aude.charillon@ptfs-europe.
   ||com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Aude Charillon  ---
Works as described: the UpdateItemLocationOnCheckout system preference
disappears from the Checkin policy section and correctly appears in the
Checkout policy one instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4809] Allow to pay lost item replacement fee when changing the lost status

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22740

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4809

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27919] Split claims return from LOST

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33292

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33292] Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27919

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28924] Allow NoIssuesCharge to be determined by patron category

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28924

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||35847


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35847
[Bug 35847] We should consistently display the select options when appropriate
in the patron search modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35847] New: We should consistently display the select options when appropriate in the patron search modal

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35847

Bug ID: 35847
   Summary: We should consistently display the select options when
appropriate in the patron search modal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com,
koha-bugs@lists.koha-community.org,
testo...@bugs.koha-community.org
Depends on: 35329

Bug 35329 comment 64

We currently only give the option to multi-select patrons from a search result
in the patron search modal for the patron card creator flow..  but there are
plenty of other places where one is able to select more than one patron for the
background form.  We should expose the functionality in the modal more
consistently.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
[Bug 35329] Move patron searches to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||35846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35846
[Bug 35846] On wide screens, we should display the patron search results next
to the filters rather than beneath
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35846] New: On wide screens, we should display the patron search results next to the filters rather than beneath

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35846

Bug ID: 35846
   Summary: On wide screens, we should display the patron search
results next to the filters rather than beneath
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com,
koha-bugs@lists.koha-community.org,
testo...@bugs.koha-community.org
Depends on: 35329

Bug 35329 comment 59

Wide screens are becoming more and more prevalent these days.  I think the
modal would be better displayed with a "sidebar" containing the filter form and
the results table to the right of it (more like we have in the various pages of
the UI, but not currently seen in any modals.)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
[Bug 35329] Move patron searches to a modal
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||35845


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35845
[Bug 35845] Add a 'note' or 'success'/'failure' wrapper around action feedback
in patron search modals
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35845] New: Add a 'note' or 'success'/'failure' wrapper around action feedback in patron search modals

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35845

Bug ID: 35845
   Summary: Add a 'note' or 'success'/'failure' wrapper around
action feedback in patron search modals
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 35329

Currently, the feedback given in the patron search modal, saying for example
that a patron was added, is rather hidden away without formatting.

I'd like to see it displayed more prominently within an info box or similar
(like the info div that displays to highlight when a particular search is
filtered on permissions)

Bug 35329 comment 58


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329
[Bug 35329] Move patron searches to a modal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable
 CC||frede...@tamil.fr

--- Comment #17 from Frédéric Demians  ---
Pushed to 22.11.x for 23.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #83 from Martin Renvoize  ---
(In reply to Martin Renvoize from comment #63)
> We should have a message similar to that on the funds ownership search in
> the basket manager search.. we limit that search to users with particular
> permissions too.

OK, I changed my mind on the PQA.. as far as I can tell this is actually a
regression.

We're calling patron_search_js as apposed to patron_search_table as our include
in this case and thus the 'note' divs that display information about the search
limits do not appear in this case.. it appears like they should be.

There's also a mismatch in the filter names.. 'baskets_managers' vs
'orders_managers'.. I think this does need fixing before we go PQA... I had a
quick look and couldn't work out the logic flow here I'm afraid :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >