[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 CC||m.de.r...@rijksmuseum.nl

--- Comment #4 from Marcel de Rooy  ---
Depends on a NSO ? Blocked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #19 from Marcel de Rooy  ---
Apart from discussion, I dont see unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|n...@bywatersolutions.com   |m.de.r...@rijksmuseum.nl

--- Comment #18 from Marcel de Rooy  ---
We should avoid separate tidy patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35165] Batch item deletions are run in a single transaction and cause locking issues

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #161368|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 161480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161480=edit
Bug 35165: Do not delete items in a transaction

We are testing the deletion with safe_delete before removing, beyond that I
think the intent
was to delete all of the items, deleting some is better than not deleting any.

To test:
1 - Apply patch, restart all
2 - Submit a batch deletion
3 - Confirm items are deleted

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation configured using the same IP

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

--- Comment #1 from Jonathan Druart  ---
No idea what this code is supposed to do...

1215 foreach my $br ( keys %$branches ) {
1216 
1217 # now we work with the treatment of ip
1218 my $domain = $branches->{$br}->{'branchip'};
1219 if ( $domain && $ip =~ /^$domain/ ) {
1220 $branchcode =
$branches->{$br}->{'branchcode'};
1221 
1222 # new op dev : add the branchname to the
cookie
1223 $branchname=
$branches->{$br}->{'branchname'};
1224 }
1225 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] New: Incorrect library used when AutoLocation configured using the same IP

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

Bug ID: 35918
   Summary: Incorrect library used when AutoLocation configured
using the same IP
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Staff interface
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If you have AutoLocation turned on and you are using the same IP for different
libraries, the logged in library will be set randomly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Marcel de Rooy  ---
 WARN   installer/data/mysql/db_revs/230600061.pl
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 11)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34886] Regression in when hold button appears

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #34 from Marcel de Rooy  ---
Multiple choice report?
Moving to In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #159520|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 161476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161476=edit
Bug 35445: Require OPAC user to confirm self-registration with button push

This change requires the OPAC user to confirm self-registration with
a button push when verifying registration using an emailed token.

Test plan:
0. Apply the patch and koha-plack --reload kohadev
1. Set syspref PatronSelfRegistrationVerifyByEmail to "Don't require"
2. Create a patron using the self-registration on the OPAC
3. Note that no confirmation step is needed when self-registering
4. Set syspref PatronSelfRegistrationVerifyByEmail to "Require"
5. Create a patron using the self-registration on the OPAC
6. Look in message_queue to find the URL with the token to
visit in the browser
7. Visit that URL
8. Note that the page says "Registration pending" and asks you to
click a button labeled "Confirm"
9. Click the button labeled "Confirm"
10. Note that the self-registration is confirmed and details are
shown on the page

Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30645] Generated DBIC query incorrect for API searches across joined extended attributes when several terms are passed

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #19 from Marcel de Rooy  ---
 WARN   t/db_dependent/selenium/patrons_search.t
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 91,
now: 100)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35128] Move cities to Vue

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35128

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35902] Add English country and language codes as authorised values to be using in cataloguing MARC21 008 builder plugin

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35902

--- Comment #1 from Aleisha Amohia  ---
Created attachment 161475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161475=edit
Bug 35902: [WIP]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32607] Add record sources CRUD

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #161438|0   |1
is obsolete||

--- Comment #64 from Tomás Cohen Arazi  ---
Created attachment 161474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161474=edit
Bug 32607: Add record sources admin page

This patch introduces a Vue.js based record sources managing page. To
test it:

1. Apply this patch
2. Build the Vue.js stuff:
   $ ktd --shell
  k$ yarn js:build
  k$ restart_all
3. On the staff interface, go to Administration > Record sources
4. Play with the interface and the offered actions
=> SUCCESS: Things go well
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32607] Add record sources CRUD

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607

--- Comment #63 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #54)
> You should rebase on top of bug 35329. It should be quite trivial to use the
> modal for the patron search. Let me know if you need help.

I dropped that feature for now. Too much work, too much time already :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35870] Adding an edit_authorities subpermission for editauthorities

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35871] Adding a merge_delete_authorities subpermission for editauthorities

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35871

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35856] Runtime parameter modal should provide option of ":all"

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856

Lucas Gass  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35856] Runtime parameter modal should provide option of ":all"

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #2 from Lucas Gass  ---
Should this be 'Signed-off'? I don't see am attached patch/sign-off line.
Setting this back to NSO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33452] Update patron statistics report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161023|0   |1
is obsolete||

--- Comment #8 from Lucas Gass  ---
Created attachment 161473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161473=edit
Bug 33452: Improve display of applied filters and results table

This makes various improvements on the display of the results:

* Filters didn't display the value that was filtered on
* Filter labels were not translatable
* Results table showed line/column using untranslatable codes
* Results table showed library and patron category codes
  instead of descriptions

To test:
* Use the various filters in the form
* Use various combinations of row/column
* Verify it all works as expected and display is much improved

Note:
* In the filters, the code for extended patron attributs will
  be used as label.
* In the results table only patron category codes and library
  codes translate to descriptions.
  Other values from pull downs haven't been implemented yet.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33452] Update patron statistics report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161022|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 161472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161472=edit
Bug 33452: Update patron statistics search form and result list

This makes changes to terminology, spelling and
capitalization. Terminology used should be the
same as on the normal patron form.

To test:
* Go to Reports > Patrons statistics
* Compare search form before and after patch.
  List of changes:
  * Gender:
* Add option 'Other'
* Change men and women to 'Male' and 'Female'
  * Sort*:
* Labels changed from "Sortx" to "Sort x"
* Note: to see Sort 1 you need to add an AV for bsort1
 * Patron status:
* Options changed to start with a capital letter
* 'Lost' changed to 'Lost card'
 * Patron activity:
* Options changed to start with a capital letter
* 'no active' changed to 'Not active'
 * Patron attributes:
* Switched code and description in label, so description is first
* Do a search, compare result table before and after patch.
  * Added white background (page-section) to results

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33452] Update patron statistics report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161021|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 161471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161471=edit
Bug 33452: Reindent borrowers_stats.tt

This patch only contains whitespace changes, including
switching from tabs to 4 spaces for indenting
consistently.

To test:
* There shoudl be no change in appearance and behavior

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33452] Update patron statistics report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35917] New: Resent notices should be recorded

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35917

Bug ID: 35917
   Summary: Resent notices should be recorded
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

When you mark a notice to be resent, it doesn't not create a new instance in
the list of notices.  It only updates the updated on timestamp, from what I can
tell.  So, no matter how many times you try to resend, it only shows the last
time.

It seems like, for accuracy, it should create a new entry in the list for each
resend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34788] Add the ability to import KBART files to ERM

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
Hi Matt,

I am not terribly familiar with KBART files. I am attempting to test this and
getting a "Something went wrong: SyntaxError: JSON.parse: unexpected character
at line 1 column 1 of the JSON data"

I'm sure this is my file. Do you have a file we can use to test with? 

Other minor things of note: 

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/import_from_kbart_file.inc
   FAIL   valid_template
: filter not found


 FAIL   t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
   FAIL   forbidden patterns
forbidden pattern: tab char (line 84)
forbidden pattern: tab char (line 85)
forbidden pattern: tab char (line 86)
forbidden pattern: tab char (line 124)
forbidden pattern: tab char (line 125)
forbidden pattern: tab char (line 126)
forbidden pattern: tab char (line 212)
forbidden pattern: tab char (line 213)
forbidden pattern: tab char (line 214)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #7 from Lucas Gass  ---
Merge conflicts in holds_table.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

--- Comment #67 from Emily Lamancusa  
---
Feedback from the MCPL staff who looked at the patch:

Inability to sort/filter on status: Front-line staff don't often do this, so
it's not a big deal for them. However, acquisitions staff do need to
sort/filter by item status on bib records pretty frequently. It would be great
if that could be prioritized as a follow-up, even if it's a filter that's more
hard-coded than we'd like with a FIXME for later.

Hiding columns based on whether the first page of results returns data: This
doesn't come up often for us (most columns in our system either always have
data or very rarely have data), though I see how this could potentially be an
issue for other libraries.

Finally, the reload time when changing the sort/filter was also a concern - if
you do multiple sorts/filters on smaller bibs, this can actually increase the
overall loading time. The potential follow-up that was discussed earlier, to
block the Ajax reload when all items are showing, could definitely help with
this, especially on smaller bibs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

--- Comment #66 from Emily Lamancusa  
---
Notes from my testing:
The majority of it seems to be working as it's supposed to. I ran into a few
problems with filtering, though:

1. When using the general "Search" field at the top of the table, the filter
often failed with the error message: “Something went wrong when loading the
table: 500 Internal Server Error”. In this case, the displayed result set
remained unchanged.

- always got the error if "Show entries" was set to a value other than
"All" and I 
  searched for a value that would return 0 results

- always got the error if "Show entries" was set to a value other than
"All" and I 
  searched for a value that exists within the item set but was not showing
on the
  current page

- inconsistently got the error if "Show entries" was set to a value other
than "All"
  and I searched for a value that exists within the items showing on the
current page

- the above behavior would occur even if all of the items were showing
(e.g. bib has
  25 items and the table is set to show 50)

- never got the error if "Show entries" was set to "All", no matter what I
searched


2. If I typed in a value and pressed the "Enter" key, in a case that would
generate the above 500 error, it generated two errors.
   First: “Something went wrong when loading the table: undefined : undefined”
   Then: “Something went wrong when loading the table: 500 Internal Server
Error”
(including this mostly in case it helps with troubleshooting #1)


3. If StaffDetailItemSelection and/or LocalCoverImages is turned off, the
alignment of the drop-down filters for the other columns is offset by 1 for
each of the two sysprefs that is disabled
Example: StaffDetailItemSelection is enabled; LocalCoverImages is disabled.
The first 5 columns are the selection column, Item Type, Current Library, Home
Library, Collection.
Item Type has a text filter instead of a drop-down.
Current Library has a drop-down, but it contains Item Type values (and is thus
useless).
Home Library has a drop-down containing branch names (but this is presumably
still shifted from Current Library)
Collection has a drop-down containing branch names (again, useless)
** If the cover images column is hidden, but not disabled by syspref, the
offset does not occur.

4. The general "Search" bar at the top of the table can only search on AV
codes, not display names (is this intentionally left for follow-up since the
column-specific filters were fixed by adding drop-downs?)

A couple of other minor things that do not need to be blockers:
1. The "Clear filter" button (next to the general "Search" box at the top of
the table) is always disabled

2. Missing space after the transit date: “In transit from Springfield to
Fairfield since 01/25/2024There is an item level hold on this item (priority =
0).”

**Note: I didn't test course reserves, analytics, or host records, as I'm not
familiar with how those work generally in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||35916


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916
[Bug 35916] Purchase suggestions bibliographic filter should be a "contains"
search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35916] Purchase suggestions bibliographic filter should be a "contains" search

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Severity|enhancement |normal
 Depends on||23991


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
[Bug 23991] Move SearchSuggestion to Koha::Suggestions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35916] New: Purchase suggestions bibliographic filter should be a "contains" search

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916

Bug ID: 35916
   Summary: Purchase suggestions bibliographic filter should be a
"contains" search
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Previously, when searching for purchase suggestions, you could search for any
word in the title and it would find it. Now, it only finds the title if it's an
exact match.

To recreate:
1. Create a purchase suggestion with a multi-word title (e.g. one day in
december)
   1.1. Go to Acquisitions > Suggestions > New purchase suggestion
   1.2. Enter a title (e.g. one day in december)
   1.3. Click on Submit your suggestion

2. Search for one of the words in the title
   2.1. In the "Filter by" section, click on Bibliographic information
   2.2. In the title field, enter one of the words of the title (e.g. december)
   2.3. Click Go
   --> No results

I only tested with the title and the author, but I think it's valid for all
bibliographic elements.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Michelle Spinney  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #161462|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 161470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161470=edit
Bug 35912: Corretc field name form itemprice to price in addorderiso2709
template

To test:
Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Select the biblio
Note items do no have prices
Cancel
Apply patch
Add to basket from file again
Note prices, and other fields, come through as expected

Signed-off-by: Michelle Spinney 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

--- Comment #5 from Lucas Gass  ---
Created attachment 161469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161469=edit
Bug 23296: Set patron branchcode when preparing non-digest version

To test:
1. APPLY PATCH
2. Set up circ rules to allow for auto renewals.
3. Set AutoRenewalNotices to 'according to message prefs'
4. Make a branch specific version of the the AUTO_RENEWAL notice.
5. Find a patron belonging to that branch and set the message prefs to allow
for a AUTO_RENEWAL. But no digest option!
6. Check some things out and make sure they are eligble for auto renewal.
7. Run the cron.
8. Make sure the patron gets the branch specific notice.
9. Delete the branch specific notice.
10. DO 6-7 again.
11. Make sure they now get the all library notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

--- Comment #4 from Lucas Gass  ---
I think this should be consistent with the behavior of the digest version of
the notice. So we should send the notice based on the patron's branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Lucas Gass  changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |lu...@bywatersolutions.com
   Severity|enhancement |normal
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33452] Update patron statistics report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452

--- Comment #5 from Katrin Fischer  ---
Hi Brendan, thanks for testing! As this already includes a lot of different
changes, I think it would make it a little easier to put any additional ones
into a separate bug report that is dependent on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457

--- Comment #2 from Katrin Fischer  ---
Maybe "Notifications"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #161466|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 161468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161468=edit
Bug 35892: Populate order price using GetMarcPrice if no price specified

Previously this happened after the fact, automagically, if no price was
included in the order record. We should
rather load the Marc price into the order form if we don't have a price form
the '...ToOrder' system preferences

To test:

Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Note that item prices are populated as '6.50' from 949$g
Cancel
Update MarcFieldsToOrder and map price to "020$c"
Add to basket from the staged file
Note the price is not populated, because 020$c contains a dollar sign
Cancel
Apply patch, restart all
Add to basket from the staged file
Note the price is now correctly populated from fallback to GetMarcPrice

Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own
doesn't work - this could be done to fields in
MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement.
This bug simply restores the previous behavious, but does it on the front end
and is more obvious to the user

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35915] Add URL encoding to status tabs in purchase suggestions management

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35915

--- Comment #2 from Caroline Cyr La Rose  ---
If someone stumbled upon this and needs to correct their suggestions:

Changing the authorized value (this can be done via the staff interface under
Administration > Authorized values > SUGGEST_STATUS):

UPDATE authorised_values SET authorised_value = 'SPACELESS_STATUS' WHERE
category  = 'SUGGEST_STATUS' AND authorised_value = 'Old status';


Changing the suggestions themselves (this must be done in the db):

UPDATE suggestions SET STATUS = 'SPACELESS_STATUS' WHERE STATUS = 'Old status';


If you had notices linked to that status (this must be done in the db also):

UPDATE letter SET code = 'SPACELESS_STATUS' WHERE code = 'Old status';

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35915] Add URL encoding to status tabs in purchase suggestions management

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35915

--- Comment #1 from Caroline Cyr La Rose  ---
I added a note in the manual, but like I said, you can write it everywhere,
there is still someone who will do it...

https://gitlab.com/koha-community/koha-manual/-/merge_requests/827

A major problem with this is that users cannot correct this by themselves if
they make the error. You must go into the database and update the value of
suggestions.STATUS.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30987] Adding relationship to PatronQuickAddFields causes it to be added 2x

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30987

--- Comment #3 from Lucas Gass  ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35915] New: Add URL encoding to status tabs in purchase suggestions management

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35915

Bug ID: 35915
   Summary: Add URL encoding to status tabs in purchase
suggestions management
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

If users add custom suggestion statuses in the SUGGEST_STATUS authorized values
and the value has spaces (or probably any other weird character), the tab in
the suggestions management page becomes unclickable/inaccessible.

To recreate:
1. Add a custom suggestion status with a space in the authorized value (e.g.
"En analyse")
   1.1. Go to Adminsitration > Authorized values > SUGGEST_STATUS
   1.2. Click Add new authorized value
   1.3. Fill out the form
- Authorized value: term with a space (e.g. "En analyse")
- Description: description (e.g. "En analyse")
   1.4. Click Save

2. Create two suggestions
   2.1. Go to Acquisitions > Suggestions
   2.2. Click New purchase suggestion
   2.3. Fill out the form (with whatever)
   2.4. Click Submit your suggestion
   2.5. Redo steps 2.2 to 2.4 for the second suggestion

3. Change the status of one of the suggestion to the custom status
   3.1. Check the box next to one of the suggestion
   3.2. At the bottom of the page, under Mark selected as, choose the custom
status
   3.3. Click Submit

4. Try to access the custom status tab
   --> Nothing happens

If you look at the URL it's trying to access it's "suggestion.pl#En
analyse_panel" with the space instead of %20. I don't know if that's the
blocking element, but it looks suspicious...

Now, I know some of you are going to say "Just don't put spaces in the
authorized value!" But even though I repeat it ALL the time and wrote it in RED
in our FAQ, users are gonna use... So either we make it impossible to enter
spaces in authorized values (I don't think that's a good idea, as some
categories might require spaces, such as categories to fill out marc fields),
or we make it so that Koha doesn't break if there is a space...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35456] The fine will not be displayed. And even if the expired book is not handed over, it will show as a checked out book.

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35456

--- Comment #6 from Katrin Fischer  ---
In the overdues or overdues with fines report the actual fine never shows. The
price column there is meant for the price of the book.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

--- Comment #40 from Brendan Lawlor  ---
I tried to test this, but I can't figure out how to format the query for the
biblios endpoint. I can only make queries with the path parameters.

Is there an example of what to put in the body of the request?

I tried like this but get 500 error:

curl --location --request GET 'http://localhost:8081/api/v1/biblios' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer ...' \
--data '{
"_page": 1,
"_per_page": 10,
"_match": "contains",
"_order_by": [],
"q": ["array", "of", "strings"]
}'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

--- Comment #5 from Caroline Cyr La Rose  ---
I meant in the staff interface, in the patron's account in the Suggestions tab.

There is a discussion about seeing the archived suggestions in the OPAC in
another bug (bug 27635).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

--- Comment #4 from Katrin Fischer  ---
Or do you mean only in staff? Maybe a checkbox "show archived" would be nice
then in case they come to ask about already archived ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

--- Comment #3 from Katrin Fischer  ---
Hm, as patrons can't archive suggestions themselves it would make sense to me
that they can see all suggestions they made and the status of them. I assumed
archiving was for staff to have a means to reduce the number of suggestions in
queues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35914] New: Add permission for changing a user password

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35914

Bug ID: 35914
   Summary: Add permission for changing a user password
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There are situations where libraries do not want staff to be able to change a
patron's password using the Change Password button but there is currently no
way to split out permission to block this.  You have to turn off the ability to
view/edit all patron info which is also not helpful.

Some libraries prefer that staff either send a password reset email, or direct
patrons to the OPAC to reset a password.

It would be a great enhancement to add a subpermission to BORROWERS to
allow/disallow the ability for staff to change a patron password.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

--- Comment #2 from Nick Clemens  ---
Created attachment 161467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161467=edit
Test order file

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35892


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892
[Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

Nick Clemens  changed:

   What|Removed |Added

 Depends on||35913


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913
[Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set
by MarcItemFieldsToOrder
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

--- Comment #1 from Nick Clemens  ---
Created attachment 161466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161466=edit
Bug 35892: Populate order price using GetMarcPrice if no price specified

Previously this happened after the fact, automagically, if no price was
included in the order record. We should
rather load the Marc price into the order form if we don't have a price form
the '...ToOrder' system preferences

To test:

Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Note that item prices are populated as '6.50' from 949$g
Cancel
Update MarcFieldsToOrder and map price to "020$c"
Add to basket from the staged file
Note the price is not populated, because 020$c contains a dollar sign
Cancel
Apply patch, restart all
Add to basket from the staged file
Note the price is now correctly populated from fallback to GetMarcPrice

Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own
doesn't work - this could be done to fields in
MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement.
This bug simply restores the previous behavious, but does it on the front end
and is more obvious to the user

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_23_11_candidate
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Certainly a bad rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

--- Comment #2 from Nick Clemens  ---
Created attachment 161465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161465=edit
Test order file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

--- Comment #1 from Nick Clemens  ---
Created attachment 161464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161464=edit
Bug 35913 - Restore price fall back to MarcFieldsToOrder if not set by
MarcItemFieldsToOrder

To test:
Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Select the biblio
Note items have prices
Cancel
Remove 'price' mapping from MarcItemFieldsToOrder
Apply patch
Add to basket from file again
Note item prices, and other fields, come through as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35913


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913
[Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set
by MarcItemFieldsToOrder
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35170] Make long overdue item type options configurable in interface

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35170

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35913


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913
[Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set
by MarcItemFieldsToOrder
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||35170, 35912


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35170
[Bug 35170] Make long overdue item type options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912
[Bug 35912] Item prices not populating order form when adding to a basket from
a staged file
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35913] New: Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35913

Bug ID: 35913
   Summary: Item order prices do not fall back to
MarcFieldsToOrder if not set by MarcItemFieldsToOrder
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 33170 removed a fallback to the order level price when an item level price
was not found in MarcItemFields To order

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35444] Add easy way to retrieve a logged in user's categorycode

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35444

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35351] Adjust basket details template to avoid showing empty page-section

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35351

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35564] Add homebranch column to holds queue report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35564

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35397] SIP2AddOpacMessagesToScreenMessage syspref description issue

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35397

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35576] Make hq-callnumber column easier to customize when viewing the holds queue report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35576

Emily Lamancusa  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35892


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892
[Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35892] Fallback to GetMarcPrice in addorderiso2907 no longer works

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35892

Nick Clemens  changed:

   What|Removed |Added

 Depends on||35912


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912
[Bug 35912] Item prices not populating order form when adding to a basket from
a staged file
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

--- Comment #2 from Nick Clemens  ---
Created attachment 161463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161463=edit
Test Order file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35912


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912
[Bug 35912] Item prices not populating order form when adding to a basket from
a staged file
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||33170


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170
[Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields
simpler
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

--- Comment #1 from Nick Clemens  ---
Created attachment 161462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161462=edit
Bug 35912: Corretc field name form itemprice to price in addorderiso2709
template

To test:
Setup -- Set systempreferences below

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

Stage the attached bib-303.marcxml file
Add to basket from the staged file
Select the biblio
Note items do no have prices
Cancel
Apply patch
Add to basket from file again
Note prices, and other fields, come through as expected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35912] New: Item prices not populating order form when adding to a basket from a staged file

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35912

Bug ID: 35912
   Summary: Item prices not populating order form when adding to a
basket from a staged file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 33170 refactored addorderiso2709 to make MarcItemFieldsToOrder easier to
adjust, however, it missed that when listing we renamed 'price' as 'itemprice'
so prices for items are not being populated

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26342] Suspended hold not marked filled when patron checks out item

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26342

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon  ---
I think that if the item being checked out is a suspended hold, it should
prompt staff to ask if the patron wants to retain this hold or cancel it.

I think the self-check should ask as well.  Can this be accomplished through
SIP, or should it just cancel it and send the patron a notification with an
explanation, or ignore it all together (maybe a setting to decide what the
preference is)?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35576] Make hq-callnumber column easier to customize when viewing the holds queue report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35576

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #4 from Emily Lamancusa  ---
Nice quality-of-life improvement! Looks good, QA script is happy. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35902] Add English country and language codes as authorised values to be using in cataloguing MARC21 008 builder plugin

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35902

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35576] Make hq-callnumber column easier to customize when viewing the holds queue report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35576

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #159930|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 161461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161461=edit
Bug 35576: Add classes to hq-callnumber column in holds report

To test:
1. APPLY PATCH
2. Make sure you have item.itemcallnumber data.
3. Have some holds and build the holds queue: perl
/kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl
4. To make testing easier add the following to IntranetUserCSS:
.hq-callnumber .location { background: lightblue; }
.hq-callnumber .itemcallnumber { background: lightgoldenrodyellow; }
5. Run the holds queue and notice that the data in the 'Call number' column has
a lightblue (location) and lightgoldenrodyellow (call number) background.

Signed-off-by: David Nind 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35397] SIP2AddOpacMessagesToScreenMessage syspref description issue

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35397

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35397] SIP2AddOpacMessagesToScreenMessage syspref description issue

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35397

--- Comment #4 from Emily Lamancusa  ---
Good catch - passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35397] SIP2AddOpacMessagesToScreenMessage syspref description issue

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35397

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #159296|0   |1
is obsolete||

--- Comment #3 from Emily Lamancusa  ---
Created attachment 161460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161460=edit
Bug 35397: Fix SIP2AddOpacMessagesToScreenMessage syspref description

The original syspref description contained an extra  '- Use' and reads
weird.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Owen Leonard 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35564] Add homebranch column to holds queue report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35564

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Signed Off  |Passed QA

--- Comment #8 from Emily Lamancusa  ---
Looks good, QA script is happy. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907

--- Comment #6 from Kyle M Hall  ---
Created attachment 161459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161459=edit
Bug 35907: Tidy execute_query

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #161452|0   |1
is obsolete||
 Attachment #161453|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 161458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161458=edit
Bug 35907: Add ability to log all custom report runs with or without query

Because of the way Koha::Logger has been used to log to different categories
based on the interface and caller, it can be extremely hard to log all of a
particular log statement to one place.

For custom report runs, the category is plack-intranet.C4::Reports::Guided when
run from the web interface, cron.C4::Reports::Guided when run from
runreport.pl, and plack-intranet.C4::Auth when run from svc/report.

We should add a more standardized report run log, both with and without the
full query, so that administrators can log all report runs to a centralized
location. If an administrator were to need the "point of entry" for reports, it
is easy to include via parameters in PatternLayout.

Test Plan:
1) Apply this patch
2) Modify your log4perl file, add the following:

log4perl.logger.reports.execute.time = INFO, REPORTTIME
log4perl.appender.REPORTTIME=Log::Log4perl::Appender::File
log4perl.appender.REPORTTIME.filename=/tmp/report-time.log
log4perl.appender.REPORTTIME.mode=append
log4perl.appender.REPORTTIME.layout=PatternLayout
log4perl.appender.REPORTTIME.layout.ConversionPattern=[%d] [%p] [%P] %m%n
log4perl.appender.REPORTTIME.utf8=1

log4perl.logger.reports.execute.query = INFO, REPORTQUERY
log4perl.appender.REPORTQUERY=Log::Log4perl::Appender::File
log4perl.appender.REPORTQUERY.filename=/tmp/report-query.log
log4perl.appender.REPORTQUERY.mode=append
log4perl.appender.REPORTQUERY.layout=PatternLayout
log4perl.appender.REPORTQUERY.layout.ConversionPattern=[%d] [%p] [%P] %m%n
log4perl.appender.REPORTQUERY.utf8=1

3) Restart all the things!
4) Run a report somehow:
   CLI: ./misc/cronjobs/runreport.pl 1
   API: /cgi-bin/koha/svc/report?id=1
   Web: /cgi-bin/koha/reports/guided_reports.pl?reports=1=Run this report
5) Note the report runs are logged to /tmp/report-time.log and
/tmp/report-query.log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35564] Add homebranch column to holds queue report

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35564

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #159845|0   |1
is obsolete||

--- Comment #7 from Emily Lamancusa  ---
Created attachment 161457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161457=edit
Bug 35564: Add homebranch to the holds queue report

To test:
1 - Place some holds in your system
2 - perl misc/cronjobs/holds/build_holdsqueue.pl
3 - View the holds queue
4 - Note there is no holding branch column
5 - APPLY PATCH
6 - Reload and try again
7 - Note the column is not there
8 - Click column setting gear to expose the column
9 - Go to Admin -> Table settings and make sure you can expose the column via
Table settings

Signed-off-by: Michelle 
Signed-off-by: Brendan Lawlor 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

--- Comment #2 from Caroline Cyr La Rose  ---
And if it was intended to show them, could we add a filter? I would hide the
archived suggestions by default and have a filter "Show archived suggestions",
but that might change the current (unwanted in my case) behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

--- Comment #1 from Caroline Cyr La Rose  ---
If it was intended to show them, could we at least make them greyed out?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||35911


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911
[Bug 35911] Archived suggestions show in patron's account
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||23991


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
[Bug 23991] Move SearchSuggestion to Koha::Suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35911] New: Archived suggestions show in patron's account

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911

Bug ID: 35911
   Summary: Archived suggestions show in patron's account
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I don't know if this was meant as an enhancement or it's a regression, but
since 22.11, archived suggestions show in the patron's "Suggestions" tab in the
staff interface. 

It has been reported by many of our clients as a bug, so if it was intended,
maybe we should add a syspref to hide them?

To recreate:
1. Go to a patron's account in the staff interface
2. Go to the Suggestions tab
3. Click New purchase suggestion and create a suggestion
4. In another browser tab, go to Acquisitions > Suggestions
5. Click the small arrow next to the edit button to the right of the
suggestion, and choose Archive (alternatively, check the suggestion's box and
click Archive selected)
   --> Suggestion disappears from the suggestions management page (OK)
6. Go back to the tab with the patron's account and refresh
   --> Suggestion is still visible

Prior to 22.11, archived suggestions were not visible in the patron's account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Signed Off  |Passed QA

--- Comment #9 from Emily Lamancusa  ---
Looks good, QA script is happy. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging

2024-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #159590|0   |1
is obsolete||

--- Comment #8 from Emily Lamancusa  ---
Created attachment 161456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161456=edit
Bug 35034: Add parameter that links titles to their records

To recreate:
1.  Select two items from the catalog and begin a merge.
2. Notice that the title of the items, their biblionumber and a
   hyperlink to their MARC record is available.
3. Apply the patch and refresh the page. The biblionumber for each title
   is now hyperlinked and leads to the item’s bib records.
4. Sign off and have a great day :)

Signed-off-by: Owen Leonard 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >