[Koha-bugs] [Bug 35988] New: Record of deleted item not recorded in action logs even if record wasn't deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35988 Bug ID: 35988 Summary: Record of deleted item not recorded in action logs even if record wasn't deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Created attachment 161736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161736&action=edit Screenshot of object column for deleted items. When an item is deleted, it shows in the action logs that "Item number was deleted from Bibliographic record " There is no indication of which bibliographic record the item was attached to, even when the record still exists. Both links are useless as the items have been deleted the bibliographic link has no number associated with it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25825] Allow claim return function to be controlled by permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825 Marie-Luce Laflamme changed: What|Removed |Added CC||marie-luce.laflamme@inlibro ||.com --- Comment #7 from Marie-Luce Laflamme --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35987] New: See highlighted items below link broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35987 Bug ID: 35987 Summary: See highlighted items below link broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On circulation.pl and moremember.pl the "see highlighted items below" link goes to #checkouts, but there is no div #checkouts instead of #checkouts_panel -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Sara Porter changed: What|Removed |Added CC||sara.porter@bywatersolution ||s.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34699] add a notforloan_on column in items table to store the date of last notforloan change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34699 Sara Porter changed: What|Removed |Added Status|NEW |RESOLVED CC||sara.porter@bywatersolution ||s.com Resolution|--- |DUPLICATE --- Comment #1 from Sara Porter --- *** This bug has been marked as a duplicate of bug 25667 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Sara Porter changed: What|Removed |Added CC||mathsaby...@gmail.com --- Comment #4 from Sara Porter --- *** Bug 34699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35134] cn_browser.pl pop-up size should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #4 from Phil Ringnalda --- Sizing relative to screen width/height gives reasonable results on a laptop screen (where I'm typically using window size close to screen size), but on a decent size monitor it gets pretty comical. I don't have a monitor quite big enough to catalog in a window that's less than half the screen width, but plenty of people do, which would result in a popup that completely covers the parent window. And since the plugin only displays a fixed number of results, screen height makes it look like a mistake, with two-thirds of the window height just blank. Half the parent window width and the parent window height would eliminate covering the parent window, and give people with more space who need it bigger an easy way to get it: just increase the size of the window you are cataloging in and the popups will be bigger. Makes me wonder what screen height is for a Safari window in VisionOS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161593|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 161735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161735&action=edit Bug 35924: Hide the print checkins button on the checkin screen for patron's who always anonymize Test Plan: 1) Set a patron's privacy to "Never" 2) Check out a few items to a patron 3) Check in one item 4) Note the "Print checkin slip" diplays 3) Apply this patch 4) Check in an item 5) Note the option is now missing 6) Set the patron's privacy to "Forever" or "Default" 7) Check in an item 8) Note the print checkins option is back! Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161592|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 161734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161734&action=edit Bug 35924: Hide the print checkins button on the patron screens for patron's who always anonymize If a patron anonymizes their checkins, the checkin slip cannot retrieve any info to print the checkin slip. We should not show the button in this scenario Test Plan: 1) Set a patron's privacy to "Never" 2) Note the "Print checkin slip" option in the Print button on the patrons toolbar displays 3) Apply this patch 4) Reload the page 5) Note the option is now missing 6) Set the patron's privacy to "Forever" or "Default" 7) Reload the page 8) Note the print checkins option is back! Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35924] The 'checkin slip' button should not be available for patrons whose privacy is set to never
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35924 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161614|0 |1 is obsolete|| --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 161733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161733&action=edit Bug 35840: Add unit tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161613|0 |1 is obsolete|| --- Comment #30 from Andrew Fuerste-Henry --- Created attachment 161732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161732&action=edit Bug 35840: Add option to AddReturn to skip recording of localuse To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35854] Suggestions generate identical messages when edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 S Martin changed: What|Removed |Added CC||smartin@lancasterseminary.e ||du --- Comment #3 from S Martin --- I'm also having this problem. The suggestion accepted message is sent to patrons whenever something in the record is edited. It's also being sent when the suggestion is marked as ordered (the suggestion ordered notice is sent, and the suggestion accepted message is being sent again at the same time.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161559|0 |1 is obsolete|| --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 161731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161731&action=edit Bug 23208: perltidy Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161558|0 |1 is obsolete|| --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 161730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161730&action=edit Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #161557|0 |1 is obsolete|| --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 161729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161729&action=edit Bug 23208: Add system preference HoldRatioDefault Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23208] Built in Holds Ratio Report - default ratio set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23208 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35816] Email Notification Alert for Purchase Suggestion don’t properly work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35816 S Martin changed: What|Removed |Added CC||smartin@lancasterseminary.e ||du -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||andre...@dubcolib.org --- Comment #29 from Andrew Fuerste-Henry --- This looks like maybe it should have been set to Signed Off when Kelly tested it 1/26. As of today, the patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35653] Allow the patron import script to log it's output to the action_logs cron logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Passed QA CC||emily.lamancusa@montgomeryc ||ountymd.gov QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35653] Allow the patron import script to log it's output to the action_logs cron logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653 --- Comment #4 from Emily Lamancusa --- Created attachment 161728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161728&action=edit Bug 35653: (QA follow-up) Perltidy Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35653] Allow the patron import script to log it's output to the action_logs cron logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35653 Emily Lamancusa changed: What|Removed |Added Attachment #160384|0 |1 is obsolete|| --- Comment #3 from Emily Lamancusa --- Created attachment 161727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161727&action=edit Bug 35653: Log import_patroni.pl info to action logs To test: 1. APPLY PATCH 2. Create a CSV file with a few lines that contain at least firstname, surname, cardnumber 3. Turn on "CronjobLog". 4. Run the import patron script. I did this: perl /kohadevbox/koha/misc/import_patrons.pl --file 'test1.csv' --matchpoint cardnumber -c 5. Check the action logs for cronjobs. 6. You should see info. about the import patron script. Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #157134|0 |1 is obsolete|| --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 161726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161726&action=edit Bug 32702: Unit tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #157133|0 |1 is obsolete|| --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 161725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161725&action=edit Bug 32702: Move item status checks to CanItemBeReserved This patch moves item status checks from IsAvailableForItemLevelRequest to CanItemBeReserved. Changes to existing calls highlighted below. Existing Calls for CanItemBeReserved/CanBookBeReserved: Call in Circulation.pm checkHighHolds - previously would have allowed damaged, notforloan, etc items to fill holds CanBookBeRenewed - Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest Call in ILSDI/Services.pm HoldItem - would have allowed placing holds on damaged/notforloan/etc items GetServices - Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest C4/Reserves: What is ItemsAnyAvailableAndNotRestricted used for C4/SIP/ILS/Transaction/Hold.pm: do_hold - would have allowed hold on lost/damaged/etc. Koha/Club/Hold/pm: add - would have allowed etc. Koha/REST/V1/Holds.pm: add - would have allowed ... opac/opac-reserve.pl: Was already combo of CanItemBeReserved and IsAvailableForItemLevelRequest reserve/placerequest: Items would have been filtered on reserve/request.pl by IsAvailableForItemLevelRequest In this case and opac, I believe before this a hold could have been forced with the right parameters Existing Calls for IsAvailableForItemLevelRequest C4/Circulation - see above Call in opac/opac-reserve.pl: Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest Call in reserve/request.pl: Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest To test: 1 - Setup a record with items to have: 1 available item 1 lost item 1 item with positive not for loan status 1 item with negative not for loan status 1 item withdrawn 1 item damaged 1 item not for loan by itemtype 2 - Attempt to place hold on staff and opac and note the statuses 3 - Apply patch 4 - Confirm the statuses have not changed 5 - Attempt to hold lost/damaged/withdrawn/notforloan items via API 6 - You should not be able to place the hold 7 - Attempt to place club holds on these items - it should not be possible 8 - Attempt to place holds via ILSDI - it should not be possible Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] Optionally remove HTML from downloaded reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #21 from George Williams (NEKLS) --- How about switching the "Download" drop-down from a list of options to a checkbox drop-down that allows the user to specify the format and whether or not HTML is stripped from the output. That would be the most granular way of going about it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #32 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #29 from Lucas Gass --- Missing 23.05.x dependencies. No backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35474] Add icon for protected patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #7 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #48 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35651] Toggle for advanced editor should not show to staff without advanced_editor permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35651 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34950] ILS DI Availability is not accurate for items on holds shelf or in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34950 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #9 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35641] Reduce DB calls when performing inventory on a list of barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35641 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #6 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35676] OPAC search results - link for "Check for suggestions" generates a blank page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35772] Double escaping of patron fields in bookings modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35772 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35438] Importing records can create too large transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #23 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] Optionally remove HTML from downloaded reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Remove HTML from downloaded |Optionally remove HTML from |reports |downloaded reports --- Comment #20 from Andrew Fuerste-Henry --- (In reply to George Williams (NEKLS) from comment #19) > I want to reiterate that whether or not the HTML is stripped from a report > when it's downloaded should be optional. Well-reiterated, thank you! Would you prefer a global option for this, or something more granular? As someone who probably never wants to export the HTML, I'd hate to add a to every report download in order to opt for stripping the HTML at that point. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] Remove HTML from downloaded reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #19 from George Williams (NEKLS) --- I want to reiterate that whether or not the HTML is stripped from a report when it's downloaded should be optional. There are times that I actually want the raw HTML output in a downloaded report. Example: I have reports that a library can run and download that has HTML in the output so that the raw HTML can then be cut and pasted into the library's website. If this patch strips all of the HTML tags from -all- downloaded report output, then I'm going to have to re-write those reports to find a new way to create the raw HTML when I actually want the raw HTML output. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35702] Reduce DB calls when performing authorities merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35702 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35086] Koha::SearchEngine::Elasticsearch::Indexer->update_index needs to commit in batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35086 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #25 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] Remove HTML from downloaded reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #18 from Andrew Fuerste-Henry --- It would also be great to have HTML-stipping available in reports run and emailed via the commandline. Martin, is that reasonably easy to add here, or would you rather I file a new bug? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] Remove HTML from downloaded reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920
--- Comment #17 from Andrew Fuerste-Henry ---
Clearly I've doing this too early in the morning. I applied your patches to my
testing docker and then ran my reports on the wrong Koha.
When I follow my test plan correctly, this works!
However, for my test report:
SELECT
biblionumber,
CONCAT('',title,'')
AS Title
from biblio
When I download CSV or ODS formats, the second column contains just the title.
When I download TSV format, the second column contains just the biblionumber
(so the report is two columns of the same data).
It'd be best if all 3 options work the same way. But I'm happy to sign off on
this and pursue that consistency in a new bug if desired; this is absolutely
useful as-is.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34999] REST API: Public routes should respect OPACMaintenance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34999 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #19 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35759] Preservation module home yields a blank page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35759 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35504] Release team 24.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #40 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35634] Permissions mismatch for vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35634 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Missing 23.05.x dependencies. NO backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35774] add_item_to_item_group additem.pl should be $item->itemnumber instead of biblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35774 Lucas Gass changed: What|Removed |Added Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #10 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.09 released in|| --- Comment #26 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] Remove HTML from downloaded reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920
--- Comment #16 from Andrew Fuerste-Henry ---
Martin, can you please provide a test plan? What I've tried doesn't seem to
work, but perhaps I'm misunderstanding your intent.
Here's what I did:
- apply patch
- cpan HTML:Restrict
- restart_all
- create a new report from SQL:
"select concat('','Hello world','') as message"
- run report
- click Download, select CSV format
- open csv in text editor
I expected my CSV to contain "Hello world" without the tags, but I got:
message
"Hello world"
I also tried:
SELECT
biblionumber,
CONCAT('',title,'')
AS Title
from biblio
and ended up with a csv containing:
biblionumber,Title
12484,"The
mask"
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31327] Add color scheme picker to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327
--- Comment #7 from David Liddle ---
I've was working some more on our own OPAC customizations, and not being a web
developer or design professional, I had cause to look up some aspects of CSS.
It was then that I learned about CSS variables. (See
https://www.w3schools.com/css/css3_variables.asp.) It occurred to me that CSS
variables for colors could make Koha theming really easy.
There *is* a list of such variables listed in the ":root" section of opac.css,
but it seems that none of them are in use. Instead, colors are specified
directly by each rule. If a default color palette was formed for the Koha OPAC,
and the CSS contained something like this:
:root {
--kColor1: #abcdef
--kColor2: #fedcba
--kColor3: #123456
--kColor4: #654321
...
}
AND the CSS rules in opac.css (and others) were edited to *always* refer to
colors by way of variables, then a *basic* theme variation would simply need to
change those variables. The change could come by way of OPACUserCSS, a custom
CSS file, a built-in light/dark mode switcher, or a plugin. Some color variants
can be created programmatically – e.g. lighter or darker, shades or tints – so
they wouldn't have to exist as separate variables. The color-mix() function is
a good example of this. (See
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color-mix.)
As I wrote, I'm not a web pro, so I could be wrong, or there could be a more
efficient way. In some ways, I'm just recording my own thoughts on the matter.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #20) > Also.. should I work through and try to replace ALL calls to > ->metadata->record with ->metadata_record.. and check for superfluous > RecordProcessor instantiations now we can do it inline? I'm sorry. Yes to all your suggestions :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 --- Comment #25 from Martin Renvoize --- Such a shame things like this just die instead of getting support. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 from Barbara Johnson --- Forgot to set the status to Failed QA after testing the bug yesterday. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35986] New: Add plugin hook for adding to OPAC item display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35986 Bug ID: 35986 Summary: Add plugin hook for adding to OPAC item display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org Add a new cell on the right of every row in the table that displays item information on detail pages in the OPAC. The content of the cell should be rendered by a plugin. Use case: Link to a shelf map. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00,23.11.02,23.05.08, |24.05.00,23.11.02,23.05.08, released in|22.11.14|22.11.14,22.05.18 Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00,23.11.02,23.05.08 |24.05.00,23.11.02,23.05.08, released in||22.11.14 Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207
--- Comment #26 from Andreas Roussos ---
(In reply to Jonathan Druart from comment #21)
Hi, Jonathan!
I'm sorry for the (much) belated reply. As per my previous
message to Lucas, I realise this bug has been left lingering
for too long. I'm keen to move this forward, so please see
my comments inline below:
> +[% IF itemloop_has_images OR otheritemloop_has_images %]
> +KOHA.LocalCover.GetCoverFromItemnumber(true);
> +[% END %]
>
>
> This is not correct, that's not what we want here.
>
> You don't want to get the image at the item level if the *current* biblio
> has image at the item level.
Fair point, I agree. To decide which local cover image to display
for the items shown in the shelf browser we shouldn't look at the
current biblio but rather handle each item independently.
In fact, I think that the algorithm should operate as follows:
1) If only a biblio-level image exists:
=> show that for all biblio items
2) If only item-level images exist:
=> show the respective image for each item
3) If both biblio-level and item-level images exist:
=> show the item-level image for the items that have one
=> fall back to the biblio-level image for all other items
> If you want to implement that you need to:
> 1. Create a new JS function in localcovers.js (say
> GetCoverFromItemnumberOrBibnumber) that would call opac-image.pl with a new
> parameter (say biblio-fallback=1)
> 2. Modify opac-image.pl to retrieve this parameter and return
> $item->cover_image || $biblio->cover_image
I'm afraid this is the part that I don't understand fully ;-)
When would this new biblio-fallback parameter be set?
And how would it work in conjunction with opac-image.pl?
As per the DESCRIPTION section of opac-image.pl, the script
currently accepts an imagenumber or a biblionumber, returning
a random image if the latter was provided (side note: I think
it's not actually 100% random but rather the first cover image):
72 elsif ( defined $biblionumber ) {
73 my $biblio = Koha::Biblios->find($biblionumber);
74 unless ($biblio) {
75 print $input->redirect("/cgi-bin/koha/errors/404.pl");
76 exit;
77 }
78 my $cover_images = $biblio->cover_images;
79 if ( $cover_images->count ) {
80 $image = $cover_images->next;
81 }
82 }
AIUI, unless we modify opac-image.pl to also accept an itemnumber
parameter we have no way of implementing the cover image selection
algorithm I described above. To do this I actually had to also
modify opac-detail.tt, shelfbrowser.inc, and C4/ShelfBrowser.pm.
> The selenium test could also cover this situation :)
OK, I reckon that should be easy to implement since we already
have a test action that uploads an item-level local cover image.
What's left to be done is to write some more tests to check if
the correct local cover image is returned in each situation.
> Does that make sense?
I think what confused me in the past (not your fault!) was that
you mentioned two changes that needed to be made (localcovers.js
and opac-image.pl), and because I had to change more files I
considered my revised patch a failure.
Apologies for not asking for your feedback earlier.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.02 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What|Removed |Added Product|Koha security |Koha Component|Koha|Web services Version|unspecified |23.11 Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #92 from Katrin Fischer --- Thanks Matt, follow-up pushed - now we need to wait and see :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277 --- Comment #28 from Fridolin Somers --- OK i give it a try -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35630] Add ability to log changes to Authorized Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Alban Peyrat changed: What|Removed |Added CC||alban.peyrat_k...@yahoo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #91 from Matt Blenkinsop --- Created attachment 161724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161724&action=edit Bug 32474: (follow-up): Tell the tests to wait for the intercepted request responses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #90 from Matt Blenkinsop --- Passes locally for me too but I think telling cypress to wait for the intercepted requests for pages two and three may help. I'll add a follow-up patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen changed: What|Removed |Added Attachment #150776|0 |1 is obsolete|| --- Comment #16 from Emmi Takkinen --- Created attachment 161723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161723&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy Signed-off-by: hinemoea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen changed: What|Removed |Added Attachment #140162|0 |1 is obsolete|| --- Comment #15 from Emmi Takkinen --- Created attachment 161722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161722&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucy Vaux-Harvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207 --- Comment #25 from Andreas Roussos --- (In reply to Lucas Gass from comment #24) > Is this still being worked on? Hi, Lucas! I'm really sorry for the lack of any response on this bug :-( The TL;DR version is that it's all due to bad communication on my part (I should have asked for further clarifications before setting off to rewrite my patch). I actually tried to follow-up on this after Jonathan's latest feedback in Comment 21. However, in my revised patch I had to modify more than just localcovers.js and opac-image.pl since I couldn't figure out how to implement the suggested fallback parameter. So, I left this idle for a while until I could fix it properly and then, unfortunately, it fell under the radar. I'll ask for Jonathan's advice ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #14 from Emmi Takkinen --- (In reply to Stina Hallin from comment #12) > I tried to sign off, but the checkin was not always returned successfully > when I checked the patron details. Sometimes it worked as it should, but I > didn't manage to see why it worked sometimes, and sometimes failed. I tried > waiting until the sco-page logged out, and sometimes it worked on the first > try but not the next. I tried using both the Submit button and return key. > Once it worked when I changed home library for the patron. I'm unable to repeat this. I was able to return several loans of several different patrons. Both items and patrons had different homebranch than library I was logged in on sco-page. Patch needs rebase, so I'll do that and set this back "Needs Signoff" to get more feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #89 from Katrin Fischer --- Tests were green when I ran them locally. so maybe something has changed, can you please check on this fail? https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/(root)/Should%20load%20the%20next%20page%20on%20scroll/Infinite_scroll_Should_load_the_next_page_on_scroll/ koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Fridolin Somers changed: What|Removed |Added Product|Koha security |Koha Group|Koha security | Version|unspecified |master Component|Koha|Web services Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed --- Comment #3 from Katrin Fischer --- It looks like D10 is still unhappy - could you have another look at it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 --- Comment #1 from Katrin Fischer --- I wrote the patch, but the different comparisons are confusing :( Happy to have some help with the fix really. I think the --showsql is to help fix an already found problem, so it probably makes sense to skip tests when the script is run with this parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 --- Comment #2 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35962] t/db_dependent/Koha/BackgroundJob.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35962 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #49 from Katrin Fischer --- I have pushed the first patch yesterday as a compromise and to get this moving. So far, Jenkins seems happy, but as this was a random failure, we are not totally out of the woods yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34979] System preferences missing from sysprefs.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 Fridolin Somers changed: What|Removed |Added Blocks||35985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35985] ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985 Fridolin Somers changed: What|Removed |Added Depends on||34979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 [Bug 34979] System preferences missing from sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35985] New: ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35985
Bug ID: 35985
Summary: ./t/db_dependent/check_sysprefs.t --showsql since Bug
34979
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Installation and upgrade (command-line installer)
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
With Bug 34979 looks like we need to adapt ./t/db_dependent/check_sysprefs.t
--showsql
Example :
kohadev-koha@kohadevbox:koha(master)$ ./t/db_dependent/check_sysprefs.t
--showsql
1..2
# Subtest: Compare database with sysprefs.sql file
('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records -
http://www.loc.gov/marc/organizations/orgshome.html','free'),
1..0
# No tests run!
not ok 1 - No tests run for subtest "Compare database with sysprefs.sql file"
# Failed test 'No tests run for subtest "Compare database with sysprefs.sql
file"'
# at ./t/db_dependent/check_sysprefs.t line 53.
# Subtest: Compare sysprefs.sql with YAML files
1..2
ok 1 - No system preference entries missing from sysprefs.sql
ok 2 - No system preference entries missing from YAML files
ok 2 - Compare sysprefs.sql with YAML files
# Looks like you failed 1 test of 2.
Too much verbose.
Should we skip subtest "Compare database with sysprefs.sql file" ?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35940] Cypress tests for the Preservation module are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35940 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35940] Cypress tests for the Preservation module are failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35940 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Emmi Takkinen changed: What|Removed |Added Attachment #143988|0 |1 is obsolete|| --- Comment #4 from Emmi Takkinen --- Created attachment 161721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161721&action=edit Bug 32132: Do not allow NULL value in column aqbudgets.budget_period_id If budget_period_id column is set as NULL, "Late orders" page dies on error 500. Logs read: Template process failed: undef error - DBIC result _type isn't of the _type Aqbudget at /home/koha/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt line 157 This patch makes changes to column aqbudgets.budget_period_id so that it no longer allows NULL values. This is in line with aqbudgets tables foreign key "budget_period_id" which has ON DELETE CASCADE clause. To test: 1. Run prove t/db_dependent/Koha/Acquisition/Fund.t => Tests should fail 2. Run updatedatabase.pl and restart services if needed 3. Rerun prove t/db_dependent/Koha/Acquisition/Fund.t => Tests should now pass Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
