[Koha-bugs] [Bug 36009] Document koha-worker --queue elastic_index

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009

--- Comment #1 from Magnus Enger  ---
Created attachment 161796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161796&action=edit
Bug 36009: Document koha-worker --queue elastic_index

To test:
- Copy the koha-worker script to the standard location:
  $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker
- Check "sudo koha-worker --help" and verify elastic_index is
  mentioned in the list of "current queues"
- See https://wiki.koha-community.org/wiki/Testing_man_pages for
  how to check the "man" page. There should be a new paragraph
  about "Current queues" under "--queue"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36009] Document koha-worker --queue elastic_index

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34927] Adding DMARC compatibility to mailing lists

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34927

--- Comment #16 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #15)
> Still missing
> koha-es
> koha-gr
> koha-i18n-ar
> koha-oz
> koha-security

Done now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36010] Items/AutomaticItemModificationByAge.t is failing

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010

Jonathan Druart  changed:

   What|Removed |Added

Summary|Items/AutomaticItemModifica |Items/AutomaticItemModifica
   |tionByAge.t is failing  |tionByAge.t is failing
   |randomly|
 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|fridolin.som...@biblibre.co
   ||m

--- Comment #1 from Jonathan Druart  ---
It is actually failing consistently, see 

https://jenkins.koha-community.org/job/Koha_Master_My8/1274/
https://jenkins.koha-community.org/job/Koha_Master_My8/1275/
https://jenkins.koha-community.org/job/Koha_Master_My8/1276/
https://jenkins.koha-community.org/job/Koha_Master_My8/1277/
https://jenkins.koha-community.org/job/Koha_Master_My8/1278/
https://jenkins.koha-community.org/job/Koha_Master_My8/1279/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029

--- Comment #20 from Jonathan Druart  ---
It caused a failure, see bug 36010

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||36010


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010
[Bug 36010] Items/AutomaticItemModificationByAge.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36010] New: Items/AutomaticItemModificationByAge.t is failing randomly

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010

Bug ID: 36010
   Summary: Items/AutomaticItemModificationByAge.t is failing
randomly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 32029

koha_1   | #   Failed test 'ToggleNewStatus: conditions on biblio'
koha_1   | #   at t/db_dependent/Items/AutomaticItemModificationByAge.t
line 356.
koha_1   | #  got: 'agefield_new_value'
koha_1   | # expected: 'new_updated_value_biblio'
koha_1   | # Looks like you failed 1 test of 20.

Koha_Master_My8/1279

First failure from this one that has been pushed recently. I don't recreate
locally (even using MySQL8).

Maybe something to do with the age comparison if the node is slow?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029
[Bug 32029] Automatic item modifications by age missing biblio table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36009] New: Document koha-worker --queue elastic_index

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009

Bug ID: 36009
   Summary: Document koha-worker --queue elastic_index
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

koha-worker --help currently says: 

--queue   Specify the queue/worker to restart - 'default' is
used if not specified
  current queues are: default, long_tasks

We should add elastic_index to the "current queues". 

"man koha-worker" only says: 

 Allows specifying the queue worker (defaults to 'default'). 

It would probably make sense to add a line about the actual queues there too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #14 from Victor Grousset/tuxayo  ---
(In reply to Katrin Fischer from comment #7)
> (In reply to Victor Grousset/tuxayo from comment #6)
> > While testing, found this that is not due to this patch but related:
> > 
> > When canceling a hold, it stays in the hold queue. Is that bad? It stays
> > until the next queue rebuild (15min is said to be the usual delay)
> 
> Please keep in mind that build_holdsqueue is no longer the only use case. We
> have RTHoldsqueue without people running the script or only running it
> nightly now.

Indeed thanks for pointing this out. (confirmed that the RTHQ doesn't suffer
from the bug here)

---

Thanks Kyle for the followups, I'll looks at them asap and again at the issue
at step 7.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |
 Status|Signed Off  |Failed QA

--- Comment #7 from Victor Grousset/tuxayo  ---
> #Patron has 1 checkout of parent itemtype  child itype1

What does  means?
My guess is that « child itype1» isn't meant to be here. And it's just some
mistyping in vim ^^

+#my $circ_rule_object =
+#  Koha::CirculationRules->find( $parent_iq_rule->{id} );
+#$circ_rule_object->rule_value(4)->store();

---

There is a probably forgotten comment:

+#my $circ_rule_object =
+#  Koha::CirculationRules->find( $parent_iq_rule->{id} );
+#$circ_rule_object->rule_value(4)->store();

Otherwise, all seems to work as it should and code looks good :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28996] SendAlerts crashes on a bad email 'To'

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996

--- Comment #7 from David Cook  ---
The patch will need to be rewriten to take into account bug 28803 but should be
an easy fix overall. (I've applied the fix locally for years. At some point
this year I might find the time to upstream it.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #6 from Victor Grousset/tuxayo  ---
> 15: Other results should be the same

9 isn't the same. And it shouldn't be the same. Because 7 failed, it's not "2
checked out" but "1 checked out". So what happens makes sense.

Thanks for the test plan with all those combination. It's great! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28996] SendAlerts crashes on a bad email 'To'

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996

David Cook  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||dc...@prosentient.com.au
Summary|SendQueuedMessages exit on  |SendAlerts crashes on a bad
   |a bad email 'To' and|email 'To'
   |following messages are  |
   |never processed.|
 Resolution|DUPLICATE   |---

--- Comment #6 from David Cook  ---
It looks like bug 28803 only covers part of the root problem.
C4::Letters::SendAlerts still has the problem. I'll rename the bug title to be
more accurate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33223] Koha::Patron->notice_email_address isn't consistently used

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36008

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36008] SendAlerts should use notice_email_address instead of email

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33223

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36008] New: SendAlerts should use notice_email_address instead of email

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36008

Bug ID: 36008
   Summary: SendAlerts should use notice_email_address instead of
email
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

C4::Letters::SendAlerts() uses $patron->email instead of
$patron->notice_email_address

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36001] Visualize MARC fields 310 and 362 for serial publications

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36001

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35943] SQL reports groups/subgroups whose name contains regexp special characters break table filtering

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35943

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978

--- Comment #7 from David Cook  ---
(In reply to Martin Renvoize from comment #6)
> Is there a more secure way of doing this rather than just exposing the raw
> html.. I feel like we're just undoing a security flaw we fixed for a reason.

Yeah I don't think we can just expose the raw HTML. One option would be to use
the HTML scrubber. I think there are quite a few parts of Koha where people
want to use HTML, but could be limited to a fairly small subset of elements and
attributes. 

> Is it time to use markdown for rich text or perhaps for linebreaks just
> outputting the note field in a pre/code block?

For line breaks, the "html_line_break" filter can be useful. 

For notes, adding that line break filter would make sense. I don't know that
any other HTML features would really needed though. If they were to be added, I
think we'd have to scrub them first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
I've signed off, as I think having better messages is great.

Some suggestions:

There was an error sending the cart: No valid biblio records found.
> There was an error sending the cart: no valid records were found.

Since we do not have your email address, we cannot send a mail. We need your
email address as reply-to address.
> There was an error sending the cart: we cannot send an email as there is no 
> email address recorded for your account (your email address is used for the 
> reply to address).

Testing notes (using KTD):

1. Go to http://127.0.0.1:8080/cgi-bin/koha/opac-sendbasket.pl?bib_list=null
2. Log in as koha/koha
3. Add an email address to the form and click 'Send': m...@example.com
4. Error message displayed: "There was an error sending the cart."
5. Note the warning in the log: /var/log/koha/kohadev/plack-opac-error.log
6. Apply the patch
7. Repeat steps 1-3
8. Note that the error displayed is now: "Since we do not have your email
address, we cannot send a mail. We need your email address as reply-to
address."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969

David Nind  changed:

   What|Removed |Added

 Attachment #161713|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 161795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161795&action=edit
Bug 35969: Add error code in opac-sendbasket.pl

No need to carp about empty basket or no reply address.
Just add a simple explanation on the form.

Note that it makes no sense to show the form if the patron
has no email address. We need it as reply-to.

Test plan:
Try opac-sendbasket.pl?bib_list=null
Remove email address from your account, try again.

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35969] opac-sendbasket: Improve error message, remove some logging

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35969

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36007] Add the ability to batch edit in Course Reserves

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36007

Beth  changed:

   What|Removed |Added

 CC||bbo...@waynesburg.edu

--- Comment #1 from Beth  ---
I would like to add that if we enable a course that was previously disabled,
the  location (say Reserve)does not automatically return to Reserve.  It would
be great to be able to batch edit the location.  Hopefully the system will
still retain the previous shelf location before it was placed on Reserve.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Matthias Le Gac  ---
were I can know which lines are bad ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36006] New patron notification method to show notice in patron account in OPAC

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36006

Katrin Fischer  changed:

   What|Removed |Added

Summary|Patron notification methods |New patron notification
   ||method to show notice in
   ||patron account in OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #21 from Martin Renvoize  ---
Not with how the API embeds get translated.  The real fix is to fix our
database field names and database table names to generally be consistency.. 
but that would upset everyone with reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36007] New: Add the ability to batch edit in Course Reserves

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36007

Bug ID: 36007
   Summary: Add the ability to batch edit in Course Reserves
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be nice to have the ability to batch edit in course reserves.  A
scenario could be, a course is reactivated, the items in the course are the
same, but they all need to be relocated for the course is happening at a
different branch, or a different reserve location. A batch edit would allow
staff to retain the list of items in the course, but easily update the new
course reserves values. At this time, each item would need to be individually
edited.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36006] Patron notification methods

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36006

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30515

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36006

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33459] Patrons need messaging preferences for other notices

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33459

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30515

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30515] Move Overdue transports to patron messaging preferences

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30515

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33459
 CC||cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

--- Comment #7 from Brendan Lawlor  ---
I tried testing this but couldn't find the log files /tmp/report-time.log and
/tmp/report-query.log 

I may be missing a step.
1. Applied the patch
2. Added the provided config to /koha/etc/log4perl.conf
3. restart_all
4. Set all Logging system prefs to 'Log'
5. Ran some reports
6. Check /tmp for report-time.log and report-query.log

There were files in /tmp but none name like that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11583] Add WYSIWYG editor for HTML notices/letters

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org
 Status|RESOLVED|REOPENED
 Resolution|WISHLIST|---

--- Comment #5 from Christopher Brannon  ---
I would like to see this.  If we select HTML in the template, we should be able
to see it and format with tools like we can everywhere else.  This would be a
very welcome enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36006] New: Patron notification methods

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36006

Bug ID: 36006
   Summary: Patron notification methods
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Patrons have the option to turn on or off any notifications for any of the
methods available (email, print, sms, phone).  Could we offer another method
that allows them to be notified when they login to their account?  So,
basically, when selected for a particular notice, the notice appears in their
opac messages.  When they mark it as read, there could be an indicator in the
staff side next to that notice when they marked it read.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2635] Allow validation of price related item fields

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635

--- Comment #10 from Chris Nighswonger  ---
(In reply to Esther Melander from comment #9)
> To be clear, would this bug validate the 952$g (Cost, normal purchase price)
> and 952$v (Cost, replacement price)?
> 
> Bug 34169 added validation of monetary fields in acquisitions, but it did
> not include the item form used in acquisitions. In general it would be nice
> if it was included both in acquisitions and when editing/adding an item
> record to a bibliographic record.

In another four years this bug will turn 20... wow!

I really do not recall much of anything about this as it has been so long.
Reading back, it appears that work I did for LL never made it into the public
repo. Sad.

Maybe someone currently working on the project can comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2635] Allow validation of price related item fields

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #9 from Esther Melander  ---
To be clear, would this bug validate the 952$g (Cost, normal purchase price)
and 952$v (Cost, replacement price)?

Bug 34169 added validation of monetary fields in acquisitions, but it did not
include the item form used in acquisitions. In general it would be nice if it
was included both in acquisitions and when editing/adding an item record to a
bibliographic record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

--- Comment #4 from Brendan Lawlor  ---
Testing notes

1. Placed holds

2. Find the script and run it:
git grep build_holds_queue
cd misc/cronjobs/holds/
perl build_holds_queue.pl

3. Check http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl
4. Cancel holds and refresh the page

The holds were removed from the queue!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #161767|0   |1
is obsolete||

--- Comment #3 from Brendan Lawlor  ---
Created attachment 161794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161794&action=edit
Bug 35997: Cancelling a hold should remove the hold from the queue

Test plan:
1) Place a hold for a record for a patron
2) Build the holds queue
3) Note the holds queue contains a match for that patron and record
4) Cancel the holds queue
5) Reload the holds queue page, note the match for  that patron and
   record is gone!

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35997] Cancelling a hold should remove the hold from the queue

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35943] SQL reports groups/subgroups whose name contains regexp special characters break table filtering

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35943

David Nind  changed:

   What|Removed |Added

 Attachment #161645|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 161793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161793&action=edit
Bug 35943: Fix group/subgroup filtering of saved reports

Use code instead of name for filtering and escape regexp special
characters.

This patch also disables datatables' smart filtering as it is not
recommended to use with regexp filtering

https://datatables.net/reference/api/search()

Test plan:
1. Create a report in a group named "Foo + Bar" and in a subgroup named
   "Baz + Quux"
2. Create other reports in group "Foo + Bar" but in other subgroups, as
   well as in other groups. This is useful to see the effect of
   filtering
3. Go to the saved reports page and verify that navigating between tabs
   have the desired result. Same for the subgroup select

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35943] SQL reports groups/subgroups whose name contains regexp special characters break table filtering

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35943

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #29 from Esther Melander  ---
I agree that moving the 001 control number of an incoming authority record to
the 035 needs to happen. Some third party suppliers of authority records are
using the 001 for their control number. Once that record is imported, the third
party control number is lost. On the next round of authority updates it then
becomes impossible to match and overlay those records. If the incoming
authority is missing the corresponding 003, then it should just be left off
when the number is copied over to the 035. If this copying action is done, then
the 003 should be the local organizations code or blank if not defined.

The current work around is to edit the authorities using MarcEdit to move/copy
the 001 control number to the 035 before importing. A task that could be pretty
tedious when there are thousands of records that need to be imported and
overlaid every three months.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35927] Selecting MARC framework again doesn't work when adding to basket from an external source

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35927

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
I'm not seeing this on the current master. Are there any additional steps I
need to do?

Happy to sign off if this is aimed at improving the code and no change in
behavour.

Or should I test using Ubuntu Focal as the operating system?

How I tested:
1. Go to Acquisitions, then click 'Search'.
2. Select 'My Basket' > Add to basket > From an external source.
3. In the 'Order from external source' form:
   - Title: DITA best practices
   - Select MARC framework: select another framework, such as 'Books. Booklets,
Workbooks'
4. For actions, select +Order.
5. Complete the required fields and click 'Add item'.
6. Complete the accounting details form and click 'Save'.
7. Edit the newly created record.
8. Under the Settings menu, the framework should be the same as you selected in
step 3.

Note: If I repeat and add the same record again (for duplicate warning: create
new record), the new record shows as the default framework. (I'm not sure why
you would do this, but it is possible to. The patch doesn't fix this.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #161791|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 161792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161792&action=edit
Bug 35357: Enhance unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #12 from Kyle M Hall  ---
(In reply to Victor Grousset/tuxayo from comment #5)
> > 7) Verify the holds queue viewer no longer shows that patron and item!
> 
> The next run of misc/cronjobs/holds/build_holds_queue.pl brings back that
> patron and item in the Holds queue page. So back with the initial issue :(

I am unable to recreate that. If you can please submit a new bug report as that
would be a different bug!

> QA script unhappy:
>  WARN t/db_dependent/HoldsQueue.t
>WARN tidiness
>   The file is less tidy than before (bad/messy lines before: 484, 
> now: 488)

Fixed!

> minor finding:
> The test uses a record level hold instead of an item level one. It works
> because there is one item for the record. Otherwise reproducing the bug
> would depend on which item is picked. IIUC it has to be the one suggested by
> the hold queue to get the issue.
> So maybe a comment is needed to say that the test tests the case where the
> checked out item is the one suggested by the hold queue. Or make it do an
> item level hold like in the test plan.

That is correct, it is always the one suggested by the holds queue. I have
enhanced the unit tests to prove this is the case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #11 from Kyle M Hall  ---
Created attachment 161791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161791&action=edit
Bug 35357: Enhance unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #10 from Kyle M Hall  ---
Created attachment 161790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161790&action=edit
Bug 35357: Remove item from holds queue when it is checked out

Test Plan:
1) Place a hold on an item
2) Build the holds queue
3) Check out the item to a different patron than the one
   targeted in the holds queue
4) Verify the holds queue viewer still shows that item and patron
5) Apply this patch
6) Repeat stepts 1 through 3
7) Verify the holds queue viewer no longer shows that patron and item!

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #161009|0   |1
is obsolete||
 Attachment #161010|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 161789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161789&action=edit
Bug 35357: Add unit test

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Owen Leonard  changed:

   What|Removed |Added

 Attachment #161785|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 161788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161788&action=edit
Bug 36004: Fixed typo in successfully

To test:

1. Turn on the syspref 'OpacCatalogConcerns'

2. Go to view a record in the OPAC and click on "Report a concern" in
   the column located on the right-hand side.

3. Fill out the title on the form and leave everything else the same.
   Click on submit and notice that the message on the screen says "Your
   concern was sucessfully submitted."

4. Apply the patch.

5. Submit a new concern. Notice that the text now has "successfully"
   spelled correctly.

6. Sign off and have a great day! :D

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #8 from Kyle M Hall  ---
(In reply to Victor Grousset/tuxayo from comment #6)
> While testing, found this that is not due to this patch but related:
> 
> When canceling a hold, it stays in the hold queue. Is that bad? It stays
> until the next queue rebuild (15min is said to be the usual delay)

See Bug 35997 for the fix for that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com
 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
Changed assignee.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457

David Nind  changed:

   What|Removed |Added

 Attachment #161543|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 161787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161787&action=edit
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials
preferences

This patch moved the SerialsDefaultEMailAddress system preference and
the SerialsDefaultReplyTo system preference to the Serials preferences.

To test:
1. Apply patch
2. Go to Administration > System preferences > Acquisitions
   --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not
   be there
3. Go to Administration > System preferences > Serials
   --> There should be a new section called "Notifications" with
   the two system preferences

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32137] Use current patron contact info when resending notices

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Christopher Brannon  ---
It seems at some point this was fixed.  Not sure when.  But is not an issue in
23.05, after doing some recent tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005

Laura Escamilla  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu
   |ity.org |tions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005

--- Comment #1 from Laura Escamilla  ---
Created attachment 161786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161786&action=edit
Bug 36005: Fixed typo in "Your concern was successfully submitted." text

To test:

1. Turn on the syspref 'CatalogConcerns'

2. Go to view a record in the staff intranet and click on "New catalog concern"
which is located in the "+New" dropdown.

3. Fill out the title on the form and leave everything else the same. Click on
submit and notice that the message on the screen says "Your concern was
sucessfully submitted."

4. Apply the patch.

5. Refresh the page and submit a new concern. Notice that the message now has
"successfully" spelled correctly.

6. Sign off and have a wonderful day! :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36005] Typo in "Your concern was successfully submitted" Staff Intranet text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005

Laura Escamilla  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36005] New: Typo in "Your concern was successfully submitted" Staff Intranet text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36005

Bug ID: 36005
   Summary: Typo in "Your concern was successfully submitted"
Staff Intranet text
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To recreate:

1. Turn on the syspref 'CatalogConcerns'

2. Go to view a record in the staff intranet and click on "New catalog concern"
which is located in the "+New" dropdown.

3. Fill out the title on the form and leave everything else the same. Click on
submit and notice that the message on the screen says "Your concern was
sucessfully submitted."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667

--- Comment #5 from Sara Porter  ---
This would be particularly useful if notforloan_on contained a date even when
notforloan was changed to 0. It would give us a simple way to track when items
became available.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" OPAC text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Laura Escamilla  changed:

   What|Removed |Added

Summary|Typo in "Your concern was   |Typo in "Your concern was
   |successfully submitted" |successfully submitted"
   |text|OPAC text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

--- Comment #1 from Laura Escamilla  ---
Created attachment 161785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161785&action=edit
Bug 36004: Fixed typo in successfully

To test:

1. Turn on the syspref 'OpacCatalogConcerns'

2. Go to view a record in the OPAC and click on "Report a concern" in the
column located on the right-hand side.

3. Fill out the title on the form and leave everything else the same. Click on
submit and notice that the message on the screen says "Your concern was
sucessfully submitted."

4. Apply the patch.

5. Submit a new concern. Notice that the text now has "successfully" spelled
correctly.

6. Sign off and have a great day! :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Laura Escamilla  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Laura Escamilla  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] Typo in "Your concern was successfully submitted" text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Laura Escamilla  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |Laura.escamilla@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36004] New: Typo in "Your concern was successfully submitted" text

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36004

Bug ID: 36004
   Summary: Typo in "Your concern was successfully submitted" text
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

1. Turn on the syspref 'OpacCatalogConcerns'
2. Go to view a record in the OPAC and click on "Report a concern" in the
column located on the right-hand side. 
3. Fill out the title on the form and leave everything else the same. Click on
submit and notice that the message on the screen says "Your concern was
sucessfully submitted."

Successfully is spelled incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #20 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #19)
> Adding the orders relation alias is forward thinking for the API here. I
> agree with the approach Tomas took

Yeah no problem. But couldnt you add an ->orders method and use the aqorders
relation inside. Preventing custom relations in DBIx schema?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #6 from Katrin Fischer  ---
Excited to see patches on this one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077

--- Comment #15 from Martin Renvoize  ---
I'm out, this was meant to be a simple consistency fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #19 from Martin Renvoize  ---
Adding the orders relation alias is forward thinking for the API here. I agree
with the approach Tomas took

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35994] Need an easy way to see if biblio record or item is still in acquisition

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Need a easy way to see if   |Need an easy way to see if
   |biblio record or item is|biblio record or item is
   |still in acquisition|still in acquisition

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35994] Need a easy way to see if biblio record or item is still in acquisition

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994

--- Comment #2 from Marcel de Rooy  ---
Bug 24430 added biblio->active_orders but they include the lines which are
completely received. These are actually 'not-cancelled' orders.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35994

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35994] Need a easy way to see if biblio record or item is still in acquisition

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24430

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #18 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #0)
> Using the DBIC relationship with aqorders and count, we can get rid of it.

You could have used aqorders but added orders?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #17 from Marcel de Rooy  ---
A bit late, but wondering why active_orders include completed lines ? Looks a
bit strange to me..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com
   Assignee|tomasco...@gmail.com|maryse.sim...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #5 from Maryse Simard  ---
Created attachment 161784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161784&action=edit
Bug 34755: Resets the userenv when calling OAuth api endpoints

When using OIDC authentication, the error "wrong_csrf_token" can happen
if another user's userenv is loaded during login. This is because the
wrong userenv is used to compare the tokens. This patch explicitly
resets userenv when using OAuth endpoints of the Koha api.

Steps to reproduce:
0. On a Koha with SSO configured
1. Open the OPAC
2. Log in with a regular Koha user, not using SSO.
3. In a private browser window, open the OPAC
4. log in using SSO with a different user account.
5. Notice that you get the error message "There was an error
authenticating to external identity provider wrong_csrf_token"
6. Click on the "Log in with [...]" button again.
7. Notice that the user is immediately logged in.

To test:
- Apply the tests patch
- prove t/db_dependent/api/v1/idp.t
=> FAIL: wrong_csrf_token
- Apply patch
- prove t/db_dependent/api/v1/idp.t
=> SUCCESS
- Run other OAuth endpoints tests to make sure nothing broke:
prove t/db_dependent/api/v1/auth_authenticate_api_request.t
prove t/db_dependent/api/v1/oauth.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #4 from Maryse Simard  ---
Created attachment 161783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161783&action=edit
Bug 34755: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

Maryse Simard  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21972] Record matching rule for authorities only works for first 20 authority records

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21972

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35438] Importing records can create too large transactions

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34965] Authority match failing due to possible encoding conflicts

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34965

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340

--- Comment #13 from Jessie Zairo  ---
just adding more feedback. A librarian shared yesterday that it would be
helpful to be able to change the sorting for the table so the account summary
showed the most recent checkouts first, rather than just an alphabetical
listing. Or at least adding the option for libraries to customize.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36003] New: Printing list from OPAC shows "Cookies" when CookieConsent enabled

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003

Bug ID: 36003
   Summary: Printing list from OPAC shows "Cookies" when
CookieConsent enabled
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mirjam.vantieg...@etf.edu
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

If system preference CookieConsent is set to "Required", the word "Cookies"
appears at the bottem left on the last page, under the last result, when
printing a list from the OPAC. Funny, but not desirable.
Not sure if similar to bug #12260.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

--- Comment #4 from Marcel de Rooy  ---
Created attachment 161782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161782&action=edit
Bug 36002: Remove last references to purchaseordernumber

Test plan:
Git grep for it. Ignore update22to30.pl and atomicupdate.
Verify that you can still create/update/delete an acq order.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

--- Comment #3 from Marcel de Rooy  ---
Created attachment 161781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161781&action=edit
Bug 36002: Remove unused subroutine GetParcels

That did refer to our aqorders.purchaseordernumber..

Test plan:
Git grep for GetParcels.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

--- Comment #2 from Marcel de Rooy  ---
Created attachment 161780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161780&action=edit
Bug 36002: DBIx schema changes for Aqorder

No test plan.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

--- Comment #1 from Marcel de Rooy  ---
Created attachment 161779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161779&action=edit
Bug 36002: Database revision for aqorders.purchaseordernumber

Test plan:
Run dbrev. Check if field is no longer there.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11010] Useless column purchaseordernumber in aqorders table

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36002

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11010

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11010] Useless column purchaseordernumber in aqorders table

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> Since bug 4456 will use this field, this bug report is invalid.

Bug 4456 died prematurely. I opened 36002 to resurrect removal of this
confusing column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36002] New: Get rid of aqorders.purchaseordernumber

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36002

Bug ID: 36002
   Summary: Get rid of aqorders.purchaseordernumber
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

This field is unused. Any attempt to use it was inactive since 2014.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #161777|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 161778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161778&action=edit
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML

2024-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978

Martin Renvoize  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >