[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #49 from Victor Grousset/tuxayo --- Ok this is a though one ^^" After rereading most stuff here: comment 1 mentions that days and months work. After testing: a. the localized value is saved directly in the database[1] b. which is likely why all pages of test plan step 10 are following subscription.locale for days and months So questions for everyone depending on how you view the current patches proposed here: - related to a. : what's the issue with the proposed patches if day and month already store a localized value? - related to b. : do seasons need to be handled differently than day and month? (asked in comment 43) Because the patches are going to a different logic: following current UI locale IIUC. Even though days and months at first seemed satisfactory (comment 1) [1] is that the right place to look? : select * from subscriptionhistory; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36138] Add cancellation reason to opac-holdshistory.pl's Status column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36138 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36138] Add cancellation reason to opac-holdshistory.pl's Status column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36138 Biblibre Sandboxes changed: What|Removed |Added Attachment #162309|0 |1 is obsolete|| --- Comment #2 from Biblibre Sandboxes --- Created attachment 162404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162404&action=edit Bug 36138: Add reason to status column on opac-holdshistory, if there is a reason TO TEST: 1. Turn on OPACHoldsHistory 2. Make some holds for a patron and then cancel them with a reason. 3. Log in as that patron and go to the 'Holds history' tab. Notice the text in the 'Status' column is 'Cancelled' but nothing shows up regarding the reason. 4. Apply patch and try again, this time you should see the reason for cancellation. Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36162] New: Train table needs more detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36162 Bug ID: 36162 Summary: Train table needs more detail Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Preservation Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: jonathan.druart+k...@gmail.com The Train table in the Preservation module needs more detail. After adding an item from the waiting list, the table lists an ID # and then Edit/Remove buttons, and possibly an "Attributes" column. It would be nice if the table listed the bibliographic title and a barcode link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | Status|NEW |Needs Signoff CC||shi-yao.w...@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35911] Archived suggestions show in patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 --- Comment #6 from Shi Yao Wang --- Created attachment 162403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162403&action=edit Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 Nick Clemens changed: What|Removed |Added Blocks||36161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161 [Bug 36161] ISLDI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36161] ISLDI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161 Nick Clemens changed: What|Removed |Added Depends on||34893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893 [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36161] ISLDI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161 --- Comment #1 from Nick Clemens --- To recreate: 1 - Enable ILSDI: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=web_services#web_services_ILS-DI 2 - Enable ldap (not for real) by adding/editing to koha-conf: 1 ldaps://nha.dog belong.to.us 3 - Try to authenticate a patron (generate your correct credentials: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=edna&password=acosta 4 - Can't call method "update_lastseen" on an undefined value at /kohadevbox/koha/C4/ILSDI/Services.pm line 400 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36161] New: ISLDI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161
Bug ID: 36161
Summary: ISLDI AuthenticatePatron broken when LDAP enabled and
auth falls back to internal connection
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: Authentication
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org
bug 34893 passes a patron object back from authentication, however, when LDAP
is enabled we define the patron from the return of checkpw_ldap
When the ldap auth is a failure, we fallback to internal, however, we don't
redefine the patron object
In the code:
1965 if ( defined $userid ) {
1966 $patron = Koha::Patrons->find( { userid => $userid } );
1967 $patron = Koha::Patrons->find( { cardnumber => $userid } ) unless
$patron;
1968 }
.
.
.
1980 } elsif ( $ldap && defined($password) ) {
1981 my ( $retval, $retcard, $retuserid );
1982 ( $retval, $retcard, $retuserid, $patron ) = checkpw_ldap(@_);
# EXTERNAL AUTH
.
.
.
2026 # INTERNAL AUTH
2027 if ($check_internal_as_fallback) {
2028 @return = checkpw_internal( $userid, $password, $no_set_userenv );
2029 push( @return, $patron );
2030 $passwd_ok = 1 if $return[0] > 0;# 1 or 2
2031 }
line 1982 undefs, line 2029 returns it
In ilsdi:
397 my ($status, $cardnumber, $userid, $patron) = C4::Auth::checkpw(
$username, $password );
398 if ( $status == 1 ) {
399 # Track the login
400 $patron->update_lastseen('connection');
401 return { id => $patron->borrowernumber };
402 }
We die on undefined patron
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23532] AutoCreateAuthorities create authority only headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36160] Use $builder->build_object when creating patrons in Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- The tests don't fail for me. Is there something else that needs to be done first? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #5 from Laura Escamilla --- Agh sorry! I added my message in the incorrect spot during my sign off, but it works as described! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Laura Escamilla changed: What|Removed |Added Attachment #162129|0 |1 is obsolete|| --- Comment #4 from Laura Escamilla --- Created attachment 162402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162402&action=edit Works as described: Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35916] Purchase suggestions bibliographic filter should be a "contains" search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | CC||shi-yao.w...@inlibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35916] Purchase suggestions bibliographic filter should be a "contains" search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916 --- Comment #2 from Shi Yao Wang --- Created attachment 162401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162401&action=edit Bug 35916: Purchase suggestions bibliographic filter should be a "contains" search Make all bibliographic information fields filter do a contain match rather than an exact match Test plan: 1. Create a purchase suggestion with a multi-word title (e.g. one day in december) 1.1. Go to Acquisitions > Suggestions > New purchase suggestion 1.2. Enter a title (e.g. one day in december) 1.3. Click on Submit your suggestion 2. Search for one of the words in the title 2.1. In the "Filter by" section, click on Bibliographic information 2.2. In the title field, enter one of the words of the title (e.g. december) 2.3. Click Go --> No results 3. Apply the patch 4. Redo step 2 and notice there is now a valid result -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36142] Usermenu "Recalls history" not active when confirming recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36142 David Nind changed: What|Removed |Added CC||da...@davidnind.com Assignee|oleon...@myacpl.org |pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36142] Usermenu "Recalls history" not active when confirming recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36142 David Nind changed: What|Removed |Added Attachment #162316|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 162400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162400&action=edit Bug 36142: recallsview template param for opac-recall.tt Test plan: 1) Enable UseRecalls 2) Visit OPAC confirm recall page: /cgi-bin/koha/opac-recall.pl?biblionumber=76 3) Notice left-side menu 'Recalls history' is not active 4) Apply patch. Repeat. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36142] Usermenu "Recalls history" not active when confirming recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36142 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35152] Convert RoutingListNote system preference to additional contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35152 --- Comment #5 from Owen Leonard --- (In reply to Julian Maurice from comment #3) > I can see one minor issue: if RoutingListNote preference still have its > default value Did the database update not take care of this? (In reply to Julian Maurice from comment #4) > Is this bug really dependent on bug 35151 ? Probably not... I was trying to make each one of these HTML customization patches dependent on the previous one to avoid conflicts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36150] Circulation home page styling does not match Cataloging home page styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- This is much nicer, and more consistent! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36150] Circulation home page styling does not match Cataloging home page styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind changed: What|Removed |Added Attachment #162331|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 162399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162399&action=edit Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: /cgi-bin/koha/cataloguing/cataloging-home.pl /cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36150] Circulation home page styling does not match Cataloging home page styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36160] Use $builder->build_object when creating patrons in Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160 David Gustafsson changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|glask...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36160] Use $builder->build_object when creating patrons in Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24421] Generated authorities are missing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Phil Ringnalda changed: What|Removed |Added CC||gvera...@gmail.com --- Comment #15 from Phil Ringnalda --- *** Bug 23532 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23532] AutoCreateAuthorities create authority only headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532 Phil Ringnalda changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||p...@chetcolibrary.org --- Comment #3 from Phil Ringnalda --- Comment 0 was fixed by bug 24421 For comment 1, e should not be included just like it is not included for name headings: there's one Eastwood, Clint, 1930- whether he was $eactor or $edirector or $eactor, director for a particular biblio record. And for 150, the MARC21 Authority format doesn't define any of c d or e which is correct for e (it's only defined in authorities for use as the relationship between a name and a work in name-title headings) but rather odd for c and d. So there's no reason why there shouldn't be a bug for adding g to the list of 650 subfields, but adding c and d should start with a spec proposal, https://www.loc.gov/marc/faq.html#changes *** This bug has been marked as a duplicate of bug 24421 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36160] Use $builder->build_object when creating patrons in Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160 --- Comment #1 from David Gustafsson --- Created attachment 162398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162398&action=edit Bug 36160: Use $builder->build_object for patron objects in Circulation.t 1) Set TrackLastPatronActivityTriggers to at least "Renew an item" 2) Run tests in t/db_dependent/Circulation.t and verify that failes with "Invalid value passed, borrowers.updated_on..." 3) Apply patch 4) Run Circulatoint.t tests again and verify that no longer produces this error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36157] Links in the "Run with template" dropdown at guided_reports.pl have odd formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36157 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind --- Getting sha1 error when trying to apply the patch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36157: Remove class from anchor link error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc). error: could not build fake ancestor Patch failed at 0001 Bug 36157: Remove class from anchor link hint: Use 'git am --show-current-patch=diff' to see the failed patch Also, shouldn't the commit message be formatted according to the guidelines? (https://wiki.koha-community.org/wiki/Commit_messages) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36160] New: Use $builder->build_object when creating patrons in Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160 Bug ID: 36160 Summary: Use $builder->build_object when creating patrons in Circulation.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org Since Patron::update_lastseen was introduced in Bug 15504 circulation tests can protentially crash with: "Invalid value passed, borrowers.updated_on=SCALAR(0x564a85c3e9b0) expected type is datetime" depending of the value of TrackLastPatronActivityTriggers. This probably does not happen on a fresh Koha installation, but did when I ran the tests locally with "Renew an item" activated for TrackLastPatronActivityTriggers. The reason is that in the Circulation.t tests patron objects are created through Koha::Patron->new instead of using the builder object, and $self->lastseen($now)->store; is called in update_lastseen, on an object that does not have a valid updated_on, resulting in an invalid default value being assigned inKoha/Schema/Loader/mysql.pm. Possible added future test might also crash if resulting in these patron objects being updated. This patch fixes this issue, the tests still fail for other reasons: # Failed test 'transferbook tests' # at t/db_dependent/Circulation.t line 5769. Exception 'Koha::Exceptions::MissingParameter' thrown 'The to parameter is mandatory' But will create another issue for this if not due to some strange local issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34663] Errors in UNIMARC default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34663 David Nind changed: What|Removed |Added Attachment #162324|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 162397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162397&action=edit Bug 34663: Errors in UNIMARC default framework This patch corrects the default UNIMARC bibliographic framework to place all the 4XX subfields in tab 4. To test: 1. Go to Administration > MARC Bibliographic framework test --> There should be errors indicating subfields from 4XX fields are in tabs 3 and 4 2. Apply patch and reset_all 3. Redo step 1 --> It should now say that all subfields for each tag are in the same tab (or ignored) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34663] Errors in UNIMARC default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34663 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18317] Allow check out of already checked out items through SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 --- Comment #18 from Kyle M Hall --- Created attachment 162396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162396&action=edit Bug 18317: (QA follow-up) Clean up code and add unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18317] Allow check out of already checked out items through SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 --- Comment #17 from Kyle M Hall --- Created attachment 162395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162395&action=edit Bug 18317: Perl tidy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18317] Allow check out of already checked out items through SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 Kyle M Hall changed: What|Removed |Added Attachment #159130|0 |1 is obsolete|| Attachment #159131|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 162394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162394&action=edit Bug 18317: Allow check out of already checked out items through SIP This patch allows checkouts to be processed via SIP even when the item is already checked out to a user. Test plan: 0) Apply the patch 1) koha-sip --stop kohadev 2) koha-sip --start kohadev 3) misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkout --patron koha --item 301310 4) misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkout --patron 2352935676 --item 301310 5) Note the output includes "AFItem checked out to another patron" 6) Enable system preference "AllowItemsOnLoanCheckoutSIP" 7) misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkout --patron 2352935676 --item 301310 8) Note the output no longer includes "AFItem checked out to another patron" and the item has been checked out to patron 2352935676 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18317] Allow check out of already checked out items through SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18317] Allow check out of already checked out items through SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #15 from Kyle M Hall --- Needs unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36133] 414 Request-URI Too Long when submitting lots of items for batch item modification from a biblio detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36133 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org --- Comment #1 from Angela Berrett --- We would love to see an improvement on this as well as we have quite a few bib records with more than 500 items. Our issue is that most of them are microfilm items and do not have barcodes, so we can't export a barcode file and batch update that way. Being able to do the batch update within the bib record would be fantastic! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36034] cas_ticket is set to serialized patron object in session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36034 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #15 from Frédéric Demians --- Backported 22.11.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #8 from Esther Melander --- I filed bug 36123 with my somewhat clumsy explanation on a related problem with configuring visibility for the 856 $u in the OPAC. The larger question is if 856$u is hidden, should any other fields with data still function as a link? I think no, especially if the URL checkbox is not checked for the other fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158
Kyle M Hall changed:
What|Removed |Added
Attachment #162389|0 |1
is obsolete||
--- Comment #2 from Kyle M Hall ---
Created attachment 162393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162393&action=edit
Bug 36158: Update t iterator variable
It seems like its causing some sort of conflict with t('Hide SQL code') further
down below in the code, but I'm not sure why.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 --- Comment #1 from Nick Clemens --- Created attachment 162392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162392&action=edit Test import file Enable 'BorrowersLog' system preference Import this file, matchig on cardnuber, and overwriting Check the logs, see the modification of columns that have no date Import again We log it again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] New: Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159
Bug ID: 36159
Summary: Patron imports record a change for non-text columns
that are not in the import file
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Tools
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
When importing patrons we assume a default of '' for borrower columns not
supplied in the file.
When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:
"date_renewed" : {
"after" : "",
"before" : null
},
"dateofbirth" : {
"after" : "",
"before" : null
},
"debarred" : {
"after" : "",
"before" : null
},
"flags" : {
"after" : "",
"before" : null
},
"gonenoaddress" : {
"after" : "",
"before" : null
},
"lost" : {
"after" : "",
"before" : null
},
"password_expiration_date" : {
"after" : "",
"before" : null
},
"sms_provider_id" : {
"after" : "",
"before" : null
}
}
This can mean a lot of useless logging in sites that do automated imports
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Pedro Amorim changed: What|Removed |Added Blocks||36157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36157 [Bug 36157] Links in the "Run with template" dropdown at guided_reports.pl have odd formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36157] Links in the "Run with template" dropdown at guided_reports.pl have odd formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36157 Pedro Amorim changed: What|Removed |Added Patch complexity|--- |String patch Depends on||34136 Assignee|oleon...@myacpl.org |pedro.amo...@ptfs-europe.co ||m Severity|enhancement |trivial CC||caroline.cyr-la-rose@inlibr ||o.com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||pedro.amo...@ptfs-europe.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36157] Links in the "Run with template" dropdown at guided_reports.pl have odd formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36157 --- Comment #1 from Pedro Amorim --- Created attachment 162391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162391&action=edit Bug 36157: Remove class from anchor link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36157] Links in the "Run with template" dropdown at guided_reports.pl have odd formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36157 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Kyle M Hall changed: What|Removed |Added Attachment #159118|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 162390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162390&action=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 Pedro Amorim changed: What|Removed |Added CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 Pedro Amorim changed: What|Removed |Added Patch complexity|--- |String patch Assignee|oleon...@myacpl.org |pedro.amo...@ptfs-europe.co ||m CC||caroline.cyr-la-rose@inlibr ||o.com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Keywords||Sandbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158
--- Comment #1 from Pedro Amorim ---
Created attachment 162389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162389&action=edit
Bug 36158: Update t iterator variable
It seems like its causing some sort of conflict with t('Hide SQL code') further
down below in the code, but I'm not sure why.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24968] Add system preference controls for cronjobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #13 from Martin Renvoize --- More work required still as it's an unfunded piece.. but I do have the beginnings of a plugin for a "crontab manager" over at https://github.com/PTFS-Europe/koha-plugin-crontab I still think making our cron scripts all use preferences for their option rather than requiring lots of options be passed in the command line is a good thing though too -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Pedro Amorim changed: What|Removed |Added Blocks||36158 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 Pedro Amorim changed: What|Removed |Added Depends on||34136 CC||pedro.amo...@ptfs-europe.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 Pedro Amorim changed: What|Removed |Added Attachment #162387|0 |1 is obsolete|| --- Comment #18 from Pedro Amorim --- Created attachment 162388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162388&action=edit Bug 26869: Add items from MARC in BatchUpdateBiblio Test plan, clean k-t-d: Before test, pick a record and confirm it has no items, for this test we're using biblio 79: /cgi-bin/koha/catalogue/detail.pl?biblionumber=79 1) Add a new MARC modification template, visit: /cgi-bin/koha/tools/marc_modification_templates.pl 2) Click 'New template', enter a name and click 'Submit' 3) Click 'New action' 4) Pick 'Add new' and enter '952' as field and 'a' as subfield, enter 'CPL' as value 5) Click 'Add action' 6) Do a batch record modification, visit: /cgi-bin/koha/tools/batch_record_modification.pl 7) Select the tab 'Enter a list of record numbers' and enter '79' 8) On the template, select the template previously created. Click 'continue' 9) Click 'Modify selected records'. Click 'View detail of the enqueued job'. Notice success message is shown with no errors 10) Check the biblio, visit: /cgi-bin/koha/catalogue/detail.pl?biblionumber=79 11) Notice it now has an item with homebranch 'CPL' test with 952 but with other subfields, without subfield 'a' -> confirm 'FK constraint' error is shown, no modification made test with more than one occurrence of 952$a -> confirm 'FK constraint' error is shown, no modification made test with 952$a too long e.g. '' -> confirm 'too long' error is shown test with no 952 mapping -> confirm things work as intended test with 952 mapping plus other tags -> confirm things work as intended prove koha/t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t prove koha/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 Pedro Amorim changed: What|Removed |Added Attachment #162383|0 |1 is obsolete|| --- Comment #17 from Pedro Amorim --- Created attachment 162387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162387&action=edit Bug 26869: Add items from MARC in BatchUpdateBiblio Test plan, clean k-t-d: Before test, pick a record and confirm it has no items, for this test we're using biblio 79: /cgi-bin/koha/catalogue/detail.pl?biblionumber=79 1) Add a new MARC modification template, visit: /cgi-bin/koha/tools/marc_modification_templates.pl 2) Click 'New template', enter a name and click 'Submit' 3) Click 'New action' 4) Pick 'Add new' and enter '952' as field and 'a' as subfield, enter 'CPL' as value 5) Click 'Add action' 6) Do a batch record modification, visit: /cgi-bin/koha/tools/batch_record_modification.pl 7) Select the tab 'Enter a list of record numbers' and enter '76' 8) On the template, select the template previously created. Click 'continue' 9) Click 'Modify selected records'. Click 'View detail of the enqueued job'. Notice success message is shown with no errors 10) Check the biblio, visit: /cgi-bin/koha/catalogue/detail.pl?biblionumber=79 11) Notice it now has an item with homebranch 'CPL' test with 952 but with other subfields, without subfield 'a' -> confirm 'FK constraint' error is shown, no modification made test with more than one occurrence of 952$a -> confirm 'FK constraint' error is shown, no modification made test with 952$a too long e.g. '' -> confirm 'too long' error is shown test with no 952 mapping -> confirm things work as intended test with 952 mapping plus other tags -> confirm things work as intended prove koha/t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t prove koha/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36143] Pop-up window sizes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 --- Comment #1 from Fridolin Somers --- Maybe only large and small in enough. Looks like small popups use around 4/3 ratio. So small could be width=800,height=600 Large use a more 16/9 ratio. So large could be width=1024,height=576 Actual width=800 and width=700 goes to small. Actual width=900 may fit in small, must be validated. Actual width=1000 goes to large. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36158] New: Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36158 Bug ID: 36158 Summary: Text on the "Show SQL code" button at guided_reports.pl breaks if report notice templates exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: jr...@sekls.org QA Contact: testo...@bugs.koha-community.org Created attachment 162386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162386&action=edit Broken text on 'Show SQL code' button When a report notice template exists (using the feature added in bug 34136), if you click the "Show SQL code" button after running a report the text on the button changes to something like "Koha::Notice::Template=HASH(x)" To replicate: - Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] [% b.surname %], [% b.firstname %] Expiration: [% b.dateexpiry %] ID: [% b.borrowernumber %] [% END %] - Create and run a saved report. Example from the other bug: SELECT * FROM borrowers - Click the "Show SQL code" button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 Pedro Amorim changed: What|Removed |Added Keywords||Sandbox --- Comment #16 from Pedro Amorim --- Hey, I've submitted a patch. It's a bit more than a proof of concept as I've tested it quite a bit and I believe it achieves what's required, but a more experienced set of eyes and testers would be great here. I'd love to hear some feedback on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36157] New: Links in the "Run with template" dropdown at guided_reports.pl have odd formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36157 Bug ID: 36157 Summary: Links in the "Run with template" dropdown at guided_reports.pl have odd formatting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: jr...@sekls.org QA Contact: testo...@bugs.koha-community.org Created attachment 162385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162385&action=edit Dropdown formatting differences When using the feature added by bug 34136, the new "Run with template" dropdown has btn classes on the links in the dropdown list which gives it odd formatting compared to the rest of the dropdowns in the toolbar. I attached a screenshot to hopefully better illustrate. To replicate: - Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] [% b.surname %], [% b.firstname %] Expiration: [% b.dateexpiry %] ID: [% b.borrowernumber %] [% END %] - Create and run a saved report. Example from the other bug: SELECT * FROM borrowers - Click on the "Run with template" dropdown and hover the template title. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 162384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162384&action=edit Bug 33431: Fix remaining cases This patch tweaks three remaining cases, that are not covered by tests. To test: 1. Apply this patch 2. Make use of those places => SUCCESS: No behavior change Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 --- Comment #15 from Pedro Amorim --- Created attachment 162383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162383&action=edit Bug 26869: Add items from MARC in BatchUpdateBiblio Test plan, clean k-t-d: Before test, pick a record and confirm it has no items, for this test we're using biblio 79: /cgi-bin/koha/catalogue/detail.pl?biblionumber=79 1) Add a new MARC modification template, visit: /cgi-bin/koha/tools/marc_modification_templates.pl 2) Click 'New template', enter a name and click 'Submit' 3) Click 'New action' 4) Pick 'Add new' and enter '952' as field and 'a' as subfield, enter 'CPL' as value 5) Click 'Add action' 6) Do a batch record modification, visit: /cgi-bin/koha/tools/batch_record_modification.pl 7) Select the tab 'Enter a list of record numbers' and enter '76' 8) On the template, select the template previously created. Click 'continue' 9) Click 'Modify selected records'. Click 'View detail of the enqueued job'. Notice success message is shown with no errors 10) Check the biblio, visit: /cgi-bin/koha/catalogue/detail.pl?biblionumber=79 11) Notice it now has an item with homebranch 'CPL' test with 952 but with other subfields, without subfield 'a' -> confirm 'FK constraint' error is shown, no modification made test with more than one occurrence of 952$a -> confirm 'FK constraint' error is shown, no modification made test with 952$a too long e.g. '' -> confirm 'too long' error is shown test with no 952 mapping -> confirm things work as intended test with 952 mapping plus other tags -> confirm things work as intended prove koha/t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t prove koha/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 162382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162382&action=edit Bug 33431: Make C4::Record use C4::Context->yaml_preference This patch makes what the title says. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Rec* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Attachment #160392|0 |1 is obsolete|| Attachment #160393|0 |1 is obsolete|| Attachment #160394|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 162381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162381&action=edit Bug 33431: Make C4::Circulation use C4::Context->yaml_preference This patch removes manual YAML handling for sysprefs in C4::Circulation. It also makes C4::Context->yaml_preference not warn when undef is retrieved from the sysprefs. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Circulation* => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31415] Script to automate converting holds to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Kyle M Hall changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Kyle M Hall --- This needs to have support for the phone transport as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 --- Comment #36 from Kyle M Hall --- Created attachment 162380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162380&action=edit Bug 23781: (QA follow-up) Implement phone notice in code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 --- Comment #35 from Kyle M Hall --- Created attachment 162379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162379&action=edit Bug 23781: Add phone transport option Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 --- Comment #34 from Kyle M Hall --- Created attachment 162378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162378&action=edit Bug 23781: Make atomic updates executable and perltidy fixes Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Kyle M Hall changed: What|Removed |Added Attachment #159013|0 |1 is obsolete|| Attachment #159014|0 |1 is obsolete|| Attachment #159015|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall --- Created attachment 162377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162377&action=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 Tomás Cohen Arazi changed: What|Removed |Added Blocks||33431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 [Bug 33431] Make code use C4::Context->yaml_preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomás Cohen Arazi changed: What|Removed |Added Depends on||35293 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #16) > I am sorry, this no longer applies. I'll put it on my list to check and push > with higher priority: Caused by bug 35293. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34312] Advanced Editor - Rancor - Restore UNIMARC encoding support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34312 Nick Clemens changed: What|Removed |Added CC||julian.maur...@biblibre.com ||, n...@bywatersolutions.com --- Comment #1 from Nick Clemens --- I do not recreate this in master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36147] Load Austlang dataset from source to make available as authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36147 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Failed QA --- Comment #3 from Martin Renvoize --- This should really be a plugin in my opinion. I don't see why it should be another script added to Core. There is a cron hook that could be used perfectly for this I believe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31391] Staff-side recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Failed QA --- Comment #64 from Martin Renvoize --- I agree with the preference suggestion here. We also need the error messages improveing as highlighting, Failing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30109] Wrong interface in action logs for some staff actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30109 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 Thibaud Guillot changed: What|Removed |Added Component|Circulation |Cataloging CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 --- Comment #1 from Thibaud Guillot --- Created attachment 162376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162376&action=edit Bug 36156 : None value selected on clone field/subfield linked to AV When a field or subfield is linked to a list of authorized values and cloned, the selected value is repeated in the clone. This is linked to the default behavior of Select2Utils, so I've added a precise index (-1) to ensure that no value is selected in the clone. Test plan: 1) Create a repeatable field and subfield and link a list of authorised values to the subfield. 2) Edit a record, clone the field and see which value is automatically selected in the clone. 3) Apply the patch 4) Repeat step 2 Sponsored by : BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 Thibaud Guillot changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36156] New: Duplicate selected value when a field or subfield is cloned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36156 Bug ID: 36156 Summary: Duplicate selected value when a field or subfield is cloned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guil...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hello all, I'm surprised I haven't seen a bug about this, so I'm not 100% sure it's a bug, but I find the behavior inappropriate. When a field or subfield is linked to a list of authorised values (and therefore a select) and is repeatable, the selected value from the select is repeated in the clone. It would be more appropriate to leave the field empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36027] search_for_data_inconsistencies.pl - make each section optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||julian.maur...@biblibre.com --- Comment #11 from Julian Maurice --- Passing arbitrary numbers as command line arguments is not a good UI as it's opaque (no way to guess that "3" means "check item status") and it's very hard to remember what each number does. Also it can make future changes more complicated: for instance if section 3 should be removed, what should we do with this number ? Leave it unassigned and have "gaps" in the sequence ? Re-assign it to another check and break backward compatibility ? IMO it's far better to have option flags. And as the default behavior is to run all checks, those option flags should disable a specific section when given. For instance: --skip-items-branch --skip-age-for-category. Getopt::Long can be used for that Also documentation in POD should be updated and a --help flag should be added to print usage help (see Pod::Usage) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 --- Comment #6 from Pedro Amorim --- (In reply to Julian Maurice from comment #5) > (In reply to Pedro Amorim from comment #4) > > Hi Julian, I've SOed and provided a follow-up. > > Please take a look and see if you agree, or make it obsolete if not. > There is a small difference between your code and mine: in yours, if > budget_owner_id does not correspond to an existing borrower, it will > repeatedly try to fetch it. As there is no foreign key constraint on > budget_owner_id, it can happen. > Quite an edge case, but certainly possible. > I'll let QA decide No, you're right. The point of the patch was to optimize code without changing behavior, but it does. I've made it obsolete! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Pedro Amorim changed: What|Removed |Added Attachment #162373|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36027] search_for_data_inconsistencies.pl - make each section optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #10 from Pedro Amorim --- Putting this as "Needs Signoff" to look at again later and there's no sign-off line by anyone just yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 --- Comment #20 from Kyle M Hall --- (In reply to Andreas Jonsson from comment #19) > We have been running this in a test system of a large coalition of regional > Libraries, but I think that we need a collection of unit tests to > sufficiently test all aspects. It is too tedious to manually walk through > all possible scenarios. I will try to find some more time to work on this. Thanks Andreas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
