[Koha-bugs] [Bug 36100] Regression in bookings edit

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36100

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #162229|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 162633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162633=edit
Bug 36100: Remove readOnly from bookings definition.

Whilst readOnly feels correct here, swagger doesn't work that way at our
version. It must be removed to restore the ability to edit exising
bookings.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Julian Maurice  ---
Thanks for the follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

Julian Maurice  changed:

   What|Removed |Added

 Attachment #162623|0   |1
is obsolete||

--- Comment #7 from Julian Maurice  ---
Created attachment 162632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162632=edit
Bug 35718: Remove ES6 warnings branches.tt

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

Julian Maurice  changed:

   What|Removed |Added

 Attachment #160613|0   |1
is obsolete||

--- Comment #6 from Julian Maurice  ---
Created attachment 162631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162631=edit
Bug 35718: Remove ES6 warns from JS system preferences

To test:
1. Add some JS like this to any of the UserJS system preferences:

$(document).ready( function() {
let something = 1;
const another_thing = 2;

let an_arrow_function = (a, b) => a + b;
console.log( an_arrow_function(something, another_thing) );
});

2. Notice the icons and warnings to the left of the line numbers:

let is available in ES6
const is available in ES6
arrow_function_syntax is available in ES6

3. APPLY PATCH
4. Try steps 1 and 2 again, the warnings should be gone.
5. Check that the JavaScript still works, in my example it should console.log
3.

Signed-off-by: David Nind 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||36210


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36210
[Bug 36210] Add Recalls preferences to Hea usage statistics
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36210] Add Recalls preferences to Hea usage statistics

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36210

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||19532


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36210] New: Add Recalls preferences to Hea usage statistics

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36210

Bug ID: 36210
   Summary: Add Recalls preferences to Hea usage statistics
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Preferences shared with Hea are listed at C4/UsageStats.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||36209


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36209
[Bug 36209] Recalls: Do not force a change to the due date when an item is
recalled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36209] Recalls: Do not force a change to the due date when an item is recalled

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36209

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||19532


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36209] New: Recalls: Do not force a change to the due date when an item is recalled

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36209

Bug ID: 36209
   Summary: Recalls: Do not force a change to the due date when an
item is recalled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When an item is recalled, Koha looks to the relevant due date interval
circulation rule to adjust the checkout's due date.

If the circulation rule for recall due date interval is not defined (empty),
Koha defaults to 5 days.

We should remove this default so that if the circulation rule for recall due
date interval is left empty, then the checkout due date is not adjusted.

This has been prompted by a library who uses recalls in a way that the due date
is not adjusted, but the patron is charged a specific recall fine if they are
late to return it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36208] Add -not_itemtype argument to misc/export_records.pl

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208

--- Comment #2 from Alex Buckley  ---
Test plan and refinements to come.

Not ready for testing yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36208] Add -not_itemtype argument to misc/export_records.pl

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208

--- Comment #1 from Alex Buckley  ---
Created attachment 162629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162629=edit
Bug 36208: Add --not_itemtype argument to misc/export_records.pl

WIP

Sponsored-By: The Treasury, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36208] Add -not_itemtype argument to misc/export_records.pl

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36208] New: Add -not_itemtype argument to misc/export_records.pl

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36208

Bug ID: 36208
   Summary: Add -not_itemtype argument to misc/export_records.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

It is currently possible to pass the --itemtype argument to
misc/export_records.pl to export biblios from a given itemtype. 

It would be nice if libraries pass a --not_itemtype argument to
misc/export_records.pl to exclude exporting biblios with a given item type.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23641] Checkout via camera on device

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641

--- Comment #20 from David Cook  ---
As I mentioned before, we had a library try it and it didn't work well enough
for them.

We did another version using a commercial vendor (Scandit) which worked much
better, although that has on-going costs associated with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23641] Checkout via camera on device

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641

--- Comment #19 from David Cook  ---
(In reply to Lucas Gass from comment #18)
> Very cool, David. Do you we need to add license information to the about
> page ZXing library?

For some reason I thought people meant David Nind. Glad I decided to
double-check the bug. 

Yeah, we'd better do that. This looks like the one:
https://github.com/zxing-js/browser/blob/master/LICENSE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #20 from David Cook  ---
(In reply to Jonathan Druart from comment #13)
> David, isn't the same problem we encountered on 34478? Should not we
> backport "Make Koha::Token use session id not userenv id"?

Yep, 100%. We need to backport it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36098] Create Koha::Session module

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098

David Cook  changed:

   What|Removed |Added

 Blocks||34755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
[Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity
provider : wrong_csrf_token
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

David Cook  changed:

   What|Removed |Added

 Depends on||36098


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36098
[Bug 36098] Create Koha::Session module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36149

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #19 from David Cook  ---
(In reply to David Cook from comment #18)
> Ok this is interesting. Why would another user be logged in?

Ah I know what the problem is now.

So I'm going to keep this as Failed QA because the attached patch is not the
solution. As I mentioned on Comment 11, you've actually bumped into a different
bug which isn't directly related to the OpenID Connect Authentication. 

It is due to a problem with C4::Context->userenv, but I won't get into the
reasons why. 

Leave it to me and Jonathan. We'll take care of it. 

Thanks for your patience on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #18 from David Cook  ---
Comment on attachment 161783
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161783
Bug 34755: Unit tests

Review of attachment 161783:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=34755=161783)
-

::: t/db_dependent/api/v1/idp.t
@@ +309,5 @@
> +$tx->req->cookies( { name => 'CGISESSID', value => $session_id } );
> +$t->request_ok($tx);
> +
> +my $error = 
> URI->new($t->tx->res->headers->location)->query_param("auth_error");
> +isnt($error, "wrong_csrf_token", "CRSF token is recognized even when 
> another user is logged in.");

Ok this is interesting. Why would another user be logged in?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #17 from David Cook  ---
(In reply to David Cook from comment #16)
> I was trying my best to break my sessions, and I did manage to reproduce the
> problem, but I can't recall exactly how. 
> 
> So I'm going to keep trying again (more carefully).

Ok so one way to do it would be to do the following:

1. Go to http://localhost:8080
2. Click "Log in with Keycloak" but don't log in
3. In a new tab, go to http://localhost:8080, and do a local login 
4. Log out of the local login
5. Go back to original tab and complete the Keycloak login

You'll get a wrong_csrf_token because the CGISESSID cookie value has changed. 

An anonymous user becoming an authenticated user will keep the same session ID,
but an authenticated user becoming an anonymous user will lose their session
ID.

You should be getting the wrong_csrf_token warning in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #16 from David Cook  ---
I was trying my best to break my sessions, and I did manage to reproduce the
problem, but I can't recall exactly how. 

So I'm going to keep trying again (more carefully).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

David Cook  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from David Cook  ---
Once again, I cannot reproduce this problem. 

After authenticating in Keycloak, I'm redirected to the Koha endpoint at
http://localhost:8080/api/v1/public/oauth/login/Keycloak/opac which is a GET
request.

My request cookie has a CGISESSID value of 8435418b15fc0280af09f72a5f6c31cd.
This is an anonymous session. 

My response cookie has a CGISESSID value of 1a11450a805d152b0dfcfcc91da3c341.
This is an authenticated session. 

http://localhost:8080/api/v1/public/oauth/login/Keycloak/opac redirects as a
GET request to opac-user.pl. 

Anti-CSRF shouldn't be involved here...

--

I'm looking at Koha/REST/V1/OAuth/Client.pm and it looks OK to me. Personally,
I would use a random value for a "state" parameter and save it to the session.
Using a CSRF token in this case is problematic for a number of reasons I won't
get into here. 

But the thing is... if you're getting wrong_csrf_token here it's because you've
lost your session (well more specifically your userenv since master doesn't yet
have the CSRF session fix Jonathan mentions above) between the time the "state"
parameter was generated and the time the "state" parameter was checked.

That means the test plan given in Comment 2 can't possibly work. 

Which takes me to Comment 10... there was something about navigating around
Koha before posting the SSO login form. 

Now I have no idea why a person would do that, because it makes no sense at
all. If you're clicking "Log in with Keycloak", then I'd just complete the
login. But anyway...

Recently I did notice that there is somewhere in Koha.. I think on the OPAC..
where the cookie isn't returned when it should be and that did cause me some
grief. 

Let me try...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23641] Checkout via camera on device

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #18 from Lucas Gass  ---
Very cool, David. Do you we need to add license information to the about page
ZXing library?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Lucas Gass  ---
Matthias,

I tested this and it seems to work as intended, you sysprefs.sql update looks
good to me.

However, your DBUpdate explanation and type should not be NULL. Sorry to be a
pain!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36194] CSRF - svc

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36194

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
Is it intentional placing these follow-up bugs in "Koha" rather than "Koha
Security"?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #14 from David Cook  ---
(In reply to Jonathan Druart from comment #13)
> David, isn't the same problem we encountered on 34478? Should not we
> backport "Make Koha::Token use session id not userenv id"?

That's what I'm wondering. I haven't been able to reproduce the issue as
described above, but backporting that change might fix it for them. 

I am going to take another look to see if I can reproduce this problem...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316

--- Comment #12 from David Cook  ---
(In reply to Martin Renvoize from comment #11)
> and David, were you happy with the permissions response?

More or less heh.

I think we have some significant design flaws with the REST API (particularly
in terms of admin API vs public API), but that's out of scope for this one I
think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

--- Comment #2 from Lucas Gass  ---
Created attachment 162628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162628=edit
Bug 36082: Set branchcode correctly in opac-facets.inc

1. Tools> HTML Customization
2. Choose OPACresultssidebar
3. Create an entry specific to a library.
4. Also try to add this same entry into a translation tab, if installed.
5. Go to the OPAC
6. Login as a patron of that library that the specific OPACresultsidebar is
assigned to
7. Search the catalog, and look below the facets,where the OPACresultssidebar
would appear.
8. No text.
9. APPLY PATCH
10. Try step 7 again.
11. TEXT!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #159071|0   |1
is obsolete||

--- Comment #14 from Aleisha Amohia  ---
Created attachment 162627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162627=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust
Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #159070|0   |1
is obsolete||

--- Comment #13 from Aleisha Amohia  ---
Created attachment 162626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162626=edit
Bug 32142: Add issued_or_reserved option to HoldFeeMode syspref

Database updates

Signed-off-by: Sam Lau 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

--- Comment #48 from Aleisha Amohia  ---
(In reply to Kelly McElligott from comment #45)
> When searching for a notice in the search filters within the Notice
> Management Tool, several notices appear multiple times.  For example, there
> are 3 HOLD notices.  In the sandbox I am testing in, there is only one HOLD
> notice within the Notices and Slips, so it shouldn't appear three times.  In
> addition, there are two check-in digest and two checkout digest options in
> this drop-down menu.  There are many that only appear once, but some appear
> more than once. I think that the notice should only appear once when the
> library only has one notice.  This list becomes very long with duplicates
> and it is very confusing. 
> 
> Just testing, I did create a library-specific HOLD notice, which appeared in
> the dropdown menu as with all the others with no indication of it being a
> library-specific notice.

Good catch, this was because of the many message transport types that might be
available for a notice. I've fixed that up in latest patches - please test
again when you can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36082] OPACResultsSideBar not working with library specific message

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36082

Lucas Gass  changed:

   What|Removed |Added

Version|unspecified |master

--- Comment #1 from Lucas Gass  ---
Confirmed on current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162574|0   |1
is obsolete||

--- Comment #47 from Aleisha Amohia  ---
Created attachment 162625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162625=edit
Bug 33260: Move patron search into main body of page

This patch moves the patron search in the Notices management page to the main
body of the page so that the patron search result table displays more nicely.

This is a better place for it anyway, as using this search takes the user to a
different page. In the sidebar, where it was previously, it implied it would
have the same results display as the search filters.

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162573|0   |1
is obsolete||

--- Comment #46 from Aleisha Amohia  ---
Created attachment 162624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162624=edit
Bug 33260: Add Notice management tool

This enhancement makes it easy for the library to view sent notices and filter
by various search parameters.

You can also print sent notices, individually or in a batch.

This enhancement uses a new system preference NoticesManagement and a new
view_generated_notices user permission.

This enhancement has been built on top of Bug 33478 so print format settings
are taken into account when printing notices.

To test:
1. Apply patches, install database updates, restart services
2. Make sure your logged in user has the view_generated_notices permission
checked
3. Enable the NoticesManagement system preference
4. Generate a few notices. There are a few ways to do this including:
- place holds, check in items and confirm the holds
- place recalls, check in items and confirm the recalls
5. Go to Tools -> Notices management
6. There are two search functions on the left navigation. Confirm the patron
search box works by searching for one of the patrons you generated a notice
for, you should be redirected to their Notice history.
7. Go back to Notices management. Use the set of search filters to search for
notices. Leaving the search filters empty will return all notices generated.
Confirm the filters work as expected by using different combinations of
filters.
8. Conduct a search so your notices show in a table. Confirm the information
fetched about the notices is correct.
9. Click on a notice title. Confirm the contents of the notice show in a pop-up
box.
10. Click one of the Print buttons next to a notice. Confirm the notice is
opened to be printed.
11. Redo your notices search. Confirm the status of the notice you just printed
has now been updated to 'sent'.
12. Use the 'Select all' and 'Clear all' buttons to select or clear the
checkboxes.
13. Select a few checkboxes and click the button at the bottom of the table to
'Print selected notices'. Confirm the notices have been collated into one
document, separated by horizontal lines, and prints successfully. The statuses
for the notices should all be updated to 'sent'.
14. Confirm the Notices management page is not visible without the
view_generated_notices permission
15. Confirm the Notices management page is not visible without the
NoticesManagement system preference being enabled.
16. Go to a patron's Notices history. If the view_generated_notices user
permission is checked for your logged in patron, you should see a Print button
for each notice. Confirm this works. Confirm this button doesn't show if your
logged in patron does not have the view_generated_notices user permission. It
does not require the NoticesManagement system preference.

17. Go to Tools -> Notices & slips
18. Edit the format settings of a few different notices i.e. HOLD and WELCOME
19. Generate these notices by filling a hold for a patron and sending a welcome
email
20. Search for all notices under Tools -> Notices management
21. Select all notices and print selected notices
22. Confirm the notices different format settings are taken into account in the
printed PDF

Sponsored-by: Colorado Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Marie Martino  changed:

   What|Removed |Added

 CC||martino...@morainevalley.ed
   ||u

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35718] Remove ES6 warnings from JavaScript system preferences

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35718

--- Comment #5 from Lucas Gass  ---
Created attachment 162623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162623=edit
Bug 35718: Remove ES6 warnings branches.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36204] Add othernames to the PatronAutoComplete display

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35145] Add ability to order patron attributes

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

Phan Tung Bui  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #16 from Phan Tung Bui  ---
Hello, 
So per request of the QA, i renamed number to display_order and separate the
DBIC schema file. However, I seem to have accidentally reattached the patch
made by Emily-Rose and Owen Leonard while trying to resolve a merge conflict
earlier, as you can see in my previous comment. Now I'm not sure what to do. 

Please verify that and proceed accordingly. Thank you for your understanding

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060

--- Comment #7 from Lucas Gass  ---
I've tried reproducing the problem as Brendan describes in both Firefox and
Chrome without success.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060

--- Comment #6 from Lucas Gass  ---
(In reply to Brendan Lawlor from comment #5)
> I'm not sure, but maybe the bug I saw where the checkout table reloaded with
> both the renew and checkin box checked for a record could have been caused
> by circ rules that I set up when I tested. I set the circ rule unit to
> hours. I am going to test again with the default ktd circ rules and see if
> the behavior is different.
> 
> If it's not the circ rules, maybe it is just caused by the user following a
> specific, admittedly goofy sequence of actions.
> 
> 
> To reproduce:
> 1. Set the circ rule unit to hours
> 2. Have a few checkouts with at least one overdue
> 3. Load the checkout table and see the overdue item's renew checkbox is
> checked by default
> 4. Change the overdue item's checkbox to check the Check In checkbox instead
> 5. Check the Renew checkbox for a different item
> 6. Click the Renew selected items button
> 7. When the table reloads see both the Renew and Check In checkboxes are
> checked for the overdue item

Sorry Brendan, I am still unable to reproduce this problem following your test
plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35145] Add ability to order patron attributes

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

Phan Tung Bui  changed:

   What|Removed |Added

 Attachment #162619|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35145] Add ability to order patron attributes

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

--- Comment #15 from Phan Tung Bui  ---
Created attachment 162622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162622=edit
Bug 35145 : (follow-up) Rename number to display_order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35145] Add ability to order patron attributes

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

--- Comment #14 from Phan Tung Bui  ---
Created attachment 162621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162621=edit
Bug 35145 : Schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35145] Add ability to order patron attributes

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

Phan Tung Bui  changed:

   What|Removed |Added

 Attachment #162348|0   |1
is obsolete||

--- Comment #13 from Phan Tung Bui  ---
Created attachment 162620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162620=edit
Bug 35145: (follow-up) Quiet perltidy warnings

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35145] Add ability to order patron attributes

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

--- Comment #12 from Phan Tung Bui  ---
Created attachment 162619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162619=edit
- Seperate DBIC file

- Rename “number” to “display_order”

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Lucas Gass  changed:

   What|Removed |Added

 Blocks|35860   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860
[Bug 35860] Checking out an item that to stats patron that is already checked
out results in 2 entries in the stats table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

Lucas Gass  changed:

   What|Removed |Added

 Depends on|35840   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840
[Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn
and statistical patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35860] Checking out an item that to stats patron that is already checked out results in 2 entries in the stats table

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35860

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|In Discussion   |RESOLVED

--- Comment #2 from Lucas Gass  ---
(In reply to Andrew Fuerste-Henry from comment #1)
> To me, use of a statistical patron implies that one is fairly certain that a
> local use should be recorded, so we should record both a local use and a
> return if an item is scanned to a statistical patron while previously
> checked out to another patron.

Andrew, thanks! I think we can just call this one RESOLVED INVALID.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

--- Comment #5 from Lucas Gass  ---
Created attachment 162618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162618=edit
Bug 35950: Adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

Lucas Gass  changed:

   What|Removed |Added

 Attachment #162616|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 162617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162617=edit
Bug 35950: Move AddReturn call into circulation.pl

There should be no change in beahavior. Following the test plan from Bug 35840.

To test:
1. APPLY PATCH, restart_all
2. Turn on RecordLocalUseOnReturn
3. Create a Statistical patron.
4. Check an item out to a regular patron.
5. Check the item out to a Statistical patron.
6. This should trigger a return and you will see 2 entries in the statistics
table, one for localuse and one for a return.
7. Try checking out an item to the Stats patron that is NOT checked out.
8. You should only see 1 entry, localuse, in the statistics table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35659] OAI Harvester

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

Lauren Denny  changed:

   What|Removed |Added

 CC||lauren_de...@sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

--- Comment #3 from Lucas Gass  ---
Created attachment 162616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162616=edit
Bug 35950: Move AddReturn call into circulation.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

--- Comment #13 from Alex Buckley  ---
(In reply to Owen Leonard from comment #10)
> (In reply to Owen Leonard from comment #9)
>  
> > I'm a little bit concerned about using dateaccessioned for sorting
> 
> Ignore me, I wasn't thinking about the fact that there is already a "Date
> added" sorting option.
> 
> I wonder if there is a more user-friendly way to say "Date accessioned?"
> Some way to express that the order is by newest item?

Hi Owen, 

Thanks for your feedback and taking a look!

Looking at your screenshots now.

Do you think 'Date acquired' might be a more helpful wording? Happy to change
the wording.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

--- Comment #8 from Kristi  ---
I was testing in a sandbox, Nick. I think that may answer your second question.
It sounds like perhaps this is best tested in a dev environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] Convert browser alerts to modals: OPAC tags

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

Owen Leonard  changed:

   What|Removed |Added

 Blocks||36166


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36166
[Bug 36166] Disable select to add to list if opacuserlogin is disabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36166] Disable select to add to list if opacuserlogin is disabled

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36166

Owen Leonard  changed:

   What|Removed |Added

 Depends on||36207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207
[Bug 36207] Convert browser alerts to modals: OPAC tags
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Martin Renvoize  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #101 from David Gustafsson  ---
Fixed 4), regarding 2), yes both are needed. Now when I had a look at this also
discovered that modification templates are not applied when saving new biblio
using the advanced editor. Easy to fix, but I am also beginning to reconsider
whether this whole feature is a good idea to begin with. Also kind of wonder
why did not decided to apply the template withing ModBibioMarc as that would
simplify the code. The downside I guess is that templates would even be
applied, even in cases where biblios are saved internally where it does perhaps
do not make sense to do so. Also the error handling and user feedback would be
harder to implement since AddBibio/ModBibio would either have to throw an error
or return some error code and such a major change in behavior could have
unforeseen consequences if not handles correctly in the entire code base.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

--- Comment #2 from Martin Renvoize  ---
There's a new branch on the crontab plugin to use to test this against.. I'll
enlist those trialing it for me to test ;P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36202] Article requests: a SCAN request has no pickup location

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36202

--- Comment #2 from Martin Renvoize  ---
Oops.. bug number typo

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36202] Article requests: a SCAN request has no pickup location

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36202

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Attachment #162614|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

--- Comment #1 from Martin Renvoize  ---
Created attachment 162615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162615=edit
Bug 36206: Add 'admin' plugins option

This patch adds an admin plugins class to the plugins system and
displays such plugins under the 'Plugins' section in the Administration
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36202] Article requests: a SCAN request has no pickup location

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36202

--- Comment #1 from Martin Renvoize  ---
Created attachment 162614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162614=edit
Bug 36202: Add 'admin' plugins option

This patch adds an admin plugins class to the plugins system and
displays such plugins under the 'Plugins' section in the Administration
page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] Convert browser alerts to modals: OPAC tags

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

Owen Leonard  changed:

   What|Removed |Added

 Depends on||34478

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26824] Use confirmation modal when removing titles from a list in the OPAC

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26824

Owen Leonard  changed:

   What|Removed |Added

 Blocks||36207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207
[Bug 36207] Convert browser alerts to modals: OPAC tags
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36207] New: Convert browser alerts to modals: OPAC tags

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207

Bug ID: 36207
   Summary: Convert browser alerts to modals: OPAC tags
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 26824

I propose to update the OPAC user tags page so that JavaScript alerts are
replaced by modal confirmation dialogs.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26824
[Bug 26824] Use confirmation modal when removing titles from a list in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #100 from David Gustafsson  ---
Created attachment 162613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162613=edit
Bug 18138: Display error when template missing in advanced editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson  changed:

   What|Removed |Added

 Attachment #158421|0   |1
is obsolete||

--- Comment #99 from David Gustafsson  ---
Created attachment 162612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162612=edit
Bug 18138: (QA follow-up) Perltidy and 'staff client'

* Perltidies files
* Fix atomic update (description and success message)
* Fix atomic update file permissions
* Update 'staff client' to 'staff interface'

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

--- Comment #20 from Andrew Fuerste-Henry  ---
If we were creating items from a 952 while importing a new bib, which item
fields, if any, would be required? It makes sense to me to have this process
match those requirements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out'

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #7 from Nick Clemens  ---
(In reply to Kristi from comment #3)
> In testing, I do not see 11 - Note the table now say 'Item was not checked
> in' and displays the due date and patron info
> 12 - Note the table also includes the withdrawn value for the item.
> Screenshot attachment to come.

This works for me in my testing - did you test on a sandbox, or a local dev
environment? Can you confirm plack/memchaced were restarted after the patch was
applied?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] New: Administrative plugins

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Bug ID: 36206
   Summary: Administrative plugins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

It would be beneficial to have an 'administrative' plugin type akin to 'tools'
and 'reports' plugins. This would allow for adding an administrative plugin to
the administration pages as opposed to having to expose it under tools.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36205] New: Plugins should be able to create permissions

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36205

Bug ID: 36205
   Summary: Plugins should be able to create permissions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Some plugins expose additional functionality that should only be exposed to
users with permission to access them.

We could perhaps allow plugins to add sub-permissions to the existing 'plugins'
flag to facilitate this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34962] Add a system messages feature to Koha to report issues and failures in a more visible way

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34962

--- Comment #3 from Kyle M Hall  ---
I think for an initial development, we could show a table of messages with the
date/time, a "component" ( basically the module of Koha this is part of ), and
the message itself.

For example, if EDI can't connect to an FTP server for a vendor EDI profile,
would could have a component of "Acquisitions/EDI" and a message like "Unable
to connect to remote server: Failed to connect to $vendor_ftp_host for
$vendor_description ($vendor_id)".

It seems like anything connection to an external service should take advantage
of this kind of feature.

Table columns could be something like:
timestamp
component
message
cleared (timestamp)

The screen would have a "clear all" button to set cleared. Cleared messages
would not show in the staff interface, but would remain in the table until the
cleared messages are deleted by the cleanup database cronjob.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

--- Comment #6 from Matthias Le Gac  ---
Lucas, 

Tell me if the update of sysprefs.sql is good. It's the first time I am doing
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

--- Comment #5 from Matthias Le Gac  ---
Created attachment 162611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162611=edit
Bug 35169: update sysprefs.sql

Test Plan :

1 - Apply the patch
2 - Go to Koha administration > System preferences > Circulation > Checkout
policy
3 - Set "DefaultLongOverdueLostValue" to "Lost" and "DefaultLongOverdueDays" to
"2"
4 - Check out an item to a patron and set the date to more than two days.
5 - Remember the category of the patron

Test of DefaultLongOverdueBorrowerCategories option :
6 - Go to Koha administration > System preferences > Circulation > Checkout
policy
7 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron
8 - Go to the terminal in the koha environment and execute the script
"./misc/cronjobs/longoverdue.pl"
9 - Normaly you see in list the check out item set just before and the list
it's only borrowers with the category

Test of DefaultLongOverdueSkipBorrowerCategories option :
10 - Go to Koha administration > System preferences > Circulation > Checkout
policy
11 - Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the
patron
12 - Go to the terminal in the koha environment and execute the script
"./misc/cronjobs/longoverdue.pl"
13 - Normaly you don't see in list the check out item set just before and the
list it's only borrowers with others categories

Test of warning :
14 - Go to Koha administration > System preferences > Circulation > Checkout
policy
15 - Set "DefaultLongOverdueBorrowerCategories" to the category of the patron
and Set "DefaultLongOverdueSkipBorrowerCategories" to the category of the
patron
16 - Go to the terminal in the koha environment and execute the script
"./misc/cronjobs/longoverdue.pl"
17 - Normaly you don't see in list the check out item set just before because
the "DefaultLongOverdueSkipBorrowerCategories" take advantage of
"DefaultLongOverdueBorrowerCategories"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36204] Add othernames to the PatronAutoComplete display

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36204] Add othernames to the PatronAutoComplete display

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204

--- Comment #1 from Lucas Gass  ---
Created attachment 162610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162610=edit
Bug 36204: Add othernames field to PatronAutoComplete display

To test:
1. APPLY PATCH
2. Make sure PatronAutoComplete is on.
3. Find or add othernames to a patron record.
4. Search for that patron and make sure othernames properly displays in the
dropdown.
5. Add a middle name to that patron and search again, make sure the display
looks good.
6. Remove the othernames field and search again, make sure the display looks
good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

--- Comment #19 from Esther Melander  ---
I would sign-off because the test plan works. This is an exciting enhancement
but there were a few things I noticed that may be worth discussion first.

The test plan works through step 11 and an item is created. The item created
defaulted to the 952$y item type Book, even though only the 952$a is in the
action. That may not always be the correct item type, though it is probably
better for something to be assigned than nothing.

Then I created a template with actions to add the 952$a and other subfields
including adding the item type 952$y as configured. The items were created
correctly.

I duplicated the previous template and removed the action to include the 952$a.
Items were created with no error message. I tested removing other subfields and
items were created.

The test plan implies the 952$a is required to create an item, but I was able
to create an item with only the 952$8. The caveat is the item defaulted to the
Book item type for the 952$y again.

If the item type is required, as it is added regardless, how can the user be
alerted so they can select the correct item type before the items are added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36204] New: Add othernames to the PatronAutoComplete display

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36204

Bug ID: 36204
   Summary: Add othernames to the PatronAutoComplete  display
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some librarians would like to able to see the othernames field in the
PatronAutoComplete dropdown to help differentiate between patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

--- Comment #16 from Pedro Amorim  ---
Created attachment 162609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162609=edit
Bug 34920: Add cypress tests

Run the agreements cypress test spec:

cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36079] Library hours and the Calendar are not linked in any meaningful ways

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36079

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

--- Comment #15 from Pedro Amorim  ---
I'm unable to attach the following patch:
https://github.com/PTFS-Europe/koha/commit/9d1047e1eb3e604868602a60ffd2cd04e0801a84

Error:
413 Request Entity Too Large

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

--- Comment #14 from Pedro Amorim  ---
Created attachment 162608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162608=edit
Bug 34920: Ensure 'description' property is an empty string if 'lib' is null

Test plan:
1. Enable ERM module
2. Confirm that you can open the ERM module in the staff interface.
3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit
the 'Cancelled' authorized value by removing the description. Making this
change with any of the ERM authorized values will result in an error.
4. Go back to the ERM module and notice that there is an error. 'Something went
wrong: Error: Expected string - got null.'
5. Apply patch. Run yarn js:build. Repeat test plan
6. Create a new agreement. Pick status 'Closed'.
7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty
entry below that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

--- Comment #12 from Owen Leonard  ---
Created attachment 162607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162607=edit
Different list sort in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36188] Allow to sort lists by items.dateaccessioned of item records

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188

--- Comment #11 from Owen Leonard  ---
Created attachment 162606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162606=edit
List sort in the staff interface

Note that I edited one item in each record to have the same dateaccessioned.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

--- Comment #13 from Pedro Amorim  ---
Created attachment 162605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162605=edit
Bug 34920: Add API endpoint tests

prove koha/t/db_dependent/api/v1/authorised_values.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

2024-02-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920

--- Comment #12 from Pedro Amorim  ---
Created attachment 162604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162604=edit
Bug 34920: Return sorted av_cats to be able to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >