[Koha-bugs] [Bug 36206] Administrative plugins

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

--- Comment #9 from Martin Renvoize  ---
(In reply to David Cook from comment #7)
> (In reply to Martin Renvoize from comment #6)
> > Currently this is easiest to test using the in-development crontab manager
> > plugin, admin_plugin branch:
> > https://github.com/PTFS-Europe/koha-plugin-crontab/tree/admin_plugin
> 
> Can't locate Config/Crontab.pm in @INC (you may need to install the
> Config::Cron
> tab module)
> 
> sudo apt-get install libconfig-crontab-perl
> 
> sudo sh install_plugins.sh
> 
> No crontab found, installing default at
> /var/lib/koha/kohadev/koha-plugin-crontab/Koha/Plugin/Com/PTFSEurope/Crontab.
> pm line 140.
> Writing crontab: # This crontab file is managed by the Koha Crontab manager
> plugin
> 
> # BLOCKID: 0
> PERL5LIB=/usr/share/koha/lib
> KOHA_CRON_PATH=/usr/share/koha/bin/cronjobs
> KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
> Installed Crontab version {VERSION}
> All plugins successfully re-initialised

Yeah, I also have a work-in-progress branch that attempts to use
Module::Load::Conditional to output a nicer warning in the UI when the library
is missing... that or I'm considering bundling Config::Crontab into the plugin
itself.. so far I've not come up with a nice solution for plugins that have
cpan dependencies.. any idea's on a nice way to handle such cases would be
awesome.

Anyway, it looks like you managed to get there on the install and the default
template was installed (it'll check for local crontab and load that, or it'll
load a very basic template if one isn't found.. local crontab = whatever you
may have added to a crontab using koha-shell for example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22514] Hardcoded value of 10 for return hour when calculating hourly loans affected by holidays

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22514

--- Comment #2 from Ray Delahunty  ---
Lack of properly working hourly loans functionality in Koha is a major problem
for us. To prevent items being due back on weekends, all of our 8 libraries
have every weekend day set to be closed days even though the libaries are open,
and loaning hundreds of 5 hourly loans daily (mainly laptops). A fix to this
bug would help reduce patron confusion with loan periods. But fully working
hourly loans needs other fixes including those discussed in bug 6796 and bug
9725. And I suspect others.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29510] objects.find should call search_limited if present

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510

Fridolin Somers  changed:

   What|Removed |Added

Version|unspecified |master
  Group|Koha security   |
  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34623] Update jQuery-validate plugin to 1.20.0

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34623

Fridolin Somers  changed:

   What|Removed |Added

  Component|Koha|Architecture, internals,
   ||and plumbing
  Group|Koha security   |
Product|Koha security   |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34623] Update jQuery-validate plugin to 1.20.0

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34623

Fridolin Somers  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34623] Update jQuery-validate plugin to 1.20.0

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34623

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.03,23.05.09,
released in||22.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35890] AutoLocation system preference + setting the library IP field - can still login and unexpected results

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.03,23.05.09,
released in||22.11.15,22.05.19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation configured using the same IP

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.03,23.05.09,
released in||22.11.15,22.05.19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29510] objects.find should call search_limited if present

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34623] Update jQuery-validate plugin to 1.20.0

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34623

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35890] AutoLocation system preference + setting the library IP field - can still login and unexpected results

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation configured using the same IP

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29510] objects.find should call search_limited if present

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34623] Update jQuery-validate plugin to 1.20.0

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34623

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35890] AutoLocation system preference + setting the library IP field - can still login and unexpected results

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation configured using the same IP

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29510] objects.find should call search_limited if present

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34623] Update jQuery-validate plugin to 1.20.0

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34623

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35890] AutoLocation system preference + setting the library IP field - can still login and unexpected results

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation configured using the same IP

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29510] objects.find should call search_limited if present

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |Pushed to oldoldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35890] AutoLocation system preference + setting the library IP field - can still login and unexpected results

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |Pushed to oldoldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35918] Incorrect library used when AutoLocation configured using the same IP

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35918

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |Pushed to oldoldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35941] OPAC user can guess clubs of other users

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35941

Fridolin Somers  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com
Product|Koha security   |Koha
  Group|Koha security   |
  Component|Koha|Patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35941] OPAC user can guess clubs of other users

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35941

--- Comment #9 from Fridolin Somers  ---
(In reply to Frédéric Demians from comment #8)
> Complex to backport to 22.11 due to patch 33895 which changed a lot of code.
> Is that bad if it's not backported?

I see it in now in 22.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35941] OPAC user can guess clubs of other users

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35941

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|24.05.00|24.05.00,23.11.03
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35941] OPAC user can guess clubs of other users

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35941

--- Comment #10 from Fridolin Somers  ---
@Lucas

I don't see this in 23.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36072] Can request articles even if ArticleRequests is off

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36072

Fridolin Somers  changed:

   What|Removed |Added

  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha
Version|unspecified |master
  Group|Koha security   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36072] Can request articles even if ArticleRequests is off

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36072

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|24.05.00,23.11.03   |24.05.00,23.11.03,23.05.09,
released in||22.11.15,22.05.19

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36072] Can request articles even if ArticleRequests is off

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36072

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36072] Can request articles even if ArticleRequests is off

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36072

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |Pushed to oldoldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36193] CSRF - Code review missed

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36193

--- Comment #3 from Nick Clemens  ---
(In reply to David Cook from comment #2)
> I'm not sure if I fully understand. It looks like bug 34478 accidentally
> broke the Oauth/OIDC SSO, so I've fixed it on bug 36219. Should I have added
> that patch here instead?

The idea was simply to reduce the number of bugs filed, for what will likely be
similar patches - it is perfectly okay that you filed a new bug, and it is for
a distinct issue, and you linked it to the others. This is going to be a bit
messy, so we just do our best to keep things clear and simple, and I think you
did.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Katrin Fischer  changed:

   What|Removed |Added

 CC||christian.stelzenmueller@bs
   ||z-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

--- Comment #35 from Nick Clemens  ---
(In reply to Barbara Johnson from comment #34)
> I tested this in a ByWater sandbox but am getting an error. I used the test
> plan from comment 27. In step 9 I am getting an error when saving on
> addorderiso2709.pl that says 'Some required item subfields are not set.' The
> only field that displays required next to it is budget_code which is already
> filled in from the xml file. I tried changing the budget_code to a different
> value but still got the error. I tried globally changing the budget_code via
> the 'Default accounting details' setting but am still getting the error
> message. 
> 
> I also noticed that the price (949$g) and replacementprice (949$v) were not
> populated on addorderiso2709.pl. I tried entering prices for those fields
> but that also did not clear the error.
> 
> In case it matters, I also saw that the data in the xml file contained
> barcodes in the 949$p but those did not populate on addorderiso2709.pl.

Hi Barbara, I think you might be seeing bug 32209 - can you try setting the
itemtype field in the item information tab?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36219] State parameter broken for OIDC/Oauth

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com

--- Comment #2 from Jonathan Druart  ---
I confirm that the changes made to Koha/REST/V1/OAuth/Client.pm in the
following commit were not expected!

  commit 7e7159bf58f2dd1172737d0abe4bcfa15237c88e
  Bug 34478: Remove generate_csrf from pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675

--- Comment #13 from Jonathan Druart  ---
No tests => regression later!
bug 36219.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36219] State parameter broken for OIDC/Oauth

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36219] State parameter broken for OIDC/Oauth

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #162709|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 162711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162711&action=edit
Bug 36219: Re-add missing state param for Oauth/OIDC client

This change restores the csrf token added as the state param for
the OAuth/OIDC client.

Test plan:
0. Apply the patch and restart Starman
1. Test the SSO using the wiki guide

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #27 from Jonathan Druart  ---
Olivier, please test this (with bug 36098) as soon as you can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30353] Enhance BiblioItemtypeInfo so that item level itypes can be displayed in results

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30353

Katrin Fischer  changed:

   What|Removed |Added

Version|20.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #13)
> No tests => regression later!
> bug 36219.

:-(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #161 from Jonathan Druart  ---
Same tests are still failing with those 2 patches, rescheduling another run to
see if it's a random failure (I don't recreate locally).


Also noted the following JS error in the log, which is not expected at all
being superlibrarian:

selenium_1   | JavaScript error:
http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha//members/members-home.pl,
line 2756: TypeError: libraries_map[data] is undefined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36084] Pass CSRF token to SVC scripts (1/2)

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084

--- Comment #38 from Tomás Cohen Arazi  ---
Created attachment 162712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162712&action=edit
Bug 36084: Fix cookie domain for www/ tests

This patch changes the hardcoded `koha.local` value on
t::lib::Mocks::Zebra so tests don't fail when the domain is not `koha`.

To test:
1. Run:
   $ ktd --shell
  k$ export KOHA_INTRANET_URL=http://kohadev-intra.myDNSname.org:8081
  k$ prove t/db_dependent/www/batch.t
=> FAIL: Tests fail!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32928] Filters missing in SQL builder on Orders::filter_by_active

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32928

--- Comment #4 from Fridolin Somers  ---
(In reply to Fridolin Somers from comment #3)
> Oups there is a typo.
> Backslash there :
> +'quantityreceived' => { '<' => \'me.quantity' }

Forget that, it is a string ref, completely normal :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36084] Pass CSRF token to SVC scripts (1/2)

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36084

--- Comment #39 from Jonathan Druart  ---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #162 from Jonathan Druart  ---
Created attachment 162713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162713&action=edit
Bug 35329: Fix autocomplete when placing a hold

There was a JS error
Uncaught TypeError: node.autocomplete(...).data(...) is undefined

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36193] CSRF - Code review missed

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36193

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36195] CSRF - testing reports

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36219] State parameter broken for OIDC/Oauth

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #163 from Jonathan Druart  ---
Created attachment 162714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162714&action=edit
Bug 35329: Fix selenium tests if no fund exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36219] State parameter broken for OIDC/Oauth

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||34478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478
[Bug 34478] Full CSRF protection
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||36219


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219
[Bug 36219] State parameter broken for OIDC/Oauth
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36219] State parameter broken for OIDC/Oauth

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36219

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

--- Comment #4 from Jonathan Druart  ---
Pushed to master for 24.05.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #164 from Jonathan Druart  ---
Last 2 patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36220] New: Connect cover_images and uploaded_files

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36220

Bug ID: 36220
   Summary: Connect cover_images and uploaded_files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

When a local cover image is uploaded, the image ("full" and thumbnail) and the
connection to the biblio record are stored in the "cover_images" table: 
https://schema.koha-community.org/23_11/tables/cover_images.html

Some information is also stored in the "uploaded_files" table:
https://schema.koha-community.org/23_11/tables/uploaded_files.html

Would it not make sense to connect these to, so cover_images contained a
reference to the relevant entry in  uploaded_files? That way we could also make
a connection from biblionumber to any existing files in "tmp_path" directories.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] New: Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Bug ID: 36221
   Summary: Improve styling of Standard backend create form
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pedro.amo...@ptfs-europe.com
CC: pedro.amo...@ptfs-europe.com
Depends on: 35725


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725
[Bug 35725] ILL - Generic master form does not keep patron and cardnumber when
changing type
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||36221


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221
[Bug 36221] Improve styling of Standard backend create form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

--- Comment #1 from Pedro Amorim  ---
Created attachment 162715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162715&action=edit
Bug 36221: Preparation

This refactors the code for more DRY

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

--- Comment #2 from Pedro Amorim  ---
Created attachment 162716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162716&action=edit
Bug 36221: OPAC Styling

Test plan, dont apply patches yet:
1) Enable ILLModule
2) Create a new OPAC ILL request, visit:
/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
3) Notice the style. Apply patches. Repeat

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36197] Allow for OPAC unauthenticated ILL request

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197

Pedro Amorim  changed:

   What|Removed |Added

 Depends on|35570   |36221


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570
[Bug 35570] Add a generic master form in ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221
[Bug 36221] Improve styling of Standard backend create form
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35570] Add a generic master form in ILL

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570

Pedro Amorim  changed:

   What|Removed |Added

 Blocks|36197   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197
[Bug 36197] Allow for OPAC unauthenticated ILL request
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||36197


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197
[Bug 36197] Allow for OPAC unauthenticated ILL request
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record has at least one hold already"

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

--- Comment #15 from Philip Orr  ---
Looks good now, thanks.
Test plan is good, all tested OK for me.
Running qa, all changes look good.

However tests do not pass for GetReserveFee.t:

´´´
Running tests (1)
* Proving /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t KO!

#   Failed test 'HoldFeeMode=not_always, Patron 2 should not be charged'
#   at /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t line 113.
#  got: '2'
# expected: '0'
 # Looks like you failed 1 test of 8.

#   Failed test 'GetReserveFee'
#   at /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t line 138.
 # Looks like you failed 1 test of 3.
 /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
 /kohadevbox/koha/t/db_dependent/Reserves/GetReserveFee.t (Wstat: 256 Tests: 3
Failed: 1)
  Failed test:   1
  Non-zero exit status: 1
 Files=1, Tests=3,  5 wallclock secs ( 0.02 usr  0.00 sys +  3.74 cusr  0.22
csys =  3.98 CPU)
 Result: FAIL
```

Also, I'm not sure about comma rules.. but I think the option in HoldFeeMode
should be "either if all items are checked out or the record has at least one
hold already." (that is, with no comma before the or)
Maybe a QA person can clarify? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36222] New: Add GET route for star ratings

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36222

Bug ID: 36222
   Summary: Add GET route for star ratings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
CC: tomasco...@gmail.com

It should be possible to get the existing rating for a bibliographic record via
the REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36223] New: Add GET route for local cover images (bibliographic records)

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36223

Bug ID: 36223
   Summary: Add GET route for local cover images (bibliographic
records)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
CC: tomasco...@gmail.com

Koha allows to store local cover images for books and items. It would be great
if we could provide a route to get the local cover images for bibliographic
records. That would allow embedding them in external discovery interfaces and
catalog interfaces.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30299] Create a Registration API to allow for use of email verification when outside systems are registering patrons

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30299

--- Comment #2 from Katrin Fischer  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

Olivier Hubert  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #28 from Olivier Hubert  ---
Neither this bug (34755) nor 36098 applies on a fresh master. Both have
conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?)

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012

--- Comment #8 from Jonathan Druart  ---
Koha_Master/2804

koha_1   |   

[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

Jonathan Druart  changed:

   What|Removed |Added

Version|master  |23.11

--- Comment #29 from Jonathan Druart  ---
(In reply to Olivier Hubert from comment #28)
> Neither this bug (34755) nor 36098 applies on a fresh master. Both have
> conflicts.

Master already has this change. This bug is only for backport. You need 23.11.x
to test this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35484] OPACShelfBrowser secondary sort should be biblio.title not item.itemnumber

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35484

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35484] OPACShelfBrowser secondary sort should be biblio.title not item.itemnumber

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35484

--- Comment #1 from Lucas Gass  ---
Created attachment 162717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162717&action=edit
Bug 35484: Make secondary sort use biblio.title

To test:
1. In k-t-d, set all item itemcallnumbers to the same thing, ie: 'abcdefg';
2. Touch all items to update the cn_sort values
3. Turn on OPACShelfBrowser and view a record detail page on the OPAC.
4. Browse the shelf and see that all items are organized by itemnumber.
5. APPLY PATCH and restart_services
6. Try again, now the secondary sort should be using biblio.title, not
itemnumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35484] OPACShelfBrowser secondary sort should be biblio.title not item.itemnumber

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35484

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

Olivier Hubert  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #30 from Olivier Hubert  ---
This looks like it's fixed, in 23.11.x. With the patches from this bug and
36098, I was not able to reproduce the issue. SSO works as it should.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36224] New: It looks like spsuggest functionality was removed years ago, but the templates still refer to it

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36224

Bug ID: 36224
   Summary: It looks like spsuggest functionality was removed
years ago, but the templates still refer to it
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

opac-search.tt still refers to spsuggest but the git logs suggest the
functionality was never fully implimented and the system preferences were
removed long ago.. but they missed the template block.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36224] It looks like spsuggest functionality was removed years ago, but the templates still refer to it

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36224

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co
   |ity.org |m
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162521|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 162718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162718&action=edit
Bug 35963: Add tests

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162522|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 162719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162719&action=edit
Bug 35963: Fix bundled items table ordering and filtering

Using the many-to-many relationship results in the table alias `me` to
be used for table `item_bundles` instead of the expected table `items`.
This causes ordering and filtering to fail for columns Callnumber and
Barcode.
Using Koha::Items->search does not have this problem.

This patch also disables ordering by status because it does not work
(error message is: "Cannot find Koha::Object class for return_claim'")

Test plan:
1. Create an item bundle
  
https://koha-community.org/manual/23.11/en/html/circulation.html#circulating-bundles
2. Add at least 2 items to this bundle
3. Verify that ordering/filtering by callnumber or barcode works
4. Run `prove t/db_dependent/api/v1/items/bundled_items.t`

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162523|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 162720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162720&action=edit
Bug 35963: (QA follow-up): tidy up code and fix exec permission

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35568] Add a plugin hook to allow modification of notices created via GetPreparedLetter

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35568

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #159932|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 162721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162721&action=edit
Bug 35568: Add a transform_prepared_letter plugin hook to allow modification of
notices created via GetPreparedLetter

A plugin hook for GetPreparedLetter would be very useful. It could be used to
add universal headers and/or footers to messages, attach news, and modify
notices in other ways in whole or in part. It could even be used for call
webhooks when certain types of notices are sent.

For example, the MessageBee ( https://uniquelibrary.com/messagebee/ ) plugin
for Koha generates YAML based notice content, which is then further processed
by the before_send_messages hook. This process is unreliable due to the
possible changes in data between the creation of the yaml and the reading of
that yaml and transforming it into JSON with much more data. For example, the
yaml may contain an issue_id, but that checkout may have been returned in the
meantime. A hook like this would allow the MessageBee plugin to skip the yaml
step and create the json data directly which is then sent to MessageBee for
transmission to the patron.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Plugins/Transform_prepared_letter_hook.t
3) Download and install the Kitchen Sink plugin v2.4.0
  
https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases/tag/v2.4.0
4) Generate any notice or slip, such as a checkin or checkout notice
5) Note that all notices now end with "Thanks for using your local library!"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35963] Problem using some filters in the bundled items table

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

--- Comment #9 from Martin Renvoize  ---
Thanks chaps, Passing QA here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create form

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, nug...@gmail.com,
   ||tomasco...@gmail.com,
   ||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24644] Hold not marked filled if item set to positive not for loan value

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #41 from Lucas Gass  ---
Created attachment 162722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162722&action=edit
Bug 33703: Don't use Maskito when picking a range

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #42 from Lucas Gass  ---
Created attachment 162723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162723&action=edit
Bug 33703: Add Maskito to dateaccessioned.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 Attachment #156411|0   |1
is obsolete||
 Attachment #156412|0   |1
is obsolete||
 Attachment #156413|0   |1
is obsolete||
 Attachment #157132|0   |1
is obsolete||
 Attachment #157206|0   |1
is obsolete||
 Attachment #157746|0   |1
is obsolete||

--- Comment #43 from Lucas Gass  ---
Created attachment 162724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162724&action=edit
Bug 33703: Add Maskito support for OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #44 from Lucas Gass  ---
Created attachment 162725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162725&action=edit
Bug 33703: Add Maskito to about.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36225] New: Koha should warn if item group has holds group is being deleted

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36225

Bug ID: 36225
   Summary: Koha should warn if item group has holds group is
being deleted
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
1. Have item hold groups enabled.
2. Have a hold on an item group on a record.
3. Delete the item group - no warning of existing holds.
4. Hold is now a bib-level hold.

In some cases, this may be desirable behavior (like a library using one record
for multiple year editions), but in others, like volumes of a work, this
now-bib-level hold is not what the patron needs. Best solution would be a
warning with option for the librarian to either cancel hold or transform into
bib-level hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36225] Koha should warn if item group with holds on that group is being deleted

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36225

he...@bywatersolutions.com changed:

   What|Removed |Added

Summary|Koha should warn if item|Koha should warn if item
   |group has holds group is|group with holds on that
   |being deleted   |group is being deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36226] New: Large patron databases create difficult patron auto-complete searches

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36226

Bug ID: 36226
   Summary: Large patron databases create difficult patron
auto-complete searches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Large library systems or consortium are seeing issues with patron name
searches. For example, if staff look for a patron with the name of "John Smith"
the autocomplete feature will show the first 10 results of patrons with the
name "John Smith" or similar names like "Johnny Smith". However, if they search
for a name such as "Mary Maryilyn" the search will not pull up the correct
patron. The autocomplete will pull up names with "Mary" or "Maryilyn" but not
the name itself. A regular patron search will also result in several pages of
results instead of the one unique name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36226] Large patron databases create difficult patron auto-complete searches

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36226

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36227] New: No warning if placing hold on item group with no items

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227

Bug ID: 36227
   Summary: No warning if placing hold on item group with no items
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It is currently possible to place a group-level hold on an item group with no
items in it, both from the staff client and OPAC. This results in a hold that
is not fillable unless the item group is deleted or an item is added into it. A
warning would be helpful so patrons aren't left with an unfillable hold.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161619|0   |1
is obsolete||

--- Comment #45 from Lucas Gass  ---
Created attachment 162726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162726&action=edit
Bug 33703: Add Masikto core/kit for date masking

To test:
1. Apply patch
2. Restart all, clear browser cache
3. In the staff interface start testing some flatpickr instances with direct
inputs.
4. Try entering your dates without delimiters, '/' or '-', or '.'.
5. Make sure the dates are well formed.
6. Test with each of dateformat's Koha supports. ( system preference
'dateformat').
7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates
are well formed.
8. Make an item bookable by going to the item tab of a record and setting at
least 1 item to "Bookable:".
9. Now "Place booking", which should trigger a modal.
10. In the "Period" date picker, which is a range, the dates should NOT be
formatted.
11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect )

Some places to test:
-Patron record date of birth
-Patron record registration date
-Patron record expiry date
-Checkouts, manually set a due date
-Patron category, enrollment period

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161663|0   |1
is obsolete||

--- Comment #46 from Lucas Gass  ---
Created attachment 162727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162727&action=edit
Bug 33703: Add time support

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2024-03-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 Attachment #162722|0   |1
is obsolete||

--- Comment #47 from Lucas Gass  ---
Created attachment 162728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162728&action=edit
Bug 33703: Don't use Maskito when picking a range

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >