[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #162944|0   |1
is obsolete||

--- Comment #22 from Marcel de Rooy  ---
Comment on attachment 162944
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162944
Bug 33898: (follow-up) Apply same solution to es_indexer_daemon

Oops this still needs a bit of attention

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898

--- Comment #23 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #22)
> Comment on attachment 162944 [details] [review]
> Bug 33898: (follow-up) Apply same solution to es_indexer_daemon
> 
> Oops this still needs a bit of attention

Ah I see $pm is not even used in the es_indexer_daemon..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)||23.11.04
released in||

--- Comment #9 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159528|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 162945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162945&action=edit
Bug 33544: Replace title details with one column

Combine the request title details fields into onea column for display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159529|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 162946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162946&action=edit
Bug 33544: Update columns_settings.yml

Wonder if year should be out of the details? In case we want to sort by year,
its not sortable anyway at the moment but we need to keep in mind that fields
bundled here will not be sortable. It does not seem to cause any issues on
searching at first glance, at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #159530|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 162947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162947&action=edit
Bug 33544: Link title in details to biblio

This patch removes the biblio id column and instead adds the biblio link
to the title field in the request details column when appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544

--- Comment #17 from Martin Renvoize  ---
Just a quick rebase here now that master has moved again.. I couldn't replicate
your bug I'm afraid though Lisette. I'll try to swing back around and dig a
little deeper when I get a moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35248] Bookings needs unit tests

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248

--- Comment #67 from Martin Renvoize  ---
I just applied the whole tree this morning against the current master and it
was seamless.. not sure what problems your facing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2244] RFID Cataloguing - Programming RFID tags from Koha

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244

Jan Kissig  changed:

   What|Removed |Added

 CC||bibliot...@th-wildau.de

--- Comment #10 from Jan Kissig  ---
if there is any

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Depends on|35725   |36221


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725
[Bug 35725] ILL - Generic master form does not keep patron and cardnumber when
changing type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221
[Bug 36221] Improve styling of Standard backend create OPAC form
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35725] ILL - Generic master form does not keep patron and cardnumber when changing type

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35725

Pedro Amorim  changed:

   What|Removed |Added

 Blocks|35604   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604
[Bug 35604] ILL - Allow for automatic backend selection
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||35604


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604
[Bug 35604] ILL - Allow for automatic backend selection
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35862] Display patron search result on the right of the form (modal)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862

--- Comment #7 from Martin Renvoize  ---
I like the 100% myself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||36270


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270
[Bug 36270] Remove special handling for <>
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36270] Remove special handling for <>

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||30657


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657
[Bug 30657] Make patron attributes available via Template Toolkit in overdues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

Martin Renvoize  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com
 Blocks|36270   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270
[Bug 36270] Remove special handling for <>
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36270] Remove special handling for <>

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|30657   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657
[Bug 30657] Make patron attributes available via Template Toolkit in overdues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32611] Not for loan items don't show the specific not for loan value in OPAC detail page

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32445

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32611

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33575] Add table settings to the holds table for a specific record in the staff interface

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575

lasse.po...@koha-suomi.fi changed:

   What|Removed |Added

 CC||lasse.po...@koha-suomi.fi

--- Comment #17 from lasse.po...@koha-suomi.fi ---
Is there a reason why pagination is explicitly turned off ("bPaginate":false)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

--- Comment #7 from Martin Renvoize  ---
There are already a couple of options here I believe.. but I think we should
perhaps make it simpler/clearer.

You can use all accessors available from the Koha::Patron object assuming
you've been passed said object into the template.

We have a few different attribute accessors:

* 'extended_attributes' which returns a resultset of attached extended
attributes
* 'get_extended_attribute(code)' which returns the attribute associated with
the code passed (but doesn't work properly for repeatable attributes)

To use those in TT:

*  [% FOREACH extendedattribute IN patron.extended_attributes %]

[%
extendedattribute.type.description | html %]: [%
extendedattribute.description | html %]

[% END %]

* [% SET attribute = patron.get_extended_attribute('code') %]
  [% attribute.description | html %]

The second one is clearly simpler to use, but only works for non-repeatable
attributes so you need to know a little about the underlying patron data setup.
 I also think it's a get wordy 'get_' and would prefer, I think, to have a
simple 'extended_attribute($code)' accessor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162934|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162933|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162716|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162715|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162715|0   |1
is obsolete||

--- Comment #5 from Pedro Amorim  ---
Created attachment 162948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162948&action=edit
Bug 36221: Preparation

This refactors the code for more DRY

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #162716|0   |1
is obsolete||

--- Comment #6 from Pedro Amorim  ---
Created attachment 162949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162949&action=edit
Bug 36221: OPAC Styling

Test plan, dont apply patches yet:
1) Enable ILLModule
2) Create a new OPAC ILL request, visit:
/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
3) Notice the style. Apply patches. Repeat

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

--- Comment #7 from Pedro Amorim  ---
Patches became out of order after Lisette's sign-off and did not apply. It's
now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

--- Comment #8 from Martin Renvoize  ---
Annoyingly the extended_attributes accessor is also set to be a setter which
means it won't pass through any filters you want to pass.. we should really
rectify that.

In my opinion we should have two simple accessors that both accept standard
dbic query filters.

* extended_attributes($where, $attr);
* extended_attribute($where,$attr);

We wrap our DBIx::Clas objects and thus remove the nice easy scalar handling of
_rs on accessors which means we also have to deal with that in 'clever' ways at
the TT level.. I can't remember the details for that off the top of my head
though.

We really need to document all this better somewhere in short.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36281] New: Restricted info is displayed even if item is not restricted (OPAC details)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281

Bug ID: 36281
   Summary: Restricted info is displayed even if item is not
restricted (OPAC details)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

If you define a description for restricted = 0 : 
In OPAC details, restricted info is displayed even if item is not restricted
(value 0).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36281] Restricted info is displayed even if item is not restricted (OPAC details)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||32445

--- Comment #1 from Fridolin Somers  ---
Since Bug 32445


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
[Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||36281


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281
[Bug 36281] Restricted info is displayed even if item is not restricted (OPAC
details)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36281] Restricted info is displayed even if item is not restricted (OPAC details)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36281] Restricted info is displayed even if item is not restricted (OPAC details)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36281] Restricted info is displayed even if item is not restricted (OPAC details)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281

--- Comment #2 from Fridolin Somers  ---
Created attachment 162950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162950&action=edit
Bug 36281: Display restricted info only if item is not restricted (OPAC
details)

If you define a description for restricted = 0 :
In OPAC details, restricted info is displayed even if item is not restricted
(value 0).

This patch fixes by adding 'IF item.restricted'.
Also creates a BLOCK to avoid code duplication.
Also adds span around status text to create easier translation.

Test plan :
1) Create a description in restricted autorised values category for value 0
2) Create a description in restricted autorised values category for value 1
3) Edit an biblio record to add an item with restricted=0 and an item with
restricted=1
4) Display this biblio on OPAC details page
=> Check you see resticted info only for restricted item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

--- Comment #8 from Marcel de Rooy  ---
Giving this a try on top of 33898

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||33898


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898
[Bug 33898] background_jobs_worker.pl may leave defunct children processes for
extended periods of time
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||35920


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920
[Bug 35920] Centralize code from workers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

--- Comment #9 from Marcel de Rooy  ---
Created attachment 162951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162951&action=edit
Bug 35920: Centralize worker code

Test plan:
Confirm that running jobs still works as expected.
Restart workers and try to stage a MARC file and import it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

--- Comment #10 from Marcel de Rooy  ---
Created attachment 162952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162952&action=edit
Bug 35920: Use BackgroundWorker in es_indexer_daemon

This needs incorporating the batch_size in the main loop.

Test plan:
Test both regular worker and es indexer daemon here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

Marcel de Rooy  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

--- Comment #11 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #1)
> This is WIP. We need bug 35819 pushed first, then to clean this, it is not
> very nice. But at least it will prevent the code to be duplicated.

Hmm. Didnt notice your patch when I did something similar with patch 2 and 3..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #162941|0   |1
is obsolete||
 Attachment #162943|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 162953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162953&action=edit
Bug 33898: Alternative approach with receive frame timeout

See bug 33898 comment6.

Test plan:
Based on comment12: Stage MARC import and manage. Look at the same
time to the results of ps aux|grep Z. Verify that the lines with
[background_jobs]  disappear within 10 seconds.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898

--- Comment #25 from Kyle M Hall  ---
Created attachment 162954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162954&action=edit
Bug 33898: Implement reaping for database polling

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35716] Duplicated assets in both koha-tmpl/intra-tmpl and koha-tmpl/opac-tmpl

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35716

Pedro Amorim  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36282

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36282] New: OPAC - Remove trailing and leading blank space from translated strings

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282

Bug ID: 36282
   Summary: OPAC - Remove trailing and leading blank space from
translated strings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: pedro.amo...@ptfs-europe.com
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: da...@davidnind.com, martin.renvo...@ptfs-europe.com,
oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816

Pedro Amorim  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36282

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36282] OPAC - Remove trailing and leading blank space from translated strings

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282

--- Comment #1 from Pedro Amorim  ---
The 2 files have diverged in logic:
opac-tmpl/bootstrap/en/includes/i18n.inc
koha-tmpl/bootstrap/en/includes/i18n.inc

Adding bug 35716 as "See also" as this logic should ideally be DRY.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #22 from Kyle M Hall  ---
(In reply to Victor Grousset/tuxayo from comment #21)
> (In reply to Katrin Fischer from comment #19)
> > Just wondering about the direct SQL in this patch. 
> > We do have HoldsQueueItems.pm - should we not be able to use a delete?
> 
> Indeed it seems so , thanks for seeing that.
> 
> @Kyle: up for a follow up patch? I can open the ticket.

Using DBIC to find and delete the lines in the two tables will result in 4
queries compared to the one query we have now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36282] OPAC - Remove trailing and leading blank space from translated strings

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282

Pedro Amorim  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36282] OPAC - Remove trailing and leading blank space from translated strings

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282

--- Comment #2 from Pedro Amorim  ---
Created attachment 162955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162955&action=edit
Bug 36282: [DO NOT PUSH] For test plan only

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36282] OPAC - Remove trailing and leading blank space from translated strings

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282

--- Comment #3 from Pedro Amorim  ---
Created attachment 162956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162956&action=edit
Bug 36282: Chomp whitespace around opac i18n strings

Same logic as bug 26816 but to OPAC

Test plan:
1) Apply test plan patch only
2) Visit opac home:
/cgi-bin/koha/opac-main.pl
3) Notice there's a space between 'Translated string' and ':', even though the
markup does not contain a whitespace
4) Apply 2nd patch
5) Notice the white space is gone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36282] OPAC - Remove trailing and leading blank space from translated strings

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||36221


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221
[Bug 36221] Improve styling of Standard backend create OPAC form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

Pedro Amorim  changed:

   What|Removed |Added

 Depends on||36282


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36282
[Bug 36282] OPAC - Remove trailing and leading blank space from translated
strings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35364] Update serials pop-up windows with consistent footer markup

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36013] update_totalissues.pl should not log

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #3 from Magnus Enger  ---
I had a problem where a bad record would stop the script from completing: 

$ misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v
Processing bib 1 (0 issues)
Processing bib 2 (0 issues)
Processing bib 3 (0 issues)
...
Processing bib 368 (0 issues)
Processing bib 369 (0 issues)
:8: parser error : PCDATA invalid Char value 31
  00aD15937
^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
   ^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
  ^
:9: parser error : PCDATA invalid Char value 31
  00satmrnu0
 ^
:10: parser error : PCDATA invalid Char value 31
  00ar19881981bdkldan

After deleting that record the script runs as it should:

...
Processing bib 437 (0 issues)
Processing bib 438 (0 issues)
Update total issues count script report
===
Run started at: 03/08/24 11:48:53
Run ended at:   03/08/24 11:48:57
Total run time: 4751 ms
Number of bibs modified:435
Number of bibs with error:  0

After this the cataloguing log shows one entry per record, so that will
quickley amount to a lot of unnecessary data!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36013] update_totalissues.pl should not log

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36013] update_totalissues.pl should not log

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013

Magnus Enger  changed:

   What|Removed |Added

 Attachment #161797|0   |1
is obsolete||

--- Comment #4 from Magnus Enger  ---
Created attachment 162957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162957&action=edit
Bug 36013: update_totalissues.pl should not log

Even when CataloguingLog is on, misc/cronjobs/update_totalissues.pl should not
log the changes.
It is useless and takes database space.

Do like bulkmarcimport.pl :
https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/misc/migration_tools/bulkmarcimport.pl#L165

Test plan :
1) Enable system preference CataloguingLog
2) Perform some issues and returns
3) Run : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v
4) Go to Tools > Log viewer
5) Check there are no new cataloguing logs

Signed-off-by: Magnus Enger 
Works as advertised. Before the patch, running the script adds one
entry to action_logs per record, with the patch nothing is logged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35153] Convert IntranetmainUserblock system preference to additional contents

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35153] Convert IntranetmainUserblock system preference to additional contents

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #159721|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 162958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162958&action=edit
Bug 35153: Convert IntranetmainUserblock system preference to additional
contents

This patch moves the IntranetmainUserblock system preference into HTML
customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the IntranetmainUserblock
system preference before applying the patch. Apply the patch and run
the database update process.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from IntranetmainUserblock is now stored there.
- The HTML customization entry form should offer IntranetmainUserblock
  as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Edit the IntranetmainUserblock HTML customization and add unique
  content to the "fr-FR" tab.

- Go to the staff client home page. You should see the
  content you added to the IntranetmainUserblock HTML customization.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "IntranetmainUserblock." It should return no results.

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35920] Centralize code from workers

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35920

--- Comment #12 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #11)
> (In reply to Jonathan Druart from comment #1)
> > This is WIP. We need bug 35819 pushed first, then to clean this, it is not
> > very nice. But at least it will prevent the code to be duplicated.
> 
> Hmm. Didnt notice your patch when I did something similar with patch 2 and
> 3..

Too bad to duplicate the effort again.

And so what?
The goal of my approach was to split Rabbit and DBMS. And also move broker's
responsibilities out of Koha::BackgroundJob

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35862] Display patron search result on the right of the form (modal)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35862] Display patron search result on the right of the form (modal)

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #162862|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  ---
Created attachment 162959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162959&action=edit
Bug 35862: Display modal search results to the right of form above 1200px

To test:
1. Apply patch
2. Rebuild CSS ( yarn build )
3. Look at some of the places where there is a modal patron search.
-suggestion/suggestion.pl: Set to patron
-members/memberentry.pl: Add guarantor

4. Make sure the modal looks good before and after you have searched for a
patron.
5. Play with many different screen sizes, ensuring everything looks good and
makes sense.

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36195] CSRF - testing reports

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195

--- Comment #4 from Jonathan Druart  ---
Created attachment 162960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162960&action=edit
Bug 36195: Replace POST batch_records_ajax.pl with GET

We retrieve a list of records for DT, it does not need to be a POST
request.

Test plan:
1. Stage a batch
2. When it's done, click on "view batch"
=> Without this patch the page loads but pops an alert that says "403:
Forbidden" and table stays empty

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36280] Viewing batch of staged records broken: CSRF token error

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36280

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||jonathan.dru...@gmail.com

--- Comment #1 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 36195 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14806] Action Log for Modifying borrower messaging preferences

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Strand  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14806] Action Log for Modifying borrower messaging preferences

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Strand  changed:

   What|Removed |Added

  Attachment #94749|0   |1
is obsolete||
  Attachment #94752|0   |1
is obsolete||

--- Comment #13 from Lari Strand  ---
Created attachment 162961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162961&action=edit
Bug 14806 - Log changes to borrower message preferences to action logs

To test:

1. Change patron's messaging preference/preferences and save
2. Note no entries in patron's modification log
3. Apply patch
4. Change patron's messaging preference/preferences and save
5. Note entries in patron's modification log, one per message type

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14806] Action Log for Modifying borrower messaging preferences

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Strand  changed:

   What|Removed |Added

 CC||lmstr...@gmail.com

--- Comment #14 from Lari Strand  ---
Mine's a bit hacky but does the job and the added code stays inside the module
responsible for the modification process (Messaging.pm). The entries are not in
line with other modification logs but they are readable :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36235] System preferences chopping everything after a semicolon.

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36235

--- Comment #5 from Jonathan Druart  ---
(In reply to Lucas Gass from comment #4)
> I just converted Jonathan's diff into a patch.

Did it fix your problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122

Matthias Le Gac  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122

--- Comment #6 from Matthias Le Gac  ---
Created attachment 162962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162962&action=edit
Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion

Test plan :

To recreate:
1. Enable EmailPurchaseSuggestions

2. Go to a patron's account and add an email address, a different one than the
one used for EmailPurchaseSuggestions

3. Create a suggestion from the OPAC
   3.1. Go to the OPAC and log in as a patron
   3.2. Go to Your account > Purchase suggestions
   3.3. Click New purchase suggestion
   3.4. Enter a title
   3.5. Click Submit your suggestion

4. Check the message_queue, there should be one NEW_SUGGESTION message sent to
whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there
should be 1 entry in message_queue)

5. Update the suggestion to accepted 
   5.1. In the staff interface, go to Acquisitions > Suggestions
   5.2. In the suggestions list, check the box next to the suggestion
   5.3. At the bottom of the screen, choose Mark selected as: Accepted
   5.4. Click Submit

6. Check the message_queue again, there should be one ACCEPTED message sent to
the patron and a new NEW_SUGGESTION message sent to whichever address you chose
in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in
message_queue)

7. Order the suggestion
   7.1. Go to Acquisitions
   7.2. Search for a vendor
   7.3. Click New > Basket
   7.4. Enter a basket name
   (Optional: for testing I like to change Create items when: cataloging the
record)
   7.5. Click Save
   7.6. Click Add to basket
   7.7. Click From a suggestion
   7.8. Click Order next to the suggestion
   7.9. Enter order details
   7.10. Click Save
   7.11. Click Close basket
   7.12. Click Yes, close

8. Check the message_queue again, there should be one ORDERED message sent to
the patron and a new NEW_SUGGESTION message sent to whichever address you chose
in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in
message_queue)

9. Apply the patch

10. now repeat steps 3 to 8 but :
step 4 you have one NEW_SUGGESTION message in message_queue
step 6 you have only one ACCEPTED message in message_queue
step 8 you have only one ORDERED message in message_queue

The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on
each steps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Needs Signoff   |Failed QA

--- Comment #7 from Martin Renvoize  ---
Can we have a Unit test for this please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36270] Remove special handling for <>

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270

--- Comment #6 from Martin Renvoize  ---
Do you have any clues on how often it's used with repeatable attributes Lucas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #161732|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 162963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162963&action=edit
Bug 35840: Add option to AddReturn to skip recording of localuse

To test:
1. APPLY PATCH, restart_all
2. Turn on RecordLocalUseOnReturn
3. Create a Statistical patron.
4. Check an item out to a regular patron.
5. Check the item out to a Statistical patron.
6. This should trigger a return and you will see 2 entries in the statistics
table, one for localuse and one for a return.
7. Try checking out an item to the Stats patron that is NOT checked out.
8. You should only see 1 entry, localuse, in the statistics table.

Signed-off-by: Andrew Fuerste Henry 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #161733|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 162964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162964&action=edit
Bug 35840: Add unit tests

Signed-off-by: Andrew Fuerste Henry 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #36 from Martin Renvoize  ---
All working well and tested.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36235] System preferences chopping everything after a semicolon.

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36235

--- Comment #6 from Lucas Gass  ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Lucas Gass from comment #4)
> > I just converted Jonathan's diff into a patch.
> 
> Did it fix your problem?

Yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #37 from Martin Renvoize  ---
Created attachment 162965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162965&action=edit
Bug 35840: (QA follow-up) Tidy and critic fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36283] New: Autoswitch behavior change after 22.11.15 upgrade

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36283

Bug ID: 36283
   Summary: Autoswitch behavior change after 22.11.15 upgrade
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: c...@pennmanor.net
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In Koha 22.11.15 a librarian is reporting to us the audio tone when using the
autoswitch functionality switched to the "error" beep. Previously this was not
the case.

To reproduce:

1. Make sure AutoSwitchPatron is enabled
2. Pull up a patron on cgi-bin/koha/circ/circulation.pl
3. Scan another patron barcode into the check out "Enter item barcode" field
4. The system should successfully switch to the scanned patron however it will
play the error audio file.


At the moment I'm not setup with any other koha machines to test newer
releases.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9015] BiblioAddsAuthorities should probably be set to "allow" by default

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9015

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mksteph...@fosgail.org
 Status|NEW |In Discussion

--- Comment #2 from Myka Kennedy Stephens  ---
I'm doing some research on authority bugs and ran across this old one. There
isn't a syspref called "BiblioAddsAuthorities" anymore. Based on the
description in this bug, I'm guessing this syspref was rendered unnecessary by
AutoCreateAuthorities and RequireChoosingExistingAuthority. 

Marking as "In Discussion," but I'm wondering if this bug could actually be
marked "Resolved"? What does the community do with old bugs that are obsolete
or no longer relevant?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36284] New: Patron search within record place holds page limit by letter does not work

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36284

Bug ID: 36284
   Summary: Patron search within record place holds page limit by
letter does not work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When searching for a patron to place a hold on, the letters that are meant to
display all patrons with a surname starting with that letter do not function
correctly. Instead all patrons are listed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162686|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 162966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162966&action=edit
Bug 35950: Move AddReturn call into circulation.pl

There should be no change in beahavior. Following the test plan from Bug 35840.

To test:
1. APPLY PATCH, restart_all
2. Turn on RecordLocalUseOnReturn
3. Create a Statistical patron.
4. Check an item out to a regular patron.
5. Check the item out to a Statistical patron.
6. This should trigger a return and you will see 2 entries in the statistics
table, one for localuse and one for a return.
7. Try checking out an item to the Stats patron that is NOT checked out.
8. You should only see 1 entry, localuse, in the statistics table.

Signed-off-by: Andrew Fuerste Henry 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #162687|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 162967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162967&action=edit
Bug 35950: Adjust tests

Signed-off-by: Andrew Fuerste Henry 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from Martin Renvoize  ---
Thanks Lucas, all looks good here, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33174] Have better indication when one is cancelling multiple holds on a record

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33174

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33174] Have better indication when one is cancelling multiple holds on a record

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33174

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #147989|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 162968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162968&action=edit
Bug 33174: Add warning about how many holds are being cancelled

To test:
1. Apply patch
2. Find or make a record with many holds on it.
3. Go to the Holds tab ( request.pl ).
4. Select some hodls to cancel and press "Cancel selected"
5. A modal popup will appear. Notice the warning telling you exactly how many
holds you are about to cancel. Confirm the count is accurate.
6. Try using the select all button and make sure the warning is accurate.
7. Make sure you can cancel the holds.

Signed-off-by: Sally 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Martin Renvoize  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Hackfest

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36285] New: Staff UI form fieldset styling needs update

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36285

Bug ID: 36285
   Summary: Staff UI form fieldset styling needs update
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36285] Staff UI form fieldset styling needs update

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36285

Pedro Amorim  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com, da...@davidnind.com,
   ||jonathan.dru...@gmail.com,
   ||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com, oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36285] Staff UI form fieldset styling needs update

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36285

--- Comment #1 from Pedro Amorim  ---
Created attachment 162969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162969&action=edit
Bug 36285: [PoC] Move ERM specific styling to all of koha Staff forms

This is just a proof of concept

1) Before applying the patch, access some (or all) of the links below.
2) Apply patch
3) Run yarn css:build to rebuild scss
4) Refresh each of the pages and notice the changes

Some form examples:
/cgi-bin/koha/acqui/supplier.pl?op=enter
/cgi-bin/koha/serials/serials-home.pl
/cgi-bin/koha/serials/subscription-add.pl
/cgi-bin/koha/erm/eholdings/local/titles/add
/cgi-bin/koha/virtualshelves/shelves.pl?op=add_form&referer=list
/cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode=CPL

Side menu changes:
/cgi-bin/koha/members/members-home.pl
/cgi-bin/koha/serials/serials-search.pl # Press Search

A problem arises for some inputs that have the size property e.g. size="4" on
the new purchase suggestion form, and others.
With this new change, these inputs lose their initial enforced "smaller" size.
I think this should be iterated and made more streamlined and use a
.input-small class of the size.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36285] Staff UI form fieldset styling needs update

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36285

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #2 from Pedro Amorim  ---
Hey all, I've submitted a PoC patch for discussion.
Would be great to have others opinions on this to better make the judgement
call if this is worth investing more time into or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

--- Comment #8 from Pedro Amorim  ---
Created attachment 162970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162970&action=edit
Bug 36221: Move patron section to top of create form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

--- Comment #9 from Pedro Amorim  ---
Created attachment 162971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162971&action=edit
Bug 36221: Update 'Create' button class

btn-primary should be used here, not btn-default

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36221] Improve styling of Standard backend create OPAC form

2024-03-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36221

--- Comment #10 from Pedro Amorim  ---
Thank you for looking and sign-off, Lisette!
However I've revisited and added 2 additional patches in case you're available
to take a look at those too! Cheers!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >