[Koha-bugs] [Bug 36215] Bookings calendar only shows bookings within RESTdefaultPageSize

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36215

--- Comment #7 from Katrin Fischer  ---
Will push the follow-up to master in a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36314] koha-email-disable does not disable all emails

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314

--- Comment #5 from Katrin Fischer  ---
Hm, my impression always was that the cronjob would not run at all with the
flag set. Maybe I am wrong and clearly we need to document the intended
behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #6 from David Cook  ---
(In reply to David Cook from comment #5)
> This sounds like a support problem. Someone would need to look into the
> logs, database structure, etc for more information here. 
> 
> This is one of those ones where it'll be good when we do have the database
> auditor information web accessible I suppose...

Because it sounds to me like this is related to the checkout_renewals table and
it missing the `interface` column, but that's weird, because that was added for
22.11, so unlikely to be related to an upgrade from 22.11 to 23.11.

So something strange going on here.

I recently upgraded 21.05 to 23.11 and had no problems like this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
This sounds like a support problem. Someone would need to look into the logs,
database structure, etc for more information here. 

This is one of those ones where it'll be good when we do have the database
auditor information web accessible I suppose...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26482] Add macros ability to basic editor

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26482

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #4 from Christian Pine  ---
(In reply to Katrin Fischer from comment #2)
> Which version of Koha are you using (exact version as shown on the About
> page) and did you recently update/upgrade?

yes I recently update & upgrade

I was using before koha 22.11 but I decided to install a newer version my
current koha version is = Koha 23.11.03 , I found some bugs / problems with the
newer version such as checking in/out and item would lead me to error500, but
when I refresh the page the item is processed/ recorded to the borrower.

In addition I found out that when I renew a book the due date but its not
updating to a new one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #3 from Christian Pine  ---
yes I recently update & upgrade

I was using before koha 22.11 but I decided to install a newer version my
current koha version is = Koha 23.11.03 , I found some bugs / problems with the
newer version such as checking in/out and item would lead me to error500, but
when I refresh the page the item is processed/ recorded to the borrower.

In addition I found out that when I renew a book the due date but its not
updating to a new one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36325] Add option to koha-run-backups/koha-dump, to exclude logs

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #163157|0   |1
is obsolete||

--- Comment #2 from Danyon Sewell  ---
Created attachment 163158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163158&action=edit
Bug 36325: Add option to koha-run-backups/koha-dump, to exclude logs

Written patch to add flag to both koha-dump and koha-run-backups.

Test plan:
1. do a sudo koha-dump and sudo koha-run-backups and check the contents of the
.tar.gz backup in /var/spool/koha/instance/ and verify logs are in there
2. apply this patch
3. this time do sudo koha-dump --exclude-logs and sudo koha-run-backups
--exclude-logs and check the contents of the .tar.gz backup in
/var/spool/koha/instance and verify nothing from /var/log/koha is in there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36325] Add option to koha-run-backups/koha-dump, to exclude logs

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325

--- Comment #1 from Danyon Sewell  ---
Created attachment 163157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163157&action=edit
Bug 36325: Add option to koha-run-backups/koha-dump, to exclude logs

Written patch to add flag to both koha-dump and koha-run-backups.

Test plan:
1. do a sudo koha-dump and sudo koha-run-backups and check the contents of the
.tar.gz backup in /var/spool/koha/instance/ and verify logs are in there
2. apply this patch
3. this time do sudo koha-dump --exclude-logs and sudo koha-run-backups
--exclude-logs and check the contents of the .tar.gz backup in
/var/spool/koha/instance and verify nothing from /var/log/koha is in there.

 Current status: ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36325] Add option to koha-run-backups/koha-dump, to exclude logs

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325

Danyon Sewell  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36325] Add option to koha-run-backups/koha-dump, to exclude logs

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325

Danyon Sewell  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36311

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36311] Add option to koha-run-backups, to only include database dump

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36311

Danyon Sewell  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36325

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36325] Add option to koha-run-backups/koha-dump, to exclude logs

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325

Danyon Sewell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |danyonsew...@catalyst.net.n
   |ity.org |z
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36325] New: Add option to koha-run-backups/koha-dump, to exclude logs

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36325

Bug ID: 36325
   Summary: Add option to koha-run-backups/koha-dump, to exclude
logs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: danyonsew...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Adding an additional option to koha-dump and koha-run-backups to exclude the
logs in /var/log/koha/site from the completed backup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307

David Nind  changed:

   What|Removed |Added

 Attachment #163116|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 163156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163156&action=edit
Bug 36307 - SMS::Send driver errors are not captured and stored

If an SMS::Send driver succeeds, it returns a value that evaluates to true.
Every driver I've inspected uses croak when it encounters a failure state.

When an SMS message fails to send, code hard codes the failure code to NO_NOTES
(No notes from SMS driver).

We should store the real error in `failure_code` and display that if the
failure code doesn't match a known failure code.

Test Plan:
1) Apply this patch
2) Set SMSSendDriver to any value
3) Generate a pending sms message
4) Run the following query:
   update message_queue set status = 'failed', failure_code = "This is a test";
5) View the patron's messages, note the delivery note contains the
   contents of the failure code
6) Run the following query:
   update message_queue set status = 'failed', failure_code =
"SMS_SEND_DRIVER_MISSING";
7) Reload the patron's messages, not the delivery note is now "The SMS
   driver could not be loaded".

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317

David Nind  changed:

   What|Removed |Added

 Attachment #163131|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 163155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163155&action=edit
Bug 36317: Koha::Biblio->host_items must use me.itemnumber

Koha::Biblio->host_items fails with search_ordered() because of ambiguous
column 'itemnumber' in where clause.
It must use me.itemnumber like in Koha::Biblio->items

Test plan :
prove t/db_dependent/Biblio.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
Testing notes (using KTD):

1. Apply the patches.
2. Test the cataloging inventory tool - it should work as expected. I:
   2.1 Exported a list of barcodes (using item search to export a list of all
the barcodes)
   2.2 Ran the inventory tool:
   . Used the barcode file under the "Use a barcode file"
   . I didn't select any additional items
   . Submit
   . Say 'OK' to the message about you have not selected any filters, and
that it could take a while
3. BONUS: Apply the patches on top of bug 36190 - all the tests should pass:
prove -v xt/find-missing-op-in-forms.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305

David Nind  changed:

   What|Removed |Added

 Attachment #163115|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 163154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163154&action=edit
Bug 36305: Implement op paramters

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305

David Nind  changed:

   What|Removed |Added

 Attachment #163114|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 163153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163153&action=edit
Bug 36305: Tidy forms

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36305] Inventory tools need adjustments for CSRF

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190

--- Comment #12 from David Nind  ---
Thanks Nick!

Testing notes (using KTD):

1. Run the tests before the patch is applied - tests should pass: prove -v
xt/find-missing-op-in-forms.t
2. Apply the first three patches (using interactive mode) and run the tests:
tests should fail with 12 forms missing the required information
3. Apply the remaining patch and run the tests again: tests still fail,[1] but
this time there is only 1 form missing the required information (addressed in
bug 36305)

[1] After all patches are applied, only 1 form is missing the required
information

prove -v xt/find-missing-op-in-forms.t
xt/find-missing-op-in-forms.t .. 
1..1
not ok 1 - The  in the following files are missing it's corresponding op
parameter, or op does not start with 'cud-' (see bug 34478)

#   Failed test 'The  in the following files are missing it's
corresponding op parameter, or op does not start with 'cud-' (see bug 34478)'
#   at xt/find-missing-op-in-forms.t line 43.
#  got: '1'
# expected: '0'
# $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt:71,248';
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
---
xt/find-missing-op-in-forms.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.15 cusr  0.01
csys =  0.17 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190

David Nind  changed:

   What|Removed |Added

 Attachment #163112|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 163152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163152&action=edit
Bug 36190: Fix problems found by test

opac-shelves   - forms were stateless - changed to GET
sco-main   - forms stateless - changed to GET
 ** untested because sco + auth is broken
smart-rules.tt - JS form template - added placeholder 'cud-' op
ill-requests   - added cud- tp ops
 ** tested comments, but not checkout, simple changes
boraccount - removed repeated op - updated script
patroncards/edit-batch - add placeholder 'cud-' op
patroncards/manage - add placheholder 'cud-' op
elasticsearch/mappings - separate forms - this could use a style follow-up, but
makes more sense separate I think
reports/dictionary  - stateless - changed to GET
guided_reports_start- stateless - changed to GET
suggestion/suggestion   - add placeholder 'cud-' op
inventory   - filed bug 36305, needs more handling

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190

David Nind  changed:

   What|Removed |Added

 Attachment #163111|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 163151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163151&action=edit
Bug 36190: (QA follow-up) Tidy

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190

David Nind  changed:

   What|Removed |Added

 Attachment #163110|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 163150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163150&action=edit
Bug 36190: To not assume op is invalid if it is a TT variable

Signed-off-by: Nick Clemens 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190

David Nind  changed:

   What|Removed |Added

 Attachment #162530|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 163149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163149&action=edit
Bug 36190: Adjust the test

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36190] op param for stateful requests must start with 'cud-'

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36190

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36315] ILSDI GetRecord speed improvement.

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36315

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35305] Add XSLT for authority details page in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35305

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24192] Show host record items in cart and list in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36317] Koha::Biblio->host_items fails with search_ordered()

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36317

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36314] koha-email-disable does not disable all emails

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
(In reply to Katrin Fischer from comment #3)
> I think we have used this during migrations and such. 
> 
> If we move to a system preference that could also work, but like the email
> switch it should not only stop sending out the emails, but also prevent
> their generation in the first place.

I'm not sure that I understand. If you have email disabled, emails will still
be generated in Koha. That's something I like because sometimes I want to test
email generation without risking sending out emails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
Just bumped into this yesterday so I understand better now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36324] Authority subfields cannot be reordered

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36324

--- Comment #1 from Katrin Fischer  ---
Hi Esther, 

this still works for me using "drag and drop" on the subfield character. (Hold
mouse down instead of click).
I can also reorder repeated fields by dragging them. Could you re-try?

I agree this feature could be visually way more obvious.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320

--- Comment #2 from Katrin Fischer  ---
Some ideas:

* Should we remove "Edit items" from the Edit pull down, as it doesn't work as
expected?
* Should we rename it "Manage items" or similar?

Koha bringing up the empty item form leads to confusion practically every
training we do. I think an empty page with a button for new item would make a
lot of sense in some scenarios. If you explicitly click "Add item" we could
still bring up the form maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36316


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36316
[Bug 36316] CookieConsent should not display in Z39.50/SRU window
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36316] CookieConsent should not display in Z39.50/SRU window

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36316

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||27378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378
[Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36077] Create separate cookie options for the staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36077

--- Comment #6 from Katrin Fischer  ---
(In reply to Mirjam Vantieghem from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > (In reply to Mirjam Vantieghem from comment #3)
> > > Not sure if this belongs here or in a separate bug:
> > > When the CookieConsent system preference is set to require, the
> > > CookieConsent also comes in the pop-up window of the Z39.50/SRU search 
> > > from
> > > the cataloguing module on the Staff client, even after confirming consent 
> > > in
> > > the staff client. 
> > > That seems unnecessary, unless there are other cookies in the Z39.50/SRU
> > > pop-up window.
> > 
> > Can you please report a separate bug as "bug"?
> 
> Bug #36316 created.

Thank you, Mirjam!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36314] koha-email-disable does not disable all emails

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314

--- Comment #3 from Katrin Fischer  ---
I think we have used this during migrations and such. 

If we move to a system preference that could also work, but like the email
switch it should not only stop sending out the emails, but also prevent their
generation in the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36313] Check out/ check out leads to error500 in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36313

--- Comment #2 from Katrin Fischer  ---
Which version of Koha are you using (exact version as shown on the About page)
and did you recently update/upgrade?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24192] Show host record items in cart and list in staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192

Katrin Fischer  changed:

   What|Removed |Added

Summary|Show host record items in   |Show host record items in
   |basket/shelves in staff |cart and list in staff
   ||interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36233] Cannot search invoices if too many vendors

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36233

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #17 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36233] Cannot search invoices if too many vendors

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36233

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163132|0   |1
is obsolete||

--- Comment #16 from Victor Grousset/tuxayo  ---
Created attachment 163148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163148&action=edit
Bug 36233: Set select2 width to 100%

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36233] Cannot search invoices if too many vendors

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36233

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163103|0   |1
is obsolete||

--- Comment #15 from Victor Grousset/tuxayo  ---
Created attachment 163147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163147&action=edit
Bug 36233: (follow-up) Fix width and enable clear option

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36233] Cannot search invoices if too many vendors

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36233

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163102|0   |1
is obsolete||

--- Comment #14 from Victor Grousset/tuxayo  ---
Created attachment 163146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163146&action=edit
Bug 36233: Use select2 to load vendors on invoice search

This patch moves the dropdown to use select2 and avoids loading all
vendors at page load.

To test:
 1 - Create some extra vendors in your system, ideally over 20
 2 - Search for a vendor in acquisitions
 3 - Click 'Invoices'
 4 - Note the dropdown of all vendors 'Vendor:' in search bar on left
 5 - The vendor you came from shoudl eb selected
 6 - Apply patch
 7 - Repeat
 8 - Note only a partial list of vendors is loaded, confirm current vendor
still selected
 9 - Search in the dropdown and confirm vendors are returned
10 - Select a vendor and search
11 - confirm selection is retained

Signed-off-by: Lisette Scheer 
Rebased-by: Victor Grousset/tuxayo 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36233] Cannot search invoices if too many vendors

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36233

--- Comment #13 from Victor Grousset/tuxayo  ---
> Set to 100%, this seems to work

great, indeed, thanks :)

> What is your RESTDefaltPageSize? The vendors can all be scrolled, however, if 
> you watch the network tab in the console, you will see there is a paged 
> request for vendors as you scroll

I got confused, I though it was without patch and part of the issue. It works,
I see the lazy loading when scrolling down, nice :)

> Yes, we have a site with ~270k vendors

270k 🤯

Ok, then no need to witness it to confirm that this will fix issues. I can't
imagine the HTML size for the  with 270k vendors.

And search works :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Failed QA

--- Comment #8 from Victor Grousset/tuxayo  ---
(In reply to Victor Grousset/tuxayo from comment #7)
> Is that something we usually do to not have some sysprefs in
> installer/data/mysql/mandatory/sysprefs.sql ?
> When their default value is 0.

Confirmed that is an issue: Bug 34979

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643

--- Comment #7 from Victor Grousset/tuxayo  ---
Is that something we usually do to not have some sysprefs in
installer/data/mysql/mandatory/sysprefs.sql ?
When their default value is 0.

It's not mentioned here:
https://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference

---

Amended the patch for minor tidying.

---

Otherwise, code looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #159113|0   |1
is obsolete||

--- Comment #6 from Victor Grousset/tuxayo  ---
Created attachment 163145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163145&action=edit
Bug 34643: Split CircConfirmItemParts for self-checkout and self-checkin

Many libraries wish to be able to allow self-check for multi-part items while
requesting librarians to verify the parts when checking out/in at the desk. It
makes sense to split CircConfirmItemParts into three prefs such that the
feature can be enabled/disabled for SCO and SCI independently.

Test Plan:
1) Apply this patch
2) Enable SCO and SCI
3) Set CircConfirmItemPartsSCO to "Don't allow"
4) Attempt to checkout out an item with materials via SCO, it should
   fail
5) Set CircConfirmItemPartsSCO to "Allow"
6) Repeat step 4, it should succeed
7) Set CircConfirmItemPartsSCI to "Don't allow"
8) Attempt to check in the item via SCI, it should fail
9) Attempt to check in the item via SCO, it should fail
9) Set CircConfirmItemPartsSCI to "Allow"
10) Attempt to check in the item via SCO and SCI, it should succeed!

Signed-off-by: AFHDubCoLib 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36307] SMS::Send driver errors are not captured and stored

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307

Kyle M Hall  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #2 from Kyle M Hall  ---
*** Bug 32381 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32381] Koha should be able to receive and record reasons for failed SMS notices

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---


*** This bug has been marked as a duplicate of bug 36307 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36324] New: Authority subfields cannot be reordered

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36324

Bug ID: 36324
   Summary: Authority subfields cannot be reordered
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

According to bug 34114, authority subfields should be able to be reordered when
editing. That function seems to be broken and the fields cannot be reordered.
When clicking on a subfield, a box appears that allows me to edit the subfield
letter/number instead.

I would think the ability to edit the subfield letter/number in the authority
editor could be problematic. The ability to sort the fields by clicking and
dragging was existing behavior and should be restored.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35143] Add hooks for status changes to ILL requests to send_staff_notice

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35143

--- Comment #2 from Marie-Luce Laflamme  ---
Suggestion of a test plan


Required settings
Enable the native ILL module and the necessary backend code before testing.

Test plan
1- Created a new ILL_NEW_REQUEST template in (tools > Notices & slips)

e.g.
 template code: ILL_NEW_REQUEST

   and message like:
  "A new interlibrary loan request from a patron is awaiting for approval.
  Request ID [%illrequest.illrequest_id %] .

  Please review this request:
  [% ill_full_metadata %]"


2- Add ILL template codes in the system preference "ILLSendStaffNotices"
 ILL_REQUEST_CANCEL|ILL_REQUEST_MODIFIED||ILL_NEW_REQUEST
3- Add your email in the system preference "ILLDefaultStaffEmail"
4- Login in to the OPAC
5- Go to the «Interlibrary request» section
6- Place a request
7- Check the message_queue in a terminal
---> At the moment, Koha is not generating the "ILL_NEW_REQUEST" email  (issue)
---> it should be added to the message_queue
8- Return to the OPAC
9- Modify the ILL request and save the changes
10- Check your email inbox
--> Koha is sending correctly the ILL_REQUEST_MODIFIED email to staff
11- Go back to the OPAC and cancel the ILLrequest.
12- Check your email inbox
--> Koha is sending correctly the ILL_REQUEST_CANCEL email to staff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35143] Add hooks for status changes to ILL requests to send_staff_notice

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35143

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #1 from Marie-Luce Laflamme  ---
Yes, it would be great to send an email to the library whenever there's a new
ILL request. It could also be useful to add an alert next to the 'new
suggestion pending' warning on the staff lending page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139

Michael Hafen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #3 from Michael Hafen  ---
Yes, sorry.  I'll change the status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #163137|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 163144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163144&action=edit
Bug 36321: Problem when dateexpiry in BorrowerUnwantedField

hen dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form.
The problem is when editing an existing patron the value is re-computed with
category settings, as if it where empty.

This comes from all fields in BorrowerUnwantedField beeing removed from
%newdata in memberentry.pl.
Whe must skip dateexpiry.

Test plan :
1) Be sure dateexpiry is not in BorrowerUnwantedField
2) Define a patron category with enrollment period 12 month
3) Create a new patron in this category
4) Its expiration date is in now + 12 month
5) Edit the patron category to set enrollment period 6 month
6) Add dateexpiry in BorrowerUnwantedField
7) Edit the patron and save
=> Without patch the expiration date is changed to now + 6 month
=> With patch the exporation date is unchanged

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
This behavior is so long-standing that I'm a little hesitant to change it. But
on the other hand I've definitely trained librarians to ignore the "Edit items"
button exactly because the behavior is not what one might want/expect.

I agree that for a bib with just 1 item, it makes sense to assume a click on
"Edit items" should edit the one available item.

A blank screen when one clicks Edit Items on a record with multiple items makes
sense to me. The change might be disruptive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #29 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #28)
> Nick, do you know what is the behaviour in stable branches?
On a 23.05 site

In firefox I get redirected to patron if I hit back

In chrome I get the member search with no results when I hit back after
searching for a patron from the members module
If I perform a checkout search from anywhere else, back takes me to the
original page, i.e. Serials home

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35138] Elastic search - add new facets

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138

--- Comment #3 from Michaela Sieber  ---
Thanks Jonathan for your proof of concept. 
We testet the patch that uses an authorized value for the configuration of
ElasticSearch facets. 
Everything in the patch worked as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
We overlapped here. Nice to see patches, though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #28 from Jonathan Druart  ---
Nick, do you know what is the behaviour in stable branches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #27 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #26)
> Ha good catch! There is another form to adjust!

Absolutely not!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #26 from Jonathan Druart  ---
Ha good catch! There is another form to adjust!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

--- Comment #1 from Fridolin Somers  ---
Created attachment 163137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163137&action=edit
Bug 36321: Problem when dateexpiry in BorrowerUnwantedField

hen dateexpiry is in BorrowerUnwantedField it is hidden in patron edition form.
The problem is when editing an existing patron the value is re-computed with
category settings, as if it where empty.

This comes from all fields in BorrowerUnwantedField beeing removed from
%newdata in memberentry.pl.
Whe must skip dateexpiry.

Test plan :
1) Be sure dateexpiry is not in BorrowerUnwantedField
2) Define a patron category with enrollment period 12 month
3) Create a new patron in this category
4) Its expiration date is in now + 12 month
5) Edit the patron category to set enrollment period 6 month
6) Add dateexpiry in BorrowerUnwantedField
7) Edit the patron and save
=> Without patch the expiration date is changed to now + 6 month
=> With patch the exporation date is unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] Problem when dateexpiry in BorrowerUnwantedField

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36321] New: Problem when dateexpiry in BorrowerUnwantedField

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36321

Bug ID: 36321
   Summary: Problem when dateexpiry in BorrowerUnwantedField
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When dateexpiry is in BorrowerUnwantedField it is hidden in patron edition
form.
The problem is when editing an existing patron the value is re-computed with
category settings, as if it where empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36297] Avoid using var named "t" in templates

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36297

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #4 from Julian Maurice  ---
Remember that there is also 'tn', 'tnx', ... (exhaustive list in i18n.inc).

Also FOREACH is probably not the only way to "hide" these macros (for instance
[% t = ... %] or [% WHILE (t = ...) %] probably does the same thing)

Another solution could be to remove i18n.inc, forcing us to use [%
I18N.t("...") %] which is unlikely to conflict with other variables.

Or another (but hypothetical as I'm not sure it works): redefine these
functions as filters [% "..." | t %] (I believe filters don't conflict with
variable names ?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36297] Avoid using var named "t" in templates

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36297

--- Comment #3 from Pedro Amorim  ---
(In reply to Kyle M Hall from comment #2)
> (In reply to Pedro Amorim from comment #1)
> > This may be a non-issue (?) if it is indeed a template toolkit bug and it
> > gets fixed upstream, the problem is that the value of 't' persists even
> > after the end of the loop.
> > Having said that, we may also just decide that using 't' as a variable name
> > (anywhere) in TT is bad practice, because it may conflict with the
> > translation method 't' we use.
> 
> I don't think we can count on this being fixed upstream any time soon. I
> think it's reasonable for use to fix the existing instances and perhaps add
> a unit test to grep for "FOREACH t IN" in all our templates.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36301] Patron search is searching on attribute types even if a specific non attribute type search field is selected

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36301

--- Comment #2 from Pedro Amorim  ---
This is a bug Jake discovered and we were looking at it together but when
coming up with a test plan for it we found bug 36302.
We tried reproducing this again but weren't able to anymore.
There appears to be something funky going on but I'll try to come back to it
if/when we can reproduce it again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36302] Patron search from search bar broken

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #25 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #24)
> I am sorry but... I am still getting the redirect to the patron detail page
> after hitting the back button.
> 
> BUT I have tried v23.11.00 and it behaving like that as well.
> 
> Sure I tried yesterday a pre-csrf and it works "working" (no redirect).
> 
> David, what did you notice during your testing session?

I tested this a bit today, there are slightly different results when searching
from mainpage vs members-home - the former using patron-search-box the latter
member-search-box. Some of this is covered by discussion, just highlighting it
all together

From mainpage the url is:
http://localhost:8081/cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&searchmember=henry

From members-home the url is:
http://localhost:8081/cgi-bin/koha/members/member.pl?quicksearch=1&searchmember=henry&searchfieldstype=standard&searchtype=starts_with&branchcode_filter=&categorycode_filter=

circsearch makes the difference in that without that, the table is blank, this
seems to be from defer_loading which prevents the form submission

Chrome and Firefox behave differently because it seems Chrome/Edge is designed
to prevent a redirect when clicking back - Firefox does not do this

When the patch changes from GET to POST this effects the defer_loading variable
so really seems to be effectively the same as the initial patch. 

My only thought has been to store the initial page or pass it through as a
variable, and offer a "Back to {page}" link on the patron screen

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34270] Upgrade and prune jQueryUI assets in the staff interface

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34270

Jonathan Druart  changed:

   What|Removed |Added

 CC||dudzikmic...@wp.pl

--- Comment #8 from Jonathan Druart  ---
*** Bug 35046 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36318] Patrons searching

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36318

--- Comment #2 from lmitxelena  ---
Thank you Jonathan, the bug that you mentions, answers the question.
Leire

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

--- Comment #193 from Jonathan Druart  ---
*** Bug 30502 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

Jonathan Druart  changed:

   What|Removed |Added

 CC||anuragme...@gmail.com

--- Comment #192 from Jonathan Druart  ---
*** Bug 23238 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

--- Comment #191 from Jonathan Druart  ---
*** Bug 34111 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

--- Comment #190 from Jonathan Druart  ---
*** Bug 23060 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

--- Comment #189 from Jonathan Druart  ---
*** Bug 22314 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

Jonathan Druart  changed:

   What|Removed |Added

 CC||amitddng...@gmail.com

--- Comment #188 from Jonathan Druart  ---
*** Bug 19645 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

--- Comment #187 from Jonathan Druart  ---
*** Bug 35677 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36320] Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320

Lucas Gass  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com

--- Comment #2 from Jonathan Druart  ---
Is this ready for signoff?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36320] New: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320

Bug ID: 36320
   Summary: Clicking Edit items from catalogue/detail.pl leads to
'Add item' screen
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

To recreate:


1. Find a record with more than 1 items attached. 
2. From catalogue/detail.pl click the 'Edit' button in the toolbar to activate
the dropdown. 
3. Click 'Edit items'. 
4. This cannot direct the user to any particular item to edit because Koha
doesn't know which item you want to edit at this point. 

If there is a single item this should direct the user straight to an 'Edit
item'. If a record has many items maybe a blank screen ( no Add Item ) would be
less confusing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36301] Patron search is searching on attribute types even if a specific non attribute type search field is selected

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36301

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com

--- Comment #1 from Jonathan Druart  ---
I don't understand, please provide more detail.

The non-searchable patron attributes are not listed.

Are you talking about the REST API endpoint?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35558] Do not fetch local image if none exists

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35558

--- Comment #18 from Jonathan Druart  ---
Created attachment 163136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163136&action=edit
Bug 35558: Do not retrieve the local image if none exists - OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36319] New: Splitting a single item between multiple funds

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36319

Bug ID: 36319
   Summary: Splitting a single item between multiple funds
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lib...@uhv.edu
QA Contact: testo...@bugs.koha-community.org

Periodically we run into instances where we need to split the cost of a book or
database between two funds. Currently this is not possible in Koha and so we
add and subtract money from funds to get the money to match, but it doesn't
allow us to track the actuality of how the money was spent for reporting
purposes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35703] Marking Lost card does not prevent patron from placing holds

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35703

--- Comment #1 from Kristi  ---
After speaking with Nick at ByWater, part of the issue with the lost/stolen
setting is that it needs to work better with the API. The hold check needs to
be the same on the OPAC and API.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117

Jonathan Druart  changed:

   What|Removed |Added

 CC||sistemak.medialab@tabakaler
   ||a.eus

--- Comment #72 from Jonathan Druart  ---
*** Bug 36318 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36318] Patrons searching

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36318

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  ---
Hola,
Have a look at bug 33117 and the new syspref DefaultPatronSearchMethod.
You may want to update its value to "contains".

*** This bug has been marked as a duplicate of bug 33117 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277

--- Comment #9 from Jonathan Druart  ---
This certainly arises because one of the tests does not clean correctly behind
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277

--- Comment #8 from Jonathan Druart  ---
Created attachment 163135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163135&action=edit
Bug 36277: Improve algorithmic complexity of batch_add

The 2 nested loops are terrible in term of algorithmic complexity.
Especially if we are fetching from there.

The goal of this patch is to fetch all the limits outside of the loop.

If you have 100 libraries, it will remove 100^2 - 1 fetches!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277

--- Comment #7 from Jonathan Druart  ---
Created attachment 163134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163134&action=edit
Bug 36277: Do not fetch the whole library list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36277] t/db_dependent/api/v1/transfer_limits.t is failing

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36306] Make Koha UserName configurable how it is created

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36306

he...@bywatersolutions.com changed:

   What|Removed |Added

 CC||he...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35558] Do not fetch local image if none exists

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35558

--- Comment #17 from Didier Gautheron  ---
Same is need for OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36318] New: Patrons searching

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36318

Bug ID: 36318
   Summary: Patrons searching
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: QA tools
  Assignee: jonathan.dru...@gmail.com
  Reporter: sistemak.media...@tabakalera.eus

Hi,

I write from a library from Spain. Here we use two family names "Firstname and
Surnames (2 family names). For example Isabel Ruiperez Alcaraz.

In the new version, it can't search the patron only since the second surname
"Alcaraz"

Anybody knows how do it?

L.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36314] koha-email-disable does not disable all emails

2024-03-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314

--- Comment #2 from Tomás Cohen Arazi  ---
`koha-email-{enabled|disable}` is only used by `koha-list`. I'm not sure what's
the best approach to this. We could have a syspref instead of email.enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >