[Koha-bugs] [Bug 35659] OAI Harvester

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #38 from Victor Grousset/tuxayo  ---
Adding a server doesn't work due to not complying with CSRF (Bug 34478):

> Programming error - op 'add_validated' must start with 'cud-' for POST 
> http://localhost:8081/intranet/admin/oaiservers.pl (referer: 
> http://localhost:8081/cgi-bin/koha/admin/oaiservers.pl?op=add)

From Koha/Middleware/CSRF.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|In Discussion   |Failed QA

--- Comment #39 from Victor Grousset/tuxayo  ---
It seems so. Switching to it so it's clearer that is rescuable and not blocked
due to uncertainty about a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921

--- Comment #11 from Victor Grousset/tuxayo  ---
It works! :)
Nice improvement, 11 sec vs 21.5 sec

Adding a second signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #162372|0   |1
is obsolete||

--- Comment #10 from Victor Grousset/tuxayo  ---
Created attachment 163288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163288=edit
Bug 35921: Improve perfs of acqui-home.pl when there are many budgets

When there are a lot of budgets with the same owner, most of the time of
acqui-home.pl is spent loading the same patron over and over.

This patch makes sure each borrower is loaded only once.

Test plan:
0. Do not apply the patch yet
1. Create a thousand budgets with the following command (make sure the
   budget_owner_id is an existing borrowernumber):
   perl -MKoha::Database -e '
   my $schema = Koha::Database->schema;
   my $period = $schema->resultset("Aqbudgetperiod")->create({
   budget_period_startdate => "2000-01-01",
   budget_period_enddate => "2999-12-31"
   });
   $schema->resultset("Aqbudget")->create({
   budget_owner_id => 1,
   budget_period_id => $period->id
   }) for (1..1000)
   '
2. Measure the time it takes to load acqui/acqui-home.pl (do it several
   times and keep the average time)
3. Apply the patch
4. Repeat step 2

Signed-off-by: Pedro Amorim 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35921] Improve perfs of acqui-home.pl when there are many budgets

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo  ---
(In reply to Jonathan Druart from comment #7)
> You are mixing unblessed and blessed in budget_owner.

(In reply to Julian Maurice from comment #8)
> The %patrons hash only contains Koha::Patron object.

I seems that's indeed the case, dumping %patrons:
> $VAR2 = undef;
> $VAR3 = '1';
> $VAR4 = bless( {
> [...]
>   }, 'Koha::Patron' );
> $VAR5 = '51';
> $VAR6 = bless( {
> [...]
>   }, 'Koha::Patron' );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #29 from David Nind  ---
I'd be happy to test, but I don't know enough about Zebra indexes to test.

If you could add a step-by-step test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36335] ILS-DI GetRecords bad encoding for UNIMARC

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36335

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
I had a go at testing, but I'm not sure how to generate the bad encoding.

Any hints on how to create an encoding error?

I tried using the test plan I used in bug 34467 comment 8, but I didn't get an
encoding error (using KTD):

1. Edited .env and change KOHA_MARC_FLAVOUR=unimarc

2. Enabled the ILS-DI system preference.

3. Modified record 1234:
   - on leader position 9, enter a blank
   - on 200$a, add a è
   - Here is what is in the leader: 01552nam  2200829   4500
   - Had to add all the required subfields
   - Edited the item for the record so that the item has the correct entries
from item dropdown list options and the item type

4. Ran flush_memcached and restart_all and use a refreshed browser.

5. Used this URL:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords=1234

6. Note that the 200$a does not have an è.

7. Applied the patch, run flush_memcached and restart_all

8. The ILS-DI response now includes an è in the 200$a

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32391] [DOCS] Reorganise the manual contents

2024-03-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391

Emmanuel Bétemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/