[Koha-bugs] [Bug 36425] koha-run-backups deletes old backup files based on number of hours since modification - not date of modification

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36425

Alex Buckley  changed:

   What|Removed |Added

 Depends on||30627


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627
[Bug 30627] koha-run-backups delete the backup files after finished its job
without caring days option
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30627] koha-run-backups delete the backup files after finished its job without caring days option

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627

Alex Buckley  changed:

   What|Removed |Added

 Blocks||36425
 CC||alexbuck...@catalyst.net.nz


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36425
[Bug 36425] koha-run-backups deletes old backup files based on number of hours
since modification - not date of modification
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36425] New: koha-run-backups deletes old backup files based on number of hours since modification - not date of modification

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36425

Bug ID: 36425
   Summary: koha-run-backups deletes old backup files based on
number of hours since modification - not date of
modification
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Our Koha partner libraries are all configured to pass koha-run-backups with the
--days 2 parameter. Therefore, theoretically, any old backup files modified on
a date two days ago will be deleted.

However, since bug 30627 was pushed to 23.05.x and 23.11.x, we have noticed for
our larger Koha instances (which run koha-run-backups for a long time each
morning) the .tar.gz file from two days ago is often not deleted. 

This is because the .tar.gz file is not exactly 48+ hours old when the
koha-run-backups runs the find command to identify old files to remove:
https://github.com/Koha-Community/Koha/blob/286fc8e9833d55d694955849e4050d28a4b053a6/debian/scripts/koha-run-backups#L79

Often the .tar.gz file will be 47.9 hours old and therefore not deleted.

The find command should switch to checking the modification date, to ensure all
files created X days ago are deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349

--- Comment #19 from Victor Grousset/tuxayo  ---
(In reply to Jonathan Druart from comment #18)
> What you describe is "expected". At least other login forms are affected by
> this and should be reported on its own bug (ie. not only sci/sco).

Ok, no deeper issue, great.

What is the next step? Calling for help on koha-devel to find a cleaner
approach?
Or going with the current one? In that case I can sign-off. Found nothing else
weird after messing around with the forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #36 from Victor Grousset/tuxayo  ---
It works :)

---

Thanks for the other fixes.
To spare a QA roundtrip, you can fix the remaining issues:

 WARN   Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 318,
now: 333)
 WARN   installer/data/mysql/atomicupdate/bug_32707.pl
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 5)
 WARN   t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 72,
now: 85)

It's a WARN because it's prone to false positives, like at least for
autogenerated code or when moving code.
But in this case it seems valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34516] Upgrade database fails for 22.11.07.003, points to web installer

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34516

--- Comment #26 from dcowen...@gmail.com ---
Thank you to those who worked on this. I waited awhile to try the upgrade,
making sure it was in the Ubuntu package repository. This is what I get when
the database schema fails: 

Upgrading database schema for [instance name]
Upgrade to 22.12.00.026  [02:21:44]: Bug 22440 - Add new /ill_requests
endopoint
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name
'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741

This looks very familiar. The package version is 23.11.03-1. Is there an extra
step I need to take to get past this bug? Or do I need to go back to
oldoldstable?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163823|0   |1
is obsolete||

--- Comment #35 from Victor Grousset/tuxayo  ---
Created attachment 163882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163882=edit
Bug 32707: ElasticSearch should not auto truncate (even if QueryAutoTruncate =
1) for identifiers (and some other fields)

Koha with Zebra prevented auto truncation in some circumstances -- see
the first return for ccl inside C4::Search:: buildQuery, before applying
auto truncation, and setting $auto_truncation = 0 for some search
fields.

Koha with ElasticSearch applies auto truncation for all search fields,
not paying attention to these special cases when it should not be done.
This leads to various problems as described in bug 26508, 26608, etc.

The solution would be to prevent auto truncation for certain search
fields, above all – the identifiers.  In addition, under no
circumstances should a search field other than of text type be truncated
(an attempt to truncate would generate an exception from ElasticSearch,
e.g. number_format_exception for integer).

Test plan
=

0. Use the test data sample provided in the bug report. Comment 16 in
   the ticket.

Scenario A (authority)
--
1. Enable Elasticsearch engine.
2. Have like 100+ bibliographic records and properly linked authority
   records.
3. Reindex ElasticSearch if needed.
4. Enable QueryAutoTruncate systempreference.
5. Find the authority record #1 and note the number of linked biblio
   records.
6. Show the detail of authority #1 and compare the number of linked
   biblio records.
7. If in the database there are authority records with ids =~ /^1/ (i.e.
   10, 11, 12, ..., 100, 101, ...) linked to the biblio records you get
   two different numbers of linked records.
8. Also, as lists of linked biblio records (via link: Used in N
   record(s) from results view and detail view) you will get two
   different sets of biblio records.  In particular, on the list generated
   from detail view (authorities/detail.pl?authid=1) you will get biblio
   records that are in fact not linked to the auth #1 (the list is
   generated with =an:1).
8.99. Skip to scenario B and come back here after finishing to not have
to unapply the patches and restart services for nothing.
9. Apply this patch.
10. Counts and list of linked biblios should be ok.

Scenario B (analytics)
--
1. Enable Elasticsearch engine.
2. Have three monographic bibliographic records with 001 = 1, 10, 100
   (i.e. =~ /^1/).
3. Have an analytical record with 773 $w = 1 (in the test data set - biblio
896).
4. Enable QueryAutoTruncate and UseControlNumber systempreference.
6. Find the analytical record and click on the link generated from 773,
   i.e. (In: ... --> catalogue/search.pl?q=Control-number:1).  You should see
   a list of 100+ records (001 = 1, 10, 100) instead of one (001 = 1).
7. From the biblio # 1 try to go to the analytice records (with Show analytics
   link) - you should get 60+ records with from different host records (773 $t)
   -- instead of one.
8. Apply this patch. Make sure that control-number and record-control-number
   are included in ESPreventAutoTruncate syspref.
9. Repeat steps 6 and 7.  You should arrive at the right host record in p. 6
   and at one analytical records when looking for analytical records in p. 7
   (or more than one, but right, if you modified the test data set).

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163822|0   |1
is obsolete||

--- Comment #34 from Victor Grousset/tuxayo  ---
Created attachment 163881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163881=edit
Bug 32707: Add 'ESPreventAutoTruncate' preference

This patch adds a new 'ESPreventAutoTruncate' preference allowing to define
Elasticsearch search fields that should not be autotruncated when
'QueryAutoTruncate'
is active (e.g. barcode).

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163824|0   |1
is obsolete||

--- Comment #33 from Victor Grousset/tuxayo  ---
Created attachment 163880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163880=edit
Bug 32707: Unit tests

NB in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t,
I had to modify four existing test by changing Local-number:123456 to
Personal-name:donald -- since Local-number should never be
auto truncated according to the submitted patch.

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #158586|0   |1
is obsolete||

--- Comment #18 from Aleisha Amohia  ---
Created attachment 163879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163879=edit
Bug 32256: Add message to SCO that batch checkouts works for checkouts only

Not yet handling renewals, returns, or items that are impossible to check out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #158585|0   |1
is obsolete||

--- Comment #17 from Aleisha Amohia  ---
Created attachment 163878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163878=edit
Bug 32256: Enable batch checkout using self-checkout

This patch allows more than one item to be scanned and processed at once in
Koha's self-checkout module. The items in the batch will still be handled
one-by-one, so if any item in the batch requires confirmation (i.e. to be
renewed or returned) or is impossible to check out, the process will stop at
that item. Any items earlier in the list will be processed, but any items
coming after in the list will be ignored. This feature uses the existing
BatchCheckouts and BatchCheckoutsValidCategories system preferences to
determine if batch checkouts should be allowed.

To test:
1) Open the staff interface. Go to Koha Administration -> Global system
preferences. Search for "BatchCheckouts". Confirm BatchCheckouts syspref is
disabled, and no categories are selected for the BatchCheckoutsValidCategories
syspref.
2) In another tab, open the OPAC self checkout (found out
OPACBaseURL/cgi-bin/koha/sco/sco-main.pl) and log in
3) Confirm the self-checkout works as normal for checking out, returning or
renewing one item at a time
4) Go back to the staff interface tab (you may need to log back in). Enable the
BatchCheckouts syspref but leave the BatchCheckoutsValidCategories syspref
empty.
5) Refresh the OPAC self checkout tab. The barcode input field will now be
bigger to support a list of barcodes. Enter a list of barcodes separated by
newlines and Submit.
6) Only the first barcode should be processed. This is because no categories
are valid for BatchCheckouts.
7) Go back to the staff interface tab (you may need to log back in). Select at
least your patron category for the BatchCheckoutsValidCategories syspref and
Save.
8) Refresh the OPAC self checkout tab. Enter a list of barcodes separated by
newlines and Submit. Confirm all valid items are checked out as expected.
9) Test with a few items that are notforloan or would not be valid checkouts.
Confirm they are not checked out, but other valid items in the batch are
checked out successfully.
10) Test with a batch where one of the items is already checked out to the
patron. The batch should get blocked at this item as the self-checkout asks for
confirmation.
11) Test with both renewing and returning of items that are already checked out
to the patron. This will only work with one item at a time and later items in
the list will be ignored.

Sponsored-by: Koha-US
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352

--- Comment #42 from David Cook  ---
(In reply to David Cook from comment #41)
> (In reply to Martin Renvoize from comment #8)
> > There's an undocumented feature here: When 'autoMemberNum' is enabled
> > there's a second plugin hook available called 'barcode_generate'. 
> > 
> > I'm wondering if this needs to be an explicit method of it's own as
> > currently implemented or it could just be the case for when an empty or
> > undefined cardnumber is passed to the patron_barcode_transform hook?
> 
> Apparently this was already discussed.
> 
> I would've preferred a second hook for sure. I thought maybe it would be
> safe to create a new cardnumber when it's empty/undefined, but
> Koha::Patron::store() has some oddities. Like "patron_barcode_transform"
> gets called twice if you're using autoMemberNum... and fixup_cardnumber()
> assumes the output of autoMemberNum is an integer, which seems presumptuous
> especially when the original use case talked about prefixing/suffixing
> cardnumbers with letters...

I've developed a plugin to create an alphanumeric cardnumber if there's no
cardnumber passed into "patron_barcode_transform", and yeah it doesn't work if
you're using "autoMemberNum".

If you're using "autoMemberNum", the cardnumber referenced in
"patron_barcode_transform" must be a positive integer, or you'll run into
strife.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36424] New: Database update 22.06.00.078 breaks update process (II)

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424

Bug ID: 36424
   Summary: Database update 22.06.00.078 breaks update process
(II)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pablo.bian...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: tomasco...@gmail.com

Following Joubu advice on bug 34520#c12:

After that bug has being fixed, I tried (today 2024-03-25) once again:

Unpacking koha-common (23.11.03-1) over (22.05.19-1) ...
Setting up koha-common (23.11.03-1) ...   
[...]
Upgrading database schema for myinstance 
[...]
Upgrade to 22.06.00.078  [21:13:26]: Bug 24860 - Add ability to place item
group level holds   
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create table
`koha_myinstance`.`reserves` (errno: 150 "Foreign key constraint is incorrectly
formed") at /usr/share/koha/lib/C4/Installer.pm line 741 

dpkg: error processing package koha-common (--configure):
```
```

DB host has a 10.3.34-MariaDB-0+deb10u1-log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #19 from Lucas Gass  ---
This looks good but there are some small fixes to be made: 

1.  WARNinstaller/data/mysql/atomicupdate/bug_36135.pl
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 4)

Perltidy your atomicupdate

2.  forbidden pattern: simple-quote string (line 312)

Line 312: tools/batch_modify_holds.tt, needs double quotes, not single. 

3.FAILtt_valid
lines 134

This probably needs to be something like: 

[% IF hold.found %]

[% ELSE %]

[% END %]

4. Line 123: Title
5. Line 111: Missing a closing 


6. Overall there needs to be some improvement to the HTML:

Expiration date:
Suspended until: 

These should probably be  not . 

 elements inside of ? Not a blocker but should these be separate
fieldsets? 


7. These both use the ID "to" and they should use #expirationdate_to and
#suspend_until_to, respectively.


 56 
 57 To
 58 
 59 


 91 To
 92 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36422] Triggered waiting holds should not display information about transferring because the item is in a rotating collection.

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422

Heather Rommens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Heather Rommens  ---
Followed the testing plan, but when the waiting hold on the item was cancelled,
a transfer was not initiated for the item to return to its current location for
the rotating collection. A message displayed for the slip to be printed, but no
transfer or cancel transfer options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36423] Userid should be removed from PatronSelfModificationMandatoryField and PatronSelfRegistrationBorrowerUnwantedField sys prefs

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36423

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36423] New: Userid should be removed from PatronSelfModificationMandatoryField and PatronSelfRegistrationBorrowerUnwantedField sys prefs

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36423

Bug ID: 36423
   Summary: Userid should be removed from
PatronSelfModificationMandatoryField and
PatronSelfRegistrationBorrowerUnwantedField sys prefs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 29449 removed userid from the OPAC self-reg form, but userid is still a
selectable field in PatronSelfRegistrationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerMandatoryField. Selecting userid in
PatronSelfRegistrationBorrowerMandatoryField quietly populates userid without
an input box, and deselecting userid in
PatronSelfRegistrationBorrowerUnwantedField doesn't display the field. The
option should be removed from the syspref option if selecting/deselecting
doesn't actually change behavior/form display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

--- Comment #16 from Lucas Gass  ---
Needs rebased on top of Bug 34478 now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36422] Triggered waiting holds should not display information about transferring because the item is in a rotating collection.

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |normal
Version|23.05   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36422] Triggered waiting holds should not display information about transferring because the item is in a rotating collection.

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422

--- Comment #1 from Lucas Gass  ---
Created attachment 163877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163877=edit
Bug 36422: Only show rotating collection transfer warning if there are no holds
on an item

To Test:
1. Tools > Rotating collections
2. Set up a rotating collection from Branch A and transfer it to Branch B.
3. From Branch A put a hold on that same item for pickup a Branch A.
4. Check the item in to trigger the hold at Branch A.
5. Notice the modal says that the item is on hold and waiting correctly at
Branch A.
6. The modal also says "Please transfer item to: Branch 2. This is part of a
rotating collection".
7. APPLY PATCH
8. Try steps 3 - 5 again. This time there should be no info. about needing to
transfer the item for the rotating collection.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36422] Triggered waiting holds should not display information about transferring because the item is in a rotating collection.

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #15 from Matthias Le Gac  ---
Created attachment 163876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163876=edit
Bug 36111: removes display of fields 856 if not 856

Test plan:
1. Add 856$h to MARC editor
   1.1. Go to Administration > MARC bibliographic frameworks
   1.2. Next to Default framework, click Actions > MARC structure
   1.3. Search for field 856
   1.4. Click Actions > Edit subfields
   1.5. Click h
   1.6. Check the Editor box
   1.7. Click Save changes
2. Catalog a new record with a random URL in 856$h
   2.1. Go to Cataloging
   2.2. Click New record
   2.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c,
245$a, 942$c)
   2.4. Go to tab 8 and enter a value in 856$h
   2.5. Click Save (No need to add an item)
3. Search for the title in the staff interface (a large enough
   search to have more than one result)
   --> Notice it says "Online resources: Click here to access online"
   3.1. Try to click the link
--> Blank page
4. Access the detailed record in the staff interface
   --> Notice it says "Online resources: Click here to access online"
   4.1. Try to click the link
--> Blank page
5. Search for the title in the opac (a large enough search to have
   more than one result)
   --> Notice it says "Online resources: Click here to access online"
   5.1. Try to click the link
--> Blank page
6. Access the detailed record in the opac
   --> Notice it says "Online resources: Click here to access online"
   6.1. Try to click the link
--> Blank page
7. Apply the patch
8. Replay steps 3 through 6, but this time, the "Online resources"
   field should not be present.
9. Edit the item and add a url in field 856$u
10. Replay steps 3 through 6, but this time, clicking on the link
should take you to the URL specified in the 856$u field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Aleisha Amohia  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26342] Suspended hold not marked filled when patron checks out item

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26342

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

--- Comment #4 from Sarah Cornell  ---
I agree with Christopher.  Koha should prompt staff to ask if the patron would
like to cancel the suspended hold, and it should prompt the patron at the self
check as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36422] Triggered waiting holds should not display information about transferring because the item is in a rotating collection.

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422

Lucas Gass  changed:

   What|Removed |Added

 CC||heat...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36422] New: Triggered waiting holds should not display information about transferring because the item is in a rotating collection.

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422

Bug ID: 36422
   Summary: Triggered waiting holds should not display information
about transferring because the item is in a rotating
collection.
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To recreate:
1. Tools > Rotating collections
2. Set up a rotating collection from Branch A and transfer it to Branch B.
3. From Branch A put a hold on that same item for pickup a Branch A.
4. Check the item in to trigger the hold at Branch A. 
5. Notice the modal says that the item is on hold and waiting correctly at
Branch A. 
6. The modal also says "Please transfer item to: Branch 2. This is part of a
rotating collection".


The warning about transferring because its in a rotating collection should not
show here, it's confusing. It should only show when the hold is canceled or
after it has been checked back in.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to master|ASSIGNED

--- Comment #38 from Katrin Fischer  ---
Could we have QA on the last 2 patches please?

Question: test plan for second patch doesn't mention the commit flag?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

--- Comment #41 from Katrin Fischer  ---
(In reply to Pedro Amorim from comment #40)
> (In reply to Katrin Fischer from comment #39)
> > That makes sense. Do we have some kind of plan on how to handle this
> > post/close to release? Maybe a note on README or using the version settings
> > in the plugin info? (not sure if we are really checking for these so far)
> 
> If bug 35570 is pushed in time for 24.05 this becomes a non-issue I believe,
> as that is planned to supersede FreeForm.
> 
> As for other backends, I've tried my best to address compatibility through
> get_op_param_deprecation in Illrequest.pm but csrf_token needs to exist in
> the POST form anyway, which means some update work will also be required
> unless I'm missing some other alternative. ILL backend maintainer's will
> need to maintain their ILL backends, as it's also the case with regular
> plugins.

Thx for clarifying!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #162303|0   |1
is obsolete||

--- Comment #21 from Brendan Lawlor  ---
Created attachment 163875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163875=edit
Bug 35746: add multiselect to report dropdowns

Rebased for changes to guided_reports_start.tt

This patch adds the ability to use multi select in report dropdowns.

It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>

Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
 WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc

Sponsored-by: CLAMS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find and search

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

David Gustafsson  changed:

   What|Removed |Added

Summary|Add subclass of |Add subclass of
   |Koha::Objects that provides |Koha::Objects that provides
   |caching for find|caching for find and search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

--- Comment #9 from David Gustafsson  ---
Added caching for Patrons and Currencies and attach a flamegraph for the
acquisitions page where Patron::find and Currencies->search are called a large
number of time with the same conditions. Probably only significant when having
a large number of budgets, but it's an example of a page where caching can make
a noticeable difference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

--- Comment #8 from David Gustafsson  ---
Created attachment 163874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163874=edit
After

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

--- Comment #7 from David Gustafsson  ---
Created attachment 163873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163873=edit
Before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163858|0   |1
is obsolete||

--- Comment #6 from David Gustafsson  ---
Created attachment 163872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163872=edit
Bug 36350: Add caching for Objects::find and Objects::search

Add subclass of Koha::Objects that provides cached find and search.

To test:
1) Ensure the following tests pass:
   - t/db_dependend/Koha/Libraries.t
   - t/db_dependent/Koha/ItemTypes.t
   - t/db_dependent/Koha/Patrons.t
   - t/db_dependent/Koha/Acquisition/Currencies.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #20 from Hammat wele  ---
Created attachment 163871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163871=edit
Bug 31736: Editing 'All' in viewlog.tt

This patch edit the term 'All' to 'All log modules',
All log actions and All log interfaces , beacause All can have different
genders depending on the used language ( in french All could mean 'tous for
'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All log modules',
All log actions and All log interfaces
   --> No spelling errors in 'All log modules',
All log actions and All log interfaces
   - Tools > Log viewer > 'All log modules',
All log actions and All log interfaces should be displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #19 from Hammat wele  ---
Created attachment 163870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163870=edit
Bug 31736: Editing 'All' to 'All MARC fields'

This patch edit the term 'All' to 'All MARC fields', beacause All can have
different genders depending on the used language ( in french All could mean
'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All MARC fields'
   --> No spelling errors in 'All MARC fields'
   - Cataloging > MARC modification templates > New template > New Action
  'All MARC fields' should be in the drop-down list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #18 from Hammat wele  ---
Created attachment 163869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163869=edit
Bug 31736: Editing 'All' to 'All display locations'

This patch edit the term 'All' to 'All display locations', beacause All can
have different genders depending on the used language ( in french All could
mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered'
things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All display locations'
   --> No spelling errors in 'All display locations'
   - Tools > News > 'All display locations' in Display location drop-down
   - Creation a new additional content, in Display location select Staff
interface and OPAC
  --> in the Additional contents table the colunm Location should contant
'All display locations'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #17 from Hammat wele  ---
Created attachment 163868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163868=edit
Bug 31736: Editing 'All' to 'All report groups'

This patch edit the term 'All' to 'All report groups', beacause All can have
different genders depending on the used language ( in french All could mean
'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. Reports > Create guided report
3. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All report groups'
   --> No spelling errors in 'All report groups'
   - Reports > Use saved  'All report groups' should be in a tab name
   - 'All report subgroups' should be in Subgroup drop-down

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #16 from Hammat wele  ---
Created attachment 163867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163867=edit
Bug 31736: Editing 'All' to 'Report dictionary areas'

This patch edit the term 'All' to 'Report dictionary areas', beacause All can
have different genders depending on the used language ( in french All could
mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered'
things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'Report dictionary areas'
   --> No spelling errors in 'Report dictionary areas'
   - Reports > View dictionary > Add new definition > 'Report dictionary areas'
should be in Filter by area drop-down

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #15 from Hammat wele  ---
Created attachment 163866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163866=edit
Bug 31736: Editing 'All' to 'All vendors'

This patch edit the term 'All' to 'All vendors', beacause All can have
different genders depending on the used language ( in french All could mean
'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. Create some Additional fields for Invoices and make it searchable
   2.1. Administration > Additional fields > Invoices > New fields
   2.2. Type a Name, select a Authorized value category, and check Searchable
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All vendors'
   --> No spelling errors in 'All vendors'
   - Acquisitions > Invoices > in the Search filters From the >> 'All vendors'
in field drop-down

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #14 from Hammat wele  ---
Created attachment 163865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163865=edit
Bug 31736: Editing 'All' to 'All checkouts'

This patch edit the term 'All' to 'All checkouts', beacause All can have
different genders depending on the used language ( in french All could mean
'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All checkouts'
   --> No spelling errors in 'All checkouts'
   - Go to a patron profile who once took out a loan > Circulation history >
'All checkouts' in checkout tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #13 from Hammat wele  ---
Created attachment 163864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163864=edit
Bug 31736: Editing 'All' to 'All not for loan statuses'

This patch edit the term 'All' to 'All not for loan statuses', beacause All can
have different genders depending on the used language ( in french All could
mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered'
things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All not for loan statuses'
   --> No spelling errors in 'All not for loan statuses'
   - Reports > Items lost > 'All not for loan statuses' in Not for loan
drop-down

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #12 from Hammat wele  ---
Created attachment 163863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163863=edit
Bug 31736: Editing 'All' to 'All lost statuses'

This patch edit the term 'All' to 'All lost statuses', beacause All can have
different genders depending on the used language ( in french All could mean
'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All lost statuses'
   --> No spelling errors in 'All lost statuses'
   - Reports > Items lost > 'All lost statuses' in Lost status drop-down

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #11 from Hammat wele  ---
Created attachment 163862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163862=edit
Bug 31736: Editing 'All' to 'All shelving locations'

This patch edit the term 'All' to 'All shelving locations', beacause All can
have different genders depending on the used language ( in french All could
mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered'
things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All shelving locations'
   --> No spelling errors in 'All shelving locations'
   - Circulation > Hold queue >  'All shelving locations' in Shelving location
drop-down

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #10 from Hammat wele  ---
Created attachment 163861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163861=edit
Bug 31736: Editing 'All' to 'All item types'

This patch edit the term 'All' to 'All item types', beacause All can have
different genders depending on the used language ( in french All could mean
'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All item types'
   --> No spelling errors in 'All item types'

   - Administration > Circulation and fines rules > Item types column ('All
item types' in existing rule)
   - Administration > Circulation and fines rules > Item types column ('All
item types' in drop-down to create a new rule)
   - Administration > Circulation and fines rules > Default waiting hold
cancellation policy > Item types column ('All item types' in existing rule)
   - Administration > Circulation and fines rules > Default waiting hold
cancellation policy > Item types column ('All item types' in drop-down to
create a new rule)
   - Circulation > Hold queue > Item type > 'All item types' in Item type
drop-down
   - Reports > Items lost > 'All item types' in Item type drop-down
   - Installer > Onboarding > New circulation rule (Item type)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #9 from Hammat wele  ---
Created attachment 163860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163860=edit
Bug 31736: Editing 'All' to 'All patron categories'

This patch edit the term 'All' to 'All patron categories', beacause All can
have different genders depending on the used language ( in french All could
mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered'
things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All patron categories'
   --> No spelling errors in 'All' patron categories

   - Administration > Circulation and fines rules > Patron category column
('All patron categories' in existing rule)
   - Administration > Circulation and fines rules > Patron category column
('All patron categories' in drop-down to create a new rule)
   - Administration > Circulation and fines rules > Default waiting hold
cancellation policy > Patron category column ('All patron categories' in
existing rule)
   - Administration > Circulation and fines rules > Default waiting hold
cancellation policy > Patron category column ('All patron categories' in
drop-down to create a new rule)
   - Administration > Circulation and fines rules > Default article request
fees > Patron category column ('All patron categories' in existing rule)
   - Administration > Circulation and fines rules > Default article request
fees > Patron category column ('All patron categories' in drop-down to create a
new rule)
   - Installer > Onboarding > New circulation rule (Patron category)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #8 from Hammat wele  ---
Created attachment 163859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163859=edit
Bug 31736: Editing 'All' to 'All libraries'

This patch edit the term 'All' to 'All libraries/branches', beacause All can
have different genders depending on the used language ( in french All could
mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered'
things).

1. Apply patch

2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All libraries/branches'
   --> No spelling errors in 'All' libraries

   - Acquisitions > Invoices (Library filter on the left)
   - Circulation > Holds queue (Library filter)
   - Reports > Cash register (Transaction library filter)
   - Reports > Items lost (Library filter)
   - Serials > Check expiration (Library filter)
   - Serials > Search settings icon in the search bar > Advanced search
(Library filter)
   - Acquisitions > Add to basket > From a subscription (Library filter on the
left)
   - Installer > Onboarding > New circulation rule (Library)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

Hammat wele  changed:

   What|Removed |Added

 Attachment #162545|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163857|0   |1
is obsolete||

--- Comment #5 from David Gustafsson  ---
Created attachment 163858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163858=edit
Bug 36350: Add caching for Objects::find and Objects::search

Add subclass of Koha::Objects that provides cached find and search.

To test:
1) Ensure the following tests pass:
   - t/db_dependend/Koha/Libraries.t
   - t/db_dependent/Koha/ItemTypes.t
   - t/db_dependent/Koha/Patrons.t
   - t/db_dependent/Koha/Acquisition/Currencies.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163361|0   |1
is obsolete||

--- Comment #4 from David Gustafsson  ---
Created attachment 163857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163857=edit
Bug 36350: Add caching for Objects::find and Objects::search

Add subclass of Koha::Objects that provides cached find and search.

To test:
1) Ensure the following tests pass:
   - t/db_dependend/Koha/Libraries.t
   - t/db_dependent/Koha/ItemTypes.t
   - t/db_dependent/Koha/Patrons.t
   - t/db_dependent/Koha/Acquisition/Currencies.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36421] REST API 500 errors say to check the logs, but suppress errors that would be there

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421

--- Comment #1 from Kyle M Hall  ---
Created attachment 163856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163856=edit
Bug 36421: REST API 500 errors say to check the logs, but suppress errors that
would be there

If a REST auth error happens that that is unblessed or uncaught, we should warn
the value to the logs.

Test Plan:
1) Install the curbside pickups plugin
2) create a patron with the userid 'puser' and the cardnumber 'pcard'
3) GET /api/v1/contrib/curbsidepickup/patrons/XXX/pickups using basic auth with
the username 'pcard' where XXX is the patron borrowernumber
4) Note there is no error in the logs
5) Apply this patch
6) Repeat step 3
7) You should now see an error in the logs!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36421] REST API 500 errors say to check the logs, but suppress errors that would be there

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36420] REST API Basic Auth does not support cardnumbers, only userid

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36420

Kyle M Hall  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36421

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36421] REST API 500 errors say to check the logs, but suppress errors that would be there

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421

Kyle M Hall  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36420

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36421] REST API 500 errors say to check the logs, but suppress errors that would be there

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36421] New: REST API 500 errors say to check the logs, but suppress errors that would be there

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421

Bug ID: 36421
   Summary: REST API 500 errors say to check the logs, but
suppress errors that would be there
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
CC: tomasco...@gmail.com

If a REST auth error happens that that is unblessed or uncaught, we should warn
the value to the logs.

Test Plan:
1) Install the curbside pickups plugin
2) create a patron with the userid 'puser' and the cardnumber 'pcard'
3) GET /api/v1/contrib/curbsidepickup/patrons/XXX/pickups using basic auth with
the username 'pcard' where XXX is the patron borrowernumber
4) Note there is no error in the logs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 163855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163855=edit
Bug 33960: Unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 163854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163854=edit
Bug 33960: Add routes and controller

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

--- Comment #42 from Tomás Cohen Arazi  ---
Created attachment 163853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163853=edit
Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #159998|0   |1
is obsolete||
 Attachment #15|0   |1
is obsolete||
 Attachment #16|0   |1
is obsolete||
 Attachment #160001|0   |1
is obsolete||
 Attachment #160552|0   |1
is obsolete||

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 163852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163852=edit
Bug 33960: Add objects and update schema

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36420] REST API Basic Auth does not support cardnumbers, only userid

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36420

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36420] New: REST API Basic Auth does not support cardnumbers, only userid

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36420

Bug ID: 36420
   Summary: REST API Basic Auth does not support cardnumbers, only
userid
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
CC: tomasco...@gmail.com

Every other part of Koha supports logging in either a userid or cardnumber. The
REST API should support this for basic auth as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462

Amanda Campbell  changed:

   What|Removed |Added

 CC||acampb...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36035] Form is broken in addorderiso2709.pl

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36035

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161932|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 163851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163851=edit
Bug 36035: Wrong text colour in addorderiso2709.pl

This patch updates the "Order staged MARC records" page so that the
class which is added upon selection is more unique to avoid a collision
with some default DataTables styles. These classes are used in
JavaScript selectors, not for visual style.

The patch also adds some custom CSS variables to global.scss to override
the defaults for the DataTables "selected" style, in case this issue
crops up again.

To test, apply the patch and rebuild the staff interface CSS. Follow the
test plan from the bug report:

1) In system preferences, click Search and then select the Acquisitions
   option from the left hand menu
2) Paste the following into MarcFieldsToOrder

price: 975$p
quantity: 975$q
budget_code: 975$h

3) Paste the following into MarcItemFieldsToOrder

homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

4) Save the sysprefs
5) Navigate to acquisitions and go into a basket
6) Click "Add to basket" and select "From a new file"
7) Download the file attached to this bug
8) Import the file and when the job is complete click "Add staged files
   to basket"
9) Click the checkbox next to the record to display the items.
   - The expanded form should look correct.
10) Add one or more items to the order and confirm that submitting the
form works correctly.

To test the new default "selected" DataTables style, view a page with a
DataTable, e.g. Administration -> Libraries.

- Right-click on one of the table rows and choose "Inspect"
- Click the table row element, e.g. ''
- Double-click the class name and replace it with "selected."
- The row you inspected should now have a pale green background and text
  colors should remain the same.

Signed-off-by: Matt Blenkinsop 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36035] Form is broken in addorderiso2709.pl

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36035

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|rel_23_11_candidate |rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 Status|ASSIGNED|In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 163850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163850=edit
[POC] Bug 36419: Use wantarray to control return value

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36035] Form is broken in addorderiso2709.pl

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36035

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36347] Return claims table is loaded twice

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163747|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 163849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163849=edit
Bug 36347: Avoid return claims table being loaded twice

The issue is caused by these lines in circulation.js:

$("#finesholdsissues a[data-toggle='tab']").on("shown.bs.tab", function(e){
$(this).click();
});

When the user clicks on a hidden tab, 'shown.bs.tab' is triggered and
then another click event is triggered. And because the table was loaded
on tab click, it was loaded twice.
Visually it could have caused the rows to be duplicated (it was random,
probably due to timing, network latency, ...)

I don't know why we need to trigger a click in this case, but removing
this will probably break something else, so the fix here is to load the
table on 'shown.bs.tab' event instead of 'click'

This patch also contains a small fix in refreshReturnClaimsTable which
was reloading the table right after the table initialization.

Test plan:
1. Check out an item, and in the checkouts table, click "Claim returned"
2. Open the network tab of your browser's developer tools
3. Click on the "Claims" tab, verify that only one call is made to
   svc/return_claims
4. Verify that the claims table is displayed correctly

Signed-off-by: David Nind 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36347] Return claims table is loaded twice

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36347] Return claims table is loaded twice

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347

Lucas Gass  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36347] Return claims table is loaded twice

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36347

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #4 from Lucas Gass  ---
Changes make sense, works as intended, QA scripts are happy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #15 from Esther Melander  ---
I tested this. I had 5 bibliographic records with attached items. Each
bibliographic record had multiple copies/items. I edited the first item on the
first bibliographic record in the import file to have an incorrect branch code.
When staging, I selected the option to always add the items. After staging the
file, I received the warning that an item has an incorrect branchcode (nice!).
I proceeded to import the file. None of the bibliographic records imported any
items. I did not see a link in the warning message?

I would have expected the one item with the incorrect branch code to be
ignored. I could even expect the bibliographic record that contained this item
would not have any items brought in. But I would expect the rest of the
bibliographic records would import their items.

It would be even more helpful if the warning message was more specific. If this
was a large import file with a few hundred items, finding the one item with the
bad branch code would be quite time consuming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36265] Bigger font-size for headers in staff interface

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36265

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163830|0   |1
is obsolete||

--- Comment #8 from Lucas Gass  ---
Created attachment 163848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163848=edit
Bug 36265: Bigger font-size for headers in staff interface

In staff interface, text in nav bar and search header are at normal
size. Since these are used a lot, I propose to increase font-size at
110%.

Test by applying patch and rebuild CSS to see bigger text in staff
interface

Signed-off-by: Owen Leonard 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36265] Bigger font-size for headers in staff interface

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36265

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

--- Comment #1 from Tomás Cohen Arazi  ---
I have now noticed that the `errors => 1` from the original code was the one
preventing it to work.

So I'll lower the importance to enhancement, but want to propose a signature
change here. For discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9762] Log circulation overrides

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Matthias Le Gac  changed:

   What|Removed |Added

 Attachment #156222|0   |1
is obsolete||

--- Comment #10 from Matthias Le Gac  ---
Created attachment 163847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163847=edit
Bug 9762: Log circulation overrides

Rebase to master

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed


Current status: Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 163846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163846=edit
Bug 19605: Fix after bug 35536

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36383] Add option to set open booking days

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36383

Kristi  changed:

   What|Removed |Added

 CC||kkrue...@cuyahogalibrary.or
   ||g

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35536] Improve removal of Koha plugins in unit tests

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||36419


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419
[Bug 36419] Ambiguous return value in GetPlugins
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com,
   ||tomasco...@gmail.com
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Depends on||35536


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536
[Bug 35536] Improve removal of Koha plugins in unit tests
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36419] New: Ambiguous return value in GetPlugins

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36419

Bug ID: 36419
   Summary: Ambiguous return value in GetPlugins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Bug 35536 introduced some better error handling, but made the return value more
erratic.

We you previously had code like this:

```perl
my @plugins = Koha::Plugins->new()->GetPlugins(
{
method   => 'ill_backend',
metadata => { name => $backend_id },
all  => 1,
errors   => 1
}
);

foreach my $plugin (@plugins) { ... }
```

And now the new return value for GetPlugins is:

```perl
return $errors ? ( \@plugins, \@failing ) : @plugins;
```

This means the caller will need to check the return value, and if the arity is
two (?), check that the second element has some specific structure so we
determine... it is not actually a plugin!

I propose we return a hashref with the plugins and (possibly) the errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

Kristi  changed:

   What|Removed |Added

 CC||kkrue...@cuyahogalibrary.or
   ||g

--- Comment #3 from Kristi  ---
Is this still in progress, or is it ready for a sign off attempt?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431

--- Comment #40 from Pedro Amorim  ---
(In reply to Katrin Fischer from comment #39)
> That makes sense. Do we have some kind of plan on how to handle this
> post/close to release? Maybe a note on README or using the version settings
> in the plugin info? (not sure if we are really checking for these so far)

If bug 35570 is pushed in time for 24.05 this becomes a non-issue I believe, as
that is planned to supersede FreeForm.

As for other backends, I've tried my best to address compatibility through
get_op_param_deprecation in Illrequest.pm but csrf_token needs to exist in the
POST form anyway, which means some update work will also be required unless I'm
missing some other alternative. ILL backend maintainer's will need to maintain
their ILL backends, as it's also the case with regular plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Can't properly renew/checkin from issues-table

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

--- Comment #62 from Matt Blenkinsop  ---
Thanks for signing off Barbara, the unit tests can be checked in QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026

--- Comment #61 from Barbara Johnson  ---
I signed off on all patches. I realize now that one of them was to 'prove
t/db_dependent/Koha/MarcOrder.t' which I don't think I can do in a sandbox?
And, if I can, I don't know how.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled

2024-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060

--- Comment #13 from Lucas Gass  ---
Went to look at QA concerns and noticed Bug 36418, making this one a dependency
of that one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >