[Koha-bugs] [Bug 36176] [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

--- Comment #15 from Fridolin Somers  ---
Bug 36176: Exclude misc/releases_notes/*
Pushed to 23.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36304] Add ability to have an external list of trusted proxies, for services such as CloudFlare.

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36304

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

Summary|Allow option to |Add ability to have an
   |automatically trust |external list of trusted
   |cloudflare proxies  |proxies, for services such
   ||as CloudFlare.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36304] Allow option to automatically trust cloudflare proxies

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36304

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

 Attachment #163515|0   |1
is obsolete||

--- Comment #4 from Nicholas van Oudtshoorn  ---
Created attachment 163973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163973&action=edit
Support for externally updated proxy lists

Thanks for the feedback, David!

It makes sense to move it into the koha-conf.xml file, and this updated patch
has done so. It includes a sample bash script that can be used to keep an
external list file up to date.  This can also easily be extended to
automatically update other providers, hence I have taken away the cloudflare
name, although cloudflare is referenced in a comment in koha-conf.xml

Currently, RealIP was re-generating the trusted_proxies list on every call to
get_real_ip. This patch also uses Koha's caching system to prevent reloading
from the config file and from the external list on every call, which should
speed things up just a little bit.

The sample bash script will restart koha-common if it is running, and also
clear the caches of all koha-instances.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

--- Comment #194 from David Cook  ---
(In reply to David Cook from comment #185)
> Although as I say that I'm finding more changes that need to be backported
> to really support this... heh...

Like koha-tmpl/intranet-tmpl/prog/js/file-upload.js uses XMLHttpRequest
directly and doesn't do AJAX calls via jQuery.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff interface

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |
 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36187] Cannot set suggestedby when adding/editing a suggestion from the staff interface

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #162683|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 163972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163972&action=edit
Bug 36187: Corrected set data.patron_id in select_suggestor()

To test:
1. Make a new suggestion in the staff interface and attempt to set the "Created
by" patron to someone other than the logged in user.
2. Submit the suggestion.
3. select suggestedby from suggestions where suggestionid = X; ( Where X is the
suggestionid )
4. The value is NULL
5. On suggestion/suggestion.pl the "Suggested by" column is blank.
6. APPLY PATCH
7. Try 1 - 3 again. This time the suggestedby should be correctly set.

Signed-off-by: Andrew Fuerste Henry 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893

--- Comment #55 from Victor Grousset/tuxayo  ---
> Added a new patch to change number of tests so my jenkins build passes

Ah yes, that often happens. I don't know if in the lasts cycles something
changed but if not:
when that happened to me I would just commit to the branch and not bother
attaching a follow-up in the ticket. And if caught that when running the tests
locally when backporting, I would append the patch that changed the test.

If that can help you getting rid quicker of those test number issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||vic...@tuxayo.net

--- Comment #5 from Victor Grousset/tuxayo  ---
It works :)

---

To spare a QA roundtrip here is the next step:

 FAIL   Koha/DateTime/Format/RFC3339.pm
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 5)

 FAIL   Koha/DateTime/Format/SQL.pm
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 2)

 WARN   t/Koha/DateTime/Format/RFC3339.t
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 23)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163942|0   |1
is obsolete||

--- Comment #4 from Victor Grousset/tuxayo  ---
Created attachment 163971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163971&action=edit
Bug 36432: Remove circular dependency from Koha::Object

Koha::Object depends on Koha::DateUtils, which depends on C4::Context,
which depends on Koha::Config::SysPref, which depends on... Koha::Object

Apart from the circular dependency, the dependency on C4::Context alone
is problematic as it loads a bunch of modules that are not needed at all
in Koha::Object (YAML::XS and ZOOM for instance).
As Koha::Object is used as a base for a lot of modules, we should take
care to only load the minimum required.

This patch moves some date parsing code to specific modules:
- Koha::DateTime::Format::RFC3339
- Koha::DateTime::Format::SQL

and it uses them in Koha::Object and Koha::DateUtils where it is
possible.

Test plan:
1. Do not apply the patch yet and run the following command:
   `perl -cw Koha/Object.pm`
   It should print several warnings about redefined subroutines, meaning
   there is a circular dependency.
2. Apply the patch
3. Run `perl -cw Koha/Object.pm`. It should only say:
   "Koha/Object.pm syntax OK"
4. Run the following command:
prove \
t/DateUtils.t \
t/Koha/DateTime/Format/RFC3339.t \
t/db_dependent/Koha/Object.t

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36425] koha-run-backups deletes old backup files based on number of hours since modification - not date of modification

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36425

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #1 from Victor Grousset/tuxayo  ---
The -daystart option (from find's man) seems like a simple way to solve this by
truncating the -mtime results IIUC.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #16 from Victor Grousset/tuxayo  ---
Hi :)

The second patch now duplicates the test plan of the 1st patch. That will cause
confusion.

About the switch back to Needs Signoff: are the steps to test the additional
changes the same? Or is there something additional to check about these latest
changes?

The idea is that if someone would forget to apply the second patch, when
testing, they should not get what is expected. Thus demonstrating that the test
plan really tests the changes. If not, that means the test plan isn't complete
enough.
No need to have manual tests showing every single change made by the patches.
It's a balance to show enough of the functional changes and edge cases and to
demonstrate that the related code works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435

--- Comment #1 from Aleisha Amohia  ---
Created attachment 163970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163970&action=edit
Bug 36435: Specify to not show warnings if file changed while koha-dump running

This patch adds a switch to the tar --create command called by koha-dump to
prevent 'file changed' warnings, which stop koha-dump from returning a success
status, which interrupts koha-run-backups before it can delete old backup
files.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||30627


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627
[Bug 30627] koha-run-backups delete the backup files after finished its job
without caring days option
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30627] koha-run-backups delete the backup files after finished its job without caring days option

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||36435


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435
[Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting
old backup files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo  ---
>> Is this the correct fix and if so, do all the svc/* files need it?
> Yes

Maybe these two then?
svc/recall
svc/mana/increment

What about the OPAC?
opac/svc/club/enroll
opac/svc/club/cancel_enrollment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36435] New: Prevent warnings from interrupting koha-run-backups when deleting old backup files

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435

Bug ID: 36435
   Summary: Prevent warnings from interrupting koha-run-backups
when deleting old backup files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Since the changes at Bug 30627, sometimes backup files older than X days don't
get deleted as they are meant to.

In our case, this happens when:

- koha-dump does not return a success status
- because `tar -c` throws a warning "tar:
var/log/koha/INSTANCENAME/opac-access.log: file changed as we read it"

The new dump is created, but the warning is enough to interrupt
koha-run-backups before it gets to deleting old backups.

This causes excess backups to be stored and fills up the disk.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434

--- Comment #1 from Aleisha Amohia  ---
Created attachment 163969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163969&action=edit
Bug 36434: Use a keyword that will be secretly included in all OPAC
bibliographic and authority searches

When a keyword is provided to the new OPACAlwaysSearchKeyword system
preference, Koha will secretly add this to all OPAC searches (both
bibliographic and authority) to help limit results.

Note: This will have unexpected results if authority searches are done with
'starts with' or 'is exactly'. It is only designed to work with 'contains'.

To test:

1. Install database updates and restart services.
2. Do a standard OPAC search using the main search bar for 'this that'. Notice
the number of results.
3. Do an advanced OPAC search, specify keyword: 'this' and keyword: 'that'.
Notice the number of results.
4. In the staff interface, do a biblio search for 'this that'. Edit the first
two records, and put your test keyword somewhere in the MARC, perhaps a note
field 5XX.
5. Go to the Koha Administration -> System preferences and search for
OPACAlwaysSearchKeyword. Add your test keyword to the syspref and Save.
6. Repeat steps 2 and 3. Confirm results are returned, and there should only be
your two records which you added the test keyword to.
7. Remove the test keyword from OPACAlwaysSearchKeyword and Save.

8. Do an OPAC authority search for 'series'. Notice the number of results.
9. In the staff interface, do an authority search for 'series'. Edit the first
two records, and put your test keyword somewhere in the MARC, perhaps in the
040$f.
10. Repeat step 5.
11. Repeat steps 8 and 9. Confirm results are returned, and there should only
be your two records which you added the test keyword to.

12. Click on 'Welcome, your name' in the top right of the OPAC and go to your
search history. Confirm the test keyword added to OPACAlwaysSearchKeyword does
NOT show in your history, for both catalog and authority searches.

13. Confirm all results are returned as normal when OPACAlwaysSearchKeyword is
empty.

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35610] Missing FK on old_reserves.branchcode?

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #16 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

Test with comment 10 and checked that before the patch, orphan branchcodes
where left and that after the patch, existing ones where handled and it was not
possible to create new ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35610] Missing FK on old_reserves.branchcode?

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35610] Missing FK on old_reserves.branchcode?

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610

--- Comment #15 from Victor Grousset/tuxayo  ---
Created attachment 163968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163968&action=edit
Bug 35610: (QA follow-up): tidy up code

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35610] Missing FK on old_reserves.branchcode?

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163827|0   |1
is obsolete||

--- Comment #14 from Victor Grousset/tuxayo  ---
Created attachment 163967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163967&action=edit
Bug 35610: Set branchcode to NULL before adding the FK

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35610] Missing FK on old_reserves.branchcode?

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #161540|0   |1
is obsolete||

--- Comment #13 from Victor Grousset/tuxayo  ---
Created attachment 163966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163966&action=edit
Bug 35610: Add FK on old_reserves.branchcode

Signed-off-by: Kyle M Hall 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23352] Define serial's collection in the subscription

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

--- Comment #55 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 163965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163965&action=edit
Bug 23352: [22.05] (follow-up) change number of tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz
 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36434] New: Use a keyword that will be secretly included in all OPAC bibliographic and authority searches

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434

Bug ID: 36434
   Summary: Use a keyword that will be secretly included in all
OPAC bibliographic and authority searches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Libraries might repurpose their OPAC to only search certain records.

These records might still have relevant collection, item type, shelving
location information, so it doesn't work to use these fields to filter OPAC
searches on.

It might be easier to add a 'keyword' to the MARC for these records, and have
Koha secretly apply this keyword to the search, when switched on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893

--- Comment #54 from wainuiwitikap...@catalyst.net.nz ---
(In reply to wainuiwitikapark from comment #53)
> Created attachment 163964 [details] [review]
> Bug 34893: [22.05] (follow-up) change number of tests

Added a new patch to change number of tests so my jenkins build passes
https://jenkins.koha-community.org/job/Koha_Sec/job/Koha_22.05/lastCompletedBuild/testReport/(root)/t_db_dependent_ILSDI_Services_t/Number_of_runned_tests_does_not_match_plan___376_/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34893] ILS-DI can return the wrong patron for AuthenticatePatron

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34893

--- Comment #53 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 163964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163964&action=edit
Bug 34893: [22.05] (follow-up) change number of tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

David Cook  changed:

   What|Removed |Added

 CC||f.demi...@tamil.fr

--- Comment #48 from David Cook  ---
Frédéric can we get this into 22.11? I know there are folk out there having
this issue in prod still.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755

--- Comment #47 from David Cook  ---
(In reply to Lucas Gass from comment #45)
> https://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=t/Token.t;
> h=355282c6ed83f89f18ed0b7609667772f579b991;
> hp=d34089a9087a372dfcd0d50cb9d2c3e483daeb3f;
> hb=c9375e746b3f57e8c1101fce32d48138dc9c030b;
> hpb=f859c30704f868b11e0b5bbfb8185d4966ba0606
> 
> Will look tomorrow.

I went to look at this, and noticed that you've already fixed them. Thanks,
Lucas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

--- Comment #14 from wainuiwitikap...@catalyst.net.nz ---
(In reply to Lucas Gass from comment #13)
> Created attachment 163960 [details] [review]
> Bug 36176: Exclude misc/releases_notes/*

added to 22.05-x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36369] Make APIClient be more useful

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32209] Item subfields required even when supplied for each order

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32209

Joe Askins  changed:

   What|Removed |Added

 CC||jask...@faylib.org

--- Comment #3 from Joe Askins  ---
New Koha library experiencing this same issue when staging carts from Baker &
Taylor. We'd love to see a fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34827] "Item information" tab should not appear when adding to a basket from a staged file if items are created using MarcItemFieldsToOrder

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34827

Joe Askins  changed:

   What|Removed |Added

 CC||jask...@faylib.org

--- Comment #2 from Joe Askins  ---
New Koha library experiencing this same issue when staging carts from Baker &
Taylor. We'd love to see a fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

Frédéric Demians  changed:

   What|Removed |Added

 Attachment #163944|0   |1
is obsolete||

--- Comment #5 from Frédéric Demians  ---
Created attachment 163963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163963&action=edit
Bug 36433: Plugin hook elasticsearch_to_document

Add a new hook elasticsearch_to_document in order to allow completing
the 'document' to be sent to Elasticsearch. Usage example: (1) add new
search fields, (2) normalize/sanitize existing fields, (3) use id fields
to retrieve info via web services in other repositories (say VIAF), (4)
download file referenced in a field, and index its content.

To test:

1. Apply the unit tests patch, and run it:

   prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t

   => FAIL: Tests fail! The hook is not implemented so the desired

2. Apply this patch, and then repeat 1:

   => SUCCESS: It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #71 from Michal Denar  ---
Hi,
I am following the Test plan, but the missing authorities will not download
from 39.50. What is worse, in the lines where the link to the authority is
missing, when I click on the Create authority icon I get error 403: Programming
error - No CSRF token passed for POST
http://localhost:8081/intranet/authorities/authorities.pl (referer:
http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=)

I'm not sure if I was able to set up LinkerZ3950Server correctly. It would be
more user friendly and reliable to choose from the available servers rather
than just writing its name. 

Then I have one more question. If z39.50 provide separately personal and
subject, we may run into the problem that this option is now not possible to
set up. Yet for fields 100 or 700 we are just looking for personal authorities
and in fields 6X for subjects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

Frédéric Demians  changed:

   What|Removed |Added

 Attachment #163943|0   |1
is obsolete||

--- Comment #4 from Frédéric Demians  ---
Created attachment 163962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163962&action=edit
Bug 36433: UT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items current and desired locations

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #160559|0   |1
is obsolete||

--- Comment #7 from Emily Lamancusa  ---
Created attachment 163961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163961&action=edit
Bug 22567: Add transfer details to stockrotation page

This patch adds any pending/current transfer details into the
stockrotation item management page.

Signed-off-by: Nick Clemens 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

--- Comment #13 from Lucas Gass  ---
Created attachment 163960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163960&action=edit
Bug 36176: Exclude misc/releases_notes/*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36176] [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176

--- Comment #12 from Lucas Gass  ---
Can we exclude `misc/release_notes/*`, this is causing builds to fail for
stable releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

--- Comment #8 from David Gustafsson  ---
Created attachment 163959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163959&action=edit
Bug 26744: Only log if BorrowersLog syspref is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

Hannah Olsen  changed:

   What|Removed |Added

 CC||hol...@duncanville.com

--- Comment #35 from Hannah Olsen  ---
This is an issue for us as well, as withdrawn items still show up in searches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163957|0   |1
is obsolete||

--- Comment #7 from David Gustafsson  ---
Created attachment 163958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163958&action=edit
Bug 26744: Log changes to extended patron attributes

Log non-repeatable attributes and only log changes and creations, not
deletions.
When changed, attributes are first all deleted, then the relevant ones are
recreated.
This patch catches all deletions, and checks against them in the creation
phase, logging
only the attributes that have changed (with before/after content). This makes
it impossible
to log actual deletions.

To test:

1) Ensure tests in  t/db_dependent/Koha/Patron/Attribute.t passes

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |
 CC||glask...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

--- Comment #6 from David Gustafsson  ---
Created attachment 163957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163957&action=edit
Bug 26744: Log changes to extended patron attributes

Log non-repeatable attributes and only log changes and creations, not
deletions.
When changed, attributes are first all deleted, then the relevant ones are
recreated.
This patch catches all deletions, and checks against them in the creation
phase, logging
only the attributes that have changed (with before/after content). This makes
it impossible
to log actual deletions.

To test:

1) Ensure tests in  t/db_dependent/Koha/Patron/Attribute.t passes

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

--- Comment #7 from Martin Renvoize  ---
Haha, that's great. This was really just a bit of a proof of concept I pulled
out of the lead-in/trail-out work I've been doing for one of the other bookings
bugs. I decided I was going down a wrong path there but liked this piece enough
to pull it out for safe keeping here.

Thanks for writing a test plan and the feedback Esther.  You've identified most
of the points I was worried about as it happens.  It won't scale well as it is
UI wise but I haven't come up with an alternative as yet so I'm open to
suggestions.  I was contemplating different colours for different items, dots
Vs lines, hints in hover or numeric labels for numbers if items booked per day.

All good for thought, I'll continue here once I've got the tie other bookings
bugs I have in progress submitted as they have a more pressing deadline at the
minute.

Thanks again,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36027] search_for_data_inconsistencies.pl - make each section optional

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027

Phan Tung Bui  changed:

   What|Removed |Added

 Attachment #162351|0   |1
is obsolete||
 Attachment #162540|0   |1
is obsolete||
 Attachment #162546|0   |1
is obsolete||
 Attachment #163259|0   |1
is obsolete||

--- Comment #17 from Phan Tung Bui  ---
Created attachment 163956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163956&action=edit
Bug 36027: change interactive to pass param and add check options

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

--- Comment #23 from Phan Tung Bui  ---
Created attachment 163955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163955&action=edit
Bug 30745 : Fix pagination error

1. I've fixed the pagination option
2. "Select all" and "clear all" buttons seem all functional for me. Could you
double check it with my new test plan?

Test Plan 
- Activate Zebra as search engine
- Cataloging ->  Label Creator 
- Click on "New" then "Label Batch"
- Click on "Add item(s)"
- Choose a search option (For exemple i put "a" for "Title" so that we can
obtain a result that has multiple pages)
- Click on "Search"
- Scroll all the pages using page number or "Previous" and "Next" button to
test the pagination option
- Click on "Select all" or "Clear all" to test the functionality of both
buttons then click on "Add checked", the barcode of the seleccted items will be
added to the "Add by barcode(s) or itemnumbers(s)" case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

Phan Tung Bui  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35172] Order receiving error

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35172

Keith Dembek  changed:

   What|Removed |Added

 CC||kdem...@sjcfl.us

--- Comment #7 from Keith Dembek  ---
This happens to me in 23.05.09 if the items were not given an item type during
the acquisitions process. Once I go to the record and give them an item type,
they'll suddenly appear in the receiving search results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

Esther Melander  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Esther Melander  ---
This seems to work fine. It would be nice to have a hover function for the
dots. Some libraries have many copies, such as for a book club, and the dots
may not work as well - may cause a very cluttered date picker. I did not test
the limits, but something to consider. For now, it works as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #163572|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 163954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163954&action=edit
Bug 36373: Show existing bookings in the datepicker

This patch exposes existing bookings as info dots in the flatpickr

Signed-off-by: Esther 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36373] Show existing bookings in datepicker

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36373

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #4 from Esther Melander  ---
My test plan:

1. Search the catalog and find an item and make it bookable
2. Place a booking on that item (select the same barcode) for three different
patrons.

See the available booking dates change with each additional booking for the
same item.

Repeat this, but

1. Select a bibliographic record with multiple items. Make each item bookable.
2. Place a booking, but select the option for "any item" for three different
patrons. Have one of the bookings overlap another.

See the available booking dates change with each additional booking. The dates
with a dot indicate a copy  has been booked. A date with more than one dot
indicates more than one copy has been booked.

Look at the bookings tab for the bibliographic record. See the different
bookings with the patrons names and dates and the assigned item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

--- Comment #51 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #50)
> Nick, was this one sponsored.. there's no sponsor lines ;)

This one does not need credit beyond ByWater, and all the community folks that
helped ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #11 from Nick Clemens  ---
(In reply to Martin Renvoize from comment #8)
> Sorry, can we get some unit tests here.

Signed off as test plan works, but Martin is correct, unit tests would be
useful

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

--- Comment #10 from Nick Clemens  ---
Created attachment 163953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163953&action=edit
Bug 33237: (follow-up) Tidy

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Nick Clemens  changed:

   What|Removed |Added

 Attachment #148785|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 163952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163952&action=edit
Bug 33237: If TranslateNotices is off, use the interface language includes in
slips

This patch set the language used in slips folloinw this logic:
   --> uses patron's preferred language
   --> if patron's preferred language is 'default', use the interface language
   --> if there is no interface (for overdue_notices for example), use the
first language in 'language' system preference

To Test:
1. Install the other language (i used fr-CA here)
 1.1.

 gulp po:update fr-CA

 ./misc/translator/translate install fr-CA

 1.2. In Administration > Global system preferences, search for language
and check the added language

2. Create a manual invoice in a patron's account and pay it

3. From the Transactions tab, click 'Print' next to the payment line
   --> On the printed slip, there's the word 'Payment' in English (OK)

4. Switch interface to other language

5. Redo step 3
   --> On the printed slip, the word 'Payment' is still in English (not ok)

6. In Administration > Global system preferences, enable TranslateNotices

7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the
letter into all the languages

8. Redo step 3 (you should still be in the other language interface)
   --> On the printed slip, the word 'Payment' is still in English (not ok)

9. Edit the patron's account and change the preferred language to the other
language

10. Redo step 3
   --> On the printed slip, the word 'Payment' is in the other language
(Paiement) (OK)

11. Apply the patch

12. Reset config
12.1. Edit the patron's account and change back the preferred language to
'default'
12.2. In Administration > Global system preferences, disable
TranslateNotices

13. Redo step 3 (you should still be in the other language interface)
   --> On the printed slip, the word 'Payment' is in the other language
(Paiement)

14. Switch interface to the english language

15. Redo step 3
   --> On the printed slip, the word 'Payment' is in English

16. In Administration > Global system preferences, enable TranslateNotices

17. Edit the patron's account and change the preferred language to the other
language

18. Redo step 3
   --> On the printed slip, the word 'Payment' is in the other language
(Paiement)

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

--- Comment #50 from Martin Renvoize  ---
Nick, was this one sponsored.. there's no sponsor lines ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #49 from Martin Renvoize  ---
My apologies, this one slipped the net for me.

Looks great now with the work that's happened since I last assessed it.

I'm happy to PQA on it, tests all passing, QA script is happy and it all makes
clear sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163855|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize  ---
Created attachment 163951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163951&action=edit
Bug 33960: Unit tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163854|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 163950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163950&action=edit
Bug 33960: Add routes and controller

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163853|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Created attachment 163949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163949&action=edit
Bug 33960: Add api mapping and biblioitems to Old::Biblios to match Biblio

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163852|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize  ---
Created attachment 163948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163948&action=edit
Bug 33960: Add objects and update schema

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #70 from Hammat wele  ---
Created attachment 163947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163947&action=edit
Bug 11300: (Fix) Z3950Server.pm, deleting Biblio.pm.rej and adding a new
atomicupdate

To test:
1. Apply the patch
2. Set the preference LinkerModule to Z39.50 Server
3. Set the preference LinkerZ3950Server to LIBRARY OF CONGRESS SUBJECTS
4. Set the preference LinkerOptions to local_first
5. Verify that your local authorities include 'Perl (Computer program
language)' but do not include 'Scripting languages (Computer science)'
6. Cataloging > New record
7. In tab 6, field 650, paste Perl (Computer program language) in subfield a
and click 'Link authorities automatically' - you should be told '650 - A
matching authority was found in the local database.' which verifies that
authority linking currently works at all.
8. Clear the 650 by clicking the 'Delete this tag' icon with the red X at the
end of the tag description, and paste 'Scripting languages (Computer science)'
in subfield a and click 'Link authorities automatically'
   --->  you should be told 'A matching authority record was found on the
Z39.50 server and was imported locally.'
   ---> you should also find the imported authority in your local authorities

This test is based on Subject field 650a it should also work with other field
(100a, 110a ...) with a valid Z39.50 Server

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Hammat wele  changed:

   What|Removed |Added

 Attachment #159741|0   |1
is obsolete||

--- Comment #69 from Hammat wele  ---
Created attachment 163946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163946&action=edit
Bug 11300: Add a new authority linker which searches for authority links on a
Z39.50 server.

This patch adds a Z39.50 Linker which searches for authority links on a remote
server.

If a matching authority is found, it's imported in the local database for
linking with the current biblio record.

If no matching authority was found on the remote server, the Linker falls back
to a local authority search.

Configuration :
* The option "Z39.50 Server" is added to the LinkerModule preference. You must
choose this to use the new Linker.
* The preference LinkerZ3950Server is required and specifies which server to
use for linking. It must contain the "name" of the server, as defined in the
z3950servers table.
* You can set the "local_first" option in the LinkerOptions preference to force
the Linker to search for authorities in the local database first. If no local
authority match was found, the Linker falls back to a remote Z39.50 search.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Hammat wele  changed:

   What|Removed |Added

 Attachment #159742|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #16 from Frédéric Demians  ---
See also bug 36433

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36431] SIP2: Checkin does not show difference between WasTransfered and NeedsTransfer

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431

--- Comment #2 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #1)
> As I understand, we cannot change the CV value. This SIP extension stands
> for "send to other branch".
> 
> But would it make sense to populate for instance the AF field [screen
> message] in the response to show that the transfer was already actually
> created (when AddReturn responded with WasTransfered) ?

CV is non-standard but is documented at
https://help.oclc.org/Library_Management/Amlib/SIP2/SIP2_Manager_procedure/170Media_Types

01 - hold for this library
02 - hold for other branch
04 - send to other branch

In both of those code paths, there is indeed a real transfer. In the case of
WasTransfered, it means a transfer was initiated, but the item has been checked
in at the library the transfer originated from, so the destination and location
in this case are not the same. Am I mistaken?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find and search

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

--- Comment #11 from David Gustafsson  ---
Rebased on current master. The local caching of patrons in Bug 35921 is no
longer needed and can be reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find and search

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350

David Gustafsson  changed:

   What|Removed |Added

 Attachment #163872|0   |1
is obsolete||

--- Comment #10 from David Gustafsson  ---
Created attachment 163945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163945&action=edit
Bug 36350: Add caching for Objects::find and Objects::search

Add subclass of Koha::Objects that provides cached find and search.

To test:
1) Ensure the following tests pass:
   - t/db_dependend/Koha/Libraries.t
   - t/db_dependent/Koha/ItemTypes.t
   - t/db_dependent/Koha/Patrons.t
   - t/db_dependent/Koha/Acquisition/Currencies.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

--- Comment #3 from Frédéric Demians  ---
Created attachment 163944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163944&action=edit
Bug 36433: Plugin hook elasticsearch_to_document

Add a new hook elasticsearch_to_document in order to allow completing
the 'document' to be sent to Elasticsearch. Usage example: (1) add new
search fields, (2) normalize/sanitize existing fields, (3) use id fields
to retrieve info via web services in other repositories (say VIAF), (4)
download file referenced in a field, and index its content.

To test:

1. Apply the unit tests patch, and run it:

   prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t

   => FAIL: Tests fail! The hook is not implemented so the desired

2. Apply this patch, and then repeat 1:

   => SUCCESS: It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

--- Comment #2 from Frédéric Demians  ---
Created attachment 163943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163943&action=edit
Bug 36433: UT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

Frédéric Demians  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

Frédéric Demians  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Frédéric Demians  ---
Close to bug 31897

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

Frédéric Demians  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36433] New: Plugin hook elasticsearch_to_document

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36433

Bug ID: 36433
   Summary: Plugin hook elasticsearch_to_document
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: frede...@tamil.fr
QA Contact: testo...@bugs.koha-community.org

Add a new hook elasticsearch_to_document in order to allow completing the
'document' to be sent to Elasticsearch. Usage example: (1) add new search
fields, (2) normalize/sanitize existing fields, (3) use id fields to retrieve
info via web services in other repositories (say VIAF), (4) download file
referenced in a field, and index its content.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Martin Renvoize  ---
Sorry, can we get some unit tests here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33552] Automatic renewals should only send emails for successes

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552

Cindy Murdock Ames  changed:

   What|Removed |Added

 CC||cmurd...@ccfls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36154] Add the ability for some pages to be able to use images coming from plugin

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #3 from Esther Melander  ---
I tested this. I added some local cover images to a few items in a list. I
could see the Cover column for the list, but not the local images. I checked
the Opac and did not see any local cover images. I turned on the system
preference OPACLocalCoverImages to see the images in the OPAC and they did not
show in the Patron Summary, Patron Checkout History, or in the public list.
There was no separate column for the Cover image in the Patron Summary or
Checkout History.

I then turned on:

AmazonCoverImages
OPACAmazonCoverImages

This then displayed  Amazon cover images and my local cover images in the OPAC.
The cover images still did not show in the staff interface list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Julian Maurice  changed:

   What|Removed |Added

 Attachment #163941|0   |1
is obsolete||

--- Comment #3 from Julian Maurice  ---
Created attachment 163942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163942&action=edit
Bug 36432: Remove circular dependency from Koha::Object

Koha::Object depends on Koha::DateUtils, which depends on C4::Context,
which depends on Koha::Config::SysPref, which depends on... Koha::Object

Apart from the circular dependency, the dependency on C4::Context alone
is problematic as it loads a bunch of modules that are not needed at all
in Koha::Object (YAML::XS and ZOOM for instance).
As Koha::Object is used as a base for a lot of modules, we should take
care to only load the minimum required.

This patch moves some date parsing code to specific modules:
- Koha::DateTime::Format::RFC3339
- Koha::DateTime::Format::SQL

and it uses them in Koha::Object and Koha::DateUtils where it is
possible.

Test plan:
1. Do not apply the patch yet and run the following command:
   `perl -cw Koha/Object.pm`
   It should print several warnings about redefined subroutines, meaning
   there is a circular dependency.
2. Apply the patch
3. Run `perl -cw Koha/Object.pm`. It should only say:
   "Koha/Object.pm syntax OK"
4. Run the following command:
prove \
t/DateUtils.t \
t/Koha/DateTime/Format/RFC3339.t \
t/db_dependent/Koha/Object.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules)

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959

--- Comment #32 from Marcel de Rooy  ---
(In reply to Julian Maurice from comment #31)
> I just submitted bug 36432. It removes a circular dependency. It doesn't fix
> the problem with Koha::AuthorisedValue, but I think we should try to go this
> way instead of messing with the load order of modules

Fine with me. It was a nice exercise ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Julian Maurice  changed:

   What|Removed |Added

 Attachment #163940|0   |1
is obsolete||

--- Comment #2 from Julian Maurice  ---
Created attachment 163941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163941&action=edit
Bug 36432: Remove circular dependency from Koha::Object

Koha::Object depends on Koha::DateUtils, which depends on C4::Context,
which depends on Koha::Config::SysPref, which depends on... Koha::Object

Apart from the circular dependency, the dependency on C4::Context alone
is problematic as it loads a bunch of modules that are not needed at all
in Koha::Object (YAML::XS and ZOOM for instance).
As Koha::Object is used as a base for a lot of modules, we should take
care to only load the minimum required.

This patch moves some date parsing code to specific modules:
- Koha::DateTime::Format::RFC3339
- Koha::DateTime::Format::SQL

and it uses them in Koha::Object and Koha::DateUtils where it is
possible.

Test plan:
1. Do not apply the patch yet and run the following command:
   `perl -cw Koha/Object.pm`
   It should print several warnings about redefined subroutines, meaning
   there is a circular dependency.
2. Apply the patch
3. Run `perl -cw Koha/Object.pm`. It should only say:
   "Koha/Object.pm syntax OK"
4. Run the following command:
prove \
t/DateUtils.t \
t/Koha/DateTime/Format/RFC3339.t \
t/db_dependent/Koha/Object.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30800] Ability to view, modify, and delete profiles for staging MARC records for import

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30800

Joe Askins  changed:

   What|Removed |Added

 CC||jask...@faylib.org

--- Comment #1 from Joe Askins  ---
New Koha library cosigning this bug -- we'd love to have a more obvious and
intuitive way to view, edit, and delete these profiles.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules)

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959

--- Comment #31 from Julian Maurice  ---
I just submitted bug 36432. It removes a circular dependency. It doesn't fix
the problem with Koha::AuthorisedValue, but I think we should try to go this
way instead of messing with the load order of modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

--- Comment #1 from Julian Maurice  ---
Created attachment 163940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163940&action=edit
Bug 36432: Remove circular dependency from Koha::Object

Koha::Object depends on Koha::DateUtils, which depends on C4::Context,
which depends on Koha::Config::SysPref, which depends on... Koha::Object

Apart from the circular dependency, the dependency on C4::Context alone
is problematic as it loads a bunch of modules that are not needed at all
in Koha::Object (YAML::XS and ZOOM for instance).
As Koha::Object is used as a base for a lot of modules, we should take
care to only load the minimum required.

This patch moves some date parsing code to specific modules:
- Koha::DateTime::Format::RFC3339
- Koha::DateTime::Format::SQL

and it uses them in Koha::Object and Koha::DateUtils where it is
possible.

Test plan:
1. Do not apply the patch yet and run the following command:
   `perl -cw Koha/Object.pm`
   It should print several warnings about redefined subroutines, meaning
   there is a circular dependency.
2. Apply the patch
3. Run `perl -cw Koha/Object.pm`. It should only say:
   "Koha/Object.pm syntax OK"
4. Run the following command:
prove \
t/DateUtils.t \
t/Koha/DateTime/Format/RFC3339.t \
t/db_dependent/Koha/Object.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36432] New: Remove circular dependency from Koha::Object

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432

Bug ID: 36432
   Summary: Remove circular dependency from Koha::Object
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Koha::Object depends on Koha::DateUtils, which depends on C4::Context, which
depends on Koha::Config::SysPref, which depends on... Koha::Object

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36369] Make APIClient be more useful

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369

--- Comment #6 from Paul Derscheid  ---
If you want to validate input before passing it to api clients, please use zod
or something similar.

That makes it very declarative and easy to maintain.

Here's a list of options compared by performance:
https://moltar.github.io/typescript-runtime-type-benchmarks/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35599] Pronouns and HidePersonalPatronDetailOnCirculation

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599

--- Comment #3 from pierre.ge...@biblibre.com ---
It works for me : address or phone number are hidden but pronom still displays.
Someone else to test and sign off ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36431] SIP2: Checkin does not show difference between WasTransfered and NeedsTransfer

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431

--- Comment #1 from Marcel de Rooy  ---
As I understand, we cannot change the CV value. This SIP extension stands for
"send to other branch".

But would it make sense to populate for instance the AF field [screen message]
in the response to show that the transfer was already actually created (when
AddReturn responded with WasTransfered) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

2024-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #36 from Frédéric Demians  ---
Backported (big word) to 22.11.x for 22.11.16

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >