[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799

--- Comment #2 from Phil Ringnalda  ---
Moved setting waitSeconds: 0 to bug 36461, so it can be about making it
possible to load the editor, and this can be about making it pleasant to load
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461

--- Comment #1 from Phil Ringnalda  ---
Created attachment 164099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164099=edit
Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0

We aren't actually doing any error handling with the RequireJS waitSeconds
config, just leaving the advanced editor hanging on loading if it times out,
so instead we should disable it.

Test plan:

1. Set the preference EnableAdvancedCatalogingEditor to Enable
2. Load the Cataloging module home page in Firefox and open Firefox's
   Web Developer Tools, and in the Network tab change from "No Throttling"
   to "Regular 2G"
3. In the Cataloging page, click Advanced editor, and watch it attempt to
   load for 30 seconds, followed by a setTimout error in the devtools console,
   and then wait as long as you can stand for anything but the "Loading,
   please wait..." to happen in the web page. Nothing ever will.
4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to
   Enable, turn throttling on, load the Advanced editor again, and note that
   even though it will take a minute or more to load through the throttling,
   the editor does actually load.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461

Phil Ringnalda  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799

Phil Ringnalda  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36461

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36461] New: Advanced editor should disable RequireJS timeout with waitSeconds: 0

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461

Bug ID: 36461
   Summary: Advanced editor should disable RequireJS timeout with
waitSeconds: 0
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: p...@chetcolibrary.org
  Reporter: p...@chetcolibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

We currently set waitSeconds: 30 for RequireJS in the advanced editor, which as
bug 35799 says just causes loading of the editor to hang forever if loading any
required part (which practially speaking means loading
svc/cataloguing/framework) takes more than 30 seconds.

As jrburke says in https://github.com/requirejs/requirejs/issues/787
waitSeconds exists to show developers why things aren't working when they try
to require something that 404s, and to allow error handling in old versions of
IE. But since we aren't doing any error handling, we'd be better off setting it
to 0, which disables the timeout, and just letting things load no matter how
long they take.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799

lthor...@cuyahogalibrary.org  changed:

   What|Removed |Added

 CC||lthor...@cuyahogalibrary.or
   ||g

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35829] Codename for 24.05

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35829

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

--- Comment #2 from Brendan Lawlor  ---
I really love the idea of codenames. I suggested Henriette at the meeting
because of her work developing MARC in 1968, but I just found another really
fitting codename from more recent history.

Codename Polly, after Jean Armour Polly, one of the first librarians to offer
public computer access in 1981 and public Internet access in 1992. She is also
credited with coining the phrase 'Surfing the Internet' which is pretty rad. 

Surfing Bugzilla, reporting bugs, testing or writing a patch, can be like the
thrill of finding the perfect wave and catching it.

It's a nod to a librarian and Internet advocate and also to the web's open
standards that have been critical for Koha to be developed as the first web
based open source ILS.

https://www.internethalloffame.org/inductee/jean-armour-polly/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36460] When lost item payment is voided or refunded prompt librarian for new status

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36460

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

Lisette Scheer  changed:

   What|Removed |Added

 Blocks||36460


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36460
[Bug 36460] When lost item payment is voided or refunded prompt librarian for
new status
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36460] When lost item payment is voided or refunded prompt librarian for new status

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36460

Lisette Scheer  changed:

   What|Removed |Added

 Depends on||22740


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740
[Bug 22740] Automatically change lost status when item is paid for
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36460] New: When lost item payment is voided or refunded prompt librarian for new status

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36460

Bug ID: 36460
   Summary: When lost item payment is voided or refunded prompt
librarian for new status
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When a lost item has been either written off or paid for, if the status is
changed to "Lost and Paid for" or another lost status (per bug 22470) there
should be an easy option for the librarian to change to a new status, or an
additional preference to automatically set it to a chosen lost value.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

--- Comment #17 from Lisette Scheer  ---
I think 2 system prefs (lost->paid & lost->written off/voided) would be better
than hardcoding. 

Additionally, I think Andrew's question about voiding and refunding would be a
separate bug, which I'm filing and I'll add as a see also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36169] Add guarantee to patron categories with type='Staff'

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36169

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

--- Comment #4 from Lisette Scheer  ---
Additionally, staff might use it like this:

Main tech services account/tech services manager is guarantor to all the people
they manage. 
This way they can easily find all the checkouts in one place for the
department.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #19 from Victor Grousset/tuxayo  ---
Thanks for the additional steps :)
The back to need signoff now is clear, there is additional behavior to test.

Remaining is the issue of the 1st patch having the old test plan. So there is
duplication and someone coming to test is likely to miss the full test plan in
the 2nd patch. And signoff without having actually tested the last changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35357] Item not removed from holds queue when checked out to a different patron

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35357

--- Comment #33 from Victor Grousset/tuxayo  ---
This is weird, 23.11.x has $dbh declared at the beginning of the function.
https://gitlab.com/koha-community/Koha/-/blob/23.11.x/C4/Circulation.pm#L1548

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

David Gustafsson  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #15 from David Gustafsson  ---
I realised it actually was not too much trouble also logging changes to
repeatable attributes (and deletions) if instead performing the logging in
Koha::Patron->extended_attributes, so I revised the patch to do that instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26744] Log changes to extended patron attributes

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744

--- Comment #14 from David Gustafsson  ---
Created attachment 164098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164098=edit
Bug 26744: Add support for repeatable and deleted attributes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36459] Backdating checkouts on circ/circulation.pl not working properly

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459

--- Comment #1 from Lucas Gass  ---
This highlights the fact that there are multiple '#duedatespec' on the same
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

--- Comment #17 from Victor Grousset/tuxayo  ---
Tested & SOed Lucas' follow-up, and added another follow-up for the OPAC cases.
Amended test plan to add the URLs used to test Lucas' follow-up and mine
partially.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #164066|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

--- Comment #16 from Victor Grousset/tuxayo  ---
Created attachment 164097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164097=edit
Bug 36418: opac/svc/club: switch content-type to application/json

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

--- Comment #15 from Victor Grousset/tuxayo  ---
Created attachment 164096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164096=edit
Bug 36418: Catch more cases where header response should be application/json

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163923|0   |1
is obsolete||

--- Comment #14 from Victor Grousset/tuxayo  ---
Created attachment 164095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164095=edit
Bug 36418: Set header response content type to application/json - svc

We need to set the content type to application/json for the svc scripts
returning json

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #163922|0   |1
is obsolete||

--- Comment #13 from Victor Grousset/tuxayo  ---
Created attachment 164094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164094=edit
Bug 36418: Explicitly set response to json

To test:
1. Add some checkouts and load the issues-table
2. Select 'Check in' checkbox for that item and click "Check in selected items"
3. The row becomes read and reads "Unable to check in"
4. Reload the page, the item has actually checked in

5. Try the 'Renew' checkbox and click "Renew selected items"
6. It just spins and spins.
7. Reload the page, the item has actually renewed.
8. APPLY PATCH and restart_all
9. Try the steps again and this time everything should work properly.
10. tests these URLs
http://localhost:8081/cgi-bin/koha/svc/recall
http://localhost:8080/cgi-bin/koha/svc/club/enroll
http://localhost:8081/cgi-bin/koha/svc/mana/increment : empty response

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35560] Use the REST API for holds history

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35560] Use the REST API for holds history

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35560] Use the REST API for holds history

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560

--- Comment #19 from Owen Leonard  ---
This works well for me except with title sorting. The "anti-the" sorting type
doesn't seem to be taken into account even though the markup looks correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35560] Use the REST API for holds history

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35560

--- Comment #18 from Owen Leonard  ---
Created attachment 164093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164093=edit
Bug 35560: (follow-up) Add in-page links to jump between tables

Also a terminology change: I think "Past holds" reads better than
"Historical holds."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

--- Comment #39 from Pedro Amorim  ---
(In reply to Tomás Cohen Arazi from comment #29)
> I've just sent a PR for adjusting the sample plugin to the proposed changes.

I got some errors testing it and followed up, please take a look when possible:
https://github.com/PTFS-Europe/koha-ill-backend-plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443

Owen Leonard  changed:

   What|Removed |Added

 Attachment #164033|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 164092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164092=edit
Bug 36443: Add a fax field / column to the batch patron modification tool

To test:
1. Create or modify an existing patron account so that they have a
   value in their fax number field.
2. Go to Tools > Batch patron modification
1. Add the patron card number, or borrower number into the
   modification tool and click on continue. There is no option for
   modifying fax numbers, nor are fax numbers visible in the
   modification table.
3. Apply the patch and restart_all
4. Repeat step 2
1. A column for ‘Fax’ is now visible after ‘Other phone’
2. Test the ‘Fax’ field by clearing out the field with the checkbox.
   ‘Checking the box right next to the label will disable the entry
   and delete the values of that field on all selected patrons.’
3. Test the ‘Fax’ field by updating the value with a new number
5. Sign off and have a wonderful day :)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

--- Comment #38 from Pedro Amorim  ---
Created attachment 164091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164091=edit
Bug 19605: Another fix after bug 35536

Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163846|0   |1
is obsolete||

--- Comment #37 from Pedro Amorim  ---
Created attachment 164090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164090=edit
Bug 19605: Fix after bug 35536

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163007|0   |1
is obsolete||

--- Comment #36 from Pedro Amorim  ---
Created attachment 164089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164089=edit
Bug 19605: Clarify method name

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163006|0   |1
is obsolete||

--- Comment #35 from Pedro Amorim  ---
Created attachment 164088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164088=edit
Bug 19605: Rename method and use the instantiated plugin in the call

This patch makes the backend instantiation happen through a plugin
object method instead of a static one. This way, the (already)
instantiated plugin can be reused (if needed) in the plugin workflow
like this:

sub new_il_backend {
my ($self, $params) = @_;
return Custom::Backend->new(
{
config => $params->{config},
logger => $params->{logger},
plugin => $self,
}
);
}

The passed plugin object would then be used to retrieve whatever
plugin-defined configurations, template paths or even helper methods. On
INN-Reach, it gives the backend access to API user agents, task queue
injection, etc.

This patch also renames the method so it is more straight-forward this is
related to ILL.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163005|0   |1
is obsolete||

--- Comment #34 from Pedro Amorim  ---
Created attachment 164087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164087=edit
Bug 19605: Tidy

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163004|0   |1
is obsolete||

--- Comment #33 from Pedro Amorim  ---
Created attachment 164086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164086=edit
Bug 19605: Add support for ILL backends as plugins

This is designed to maintain existing functionality of loading ILL
backends through the backend_dir config (default Koha/Illbackends/).

A check for a plugin of a given backend name takes precedence over a
backend of the same name loaded the old way through backend_dir, this
means that if this happens, the backend plugin is used and NOT the
backend present in backend_dir.

Old backend_dir backends AND new backend plugins coexist.

Test plan, k-t-d:
1) Enable ILLModule and install FreeForm, run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Install the plugin ILL backend example .kpz located at:
https://github.com/ammopt/koha-ill-backend-plugin/releases/tag/1.0.0
3) koha-plack --restart kohadev
4) Visit ILL requests:
/cgi-bin/koha/ill/ill-requests.pl
5) Click "+ New ILL request". Notice it lists 'FreeForm' and
   'PluginBackend'
6) Click 'PluginBackend'. Enter a '123' in pubmedid, '42' in cardnumber
   and pick a library. Click 'Marke request'
7) Notice the request is created successfully.
8) Visit plugins:
/cgi-bin/koha/plugins/plugins-home.pl
9) Click "View plugin by class". Pick "ill backend plugins". Notice the
   correct plugin is listed.
10) Click "configure" on the ILL backend plugin. Notice it's a normal
plugin configuration page

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163003|0   |1
is obsolete||

--- Comment #32 from Pedro Amorim  ---
Created attachment 164085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164085=edit
Bug 19605: Update expandTemplate to expand_template method name

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163002|0   |1
is obsolete||

--- Comment #31 from Pedro Amorim  ---
Created attachment 164084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164084=edit
Bug 19605: Add 'ill_backend' plugin category

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18885] When 'on-site checkout' was used, the 'Specify due date' should be emptied for next checkout unless OnSiteCheckoutAutoCheck

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Lucas Gass  changed:

   What|Removed |Added

 Blocks||36459


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459
[Bug 36459] Backdating checkouts on circ/circulation.pl not working properly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36459] Backdating checkouts on circ/circulation.pl not working properly

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459

Lucas Gass  changed:

   What|Removed |Added

 Depends on||18885


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885
[Bug 18885] When 'on-site checkout' was used, the 'Specify due date' should be
emptied for next checkout unless OnSiteCheckoutAutoCheck
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36459] New: Backdating checkouts on circ/circulation.pl not working properly

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36459

Bug ID: 36459
   Summary: Backdating checkouts on circ/circulation.pl not
working properly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate: 

1. Go to circ/circulation.pl and check an item out to a patron.
2. Backdate it to sometime in the past using the "Specify due date (MM/DD/)
: " input
3. A modal appears to "Please confirm checkout". The date is no longer
populated in that field. 
4. You must add the date again here. 


This is due to Bug 18885.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447

Owen Leonard  changed:

   What|Removed |Added

 Attachment #164065|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 164083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164083=edit
Bug 36447: Circ rules slow to load when many itemtypes and categories

It seems that we loop all categories and item types to build the circ
matrix. We should only loop over values that have actually been used
in circulation rules.

Test Plan:
1) Create 1000 itemtypes and category codes. You can use the following
   script:

   use t::lib::TestBuilder;
   my $builder = t::lib::TestBuilder->new();
   $builder->build( { source => 'Category' } ) for 0..1000;
   $builder->build( { source => 'Itemtype' } ) for 0..1000;

2) Note the lengthy load time for smart-rules.pl
3) Apply this patch
4) Restart all the things!
5) Reload the page
6) Note the much faster load time!

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36451] Parenthesis removed from biblio's title in notice

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36451

--- Comment #2 from Jonathan Druart  ---
Yes, I went all the archeological work this morning as well. Hence the "then
propagated". It's not "coming from" bug 19578, I only restore (what I thought
was) a broken behaviour.

Still no idea what's best here. Needs might differ I guess...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163816|0   |1
is obsolete||

--- Comment #95 from Pedro Amorim  ---
Created attachment 164082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164082=edit
Bug 35581: POD fixes

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163815|0   |1
is obsolete||

--- Comment #94 from Pedro Amorim  ---
Created attachment 164081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164081=edit
Bug 35581: (follow-up) Remove internal use of ->illrequestattributes

By now, we shouldn't be using the deprecated method internally.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163814|0   |1
is obsolete||

--- Comment #93 from Pedro Amorim  ---
Created attachment 164080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164080=edit
Bug 35581: Cleanup Comments.t

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163813|0   |1
is obsolete||

--- Comment #92 from Pedro Amorim  ---
Created attachment 164079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164079=edit
Bug 35581: Koha::REST::V1::Illrequests -> Koha::REST::V1::ILL::Requests

Test plan:
1. Apply patch
2. Make sure tests pass, run:
prove t/db_dependent/api/v1/ill_*

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163812|0   |1
is obsolete||

--- Comment #91 from Pedro Amorim  ---
Created attachment 164078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164078=edit
Bug 35581: Koha::Illrequest -> Koha::ILL::Request

Koha/Illrequests.pm -> Koha/ILL/Requests.pm

Merged:
t/db_dependent/Koha/Illrequests.t
t/db_dependent/Illrequests.t

Into:
t/db_dependent/Koha/ILL/Requests.t

ILL classes file structure is, for the most part, around 7 years old and
doesn't follow a strict logic. It's so confusing that some test files exist
redundantly.

This housekeeping should help future work in regards to ISO18626 to add Koha as
a supplying agency instead of just requesting agency, as is now.
It should also help future housekeeping of moving backend related logic out of
the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as
of this patchset).
It should also help in structuring the addition of a master generic form (see
bug 35570)

This patchset will require existing backends to be updated to match the new
class names and structure, if they invoke them.

Test plan, k-t-d, run tests:
prove t/db_dependent/api/v1/ill_*
prove t/db_dependent/Koha/ILL/*

Test plan, k-t-d, manual:
1) Install FreeForm, enable ILL module, run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) You'll have to switch the FreeForm repo to the one compatible with this
work, like:
cd /kohadevbox/koha/Koha/Illbackends/FreeForm
git checkout reorganize_ILL
3) Do some generic ILL testing:
3.1) Create a request
3.2) Add a comment to a request
3.3) Edit a request
3.4) Edit a request's item metadata
3.5) Confirm a request
3.6) List requests
3.7) Filter requests list using left side filters
4) Install a metadata enrichment plugin:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed
4.1) Create an ILL batch and insert a pubmedid like 123
4.2) Add the request and finish batch
5) Verify all of the above works as expected

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163811|0   |1
is obsolete||

--- Comment #90 from Pedro Amorim  ---
Created attachment 164077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164077=edit
Bug 35581: Koha::Illrequest::SupplierUpdate* ->
Koha::ILL::Request::SupplierUpdate*

Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm
Koha/Illrequest/SupplierUpdateProcessor.pm ->
Koha/ILL/Request/SupplierUpdateProcessor.pm

Signed-off-by: David Nind 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163810|0   |1
is obsolete||

--- Comment #89 from Pedro Amorim  ---
Created attachment 164076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164076=edit
Bug 35581: Koha::Illrequest::Logger -> Koha::ILL::Request::Logger

Signed-off-by: David Nind 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163809|0   |1
is obsolete||

--- Comment #88 from Pedro Amorim  ---
Created attachment 164075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164075=edit
Bug 35581: Koha::Illrequest::Config -> Koha::ILL::Request::Config

Signed-off-by: David Nind 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163808|0   |1
is obsolete||

--- Comment #87 from Pedro Amorim  ---
Created attachment 164074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164074=edit
Bug 35581: Koha::Illrequest::Workflow* -> Koha::ILL::Request::Workflow*

Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm
Koha/Illrequest/Workflow/Availability.pm ->
Koha/ILL/Request/Workflow/Availability.pm
Koha/Illrequest/Workflow/TypeDisclaimer.pm ->
Koha/ILL/Request/Workflow/TypeDisclaimer.pm

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163807|0   |1
is obsolete||

--- Comment #86 from Pedro Amorim  ---
Created attachment 164073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164073=edit
Bug 35581: Koha::Illrequestattribute* -> Koha::ILL::Request::Attribute*

Koha/Illrequestattribute.pm -> Koha/ILL/Request/Attribute.pm
Koha/Illrequestattributes.pm -> Koha/ILL/Request/Attributes.pm

Signed-off-by: David Nind 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163806|0   |1
is obsolete||

--- Comment #85 from Pedro Amorim  ---
Created attachment 164072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164072=edit
Bug 35581: Koha::Illcomment* -> Koha::ILL::Comment*

Koha/Illcomment.pm -> Koha/ILL/Comment.pm
Koha/Illcomments.pm -> Koha/ILL/Comments.pm

Signed-off-by: David Nind 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163805|0   |1
is obsolete||

--- Comment #84 from Pedro Amorim  ---
Created attachment 164071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164071=edit
Bug 35581: Illbatchstatus* -> ILL::Batch::Status*

Koha/IllbatchStatus.pm -> Koha/ILL/Batch/Status.pm
Koha/IllbatchStatuses.pm -> Koha/ILL/Batch/Statuses.pm
Koha/REST/V1/IllbatchStatuses.pm -> Koha/REST/V1/ILL/Batch/Statuses.pm

Signed-off-by: David Nind 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163804|0   |1
is obsolete||

--- Comment #83 from Pedro Amorim  ---
Created attachment 164070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164070=edit
Bug 35581: Koha::*Illbatch* -> Koha::*ILL::*Batch*

Koha/Illbatch.pm -> Koha/ILL/Batch.pm
Koha/Illbatches.pm -> Koha/ILL/Batches.pm
Koha/REST/V1/Illbatches.pm -> Koha/REST/V1/ILL/Batches.pm
t/db_dependent/Koha/Illbatch.t -> t/db_dependent/Koha/ILL/Batch.t
t/db_dependent/Illbatches.t -> t/db_dependent/Koha/ILL/Batches.t

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35581] ILL Koha classes are not consistent

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #163803|0   |1
is obsolete||

--- Comment #82 from Pedro Amorim  ---
Created attachment 164069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164069=edit
Bug 35581: Koha::Illbackend -> Koha::ILL::Backend

Koha/Illbackend.pm -> Koha/ILL/Backend.pm
Koha/REST/V1/Illbackends.pm -> Koha/REST/V1/ILL/Backends.pm

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Pedro Amorim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36451] Parenthesis removed from biblio's title in notice

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36451

Frédéric Demians  changed:

   What|Removed |Added

 CC||f.demi...@tamil.fr

--- Comment #1 from Frédéric Demians  ---
> What was its original need? No idea!

But who knows :-) ? After all, it comes from your patch on bug 19578...

It's more archeology than IT. You isolated in C4::Letters:

$val =~ s/\p{P}$// if $val && $table=~/biblio/;

Which itself come from bug 9886.

Removing trailing ponctuation characters in biblio.title could make sense in
MARC21 catalog, but not in UNIMARC. In MARC21, ISBD cataloging rules prescribe
to add a ponctuation if you have subtitle: $aPrivate eyeballs :$ba golden
treasury of bad taste. So biblio.title end with ' :'. It's not the case in
UNIMARC. Furthermore, now that we have biblio.subtitle, even in MARC21 removing
trailing ponctuation may be an issue.

There may be several options:

1) Suppress any trailing ponctuation character curation.
2) Remove ponctuation less aggressively, just :,;. for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9762] Log circulation overrides

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Matthias Le Gac  changed:

   What|Removed |Added

 Attachment #164067|0   |1
is obsolete||

--- Comment #16 from Matthias Le Gac  ---
Created attachment 164068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164068=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Fix POD problem for Circulation.pm


Current status: Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434

Esther Melander  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #7 from Esther Melander  ---
The concern with this approach is the potential for abuse over time. Search
engines have been accused of such things for years.

OpacHiddenItems can hide the one collection in the Koha OPAC. What is available
for display/use in the Discovery Layer depends on how the discovery layer
handles the OpacHiddenItems flag. It is perhaps better handled at the discovery
layer level and not Koha directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178

Eric  changed:

   What|Removed |Added

 CC||e...@bywatersolutions.com

--- Comment #2 from Eric  ---
Yes please

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9762] Log circulation overrides

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #15 from Matthias Le Gac  ---
And I will make a new patch for test Circulation.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36458] Koha::Item->return_claim method name is not correct

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36458

--- Comment #2 from Tomás Cohen Arazi  ---
or maybe.. `$item->return_claims->get_newest_active`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9762] Log circulation overrides

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #14 from Matthias Le Gac  ---
For the "skip_record_index" I don't now why Emily deleted this code but I thing
we need this code so I put it back. Tell me if it's good??

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9762] Log circulation overrides

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Matthias Le Gac  changed:

   What|Removed |Added

 Attachment #163847|0   |1
is obsolete||
 Attachment #164022|0   |1
is obsolete||

--- Comment #13 from Matthias Le Gac  ---
Created attachment 164067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164067=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

In this patch I smatch my log fix and tideness fix. I will make another patch
for the new test.


Current status: Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14322] Can't link to an item search

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7335] Allow custom parameters for sorting in SQL reports

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

--- Comment #12 from Lucas Gass  ---
Created attachment 164066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164066=edit
Bug 36418: Catch  more cases where header respose should be application/json

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447

--- Comment #1 from Kyle M Hall  ---
Created attachment 164065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164065=edit
Bug 36447: Circ rules slow to load when many itemtypes and categories

It seems that we loop all categories and item types to build the circ
matrix. We should only loop over values that have actually been used
in circulation rules.

Test Plan:
1) Create 1000 itemtypes and category codes. You can use the following script:
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new();
$builder->build( { source => 'Category' } ) for 0..1000;
$builder->build( { source => 'Itemtype' } ) for 0..1000;
2) Note the lengthy load time for smart-rules.pl
3) Apply this patch
4) Restart all the things!
5) Reload the page
6) Note the much faster load time!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||36458


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36458
[Bug 36458] Koha::Item->return_claim method name is not correct
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36458] Koha::Item->return_claim method name is not correct

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36458

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Koha::Item-rreturn_claim
   ||method name is not correct
 CC||tomasco...@gmail.com
 Depends on||28854

--- Comment #1 from Tomás Cohen Arazi  ---
This method should be named something like 'newest_unresolved_claim'. I leave
it to others to pick the right name. But as-is it is ambiguous.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items for circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36458] New: Koha::Item-r

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36458

Bug ID: 36458
   Summary: Koha::Item-rhttps://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7335] Allow custom parameters for sorting in SQL reports

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36315] ILSDI GetRecord speed improvement.

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36315

--- Comment #1 from Didier Gautheron  ---
Created attachment 164064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164064=edit
Bug 36315: ILSDI GetRecords use AuthorisedValues cache for items.location

Speedup GetRecords by using Koha cache for items.location authorised value.

Test plan
1) Enable ILS-DI
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=ILS-DI
2) Download a record  
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords=1
3) Note location_description
4) Apply patch
5) Re download the same record
6) Verify location_description are the same

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36315] ILSDI GetRecord speed improvement.

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36315

Didier Gautheron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33312] Add circulation and fines rules table from smart-rules.pl to column settings

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312

Lisette Scheer  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com,
   ||lisette.scheer@bywatersolut
   ||ions.com,
   ||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36457] Add way for reports to default to logged in library when branches in runtime parameters

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36457

Lisette Scheer  changed:

   What|Removed |Added

Summary|Add way for reports to  |Add way for reports to
   |default to logged in|default to logged in
   |library when branches in|library when branches in
   |runtime paramaters  |runtime parameters

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36457] Add way for reports to default to logged in library when branches in runtime paramaters

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36457

Lisette Scheer  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com,
   ||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36457] New: Add way for reports to default to logged in library when branches in runtime paramaters

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36457

Bug ID: 36457
   Summary: Add way for reports to default to logged in library
when branches in runtime paramaters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It would be great if when you add branches as a runtime parameter, similar to
the "all" options, you could default branch selectors to the logged in library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36455] Default the hold queue link to your logged in library

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455

Lisette Scheer  changed:

   What|Removed |Added

 Blocks||36456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36456
[Bug 36456] Add count of holds on queue to hold queue link
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36456] Add count of holds on queue to hold queue link

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36456

Lisette Scheer  changed:

   What|Removed |Added

 Depends on||36455
 CC||Laura.escamilla@bywatersolu
   ||tions.com,
   ||lu...@bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455
[Bug 36455] Default the hold queue link to your logged in library
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36456] New: Add count of holds on queue to hold queue link

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36456

Bug ID: 36456
   Summary: Add count of holds on queue to hold queue link
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I guess a different option for both this and bug 36455 would be to add a link
on the home page with patron mods/purchase suggestions for the library's hold
queue + count of your library's queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35815] [Elasticsearch] Fix indexing of bibliographic records when items are deleted

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35815

Clemens Tubach  changed:

   What|Removed |Added

 CC||clemens.tub...@kit.edu

--- Comment #7 from Clemens Tubach  ---
We also have this problem on production 23.05.04 using elastic 7.
The background job 'batch_item_record_deletion' was finished successfully and
items are deleted.
But the related background job 'update_elastic_index' stays in status 'new', so
the item is visible in the search result.

We couldn't reproduce it on current master with KTD either.

We hope that the problem will be solved with improvements in bug 35819 and
related.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@gmail.com   |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36455] Default the hold queue link to your logged in library

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455

Lisette Scheer  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com,
   ||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36455] New: Default the hold queue link to your logged in library

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455

Bug ID: 36455
   Summary: Default the hold queue link to your logged in library
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To reduce clicks for library staff, defaulting the hold queue link on
circulation home to the logged in library would be helpful, either as an option
or as the default behavior with the option to run it for a different branch
from the queue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597

--- Comment #12 from Pedro Amorim  ---
(In reply to R Bradshaw from comment #11)
> Thanks Pedro. 
> 
> Yes, it allows me to create ILL book requests for an expired user. However,
> at the point of checkout (i.e. after the item record has been created) it
> presents an error message saying there is a problem with the users account. 
> It is extremely subtle as a message  though – just a line of grey test
> amongst other lines of grey text.
> Thanks,
> Becca

Got it, thanks for clarifying!
If/when you have the chance, please take a quick look at bug 36454 and confirm
that we're on the same page regarding this or correct/add anything. Much
appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597

--- Comment #11 from R Bradshaw  ---
Thanks Pedro. 

Yes, it allows me to create ILL book requests for an expired user. However, at
the point of checkout (i.e. after the item record has been created) it presents
an error message saying there is a problem with the users account. 
It is extremely subtle as a message  though – just a line of grey test amongst
other lines of grey text.
Thanks,
Becca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36418] Set response's content-type to application/json when needed - svc scripts

2024-03-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36418

--- Comment #11 from Jonathan Druart  ---
Can you provide a follow-up maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >