[Koha-bugs] [Bug 36451] Parenthesis removed from biblio's title in notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36451 --- Comment #3 from Katrin Fischer --- It feels odd that we remove ), I think removing other characters makes more sense that are used as standalone ISBD punctuation. I feel this is still handy for MARC21, but maybe we could make it optional as a custom TT filter when using TT in notices going forward? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in EDIFACT list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Katrin Fischer changed: What|Removed |Added Summary|Fix typo in edifact list|Fix typo in EDIFACT list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466 --- Comment #3 from Hammat wele --- Created attachment 164156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164156=edit Bug 36466: (follow-up) Adding atomicupdate file to fix -00-00 in serial table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466 Hammat wele changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466
--- Comment #2 from Hammat wele ---
Created attachment 164155
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164155=edit
Bug 36466: Incorrect date value stored when 'Published on' or 'Expected on' are
empty
When we edit a serial and we leave the date fields ('Published on' or 'Expected
on') empty
incorrect date are saved in the database -00-00 instade of current date and
we get Error 500
to reproduce
1. Connect to staff interface
2. Go to Serials and create a new subscription
3. Click on Serial collection in the left menu (and note the Subscription
numnber)
4. Select a serial to edit and Click on «Edit serials»
5. In the Serial edition form, delete «Published on > and « Expected on » dates
and save
> Error 500 page is displayed
6. Check the value of «Published on > and « Expected on » dates in the
database
select planneddate,publisheddate from serial where
subscriptionid=;
--> planneddate publisheddate have «-00-00» value
7. Apply the patch
8. repeat step 2, 3, 4, 5, 6
-> Error 500 page is no more displayed
-> «Published on » and « Expected on » field have today date
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Hammat wele changed: What|Removed |Added CC||hammat.w...@inlibro.com Attachment #164154|1 |0 is patch|| Attachment #164154|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039
--- Comment #23 from Hammat wele ---
Created attachment 164154
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164154=edit
Bug 33039: Incorrect date value stored when 'Published on' or 'Expected on' are
empty
When we edit a serial and we leave the date fields ('Published on' or 'Expected
on') empty
incorrect date are saved in the database -00-00 instade of current date and
we get Error 500
to reproduce
1. Connect to staff interface
2. Go to Serials and create a new subscription
3. Click on Serial collection in the left menu (and note the Subscription
numnber)
4. Select a serial to edit and Click on «Edit serials»
5. In the Serial edition form, delete «Published on > and « Expected on » dates
and save
> Error 500 page is displayed
6. Check the value of «Published on > and « Expected on » dates in the
database
select planneddate,publisheddate from serial where
subscriptionid=;
--> planneddate publisheddate have «-00-00» value
7. Apply the patch
8. repeat step 2, 3, 4, 5, 6
-> Error 500 page is no more displayed
-> «Published on » and « Expected on » field have today date
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466 Hammat wele changed: What|Removed |Added Attachment #164153|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466
--- Comment #1 from Hammat wele ---
Created attachment 164153
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164153=edit
Bug 33039: Incorrect date value stored when 'Published on' or 'Expected on' are
empty
When we edit a serial and we leave the date fields ('Published on' or 'Expected
on') empty
incorrect date are saved in the database -00-00 instade of current date and
we get Error 500
to reproduce
1. Connect to staff interface
2. Go to Serials and create a new subscription
3. Click on Serial collection in the left menu (and note the Subscription
numnber)
4. Select a serial to edit and Click on «Edit serials»
5. In the Serial edition form, delete «Published on > and « Expected on » dates
and save
> Error 500 page is displayed
6. Check the value of «Published on > and « Expected on » dates in the
database
select planneddate,publisheddate from serial where
subscriptionid=;
--> planneddate publisheddate have «-00-00» value
7. Apply the patch
8. repeat step 2, 3, 4, 5, 6
-> Error 500 page is no more displayed
-> «Published on » and « Expected on » field have today date
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind changed: What|Removed |Added Attachment #164150|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 164152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164152=edit Bug 34041 - z3950 responder additional options not coming through properly This patch adds the node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466 Hammat wele changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |hammat.w...@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466 Hammat wele changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36466] New: Incorrect date value stored when "Published on" or "Expected on" are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36466
Bug ID: 36466
Summary: Incorrect date value stored when "Published on" or
"Expected on" are empty
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs@lists.koha-community.org
Reporter: hammat.w...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
When we edit a serial and we leave the date fields ("Published on" or "Expected
on") empty
incorrect date are saved in the database -00-00 instade of current date and
we get Error 500
to reproduce
1. Connect to staff interface
2. Go to Serials and create a new subscription
3. Click on Serial collection in the left menu (and note the Subscription
numnber)
4. Select a serial to edit and Click on «Edit serials»
5. In the Serial edition form, delete «Published on > and « Expected on » dates
and save
> Error 500 page is displayed
6. Check the value of «Published on > and « Expected on » dates in the
database
select planneddate,publisheddate from serial where
subscriptionid=;
--> planneddate publisheddate have «-00-00» value
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #25 from Matthias Le Gac --- I tested with your file and the items that are good imported well and those with bad branches did not. For the record "Working effectively with legacy code" I have the item with homebranch "FPL" but not the item with homebranch "MPAL". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36366] Itemtype can be used in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
Status|Signed Off |Failed QA
--- Comment #5 from Nick Clemens ---
I think this should match the format of other information:
my $itemtype = C4::Koha::xml_escape($item->effective_itemtype&&
exists $itemtypes->{$item->effective_itemtype}?
$itemtypes->{$item->effective_itemtype}:
$item->effective_itemtype);
Other wise we end up with undef when the effective itemtype is not an official
itemtype, and I think we should still display the type code in that case.
Also, we are xml escaping other values, so should on this one too
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35953] Add delete_any_record cataloguing subpermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Can we get some explanation here on what the purpose is? If I understand, this is to remove 'deletion' from 'edit_catalogue' and make it a new standalone permission? If correct we also need to grant the permission existing users with 'editcatalogue' in the database update I find 'delete_any_record' confusing - edit_any_item is because there are items that can be restricted - are there records that could be restricted and not possible to delete? This plan/patch does not cover authorities, which would be implied by 'any' record. I do see that 'acquisition->order_manage' seems to grant the ability to delete order related biblios And the tools permissions for batch deletion allow you to delete items/bibs without cataloging permissions Have you verified there are not other places from which a biblio can be deleted? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #21 from Matthias Le Gac --- I put the test plan in the commit message It's better now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #164029|0 |1 is obsolete|| --- Comment #20 from Matthias Le Gac --- Created attachment 164151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164151=edit Bug 36111: removes display of fields 856y3z if not 856u Test plan: 1. Add 856$h to MARC editor 1.1. Go to Administration > MARC bibliographic frameworks 1.2. Next to Default framework, click Actions > MARC structure 1.3. Search for field 856 1.4. Click Actions > Edit subfields 1.5. Click h 1.6. Check the Editor box 1.7. Click Save changes 2. Catalog a new record with a random URL in 856$h 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c, 245$a, 942$c) 2.4. Go to tab 8 and enter a value in 856$h 2.5. Click Save (No need to add an item) 3. Search for the title in the staff interface (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 3.1. Try to click the link --> Blank page 4. Access the detailed record in the staff interface --> Notice it says "Online resources: Click here to access online" 4.1. Try to click the link --> Blank page 5. Search for the title in the opac (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 5.1. Try to click the link --> Blank page 6. Access the detailed record in the opac --> Notice it says "Online resources: Click here to access online" 6.1. Try to click the link --> Blank page 7. Edit the item and add a text in field 856$y 8. Access the detailed record in the staff interface --> Notice it says what you put in 856$y field 9. Apply the patch 10. Replay steps 3 through 6, but this time, the "Online resources" field should not be present. 11. Replay steps 7 through 8, but this time, what you put in 856$y field should not be present. 12. Edit the item and add a url in field 856$u 13. Replay steps 3 through 6, but this time, clicking on the link should take you to the URL specified in the 856$u field. 14. Replay steps 7 through 8, but this time, what you put in 856$y field should be present and clicking on the link should take you to the URL specified in the 856$u field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Nick Clemens changed: What|Removed |Added Attachment #152448|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 164150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164150=edit Bug 34041 - z3950 responder additional options not coming through properly This patch adds the node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34041] z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #24 from Matthias Le Gac --- Created attachment 164149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164149=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #23 from Matthias Le Gac --- (In reply to Esther Melander from comment #20) > I tested again and the error message is improved. It would be nice if the > error message was retained in some way so that it can be referenced again > after the import in the Manage Stage records for the file. > > Hammat's file works and the items with bad codes are ignored and the other > items are brought in. > > My import file contains bibliographic records with multiple items for each. > The error message was triggered correctly for the one item with a bad branch > code. However, none of the items were brought in. Ok I will check with your file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #22 from Matthias Le Gac --- (In reply to Matthias Le Gac from comment #21) > Created attachment 164148 [details] [review] > Bug 21272: Improve warning message > > To test > > Before make sure backgroundjobs process is running > (/misc/workers/background_jobs_worker.pl --queue long_tasks) > > 1- Go to Cataloging -> Stage records for import > 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or > homelibraary set and is not present in your installation > 3- Click on Stage for import > 4- Click on View batch > --> There is no message for the missing branches > 5- Click on "Import this batch into the catalog" > --> The importation failed > 6- Apply the patch > 7- Run prove -t t/db_dependent/ImportBatch.t > 8- Click on "Manage imported batch" > --> There is a warning message showing the missing branches > --> There is a warning message showing the titles of the wrong items > 9- Click on "Import this batch into the catalog" again > --> The records are imported > --> The items with wrong branches are ignored > > > Current status: Failed QA Just make tideness -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Attachment #164143|0 |1 is obsolete|| --- Comment #21 from Matthias Le Gac --- Created attachment 164148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164148=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #20 from Esther Melander --- I tested again and the error message is improved. It would be nice if the error message was retained in some way so that it can be referenced again after the import in the Manage Stage records for the file. Hammat's file works and the items with bad codes are ignored and the other items are brought in. My import file contains bibliographic records with multiple items for each. The error message was triggered correctly for the one item with a bad branch code. However, none of the items were brought in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36169] Add guarantee to patron categories with type='Staff'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36169 Kathleen L. changed: What|Removed |Added CC||kleh...@faylib.org --- Comment #5 from Kathleen L. --- Comment to echo that this is being requested by our staff as well. Many have children and would like to be able to be able to see their kiddos' checkouts from their own accounts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #19 from Esther Melander --- Created attachment 164147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164147=edit Import file with an attached items and bad branch code on one Here is the import file I tested with. Only one item on one bibliographic record has a bad branch code. That bibliographic record is Working effectively with legacy code, the first item has a branch code of MPAL instead of MPL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 --- Comment #6 from Phil Ringnalda --- And because the names of mimetypes are names, and thus a Hard Problem, rfc9239 says text/javascript is correct and application/javascript is an obsolete alias, so the correct fix is to deflate text/javascript. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36462] Home button breadcrumb appears twice when viewing/editing the authority MARC subfield structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36462 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36462] Home button breadcrumb appears twice when viewing/editing the authority MARC subfield structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36462 ByWater Sandboxes changed: What|Removed |Added Attachment #164101|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 164144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164144=edit Bug 36462: remove extra Home breadcrumb item In the Staff interface, when viewing (or editing) the authority MARC subfield structure for a particular field, the Home button breadcrumb on the top left of the screen appears twice. This patch fixes that. Test plan: 1) Try to view (or edit) the authority MARC subfield structure for a particular field. Notice the 'Home' breadcrumb button/icon is appearing twice. 2) Apply this patch. 3) Refresh the page, the 'Home' breadcrumb icon should now appear only once. Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 --- Comment #5 from Phil Ringnalda --- Oh, heh. That's what = does, https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Service.pm#L56 serves it as 'js' rather than 'json', and although we deflate application/javascript, we don't serve that, https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/Output.pm#L250 maps 'js' to text/javascript. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36465] New: Clicking add guarantee should allow adding existing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36465 Bug ID: 36465 Summary: Clicking add guarantee should allow adding existing patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When clicking on add guarantee from a patron record, it opens a blank patron form to add a new patron. It would be nice to be able to have the option to either search for an existing patron or add a new patron as needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Matthias Le Gac --- I have to add tests for the two new methods I added in Import.pm but tell me if the warning is better ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #17 from Matthias Le Gac --- Created attachment 164143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164143=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 --- Comment #43 from Nick Clemens --- Created attachment 164142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164142=edit Bug 32707: Unit tests NB in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t, I had to modify four existing test by changing Local-number:123456 to Personal-name:donald -- since Local-number should never be auto truncated according to the submitted patch. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 --- Comment #42 from Nick Clemens --- Created attachment 164141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164141=edit Bug 32707: ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields) Koha with Zebra prevented auto truncation in some circumstances -- see the first return for ccl inside C4::Search:: buildQuery, before applying auto truncation, and setting $auto_truncation = 0 for some search fields. Koha with ElasticSearch applies auto truncation for all search fields, not paying attention to these special cases when it should not be done. This leads to various problems as described in bug 26508, 26608, etc. The solution would be to prevent auto truncation for certain search fields, above all – the identifiers. In addition, under no circumstances should a search field other than of text type be truncated (an attempt to truncate would generate an exception from ElasticSearch, e.g. number_format_exception for integer). Test plan = 0. Use the test data sample provided in the bug report. Comment 16 in the ticket. Scenario A (authority) -- 1. Enable Elasticsearch engine. 2. Have like 100+ bibliographic records and properly linked authority records. 3. Reindex ElasticSearch if needed. 4. Enable QueryAutoTruncate systempreference. 5. Find the authority record #1 and note the number of linked biblio records. 6. Show the detail of authority #1 and compare the number of linked biblio records. 7. If in the database there are authority records with ids =~ /^1/ (i.e. 10, 11, 12, ..., 100, 101, ...) linked to the biblio records you get two different numbers of linked records. 8. Also, as lists of linked biblio records (via link: Used in N record(s) from results view and detail view) you will get two different sets of biblio records. In particular, on the list generated from detail view (authorities/detail.pl?authid=1) you will get biblio records that are in fact not linked to the auth #1 (the list is generated with =an:1). 8.99. Skip to scenario B and come back here after finishing to not have to unapply the patches and restart services for nothing. 9. Apply this patch. 10. Counts and list of linked biblios should be ok. Scenario B (analytics) -- 1. Enable Elasticsearch engine. 2. Have three monographic bibliographic records with 001 = 1, 10, 100 (i.e. =~ /^1/). 3. Have an analytical record with 773 $w = 1 (in the test data set - biblio 896). 4. Enable QueryAutoTruncate and UseControlNumber systempreference. 6. Find the analytical record and click on the link generated from 773, i.e. (In: ... --> catalogue/search.pl?q=Control-number:1). You should see a list of 100+ records (001 = 1, 10, 100) instead of one (001 = 1). 7. From the biblio # 1 try to go to the analytice records (with Show analytics link) - you should get 60+ records with from different host records (773 $t) -- instead of one. 8. Apply this patch. Make sure that control-number and record-control-number are included in ESPreventAutoTruncate syspref. 9. Repeat steps 6 and 7. You should arrive at the right host record in p. 6 and at one analytical records when looking for analytical records in p. 7 (or more than one, but right, if you modified the test data set). Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 Nick Clemens changed: What|Removed |Added Attachment #163892|0 |1 is obsolete|| Attachment #163893|0 |1 is obsolete|| Attachment #163894|0 |1 is obsolete|| --- Comment #41 from Nick Clemens --- Created attachment 164140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164140=edit Bug 32707: Add 'ESPreventAutoTruncate' preference This patch adds a new 'ESPreventAutoTruncate' preference allowing to define Elasticsearch search fields that should not be autotruncated when 'QueryAutoTruncate' is active (e.g. barcode). Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36299] Highlighting of Logged-In Library Facets not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36299 Kelly McElligott changed: What|Removed |Added Version|master |23.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36299] Highlighting of Logged-In Library Facets not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36299 --- Comment #2 from Kelly McElligott --- I am in 23.11.01 - so maybe something has been fixed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36464] New: A guarantee can add a staff guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36464 Bug ID: 36464 Summary: A guarantee can add a staff guarantor Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Generally speaking Staff cannot be a guarantor. Bug 36169 asks to add the ability to allow staff to be a guarantor. Currently it is not possible to add a guarantee from a staff account. However, it is still possible to add a staff guarantor from a guarantee account. Either this should be disabled or a warning provided. To replicate: 1. Find a staff account to have ready. 2. Find another non-staff patron account - ensure the patron category can be a guarantee. 3. Edit the patron account. 4. Under the section for Patron Guarantor - Add guarantor. 5. Search for the staff account and select. 6. Save the patron record. 7. Pull up the staff account and see they are now a guarantor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18053] Allow to manually link items to serial issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18053 Dani Elder changed: What|Removed |Added CC||danielle.elder@law.utexas.e ||du --- Comment #1 from Dani Elder --- This would be helpful for migrated libraries too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34481] Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34481 Frédéric Demians changed: What|Removed |Added CC||f.demi...@tamil.fr --- Comment #2 from Frédéric Demians --- This line: my $marc_filter = Koha::Koha::Filter::MARC::EmbedSeeFromHeadings->new; should be: my $marc_filter = Koha::Filter::MARC::EmbedSeeFromHeadings->new; Otherwise, all good! Do I fix it directly while signing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Frédéric Demians changed: What|Removed |Added Attachment #164138|0 |1 is obsolete|| --- Comment #5 from Frédéric Demians --- Created attachment 164139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164139=edit Bug 36463: (follow-up) Adjust other occurence (intranet) Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 --- Comment #4 from Nick Clemens --- Created attachment 164138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164138=edit Bug 36463: (follow-up) Adjust other occurence (intranet) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24597] Add ability to add note on all payment/writeoff screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Frédéric Demians changed: What|Removed |Added CC||f.demi...@tamil.fr --- Comment #3 from Frédéric Demians --- In etc/koha-httpd.conf, they are two mod_deflate.c section. Your patch modify the 1st one, not the 2nd one. Isn't it necessary? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 --- Comment #4 from Phil Ringnalda --- Not sure why, but the initial framework load is served as text/javascript, so it's missing compression from that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Phil Ringnalda changed: What|Removed |Added Attachment #164128|0 |1 is obsolete|| --- Comment #2 from Phil Ringnalda --- Created attachment 164137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164137=edit Bug 36463: Compress application/json This patch simply adds application/json to the mod_deflate configuration To test: 1 - Open the netowrk tab in firefox 2 - Load http://localhost:8081/api/v1/libraries 3 - Not the transferred size, and note no 'Content-Encoding: gzip" header 4 - Apply patch, reset_all (or edit /etc/koha/apache-shared.conf) 5 - Reload 6 - Note smaller size, note gzip header Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35430] Add endpoints for managing stock rotation rota's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35430] Add endpoints for managing stock rotation rota's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #15 from Kyle M Hall --- Created attachment 164136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164136=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35430] Add endpoints for managing stock rotation rota's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #14 from Kyle M Hall --- Created attachment 164135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164135=edit Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35430] Add endpoints for managing stock rotation rota's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Kyle M Hall changed: What|Removed |Added Attachment #159418|0 |1 is obsolete|| Attachment #159419|0 |1 is obsolete|| Attachment #159420|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 164134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164134=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35430] Add endpoints for managing stock rotation rota's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #162 from Kyle M Hall --- Created attachment 164133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164133=edit Bug 23260: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #161 from Kyle M Hall --- Created attachment 164132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164132=edit Bug 23260: Add cronjob anonymize_last_borrowers.pl This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a new cron job anonymize_last_borrowers.pl To test: 1) apply this patch and the previous ones 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) set AnonymousPatron preference to a valid patron id 5) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 6) In mysql, update created_on of items_last_borrower and returndate of old_issues to two days earlier. 7) perl misc/cronjobs/anonymize_last_borrowers.pl CHECK => borrower number in items_last_borrower is not anonymized yet. 8) Repeat step 5 and 6 but instead of two days earlier, set the new entry in items_last_borrower to three days earlier. 9) set AnonymizeLastBorrower to 'Anonymize' and AnonymizeLastBorrowerDays to 2 days. 10) perl misc/cronjobs/anonymize_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 11) repeat step 8 12) set AnonymousPatron preference to 0 13) perl misc/cronjobs/anonymize_last_borrowers.pl SUCCESS => borrower number in items_last_borrower changed to null 14) prove t/db_dependent/Koha/Patrons.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #160 from Kyle M Hall --- Created attachment 164131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164131=edit Bug 23260: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #159 from Kyle M Hall --- Created attachment 164130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164130=edit Bug 23260: Add anonymize_last_borrowers method to Patrons.pm This patch adds a new routine to allow anonymizing the items_last_borrower table Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall changed: What|Removed |Added Attachment #159298|0 |1 is obsolete|| Attachment #159299|0 |1 is obsolete|| Attachment #159300|0 |1 is obsolete|| Attachment #159301|0 |1 is obsolete|| --- Comment #158 from Kyle M Hall --- Created attachment 164129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164129=edit Bug 23260: Database updates and new system preferences AnonymizeLastBorrower / AnonymizeLastBorrowerDays This patch alters the items_last_borrowers table to allow for NULL borrowers It also adds two new system preferences to allow controlling the anonymization of items_last_borrower data Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@gmail.com, ||julian.maur...@biblibre.com ||, m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 --- Comment #3 from Nick Clemens --- Filed bug 36463 which improves size of loading subsequent frameworks, however, the initial load is not compressed for some reason - I think because of the loading by requireJS? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35799 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35799] Loading svc/cataloguing/framework bottlenecks advanced cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35799 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36463 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens --- Trivial update - we aren't handling the error, so waiting will appear the same, but it may succeed now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 --- Comment #1 from Nick Clemens --- Created attachment 164128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164128=edit Bug 36463: Compress application/json This patch simply adds application/json to the mod_deflate configuration To test: 1 - Open the netowrk tab in firefox 2 - Load http://localhost:8081/api/v1/libraries 3 - Not the transferred size, and note no 'Content-Encoding: gzip" header 4 - Apply patch, reset_all (or edit /etc/koha/apache-shared.conf) 5 - Reload 6 - Note smaller size, note gzip header -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #31 from Kyle M Hall --- Created attachment 164127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164127=edit Bug 29825: (follow-up) Some style fixes and modal correction This patch makes a few coding style changes to the new JavaScript and updates the Bootstrap modal markup to be in line with current standards. The previous patches lacked a trigger for the preview modal, so I added that. Since the content of the modal uses spaces for formatting I added monospace formatting to the modal body. Signed-off-by: Phil Ringnalda Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Kyle M Hall changed: What|Removed |Added Attachment #159200|0 |1 is obsolete|| Attachment #159201|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 164126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164126=edit Bug 29825: Preview of authority record on edit mode as MARC formatted view This bug adds a new functionality on Edit mode of a new or existing authority. Add a new button 'MARC Preview' in order librarian have the ability to preview the record on MARC plain structure mode and have all fields and subfields that entered before save/update the record. To test: 1. Open or add an authority 2. The preview button isn't on toolbar 3. Apply the patch 4. Do step 1 5. The preview button exists 6. Do some changes or not to the authority record 7. Click to Preview MARC button and a modal window will appear with all fields indicators and subfields that filled in the form of cataloguing. Mentored by: Andreas Roussos Signed-off-by: Phil Ringnalda Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36463] New: We should compress our JSON responses (gzip deflate mod_deflate application/json)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36463 Bug ID: 36463 Summary: We should compress our JSON responses (gzip deflate mod_deflate application/json) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org We serve most types with gzip encoding, but not application/json -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens changed: What|Removed |Added Attachment #164099|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 164125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164125=edit Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36461] Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159 --- Comment #16 from Kyle M Hall --- Created attachment 164124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164124=edit Bug 36159: (QA follow-up) Tidy code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972
--- Comment #14 from Marcel de Rooy ---
Hi Emily,
Brave effort to try improve here :) This code is a mine field.
Some small observations:
my $patron = Koha::Patrons->find( $nextreservinfo );
Does not look good. We should just pass the borrowernumber to find. Cleaner
code.
L615 my ( $messages, $nextreservinfo ) =
GetOtherReserves($reserve->{itemnumber});
Confusing that we start here with another $messages while the former one came
from AddReturn.
General
I am just wondering how much sense it makes to still have GetOtherReserves.
Couldnt we just obsolete it here now? Note that the name is quite misleading.
IIUC it checks if the next reserve is waiting or transit.
Around the first call I am wondering what happens now if you came from the
$cancel_reserve branch of the if statement. After that you go to
GetOtherReserves. Which changed behavior and does nothing now. Did it formerly
handle the next reserve after the cancelled one?
If I am coming from the else branch, I know if the hold is waiting or transit
(look at diffBranchSend). So why still call GetOtherReserves to find out what
you already know?
Around L600 the second call. There is just one route to the call now. You
already know again diffBranchSend. Why call GetOtherReserves?
Appreciate some feedback. Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36384] 'Used saved' typo in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36384 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36384] 'Used saved' typo in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36384 Marcel de Rooy changed: What|Removed |Added Attachment #163622|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 164122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164122=edit Bug 36384: Fix 'Used saved' typo in guided reports Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36384] 'Used saved' typo in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36384 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447
Marcel de Rooy changed:
What|Removed |Added
Attachment #164083|0 |1
is obsolete||
--- Comment #3 from Marcel de Rooy ---
Created attachment 164121
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164121=edit
Bug 36447: Circ rules slow to load when many itemtypes and categories
It seems that we loop all categories and item types to build the circ
matrix. We should only loop over values that have actually been used
in circulation rules.
Test Plan:
1) Create 1000 itemtypes and category codes. You can use the following
script:
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new();
$builder->build( { source => 'Category' } ) for 0..1000;
$builder->build( { source => 'Itemtype' } ) for 0..1000;
2) Note the lengthy load time for smart-rules.pl
3) Apply this patch
4) Restart all the things!
5) Reload the page
6) Note the much faster load time!
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Nice catch. Start your stopwatch and look for the change :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Marcel de Rooy changed: What|Removed |Added Attachment #164032|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 164120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164120=edit Bug 36442: Fix typo in edifact list To test: 1) Create an edifact message 2) Go to the acquisition EDIFACT messages page and verify the basket link is broken 3) Apply patch 4) Verify the link now works Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36330] Fix typo: reseve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36330 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- diff --git a/Koha/Schema/Result/CourseItem.pm b/Koha/Schema/Result/CourseItem.pm index 53a62686e4..435c2db64e 100644 --- a/Koha/Schema/Result/CourseItem.pm +++ b/Koha/Schema/Result/CourseItem.pm @@ -152,7 +152,7 @@ a place to store the holdingbranch when item is on course reserve is_nullable: 1 size: 80 -new shelving location for the item to have while on reseve (optional) +new shelving location for the item to have while on reserve (optional) This is not allowed. You should provide a dbrev to update the tables for the adjusted comments in kohastructure. After that provide a DBIx schema update patch or leave it to the RM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35345] Pass custom SQL to rebuild_elasticsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35345 Thomas Klausner changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35345] Pass custom SQL to rebuild_elasticsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35345 --- Comment #11 from Thomas Klausner --- I've now cleaned up the patch to only include the actual changes. Not sure if I should now also change the status (and if yes, to what..) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35345] Pass custom SQL to rebuild_elasticsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35345 Thomas Klausner changed: What|Removed |Added Attachment #162015|0 |1 is obsolete|| --- Comment #10 from Thomas Klausner --- Created attachment 164118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164118=edit Bug 35345: Add --where option to rebuild_elasticsearch.pl Sometimes we need to only re-index a subset of our bibliographic data or authorities. Currently this is only possible by enumerating all id (-bn or -ai), which does not work well when indexing eg 100.000 items of a 2.000.000 DB. Re-indexing everything is also overkill. This patch adds an `--where` flag to misc/search_tools/rebuild_elasticsearch.pl which can take arbitrary SQL (that of course has to match the respective tables) and adds it as an additional param to the resultset to index To test, start koha-testing-docker with ElasticSearch enabled, for example via `ktd --es7 up Before applying the patch, rebuild_elasticsearch will index all data: Biblios: $ misc/search_tools/rebuild_elasticsearch.pl -b -v [12387] Checking state of biblios index [12387] Indexing biblios [12387] Committing final records... [12387] Total 435 records indexed (there might be a waring regarding a broken biblio, which can be ignored) Auth: $ misc/search_tools/rebuild_elasticsearch.pl -a -v [12546] Checking state of authorities index [12546] Indexing authorities [12546] 1000 records processed [12546] Committing final records... [12546] Total 1706 records indexed Now apply the patch Biblio, limit by range of biblioid: $ misc/search_tools/rebuild_elasticsearch.pl -b -v --where "biblionumber between 100 and 150" [12765] Checking state of biblios index [12765] Indexing biblios [12765] Committing final records... [12765] Total 50 records indexed Note that only 50 records where indexed (instead of the whole set of 435 records) Auth, limit by authtypecode: $ misc/search_tools/rebuild_elasticsearch.pl -a -v --where "authtypecode = 'GEOGR_NAME'" [12848] Checking state of authorities index [12848] Indexing authorities [12848] Committing final records... [12848] Total 142 records indexed Again, only 142 have been indexed. Sponsored-by: Steiermärkische Landesbibliothek Sponsored-by: HKS3 / koha-support.eu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36421] Better logging of 500 errors in V1/Auth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36421] Better logging of 500 errors in V1/Auth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421 Marcel de Rooy changed: What|Removed |Added Attachment #163995|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 164117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164117=edit Bug 36421: Make sure pre-controller errors are correctly logged If something explodes in Koha::REST::V1::Auth chances are that no logging will happen. This patch makes sure they are! To test: 1. Make sure you do NOT have 36420 on your tree 2. Make sure you are looking at the logs: $ ktd --shell k$ koha-plack --restart kohadev; tail -f /var/log/koha/kohadev/*.log 3. Use Postman or similar for hitting some known endpoint. Use the user's cardnumber instead of the userid. On a default KTD launch, the generated user's cardnumber is '42'. GET /patrons => FAIL: You get a 500 error (expected, fixed on 36420) but no useful logging found. 4. Apply this patch 5. Ctrl+c on the logs and re-run the command 6. Repeat 3 => SUCCESS: You get a 500, but you also get the exception information logged! 7. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy [OK] prove t/db_dependent/api/v1/items.t t/db_dependent/api/v1/unhandled_exceptions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36421] Better logging of 500 errors in V1/Auth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36421 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > So we still need to package our own. > > Mason, are you ok with that? We would need to remove the '-really' and > provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 No need to keep this in SO. Mason, please respond or update our packages accordingly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
