[Koha-bugs] [Bug 36469] Conflict between _header.scss and addbiblio.css tab style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||the staff interface search ||bar. In some places, such ||as when adding a new ||record, extra padding was ||added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36469] Conflict between _header.scss and addbiblio.css tab style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 David Nind changed: What|Removed |Added Attachment #164178|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 164232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164232=edit Bug 36469: Fix conflict between _header.scss and addbiblio.css tab style addbiblio.css adds padding to tab panes specific for that interface, and the header search form should not pick up that style. This patch adds some specificity to _header.scss to avoid unwanted padding. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - Go to Cataloging -> New record (using the basic MARC editor). - The style of the MARC edit form should look correct. - The header search form should look correct - Test other pages with tabs to confirm that there are no other unwanted side-effects, e.g. Circulation -> Check out; Advanced catalog search; Bibliographic detail page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36469] Conflict between _header.scss and addbiblio.css tab style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36469 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36484] Even with RabbitMQ enabled, we should should poll the database for update_elastic_index jobs at koha-es-indexer startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36484 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #2 from Alex Buckley --- I'm not sure if this is the best test plan, so please do let me know if you would like me to change it. Ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36484] Even with RabbitMQ enabled, we should should poll the database for update_elastic_index jobs at koha-es-indexer startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36484 --- Comment #1 from Alex Buckley --- Created attachment 164231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164231=edit Bug 36484: Fetch all outstanding (New) update_elastic_index background jobs upon starting koha-es-indexer Test plan: 1. Ensure your Koha instance is using Elasticsearch 2. Apply patches 3. sudo koha-es-indexer --stop 4. Add a new biblio record in your Koha instance 5. Query your database and ensure there is one outstanding update_elastic_index job in background_jobs: SELECT * FROM background_jobs WHERE type = 'update_elastic_index' AND status = 'new'; 6. Start services: sud service koha-common start 7. Repeat step 5 and observe the outstanding job is not returned by the query - that is because it has been processed. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30627] koha-run-backups delete the backup files after finished its job without caring days option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627 --- Comment #15 from Aleisha Amohia --- *** Bug 23943 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23943] koha-run-backups --days is misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23943 Aleisha Amohia changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||alei...@catalyst.net.nz --- Comment #1 from Aleisha Amohia --- *** This bug has been marked as a duplicate of bug 30627 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36484] Even with RabbitMQ enabled, we should should poll the database for update_elastic_index jobs at koha-es-indexer startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36484 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434 --- Comment #8 from Aleisha Amohia --- I understand the concerns. The issue for us is that we can't use OpacHiddenItems to exclude everything except our archives, because the discovery layer includes OpacHiddenItems in the harvest. The OPAC will be used to search opposite records from the discovery layer. This is a niche use case so if it is too risky to upstream then that's totally fine, we can maintain it as a customisation for this library. Please feel free to change bug status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36484] Even with RabbitMQ enabled, we should should poll the database for update_elastic_index jobs at koha-es-indexer startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36484 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36484] Even with RabbitMQ enabled, we should should poll the database for update_elastic_index jobs at koha-es-indexer startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36484 Alex Buckley changed: What|Removed |Added Summary|Even with RabbitMQ enabled, |Even with RabbitMQ enabled, |es_indexer_daemon should|we should should poll the |poll the database for |database for |update_elastic_index jobs |update_elastic_index jobs |at koha-es-indexer startup |at koha-es-indexer startup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36484] New: Even with RabbitMQ enabled, es_indexer_daemon should poll the database for update_elastic_index jobs at koha-es-indexer startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36484 Bug ID: 36484 Summary: Even with RabbitMQ enabled, es_indexer_daemon should poll the database for update_elastic_index jobs at koha-es-indexer startup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Bug 30654 adds a check of the background_jobs database table prior to worker standup, regardless of whether a Koha instance is using RabbitMQ or Database polling. However, the patches on bug 30654 do not process outstanding update_elastic_index background jobs. The es_indexer_daemon.pl worker script should process these outstanding jobs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36479] Z39.50 responder does not support element set / composition "B"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36479 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36385] HTML escaped via JavaScript should encode all entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36385 --- Comment #1 from David Cook --- (In reply to Kyle M Hall from comment #0) > In staff-global.js, we have a function escape_str. This function only > encodes a tiny subset of html characters. We should use > https://github.com/mathiasbynens/he to encode the full set of html entities. In theory, escape_str might work as a "HtmlAttributeEncode" method if it were to include double quotes, single quotes, ampersands, and angle brackets. But I think we're trying to use it in context where a full HTML entity encode is needed. Overall, I think we should be writing better Javascript, but adding layers of protection is useful I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36385] HTML escaped via JavaScript should encode all entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36385 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32465] koha-worker debian script missing 'queue' in help
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32465 --- Comment #9 from wajasu --- *** Bug 35092 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35092] [OMNIBUS] Remaining background job/worker issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092 wajasu changed: What|Removed |Added Resolution|--- |DUPLICATE CC||matted-34...@mypacks.net Status|NEW |RESOLVED --- Comment #26 from wajasu --- Cleaned up this old bug since it was resolved by bug 32465 *** This bug has been marked as a duplicate of bug 32465 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36312] Authorities Z39.50 missing Subject-heading 21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36312 David Cook changed: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36312] Authorities Z39.50 missing Subject-heading 21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36312 --- Comment #6 from David Cook --- (In reply to Nick Clemens from comment #5) > This works, just one question, why not use 'Subject-topical' as the 21? It's a good question. Subject-topical is 1079, and Subject-Heading/21 should include more than just topical subjects. But what should it include? Maybe we should be using "Heading". The "Library of Congress Subjects" and "Library of Congress Names" databases seem to index any 1XX heading as "Subject-Heading", since that's what a 6XX bib entry is. -- Then for the Koha Z30.50 authority search points, we could update/expand where we replace "Subject heading" with "Heading (any)" and add a "Subject (topical)". Should probably actually add search points for each of the different 1XX headings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35178] Add option to save item search as an SQL report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35178 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org --- Comment #3 from Angela Berrett --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 --- Comment #1 from Tomás Cohen Arazi --- I meant to say that when bug 33080 introduced this, we should've reviewed all controllers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33080] Add helpers that return result_set for further processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 [Bug 36483] Calling $object->to_api directly should be avoided -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Tomás Cohen Arazi changed: What|Removed |Added Depends on||33080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33080 [Bug 33080] Add helpers that return result_set for further processing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36483] New: Calling $object->to_api directly should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 Bug ID: 36483 Summary: Calling $object->to_api directly should be avoided Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: tomasco...@gmail.com Highlighted on bug 36482, calling $object->to_api directly on our API controllers makes several parameters ineffective. Notably, x-koha-embed. We should call instead: ```perl $c->objects->to_api( $object ) ``` A follow-up bug replacing all existing calls should've been filled but we somehow missed it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36482] Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 164230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164230=edit Bug 36482: Make embedding work for GET /libraries/:library_id Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36482] Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 164229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164229=edit Bug 36482: Allow embedding desks and cash_registers on libraries endpoints Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36482] Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36481] Add GET /libraries/:library_id/cash_registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 [Bug 36482] Make it possible to embed desks and cash_registers on /libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 [Bug 36482] Make it possible to embed desks and cash_registers on /libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36482] Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |ASSIGNED Depends on||36480, 36481 --- Comment #1 from Tomás Cohen Arazi --- Now that we have specs thanks to bug 36480 and bug 36481, we should add the option. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 [Bug 36480] Add GET /libraries/:library_id/desks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 [Bug 36481] Add GET /libraries/:library_id/cash_registers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36482] New: Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Bug ID: 36482 Summary: Make it possible to embed desks and cash_registers on /libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36481] Add GET /libraries/:library_id/cash_registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 164228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164228=edit Bug 36481: Add GET /libraries/:library_id/cash_registers This patch adds the mentioned route. For the task it: * Adds Koha::Cash::Register->to_api_mapping with trivial mappings * Adds a cash_register object definition on the API spec * Adds a controller to handle requests * Adds tests for the new endpoint To test: 1. Apply this patch 2. Run: $ ktd --shell k$ qa => SUCCESS: All green! Tests pass! 3. Play with Postman! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36237] Improve set-library UI after 34478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi changed: What|Removed |Added Blocks||36481 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36481 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 [Bug 36481] Add GET /libraries/:library_id/cash_registers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36481] Add GET /libraries/:library_id/cash_registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on||36237 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36237 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 [Bug 36237] Improve set-library UI after 34478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36481] Add GET /libraries/:library_id/cash_registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36237] Improve set-library UI after 34478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36481 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36481] Add GET /libraries/:library_id/cash_registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36237 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36481] New: Add GET /libraries/:library_id/cash_registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 Bug ID: 36481 Summary: Add GET /libraries/:library_id/cash_registers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: tomasco...@gmail.com I propose to add an endpoint for fetching a library's list of cash registers. Context is bug 36237. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36422] Triggered holds should not display information about transferring because the item is in a rotating collection.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422 cart...@slolibrary.org changed: What|Removed |Added CC||cart...@slolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36470] Generate CHECKOUT, CHECKIN and HOLD digest notices should be generated at once, not amended over time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36470 --- Comment #2 from Katrin Fischer --- I think we need to give some thought on what the best way to implement this would be, but it should not create problems with performance etc. as we would only write to the database less and it would be de-coupled from the transaction (checkin, checkout) itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 164227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164227=edit Bug 36480: Add GET /libraries/:library_id/desks This patch adds the mentioned endpoint. For it, it does: * Add Koha::Desk->to_api_mapping * Add desk.yaml with the correct data structure for desks * Add the route to the spec * Add tests Note: Lucas and I had doubts about the right return value for when the feature is disabled. I opted for returning 404 with a message telling the feature is disabled. This can be discussed. To test: 1. Apply this patches 2. Run: $ ktd k$ qa => SUCCESS: All green, all tests pass! 3. Play with this using Postman. 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 164226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164226=edit Bug 36480: Add Koha::Library->desks We add an accessor for the related desks. Tests are added. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Library.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36237] Improve set-library UI after 34478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36480 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36237 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] New: Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 Bug ID: 36480 Summary: Add GET /libraries/:library_id/desks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: tomasco...@gmail.com I propose to add an endpoint for fetching a library's list of desks. Context is bug 36237. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31451] Can the display order be applied incrementally for item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31451 Miranda Nero changed: What|Removed |Added CC||mn...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31451] Can the display order be applied incrementally for item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31451 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33538] Allow for independent shibboleth autocreate and sync mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Brendan Lawlor changed: What|Removed |Added CC||blaw...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36479] New: Z39.50 responder does not support element set / composition "B"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36479 Bug ID: 36479 Summary: Z39.50 responder does not support element set / composition "B" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The Z39.50 responder currently has a hard-coded expectation that the element set / composition provided by the client is either blank or "F". It would be handy if it also supported "B" (brief) for backwards compatibility, since the default Zebra configuration also supports "B" (as effective a synonym for "F" (full)). Doing this would avoid a compatibility issue when switching from zebrasrv as the Z39.50 server to the Z39.50 responder for clients that happen to set the element set to "B". In particular, we've seen at least one case where the EBSCO/EDS item availability checker was configured to request "B". The error message associated with this is returning error 239: Unsupported syntax/composition 1.2.840.10003.5.10/B Koha::Z3950Responder::Session::log_error /usr/share/koha/lib/Koha/Z3950Responder/Session.pm (341) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36369] Make APIClient be more useful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369 0xfun changed: What|Removed |Added CC||m...@paulderscheid.xyz --- Comment #10 from 0xfun --- I like it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36477] We should use JSDoc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36477 --- Comment #1 from Owen Leonard --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #15 from Katrin Fischer --- (In reply to Nick Clemens from comment #11) > (In reply to Marcel de Rooy from comment #6) > > Still confused though about another "psychological effect". If the field is > > prefilled, the user might be inclined to go to the next field that he should > > still fill. If it is blank but required, (s)he is forced to pay a bit more > > attention? > > Passing QA, but highlighting for RM - I think in this case defaulting to > today is more obvious for general purposes. > IMHO, you can use a bit of jQuery to clear the field since you have a unique > use case Hm. I think with OPACMandatoryHoldDates set to have the start date as mandatory. This is the standard behavior for required fields as it forces the user to make an active choice, otherwise the preference basically has no effect. A lot can be solved with JS, but I think we need consistent behavior as the default. And JS is not as reachable or easy to a lot of libraries as it is for some of us. Especially with the new date widget it can get tricky. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Tomás Cohen Arazi changed: What|Removed |Added Attachment #164092|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 164225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164225=edit Bug 36443: Add a fax field / column to the batch patron modification tool To test: 1. Create or modify an existing patron account so that they have a value in their fax number field. 2. Go to Tools > Batch patron modification 1. Add the patron card number, or borrower number into the modification tool and click on continue. There is no option for modifying fax numbers, nor are fax numbers visible in the modification table. 3. Apply the patch and restart_all 4. Repeat step 2 1. A column for ‘Fax’ is now visible after ‘Other phone’ 2. Test the ‘Fax’ field by clearing out the field with the checkbox. ‘Checking the box right next to the label will disable the entry and delete the values of that field on all selected patrons.’ 3. Test the ‘Fax’ field by updating the value with a new number 5. Sign off and have a wonderful day :) Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36478] New: add title field to documents OR allow file description with no upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36478 Bug ID: 36478 Summary: add title field to documents OR allow file description with no upload Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.dru...@gmail.com Reporter: billieanne.g...@frontier.edu CC: jonathan.dru...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, matt.blenkin...@ptfs-europe.com, pedro.amo...@ptfs-europe.com In the documents section, you might want to reference documents in a physical location that have not actually been uploaded. If no file is uploaded, there's no description for the document, so only the other fields show. It would be helpful to have a title or a document description even when there is no file being uploaded. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #24 from Tomás Cohen Arazi --- I like this. How about adding some trivial methods like: say_warning say_failure say_success say_info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35106] ILL - Add patron autocomplete to 'Edit request' Patron ID input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35106 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35106] ILL - Add patron autocomplete to 'Edit request' Patron ID input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35106 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #12 from Tomás Cohen Arazi --- Pedro, please rebase. The second patch seems harder to rebase so I leave it to you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34823] Do not show item group drop-down if there are no item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #7 from Emily Lamancusa --- (In reply to Lucas Gass from comment #6) > (In reply to Emily Lamancusa from comment #5) > > There's also an edge case when a record has item groups defined, but all of > > the item groups are empty. Could this fix be adjusted to cover that case > > too? Maybe by filtering the search itself to exclude empty item groups, and > > bumping it up in the code a bit? > > I must be missing something because I thought that is what this patch is > correcting. It corrects the usual case, where a record has no item groups at all. To replicate what I'm seeing: 1. Apply the patch 2. On the intranet, find a record with no item groups 3. Add one or more item groups to that record (Do not add any items to the item group(s)) 4. On the OPAC, go to that record and try to place a hold --> Note that there is an option to choose an item group with the only option being "Any item group" I can't think of a reason this state would exist except in error, so if this is not as easy to address as I'm imagining, then I don't think it needs to be a blocker. But if this case can be covered by making something like a three-line change as opposed to a one-line change, then I'd rather go with the more robust fix the first time around. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] Elasticsearch: publisher-location (pl) index should include 260a/264a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- I must admin, we have had it this way in our mappings internally for some time - been on the list to reconcile what we have against community version -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] Elasticsearch: publisher-location (pl) index should include 260a/264a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Nick Clemens changed: What|Removed |Added Attachment #162932|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 164224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164224=edit Bug 36269: ElasticSearch: publisher-location (pl) should use260a/264a Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. Test plan (for koha-testing-docker with ElasticSearch via `ktd --es7 up`) Verify the old/broken behaviour: * Go to Staff/Advanced Search * Select "Publisher Location" and enter "cau", start search * You will get some hits (~16), eg "Perl best practices / Damian Conway", which has 008 of "051222s2005 caua b 001 0 eng d" with "cau" on 15-17 * Edit this record (cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=5) * Inspect 260$a, which should containt "Sebastopol, CA :" * Go back to Advanced Search and search for "Publisher Location" = "Sebastopol" * No hits! Apply the patch! * exit ktd and stop it (ktd --es7 down; ktd --es7 stop) * start it again * Go to Staff / Administration / Search Engine Config (Elasticsearch) * Click on the Tab "Bibliographic records" and search/filter for "pl" * you should see 3 entries for "pl", with Mapping values of "008_/15-17", "260a" and "264a" * Go to Search, * Select "Publisher Location" and enter "cau", start search * same hits as befor * Search again, but for "Sebastopol" * Now you'll get 9 hits!! Bonus: Test 264a * Got to Admin / MARC bibl framework, select BKS -> MARC structure * search for tag "264", edit subfields * in tabs a, b, c: Check the "Editor" Checkbox (Visibility) * Save changes * find a book, eg again "Perl best practices" and edit it * find field 264 and enter "Test" into 264a, Save * Depending on your setup, you might have to manually re-index the book: * enter ktd: ktd --shell * reindex the one book (via --bn) or all (might also need a -d) /usr/share/koha/bin/search_tools/rebuild_elasticsearch.pl -v -b -d * Go again to Advanced Search, Publisher Location = "Test" * You should find the book If your NOT running ktd, you might be able to just edit the ElasticSearch Mappings to add / change the mapping for "pl" to point to "260a". One rather harsh way to do this (which I needed to do, because the ES Mappings UI did not work for me) is via this SQL: update search_marc_map set marc_field='260a' where marc_field='008_/15-17'; Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Caroline Cyr La Rose Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] Elasticsearch: publisher-location (pl) index should include 260a/264a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #9 from Nick Clemens --- Created attachment 164223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164223=edit Bug 35129: Return 400 if _per_page=0 passed This patch adds a safe guard for when consumers pass _per_page=0 to endpoints. This condition is checked for on a centralized place and avoid reaching the controller in such scenarios that would provoke a division by zero exception. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/pagination.t => FAIL: We expect a 400, but get a 500 instead 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No more explosions for this! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Nick Clemens changed: What|Removed |Added Attachment #163637|0 |1 is obsolete|| Attachment #163638|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 164222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164222=edit Bug 35129: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Laura Escamilla Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36477] New: We should use JSDoc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36477 Bug ID: 36477 Summary: We should use JSDoc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.dru...@gmail.com Reporter: tomasco...@gmail.com CC: jonathan.dru...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, matt.blenkin...@ptfs-europe.com, pedro.amo...@ptfs-europe.com We need to add documentation to our JS codebase. We did some in some of our .js files, but the Vue classes should follow something like this: https://jsdoc.app/tags-param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #14 from Nick Clemens --- This will also need rebased on 36341 - but it broke the date population when I tried -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Attachment #162126|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 164221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164221=edit Bug 35977: (follow-up) Perltidy whitespace fixes Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Attachment #162125|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 164220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164220=edit Bug 35977: Set holddatefrom default to today This patch sets the holddatefrom date to today by default on the opac. Signed-off-by: Barbara Johnson Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Attachment #162126|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Attachment #162125|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Attachment #164217|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36341] "Hold starts on date" should be limited to future dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36341 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Trivial fix, PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36341] "Hold starts on date" should be limited to future dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36341 --- Comment #3 from Nick Clemens --- Created attachment 164219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164219=edit Bug 36341: (QA follow-up) Use future inclusive on staff side too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36341] "Hold starts on date" should be limited to future dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36341 Nick Clemens changed: What|Removed |Added Attachment #163309|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 164218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164218=edit Bug 36341: Add futureinclusive to future holds This patch adds the flatpickr-futureinclusive data to the input field for "Hold starts on date" in the OPAC. We also add 'flatpickr-future' data to the input field for expiration date as it also doesn't make sense to allow this to be a past data either. Test plan 1) Attempt to place a hold on an item from the OPAC 2) Expand the 'Show more options' dropdown 3) Note that without the patch 'Hold not needed after' allows setting to a date in the past. 4) Enable `AllowHoldDateInFuture` and `OPACAllowHoldDateInFuture` system preferences 5) The 'Hold starts on date' option should now appear if you refresh your hold placing page in the OPAC. 6) Note that the above input also allows setting a past date 7) Apply patch 8) Neith input should allow past dates now. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36341] "Hold starts on date" should be limited to future dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36341 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- (In reply to Marcel de Rooy from comment #6) > Still confused though about another "psychological effect". If the field is > prefilled, the user might be inclined to go to the next field that he should > still fill. If it is blank but required, (s)he is forced to pay a bit more > attention? Passing QA, but highlighting for RM - I think in this case defaulting to today is more obvious for general purposes. IMHO, you can use a bit of jQuery to clear the field since you have a unique use case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Attachment #162125|0 |1 is obsolete|| Attachment #162126|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 164217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164217=edit Bug 35977: (follow-up) Perltidy whitespace fixes Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in Hold starts on date on opac-reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36452] Patron message does not respect multiple line display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36452 Nick Clemens changed: What|Removed |Added Attachment #164049|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 164216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164216=edit Bug 36452: correct display of patron message To test: 1. Before applying the patch: 2. In the staff interface, navigate to a patron 3. Add a new staff message that contains multiple lines (e.g. using enter for the next line) 4. Save the message and check the display. It will be a single line. 5. Apply the patch and navigate back to the patron 6. The message should now be displayed as multiple lines. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36452] Patron message does not respect multiple line display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36452 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Nick Clemens changed: What|Removed |Added Attachment #160725|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 164215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164215=edit Bug 35728: Add ability to NOT redirect to result when search returns only one record This enhancement adds a new system preference RedirectToSoleResult. By default it is enabled, which matches current behaviour - to redirect to the detail page if it is the only search result. To test: 1) Apply the patch, install database updates, restart services. 2) Go to Koha Administration -> Global system preferences. The RedirectToSoleResult system preference is in the Searching tab. Confirm it is enabled (set to "Redirect") by default. 3) Conduct a catalogue search on the staff interface that you know will return a single result. Confirm you are redirected to the detail page. 4) Do the same search on the OPAC. Confirm you are redirected to the detail page. 5) Go back to the system preferences and disable the RedirectToSoleResult system preference by setting it to "Don't redirect" 6) Do the searches again on the staff interface and OPAC. Confirm you are NOT redirected to the detail page, and the search results page shows as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Nick Clemens changed: What|Removed |Added Attachment #160724|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 164214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164214=edit Bug 35728: Add RedirectToSoleResult system preference Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35728] Add option to NOT redirect to result when search returns only one record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35728 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36470] Generate CHECKOUT, CHECKIN and HOLD digest notices should be generated at once, not amended over time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36470 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #1 from Christopher Brannon --- Not completely knowing how all this work, what I am seeing Katrin say makes sense. It would be great if the cron job gathered information and checked validity at the time of delivery. This might prove problematic for systems that have more frequent delivery times, but I don't know. However, this might resolve issues where holds have been picked up, or patron information has changed (name, other patron data, addresses/phone numbers/sms numbers. This might also make a way to address issues with resending, where the delivery format was changed. The resend should go out as whatever the current delivery method is. This new workflow might aid in making that possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36031] Get rid of (outdated) misc/bin/set-selinux-labels.sh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36031 Nick Clemens changed: What|Removed |Added Attachment #161877|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 164213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164213=edit Bug 36031: Remove obsoleted script Since it is not up to date, we should remove it. The folder structure changed and this would need digging into SELinux to update that side as well. In other words, remove this until someone finds time do it. But dont let it here in its current outdated state. No test plan here. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36031] Get rid of (outdated) misc/bin/set-selinux-labels.sh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36031 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36046] Choose staff interface homepage default action
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36046 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu --- Comment #1 from Katrin Fischer --- It would probably be possibly to solve this with a little jQuery. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 --- Comment #15 from Katrin Fischer --- (In reply to Pedro Amorim from comment #14) > Thanks Joubu, we fixed it. I think what Joubu meant was why we didn't fix the original database update too - have to admit I don't know. It looks like another problem popped up on bug 36424 now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34520] Database update 22.06.00.078 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Katrin Fischer changed: What|Removed |Added Blocks||36424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 [Bug 36424] Database update 22.06.00.078 breaks update process (II) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36424] Database update 22.06.00.078 breaks update process (II)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36424 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal Keywords||RM_priority Depends on||34520 --- Comment #1 from Katrin Fischer --- Do we have an idea what's going wrong here? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 [Bug 34520] Database update 22.06.00.078 breaks update process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432 Nick Clemens changed: What|Removed |Added Attachment #164056|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 164210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164210=edit Bug 36432: Remove circular dependency from Koha::Object Koha::Object depends on Koha::DateUtils, which depends on C4::Context, which depends on Koha::Config::SysPref, which depends on... Koha::Object Apart from the circular dependency, the dependency on C4::Context alone is problematic as it loads a bunch of modules that are not needed at all in Koha::Object (YAML::XS and ZOOM for instance). As Koha::Object is used as a base for a lot of modules, we should take care to only load the minimum required. This patch moves some date parsing code to specific modules: - Koha::DateTime::Format::RFC3339 - Koha::DateTime::Format::SQL and it uses them in Koha::Object and Koha::DateUtils where it is possible. Test plan: 1. Do not apply the patch yet and run the following command: `perl -cw Koha/Object.pm` It should print several warnings about redefined subroutines, meaning there is a circular dependency. 2. Apply the patch 3. Run `perl -cw Koha/Object.pm`. It should only say: "Koha/Object.pm syntax OK" 4. Run the following command: prove \ t/DateUtils.t \ t/Koha/DateTime/Format/RFC3339.t \ t/db_dependent/Koha/Object.t Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36432] Remove circular dependency from Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36432 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36470] Generate CHECKOUT, CHECKIN and HOLD digest notices should be generated at once, not amended over time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36470 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35972] Add a 'Research tables' feature, that builds upon Course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #6 from Andrew Fuerste-Henry --- (In reply to Katrin Fischer from comment #5) > * Terminology: Is there maybe a more general term we could use? Libraries > might implement this as special shelves, carts, tables, desks, carrels, ... > I think right now would be the best moment to give this some thought. I agree this could see a lot of varied use if the naming/labeling of it all is sufficiently broad or customizable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
