[Koha-bugs] [Bug 34488] Cannot import default framework

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34488

--- Comment #2 from Viliam  ---
same in 23.11.03, 23.11.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36586] Self-checkouts will get CSRF errors if left inactive for 8 hours

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36586

--- Comment #1 from David Cook  ---
I think the most obvious (but not necessarily the best) solution is to have a
timer that refreshes the main SCO page at certain intervals. 

--

(Note that this same problem will probably arise with Vue.js driven pages.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36586] New: Self-checkouts will get CSRF errors if left inactive for 8 hours

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36586

Bug ID: 36586
   Summary: Self-checkouts will get CSRF errors if left inactive
for 8 hours
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Currently, the CSRF token is only good for 8 hours. This means that a
self-checkout terminal left inactive for 8 hours (e.g. overnight, over a
holiday closure, etc) will create a wrong CSRF token error on the first
activity attempt in the morning.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30962] Add POST endpoint for validating a user password

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962

David Cook  changed:

   What|Removed |Added

 Blocks||36575

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897

--- Comment #35 from David Cook  ---
(In reply to David Cook from comment #34)
> Also, one final concern:
> 
> I might just test that quickly...

So the Starman worker launches a subprocess like the following:

sh -c /kohadevbox/koha/installer/data/mysql/updatedatabase.pl >>
/var/log/koha/kohadev/updatedatabase_2024-04-12T02:34:37_19.064_23.1200017.log
2>> /var/log/koha/kohadev/updatedatabase-
error_2024-04-12T02:34:37_19.064_23.1200017.log

So it's this shell process that gets HUPed, and then init takes over as the
parent process:

kohadev-koha@kohadevbox:koha(bug_30897_1)$ ps -fww -p 15743
UIDPID  PPID  C STIME TTY  TIME CMD
kohadev+ 15743 1 13 02:32 ?00:00:01 /usr/bin/perl
/kohadevbox/koha/installer/data/mysql/updatedatabase.pl

--

I think this is another unintended consequence, but... it probably won't cause
any harm overall, and it would only affect people upgrading from <= 19.05 to >=
24.05.

(Note that the upgrade crashed for me at 19.0600011 but that was for unrelated
reasons.)

--

Note that this is one of the reasons why I think the Starman restart should've
been in a separate function to InstallPlugins(). While the psgi detection
helped, it's not quite enough. In this case, the environmental variables are
inherited from the web process by the shell process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162681|0   |1
is obsolete||

--- Comment #59 from Aleisha Amohia  ---
Created attachment 164787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164787=edit
Bug 33260: Move patron search into main body of page

This patch moves the patron search in the Notices management page to the main
body of the page so that the patron search result table displays more nicely.

This is a better place for it anyway, as using this search takes the user to a
different page. In the sidebar, where it was previously, it implied it would
have the same results display as the search filters.

Signed-off-by: Laura Escamilla 
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162680|0   |1
is obsolete||

--- Comment #58 from Aleisha Amohia  ---
Created attachment 164786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164786=edit
Bug 33260: Add Notice management tool

This enhancement makes it easy for the library to view sent notices and filter
by various search parameters.

You can also print sent notices, individually or in a batch.

This enhancement uses a new system preference NoticesManagement and a new
view_generated_notices user permission.

This enhancement has been built on top of Bug 33478 so print format settings
are taken into account when printing notices.

To test:
1. Apply patches, install database updates, restart services
2. Make sure your logged in user has the view_generated_notices permission
checked
3. Enable the NoticesManagement system preference
4. Generate a few notices. There are a few ways to do this including:
- place holds, check in items and confirm the holds
- place recalls, check in items and confirm the recalls
5. Go to Tools -> Notices management
6. There are two search functions on the left navigation. Confirm the patron
search box works by searching for one of the patrons you generated a notice
for, you should be redirected to their Notice history.
7. Go back to Notices management. Use the set of search filters to search for
notices. Leaving the search filters empty will return all notices generated.
Confirm the filters work as expected by using different combinations of
filters.
8. Conduct a search so your notices show in a table. Confirm the information
fetched about the notices is correct.
9. Click on a notice title. Confirm the contents of the notice show in a pop-up
box.
10. Click one of the Print buttons next to a notice. Confirm the notice is
opened to be printed.
11. Redo your notices search. Confirm the status of the notice you just printed
has now been updated to 'sent'.
12. Use the 'Select all' and 'Clear all' buttons to select or clear the
checkboxes.
13. Select a few checkboxes and click the button at the bottom of the table to
'Print selected notices'. Confirm the notices have been collated into one
document, separated by horizontal lines, and prints successfully. The statuses
for the notices should all be updated to 'sent'.
14. Confirm the Notices management page is not visible without the
view_generated_notices permission
15. Confirm the Notices management page is not visible without the
NoticesManagement system preference being enabled.
16. Go to a patron's Notices history. If the view_generated_notices user
permission is checked for your logged in patron, you should see a Print button
for each notice. Confirm this works. Confirm this button doesn't show if your
logged in patron does not have the view_generated_notices user permission. It
does not require the NoticesManagement system preference.

17. Go to Tools -> Notices & slips
18. Edit the format settings of a few different notices i.e. HOLD and WELCOME
19. Generate these notices by filling a hold for a patron and sending a welcome
email
20. Search for all notices under Tools -> Notices management
21. Select all notices and print selected notices
22. Confirm the notices different format settings are taken into account in the
printed PDF

Sponsored-by: Colorado Library Consortium
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162679|0   |1
is obsolete||

--- Comment #57 from Aleisha Amohia  ---
Created attachment 164785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164785=edit
Bug 33260: Add a patron getter method to Koha::Notice::Message

Signed-off-by: Laura Escamilla 
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162678|0   |1
is obsolete||

--- Comment #56 from Aleisha Amohia  ---
Created attachment 164784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164784=edit
Bug 33260: Add NoticesManagement system preference

Signed-off-by: Laura Escamilla 
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #162677|0   |1
is obsolete||

--- Comment #55 from Aleisha Amohia  ---
Created attachment 164783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164783=edit
Bug 33260: Add view_generated_notices user permission

Signed-off-by: Laura Escamilla 
Signed-off-by: kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34913] Upgrade DataTables from 1.10.18 to 1.13.6

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913

--- Comment #71 from wainuiwitikap...@catalyst.net.nz ---
(In reply to Lucas Gass from comment #70)
> Backported to 23.05.x for upcoming 23.05.10

Hey, I have found an issue which I believe comes from: "Bug 34913: Upgrade
staff interface DataTables from 1.10.18 to 1.13.6"

When adding orders from a marc file to a basket, the text in the form is
showing up as white.

Applying the following to intranetusercss temporarily fixes the issue:

table.dataTable tbody tr.selected > * {
  color: black;
}

Is it possible for this issue to please be fixed?

Thanks,

Wainui

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897

--- Comment #34 from David Cook  ---
Also, one final concern:

For DB version 19.06.00.006, we run "Koha::Plugins->new({ enable_plugins => 1
})->InstallPlugins;" in installer/data/mysql/updatedatabase.pl

In theory, if the database were being upgraded via the web installer, this
would cause the database upgrade to crash I think? 

I might just test that quickly...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897

--- Comment #33 from David Cook  ---
Comment on attachment 164737
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164737
Bug 30897: Add option to disable automated restart

Review of attachment 164737:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=30897=164737)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt
@@ +45,5 @@
>  
>  [% END %]
> +[% IF ( !plugins_restart ) %]
> +
> +You're system is not configured to automatically 
> refresh on plugin upload, you may need to ask your administrator to complete 
> the plugin installation.

I notice the patch is spelled "You're system" but the patch in master is
spelled correctly as "Your system".

We've still got a comma splice here, so that comma should be replaced with
either a full stop or a semicolon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to csv doesn't have the total

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585

Michael Hafen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Michael Hafen  ---
[ The test plan is in the patch, but I forgot to copy it here. ]

Try the following with and without a group by, specifically item type.

1. Generate the report with output to screen with a group by.
2. Observe that the patron name is repeated for each column group.
3. Observe that there is no total column.
4. Generate the report with output to csv.
5. Observe that the total check outs is not in the csv.
6. Apply patch. restart Koha.
7. Generate the report to csv again.
8. Observe that the total checkouts is in the csv.
9. Generate the report to screen again.
10. Observe that there is a total column and the patron name is only in one
column.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36585] Patrons with the most checkouts Report when outputting to csv doesn't have the total

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585

--- Comment #1 from Michael Hafen  ---
Created attachment 164782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164782=edit
Improve bor_issues_top report

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36585] New: Patrons with the most checkouts Report when outputting to csv doesn't have the total

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36585

Bug ID: 36585
   Summary: Patrons with the most checkouts Report when outputting
to csv doesn't have the total
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: michael.ha...@washk12.org
QA Contact: testo...@bugs.koha-community.org

I will submit a patch which:
Adds the total to csv output.
Changes screen output to only show the patrons name once, instead of with each
group by column.
Also show total checkout when output to screen.
Changes item type group by from biblioitems.itemtype to items.itype.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35305] Add XSLT for authority details page in staff interface

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35305

--- Comment #6 from Matthias Le Gac  ---
(In reply to Fridolin Somers from comment #5)
> (In reply to Matthias Le Gac from comment #4)
> > The display match with the XSLT for type GEOGR_NAME but for the other types
> > the default display isn't use, it's the XSLT display who is using.
> 
> Hi, could you explain more please ?
> 
> Using a XSLT file only for GEOGR_NAME is just an example, you may create a
> file per authority type or for UNIMARC use the sample file.

What I meant was that when I go to the details of a GEOGR_NAME authority it
looks just like what I specified in the XSL but it also has an impact on the
details page of a PERSO_NAME authority and if I've understood the test plan
correctly it shouldn't.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36574] Canceled/invalid ISBN not indexed by ES for MARC 21

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574

--- Comment #3 from Roman Dolny  ---
(In reply to Roman Dolny from comment #2)
> Created attachment 164778 [details] [review]
> Revert "Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21"
> 
> This reverts commit 019e80dbbeaccfae732c59c5590da6e5a29f329b.

Janusz, sorry for canceling the commit. My mistake while trying to sign the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36527] Patron category or item type not changing when editing another circulation rule

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527

Phan Tung Bui  changed:

   What|Removed |Added

 Attachment #164779|0   |1
is obsolete||

--- Comment #2 from Phan Tung Bui  ---
Created attachment 164781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164781=edit
Bug 36527: Patron category or item type not changing when editing another
circulation rule

Plan test :
1. Go to Administration > Circulation and fine rules
2. Add a couple of rules with various patron category/item type combinations
3. Click on "Edit" next to one of the rules
   --> The line should become highlighted in yellow and the values should be
copied in the very last row
4. Click on "Edit" next to another rule
5. Click OK in the browser dialog box to confirm you want to edit another rule
   --> Depending on the rules, the values for the patron category and/or item
type might not change in the editing row
6. Repeat steps 4 and 5
   --> The patron category and item type do not always change
7. Apply the batch
8. Redo step from 3 to 6
9. Observe that category and item type change accordingly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36574] Canceled/invalid ISBN not indexed by ES for MARC 21

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574

Janusz Kaczmarek  changed:

   What|Removed |Added

 Attachment #164778|0   |1
is obsolete||
 Attachment #164778|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36053] Replacement prices not populating when supplied from MarcItemFieldsToOrder

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053

Sara Brown  changed:

   What|Removed |Added

 CC||sbr...@bywatersolutions.com
   Keywords||rel_23_05_candidate,
   ||rel_23_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36578] Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578

Janusz Kaczmarek  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 QA Contact|janus...@gmail.com  |
   Assignee|koha-b...@lists.koha-commun |janus...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36578] Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578

Janusz Kaczmarek  changed:

   What|Removed |Added

 Attachment #164757|0   |1
is obsolete||

--- Comment #3 from Janusz Kaczmarek  ---
Created attachment 164780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164780=edit
Bug 36578: Elasticsearch: publisher-location (pl) index should include field
752 (for old prints) and also support UNIMARC

Extension to bug 36269: 1) when cataloguing old prints, the standardized form
of
the place of publication is given in the field 752 and as such should also be
indexed.

2) Also, normal UNIMARC fields for publication place should be indexed (210a,
214a).

Test plan
=

Scenario A (MARC 21, field 752)
---
0. Have an installation with Elasticsearch and MARC 21 configuration.
1. Activate subfields 752 $a, $d in the default framework (Visibility: Editor).
2. Edit an existing record with this framework, putting some rare words in the
   752 $a and $d subfields.
3. Try to make a search with tis words (general keyword or by publication
place,
   i.e. pl:).
4. You hsold get no results.
5. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -b kohadev
6. Repeat p. 3. You should get your edited record.

Scenario B (UNIMARC)

0. Have an installation with Elasticsearch and UNIMARC configuration.
1. Try to search for a publication place, either with pl: directly in the
   search window, or in Advanced search, with Publisher location.
   With ktd UNIMARC test date you can search for 'Ste Geneviève Cedex'.
2. You should get no results.
3. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -b kohadev
4. Repeat p. 1. You should get some results (with ktd test data set and
   Ste Geneviève Cedex - record #1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7132] Check for duplicates when creating a new record in acquisitions

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7132

Sara Brown  changed:

   What|Removed |Added

 CC||sbr...@bywatersolutions.com

--- Comment #1 from Sara Brown  ---
This is still an issue as of 23.05. A fix would save lots of de-duplication
time for libraries who manually enter orders into acquisitions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506

Emily Lamancusa  changed:

   What|Removed |Added

 Blocks||36581


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581
[Bug 36581] Checkouts table on patron account won't load if any of the items
have item notes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Emily Lamancusa  changed:

   What|Removed |Added

 Depends on||35506

--- Comment #7 from Emily Lamancusa  ---
(In reply to Emily Lamancusa from comment #6)
> (In reply to Nick Clemens from comment #5)
> > I suspect this is from the CSRF, but we should test this in older versions
> > or uncover the fault
> 
> I think it's bug 35506. I'll test and confirm.

Confirmed - I'll add it a dependency.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
[Bug 35506] selenium/regressions.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36527] Patron category or item type not changing when editing another circulation rule

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527

--- Comment #1 from Phan Tung Bui  ---
Created attachment 164779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164779=edit
Bug 36527: Patron category or item type not changing when editing another
circulation rule

Plan test :
1. Go to Administration > Circulation and fine rules
2. Add a couple of rules with various patron category/item type combinations
3. Click on "Edit" next to one of the rules
   --> The line should become highlighted in yellow and the values should be
copied in the very last row
4. Click on "Edit" next to another rule
5. Click OK in the browser dialog box to confirm you want to edit another rule
   --> Depending on the rules, the values for the patron category and/or item
type might not change in the editing row
6. Repeat steps 4 and 5
   --> The patron category and item type do not always change
7. Apply the batch
8. Redo step from 3 to 6
9. Observe that category and item type change accordingly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36527] Patron category or item type not changing when editing another circulation rule

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527

Phan Tung Bui  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #197 from Matthias Le Gac  ---
I don't understand your problem because when I run the test plan, everything
works and I don't get any errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

Joe Sikowitz  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36574] Canceled/invalid ISBN not indexed by ES for MARC 21

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574

--- Comment #2 from Roman Dolny  ---
Created attachment 164778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164778=edit
Revert "Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21"

This reverts commit 019e80dbbeaccfae732c59c5590da6e5a29f329b.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

Eliana  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Eliana  ---
I test checked in a non-checked out item and a checked out item and both times
the page's title stayed static. Mission accomplished!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36500] Add author column to item search results

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36500

Laura Escamilla  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

Joe Sikowitz  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36584] Add fields 520, 561, and 563 (MARC 21) to ES note search field

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36584

Janusz Kaczmarek  changed:

   What|Removed |Added

 QA Contact||janus...@gmail.com
 CC||pedro.amo...@ptfs-europe.co
   ||m
Summary|add fields 520, 561, and|Add fields 520, 561, and
   |563 (MARC 21) to ES note|563 (MARC 21) to ES note
   |search field|search field

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

Joe Sikowitz  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36583] MEMBERSHIP_RENEWED message for manual renewals

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36583

Gene Miller  changed:

   What|Removed |Added

 CC||ge...@takomaparkmd.gov

--- Comment #1 from Gene Miller  ---
We'd love a manual trigger for Membership_Renewed messages. All of our
membership renewals are done manually, largely because we have a fairly
transient population whose info changes frequently. Manual renewal gives us the
opportunity to review the patron record--especially the contact info--and
update it as needed.

The manually-triggered notice would serve as a useful confirmation of the
membership renewal itself, plus providing a useful and almost immediate check
that any updates to the patron's email address have been done correctly.

Gene Miller
Library Associate
Takoma Park (MD) Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36584] add fields 520, 561, and 563 (MARC 21) to ES note search field

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36584

--- Comment #1 from Janusz Kaczmarek  ---
Created attachment 164777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164777=edit
Bug 36584: Add fields 520, 561, and 563 (MARC 21) to ES note search field

With Zebra, the general keyword search covered the entire record content,
even if the field was not explicitly indexed with a Zebra index (the Any
index).
With Elasticsearch only the content of the fields explicitly indexed
can be found with general keyword search.  This is OK, to some extent, but with
the current configuration it hides the content fo some important notes from the
searches, and librarians complained about that: 520 - Summary, etc.,
561 - Ownership and Custodial History, 563 - Binding Information.

This patch adds the content of 520, 561, and 563 fields to the 'note'
search field.

Test plan
=
1. Have an installation with Elasticsearch.
2. Add some information to the 520, 561, and/or 563 fields (561 is
   hidden in the default framework--one should enable it to be able to use
   the 561 field).  Save teh record.
3. Try to find the record with the general keyword search, with the words
   you used.  If they were specific enough, you will get no results.
4. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -b kohadev
5. Confirm that now you are able to find the record with the information
   you entered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36584] add fields 520, 561, and 563 (MARC 21) to ES note search field

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36584

Janusz Kaczmarek  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36584] New: add fields 520, 561, and 563 (MARC 21) to ES note search field

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36584

Bug ID: 36584
   Summary: add fields 520, 561, and 563 (MARC 21) to ES note
search field
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: janus...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

Joe Sikowitz  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688

--- Comment #3 from Joe Sikowitz  ---
Created attachment 164776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164776=edit
Patch that keeps check in page title static

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29214] Lost item checked in shows "Lost item fee refund" instead of "Lost item fee removed"

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29214

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #11 from Owen Leonard  ---
(In reply to Brendan Lawlor from comment #10)
> (In reply to Owen Leonard from comment #9)
> > Why trigger change() after the on("change") event?
> so change() triggers the on change event when the page first loads

Ah, that makes sense. IMO you don't need to redo the patch again to change the
number of updated lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22281] Keydown event properties (keyCode and which) are both deprecated

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22281

--- Comment #4 from Owen Leonard  ---
I assumed that if we were going to address deprecated key events we would do so
in one place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36583] New: MEMBERSHIP_RENEWED message for manual renewals

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36583

Bug ID: 36583
   Summary: MEMBERSHIP_RENEWED message for manual renewals
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sbr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Libraries who require in-person patron account renewals (so that they can
confirm contact information etc.) may also want to send a record of the renewal
to their patrons, so it would be nice if the new MEMBERSHIP_RENEWED notice
coming with bug 28688 could be sent for manual patron account renewals, not
just for automatic account renewals via the membership_expiry.pl cron.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

--- Comment #10 from Brendan Lawlor  ---
(In reply to Owen Leonard from comment #9)
> Why trigger change() after the on("change") event?

The javascript currently has a bit of logic that is repeated twice, because it
has to run once when the page loads and then again whenever the library select
is changed. I wanted to make it DRY, so change() triggers the on change event
when the page first loads. Maybe it would be more readable if it was instead
written as a function that gets called twice?

I wrote it this way so that when I was testing I only had to edit the logic in
one place.

Maybe I should submit another patch that just updates the minimal number of
lines that need to be changed? Instead of changing the whole file so that the
change is easier to see. It's mostly just adding a conditional to set the
current desk if it needs to be set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22281] Keydown event properties (keyCode and which) are both deprecated

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22281

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #3 from Emily Lamancusa  ---
I don't think this is a duplicate of 36580, exactly, though they're closely
related. This bug was about replacing the deprecated keypress event with a
keydown event(?) instead.

The instance that prompted me to file 36580 already uses keydown rather than
keypress (I think), but uses deprecated methods of identifying which key.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36580] Keydown event properties (keyCode and which) are both deprecated

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36580

Owen Leonard  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #1 from Owen Leonard  ---
*** Bug 22281 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22281] Keydown event properties (keyCode and which) are both deprecated

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22281

Owen Leonard  changed:

   What|Removed |Added

Summary|Does new Firefox update |Keydown event properties
   |break some shortcut keys?   |(keyCode and which) are
   |(keypress deprecated)   |both deprecated
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 36580 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Kris  changed:

   What|Removed |Added

 CC||kbec...@jcls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

--- Comment #9 from Owen Leonard  ---
Why trigger change() after the on("change") event?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

--- Comment #6 from Emily Lamancusa  ---
(In reply to Nick Clemens from comment #5)
> I suspect this is from the CSRF, but we should test this in older versions
> or uncover the fault

I think it's bug 35506. I'll test and confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27730] Innocent changes to framework silently delete bibliographic data

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36483] Calling $object->to_api directly should be avoided

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483

--- Comment #11 from Martin Renvoize  ---
It's the redaction stuff. Though talking to Tomas at hackfest I think we both
agreed it doesn't entirely make sense that one could edit, add a user with
fields that aren't accessible to them.. but I reckon that's a different bug..
I'll record it when I'm not on my phone. Just packed up for the day

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
I suspect this is from the CSRF, but we should test this in older versions or
uncover the fault

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Nick Clemens  changed:

   What|Removed |Added

 Attachment #164761|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 164775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164775=edit
Bug 36581: Define ymd in scope for checkouts table

Test plan:
1. Find or create an item with a public or nonpublic note
   (in KTD default data, items on biblionumber 12 have notes already)
2. Check the item out to a patron
--> Checkouts table loading never completes
--> Browser console shows: "Uncaught ReferenceError: ymd is not defined"
3. Apply patch and clear browser cache
4. Refresh the page
--> Checkout table loads and console error is gone

Signed-off-by: Emily Lamancusa 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505

--- Comment #11 from Brendan Lawlor  ---
Thanks Tomás!

Testing notes:

Apply dependencies and patch
```shell
git fetch
git checkout origin/master -b bug_36505
git bz apply 36505
```

Enable system preference RESTOAuth2ClientCredentials
Create a patron with edit borrowers permissions
Get an API authentication token

curl --location --request PUT 'http://localhost:8080/api/v1/patrons/21' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer
MTcxMjg0OTAyOC00NTc2OTEtMC4yNTUwNzU4MzY0NjM2NS1SbVF0UzdROW1qTDE0b1ViVjJKYXhuSFFlblZLcjY='
\
--data '{
"category_id": "PT",
"library_id": "CPL",
"surname": "Ballard",
"extended_attributes": [
{
"extended_attribute_id": "1",
"type": "SHOW_BCODE",
"value": "1"
}
]
}'

This returns 200 and updates the patron attribute!

Run test:
kohadev-koha@kohadevbox:koha(bug_36505)$ prove t/db_dependent/api/v1/patrons.t
t/db_dependent/api/v1/patrons.t .. ok   
All tests successful.
Files=1, Tests=7, 11 wallclock secs ( 0.03 usr  0.01 sys +  9.11 cusr  0.65
csys =  9.80 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568

Nick Clemens  changed:

   What|Removed |Added

 Attachment #164641|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 164774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164774=edit
Bug 36568: Fix id parameter in template

Fix missed case of changing parameter name from "reports" to "id"

To test:
1. Find or create an SQL report that will return more than 20 rows
2. Run the report
3. Change the "Rows per page" drop-down to a new value
--> An empty page is displayed!
4. Apply patch
5. Repeat steps 2-3
--> The report is displayed with the appropriate number of results

Signed-off-by: David Cook 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36568] Changing rows per page on a custom report is broken

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36568

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #164527|0   |1
is obsolete||

--- Comment #10 from Brendan Lawlor  ---
Created attachment 164773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164773=edit
Bug 36505: (follow-up) Consistent error codes in POST

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #164500|0   |1
is obsolete||

--- Comment #9 from Brendan Lawlor  ---
Created attachment 164772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164772=edit
Bug 36505: Add support for `extended_attributes` in PUT /patrons/:patron_id

This patch does what the title says. With it, you will be able to PUT on
the already existing endpoint, but also pass:

```json
[ { "type": "THE_TYPE", "value": "a" }, ... ]
```

Bonus: to ease testing I added `x-koha-embed: extended_attributes`
support.

To test:
1. Apply the unit tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: This is not implemented!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Exhaustive testes pass!
5. Sign off :-D

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #164499|0   |1
is obsolete||

--- Comment #8 from Brendan Lawlor  ---
Created attachment 164771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164771=edit
Bug 36505: Unit tests

Signed-off-by: Brendan Lawlor 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423

--- Comment #20 from Victor Grousset/tuxayo  ---
> It looks like local cache can be pretty stubborn too. I do see the changes 
> now - thanks!

huh me to!


Great, I can daily drive this now for deeper testing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #54 from Lucas Gass  ---
Tests are failing here and the DBUpdates need to have their file permissions
corrected. 

Otherwise looks good!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32934] SIP checkouts using "no block" flag have a calculated due rather than the specified due date

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934

--- Comment #6 from Kyle M Hall  ---
(In reply to David Nind from comment #5)
> Could you provide a test plan? I'm not that familiar with SIP and need
> example commands.

Test Plan ( assumes KTD with default data ):
1) Connect to SIP server via Telnet, send the following messages:
9300CNterm1|COterm1|CPCPL|
11YY2024041114540120270411   
145401AOCPL|AA23529001000463|AB301259|ACterm1|BIN|
2) Check Edna's checkouts, not the checkout is not due in 2027
3) Apply this patch, restart the SIP server
4) Check in the item to remove it from Edna's record
5) Repeat step 1
6) The checkout is now due in 2027 as expected!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582

--- Comment #1 from Lucas Gass  ---
Big +1 from me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Laurence Rault  changed:

   What|Removed |Added

 CC||laurence.ra...@biblibre.com
 Status|Needs Signoff   |Failed QA

--- Comment #196 from Laurence Rault  ---
When viewing a record, opac or staff : 
Could not compile /kohadevbox/koha/opac/opac-detail.pl: "CustomXSLTExportList"
is not exported by the C4::XSLT module
Could not compile /kohadevbox/koha/catalogue/detail.pl: "CustomXSLTExportList"
is not exported by the C4::XSLT module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24956] Add ability to define emergency/override circ rules

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956

Chanel Wheeler  changed:

   What|Removed |Added

 CC||chanel.whee...@yavapaiaz.go
   ||v

--- Comment #4 from Chanel Wheeler  ---
In a consortium this would very handy.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5598] Ability to clone circulation rules to list of patron categories

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598

Chanel Wheeler  changed:

   What|Removed |Added

 CC||chanel.whee...@yavapaiaz.go
   ||v

--- Comment #2 from Chanel Wheeler  ---
Key for me would be being able to multi-select the patron categories. Another
Symphony feature we're leaving behind.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #32 from Martin Renvoize  ---
All working as expected.. I could have swarn we had examples of just passing
the query to an existing controller.. i.e. not duplicating the code as we do
here.

But I don't see a reason to block this.. we can tidy up later.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164759|0   |1
is obsolete||

--- Comment #31 from Martin Renvoize  ---
Created attachment 164770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164770=edit
Bug 22613: Add GET endpoint /patrons/{patron_id}/checkouts

This patch adds a new endpoint, for fetching checkouts from a specific
patron.

Test plan:

1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/patrons_checkouts.t
=> SUCCESS: Tests pass!
3. Run:
   $ curl -v -s -u koha:koha --request GET \
http://kohadev.local/api/v1/patrons/{id}/checkouts
test with query parameters (they are the same as for /patrons/{id}/holds
=> SUCCESS: The API works!

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

Chanel Wheeler  changed:

   What|Removed |Added

 CC||chanel.whee...@yavapaiaz.go
   ||v

--- Comment #11 from Chanel Wheeler  ---
We had this in Symphony and it was a life saver. Very much looking forward to
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Owen Leonard  changed:

   What|Removed |Added

 Blocks||36582


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582
[Bug 36582] Add option to set library, desk, and register from user menu
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36582] New: Add option to set library, desk, and register from user menu

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582

Bug ID: 36582
   Summary: Add option to set library, desk, and register from
user menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30123

Created attachment 164769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164769=edit
Screen recording showing the menu interaction

I'm proposing a change to the staff interface's user dropdown menu so that one
can set their library, desk, and register right from the dropdown menu. See the
attached gif.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123
[Bug 30123] On set library page, desk always defaults to last in list instead
of desk user is signed in at
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34120] Add custom content areas to the tools home page and cataloging home page

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34120

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #16 from Arthur Suzuki  ---
Created attachment 164768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164768=edit
Bug 36453: Update tests

Address new new version of system pref
Address new version of categories DB table BlockExpiredPatronOpacActions column

Test plan, k-t-d, BEFORE applying patch:
1) Edit some patron categories, visit:
/cgi-bin/koha/admin/categories.pl
2) Set different values for the "Block expired patrons" input config
Set a category to block
Set a category to don't block
Set a category to follow the syspref
3) Take note of the current value of the BlockExpiredPatronOpacActions sys pref

Apply patch, then run the following commands
- koha-plack --restart kohadev
- yarn css:build
- run updatedatabase

4) Visit the patron categories you edited before, make sure they all have the
correct values for the new config type
5) Check the BlockExpiredPatronOpacActions sys pref and make sure the new value
is correct according to what was before
6) Add a new patron of one of the above categories, test that:
If 'hold' is a blocked action, patron is unable to place a hold in OPAC
If 'renew' is a blocked action, patron is unable to renew in OPAC
If 'follow sys pref' is the option, check that a patron may place a hold or
renew an item according to the BlockExpiredPatronOpacActions sys pref value

prove t/db_dependent/Circulation.t
prove t/db_dependent/ILSDI_Services.t
prove t/db_dependent/Koha/Object.t
prove t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #15 from Arthur Suzuki  ---
Created attachment 164767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164767=edit
Bug 36453: BlockExpiredPatronOpacActions system preference

The sys pref now allows multipleselect values instead of YesNo

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #14 from Arthur Suzuki  ---
Created attachment 164766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164766=edit
Bug 36453: Categories admin page:

Account for multiple values param
Input is now multipleselect select
JavaScript
Staff CSS updates to account for multiselect dropdown in categories admin page

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #13 from Arthur Suzuki  ---
Created attachment 164765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164765=edit
Bug 36453: Update old occurrences of effective_BlockExpiredPatronOpacActions

Check for 'renew' when appropriate
Check for 'hold' when appropriate

The following command must return nothing before this is pushed to
master:
git grep "\beffective_BlockExpiredPatronOpacActions\b"

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #12 from Arthur Suzuki  ---
Created attachment 164764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164764=edit
Bug 36453: effective_BlockExpiredPatronOpacActions_contains method

effective_BlockExpiredPatronOpacActions
is now
effective_BlockExpiredPatronOpacActions_contains

This method has been updated to now consider an action param.
Returns true if the given action is to be blocked to expired
patrons or not.

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #11 from Arthur Suzuki  ---
Created attachment 164763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164763=edit
Bug 36453: [DO NOT PUSH] DBIC schema files

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164042|0   |1
is obsolete||
 Attachment #164043|0   |1
is obsolete||
 Attachment #164044|0   |1
is obsolete||
 Attachment #164045|0   |1
is obsolete||
 Attachment #164046|0   |1
is obsolete||
 Attachment #164047|0   |1
is obsolete||
 Attachment #164048|0   |1
is obsolete||

--- Comment #10 from Arthur Suzuki  ---
Created attachment 164762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164762=edit
Bug 36453: DB and data changes

- kohastructure.sql updates
- atomicupdate file
- Mandatory data installer updates

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22281] Does new Firefox update break some shortcut keys? (keypress deprecated)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22281

Emily Lamancusa  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36580

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36580] Keydown event properties (keyCode and which) are both deprecated

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36580

Emily Lamancusa  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22281

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Emily Lamancusa  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |emily.lamancusa@montgomeryc
   |ity.org |ountymd.gov

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Emily Lamancusa  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Emily Lamancusa  ---
Trivial one-line patch - self-SO

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32256] Self checkout batch mode

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Martin Renvoize  ---
I'd love to have seen this allow for different delimiter options rather than
on/off and assume it's new line delimited.

I've seen scanners that allow for delimiter to be configured and final
character to be configured.. so one could produce a comma delimited list
followed by return.. that would allow for a more seamless workflow (and may
also allow for replacing this on/off pref with a 'delimeter' preference
instead.

Even if we don't do that, the preference isn't well names.. we could make it
clear this only pertains to the SCO and nothing else.

Finally.. and the main reason I'm failing QA now.. if you list good and bad
barcodes the failure is silent if it's not the first barcode happens to pass..
we should be listing all info/warning/blockers for each barcode that returns a
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36581] Checkouts table on patron account won't load if any of the items have item notes

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581

Emily Lamancusa  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453

--- Comment #9 from Arthur Suzuki  ---
2cents :
The "specific action" label on patrons category configuration is a bit
ambiguous.
I wouldn't know if the selected actions are the blocked ones or allowed ones.
Might be better to call that "block specific actions".

Also the input field seems to have a slight CSS issue, it's not wide enough so
we can read the selected value without clicking on it.
Tried both Firefox and Chromium with same results.
Choosing "Follow system preferences" make it wider than both of the other
choices which is a bit weird but not much annoying actually.

Also, since the syspref is changed, the "comment" or label of the syspref makes
no sense anymore.
Used to be "[block|don't block] expired patrons from blablabla"
Should now be something like "decide which actions are blocked for expired
patrons"

tried with a patron the different values from the syspref, works.
the values from the category do actually override the syspref, works.

a couple of very small cosmetic things could be enhanced but still signing off
because the functionality just works fine and is great :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >