[Koha-bugs] [Bug 35114] Calculation around basket details and basketgroup not correct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 --- Comment #19 from Thibaud Guillot --- (In reply to Koha Team University Lyon 3 from comment #18) > Hello Thibault, > I tried several times, activing or not OrderPriceRounding, and I always have > the same prices with the patch and on master. > > I have the same prices in the basket page, the basket group. > > I use this SQL report to see all the prices : > select ordernumber, listprice, unitprice, unitprice_tax_excluded, > unitprice_tax_included, ecost, ecost_tax_excluded, ecost_tax_included, rrp, > rrp_tax_excluded, rrp_tax_included, replacementprice from aqorders > > And I have the same results in master and with your patch. > > Are sure of your examples ? Perhaps this issue is already fix in master ? > > Sonia Hi Sonia, Before this patch there was no difference with the system preference to activate the amount taken into account was that of the unit price already rounded beforehand when it was informed about the view preceding the detail of the basket. Now according to its activation yes there is a difference on the basket detail. Do not forget to provide a discount rate on the vendor in order to be able to see the differences on the calculated amounts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #36 from Thibaud Guillot --- (In reply to Koha Team University Lyon 3 from comment #35) > I just tested it again and it doesn't work. > If I put "4,5" in the discount rate of a vendor, then save and edit it again > the discount rate hasn't been saved, the discount rate is empty. > > Sonia Normally this should not be possible. I just tested again, the validation of the form imposes a comma, did you rebuild the css ? (This is an option on the sandbox management interface). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Claes changed: What|Removed |Added CC|claes.eriks...@vti.se | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36597] Cannot delete circulation desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36597 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 --- Comment #1 from Katrin Fischer --- We just got another report of this, so giving this another 'bump'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 164871
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164871&action=edit
Bug 36593: Add 'time' column type support to TestBuilder
This simple patch adds support for the 'time' column type.
To test:
1. Run:
$ ktd --shell
k$ perl -Mt::lib::TestBuilder -e 'my $b = t::lib::TestBuilder->new; my
$hour = $b->build_object({ class => "Koha::Library::Hours" });'
=> FAIL: It explodes as it doesn't know how to deal with the 'time'
column type
2. Apply this patch and the follow-up
3. Run:
k$ prove -MDDP -Mt::lib::TestBuilder -e 'my $b =
t::lib::TestBuilder->new; my $h = $b->build_object({ class =>
"Koha::Library::Hours" }); p($h->unblessed);'
=> SUCCESS: It generates an hour!
4. Run:
k$ prove t/db_dependent/TestBuilder.t
=> SUCCESS: It builds all the things!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 164872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164872&action=edit Bug 36593: Add missing koha_object(s)_class methods to LibraryHour.pm (bug 9796) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Alban Peyrat changed: What|Removed |Added CC||alban.peyrat_k...@yahoo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35688] RFID Envisionware Software Requires Static Page Title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35688 --- Comment #5 from Owen Leonard --- I'm skeptical about sacrificing some human usability to make the page work with automation. I would prefer that some development be done towards making batch check-in a feature on its own. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35511] Add visual indicators of patron edit form collapsible sections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35511] Add visual indicators of patron edit form collapsible sections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Kyle M Hall changed: What|Removed |Added Attachment #164852|0 |1 is obsolete|| Attachment #164853|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 164873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164873&action=edit Bug 35511: Add visual indicators of patron edit form collapsible sections This patch updates CSS and markup in the patron add/edit form so that there is better visual indication that sections can be collapsed by clicking headings. The JS function for showing and hiding sections has also been updated to reduce verbosity. Unrelated markup change for the sake of accessibility: A has been added to the "Show collapsed fields" checkbox which is seen when CollapseFieldsPatronAddForm is active. To test, apply the patch and go to Patrons -> New patron. - Each section of the form should have an arrow indicator by the section heading indicating whether it is expanded or collapsed. - Mousing over the heading should show a border to help show the clickable region. - Clicking the header should collapse the section and the arrow indicator should change to reflect that the section is collapsed. - Go to Administration -> Sytem preferences and search for CollapseFieldsPatronAddForm. - Make some selections from the dropdown and save your changes. - Return to the patron entry form and confirm that your selections are collapsed by default. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35511] Add visual indicators of patron edit form collapsible sections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 --- Comment #7 from Kyle M Hall --- Created attachment 164874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164874&action=edit Bug 35511: (follow-up) Tweaks to CSS, adding aria-hidden to icons Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34142] Add column sub_location to items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen changed: What|Removed |Added Attachment #159236|0 |1 is obsolete|| --- Comment #14 from Emmi Takkinen --- Created attachment 164875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164875&action=edit Bug 34142: Add new column sub_location to (deleted)items Add new column sub_location to items and deleteditems table. Column can be used to indicate e.g. if item has some other more specific location than permanent location. To test: 1) Add new authorized value for sublocation e.g. "SUBLOC" and add some values to it. 2) Add new 952 subfield e.g. S to MARC framework and link your new authorized value "SUBLOC" to it. 3) Link subfield to items.sub_location field in "Koha to MARC mapping" (add 952,S). 4) Find a record and attempt to add new item to it. => Note that new subfield S is now displayed on item form and dropdown selector contains values added to "SUBLOC". => Saving should be successfull. => After saving confirm that sublocation is displayed in its own column in items listing above item form and that sublocation is displayed with correct description. 5) Attempt to modify item. => Confirm that sublocation is displayed and it's correct. 6) Attempt to delete item. => Deleting should be successfull. Also confirm that sub location is displayed on these pages: 1) detail.pl 2) moredetail.pl 3. returns.pl Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34142] Add column sub_location to items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen changed: What|Removed |Added Attachment #159237|0 |1 is obsolete|| --- Comment #15 from Emmi Takkinen --- Created attachment 164876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164876&action=edit DO NOT PUSH! Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34142] Add column sub_location to items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen changed: What|Removed |Added Attachment #164876|0 |1 is obsolete|| --- Comment #16 from Emmi Takkinen --- Created attachment 164877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164877&action=edit DO NOT PUSH! Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34142] Add column sub_location to items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi --- I understand the proposal and the motivation. I've added this topic to next dev meeting's agenda [1] for broader discussion. [1] https://wiki.koha-community.org/wiki/Development_IRC_meeting_17_April_2024 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Pedro Amorim changed: What|Removed |Added Attachment #164693|0 |1 is obsolete|| --- Comment #87 from Pedro Amorim --- Created attachment 164878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164878&action=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Pedro Amorim changed: What|Removed |Added Attachment #164694|0 |1 is obsolete|| --- Comment #88 from Pedro Amorim --- Created attachment 164879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164879&action=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place item-level hold on staff interface 3 - Hold is still allowed (rule do not apply to staff) 4 - Attempt to place item-level hold from opac or ilsdi 5 - Hold is not allowed (rule apply from opac or ilsdi) 6 - Change rule to 'force' 7 - Item-level hold can still be placed from the staff interface 8 - Record-level hold cannot be placed from opac or ilsdi Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #89 from Pedro Amorim --- This looks like it's a good change i.e. moving the check logic to a lower layer. The test plan works as described and all tests pass. I can't find a bug or issue this introduces, but others more experienced in the holds logic than me may disagree. Also tested the following ILSDI endpoint: /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=11&bib_id=76&item_id=167 It respects the opacitemholds config as expected, I believe, as ILSDI is an OPAC interface and context is 'opac' when using ILSDI Some thoughts related to code specifically: - Personally I'd prefer this to be unfolded in more commits to ease the review process, with each having a short explanation of why the changes are required: Something like this, (only a suggestion): -- Move get_opacitemholds_policy check into Reserves.pm::CanBookBeReserved -- Update CanItemBeReserved to return recordHoldsOnly status if interface is OPAC -- Update warning labels in opac-reserve.tt accordingly. - A new unnecessary empty new line is added in opac-reserve.pl - Some lines that have not been changed have been tidied and included - Unnecessary changes are made e.g. $patron->borrowernumber to $patron->id (correct me if I'm wrong here, please!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36584] Add fields 520, 561, and 563 (MARC 21) to ES note search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36584 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36584] Add fields 520, 561, and 563 (MARC 21) to ES note search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36584 Pedro Amorim changed: What|Removed |Added Attachment #164777|0 |1 is obsolete|| --- Comment #2 from Pedro Amorim --- Created attachment 164880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164880&action=edit Bug 36584: Add fields 520, 561, and 563 (MARC 21) to ES note search field With Zebra, the general keyword search covered the entire record content, even if the field was not explicitly indexed with a Zebra index (the Any index). With Elasticsearch only the content of the fields explicitly indexed can be found with general keyword search. This is OK, to some extent, but with the current configuration it hides the content fo some important notes from the searches, and librarians complained about that: 520 - Summary, etc., 561 - Ownership and Custodial History, 563 - Binding Information. This patch adds the content of 520, 561, and 563 fields to the 'note' search field. Test plan = 1. Have an installation with Elasticsearch. 2. Add some information to the 520, 561, and/or 563 fields (561 is hidden in the default framework--one should enable it to be able to use the 561 field). Save teh record. 3. Try to find the record with the general keyword search, with the words you used. If they were specific enough, you will get no results. 4. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 5. Confirm that now you are able to find the record with the information you entered. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593
Martin Renvoize changed:
What|Removed |Added
Attachment #164871|0 |1
is obsolete||
--- Comment #3 from Martin Renvoize ---
Created attachment 164881
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164881&action=edit
Bug 36593: Add 'time' column type support to TestBuilder
This simple patch adds support for the 'time' column type.
To test:
1. Run:
$ ktd --shell
k$ perl -Mt::lib::TestBuilder -e 'my $b = t::lib::TestBuilder->new; my
$hour = $b->build_object({ class => "Koha::Library::Hours" });'
=> FAIL: It explodes as it doesn't know how to deal with the 'time'
column type
2. Apply this patch and the follow-up
3. Run:
k$ prove -MDDP -Mt::lib::TestBuilder -e 'my $b =
t::lib::TestBuilder->new; my $h = $b->build_object({ class =>
"Koha::Library::Hours" }); p($h->unblessed);'
=> SUCCESS: It generates an hour!
4. Run:
k$ prove t/db_dependent/TestBuilder.t
=> SUCCESS: It builds all the things!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 Martin Renvoize changed: What|Removed |Added Attachment #164872|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 164882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164882&action=edit Bug 36593: Add missing koha_object(s)_class methods to LibraryHour.pm (bug 9796) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Good spot, thanks for the quick follow-up Tomas. Passing QA directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 --- Comment #6 from Jonathan Druart --- I am expecting regressions from this, did you run the whole test suite? If you set all dates to now, you will have problems in the circulation, holds, etc. logic. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36482] Make it possible to embed desks and cash_registers on /libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 Martin Renvoize changed: What|Removed |Added Depends on|36480 | CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 [Bug 36480] Add GET /libraries/:library_id/desks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36480] Add GET /libraries/:library_id/desks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36480 Martin Renvoize changed: What|Removed |Added Blocks|36482 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 [Bug 36482] Make it possible to embed desks and cash_registers on /libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > I am expecting regressions from this, did you run the whole test suite? > > If you set all dates to now, you will have problems in the circulation, > holds, etc. logic. Am I missing something? I'm not touching anything for existing behavior. This is replicating it for 'time' only. The only 'time' column is this new one. Though, the fact TestBuilder cannot build 'Koha::Library::Hour' objects implies... there are no good tests for this feature? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 --- Comment #8 from Jonathan Druart --- Right, ignore me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20065] Perennial or persistent identifier implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20065 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36374] Some of our JS files should stay tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 Martin Renvoize changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic records with standard identifiers from authority data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 --- Comment #1 from Pedro Amorim --- Created attachment 164883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164883&action=edit Bug 35604: New Backends.pm class. installed_backends method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 --- Comment #2 from Pedro Amorim --- Created attachment 164884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164884&action=edit Bug 35604: New 'ill-backends' syspref type UI rendering of sortable ILL backends -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 --- Comment #3 from Pedro Amorim --- Created attachment 164885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164885&action=edit Bug 35604: New AutoILLBackendPriority sys prefs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 --- Comment #4 from Pedro Amorim --- Created attachment 164886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164886&action=edit Bug 35604: ILL request creation with AutoILLBackendPriority enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 --- Comment #5 from Pedro Amorim --- Created attachment 164887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164887&action=edit Bug 35604: ConfirmAuto workflow stage -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604 --- Comment #6 from Pedro Amorim --- Created attachment 164888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164888&action=edit Bug 35604: Add tests Test plan: Apply patches Staff: 1) Visit the ILL sysprefs page: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Enable ILLModule 3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available backends" 4) Install 2 backend plugins from here: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0 5) Repeat 1. Notice the backends now show. 6) Enable both for AutoILLBackendPriority by ticking each respective checkbox. Save. 7) Visit ILL requests: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 8) Press "New auto ILL request" 9) You are presented the "Standard" create form. Pick type "journal" and put '123' on DOI. Enter '42' on cardnumber and pick a library. Click Create. 10) Notice you are now shown the "Confirm auto backend" stage screen. 11) PluginBackend has a 50% chance of being available or not for testing purposes. If it is, it'll suggest PluginBackend, if not, it'll default to Standard. ReprintsDesk will always error because it's missing credentials. 12) Pick any of the backends or accept the suggested one, click 'Create'. The request has been placed in that specific backend. OPAC: 1) Following from the previous test plan, visit OPAC ill requests: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 2) Click "Create a new auto request" and repeat the same inputs as before. Click 'Create'. 3) Notice you're directed to "Confirming your request" screen. It's doing the same as it does in the Staff UI, except it does not allow the patron to pick a different backend, it'll always selected the first available backend in the priority. 4) Create more requests, you'll notice some of them will land on PluginBackend, others will land on 'Standard' because PluginBackend will sometimes be available and others not. Do more testing: - Reorder the backends in the AutoILLBackendPriority syspref and save, notice they're shown and suggested accordingly after creating a request. - Disable all backends from AutoILLBackendPriority. Notice the original behaviour of requiring the user to select a backend before creating the request is restored on both opac and staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32420] Set focus for cursor to barcode input box in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32420 --- Comment #5 from Caroline Cyr La Rose --- Hi Paul, I tried to apply the patches, but it gives me an error. Should the old patch be obsoleted? Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33243] Reindex only Biblios changed in the last x minutes in Elasticsearch (ES)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33243 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- A where would be great. With also tables : https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/migration_tools/rebuild_zebra.pl#L94 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 --- Comment #9 from Caroline Cyr La Rose --- With independent branches, you don't really have groups though? Will we need to create a group per branch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 --- Comment #10 from Michael Hafen --- Such a branch group type would probably use the same groups as the item editing type. In my case it would mean a group with that type per branch to mimic independent branches. Which I would already need if all of the independent branches feature was moved to branch groups, so that's not really a problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Caroline Cyr La Rose changed: What|Removed |Added Attachment #164554|0 |1 is obsolete|| --- Comment #6 from Caroline Cyr La Rose --- Created attachment 164889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164889&action=edit Bug 36295: Space out content blocks in batch record deletion This patch adds a float-clearing line break to the batch record deletion template so that the "Record type" section has visual separation from the record number submission tabs. To test, apply the patch and go to Cataloging -> Batch record deletion. There should be padding between the two sections. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 Caroline Cyr La Rose changed: What|Removed |Added Attachment #164860|0 |1 is obsolete|| --- Comment #7 from Caroline Cyr La Rose --- Created attachment 164890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164890&action=edit Bug 36295: Space out content blocks in batch record modification This patch adds a float clearing class to a line break in the batch record modification template to fix a spacing issue in Chrome. To test apply the patch and go to Cataloging -> Batch record modification There should be space between the two sections. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36295] Space out content blocks in Batch record deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295 --- Comment #8 from Caroline Cyr La Rose --- Thanks all! Looks much better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36601] New: When creating guarantee card from the guarantor’s account can it default to the guarantor’s category?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36601 Bug ID: 36601 Summary: When creating guarantee card from the guarantor’s account can it default to the guarantor’s category? Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: pwashkev...@sjcfl.us QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When creating a guarantee card off of the guarantor’s account (click add guarantee instead of duplicate), the category setting is defaulting to 1 year nonresident. Can it be changed to default to the guarantor’s category? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567 --- Comment #3 from Owen Leonard --- Created attachment 164891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164891&action=edit Bug 16567: Correct RSS feed validity errors This patch corrects a few markup errors in the XML feeds to make the feeds validate correctly. The template has been largely re-indented to improve readability and eliminate tab characters. To test, apply the patch and perform a search in the OPAC. - Open the RSS link appearing after the "Your search returned..." header. - Depending on how your browser handles XML documents you may need to view source on the page to see the actual XML markup. - Copy the source and paste it into the W3C feed validator: https://validator.w3.org/feed/#validate_by_input - The feed should be found to be valid. - In my tests you'll get a "Recommendation" about "Self reference doesn't match document location." I think this recommendation doesn't apply. Perform the same test with the other two available formats: Atom and OpenSearch: - Change the end of the RSS feed url from '&format=rss' to '&format=atom' and validate the result. - The same "self reference" recommendation will come up, and again I think we can ignore it. - There is another recommendation about "Two entries with the same value for atom:updated." The updated time is set to the same time as the feed itself (the time when the feed was generated. Maybe this is incorrect. If so we need a follow-up that exposes a different value to the template. biblio.datecreated maybe? - Change the end of the feed url from '&format=atom' to '&format=OpenSearchDescription' and validate that result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36602] New: Locked account requires a password change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36602 Bug ID: 36602 Summary: Locked account requires a password change Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It doesn't make sense that a password change is required for a locked account. Accounts are locked because someone has attempted to log into the account multiple times and has failed the threshold. This means that someone knows the account username, but doesn't know the password. If the threshold is not a low number, it is likely someone is trying to gain access to the account that should (especially if they don't use a forgot password method. It seems that the more logical approach is to require a card number and/or username change. I guess it is possible that it could be the patron/user and they are just really bad at password recovery, and persistent, but I'm still not convinced this is the most logical response to being locked out. A change in username would be more likely to thwart abusive users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2894] Routing list holds are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 Jonathan Druart changed: What|Removed |Added Attachment #138971|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 164892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164892&action=edit Bug 2894: Fix Routing list holds This is a try to fix a very old bug. Not familiar with the workflow so cannot confirm it will fix everything. The idea is to fix the behaviour of RoutingListAddReserves, and create item-level holds (so only if items have been created). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #6 from Caroline Cyr La Rose --- Just pasting here what I said in the chat, to provide context The need behind this is that we have a client who is linking their patron account to an external system. We added a lot of patron attributes for them because it's a special library and they need specific information. They need their other system to be "triggered" when a patron is modified in Koha, either normal patron fields or patron attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2894] Routing list holds are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Jonathan Druart --- Sorry I totally forgot about this one. I had a very quick short at rebasing it but haven't tested it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31335] Unnecessary holds fetch in serials/routing-preview.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31335 --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #4) > Trivial clear fix, Passing QA But took 1.5 year :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36603] New: UNIMARC: automatically copy the ISNI number over when linking authorities with authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36603 Bug ID: 36603 Summary: UNIMARC: automatically copy the ISNI number over when linking authorities with authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: a.rous...@dataly.gr QA Contact: testo...@bugs.koha-community.org The 2023 edition of the IFLA UNIMARC Authorities Format Manual [1] has the following to say about subfield $o of authority fields 500, 510 and 520 [2,3,4]: "$o International Standard Name Identifier (ISNI) The subfield $o (International Standard Name Identifier) is used in field 510 to record the ISNI of the related identity. When the preferred access point of an authority record that contains field 010 is transferred to the 500/510/520 access point of another record (while establishing a link between both authority records), the number contained in the 010 field of the first record will also be transferred in a devoted subfield $o. Repeatable." So, when linking authorities with other authorities in UNIMARC instances I think it would be a good idea if Koha automatically copied the contents of subfield 010$a [5] into the corresponding 5xx$o subfield (if such an ISNI number exists in the source record, of course). [1] https://repository.ifla.org/handle/123456789/3011 [2] 500 RELATED ACCESS POINT – PERSONAL NAME [3] 510 RELATED ACCESS POINT – CORPORATE BODY NAME [4] 520 RELATED ACCESS POINT – FAMILY NAME [5] 010 INTERNATIONAL STANDARD NAME IDENTIFIER (ISNI) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36603] UNIMARC: automatically copy the ISNI number over when linking authorities with authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36603 Andreas Roussos changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |a.rous...@dataly.gr |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 --- Comment #7 from Caroline Cyr La Rose --- Also I think that end users don't see a difference between normal patron fields and patron attributes. We show the updated_on date in the left-hand column, so I think it would be logical (again, from end user pov) that this date be updated when we update a patron attribute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Thomas Klausner changed: What|Removed |Added CC||d...@plix.at --- Comment #6 from Thomas Klausner --- I followed the test plan, but had to add an entry for "sso" into my "/etc/hosts": In docker-compose, keycloak runs as service name "sso" and thus is reachable from eg the OPAC via http://sso:8082. But as OAuth needs to also redirect the browser (running on my host) to the same URL, I needed to add this to the "/etc/hosts" on my host (= dev laptop): 127.0.0.1 sso Depending on your setup, you might need to do different things, just make sure that the "well_known_url" is "http://sso:8082/auth/realms/test/.well-known/openid-configuration"; and that you can access this URL from your host and from inside koha testing docker (try "curl http://sso:8082";, which should return some raw html like "Resource not found" and NOT "Failed to connect") -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #7 from Thomas Klausner --- Created attachment 164893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164893&action=edit Screenshot showing that it worked! Just a small screenshot showing that the test plan worked -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #8 from Thomas Klausner --- Also note that the unit test does not work after running the manual test plan and installing the pluging, so run the unit test before the manual test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Thomas Klausner changed: What|Removed |Added Attachment #164379|0 |1 is obsolete|| --- Comment #9 from Thomas Klausner --- Created attachment 164894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164894&action=edit Bug 36503: Add a plugin hook after user authentication This plugin hook allows to change patron data or define the patron based on the authenticated user. To test: Run prove t/db_dependent/Koha/Auth/Client.t Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Thomas Klausner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Thomas Klausner changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36527] Patron category or item type not changing when editing another circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Hammat wele changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||hammat.w...@inlibro.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 --- Comment #3 from Owen Leonard --- Created attachment 164895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164895&action=edit Bug 36582: Add option to set library, desk, and register from user menu This patch adds an expandable "panel" in the user dropdown menu in the staff client. Expanding the panel will load the form from set-library.pl, including library, desk and register options if present. The patch moves the contents of desk_selection.js and register_selection.js into staff-global.js so that the functionality is available on every page. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test plan stolen from Bug 36572: 1. Have 3 staff accounts to test: -STAFF A: superlibrarian -STAFF B: loggedinlibrary permission -STAFF C: no loggedinlibrary or superlibrarian permission 2. Enable 'UseCirculationDesks' and create some desks. (Admin > Circulation desks) 3. Enable 'UseCashRegisters' and create some registers ( Admin > Cash registers) 4. Use STAFF A ( superlibrarian ) and make sure you can change branch, desk and register. 5. Use STAFF B ( loggedinlibrary permission ) and make sure you can change branch, desk and register. 6. Use STAFF C ( no loggedinlibrary or superlibrarian permission ) and make sure you can change branch, desk and register. 7. Each time you change you should be redirected to the page you were previously on. 8. Turn off UseCirculationDesks, make sure everything still works. 9. Turn off UseCashRegisters, make sure everthing still works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 --- Comment #4 from Owen Leonard --- This is technically BLOCKED but I thought I'd get eyes on it since it's otherwise ready. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Michaela Sieber changed: What|Removed |Added CC||dc...@prosentient.com.au, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36495] Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #20 from Martin Renvoize --- I'm happy with this now as it stands.. as soon as I can get the dependencies all applying I'll add my signature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33997] Borrowers.updated_on should not be updated by track_login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15504 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33997 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33997] Borrowers.updated_on should not be updated by track_login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35508 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35508] Update borrowers.updated_on when modifying a patron's attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33997 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 --- Comment #9 from Martin Renvoize --- Well.. yes and no regards tests.. They didn't add the relations so there aren't tests for that and the tests that are added account for changes in Circulation.pm and didn't need mocking.. We could always do with more tests though.. and I'd like to see more of the logic moved back out of controllers into classes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36593] Add support for the `time` column type on TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36593 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36596] Opening/closing hours should be forced to be set together
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36596 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize --- Whilst I agree about the column name and the requirement to set both openening and closing.. I'm not so sure about the meaning of no opening/closing.. that could just mean it's a 24h library and open the whole day rather than having an opening/closing time right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36594] Library hours display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- This is one of the things I was getting at when I said we really need to link the closed days and the opening hours functionalities.. For regular closed days we shouldn't display opening hours at all.. just mark the whole day as closed in that row. The other time output I would be keen to have fixed too and agree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36596] Opening/closing hours should be forced to be set together
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36596 --- Comment #2 from Martin Renvoize --- We're back into naming consistency territory here.. in repeatable_holidays it's: > `weekday` smallint(6) DEFAULT NULL COMMENT 'day of the week (0=Sunday, > 1=Monday, etc) this closing is repeated on' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28224] Make date range for order search configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #11 from Sarah Cornell --- I lost my patience with the invisible order search limit back in 2021, right before this bug was filed! If I recall correctly, it would limit to the past year even though it didn't display that limit. That drove me bonkers. I'm pretty sure we have JQuery that sets the range to 2020-current. When we search the biblio database we expect to see all results, so why would orders be any different? When I want to know if we placed an order for a title, that's all I want to know. "When" doesn't come into it. If there are too many results, THEN I want to limit the search. The behavior that seems most like other search behavior is that there be no default date limit. If I were using the simple search at the top, I would expect it to use default settings, which means no default date limit. I do appreciate it if a form remembers the last dates I entered, however. Then I would use the form for the rest of my session. Regarding a syspref: Some staff want to see everything, some staff want to search just this FY. None of them have access to sysprefs. If a library wants to customize the date range using JS, that seems like a good local solution. I'm probably suggesting a different bugfix, aren't I? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23641] Checkout via camera on device
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 --- Comment #25 from Christopher Brannon --- Wouldn't the primary uses of this feature be from phones? I see very little use case for iMac. While it might be possible someone would try something other than an Android or iPhone, I don't think those should be a show stopper. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30657 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36505 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch tool for placing and cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 --- Comment #11 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #9) > With independent branches, you don't really have groups though? > > Will we need to create a group per branch? That's true, but I think we are moving into maybe retiring IndependentBranches at some point. A lot of its functionality is now covered by the library groups in a better and more reliable way. Visibility of patrons and editing of items at least. See: Bug 12599 - IndependentBranches Holes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34255] Add an enquiry/request/workflow management module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #32 from Andrew Fuerste-Henry --- (In reply to Aleisha Amohia from comment #31) As Aleisha says, the sysprefs here existed before this feature and apply to both staff checkout and self-check. I agree that customizable delimiters make sense as a feature to be added down the road, but would hate to see this enhancement stall out over it now. > > > > Finally.. and the main reason I'm failing QA now.. if you list good and bad > > barcodes the failure is silent if it's not the first barcode happens to > > pass.. we should be listing all info/warning/blockers for each barcode that > > returns a problem. > > I have addressed this in follow-up. I'm not sure this follow-up is addressing the issue raised. With this new patch this is what I see: - enable BatchCheckouts, but no categories in BatchCheckoutsValidCategories - Have barcodes 1,2,3 that allow checkout, barcodes A,B,C that are not for loan - log into SCO with a patron, enter a valid barcode followed by an invalid barcode (1, A). Item 1 checks out correctly, but Koha says "Please check out the following items individually: A" -- This is inaccurate as A doesn't exist, cannot be checked out at all - log into SCO with another patron, enter an invalid barcode followed by a valid barcode (B, 2). Neither item checks out. Koha accurately reports that B is not a known item and says 2 must be checked out individually - return your items, enable a patron category in BatchCheckoutsValidCategories - log into SCO with a patron in the category you've allowed to use batch checkouts - Enter a valid barcode followed by an invalid barcode (1, A). Item 1 checks out, Koha makes no mention of item A. This behavior appears unchanged. Your new patch appears to apply only to patrons who are not allowed batch checkout? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34118] Add Patron's home library as an option on the DefaultHoldPickupLocation preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34118 lthor...@cuyahogalibrary.org changed: What|Removed |Added CC||lthor...@cuyahogalibrary.or ||g -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36269] Elasticsearch: publisher-location (pl) index should include 260a/264a (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose changed: What|Removed |Added Text to go in the|This enhancement adds 260$a |This enhancement adds 260$a release notes|and 264$a to the|and 264$a to the |publisher-location (pl) |publisher-location (pl) |Elasticsearch index for |Elasticsearch index for |MARC21 records. Values in |MARC21 records. Values in |those two fields will be|those two fields will be |findable using the |findable using the |Publisher location option |Publisher location option |in the advanced search. |in the advanced search. || |Note: for existing |Note: for existing |installations, the index|installations, the index |needs to be rebuild using |needs to be rebuilt using |-r (reset mappings) in |-r (reset mappings) in |order for this information |order for this information |to be taken into account. |to be taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20682] Authorised values should have an option to set a default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20682 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Doug Kingston changed: What|Removed |Added CC||d...@randomnotes.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28224] Make date range for order search configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 --- Comment #12 from Katrin Fischer --- > I'm probably suggesting a different bugfix, aren't I? :) I think so, but still very valueable feedback :) I think you are saying: remove the date limit from the acq "simple search" and let libraries set their own using jQuery for advanced search. That about correct? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28224] Make date range for order search configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224 --- Comment #13 from Sarah Cornell --- Yep, that's it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
