[Koha-bugs] [Bug 35226] Items are In transit and Available at the same time

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35226

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi

--- Comment #3 from Emmi Takkinen  ---
This seems to be duplicate, see bug 35934.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30888] Add a table for deletedauthorities

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888

--- Comment #16 from Victor Grousset/tuxayo  ---
(In reply to Marcel de Rooy from comment #14)
> Please explain why a separate table causes bad bugs. Some issues that we
> experienced in the past were related to autoincrement.

Hm, I though bug 19532 comment 5 was about more stuff than autoincrement.
Because these are indeed reliably avoidable now that it's known.


> > Introducing a flag will cause bugs only on that moment. (found and fixed in
> > the next months)
> 
> Hopefully :) One could argue that having one table requires more careful
> coding and is therefore more error prone?

When doing delete flags, there should be something in the data layer to by
default query only the non deleted data. Otherwise it will be hard to never
forget to filter. And code everywhere will have some additional complexity to
filter the data. It's a bit of code duplication in many places.
Do we have all/almost all the interactions with the authorities table in the
data layer? Otherwise it's not sure it's possible to deal with these issues :/


> Some related questions:
> Why enforce something here that we have not been able to do in the last 6
> years for a few similar tables?

Here, there is no tombstone table so introducing the flag is less work than
doing that + removing the tombstone table. Still more work than for a totally
new table like recalls.
But before that, the question is, should we even avoid introducing a tombstone
table?
That's suddenly not as clear.


> Will add yet another comment about the two scenarios from a more general
> perspective more or less proving that both ways have pro and cons.
> [...]
> Please read this on dba.stackexchange.com:
> https://dba.stackexchange.com/questions/14402/tombstone-table-vs-deleted-
> flag-in-database-syncronization-soft-delete-scenari/14419

From the discussions and attempts to switch to delete flags in the last years,
it seemed a given that a tombstone table was an anti-pattern but it turns out
totally not šŸ˜±


Back to trying to find the contention point: Now that it's known how to avoid
autoincrement issues with tombstone tables, do they have a significant drawback
for our use case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

--- Comment #5 from Lucas Gass  ---
Created attachment 165493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165493&action=edit
Bug 36694: Add JS observer to detect stuck sticky element

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36689] SelfCheckAllowByIPRanges does not work

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36689

--- Comment #4 from Christopher Brannon  ---
It is our public IP address, as seen by the world, and as Koha would see us.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165491|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 165492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165492&action=edit
Bug 36694: Remove HC sticky from acqui/supplier.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

--- Comment #3 from Lucas Gass  ---
Created attachment 165491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165491&action=edit
Bug 36694: Remove HC sticky from acqui/supplier.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

--- Comment #2 from Lucas Gass  ---
Created attachment 165490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165490&action=edit
Bug 36694: Remove HC sticky from acqui/basket.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36689] SelfCheckAllowByIPRanges does not work

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36689

--- Comment #3 from Katrin Fischer  ---
Is that the IP address of your workplace as it is visible to the server? If you
are self hosting or using VPN that might be a different one on your local
network than to the outside world.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28129] Allow staff to add subscription alerts on behalf of patrons

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28129

Katrin Fischer  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #2 from Katrin Fischer  ---
*** Bug 36692 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36692] Add ability to subscribe a patron to a serial alert notice from patron account in staff interface.

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36692

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 28129 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

--- Comment #1 from Lucas Gass  ---
Created attachment 165489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165489&action=edit
Bug 36694: Remove HC sticky from patron search searchbar

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36689] SelfCheckAllowByIPRanges does not work

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36689

--- Comment #2 from Christopher Brannon  ---
Just our IP address in standard format, just like the preference suggests:

XXX.XXX.XXX.XXX

Is there another syntax I should be using?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36691] Serial Alert notice does not appear in patron notices tab

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36691

--- Comment #2 from Katrin Fischer  ---
Ok, re-reading the bug description helps :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36691] Serial Alert notice does not appear in patron notices tab

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36691

--- Comment #1 from Katrin Fischer  ---
Hi Esther, I belive they might not be sent via messagequeue, but directly. Have
you checked with a working email setup?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36695] anonymous patron is not blocked from checkout via SIP

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36695

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36679

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36695

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

--- Comment #6 from Christopher Brannon  ---
(In reply to Lucas Gass from comment #4)
> (In reply to Christopher Brannon from comment #1)
> > This also seems to be the case with SIP transactions.
> > 
> > I've restricted the anonymous account.
> 
> Christopher,
> 
> Can you file a separate bug outlining how you were able to do this via a SIP
> transaction? 
> 
> Thanks!

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36695

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36695] New: anonymous patron is not blocked from checkout via SIP

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36695

Bug ID: 36695
   Summary: anonymous patron is not blocked from checkout via SIP
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

The anonymous patron is not allowed to checkout through the staff module, but
it appears that you can checkout as this user via SIP2, particularly through
3rd party self check systems that do not require the patron to enter a
password.

While it is more likely this could be exploited with a random library card
number, this does create a hole in blocking circ on this account.

1. Make sure AnonymousPatron is pointed to an account.
2. Point your 3rd party self check at Koha, and do not require a password for
patron authentication.  (You COULD also test with a username/password scenario,
which also shouldn't be allowed).
3. Verify that if you go to the anonymous patron account in the staff
interface, you cannot checkout items.
4. Sign into the 3rd party self check with the anonymous account, either as a
sign in with cardnumber only, or with the username/password scenario.
5. Proceed to check out items!

Our system is setup for cardnumber only, but I imagine it works just the same
with username/password.  But I can confirm that this account is checking out
via SIP2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] New: Remove HC Sticky library in favor of CSS

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

Bug ID: 36694
   Summary: Remove HC Sticky library in favor of CSS
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

CSS sticky is now widely available across major browsers. I think we can use it
instead of the HC sticky library now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36693] Improve floating toolbar in OPAC search results

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36693] Improve floating toolbar in OPAC search results

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693

--- Comment #1 from Lucas Gass  ---
Created attachment 165488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165488&action=edit
Bug 36693: Remove hc-sticky and use CSS sticky

To test:
1. APPLY PATCH and regenerate OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. DO an OPAC search that has enough results to scroll.
3. The toolbar which includes pagination, select all, clear all, etc. should
scoll the same as it did without the patch.
4. There should no longer be a small gap between the pagination and the other
tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36693] Improve floating toolbar in OPAC search results

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36689] SelfCheckAllowByIPRanges does not work

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36689

--- Comment #1 from Katrin Fischer  ---
What syntax did you use? we are using this with 22.11 in production.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36693] New: Improve floating toolbar in OPAC search results

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693

Bug ID: 36693
   Summary: Improve floating toolbar in OPAC search results
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

I think the floating toolbar ( #floating ) can be slightly improved.

-Between the #toolbar and the .selections-toolbar there is a small space and
one can see the content beneath it. Slight annoyance

-I think we can use position: sticky now to accomplish the "floating". It seems
to have widespread enough support:

https://caniuse.com/?search=sticky

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36530] Add ability to simultaneously add multiple items to a rotating collection

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36530

--- Comment #1 from Heather Rommens  ---
Commenting to note that in addition to being able to add multiple items to a
rotating collection at once, the ability to remove multiple items from a
rotating collection (perhaps by checking a box/multiple boxes) would also be
helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35134] cn_browser.pl pop-up size should be configurable

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134

Lucas Gass  changed:

   What|Removed |Added

   Assignee|lu...@bywatersolutions.com  |pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

--- Comment #5 from Lucas Gass  ---
This blocks the AnonymousPatron from logging in at the SCO module. Is there any
reason that the AnonymousPatron should be able to log into anything? (
OPAC/SCO/Staff )

Maybe we should block this at Auth.pm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

--- Comment #4 from Lucas Gass  ---
(In reply to Christopher Brannon from comment #1)
> This also seems to be the case with SIP transactions.
> 
> I've restricted the anonymous account.

Christopher,

Can you file a separate bug outlining how you were able to do this via a SIP
transaction? 

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

--- Comment #3 from Lucas Gass  ---
Created attachment 165487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165487&action=edit
Bug 36679: Prevent SCO login for the AnonymousPatron

1. Make sure AutoSelfCheckAllowed is Allowed and AutoSelfCheckID and
AutoSelfCheckPass are in use.
2. Make sure AnonymousPatron is pointed to an account.
3. Set SelfCheckoutByLogin to cardnumber.
4. Verify that if you go to the anonymous patron account in the staff
interface, you cannot checkout items.
5. Go to the selfcheck path of the library.  It should auto login.  Put in the
cardnumber for the anonymous user.
6. Proceed to check out items!
7. APPLY PATCH, restart_all
8. Try step 5 again, you should not be able to log in as the AnonymousPatron.
Instead you should be redirected to OPAC home page
9. Switch SelfCheckoutByLogin to 'username and pasword'.
10. Again try to log in as the AnonymousPatron, you should not be able to.
11. Make sure you can login as a regular patron when SelfCheckoutByLogin is set
to 'cardnumber' and when it is set to 'username and pasword'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Severity|enhancement |normal
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36132] Allow users to delete multiple patron_lists at once on any page

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36132

Roman Dolny  changed:

   What|Removed |Added

 Attachment #162283|0   |1
is obsolete||

--- Comment #2 from Roman Dolny  ---
Created attachment 165486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165486&action=edit
Bug 36132: Allow to delete multiple patron lists on any page

Signed-off-by: Roman Dolny 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36132] Allow users to delete multiple patron_lists at once on any page

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36132

Roman Dolny  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36692] New: Add ability to subscribe a patron to a serial alert notice from patron account in staff interface.

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36692

Bug ID: 36692
   Summary: Add ability to subscribe a patron to a serial alert
notice from patron account in staff interface.
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently a patron must sign up for a serial alert from the OPAC. From the
staff interface I can navigate to a patron account and click on Subscription
Alert tab to see the serial alert subscriptions, but it is only possible to
unsubscribe a patron from an alert. It would be nice to be able to add an alert
as an option in the actions column. It would be nice to be able to do it from a
bibliographic record detail view as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

--- Comment #43 from David Nind  ---
(In reply to Aleisha Amohia from comment #42)
> Mmm I noticed that too, a bit weird and will definitely caused problems for
> users ... I'm not sure of a way around that except taking the 'IGNORE' out
> if 'INSERT IGNORE INTO' for the message_attributes update. What do you think?

Sorry, I don't know enough about database updates to comment with any real
understanding. Normally, I've only had to run the updatedatabase once for a
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36691] New: Serial Alert notice does not appear in patron notices tab

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36691

Bug ID: 36691
   Summary: Serial Alert notice does not appear in patron notices
tab
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:

1. Edit a serial subscription so that patron notification is set to New serial
issue.
2. Log in to the OPAC as a regular patron, search for the serial, and subscribe
to email notification on new issues.
3. Ensure there is text in the Serials_Alert email notice.
4. Ensure the patron account has an email address and process_message_queue.pl
is running.
5. Return to the serial and receive a new issue.

The patron should receive an email notice that a new issue is available. Check
the notices tab on the patron account and see the Serials Alert notice does not
appear.

Possibly a duplicate of Bug 12170.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36690] New: Force security on self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36690

Bug ID: 36690
   Summary: Force security on self check
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

I would suggest that if SelfCheckoutByLogin is set to cardnumber, that
SelfCheckAllowByIPRanges be enforced, and if the selfcheck is accessed at an IP
not listed in SelfCheckAllowByIPRanges, that SelfCheckoutByLogin ignore the
setting and act as if it is set to username/password.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

--- Comment #2 from Christopher Brannon  ---
1. Make sure AutoSelfCheckAllowed is Allowed and AutoSelfCheckID and
AutoSelfCheckPass are in use.
2. Make sure AnonymousPatron is pointed to an account.
3. Set SelfCheckoutByLogin to cardnumber.
4. Verify that if you go to the anonymous patron account in the staff
interface, you cannot checkout items.
5. Go to the selfcheck path of the library.  It should auto login.  Put in the
cardnumber for the anonymous user.
6. Proceed to check out items!

I would HIGHLY suggest preventing the account from using anonymous as the
cardnumber/username.

Koha should also block this patron from checking out, just like it does in the
staff interface.  Maybe it should just be automatically restricted account
indefinitely?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, us the default language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

Summary|If TranslateNotices is off, |If TranslateNotices is off,
   |use the interface language  |us the default language
   |includes in slips   |includes in slips

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36679] anonymous patron is not blocked from checkout via self check

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36679

--- Comment #1 from Christopher Brannon  ---
This also seems to be the case with SIP transactions.

I've restricted the anonymous account.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36689] New: SelfCheckAllowByIPRanges does not work

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36689

Bug ID: 36689
   Summary: SelfCheckAllowByIPRanges does not work
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

If I put our IP address in this setting, it does not work.  The self check just
defaults to the catalog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20813] Revamp user permissions system

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36559] Transport cost matrix update helpers

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36559

Katrin Fischer  changed:

   What|Removed |Added

Summary|Transport Cost Matrix   |Transport cost matrix
   |update helpers  |update helpers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36688] New: Rest API access on public side to IP field needed

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36688

Bug ID: 36688
   Summary: Rest API access on public side to IP field needed
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
CC: tomasco...@gmail.com

It would be extremely helpful if Rest API would allow us to look up the IP
field for a specified branch.  This would allow us to to branch specific
customizations when not logged in and perhaps at some point, self-check logins.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165265|0   |1
is obsolete||

--- Comment #14 from Lucas Gass  ---
Created attachment 165485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165485&action=edit
Bug 36182: Add booksellerid columns to holdings table

1) Apply patch, reset_all
2) Configure holdings_table, visit:
/cgi-bin/koha/admin/columns_settings.pl?module=catalogue&page=detail&table=holdings_table
3) Confirm holdings_booksellerid is there and is hidden by default
4) Visit a record:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
5) Edit one of the items and add a value to field 'e' Source of acquisition
5.5) You may need to click the 'show filters' link in order to have the
'Columns' table button show up
6) Go back to the record and click on the 'Columns' above the table
7) Click 'Source of acquisition'. Confirm it shows as expected

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26344] Move translatable strings out of templates into patrons.js

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26344

Owen Leonard  changed:

   What|Removed |Added

 Status|BLOCKED |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27354] Translate JavaScript in intranet-tmpl/js

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27354

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
The file at issue here, koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js, is
no longer there. I'm marking this invalid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26344] Move translatable strings out of templates into patrons.js

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26344
Bug 26344 depends on bug 27354, which changed state.

Bug 27354 Summary: Translate JavaScript in intranet-tmpl/js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27354

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

--- Comment #2 from Lucas Gass  ---
Created attachment 165484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165484&action=edit
Bug 36687: Schema changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

--- Comment #1 from Lucas Gass  ---
Created attachment 165483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165483&action=edit
Bug 36687: Update itemtpes.notforloan to not allow NULL values and change to
tinyint(1)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25682] Style transfers interface to match checkin page

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682

--- Comment #1 from Owen Leonard  ---
Created attachment 165482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165482&action=edit
Bug 25682: Style transfers interface to match checkin page

This patch updates the transfer page to make it better match the style
of the checkin page. The static dialog is converted to a modal for
consistency's sake, with information displaying as similarly as
possible to the checkin page. The library dropdown is now styled with
Select2.

To test, apply the patch and go to Circulation -> Transfers.

- Test some simple transfers: Items which are not checked out, some
  which are checked out.
- Test that the page's handling of items on hold matches current master
  (i.e. broken, see Bug 36686). Description of current behavior:

- Logged in to Branch A.
- Find a barcode for a title which has a biblio-level
  hold (not already in transit) to be sent to Branch B.

  - Submit transfer to Branch C.
- Three actions are offered:
  1. Transfer to Branch B
  2. Cancel hold and then attempt transfer
  3. Ignore and return to transfers

  Testing each of the three actions:
  1. The page says "Item is now in transit
 to Branch C (not the hold's destination)"
  2. The item is not in transit, and the hold
 has been changed to an item-level hold.
  3. Works correctly. No change to the hold
 and no transfer initiated.

- Logged in to Branch A.
- Find a barcode for a title which has a biblio-level
  hold (not already in transit) to be sent to Branch B.
  - Check in the item, confirm hold and transfer.

  - Submit transfer to Branch C.
- Two actions are offered:
  1. Cancel hold and then attempt transfer
  2. Ignore and return to transfers

  Testing each of the two actions:
  1. The page says "Reserve cancelled" (sic).
 The original transfer to Branch B is still
 in place.
  2. Works correctly. No change to the hold and
 the original transfer remains.

- Logged in to Branch D.
- Find a barcode for a title which has a biblio-level
  hold (not already in transit) to be held at Branch D.
  - Check in the item, confirm hold.

- Log in to Branch A.
  - Submit a transfer with that barcode to Branch C.
- Two actions are offered:
  1. Cancel hold and then attempt transfer
  2. Ignore and return to transfer.

  Testing each of the two actions:
  1. The page says "Reserve cancelled" (sic).
 The hold has been cancelled but the item
 has not been transferred.
  2. Works correctly. Hold remains unchanged,
 no transfer initiated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25682] Style transfers interface to match checkin page

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] New: itemtypes.notforloan should be tinyint and NOT NULL

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

Bug ID: 36687
   Summary: itemtypes.notforloan should be tinyint and NOT NULL
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

kohastructure says itemtypes.notforloan is "1 if the item is not for loan, 0 if
the item is available for loan". It is also defined as smallint(6).

Unlike items.notforloan it cannot be any other value than 0 or 1. 

I think this should be NOT NULL DEFAULT 0 and tinyint(1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36686] New: Problems with manual transfers

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36686

Bug ID: 36686
   Summary: Problems with manual transfers
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In testing my patch for Bug 25682 I'm finding several problems with item
transfers. In short, the handling of items with holds is completely broken:

- Logged in to Branch A.
- Find a barcode for a title which has a biblio-level
  hold (not already in transit) to be sent to Branch B.

  - Submit transfer to Branch C.
- Three actions are offered:
  1. Transfer to Branch B
  2. Cancel hold and then attempt transfer
  3. Ignore and return to transfers

  Testing each of the three actions:
  1. The page says "Item is now in transit
 to Branch C (not the hold's destination)"
  2. The item is not in transit, and the hold
 has been changed to an item-level hold.
  3. Works correctly. No change to the hold
 and no transfer initiated.

- Logged in to Branch A.
- Find a barcode for a title which has a biblio-level
  hold (not already in transit) to be sent to Branch B.
  - Check in the item, confirm hold and transfer.

  - Submit transfer to Branch C.
- Two actions are offered:
  1. Cancel hold and then attempt transfer
  2. Ignore and return to transfers

  Testing each of the two actions:
  1. The page says "Reserve cancelled" (sic).
 The original transfer to Branch B is still
 in place.
  2. Works correctly. No change to the hold and
 the original transfer remains.

- Logged in to Branch D.
- Find a barcode for a title which has a biblio-level
  hold (not already in transit) to be held at Branch D.
  - Check in the item, confirm hold.

- Log in to Branch A.
  - Submit a transfer with that barcode to Branch C.
- Two actions are offered:
  1. Cancel hold and then attempt transfer
  2. Ignore and return to transfer.

  Testing each of the two actions:
  1. The page says "Reserve cancelled" (sic).
 The hold has been cancelled but the item
 has not been transferred.
  2. Works correctly. Hold remains unchanged,
 no transfer initiated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36684] Cancelling an item with uncertain prices leaves the basket marked as a problem

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36684] Cancelling an item with uncertain prices leaves the basket marked as a problem

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684

--- Comment #1 from Laura Escamilla  ---
Created attachment 165481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165481&action=edit
Bug 36684: Prevent users from cancelling an order if it has uncertain prices

To test:
1. Create a basket
1. Add an item to the basket from an existing record
1. When adding the item, under accounting details select ā€œUncertain
priceā€. Save the item.
2. Notice that under the RRP tax exc. column the price has an
ā€œUncertainā€ label. Under the ā€˜Cancel orderā€™ column you also have the ability to
ā€œCancel orderā€
3. Cancel the order. A new ā€œCancelled ordersā€ table will appear under
the ā€œOrdersā€ table. The item in the ā€œCancelled ordersā€ table is greyed out and
does not show any information regarding the ā€œUncertain priceā€ label.
4. The basket remains a ā€œproblemā€ basket despite it not having any
active items with uncertain prices.
2. Apply the patch and restart_all
3. Create a new basket
1. Add an item to the basket from an existing record
1. When adding the item, under accounting details select ā€œUncertain
priceā€. Save the item.
2. Notice that under the RRP tax exc. column the price has an
ā€œUncertainā€ label.
3. Under the ā€˜Cancel orderā€™ column you now see a message that says,
ā€œCanā€™t cancel order because it contains uncertain prices.ā€
4. Click on the ā€œUncertain pricesā€ tab and uncheck the ā€˜Uncertainā€™ box.
Save and head back to your basket.
5. You are now able to ā€œCancel orderā€ since the item no longer has an
uncertain price.
2. Add a second item to the basket from an existing record.
1. Do not select ā€œUncertain priceā€. Save the item.
2. Under the ā€˜Cancel orderā€™ column you have the ability to ā€œCancel
orderā€
4. Sign off and have an amazing day! :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36684] Cancelling an item with uncertain prices leaves the basket marked as a problem

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684

Laura Escamilla  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #45 from Martin Renvoize  ---
I'm comfortable with this all now.. we have:

* Strong test coverage and don't require installation of translations
* Consistent behaviour across use cases
  - 'Default' = 'Top priority OPACLanguage' regardless of the interface used to
trigger the notice or whether it's a fallback to the default notice because a
localised version doesn't exist or TranslateNotices is disabled.
* Display of which language the default notice is expected to be written in.

Unit tests pass, QA scripts are happy and discussions have all reached
conclusion on Mattermost and here.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

--- Comment #44 from Martin Renvoize  ---
Created attachment 165480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165480&action=edit
Bug 33237: Move and simplify langauge selection logic

This patch moves the language selection into GetPreparedLetter, drops
the interface check step and ensures the default template always uses
the default include language as per the OPACLanguages settings.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

--- Comment #43 from Martin Renvoize  ---
Created attachment 165479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165479&action=edit
Bug 33237: Rearrange unit tests and ensure consistency

This patch re-arranges the unit tests and sets them to ensure we
consistently return the notice and notice includes in the same language.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165460|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 165478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165478&action=edit
Bug 33237: Add display of which language default language is expected

This patch adds the display of 'Default language' to the 'Default'
language in the notices editor tool.

This is so that librarians know which language they are expected to be
writing the notice in so we can remain consistent in both template and
include language used.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165459|0   |1
is obsolete||

--- Comment #41 from Martin Renvoize  ---
Created attachment 165477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165477&action=edit
Bug 33237: (QA follow-up) Clarify tests and Mock

This patch tries to clarify the tests a little and expand their
coverage whilst also adding some defualt translated includes to the test
area and mocking the config to allow the tests to run without installing
translations.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165458|0   |1
is obsolete||

--- Comment #40 from Martin Renvoize  ---
Created attachment 165476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165476&action=edit
Bug 33237: (follow-up) Restore final fallback

This restores the final fallback to 'en' as mentioned by Jonathan

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165457|0   |1
is obsolete||

--- Comment #39 from Martin Renvoize  ---
Created attachment 165475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165475&action=edit
Bug 33237: (follow-up) Unit tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165456|0   |1
is obsolete||

--- Comment #38 from Martin Renvoize  ---
Created attachment 165474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165474&action=edit
Bug 33237: (follow-up) Tidy

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33237] If TranslateNotices is off, use the interface language includes in slips

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165455|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 165473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165473&action=edit
Bug 33237: If TranslateNotices is off, use the interface language includes in
slips

This patch set the language used in slips folloinw this logic:
   --> uses patron's preferred language
   --> if patron's preferred language is 'default', use the interface language
   --> if there is no interface (for overdue_notices for example), use the
first language in 'language' system preference

To Test:
1. Install the other language (i used fr-CA here)
 1.1.

 gulp po:update fr-CA

 ./misc/translator/translate install fr-CA

 1.2. In Administration > Global system preferences, search for language
and check the added language

2. Create a manual invoice in a patron's account and pay it

3. From the Transactions tab, click 'Print' next to the payment line
   --> On the printed slip, there's the word 'Payment' in English (OK)

4. Switch interface to other language

5. Redo step 3
   --> On the printed slip, the word 'Payment' is still in English (not ok)

6. In Administration > Global system preferences, enable TranslateNotices

7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the
letter into all the languages

8. Redo step 3 (you should still be in the other language interface)
   --> On the printed slip, the word 'Payment' is still in English (not ok)

9. Edit the patron's account and change the preferred language to the other
language

10. Redo step 3
   --> On the printed slip, the word 'Payment' is in the other language
(Paiement) (OK)

11. Apply the patch

12. Reset config
12.1. Edit the patron's account and change back the preferred language to
'default'
12.2. In Administration > Global system preferences, disable
TranslateNotices

13. Redo step 3 (you should still be in the other language interface)
   --> On the printed slip, the word 'Payment' is in the other language
(Paiement)

14. Switch interface to the english language

15. Redo step 3
   --> On the printed slip, the word 'Payment' is in English

16. In Administration > Global system preferences, enable TranslateNotices

17. Edit the patron's account and change the preferred language to the other
language

18. Redo step 3
   --> On the printed slip, the word 'Payment' is in the other language
(Paiement)

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36685] New: Add ability to set display order of custom search filters

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36685

Bug ID: 36685
   Summary: Add ability to set display order of custom search
filters
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If you make a custom search filter ( SavedSearchFilters ) they are currently
order alphabetically. Some libraries would like the ability to set the display
order differently.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36684] New: Cancelling an item with uncertain prices leaves the basket marked as a problem

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36684

Bug ID: 36684
   Summary: Cancelling an item with uncertain prices leaves the
basket marked as a problem
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: laura.escami...@bywatersolutions.com
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Issue:
When a basket contains an item with an uncertain price, it is flagged as a
'problem.' Baskets cannot be finalized if they include items with uncertain
prices. However, if you cancel an order for an item with an uncertain price,
the basket still remains marked as a 'problem,' but it can be closed out. This
situation might confuse some users who may wonder why their basket is labeled
as a problem. This confusion arises because the active items do not display
uncertain prices, and there is no way to ascertain whether canceled items were
initially marked as uncertain before their cancellation.

Suggested resolution:
Prevent users from cancelling items with uncertain prices until the uncertain
price is cleared/resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34478] Full CSRF protection

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||36683

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33905] Username and cardnumber should be unique respectively

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33905

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14323,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36575

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5463] Limit to available shows on hold items

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292

--- Comment #16 from Owen Leonard  ---
I think this is still worth fixing. It makes sense to me that if you check in
an item from another library and ignore the hold that it should behave as if
you'd checked in an item from another library without a hold.

Maybe with a different button text, "Ignore hold and transfer to " ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503

--- Comment #15 from Michaela Sieber  ---
(In reply to David Cook from comment #11)
> Hmm... wouldn't it make more sense to run this plugin just before returning? 
> 
> That way you could also have access to the $domain, and you'd have access to
> the default values coming from the domain in the $mapped_data.
> 
> Otherwise, if you tried to change the categorycode/branchcode based on IdP
> data for a new patron, you wouldn't be able to do it. 
> 
> I won't mark as Failed QA yet, but I'm curious.

Hi David, 
thanks for your feedback. As you can see Raphael has added a follow-up patch.
We would be very glad if you could do QA and this hook would be in version
24.05 :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35721] Replace ModItemTransfer calls in circ/returns.pl

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35721

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |Main
 Status|BLOCKED |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30657] Make patron attributes available via Template Toolkit in overdues

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657

--- Comment #11 from Lucas Gass  ---
A real world example I had to cook up for a HOLD_SLIP:

[% SET alt_id = '' %]
[% FOREACH ba IN borrower.extended_attributes %]
 [% IF ba.code == 'UNCLE' %]
  [% alt_id = ba.attribute %]
 [% END %]
[% END %]

[% IF alt_id == 'BOB' %]
Warning: Bob is your uncle.
[% ELSE %]
Warning: Bob is NOT your uncle.
[% END %]


Would be nice to make it a bit easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16131] Messages for branch transfers show with bullet points

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16131

Owen Leonard  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25682] Style transfers interface to match checkin page

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27028

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27028] Manual transfers: patron name display in hold warning should be standardized

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27028

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25682

--- Comment #2 from Owen Leonard  ---
I'm working on a patch for Bug 25682 which I think will solve this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26794] Item transfer modal may close automatically after a delay

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26794

--- Comment #2 from Owen Leonard  ---
This seems like a very specific set of circumstances. Aren't there lots of
possible modal instances that require keyboard or mouse interaction?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

--- Comment #8 from Owen Leonard  ---
What I'm seeing is that if I transfer a random item (no holds) multiple times I
see multiple entries in the branchtransfers table.

The same is not true of an item which is on hold and has already been
transferred. However, if you transfer an on-hold item which is already in
transit you get these choices:

 - Cancel hold and then attempt transfer
 - Ignore and return to transfers

I think that makes it clear that the original transfer is going to stay in
place if you choose to "Ignore."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139

--- Comment #15 from Michael Hafen  ---
This patch must NOT be back ported to 23.05.x. these changes are already in
that branch due to a mistake on my part. There is a note on the parent bug
about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36197] Allow for OPAC unauthenticated ILL request

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197

Pedro Amorim  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch
   Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co
   |ity.org |m
   Severity|enhancement |new feature

--- Comment #1 from Pedro Amorim  ---
This is ready for testing. Branch at:
https://github.com/PTFS-Europe/koha/commits/b_36197

0) If k-t-d, run updatedatabase (ignore this if testing on a sandbox)
1) Enable ILLModule syspref:
 
{staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModule
2) No need to install a backend as 35570 is in the tree
3) On a different browser session, without being lgoged in, access the create
ILL request OPAC page directly:
  {opac_url}/cgi-bin/koha/opac-illrequests.pl?method=create&backend=Standard
4) Notice you're presented with the login page, as expected
5) Enable ILLOpacUnauthenticatedRequest:
 
{staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLOpacUnauthenticatedRequest
6) Repeat step 3) Notice you now get the create ILL request form, with some
additional inputs at the top specific to an unauthenticated request (first
name, last name, e-mail address)
6.5) (optional) Confirm the 'Make an Interlibrary loan request' link exists at
the bottom of the search results page, while unauthenticated on OPAC:
  {opac_url}/cgi-bin/koha/opac-search.pl?idx=&q=music&weight_search=1
  This should only show for authenticated OPAC users if
ILLOpacUnauthenticatedRequest is off.
7) Test the form, try submitting with some blank fields, change type and
library after and before inputing data in the input fields, etc.
8) Submit the form successfully. Notice you're presented with the
unauthenticated request submission confirmation screen with a message and
request details.
9) Go back to Staff UI, logged in, access ILL requests and confirm the
unauthenticated request submitted through the OPAC is there:
  {staff_url}/cgi-bin/koha/ill/ill-requests.pl
10) Test that you can add a patron afterwards, if needed, by clicking 'Edit
request' on the toolbar of the manage request page, and entering a patron ID
11) Test that you're able to 'confirm' the request by clicking 'Confirm
request', as if it was a regular 'NEW' request.

Additional testing:
 Make sure existing ILL functionality interacts with this new optional workflow
behavior.
 For this, we're using ILLModuleDisclaimerByType. ILLCheckAvailability or
AutoILLBackendPriority can also be used but require more setup (plugins,
credentials, etc)
1) Configure ILLModuleDisclaimerByType, visit
 
{staff_url}/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType
2) Click the 'edit' link at the bottom of the syspref and copy the example code
from the description into the text box. Save.
3) Repeat the original test plan from above, but make sure the request type is
not 'article' (as that type is bypassed). Use 'journal', for example. Submit
the request making sure you fill in all mandatory fields.
4) Notice you're now presented with the ILL request disclaimer screen, hit
Submit. Notice the request is created as before.
5) Return to Staff UI, logged in, confirm this 2nd unauthenticated request has
been created and the type disclaimer info is stored and presented when viewing
the request.

Run tests (k-t-d only):
  prove t/db_dependent/Koha/ILL/Backends.t
  prove t/db_dependent/selenium/opac_ill_requests.t
  prove t/lib/plugins/Koha/Plugin/ILL/TestPlugin.pm

Sponsored-by: NHS England (National Health Service England)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36197] Allow for OPAC unauthenticated ILL request

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36197

Pedro Amorim  changed:

   What|Removed |Added

 CC||andrew.a...@ptfs-europe.com
   ||, mag...@libriotech.no,
   ||michaela.sie...@kit.edu
   Keywords||Sandbox

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503

--- Comment #14 from Raphael Straub  ---
Created attachment 165466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165466&action=edit
Bug 36503: (follow-up) Move the plugin hook to include the domain

This allows the plugin to read/change the domain.

Sponsored-by: Karlsruhe Institute of Technology (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36682] Replace yarn with pnpm

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36682

Paul Derscheid  changed:

   What|Removed |Added

 CC||m...@paulderscheid.xyz
Version|unspecified |Main

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36682] New: Replace yarn with pnpm

2024-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36682

Bug ID: 36682
   Summary: Replace yarn with pnpm
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@paulderscheid.xyz
QA Contact: testo...@bugs.koha-community.org

The idea is to deprecate yarn in favor of pnpm as it offers
- better disk space efficiency
- speed (compared to yarn)
- deterministic installs
- stricter dependency isolation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >