[Koha-bugs] [Bug 35689] Add id and classes to each MARC note in OPAC bibliographic details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35689 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement adds id|This enhancement adds id release notes|and class tags to each MARC |and class attributes to |note in the description tab |each MARC note in the |for the OPAC bibliographic |description tab for the |detail page. |OPAC bibliographic detail | |page. |It adds a | |unique id for each note |It adds a unique id |(for unique styling of each |for each note (for unique |repeated tag), and a|styling of each repeated |general and unique class|tag), and a general and |for each tag (for |unique class for each tag |consistent styling across |(for consistent styling |the same tag number). An|across the same tag |example of the HTML output: |number). An example of the | |HTML output: |``` |``` |... |class="marcnote |``` |marcnote-500">... |Styles can be defined for |``` |notes and individual tags |Styles can be defined for |in the `OPACUserCSS` system |notes and individual tags |preference - see the test |in the `OPACUserCSS` system |plan for an example.|preference - see the test ||plan for an example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34032] Holds expirationdate left blank if waiting status is reverted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34032 --- Comment #25 from Katrin Fischer --- Kyle, you forgot to add your sign-off lines :) Also re-tidied Holds.t for the QA script - maybe different versions of Perltidy at work here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
Keywords||rel_24_05_candidate
--- Comment #23 from Katrin Fischer ---
I really want this for 24.05, please help me make it happen:
1) Failing unit test (blocker)
It looks like you forgot to adjust the t/db_dependent/Koha_Elasticsearch.t to
the new name of the method. I tried to fix it, but even after changing the
method names the test still keeps failing. I think some more is needed. Please
provide a follow-up ASAP.
2) Labels cannot be edited (blocker)
The test plan states:
"Librarians can then add/remove facet fields and modify their label."
But I haven't been able to update the label for my own custom facets. The field
remains "locked" and doesn't ever appear as an input field.
Tiny things I had fixed on my branch:
3) The database update is missing a success message. I had used:
+say $out "Updated DisplayLibraryFacets and search field
configuration";
4) Tiny typo: exist -> exists
-alert(__("SearchField '%s' already
exist".format(search_field_name)));
+alert(__("SearchField '%s' already
exists".format(search_field_name)));
For a separate bug maybe:
?) Show delete button only after saving?
At the moment the delete button shows for a newly added field, but it doesn't
work. I think it would make sense to hide it, until the page has been saved.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36565] Fix API docs inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565 --- Comment #29 from Katrin Fischer --- Thanks for the quick rebase :) Could we have a test plan to see the changes in action? (not blocker) I managed in the past, but it might be good to have it available somewhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35856] Runtime parameter modal should provide option of ":all"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate |additional_work_needed, ||release-notes-needed --- Comment #13 from Katrin Fischer --- I struggle a tiny bit with the phrasing "Query expression". Hm, but what to write instead? A suggestion: Query condition must use ... operator. What do you think? (setting additional_work_needed to highlight the question) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 --- Comment #17 from Katrin Fischer --- Always so happy about the accompanying unit tests, Nick. You are a star :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33092] Add ability to search within a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33092 --- Comment #5 from Katrin Fischer --- Maybe it would be enough to use a datatables based search here instead of the full search engine one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Clemens Tubach changed: What|Removed |Added CC||clemens.tub...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36151] Update leaflet.js to current version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36151 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #14 from David Cook --- Firstly, thanks for working on this. It hasn't been a priority for me, so it's cool to see someone else take up the thread. Secondly, I'm not sure if you're still working on this, but if you are ready to submit, I'd have to mark this as "Failed QA". 1. You'll need to add the syspref to ./installer/data/mysql/mandatory/sysprefs.sql as well 2. You'll want to use camel case instead of snake case. While there are about 7 snake case there are 827 camel case sysprefs. 3. I'd suggest using HttpForwardProxy as the system preference name just to be as explicit as possible 4. I think that we'd only want to show the "Do not use proxy" on z3950servers.tt *if* HttpForwardProxy is defined. Otherwise, it's going to be meaningless/confusing for 99.99% of users 5. Instead of "not_proxy" we might want to say "do_not_use_proxy" or "no_foward_proxy". They're more verbose, but they're also more descriptive. 6. In Breeding.pm, technically I don't think you'd want to use the "g" option, and you should preface "http" with a ^ so that it matches the start of the string. Your regex would probably be fine in the majority of cases, but I think it wouldn't hurt to be more specific. -- Otherwise I think all good -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #66 from David Nind --- (In reply to Aleisha Amohia from comment #65) > (In reply to David Nind from comment #63) > > I could not test steps 5-13 (Tools > Notices management) because I get these > > errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF > > protection) (other steps all work as expected): > > > > Thanks for testing David, I believe I have addressed these errors in the > latest follow up. Thanks Aleisha for updating! The patron search block on the notices management tool page is now working. However, for the search filters on the left, I'm still getting an error when clicking on 'Search': An error has occurred! Error 403 Programming error - op 'search' must start with 'cud-' for POST http://127.0.0.1:8081/intranet/tools/notices.pl (referer: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27423] ILS-DI should be deprecated and functions moved to REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27423 --- Comment #18 from David Cook --- (In reply to Nick Clemens from comment #17) > (In reply to David Cook from comment #16) > > @Nick, did you guys come up with anything in the end? > > Nothing directly, really we have just indicated a preference for the API, > and work with vendors to use the APi over ILS-DI where we can. > > We now have CRUD for biblios/items - so harvesting/get 'can' be done that way > Patron API provides most of the functionality > renewals and holds can be done via API > > We would need to dig a bit to make sure functionality is 1:1, but we are > closed than we were I've noticed that the Patron API provides a lot of the functionality, although it also provides a lot more privilege than the ILS-DI did at the patron level, which makes me a bit uncomfortable. Are you using the REST API for authentication/validation now instead of ILS-DI? I'm hoping to change the permission for that to be more restrictive (bug 36561). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #16 from David Cook --- (In reply to Raphael Straub from comment #13) > In our use case having access to the domain is not necessary, but calling > the hook before $patron->…->store with the domain as an additional argument > could be a good idea. Then the plugin might modify $domain->update_on_auth, > $domain->default_category_id or $domain->default_library_id. The more I look at Koha::Auth::Client, the more I think the already existing approach has its flaws (like arbitrarily setting the branchcode and categorycode in the $mapped_data at the end of get_user()... I think that's probably a bug in the current implementation). -- Could you describe your use case more? I know someone who might be interested in this as well, so I'd like to get more feedback... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 --- Comment #33 from Aleisha Amohia --- Created attachment 165719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165719&action=edit Bug 32256: Handle batch error messages better This enhancement modifies the self-checkout script to better handle 'impossible' and 'needs confirmation' checkout messages. Test with a combination of barcodes that would invoke these messages, for example: - impossible: barcode doesn't exist - impossible: barcode is for a 'notforloan' item type - impossible: debt - needs confirmation: barcode already checked out, i.e. confirm renewal Include barcodes that should have successful checkouts too. Also, test with the following sysprefs: - BatchCheckouts: enabled - BatchCheckoutsValidCategories: none selected Confirm SCO does not have a multi-line text area for more than one barcode, and doesn't accept more than one barcode. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32256] Self checkout batch mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 David Nind changed: What|Removed |Added Attachment #165713|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 165718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165718&action=edit Bug 36561: Add "validate_borrowers" permission for /api/v1/auth/password/validation This change adds a "validate_borrowers" permission which allows a user to only validate borrowers by using the /api/v1/auth/password/validation endpoint. This avoids scenarios where you want third-parties to authenticate a user without giving them full permissions to perform CRUD operations on user data. To test: 1. Apply patch 2. Run "koha-upgrade-schema kohadev" 3. koha-plack --reload kohadev 4. prove -v t/db_dependent/api/v1/password_validation.t 5. Visit http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=51 6. Note that a new subpermission "validate_borrowers" appears under the "borrowers" permission Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #65 from Aleisha Amohia --- (In reply to David Nind from comment #63) > I could not test steps 5-13 (Tools > Notices management) because I get these > errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF > protection) (other steps all work as expected): > Thanks for testing David, I believe I have addressed these errors in the latest follow up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #64 from Aleisha Amohia --- Created attachment 165717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165717&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- The only thing I noticed, and I wasn't sure whether this it is what is expected or not: 1. Without entering a search term, if I select 'Suggested by anyone' it displays everyone else's suggestions - but not mine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 David Nind changed: What|Removed |Added Attachment #162061|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 165714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165714&action=edit Bug 36045: Use DataTables filter for suggestions search This patch removes the server-side suggestions search form and related code from the OPAC suggestions page. In its place is a DataTables filter form and a custom dropdown to replace the "suggested by me/anyone" option from the old search. To test you should have some suggestions in your system submitted by two or more users. - Apply the patch and rebuild the OPAC CSS. - Go to Administration -> System preferences and set the "OPACViewOthersSuggestions" preference to "Show." - Log in to the OPAC as one of the users who has submitted suggetions. - Go to the purchase suggestions page. - The initial view should be of "your" suggestions. - The dropdown filter at the top should have "Suggested by me" selected. - The "Clear filter" button should be disabled. - Test that the "Suggested by me" dropdown works to change what's shown in the table. - The "Clear filter" button should be enabled when you choose "Suggested by anyone." - The DataTables "Search" field should work correctly with either setting of the "Suggested by..." dropdown. - Go back to Administration in the staff interface and disable the "OPACViewOthersSuggestions" preference. - Return to the suggestions page in the OPAC. - You should see only your suggestions, and the "Suggested by..." dropdown should not be there. - Confirm that filtering still works correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 David Cook changed: What|Removed |Added Attachment #165447|0 |1 is obsolete|| --- Comment #7 from David Cook --- Created attachment 165713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165713&action=edit Bug 36561: Add "validate_borrowers" permission for /api/v1/auth/password/validation This change adds a "validate_borrowers" permission which allows a user to only validate borrowers by using the /api/v1/auth/password/validation endpoint. This avoids scenarios where you want third-parties to authenticate a user without giving them full permissions to perform CRUD operations on user data. To test: 1. Apply patch 2. Run "koha-upgrade-schema kohadev" 3. koha-plack --reload kohadev 4. prove -v t/db_dependent/api/v1/password_validation.t 5. Visit http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=51 6. Note that a new subpermission "validate_borrowers" appears under the "borrowers" permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 --- Comment #6 from David Cook --- (In reply to David Nind from comment #5) > I'm not seeing the permission. All I see under "Add, modify and view patron > information (borrowers)" are: Thanks, David! It looks like I missed adding the database update to the commit! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31345] Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | Status|Signed Off |Passed QA --- Comment #10 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) --- Fixed commit message format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31345] Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Attachment #161952|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31345] Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345 --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 165712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165712&action=edit Bug 31345: Add ability to exit process_message_queue.pl early if any plugin before_send_messages hook fails Sometimes it would be better for process_message_queue.pl to stop if a plugin hook fails rather than continue processing. It would be nice if that was a command line option. Test Plan: 1) Install any plugin with a before_send_messages hook 2) Modify the plugin, add a 'die;' statement at the start of the before_send_messages method of the plugin. 3) Run process_message_queue.pl as usual 4) Note the exit code is 0 5) Run it again with the new -e setting 6) Note the exit code is 1 Signed-off-by: Brendan Lawlor Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676 --- Comment #7 from David Nind --- I can't currently get the SIP emulator to work in KTD (when on main). I'll come back to this one (and other SIP bugs) once I get it working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- Just a note - this bug is dependent on bug 36063, which currently doesn't apply (and is also currently Failed QA). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33092] Add ability to search within a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33092 --- Comment #4 from David Cook --- This also means that changes to lists would require re-indexing records. Refactoring all the list code could take a fair bit of work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33092] Add ability to search within a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33092 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- If I understand the above commenters, you would want to search a list like you search the catalogue? However, the catalogue search is done by the search engine, while lists are managed only in the database. Technically, with few changes, you could create a search query that contains every record in a list by including every biblionumber for every record in the list in a query, but large lists would create very large query lengths, which might even be too long for the search engine to manage. A more robust change would be to add lists to the search engine. This would mean storing the list ID in the actual bibliographic record itself. Since a bib record can belong to many lists, this would need to be a repeatable subfield. This subfield would then be added to search engine indexes. I suppose something like the 999$l (lowercase l) could be used, but I don’t know if other Koha community developers would be agreeable to that solution. Alternatively, an Elasticsearch only solution could probably be developed that doesn’t require changing the MARC, but again I don’t know if anyone would be agreeable to that solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35197] Expose additional_field definitions through REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 --- Comment #16 from Victor Grousset/tuxayo --- There is no 404 case, it returns [ ] if tablename doesn't match an existing one. Leaving that info for someone QAing the functional side to tell if that's expected here. --- The param tablename should be table_name I think. That's what is shown from the examples here: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER4.2:_Using_query_parameters_to_find_the_required_objects They diverge from the DB and for city_id, it's not for terminology reason, it seems to be just to follow snake_case. And the JSON of the response has the key `table_name` --- Otherwise all seems conformant to the guidelines. --- Is the enhancement sponsored BTW? (QA script asks this now) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652
--- Comment #34 from David Nind ---
Hi Thomas.
I can confirm the bug now applies!
I had a go at testing (not that this is required, as it has already passed QA).
Things I noted:
- database update required after applying the patch
- also needed to reset the Elasticsearch mappings
- I didn't get any search results in the OPAC
- wasn't sure how to install the HKS3GeoSearch plugin
Here are my testing notes (using KTD):
1. Start up KTD with Elasticsearch: ktd --es7 up
2. Apply the patch
3. Update the database: updatedatabase
4. Restart everything
5. Edit the books framework and make 034$s and 034$t visible in the editor
6. Add example coordinates for a couple of records (I added lat=48.216 and
lon=16.395 to records 262 and 126)
7. Reset the Elasticsearch mappings (Administration > Catalog > Search engine
configuration (Elasticsearch) > Reset mappings)
8. Rebuild the search index: koha-elasticsearch --rebuild -d -b -a kohadev
9. Check if indexing working: curl
http://es:9200/koha_kohadev_biblios/_doc/123?pretty | grep -A5 geolocation
- The result I got:
curl http://es:9200/koha_kohadev_biblios/_doc/262?pretty | grep -A5 geolocation
% Total% Received % Xferd Average Speed TimeTime Time Current
Dload Upload Total SpentLeft Speed
100 1078"geolocation" : [ 0 0 0 --:--:-- --:--:-- --:--:-- 0
3 {
"lon" : "16.395",
"lat" : "48.216"
1 }
0],
0 107830 0 2164k 0 --:--:-- --:--:-- --:--:-- 2632k
10. Query Elasticsearch directly:
- Result:
curl -X GET "http://es:9200/koha_kohadev_biblios/_search?pretty"; -H
'Content-Type: application/json' -d '{"query":
{"bool":{"must":{"match_all":{}},"filter":{"geo_distance":{"distance":10,"geolocation":{"lat":48.2,"lon":16.4}}'
{
A lot of information returned - basically the details for the two records that
I added the coordinates to.
...
}
11. OPAC query:
http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?advsearch=1&idx=geolocation&q=lat:48.25+lng:18.35+distance:100km&do=Search
- Puts details in the search field: lat:48.25 lng:18.35 distance:100km
- Results displayed:
No results found!
No results found for that in catalog.
12. HKS3GeoSearch Koha Plugin:
- No release available. Does this mean I have to clone the repository into the
plugins folder? (I tried cloning the repository into
/var/lib/koha/kohadev/plugins, but nothing appears in the list of plugins.)
David
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #54 from David Nind --- Testing notes (using KTD): 1. Edited the Books framework to make 856$h visible in the editor 2. Edited Programming Perl (biblionumber=262) to add two entries: Entry 1: . 856$h = https://example.com . 856$y = Non-functioning URL Entry 2: . 856$u = https://example.com . 856$y = Functioning URL 3. Before the patch, clicking on the non-functional URL link opens a blank page. The staff interface and OPAC search result and detail pages all display: Online resources: Non-functioning URL | Functioning URL 4. After the patch: 4.1 The non-functioning URL is no longer displayed: Online resources: Functioning URL 4.2 If there is only one 856 entry AND it has an $h, then 'Online resources' information is no longer displayed in any of the search result or detail pages. (As expected.) 4.3 If a single entry has both an 856$h and an 856$y, it is not displayed. (As expected.) (My reading of the 856 information indicates you shouldn't do this. That is, every URL (whether $h or $u) should have a separate 856 entry.) 4.4 If there is a $u and no $y subfield, then the text displayed in the search result and detail pages is: Online resources: Click here to access online -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Thomas Klausner changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #33 from Thomas Klausner --- I obsolted the old patch, now git bz works again: kohadev-koha@kohadevbox:koha(another_31652_try)$ git bz apply 31652 Bug 31652 - Add geo-search 165708 - Bug 31652: Add geo-search Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31652: Add geo-search Please try again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Thomas Klausner changed: What|Removed |Added Attachment #164690|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #165688|0 |1 is obsolete|| --- Comment #53 from David Nind --- Created attachment 165711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165711&action=edit Bug 36111: online resource link should be based on the presence of 856 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #165356|0 |1 is obsolete|| --- Comment #52 from David Nind --- Created attachment 165710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165710&action=edit Bug 36111: fixed extra space Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Attachment #165355|0 |1 is obsolete|| --- Comment #51 from David Nind --- Created attachment 165709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165709&action=edit Bug 36111: 856$h should not appear as a link in detailed record Test plan: 1. Add 856$h to MARC editor 1.1. Go to Administration > MARC bibliographic frameworks 1.2. Next to Default framework, click Actions > MARC structure 1.3. Search for field 856 1.4. Click Actions > Edit subfields 1.5. Click h 1.6. Check the Editor box 1.7. Click Save changes 2. Catalog a new record with a random URL in 856$h 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c, 245$a, 942$c) 2.4. Go to tab 8 and enter a value in 856$h 2.5. Click Save (No need to add an item) 3. Search for the title in the staff interface (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 3.1. Try to click the link --> Blank page 4. Access the detailed record in the staff interface --> Notice it says "Online resources: Click here to access online" 4.1. Try to click the link --> Blank page 5. Search for the title in the opac (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 5.1. Try to click the link --> Blank page 6. Access the detailed record in the opac --> Notice it says "Online resources: Click here to access online" 6.1. Try to click the link --> Blank page 7. Edit the item and add a text in field 856$y 8. Access the detailed record in the staff interface --> Notice it says what you put in 856$y field 9. Apply the patch 10. Replay steps 3 through 6, but this time, the "Online resources" field should not be present. 11. Replay steps 7 through 8, but this time, what you put in 856$y field should not be present. 12. Edit the item and add a url in field 856$u 13. Replay steps 3 through 6, but this time, clicking on the link should take you to the URL specified in the 856$u field. 14. Replay steps 7 through 8, but this time, what you put in 856$y field should be present and clicking on the link should take you to the URL specified in the 856$u field. Signed-off-by: Roman Dolny Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 --- Comment #32 from David Nind --- (In reply to Thomas Klausner from comment #31) > When creating the current patch, I did a rebase on the fresh main and > squashed the three commits (original, "(follow-up)" and my fixes according > to Katrins comment) into one commit. > > So there should only be one patch: > Bug 31652: Add geo-search (14.16 KB, patch) > 2024-04-27 16:58 UTC, Thomas Klausner > > > Not sure how/if I can obsolte this one: > Bug 31652: (follow-up) Fix update and remove fixed fixme (2.72 KB, patch) > 2024-04-11 13:19 UTC, Nick Clemens > > Or if it is possible (or how to do it) to tell git bz to only use my > rebased/squashed patch You can obsolete the patch from Bugzilla: 1. Under the attachments section, click the 'Details' link beside the patch to obsolete. 2. In the title/header for the patch, click 'Edit details' again. 3. Click the tick box beside 'obsolete'. 4. Add a comment. 5. Click 'Submit'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 --- Comment #31 from Thomas Klausner --- When creating the current patch, I did a rebase on the fresh main and squashed the three commits (original, "(follow-up)" and my fixes according to Katrins comment) into one commit. So there should only be one patch: Bug 31652: Add geo-search (14.16 KB, patch) 2024-04-27 16:58 UTC, Thomas Klausner Not sure how/if I can obsolte this one: Bug 31652: (follow-up) Fix update and remove fixed fixme (2.72 KB, patch) 2024-04-11 13:19 UTC, Nick Clemens Or if it is possible (or how to do it) to tell git bz to only use my rebased/squashed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 --- Comment #30 from David Nind --- (In reply to Katrin Fischer from comment #29) > I think the patch sequence is wrong now. I was going to do 2 git bz apply -i > here to fix on applying. I tried that, but it didn't work for me 8-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 --- Comment #29 from Katrin Fischer --- I think the patch sequence is wrong now. I was going to do 2 git bz apply -i here to fix on applying. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
