[Koha-bugs] [Bug 36729] New: Add Publisher/Distributor Number to advanced search dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36729 Bug ID: 36729 Summary: Add Publisher/Distributor Number to advanced search dropdown Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz 028 is already mapped to an index called identifier-publisher-for-music It would be good to have this index available in the advanced search dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36728] New: Add cancelled/valid standard number to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36728 Bug ID: 36728 Summary: Add cancelled/valid standard number to Elasticsearch index mappings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz Can currently search on the identifier-other with the 024$a mapping It would be useful to have another index on the invalid-identifier-other mapping to the 024$z only https://www.loc.gov/marc/bibliographic/bd024.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36727] New: Add incorrect ISSN to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36727 Bug ID: 36727 Summary: Add incorrect ISSN to Elasticsearch index mappings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz Can currently search on the issn with the 022$a mapping It would be useful to have another index on the incorrect-issn mapping to the 022$y only https://www.loc.gov/marc/bibliographic/bd022.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36726] New: Add invalid ISBN to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36726 Bug ID: 36726 Summary: Add invalid ISBN to Elasticsearch index mappings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz Can currently search on the isbn with the 020$a mapping It would be useful to have another index on the invalid-isbn mapping to the 020$z only https://www.loc.gov/marc/bibliographic/bd020.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net |y.org | CC||vic...@tuxayo.net Status|Signed Off |Failed QA --- Comment #6 from Victor Grousset/tuxayo --- The first attempt, the selected text in a subfield has a 1 second latency before highlighting text selected. (auth and biblios so it's from Bug 35383) That's weird but not blocking. (In reply to Andrii Nugged from comment #3) > Note: there was related issue: Bug 35383, solved differently, but I think we > should analyze how to make "common", unified solution with same coding style Good point, I had issues testing and when it worked, I forgot about this and attached a second signoff (it's just a 2nd signoff, it's valid). Back to this remark, for QA that's an issue because copying the change of bug 35425 is introducing duplication. initializeSortable() is totally duplicated and even the calls to it would benefit from being in the same place for biblios and auths to be sure that if those for on editor are changed, the others are. cataloging.js is included in addbiblio.tt and authorities.tt so unless something unexpected, moving the js change from addbiblio.tt and authorities.tt to cataloging.js should work. And then it's possible to solve the duplication of when cloning a field in cataloging.js. Because that part has the same code as initializeSortable() I don't know if it was noticed in bug 35425 that duplication was introduced, but it was it might have been ok to not bother. But now it's a third time duplication, see rule of three: https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36725] New: Add Current publication frequency to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36725 Bug ID: 36725 Summary: Add Current publication frequency to Elasticsearch index mappings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz https://www.loc.gov/marc/bibliographic/bd310.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36724] New: Add cartographic mathematical data to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36724 Bug ID: 36724 Summary: Add cartographic mathematical data to Elasticsearch index mappings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz Search whole 255 field https://www.loc.gov/marc/bibliographic/bd255.html Test with values like * Scale 1:22,000,000 * Conic proj. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] New: Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 Bug ID: 36723 Summary: Add musical presentation to Elasticsearch index mappings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz https://www.loc.gov/marc/bibliographic/bd254.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #6 from David Cook --- Note that /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df and api/swagger-v2-schema.json are the same... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #5 from David Cook --- If I force JSON::Validator::Store into debug mode, it does look like it's downloading it during the resolving process... [JSON::Validator] Resolve curr: ref=http://json-schema.org/draft-04/schema#/properties/description,base_url=http://swagger.io/v2/schema.json fragment= id=http://swagger.io/v2/schema.json root=HASH(0x55d20f974060) schema=HASH(0x55d20f9740 60) source=load [JSON::Validator] Resolve state: base_url=http://json-schema.org/draft-04/schema fragment=/definitions/stringArray id=http://json-schema.org/draft-04/schema root=HASH(0x55d2057e4a40) schema=HASH(0x55d20f702f40) source=schema/base_url I'm starting to think that bug 30194 actually made no difference here... -- [JSON::Validator] Load from cache /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df [JSON::Validator] Load from URL http://json-schema.org/draft-04/schema And Koha can't add json-schema.org to the cache, because Koha doesn't have write access to /usr/share/perl5/JSON/Validator/cache... 36d1bd12eeed51e86c8695bd8876a9df is the cached version of the http://swagger.io/v2/schema.json file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36388] Mouse operation does not work in draggable fields in authority editor (with Firefox)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36388 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #163652|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 165825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165825=edit Bug 36388: Mouse operation does not work in draggable fields in authority editor When using the authority editor in Firefox, it is not possible to set the cursor or select text from the text field. This patch mimics the corrections made in bug 35425 for biblio editor. Test plan: == 1. Start editing an existing authority record and try to put the cursor with the mouse in the middle of the content of any subfield or to select text with the mouse. It should not be possilbe. 2. Apply the patch (reload plack etc.). 3. Repeat p. 1 - everything should work as expected. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #4 from David Cook --- And now I'm extra confused... because JSON::Validator::Schema::OpenAPIv2 has a specification of http://swagger.io/v2/schema.json but http://json-schema.org/draft-04/schema# is what's being downloaded... I suppose because the $schema for http://swagger.io/v2/schema.json is http://json-schema.org/draft-04/schema# -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #3 from David Cook --- Looks like JSON::Validator isn't caching files unless JSON_VALIDATOR_CACHE_PATH is defined... It did cache when I changed koha-plack to do this: if JSON_VALIDATOR_CACHE_PATH=/opt/cache ${STARMAN} ${STARMANOPTS}; then -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #2 from David Cook --- Note an easy way to prove this is to run the following: Window 1: sudo tcpdump -A -i any 'host json-schema.org' Window 2: sudo koha-plack --restart kohadev -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 David Cook changed: What|Removed |Added Blocks||36722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 [Bug 36722] REST API won't work if json-schema.org is down -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 David Cook changed: What|Removed |Added Depends on||30194 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 [Bug 30194] Update required JSON::Validator version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #1 from David Cook --- Note also that JSON::Validator::Schema::Draft4 used by JSON::Validator::Schema::OpenAPIv2 is set to http://json-schema.org/draft-04/schema# which redirects to the HTTPS version, so every worker does 2 web requests to it on startup. Yikes... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||"Holds with cancellation ||requests: X" link to the ||staff interface home page. ||This makes it more visible ||to librarians that patrons ||have made cancellation ||requests, and action them ||(where patrons have the ||ability to cancel holds). --- Comment #19 from David Nind --- Testing notes (using KTD): 1. Enable patrons to cancel hold requests: 1.1 Go to Administration > Circulation and fine rules > Default waiting hold cancellation policy 1.2 For All and All set cancellation allowed to Yes and click +Add 2. Have some patron hold cancellation requests: 2.1 Log in as the patron you created the holds for (change their username and password) 2.2 In the OPAC under Summary > Holds, click 'Request to cancel' for one of the waiting holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Attachment #165810|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 165824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165824=edit Bug 36064: (follow-up) Activate correct tab This patch makes a change to the JavaScript on waitingreserves.pl so that the correct tab is activated if you follow the "Holds with cancellation requests" link on the home page. The page has code to activate the last viewed tab, but I've modified it so that if there is a location hash ('waitingreserves.pl#tab') the tab specified in the hash is selected instead of the last used tab. If there is no location hash the last active tab will be activated. I've also corrected the location hash in the link on the home page. To test, apply the patch and follow the "Holds with cancellation requests" link. The "Holds with cancellation requests" tab should be active. Click a different tab, e.g. "Holds waiting." Go the the circulation home page, then click the link for "Holds awaiting pickup." The tab you selected should be active. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Attachment #165809|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 165823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165823=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] New: REST API won't work if json-schema.org is down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 Bug ID: 36722 Summary: REST API won't work if json-schema.org is down Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au CC: tomasco...@gmail.com This is arguably the same issue as bug 23653 except that it's a different website this time. Also, Koha won't crash if json-schema.org is down, but the API will return a 404 for all endpoints. Like bug 23653, I think that we should use a local copy of the specification. At the moment, the way to do that is to download http://json-schema.org/draft-04/schema#, save it into our source tree, and then run the following: my $schema = JSON::Validator::Schema::OpenAPIv2->new; $schema->specification($saved_schema_spec); In theory, that's it. I'll look at providing a patch shortly... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #104 from David Cook --- Note that this introduces a regression/vulnerability that bug 23653 originally fixed. If json-schema.org is down, Koha's API won't work. See Comment 2 on bug 36721. I'll open a new bug to address this as well... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36721] Preload core libraries to speed up worker startup and reduce memory usage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36721 --- Comment #2 from David Cook --- While this doesn't have to do with preloading per se, I am seeing a slowdown: I'm noticing on startup that each Starman worker spending some time doing some web requests... which are probably related to JSON::Validator. IP addresses: - 104.26.3.209 - 104.26.2.209 - 172.67.71.88 These are the IPv4 addresses for json-schema.org. I notice the first web request gets redirected as well: write(21, "GET /draft-04/schema HTTP/1.1\r\nUser-Agent: Mojolicious (Perl)\r\nAccept-Encoding: gzip\r\nHost: json-schema.org\r\n\r\n", 111) = 111 read(21, "HTTP/1.1 301 Moved Permanently\r\nDate: Tue, 30 Apr 2024 02:27:33 GMT\r\nContent-Type: text/html\r\nTransfer-Encoding: chunked\r\nConnection: keep-alive\r\nCache-Control: max-age=3600\r\nExpires: Tue, 30 Apr 2024 03:27:33 GMT\r \nLocation: https://json-schema.org/draft-04/schema\r\nReport-To: {\"endpoints\":[{\"url\":\"h"..., 131072) = 870 -- Back in July 2020, there was a problem with swagger.io, which caused Koha to fail to startup. So in bug 23653 we started using a local copy of the schema. But in Bug 30194 it looks like that undid bug 23653... but that was for swagger.io. Note if json-schema.org is down (just map json-schema.org to localhost to reproduce), Koha appears to start, but the API doesn't work. You'll get 404 errors for every API endpoint. -- It looks like we can provide our own string to the $schema->specification(), so we can restore the idea behind bug 23653. That should insulate us from issues with json-schema.org and make for faster startup times. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||slider widget for multiple ||cover images on the OPAC ||search results page (when ||multiple sources enabled), ||matching the way covers ||display on the detail page. --- Comment #13 from David Nind --- Thanks Owen! This looks really nice. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36721] Preload core libraries to speed up worker startup and reduce memory usage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36721 --- Comment #1 from David Cook --- I've done some experimenting by using a "-M Koha::Preload" in /usr/sbin/koha-plack You can observe memory savings using "free -m" with the most obvious memory savings being over a large number of workers. Speed... if just preloading Plack and Mojolicious libraries, the speed difference is negligible. The biggest savings in time/memory I've noticed so far is preloading Koha::Schema which preloads all our 272 DBIx::Class schema files. -- If we want to preload other Koha files, I think we'll need to be careful to make sure we're not causing any variable scoping problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 David Nind changed: What|Removed |Added Attachment #165794|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 165822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165822=edit Bug 26933: Improve handling of multiple covers on catalog search results in the OPAC This patch implements a book cover slider widget for cover images in OPAC search results, matching the way we show covers on the detail page. To test, apply the page and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images - Coce (serving up Amazon, Google, and OpenLibrary images) - OpenLibrary - Baker & Taylor - Google - Custom cover images (the CustomCoverImages preference) Perform a variet of searches and confirm that cover images are displaying correctly, whether there be 0, 1, 2, or more covers available for each. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36721 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36721] Preload core libraries to speed up worker startup and reduce memory usage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36721 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36721] New: Preload core libraries to speed up worker startup and reduce memory usage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36721 Bug ID: 36721 Summary: Preload core libraries to speed up worker startup and reduce memory usage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If we preload core libraries using Starman's -M option, we can in theory speed up worker startup and reduce memory usage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #29 from David Nind --- I've listed the things that didn't work as expected, or that I'm not sure of (more details below under the respective headings): 1. Patron search: landing page (without any searches) doesn't display the toolbar above the browse by last name area. 2. Patron permissions page: the wrong toolbar is displayed when scrolling (normal edit patron toolbar, instead of the permissions toolbar). 3. Patron information: when you add new patrons, or edit existing patrons, the toolbar does not stick. 4. Authority search: The only place I could see where the toolbar is sticky is when adding or editing authorities. I didn't see any sticky toolbar when searching and on the search results page. Things noted that are different or not working as expected == 3. Patron search: with patch applied, the "Sticky" menu isn't displayed when you go to the patron landing page - it just displays Browse by last name: A, B, C, etc. Before the patch it included a toolbar with Select all, clear all, greyed out options for adding to list, merging, etc. Once there are results, this toolbar is displayed. 12. Patron permissions page: Patrons > Search (from filters to the left) > select any patron > More > Set permissions > scroll down the page. The sticky toolbar is the wrong one - it is the normal patron actions (Edit - Change password - Duplicate - etc.). Before the patch it was the permissions toolbar (Save - Cancel - Show all - etc.). 13. Patron information: . Add or edit a patron (memberentry): Patrons > + New patron > Patron > scroll down. Result: The toolbar DOES NOT STICK as you scroll down (for both add and edit). It did before the patch was applied. Things I'm not sure of == 7. Authority search: Authorities > click submit button in header. Result: search results displayed. NO sticker toolbar when scrolling down the page. The only place I could find the sticky working before and after the patch was when adding or editing an authority. Worked as expected == 3. Patron search: Patrons > click Search. Result: all patrons listed, toolbar sticks as you scroll down. 4. Acquisitions - add a vendor: Acquisitions > + New vendor. Result: new vendor form displayed, toolbar sticks as you scroll down. 5. Acquisitions - add a basket: . Acquisitions > Mange orders section > Search. Result: list of orders for "My Vendor" displayed. . + New > Basket > add a basket name > Save. Result: Page for the basket displayed. . Scroll down the page. Result: toolbar sticks as you scroll down. 6. System preferences: Administration > System preferences > select OPAC > scroll down. Result: toolbar sticks as you scroll down. 8. Advanced search: Search (in toolbar at top) > Advanced search > scroll down. Result: toolbar sticks as you scroll down. 9. Item search: Search (in toolbar at top) > Item search > scroll down. Result: toolbar bar sticks as you scroll down. NOTE: Before the patch the toolbar didn't stick. 10. Catalog search: select 'Search catalog' in the header, enter a search term, press the submit button/arrow, and scroll down on the results page. Result: The toolbar sticks as you scroll down. 11. Add a bibliographic record, or edit one: Cataloging > + New record, and then scroll down. Result: The toolbar sticks as you scroll down. 12. Patron information: . Patron details page (moremembers): Patrons > Search > Select a patron > Details. Result: toolbar sticks as you scroll down. (Note: the toolbar did not stick for me before the patch.) . Patron check out page: Patrons > Search > Select a patron > Check out. Result: toolbar sticks as you scroll down. (Note: the toolbar did not stick for me before the patch.) . Other sections: Add some data (if required) for each of the other sections - accounting, routing lists, circulation history, holds history, modification log (if you have some entries, such as check outs and check ins, the table header stays at the top of the page), notices, statistics, purchase suggestions (something is not quite right with this screen for adding new purchase suggestions - no entry form - but I don't think it is related to this bug; if you add a purchase suggestion via acquistions, the list of suggestions displays and the normal patron menu is sticky). Result: toolbar sticks as you scroll down. 14. Place multiple holds on a record: For any record from the normal view, click 'Place hold'. Add holds for multiple patrons. Result: Under the 'Existing holds' section, the toolbar sticks as you scroll down. 15. HTML customizations: Tools > Additional tools > HTML customizations. Add a new customization (+New
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #61 from Victor Grousset/tuxayo --- there might be an issue found in comment 30 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #31 from David Cook --- (In reply to David Cook from comment #30) > Actually yeah I think we do need the failover to swagger.json or else many > users of koha-testing-docker will have broken Koha instances... Ah wait... my bad. ktd runs yarn build so you should have a api/v1/swagger/swagger_bundle.json Then any core API changes will require a rebuild. Not the end of the world... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35826] Optimize building of holds queue based on transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #52 from David Cook --- (In reply to Marcel de Rooy from comment #50) > (In reply to Katrin Fischer from comment #48) > > (In reply to Katrin Fischer from comment #46) > > > Note: This introduces a new dependency on libalgorithm-munkres-perl. > > > > I have learned now that this is a bigger deal than I thought. > > Would be nice to have the module first. Now master crashes. Cant load > plack.psgi Agreed. Just came to complain about the same thing heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #30 from David Cook --- Actually yeah I think we do need the failover to swagger.json or else many users of koha-testing-docker will have broken Koha instances... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #29 from David Cook --- Created attachment 165821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165821=edit Bug 36546: Deploy swagger_bundle.json via make To test: 0. Apply patch 1a. perl Makefile.PL 1b. Choose "single" Installation mode 1c. Specify /opt/koha directory 2. make 2b. ls blib/API_CGI_DIR/v1/swagger/swagger_bundle.json 3. Ensure you're running as root or make koha user own /opt 4. make install 5. ls /opt/koha/api/v1/swagger/swagger_bundle.json -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from David Cook --- Failing this for now, since it's not deployable. 1. We need package.json to include yarn api:bundle in build:prod. 2. swagger_bundle.json will need to be added to the file_map in Makefile.PL as produced by build-resources.PL I think we should also include a fallback to swagger.yml if swagger_bundled.json is missing, although technically it should be installed by "make install", so I suppose it's not the end of the world... I can look at writing that missing patch... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34472] Template Toolkit reference guide needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687 --- Comment #6 from Lucas Gass --- > Also, I think the is_boolean flag should be added to the schema file. Is it not already there? 343 '+notforloan' => { is_boolean => 1 }, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687 --- Comment #5 from Lucas Gass --- Created attachment 165820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165820=edit Bug 36687: Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687 Lucas Gass changed: What|Removed |Added Attachment #165484|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687 Lucas Gass changed: What|Removed |Added Attachment #165483|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 165819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165819=edit Bug 36687: Update itemtypes.notforloan to not allow NULL values and change to tinyint(1) To test: 1. Have some itemtypes.notforloan values set to NULL. 2. APPLY PACTH, updatedatabase, restart_all 3. When you updatedatabase those values should be set to 0. 4. Try updating an itemtypes.notforloan value to NULL. You cannot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org --- Comment #2 from Jason Robb --- +1 We've been getting lots of odd blanks on the pending request modifications lately as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #34 from Jonathan Druart --- Created attachment 165818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165818=edit Bug 35138: Fix delete button for newly added facet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #33 from Jonathan Druart --- Had to rebase because of previous tidy patches. Adjusted the tests: fields are faceted when the facet_order is not null. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 --- Comment #32 from Jonathan Druart --- Created attachment 165817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165817=edit Bug 35138: Fix Koha_Elasticsearch.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Attachment #164816|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart --- Created attachment 165816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165816=edit Bug 35138: (QA followup) Tidy update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Attachment #164815|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 165815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165815=edit Bug 35138: A bit of cleaning - UI This can be moved to its own bug report, it's only a bit of cleaning trying to keep the code cleaner after than before. No behaviour changes expected. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Attachment #164814|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 165814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165814=edit Bug 35138: UI changes to add/remove a facet Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Attachment #164813|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 165813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165813=edit Bug 35138: Mark DisplayLibraryFacets as zebra only We can know add/remove homelibrary and holdinglibray from the config page, this syspref is no longer needed for ES Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Attachment #164812|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 165812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165812=edit Bug 35138: Adjust existing data We want the label from the DB displayed on the UI so we are adjusting the yaml and the DB. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36470] Generate CHECKOUT, CHECKIN and HOLD digest notices should be generated at once, not amended over time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36470 Emily Lamancusa changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #5 from Emily Lamancusa --- *** Bug 31656 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31656] Expand TT access for CHECKOUT notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31656 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Emily Lamancusa --- *** This bug has been marked as a duplicate of bug 36470 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Enable configuration of facets with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 Jonathan Druart changed: What|Removed |Added Attachment #164811|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 165811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165811=edit Bug 35138: Add the ability to manage ES facets This new feature allows to manage facets for Elasticsearch from the administration page. Prior to this the facet fields were hardcoded in the codebase. Librarians can then add/remove facet fields and modify their label. Test plan: 1. Create a new search field and set it a label different than its name. 2. Save 3. Go the bibliographic mapping tab 4. Add 1+ mapping for this search field (Searchable and facetable must be "Yes") 5. Add, reorder, remove new facets 6. Save and reindex your records 7. Search and notice the new facet list QA: There are several wrong things in this area (ES + facets code, everything, pm, pl, tt AND on this administration page). I have done my best to clean the code as much as I could and keep the code cleaner after than before. But there are still a lot to do. There are still inconsistencies on this page (like we need to save to see the changes applied to the other tables), but this is clearly out of the scope of this bug report. Another enhancement would be to move the facet list to a different DB table, that could bring more flexibility: * display or not (could be opac/staff/both/none) * define the size per field (number of facet to display) * order: move search_field.facet_order to this new table. But, again, it's a lot more work. More work is done in this area, please see related bug reports. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Clemens Tubach Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36720] New: Going back when placing multiple holds retains prior selections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36720 Bug ID: 36720 Summary: Going back when placing multiple holds retains prior selections Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: jr...@sekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the staff client, when placing multiple holds with the checkboxes on the search results page, if you go back and make new selections after clicking 'place hold', the prior selections are still kept. To replicate: - Search for something with more than 2 results - On the search results page, check two different checkboxes - Click 'Place hold' at the top of the results - Go back with the browser's back button - Uncheck the previous selections, check checkboxes for two new titles - Click 'Place hold' at the top of the results - Search for a patron - Notice 4 titles are listed, despite only having 2 checked Also, going back, then clicking 'place hold' again without changing the checkboxes will cause the titles to be listed in the table of potential holds multiple times. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #16 from Lucas Gass --- Rebased my patch and attached it back with Owen's as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Attachment #165799|0 |1 is obsolete|| --- Comment #15 from Lucas Gass --- Created attachment 165810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165810=edit Bug 36064: (follow-up) Activate correct tab This patch makes a change to the JavaScript on waitingreserves.pl so that the correct tab is activated if you follow the "Holds with cancellation requests" link on the home page. The page has code to activate the last viewed tab, but I've modified it so that if there is a location hash ('waitingreserves.pl#tab') the tab specified in the hash is selected instead of the last used tab. If there is no location hash the last active tab will be activated. I've also corrected the location hash in the link on the home page. To test, apply the patch and follow the "Holds with cancellation requests" link. The "Holds with cancellation requests" tab should be active. Click a different tab, e.g. "Holds waiting." Go the the circulation home page, then click the link for "Holds awaiting pickup." The tab you selected should be active. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Attachment #165798|0 |1 is obsolete|| --- Comment #14 from Lucas Gass --- Created attachment 165809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165809=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36126] Port default HOLD notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Emily Lamancusa changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36126] Port default HOLD notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 --- Comment #1 from Emily Lamancusa --- Created attachment 165808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165808=edit Bug 36126: Adjust default HOLD notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Hold filled: - Check SMS - Check Email - Leave Digests only unchecked 5. Leave SMS number and all email address fields blank for that patron 6. Place a hold for that patron 7. Check in an item to fill the hold 8. Open the Notices tab on that patron's account --> The patron should have a Print "hold filled" notice, since they don't have an email address or SMS number in the system 9. Add a Primary email and SMS number to the patron account 10. Place another hold for that patron 11. Check in an item to fill the hold 12. Go back to the Notices tab on that patron's account --> The patron should now have Email and SMS "hold filled" notices as well 13. Open each notice and confirm that all information is correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 Lucas Gass changed: What|Removed |Added Severity|major |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 --- Comment #1 from Lucas Gass --- Created attachment 165807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165807=edit Bug 36709: Add confirm flag to update_localuse_from_statistics.pl script To test: 1. APPLY PATCH and restart all 2. Run the update_localuse_from_statistics.pl script without a confirm flag, nothing happens. 3. Run the script and add the --confirm flag, stuff happens. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 Lucas Gass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #13 from David Nind --- sha1/fake ancestor error when trying to apply the patches: git bz apply 36064 Bug 36064 - Add Holds with cancellation requests info to intranet-main page 165798 - Bug 36064: Add holds with cancellation request info to staff interface main page 165799 - Bug 36064: (follow-up) Activate correct tab Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36064: Add holds with cancellation request info to staff interface main page error: sha1 information is lacking or useless (mainpage.pl). error: could not build fake ancestor Patch failed at 0001 Bug 36064: Add holds with cancellation request info to staff interface main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #20 from Lucas Gass --- rebased for current main, returning status to NQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #19 from Lucas Gass --- Created attachment 165806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165806=edit Bug 15461: Perl tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Lucas Gass changed: What|Removed |Added Attachment #162990|0 |1 is obsolete|| Attachment #162991|0 |1 is obsolete|| Attachment #162992|0 |1 is obsolete|| Attachment #162993|0 |1 is obsolete|| Attachment #165804|0 |1 is obsolete|| --- Comment #18 from Lucas Gass --- Created attachment 165805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165805=edit Bug 15461: Add StaffLocationOnDetail system preference To test; 1. APPLY patch, updatedatabase, restart services 2. Search for the new system preference 'StaffLocationOnDetail' 3. Read the description and make sure it makes sense. Check that the 'Table settings' link works. 4. By default it should be set to 'below the home library'. 5. Check to make sure that is where it displays. 6. Try 'below the holding library' and 'below both home and holding libraries', making sure each works properly. 7. Try 'on a sperate column', in which case you need to make sure that 'holdings_shelvinglocation' is properly checked under Administration > Table settings 8. Play with other Table settings to make sure they all work as they should. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15461] Add staff equivalent for OpacLocationOnDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 --- Comment #17 from Lucas Gass --- Created attachment 165804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165804=edit Bug 15461: Add StaffLocationOnDetail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #12 from Lucas Gass --- > I hope no one minds, I rebased this one on main so that it could move > forward without waiting for Bug 36063. The features don't really depend on > each other. I appreciate it, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32337] Add option to block holds with restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #39 from Tomás Cohen Arazi --- (In reply to Pedro Amorim from comment #24) > > Nick, please intervene if any of the above needs correcting. > My opinion is that a note along the lines of "It is recommended to use the > cron build_holds_queue.pl --unallocated-only cron if using RTHQ" would be > useful in the UI. Agreed. And we need good release notes as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 165803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165803=edit Bug 32565: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 165802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165802=edit Bug 32565: (QA follow-up) Fix tests Apply original tests patch + this follow-up. Run: prove t/db_dependent/HoldsQueue.t Notice tests fail. Apply fix patch, run the above prove command again. Notice tests pass. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 165801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165801=edit Bug 32565: Unit tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Tomás Cohen Arazi changed: What|Removed |Added Attachment #165166|0 |1 is obsolete|| Attachment #165167|0 |1 is obsolete|| Attachment #165168|0 |1 is obsolete|| Attachment #165169|0 |1 is obsolete|| --- Comment #35 from Tomás Cohen Arazi --- Created attachment 165800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165800=edit Bug 32565: Add unallocated option to holds queue Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected To test: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Confirm the second hold is added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Owen Leonard changed: What|Removed |Added Blocks|36064 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 [Bug 36064] Add Holds with cancellation requests info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Depends on|36063 | --- Comment #11 from Owen Leonard --- (In reply to David Nind from comment #6) > Just a note - this bug is dependent on bug 36063, which currently doesn't > apply (and is also currently Failed QA). I hope no one minds, I rebased this one on main so that it could move forward without waiting for Bug 36063. The features don't really depend on each other. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 [Bug 36063] Add Holds to Pull info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #10 from Owen Leonard --- Created attachment 165799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165799=edit Bug 36064: (follow-up) Activate correct tab This patch makes a change to the JavaScript on waitingreserves.pl so that the correct tab is activated if you follow the "Holds with cancellation requests" link on the home page. The page has code to activate the last viewed tab, but I've modified it so that if there is a location hash ('waitingreserves.pl#tab') the tab specified in the hash is selected instead of the last used tab. If there is no location hash the last active tab will be activated. I've also corrected the location hash in the link on the home page. To test, apply the patch and follow the "Holds with cancellation requests" link. The "Holds with cancellation requests" tab should be active. Click a different tab, e.g. "Holds waiting." Go the the circulation home page, then click the link for "Holds awaiting pickup." The tab you selected should be active. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Attachment #165796|0 |1 is obsolete|| Attachment #165797|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 165798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165798=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 --- Comment #8 from Owen Leonard --- Created attachment 165797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165797=edit Bug 36064: (follow-up) Activate correct tab This patch makes a change to the JavaScript on waitingreserves.pl so that the correct tab is activated if you follow the "Holds with cancellation requests" link on the home page. The page has code to activate the last viewed tab, but I've modified it so that if there is a location hash ('waitingreserves.pl#tab') the tab specified in the hash is selected instead of the last used tab. If there is no location hash the last active tab will be activated. I've also corrected the location hash in the link on the home page. To test, apply the patch and follow the "Holds with cancellation requests" link. The "Holds with cancellation requests" tab should be active. Click a different tab, e.g. "Holds waiting." Go the the circulation home page, then click the link for "Holds awaiting pickup." The tab you selected should be active. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Owen Leonard changed: What|Removed |Added Attachment #162002|0 |1 is obsolete|| Attachment #162105|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 165796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165796=edit Bug 36064: Add holds with cancellation request info to staff interface main page To Test: 1. APPLY PATCH, restart_all 2. Make some holds 3. Make sure there is a Default waiting hold cancellation policy. 4. Make the holds watiing by checking them in. 5. Go to the OPAC and request to cancel. 6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'. 7. Cancel the hold. 8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X' 9. Log in as a staff member with Staff access but without circulate_remaining_permissions. 10. You should not see the 'Holds with cancellation requests: X' line. Signed-off-by: David Nind Signed-off-by: Christopher Brannon Current depends: 22456 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36693] Improve floating toolbar in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36693] Improve floating toolbar in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 ByWater Sandboxes changed: What|Removed |Added Attachment #165768|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 165795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165795=edit Bug 36693: Add background color to OPAC floating element To test: 1. APPLY PATCH and regenerate OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. DO an OPAC search that has enough results to scroll. 3. There should no longer be a small gap between the pagination and the other tools. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Owen Leonard changed: What|Removed |Added Attachment #164669|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 165794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165794=edit Bug 26933: Improve handling of multiple covers on catalog search results in the OPAC This patch implements a book cover slider widget for cover images in OPAC search results, matching the way we show covers on the detail page. To test, apply the page and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images - Coce (serving up Amazon, Google, and OpenLibrary images) - OpenLibrary - Baker & Taylor - Google - Custom cover images (the CustomCoverImages preference) Perform a variet of searches and confirm that cover images are displaying correctly, whether there be 0, 1, 2, or more covers available for each. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32986 | Depends on||32986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 [Bug 32986] Add ability to generate custom slips for patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize changed: What|Removed |Added Blocks||36717 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36717 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36717 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32986 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36710] DB description of debit type is deleted when editing the type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36710 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36125] Port default HOLD_SLIP notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36125 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 --- Comment #62 from Martin Renvoize --- Just another rebase since the prettier stuff got in... would really love to see this make release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 Martin Renvoize changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36125] Port default HOLD_SLIP notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36125 ByWater Sandboxes changed: What|Removed |Added Attachment #165592|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 165793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165793=edit Bug 36125: Adjust default HOLD_SLIP to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Find a patron and make sure their account contains values for all of the following fields: First name Surname Card number Phone Address Address 2 City Zipcode Email 4. Place a hold for this patron, specifying a hold note 5. Check in an item to fill the hold and click "Confirm and print slip" 6. Confirm that all information on the hold slip is correct Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/