[Koha-bugs] [Bug 35655] Make it possible to switch off RabbitMQ without any warns in logs/about page

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35655

--- Comment #5 from Marcel de Rooy  ---
(In reply to davewood from comment #4)
Thx for your feedback. See also bug 35092.

> I just ran into problems with background jobs again (koha-common/stable,now
> 23.11.04-4 all [installed])

Could you provide some more details here? What are those problems? Are they
related to insufficient resources? Or ... ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

--- Comment #57 from Marcel de Rooy  ---
Why did we choose here for a perl module that has no Debian package?

Just glancing over cpan I am seeing for instance Data::Compare with a Debian
package libdata-compare-perl.
And note that Struct::Diff is from 2019 with bus factor 0 and Data::Compare is
from 2023 with bus factor 1.

I think that we should not just start packaging without asking for good reasons
to  go for an 'unpackaged' perl module.. (Noting that I do not see any
discussion about the choice for this module on the report.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36769] Adding new subfield to 952 in default framework causes 500 error

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36769

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Magnus Enger  ---
I think subfield codes/names/identifiers are always limited to one character? 

"Subfield codes - Two characters that distinguish the data elements within a
field which require separate manipulation. A subfield code consists of a
delimiter (ASCII 1F hex), represented in this document as a $, followed by a
data element identifier. Data element identifiers may be a lowercase alphabetic
or a numeric character."
https://www.loc.gov/marc/bibliographic/bdintro.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36681] CSRF_TOKEN header should be named CSRF-TOKEN (hyphen instead of underscore)

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36681

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
Summary|CSRK_TOKEN header should be |CSRF_TOKEN header should be
   |named CSRF-TOKEN (hyphen|named CSRF-TOKEN (hyphen
   |instead of underscore)  |instead of underscore)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36700] CSRF: Cannot save a systempreference (when nginx drops the CSRF header with an underscore)

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36700

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #25 from Julian Maurice  ---
*** Bug 36681 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36681] CSRK_TOKEN header should be named CSRF-TOKEN (hyphen instead of underscore)

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36681

Julian Maurice  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Julian Maurice  ---


*** This bug has been marked as a duplicate of bug 36700 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

--- Comment #26 from David Cook  ---
Another idea would be to use Elasticsearch specific syntax here like
"acqdate:>=-XX-XX" and "acqdate:<=-XX-XX". (See bug 28899)

I am actually tempted to try that out locally and hot fix using that...

--

Admittedly, that would set a precedent for creating a ES specific query instead
of a Zebra specific query.

But... it could be much less painful and make for a much neater change.

As Katrin has noted, there are no unit tests for the change to
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm which is going to be an
automatic "Failed QA" here anyway.

What one could do is create a Koha::* class of some kind that builds the search
for label-item-search.pl and unit test that.

Anyway, food time...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24895

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30745

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

--- Comment #25 from David Cook  ---
The original implementation of the "ccl_query" parameter is bizarre. A search
interface with 4 boxes shouldn't be that overcooked. 

I'm just reviewing the code right now, but some of these patches look weird.
Probably because the original code is weird. 

Oh well. I'm going to wear my Tester hat instead of my QA hat for this one...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #24 from David Cook  ---
We've bumped into this issue, so I will be looking at this more. 

--

Note for testing:
1. Go to /cgi-bin/koha/labels/label-edit-batch.pl?op=new
2. Click "Add item(s)"
3. In the pop-up window, click the date picker next to "Added on or before
date:" and choose today's date
4. Click "Search" button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #20 from David Cook  ---
Yeah this is a tough one. 

Sometimes I think that we shouldn't try to be too smart, and instead just be
more honest with end users.

Something like 'Tip: a question mark is a reserved character! To use it, you
must escape it like this: title:"Who is there\?"'

When we try to be too smart programmatically, we end up in nightmare
situations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546

--- Comment #51 from David Cook  ---
What are we thinking in terms of backporting this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

Danyon Sewell  changed:

   What|Removed |Added

 Attachment #166091|0   |1
is obsolete||

--- Comment #7 from Danyon Sewell  ---
Created attachment 166093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166093&action=edit
Bug 36723: Add musical presentation to Elasticsearch index mappings

Thanks for the minor changes David.

For your other two points noted:

1. I think that's a bit out of scope for this enhancement, all we're really
wanting to do is add this particular index to the advanced search feature, what
your suggesting i'd assume would require a change within the xslt.

2. You're absolutely right that's my mistake, I have updated that in this
latest patch, hopefully that should be all that is required.

also going to copy your testing plan as it's much clearer than mine was :)

Testing plan:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.
8. Use the advanced search. For the keyword indexes, 'Musical presentation' is
now listed.
9. Search for the term you added for the record in step 6.
10. Do this for both the Opac and Staff Client.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

--- Comment #6 from David Cook  ---
Seems to me like the whole of advanced search is a mess with Elastic but... I
guess I'll see...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
'ti:batman adventures' also doesn't seem to work. You have to do 'ti:"batman
adventures"' but that's also basically the same thing as 'ti,phr:"batman
adventures"'

We've started using Elasticsearch more, and it looks like we're going to
encounter some growing pains...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33092] Add ability to search within a list

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33092

--- Comment #13 from David Cook  ---
(In reply to Marie-Luce Laflamme from comment #12)
> So, adding this feature would make life easier when you're sifting through a
> massive list of items (think 80+). Being able to search by title and author
> would be a game-changer for quickly finding what you need.
> 
> Someone suggested in Bugzilla #27690 that we could just pop a search box at
> the top of the list, like how it's done on the opac-course-details.pl
> course-reserves page. Simple and effective!

So the Course reserves work differently because they're a client-side
DataTable. 

--

I'm thinking that we add a JOIN to the biblio table, and that should allow us
to search for title and author. It looks like there's already a join for items,
so it should be easy enough to search for things like barcode and
itemcallnumber.

Before starting on this, I'd want a clear idea of what we're going to do
though. 

I'm thinking a "Search list" search box under "This list contains X titles" and
above the toolbar beginning with "New list".

Then we could take the search query and search it against a set number of
database fields. 

We'd have to make sure that we pass the query in the pager buttons, but that
should be doable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add command-line utility to SFTP a file to a remote server

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

--- Comment #4 from David Cook  ---
(In reply to David Cook from comment #3)
> In theory, I'm not sure why you wouldn't just use a utility like lftp, but
> if using "koha-foreach", it could be nice to pick out things like the
> database name and admin email address I suppose.

Although then I wonder sometimes if we should use koha-foreach to provide a bit
more per-instance information to make it easier to write custom scripts that
are easier to koha-foreach...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add command-line utility to SFTP a file to a remote server

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
It looks like the email subject and body are hardcoded for OCLC. You'll want to
make that more configurable I reckon.

In theory, I'm not sure why you wouldn't just use a utility like lftp, but if
using "koha-foreach", it could be nice to pick out things like the database
name and admin email address I suppose.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27363] Restore temporary selection of Z39.50 targets throughout multiple searches

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27363

--- Comment #17 from Phil Ringnalda  ---
Created attachment 166092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166092&action=edit
Bug 27363: Restore temporary selection of Z39.50 targets throughout multiple
searches

The advanced editor currently saves which Z39.50 servers are selected in
local storage using the index in the sorted array of servers, and then misreads
them back as though they were server_ids. We want them to be server_ids, since
that's immutable and the index can change with changes in rank or server name.

We use the data-server-id property in the HTML more often as a server_id than
as the index that's currently stored there, so this patches switches it back
to be the server_id, and in the one place we would use the index, instead uses
Array.find to just get the server object instead of referencing it by index.

Test plan:
 1. Set the preference EnableAdvancedCatalogingEditor to enable
 2. Administration - Z39.50 Servers, for NATIONAL LIBRARY OF FRANCE uncheck
"Preselected"
 3. To be sure you don't have confusing saved preferences, open Firefox's
Developer Tools, in the Storage tab open Local Storage and select your URL
 4. In the row for cateditor_preferences_{your Koha user id}, if there are any
values for selected_search_targets, delete them so you have
"selected_search_targets":{}
 5. Open the advanced editor, and click "Advanced »" in the search box
 6. You should have Local catalog unchecked, LIBRARY OF CONGRESS checked
because
it is preselected, and NATIONAL LIBRARY OF FRANCE unchecked
 7. Toggle each checkbox so Local catalog and France are selected, and LoC is
unselected.
 8. In a new broser tab, open the advanced editor, and click "Advanced »"
 9. You will see Local catalog unchecked, LoC checked, and France unchecked.
That's the bug.
10. Apply patch, open the advanced editor in a new tab, click "Advanced »"
11. Toggle the checkboxes so Local catalog and France are selected, and LoC
is not selected.
12. Open the advanced editor in another new tab, click "Advanced »"
13. You should see what you just set, Local catalog and France checked, and
LoC unchecked, That's the correct behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27363] Restore temporary selection of Z39.50 targets throughout multiple searches

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27363

Phil Ringnalda  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36548] koha-zebra should fix ownership on /var/run/koha/instancename files

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548

--- Comment #4 from David Nind  ---
More information from when trying to restart the z3950 responder:

sudo koha-z3950-responder --restart kohadev
Restarting Z39.50/SRU daemon for kohadev:Stopping Z39.50/SRU daemon for
kohadev:start-stop-daemon: matching only on non-root pidfile
/var/run/koha/kohadev/z3950-responder.pid is insecure
 failed!
 failed!

If I change it back to being owned by root, it restarts as normal:

sudo koha-z3950-responder --restart kohadev
Restarting Z39.50/SRU daemon for kohadev:Stopping Z39.50/SRU daemon for
kohadev:.
Starting Z39.50/SRU daemon for kohadev:.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36548] koha-zebra should fix ownership on /var/run/koha/instancename files

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36548

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Using KTD, the patch also changes the permissions for the file
z3950-responder.pid - they are root before the patch is applied. I don't know
what effect this will have, or whether it is currently incorrect.

Happy to sign off if you consider there are no issues.

Z3950-responder information:
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server

Before the patch (using KTD), the permissions are:

 ls -la /var/run/koha/kohadev/
total 60
drwxr-xr-x 4 kohadev-koha kohadev-koha 4096 May  2 23:04 .
drwxr-xr-x 3 root root 4096 May  2 22:58 ..
drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 May  2 22:58 authorities
srw-rw-rw- 1 kohadev-koha kohadev-koha0 May  2 22:59 authoritysocket
drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 May  2 22:58 biblios
srw-rw-rw- 1 kohadev-koha kohadev-koha0 May  2 22:59 bibliosocket
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-indexer.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-indexer.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:58 kohadev-koha-sip.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker-long_tasks.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker-long_tasks.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-zebra.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59 kohadev-koha-zebra.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:58 plack.pid
srwxr-xr-x 1 kohadev-koha kohadev-koha0 May  2 22:58 plack.sock
-rw-r--r-- 1 root root4 May  2 22:59 z3950-responder.pid

After the patch, the permissions (after stopping and restarting Zebra) are:

ls -la /var/run/koha/kohadev/
total 60
drwxr-xr-x 4 kohadev-koha kohadev-koha 4096 May  2 23:05 .
drwxr-xr-x 3 root root 4096 May  2 22:58 ..
drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 May  2 22:58 authorities
srw-rw-rw- 1 kohadev-koha kohadev-koha0 May  2 23:05 authoritysocket
drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 May  2 22:58 biblios
srw-rw-rw- 1 kohadev-koha kohadev-koha0 May  2 23:05 bibliosocket
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-indexer.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-indexer.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:58 kohadev-koha-sip.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker-long_tasks.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker-long_tasks.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:59
kohadev-koha-worker.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 23:05
kohadev-koha-zebra.clientpid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 23:05 kohadev-koha-zebra.pid
-rw-r--r-- 1 kohadev-koha kohadev-koha5 May  2 22:58 plack.pid
srwxr-xr-x 1 kohadev-koha kohadev-koha0 May  2 22:58 plack.sock
-rw-r--r-- 1 kohadev-koha kohadev-koha4 May  2 22:59 z3950-responder.pid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27363] Restore temporary selection of Z39.50 targets throughout multiple searches

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27363

Phil Ringnalda  changed:

   What|Removed |Added

   Assignee|n...@bywatersolutions.com   |p...@chetcolibrary.org
 Status|In Discussion   |ASSIGNED

--- Comment #16 from Phil Ringnalda  ---
Yes, I wish I hadn't said "maintain a map from index to server_id" when
obviously the array z3950Servers is a map from its own index to the server_id
that's a property of each of its elements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435

Danyon Sewell  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from Danyon Sewell  ---
After applying the patch to one of our more active clients that gets a lot of
traffic it seems this doesn't seem to fix the issue. It did remove the oldest
DB backup but not the .tar.gz file due to the same reasons as before `tar:
var/log/koha//plack.log: file changed as we read it`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36770] Add a reportID parameter to export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36770

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36770] New: Add a reportID parameter to export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36770

Bug ID: 36770
   Summary: Add a reportID parameter to export_records.pl
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

It would be nice to be able to export reports from the export_records.pl
command-line utility using a report.

Adding a reportID parameter to the export_records.pl script would enable
libraries to have greater control over what records are exported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |danyonsew...@catalyst.net.n
   |ity.org |z

--- Comment #6 from David Nind  ---
Added assignee

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #5 from David Nind  ---
I made two minor changes to the patch:
1. Bug title: "Bug" (Change to a capital B from b).
2. For the advanced search keyword title, I changed it to sentence case to
match with all the others - Musical presentation.

I did note a couple of things, but I'm not sure whether these are in scope for
this bug or are achieved some other way:
1. The 254$a is not displayed in the details page for the record on the staff
interface and OPAC, even though it is set to visible. I assume that this
requires updating something else.
2. The "Musical presentation" index does not appear as an option in the OPAC
advanced search when 'More options' is selected. 

Testing notes using KTD:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patch and restart everything (restart_all).
3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)
4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
5. Alternative to steps 3 and 4: reset_all
6. Update the visibility for 254$a in the default framework so that it is
visible in the Editor (OPAC, Staff interface should already be selected).
7. Add a new record using the default framework and put a term in 254$a, such
as 'Full score'.
8. Use the advanced search. For the keyword indexes, 'Musical presentation' is
now listed.
9. Search for the term you added for the record in step 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Attachment #165941|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

--- Comment #4 from David Nind  ---
Created attachment 166091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166091&action=edit
Bug 36723: Add musical presentation to Elasticsearch index mappings

Have written a patch to allow Musical Presentation to be a search option within
Elasticsearch index mappings

Test plan:

1. Apply this patch

2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the
default MARC bibliographic framework
   Koha Administration > MARC Bibliographic framework > Actions (under default
framework) > MARC structure > Search 254 and actions->edit subfield > tick box
for visibility should have OPAC, Staff Interface and Editor ticked.

3. Edit a record using the default MARC bibliographic framework and put a
search term under index 254 and save.

4. Head back to the home page and go to Advanced Search

5. under the Search for dropdown select Musical presentation and in the search
field enter the search term you used in step 3.

Your results should appear

Sponsored-by: Education Services Australia SCIS
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add command-line utility to SFTP a file to a remote server

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

Alex Buckley  changed:

   What|Removed |Added

Summary|Add ability to use SFTP |Add command-line utility to
   |with export_records.pl  |SFTP a file to a remote
   ||server

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36760] Make 'Current assignee' stand out more in ticket details view

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36760

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
One thing I noted, was that if you access the details dialog box from the
catalog record (concerns tab), it doesn't display the assignee. This was with
afresh browser, with the cache cleared.

Maybe the concern title should be strong as well? 

Testing notes (using KTD):

1. Set the CatalogConcerns system preference to 'Allow'.
2. Using the staff interface, add a catalog concern for any record: Record >
New > New catalog concern. Enter a title, some details for teh description, and
click 'Submit'.
3. Access the catalog concerns area in the staff interface home page:
   . From the home page: click 'Catalog concerns pending' link at the bottom of
the page, OR
   . Go to Cataloguing > Reports > Catalog concerns.
4. Click the 'Details' action for the concern you created.
5. Assign the concern:
   . For the 'Change assignee' field select a patron
   . Click 'Update'
6. Click the details action again, and note that the 'Assignee' label in the
top right-hand side is plain text.
7. After applying the patch (flush_memcached, and restart_all), refresh the
catalog concerns listing page, and click on the details action again. The
assignee label should now be in bold

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36760] Make 'Current assignee' stand out more in ticket details view

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36760

David Nind  changed:

   What|Removed |Added

 Attachment #166073|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 166090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166090&action=edit
Bug 36760: Use 'strong' for 'Assignee' label

This patch simply add the 'strong' class to the assignee label in the
catalog concerns display ticket modal.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36760] Make 'Current assignee' stand out more in ticket details view

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36760

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add ability to use SFTP with export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

--- Comment #2 from Alex Buckley  ---
Created attachment 166089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166089&action=edit
Bug 36766: Add a command-line utility to SFTP a file to a remote server

To test you need to have a remote server you are authorised to SFTP files to.

Test plan:
1. Apply patch and restart services

2. Generate a file on your Koha server. Place it in /tmp/test.mrc

3. Manually connect to the SFTP remote host and accept the hostkey

4. Enter Koha shell

5. Run the sftp_file.pl command-line script
./sftp_file.pl --host  --user  --pass  --upload_dir  --file /tmp/test.mrc

6. Confirm the SFTP was successful

Sponsored-by: Horowhenua Libraries, Toi Ohomai Institute of Technology, Plant
and Food Research Limited, Waitaki District Council, South Taranaki District
Council New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add ability to use SFTP with export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

Alex Buckley  changed:

   What|Removed |Added

 Attachment #166085|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36755] Increase length of 'code' column in borrower_attribute_types

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755

David Nind  changed:

   What|Removed |Added

 Attachment #166086|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 166088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166088&action=edit
Bug 36755: Atomicupdate file

Test plan, k-t-d:
1) Apply patches.
2) Run the following SQL and save the output of each:
  SHOW CREATE TABLE pseudonymized_borrower_attributes;
  SHOW CREATE TABLE borrower_attribute_types_branches;
  SHOW CREATE TABLE borrower_attributes;
  SHOW CREATE TABLE borrower_attribute_types;
3) Run updatedatabase
4) Run the SQL queries again, compare the output of each with the previous
output before updatedatabase.
5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36755] Increase length of 'code' column in borrower_attribute_types

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755

David Nind  changed:

   What|Removed |Added

 Attachment #166070|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 166087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166087&action=edit
Bug 36755: Update UI input element

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36755] Increase length of 'code' column in borrower_attribute_types

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755

David Nind  changed:

   What|Removed |Added

 Attachment #166071|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 166086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166086&action=edit
Bug 36755: Atomicupdate file

Test plan, k-t-d:
1) Apply patches.
2) Run the following SQL and save the output of each:
  SHOW CREATE TABLE pseudonymized_borrower_attributes;
  SHOW CREATE TABLE borrower_attribute_types_branches;
  SHOW CREATE TABLE borrower_attributes;
  SHOW CREATE TABLE borrower_attribute_types;
3) Run updatedatabase
4) Run the SQL queries again, compare the output of each with the previous
output before updatedatabase.
5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36755] Increase length of 'code' column in borrower_attribute_types

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add ability to use SFTP with export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

--- Comment #1 from Alex Buckley  ---
Created attachment 166085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166085&action=edit
Bug 36766: WIP Command-line utility to SFTP file to remote server

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36164] Bring more consistency to our module landing pages

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164

--- Comment #4 from David Nind  ---
Totally support this idea!

From testing the PoC patch, everything looks and works the same as before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

--- Comment #5 from David Nind  ---
Thanks Nick!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750

David Nind  changed:

   What|Removed |Added

 Attachment #166083|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 166084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166084&action=edit
Bug 36750: (35138 follow-up) Use same display code for OPAC

To test:
1 - In OPAC with ES enabled do a search
2 - Note missing facet labels
3 - Apply patch
4 - They are back!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36765] TestBuilder should explode if FK broken

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36765

--- Comment #1 from Martin Renvoize  ---
Sounds sensible to me

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36769] New: Adding new subfield to 952 in default framework causes 500 error

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36769

Bug ID: 36769
   Summary: Adding new subfield to 952 in default framework causes
500 error
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: esther.melan...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

To recreate:

1. Edit the Default framework, 952 tag.
2. Try to add a subfield 12 as a custom note field for the 952.

500 error:

Duplicate IDDuplicate IDDuplicate ID

[2024/05/02 12:04:51] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI
Exception: DBD::mysql::st execute failed: Duplicate entry '952-1' for key
'PRIMARY' at /usr/share/koha/lib/Koha/Object.pm line 170

The Default framework uses the numbers 0-9, and letters a-z, with k set aside
for libraries that make their catalogs available for z39.50. I'm sure this is
an intended limitation to prevent subfields with double digits and characters.

Many libraries like to add custom fields to the 952. Some will reconfigure an
existing subfield with a new name. It is also possible to add a new field with
a capital letter, like 'A'. It may be helpful to add to the documentation on
frameworks/subfields in the Koha manual what is actually available for use.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36768] New: Add the option to show inventory number in the OPAC

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36768

Bug ID: 36768
   Summary: Add the option to show inventory number in the OPAC
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

The items' inventory number (items.stocknumber) is not in the table settings
for the OPAC. Some smaller or specialized libraries might find it useful to
have it displayed to their users.

To recreate:
1. Go to Administration > Table settings> OPAC > holdingst
--> stocknumber is not in the options

If we add it, it should be hidden by default. Libraries who need it can uncheck
the box to make it appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36767] Add a hint to the EDI account form that the SFTP/FTP port will fallback to port 22 if not defined

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767

Alex Buckley  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724

--- Comment #21 from Alex Buckley  ---
I(In reply to Katrin Fischer from comment #19)
> (In reply to Katrin Fischer from comment #17)
> > It looks like the code has fallbacks for the old ports to keep things
> > working. Should we add these as a hint to the EDI account form?
> 
> *ping*

I've logged a follow-up bug report for adding this:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767

Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724

Alex Buckley  changed:

   What|Removed |Added

 Blocks||36767


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767
[Bug 36767] Add a hint to the EDI account form that the SFTP/FTP port will
fallback to port 22 if not defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36767] Add a hint to the EDI account form that the SFTP/FTP port will fallback to port 22 if not defined

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767

Alex Buckley  changed:

   What|Removed |Added

 Depends on||35724


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724
[Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI
accounts
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36767] New: Add a hint to the EDI account form that the SFTP/FTP port will fallback to port 22 if not defined

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767

Bug ID: 36767
   Summary: Add a hint to the EDI account form that the SFTP/FTP
port will fallback to port 22 if not defined
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

In bug 35724 we added the ability for users to define a non-standard port for
SFTP/FTP via 'upload port' and 'download port' input boxes on the EDI account
form. 

In the code, we fallback to port 22 if the user has not defined the upload and
download ports. 

We should add a hint to the EDI account form that Koha will fallback to port 22
if those input fields are not set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724

--- Comment #20 from Alex Buckley  ---
(In reply to Katrin Fischer from comment #19)
> (In reply to Katrin Fischer from comment #17)
> > It looks like the code has fallbacks for the old ports to keep things
> > working. Should we add these as a hint to the EDI account form?
> 
> *ping*

Hi Katrin, 

Sorry for my delayed reply. Yes, I think that is a good idea. I will log a
follow-up bug report for adding that.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add ability to use SFTP with export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

Alex Buckley  changed:

   What|Removed |Added

Summary|Add abilities to use SFTP   |Add ability to use SFTP
   |with export_records.pl  |with export_records.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] Add abilities to use SFTP with export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36766] New: Add abilities to use SFTP with export_records.pl

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766

Bug ID: 36766
   Summary: Add abilities to use SFTP with export_records.pl
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

In New Zealand libraries need to be able to SFTP MARC files to a remote server
to keep the Te Puna union catalogue up-to-date.

It would be nice if NZ libraries could automate sending their MARC files in the
following way:

1) Use the runreport.pl cronjob to generate a list of bibliographic numbers.
2) Use export_records.pl cronjob to generate the MARC file for those numbers.
3) Use a new cronjob to SFTP the MARC file to the remote server.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

--- Comment #19 from Christopher Brannon  ---
Exciting times.  :)

Open, I like your concept.  I still think we should do away with the total
number of clubs.  It is arbitrary.  Not all clubs apply to all patrons.  It
isn't really useful in this scenario.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

--- Comment #18 from Martin Renvoize  ---
It went to assigned... That's got me excited 😊

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36765] TestBuilder should explode if FK broken

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36765

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36765] New: TestBuilder should explode if FK broken

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36765

Bug ID: 36765
   Summary: TestBuilder should explode if FK broken
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Right now, it only warns and continues. While this might mean 'there already
exists a resource with the value we need for the test', this is really hiding a
design issue with the tests.

For example

```perl
my $library = $builde->build_object(
{
class => 'Koha::Libraries,
value => { branchcode => 'ILL', pickup_location => 1 }
}
);
```

might fail because 'ILL' already exists, but if the DB entry doesn't contain
the other fixed condition (pickup_location=1) then the tests could fail
weirdly, and tracking it would be harder (i.e. you read the code, see you are
setting pickup_location=1, but it fails because it is not).

I propose we make it explode loudly instead. And fix the poorly written tests
that explode because of it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36764] Koha::Plugins::Base->store_data should return something more useful

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36764

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36764] New: Koha::Plugins::Base->store_data should return something more useful

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36764

Bug ID: 36764
   Summary: Koha::Plugins::Base->store_data should return
something more useful
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Currently, it returns undef which is not that useful for checking if everything
went well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36763] New: Changing a patron category doesn't update form accordingly

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36763

Bug ID: 36763
   Summary: Changing a patron category doesn't update form
accordingly
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Patron editor needs to re-evaluate form when the patron category is changed.

For example, let's say you have an adult category that requires both a surname
and a first name, and an institution category that requires only the surname.

You edit an existing adult category and change it into an institution. 
Realistically, it should clear the first name field, remove the field, and not
require it to save.  However, as is, none of this happens, and it is impossible
to save without putting some value in the first name field.

Changing the patron category should clear fields that hidden for the chosen
category, and hide those hidden fields, removing the required class.  And if
the category is changed to something that has more fields, those fields should
be shown, and if they are required, the required class added.

I know, in typical workflows, this is not necessarily an issue.  You generally
create a new patron with the category first.  But on occasion, as we clean up
accounts, sometimes an account changes categories, and this should be a common
check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36247] MARC21 Addition to relator terms in technical notice 2024-02-27

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36247

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36108] Update MARC21 default framework to Update 37 (December 2023)

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36108

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33134] Add some missing languages

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35929] Don't submit 'empty' changes to personal details in OPAC

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708

Angela Berrett  changed:

   What|Removed |Added

 Blocks||36286


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36286
[Bug 36286] Add ability to upload files/images in Preservation Module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36286] Add ability to upload files/images in Preservation Module

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36286

Angela Berrett  changed:

   What|Removed |Added

 Depends on||30708


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708
[Bug 30708] Creation of a new 'Preservation' module
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750

--- Comment #3 from Nick Clemens (kidclamp)  ---
Created attachment 166083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166083&action=edit
Bug 36750: (35138 follow-up) Use same display code for OPAC

To test:
1 - In OPAC with ES enabled do a search
2 - Note missing facet labels
3 - Apply patch
4 - They are back!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36750] OPAC - some facet heading labels are not displayed in search results when using Elasticsearch

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36750

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26258] Circulation tabs inconsistent with counters

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26258

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581

--- Comment #10 from Andrew Fuerste-Henry  ---
Bug 36762 is making this harder to test in that it's making it harder to
transfer an item with a pending hold. I think one should still be able to test
this by generating transfers-to-send with the stock rotation tool. I'll just
have to remember how stock rotation works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36762

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36762] New: Item not transferred correctly when there is a pending hold

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36762

Bug ID: 36762
   Summary: Item not transferred correctly when there is a pending
hold
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Koha is doing some dumb stuff when one attempts to transfer an item that could
fill a pending hold. To recreate:

1 - be logged in at Branch A
2 - have a bib with 1 holdable item at Branch A
3 - place a hold for pickup at Branch B
4 - confirm hold shows on Holds to Pull and Holds Queue
5 - go to Circulation > Transfers and attempt to send your item to Branch C
6 - Koha gives you three options. Pick the first one: "Transfer to Branch B."
This is the hold pickup branch, not the branch you selected for your transfer
7 - Koha tells you it has transferred the item to Branch C (the branch you did
select for your transfer)
8 - go to detail.pl for your title, confirm the holdings table says "there is
an item level hold" on your item
9 - click to the Holds tab for your title, confirm the hold claims to be in
transit
10 - query the branchtransfers table, confirm no transfer was created
11 - query reserves and confirm your hold has found=T, itemnumber=[your item],
and item_level_hold=0
12 - Back on the title, attempt to revert transit status, confirm the Revert
button doesn't do anything


At step 6, Koha should offer to transfer to the indicated transfer-target,
rather than the hold pickup branch. Then it should actually generate the
transfer and should not insert the itemnumber into the reserves table or update
reserves.found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28863] Cancel a pending notice

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863

--- Comment #4 from Christopher Brannon  ---
I would also like to see this, as there are times I do testing, and I don't
want the notice to go out.  But I can really see the value of cancelling it if
something is noticed after the fact.  This will eliminate a lot of confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28863] Cancel a pending notice

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon  ---
I would also like to see this, as there are times I do testing, and I don't
want the notice to go out.  But I can really see the value of cancelling it if
something is noticed after the fact.  This will eliminate a lot of confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Brendan Lawlor  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds the
  release notes||ability for report runtime
   ||parameters to allow
   ||selecting multiple options
   ||from the list of authorized
   ||values.
   ||
   ||**Usage**: `WHERE
   ||branchcode IN <>`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #99 from Nick Clemens (kidclamp)  ---
Created attachment 166082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166082&action=edit
Bug 30579: Fix rebase issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166041|0   |1
is obsolete||

--- Comment #98 from Nick Clemens (kidclamp)  ---
Created attachment 166081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166081&action=edit
Bug 30579: (follow-up) Remove unnecessary nested form elements

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166040|0   |1
is obsolete||

--- Comment #97 from Nick Clemens (kidclamp)  ---
Created attachment 166080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166080&action=edit
Bug 30579: (follow-up) fix button id

Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166039|0   |1
is obsolete||

--- Comment #96 from Nick Clemens (kidclamp)  ---
Created attachment 166079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166079&action=edit
Bug 30579: (follow-up) Add required label and warning when hold levels required

Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166038|0   |1
is obsolete||

--- Comment #95 from Nick Clemens (kidclamp)  ---
Created attachment 166078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166078&action=edit
Bug 30579: (follow-up) Use same conditions on item groups place hold button as
on other options

Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166037|0   |1
is obsolete||

--- Comment #94 from Nick Clemens (kidclamp)  ---
Created attachment 166077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166077&action=edit
Bug 30579: (follow-up) Add fieldsets and style disabled elements

This patch surrounds each section with a fieldset which allow
enabling/disabling
all the elements in one go. CSS is added to make it clear which fields are
disabled.

Button for item specific is moved form the multi-hold section

Javascript is simplified to use the new fieldsets

To test:
1 - Repeate test plan on earlier commit
2 - Additionally, search and select multiple records and place hold
3 - Confirm multi-hold placing works :-)

Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166036|0   |1
is obsolete||

--- Comment #93 from Nick Clemens (kidclamp)  ---
Created attachment 166076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166076&action=edit
Bug 30579: Remove doubled notes field

Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166035|0   |1
is obsolete||

--- Comment #92 from Nick Clemens (kidclamp)  ---
Created attachment 166075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166075&action=edit
Bug 30579: Add missing for attribute on label

Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #166034|0   |1
is obsolete||

--- Comment #91 from Nick Clemens (kidclamp)  ---
Created attachment 166074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166074&action=edit
Bug 30579: Disentangle multi-hold and single bib forms

This patch alters the structure of the hold request page to make it clear
that "Hold next available", "Hold item group", and "Hold specific item" are
mutually-exclusive options.

While there is some duplication from this, it makes the sections easier to read
and allows for more variation in the two forms

To test:
 1 - Find a bib with multiple items
 2 - Enable item groups and item group holds in system preferences
 3 - Load the records detail page
 4 - Add an item group on the item groups tab
 5 - Select two items and add to the group
 6 - Click the 'Holds' tab and search for/select a patron
 7 - Confirm the three levels of holds are clear
 8 - Confirm checking the radio next to one disables the others
 9 - Check 'Hold next available item from an item group'
10 - Do not select an item group
11 - Click 'Place hold' and confirm you are notified of need to select an item
group
 NOTE: if you are overrirding you may also have an alert that the items
cannot normally be put on hold
12 - Click 'Place hold on a specific item' - but do not select an item
13 - Click place hold and confirm there is an alert and you cannot continue
14 - Click 'Hold next available item' and place hold
15 - Hold is successfully placed
16 - Place another hold for the same patron
17 - Only the 'Hold next available item' form is enabled
18 - Confirm you cannot switch hold type
19 - Place hold
20 - Select a new patron and place an item group hold
21 - Select the same patron and place another hold - you are forced to place an
item group hold
22 - Select a new patron and place a hold on a specific item
23 - Place a second hold, confirm you can only place it on a specific item

Signed-off-by: hinemoea 
Signed-off-by: Sam Lau 
Signed-off-by: Emily Lamancusa 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34596] Items in transit should not show up in the holds queue

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34596

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30581

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34596

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Emily Lamancusa  changed:

   What|Removed |Added

 Blocks||35559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559
[Bug 35559] Can't change the pickup date of holds on the last day of expiration
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559

Emily Lamancusa  changed:

   What|Removed |Added

   Severity|enhancement |minor
 Depends on||30718

--- Comment #15 from Emily Lamancusa  
---
(In reply to Katrin Fischer from comment #13)
> Should this be a bug instead of an enh?

Good catch, thanks! It should also have a dependency on 30718.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
[Bug 30718] Use flatpickr's altInput option everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36737] Use translations in db_rev

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36737

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33448] staffaccess permission needs to have 'permissions' removed from description

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33448

Christopher Brannon  changed:

   What|Removed |Added

 Resolution|INVALID |---
 Status|CLOSED  |REOPENED

--- Comment #2 from Christopher Brannon  ---
I would like to revisit this.  Staffaccess, which lists modifying permissions
as one of it's purposes is not accurate.  If I set it, the staff member does
not have this ability (which I am glad).  I need to be able to give staff
permission to change usernames and passwords without giving them keys to the
whole system.

The modify permissions should be removed.  The permissions setting is what
really allows this, and is independent of staffaccess.  As is, these settings
are confusing.  Removing modify permissions from staffaccess seems to be the
logical choice.  If not, please provide an explanation why it needs to remain
on the description of this setting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #79 from Nick Clemens (kidclamp)  ---
Our team looked here as well.

I think the privacy concern is the hard block here - if search_limited was
implemented here (similar to Koha::ArticleRequests::search_limited) to limit
the messages to patrons who the user can view this could move ahead.

Martin's comment about non-templated notices should be addressed as well.

We agree too that we need to improve the documentation and guidelines for
datatables/searching/API interactions and will add that to the next dev meeting
agenda

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >