[Koha-bugs] [Bug 34190] Record overlay rule ignored on z39.50 import in Advanced Editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34190 --- Comment #4 from Katrin Fischer --- With all those very similar bugs I believe it just shows there is an urgent need for some clean-up! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha::
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 --- Comment #11 from Marcel de Rooy --- (In reply to Nick Clemens (kidclamp) from comment #6) > I added a patch, however, I noted a new error: > DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse > has_many results in iterator mode due to order criteria - performed an eager > cursor slurp underneath. Consider using ->all() instead at > /kohadevbox/koha/Koha/Objects.pm line 317 I have been seeing this one regularly already on 22.11. (Perhaps on 21.11 already?) Hard to find out where it is coming from. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360
Marcel de Rooy changed:
What|Removed |Added
Attachment #166456|0 |1
is obsolete||
--- Comment #12 from Marcel de Rooy ---
Created attachment 166499
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166499&action=edit
Bug 34360: Get distinct biblionumber
This fixes the problem noted in the bug:
[WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique
column 'biblionumber' on a resultset containing one-to-many joins will return
duplicate results. at /usr/share/koha/Koha/Objects.pm line 421
We are taking a list of items, assuming the scenario is that these are from a
single biblio and possibly some host_items, then searching and ordering
conditionally on whether the biblio is a serial.
Current code gets the first biblio from the list - this patch adds a 'DISTINCT'
to the results ebfore fetching the column
To test:
1 - Find a biblio in the staff interface
2 - Transfer one of the items a few times
3 - Recreate the issue on the command line:
export DBIC_TRACE=1
perl -e 'use Koha::Items; my $items =
Koha::Items->search({biblionumber=>9})->search_ordered(undef,{ prefetch =>
['issue','current_branchtransfers'] }); $items->next'
4 - Note warning:
DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique
column 'biblionumber' on a resultset containing one-to-many joins will return
duplicate results. at /kohadevbox/koha/Koha/Objects.pm line 426
5 - Apply patch
6 - Repeat 3
7 - Error is gone
Signed-off-by: baptiste
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 Marcel de Rooy changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #6 from Katrin Fischer --- Hm, I see there was a patch for 22.11 and the current patch doesn't apply on 22.11. I am restoring it for some testing with our 22.11 version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Katrin Fischer changed: What|Removed |Added Attachment #166417|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 --- Comment #16 from Jonathan Druart --- Created attachment 166500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166500&action=edit Bug 36582: Fix regressions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Marcel de Rooy changed: What|Removed |Added Attachment #161806|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 166501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166501&action=edit Bug 35907: Add ability to log all custom report runs with or without query Because of the way Koha::Logger has been used to log to different categories based on the interface and caller, it can be extremely hard to log all of a particular log statement to one place. For custom report runs, the category is plack-intranet.C4::Reports::Guided when run from the web interface, cron.C4::Reports::Guided when run from runreport.pl, and plack-intranet.C4::Auth when run from svc/report. We should add a more standardized report run log, both with and without the full query, so that administrators can log all report runs to a centralized location. If an administrator were to need the "point of entry" for reports, it is easy to include via parameters in PatternLayout. Test Plan: 1) Apply this patch 2) Modify your log4perl file, add the following: log4perl.logger.reports.execute.time = INFO, REPORTTIME log4perl.appender.REPORTTIME=Log::Log4perl::Appender::File log4perl.appender.REPORTTIME.filename=/tmp/report-time.log log4perl.appender.REPORTTIME.mode=append log4perl.appender.REPORTTIME.layout=PatternLayout log4perl.appender.REPORTTIME.layout.ConversionPattern=[%d] [%p] [%P] %m%n log4perl.appender.REPORTTIME.utf8=1 log4perl.logger.reports.execute.query = INFO, REPORTQUERY log4perl.appender.REPORTQUERY=Log::Log4perl::Appender::File log4perl.appender.REPORTQUERY.filename=/tmp/report-query.log log4perl.appender.REPORTQUERY.mode=append log4perl.appender.REPORTQUERY.layout=PatternLayout log4perl.appender.REPORTQUERY.layout.ConversionPattern=[%d] [%p] [%P] %m%n log4perl.appender.REPORTQUERY.utf8=1 3) Restart all the things! 4) Run a report somehow: CLI: ./misc/cronjobs/runreport.pl 1 API: /cgi-bin/koha/svc/report?id=1 Web: /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run this report 5) Note the report runs are logged to /tmp/report-time.log and /tmp/report-query.log Signed-off-by: Brendan Lawlor Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907 Marcel de Rooy changed: What|Removed |Added Attachment #161807|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 166502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166502&action=edit Bug 35907: Tidy execute_query Signed-off-by: Brendan Lawlor Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35907] Add ability to log all custom report runs with or without query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35907
--- Comment #15 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #0)
> Because of the way Koha::Logger has been used to log to different categories
> based on the interface and caller, it can be extremely hard to log all of a
> particular log statement to one place.
Just change your log4perl.conf configuration? And a sysadmin could always
concatenate all logs and grep on whatever he wants to find?
This works as expected but feels a bit like a workaround.
+my $prefix = $params->{prefix} // 1;
I would rather rename this one personally. What you want here is to suppress
the plack prefix, not add a custom prefix.
no_plack => 1 or something like that ?
If the log4perl config for reports.execute.query is not found, it seems that
Logger just silently ignores logging. This costed me about 15ms per call.
Probably
acceptable.
Passing QA since it is just a few lines. But hesitantly since our code doesnt
get cleaner.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added Attachment #164953|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 166503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166503&action=edit Bug 36018: Rename orders->filter_by_current Current is a bit misleading here. It means the ones that are not cancelled. We already use the filter_out_etc naming schema. So in harmony with that, we switch it to filter_out_cancelled. Test plan: Run t/db_dependent/Koha/Acquisition/Order.t Run git grep -l '::Orders' | xargs grep filter_by_current * All occurrences should be related to Recalls, not Orders. Go to acqui/basket.pl. Delete a whole basket who has some active and some cancelled lines. Signed-off-by: Marcel de Rooy Signed-off-by: Janusz Kaczmarek Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added Attachment #164954|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 166504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166504&action=edit Bug 36018: biblio->active_orders should be ->uncancelled_orders Active orders are more than just not cancelled. See filter_by_active in Koha::Acquisition::Orders. They are still in the acq process; we still need to receive items on those orders. When we cancel and want to delete a biblio, we should check for not cancelled orders (broader than active orders as in Orders.pm). Test plan: Git grep active_orders. Run t/db_dependent/Koha/Biblio.t Run t/db_dependent/Koha/Acquisition/Order.t Add two order lines in a basket referring to same biblio. Try to cancel with delete biblio. Should not be possible. Signed-off-by: Marcel de Rooy Signed-off-by: Janusz Kaczmarek Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added Attachment #164955|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 166505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166505&action=edit Bug 36018: $orders->filter_by_active should check quantityreceived An active order that has no items to receive any more is actually not very active anymore :) Test plan: Run t/db_dependent/Koha/Acquisition/Orders.t Enable OPACAcquisitionDetails. Add order on basket for new biblio. Check that opac-detail does not yet count the item as on order (since status is still new). Close basket. Check opac-detail again. Should count it now. Reopen basket. Cancel line. Check opac-detail again. Signed-off-by: Marcel de Rooy Signed-off-by: Janusz Kaczmarek Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added Attachment #164956|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 166506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166506&action=edit Bug 36018: (follow-up) Do not rely on assumed correct quantities Now filter_by_active checks quantities, we should ascertain that our test data is correct, not leaving it to random values from TestBuilder. Test plan: Run t/db_dependent/Koha/Acquisition/Order.t Signed-off-by: Marcel de Rooy Signed-off-by: Janusz Kaczmarek Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added Attachment #165153|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 166507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166507&action=edit Bug 36018: (follow-up) Disambiguate quantity One of the embeds refers to suggestions. This table also has a quantity column. Test plan: Verify that Pending Orders table does load now instead of triggering an internal server error on ambiguous column. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36018] Improve consistency in Acquisition/Order(s) regarding active/current orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize --- All working well and a clear clarification and improvement. QA scripts passing, tests passing and coverage increased. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36486] Add tests for Koha::DateTime::Format::SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36486 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy --- FAIL t/Koha/DateTime/Format/SQL.t FAIL file permissions File must have the exec flag WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 27) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36129] Check in "Hide all columns" doesn't persist on item patch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 --- Comment #5 from Emmi Takkinen --- Couldn't reproduce Davids problem with Chromium either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #20 from Marcel de Rooy --- Looking here. Seeing no test plans btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35994] New acquisition status method to see if biblio record is still in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #14 from Martin Renvoize --- We're failing a test here I'm afraid.. hopefully it's not to terrible though. Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Biblio.t KO! # Failed test 'Cancelled for only cancelled lines' # at /kohadevbox/koha/t/db_dependent/Koha/Biblio.t line 1003. # got: 'acquired' # expected: 'cancelled' # Looks like you failed 1 test of 9. # Failed test '->orders, ->uncancelled_orders and ->acq_status tests' # at /kohadevbox/koha/t/db_dependent/Koha/Biblio.t line 1006. # Looks like you failed 1 test of 37. /kohadevbox/koha/t/db_dependent/Koha/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/37 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35994] New acquisition status method to see if biblio record is still in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36486] Add tests for Koha::DateTime::Format::SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36486 --- Comment #4 from Julian Maurice --- Created attachment 166508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166508&action=edit Bug 36486: Fix file perms and tidiness -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36486] Add tests for Koha::DateTime::Format::SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36486 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #4 from Jonathan Druart --- Created attachment 166509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166509&action=edit Bug 34655: Prevent selenium/system_preferences_search.t to fail randomly Removing this JS code from document.ready. The script tag is at the end of the DOM and there is no good reasons (at least I didn't find any) to wait for the whole document to be ready before executing the JS code. It made the selenium tests selenium/system_preferences_search.t to fail randomly with: # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' # at t/db_dependent/selenium/system_preferences_search.t line 63. # got: undef # expected: 'expanded' # Looks like you failed 1 test of 6. Because we set the class in this JS code and selenium won't wait for it to finish before starting running the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35994] New acquisition status method to see if biblio record is still in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35994] New acquisition status method to see if biblio record is still in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 --- Comment #15 from Marcel de Rooy --- Created attachment 166510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166510&action=edit Bug 35994: (QA follow-up) Fix Biblio.t A follow-up changed orders->cancel a bit. This test assumed to cancel completed lines here. So we are doing it now with a direct update to have the original result. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36486] Add tests for Koha::DateTime::Format::SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36486 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36486] Add tests for Koha::DateTime::Format::SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36486 Marcel de Rooy changed: What|Removed |Added Attachment #166452|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 166511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166511&action=edit Bug 36486: Add tests for Koha::DateTime::Format::SQL Signed-off-by: Matt Blenkinsop Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36486] Add tests for Koha::DateTime::Format::SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36486 Marcel de Rooy changed: What|Removed |Added Attachment #166508|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 166512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166512&action=edit Bug 36486: Fix file perms and tidiness Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #7 from Katrin Fischer --- Hm, still doesn't apply on 22.11 - Nick, could you have a look? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35994] New acquisition status method to see if biblio record is still in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35994 --- Comment #16 from Martin Renvoize --- Thanks for the testing Emily. You've highlighted a fun little challenge with the translated notices which I'm working on now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36815] Add the option to 'Reset to default' in the notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815 --- Comment #12 from Martin Renvoize --- Thanks for the testing Emily. You've highlighted a fun little challenge with the translated notices which I'm working on now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 --- Comment #22 from Matt Blenkinsop --- Will be a rebase error on my part, having a look now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36826] New: Incorrect instantiations of CGI ::->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826
Bug ID: 36826
Summary: Incorrect instantiations of CGI ::->
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: jonathan.dru...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Koha/Uploader.pm:my $query = CGI::->new( sub { $self->_hook(@_); }, {}, 0
);
opac/opac-retrieve-file.pl:my $input = CGI::->new;
tools/upload.pl:my $input = CGI::->new;
This ::-> looks wrong
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36826] Incorrect instantiations of CGI ::->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36826 Jonathan Druart changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Marcel de Rooy changed: What|Removed |Added Attachment #164994|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 166513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166513&action=edit Bug 33737: Add bookings tab to patron details This patch adds a new 'bookings' tab to the bottom of the members details pages. When a patron has any future or current bookings against their record the tab will display the number of bookings in the tab name and on clicking the tab a bookings table will display the current and upcoming bookings. Signed-off-by: Esther Melander Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Marcel de Rooy changed: What|Removed |Added Attachment #164995|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 166514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166514&action=edit Bug 33737: Fix patron bookings table display issues Signed-off-by: Esther Melander Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Marcel de Rooy changed: What|Removed |Added Attachment #164996|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 166515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166515&action=edit Bug 33737: Link from patron bookings to biblio bookings Signed-off-by: Esther Melander Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 Marcel de Rooy changed: What|Removed |Added Attachment #164997|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy --- Created attachment 166516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166516&action=edit Bug 33737: Fix undefined variable issues This patch resolves the undefined bookings_table variable issue reported and also further fixes a subsequent undefined timeline bug that was exposed by the original fix. Signed-off-by: Esther Melander Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33737] Add bookings to patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737 --- Comment #25 from Marcel de Rooy --- QA Comment: Ignoring this one line: WARN Koha/Patron.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 293, now: 294) The feature feels still bit experimental. Without test plans I had trouble finding my way here. And came across a few warnings and errors. But the patches look good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind changed: What|Removed |Added Attachment #166509|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 166517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166517&action=edit Bug 34655: Prevent selenium/system_preferences_search.t to fail randomly Removing this JS code from document.ready. The script tag is at the end of the DOM and there is no good reasons (at least I didn't find any) to wait for the whole document to be ready before executing the JS code. It made the selenium tests selenium/system_preferences_search.t to fail randomly with: # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' # at t/db_dependent/selenium/system_preferences_search.t line 63. # got: undef # expected: 'expanded' # Looks like you failed 1 test of 6. Because we set the class in this JS code and selenium won't wait for it to finish before starting running the tests. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- Testing notes (using KTD): 1. Start up KTD with selenium: ktd --selenium up 2. Tests fail before the patch, and pass after the patch: prove t/db_dependent/selenium/system_preferences_search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36815] Add the option to 'Reset to default' in the notices editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- WARN tools/letter.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 125, now: 127) Module changes require tests. Could you please add a test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33418] Allow setting overlay_framework for connexion imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33418] Allow setting overlay_framework for connexion imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 Marcel de Rooy changed: What|Removed |Added Attachment #162471|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 166518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166518&action=edit Bug 33418: Add overlay_framework option to connexion scripts This patch adds the option to specify a framework to be used when overlaying records from webservices/connexion To test: 1 - vim /etc/koha/sites/kohadev/connexion.cnf 2 - Set content: host: port: koha:http://localhost:8081 log:/var/log/koha/kohadev/connexion.log match:ISBN user:kohauser password:kohapass overlay_action:replace nomatch_action:create_new item_action:always_add import_mode:direct framework:BKS overlay_framework: debug:1 3 - Save the sample file from this bug into your kohaclone (or copy and paste into a file your koha test site can reach) 4 - On the command line: perl misc/bin/connexion_import_daemon.pl -c /etc/koha/sites/kohadev/connexion.cnf 5 - In another terminal: cat bug_33418.test | nc -v localhost 6 - It should report success and a biblionumber 7 - In Koha: Cataloguing->Manage staged MARC record 8 - View the most recent batch with file name (webservice) 9 - Confirm it was imported, no match 10 - Click 'View' under the 'Record' column 11 - Confirm record loads correctly and 'MARC framework' detail is 'Books, Booklets, Workbooks' 12 - On the terminal repeat the command: cat bug_33418.test | nc -v localhost 13 - It should succed 14 - View the new batch, confirm the record matched this time 15 - View the record details, confirm framework is now 'default' 16 - On the first terminal hit Ctrl+C to stop the daemon 16 - Edit connexion.cnf and change: import_mode:stage framework:ACQ overlay_framework:IR 17 - Restart daemon: perl misc/bin/connexion_import_daemon.pl -c /etc/koha/sites/kohadev/connexion.cnf 18 - Delete the record created above 19 - On the second terminal repeat the command: cat bug_33418.test | nc -v localhost 20 - Confirm the batch is created, but not imported 21 - In terminal: perl misc/cronjobs/import_webservice_batch.pl --framework=ACQ --overlay_framework=BKS 22 - Confirm batch imported, and record in ACQ framework 23 - In terminal: cat bug_33418.test | nc -v localhost perl misc/cronjobs/import_webservice_batch.pl --framework=ACQ --overlay_framework=BKS 24 - Confirm batch added, record matched, record imported, and record now in Books framework 25 - Stop the deamon, edit connexion.cnf: import_mode:direct 26 - Start the daemon, and on other terminal repeat: cat bug_33418.test | nc -v localhost 27 - Confirm record in Binders framework 28 - Set record framework to Books 29 - Stop daemon, edit cnf and remove 'overlay_framework' setting 30 - Start daemon and cat the file again 31 - Confirm the record remains in Books framework Signed-off-by: Brendan Lawlor Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33418] Allow setting overlay_framework for connexion imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- Essentially only adding the overlay framework parameter. Not tested but patch looks good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Pedro Amorim changed: What|Removed |Added Attachment #162621|0 |1 is obsolete|| Attachment #162676|0 |1 is obsolete|| --- Comment #21 from Pedro Amorim --- Created attachment 166519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166519&action=edit Bug 35145: Schema file PA amended: Fix commit title Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #22 from Pedro Amorim --- Created attachment 166520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166520&action=edit Bug 35145: (follow-up) Rename number to display_order PA amended: Fix commit title Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Pedro Amorim changed: What|Removed |Added Attachment #166473|0 |1 is obsolete|| --- Comment #23 from Pedro Amorim --- Created attachment 166521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166521&action=edit Bug 35145: (follow-up) Fix atomicupdate file and display_order's data type PA amended: Added DEFAULT NULL COMMENT 'the order in which this attribute type appears in patron form' to column entry to match what's in kohastructure.sql Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #10 from Marcel de Rooy --- We do not have a script touching all authorities? That could fill the table for existing records? Another idea to accomplish that and mention in release notes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added Attachment #161213|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 166522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166522&action=edit Bug 30047: DB Updates Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added Attachment #161214|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 166523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166523&action=edit Bug 30047: DO NOT PUSH - Schema updates Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added Attachment #161215|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 166524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166524&action=edit Bug 30047: Add new heading field to auth_header table This patch adds a new heading field containing the display form of the authority record NOTE: If trying to save an auhority in the 'DEFAULT' framework, you will get an error, you should not be using DEFAULT for authorities and we should remove from the list on another bug To test: 1 - Apply patches 2 - Update database 3 - Restart all 4 - Create a new authority, save. 5 - Do this for various types 6 - View the db records: SELECT * FROM auth_header\G 7 - Note new heading field is populated correctly 8 - Edit your new authorities 9 - Confirm the heading field is updated correctly 10 - Import some authorities and confirm heading generated correctly 11 - Import auth via Z39.50 and confirm heading generated correctly Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy changed: What|Removed |Added Attachment #161216|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 166525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166525&action=edit Bug 30047: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36129] Check in "Hide all columns" doesn't persist on item patch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from David Nind --- I can't see it now either (Firefox and Chromium). 8-( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36129] Check in "Hide all columns" doesn't persist on item patch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36129] Check in "Hide all columns" doesn't persist on item patch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind changed: What|Removed |Added Attachment #162268|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 166526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166526&action=edit Bug 36129: Make check on "Hide all columns" persist on item patch modification/deletion On item patch modification/deletion tool, if one checks "Hide all columns" checkbox and then reloads the page, checkbox is no longer selected. Columns are hidden as they should. This patch adds line to batchMod.js which sets "checked" attribute and class "selected" to checkbox. To test: 1. Find items to modify/delete and modify/delete them with corresponding tool. 2. Check checkbox "Hide all columns". 3. Refresh the page. => Note that columns are still hidden, but checkbox is now unselected. 4. Apply this patch. 5. Check checkbox again and refresh page. => Checkbox should be still checked. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Matt Blenkinsop changed: What|Removed |Added Attachment #127859|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36129] Check in "Hide all columns" doesn't persist on item patch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36129 David Nind changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Matt Blenkinsop changed: What|Removed |Added Attachment #164936|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Matt Blenkinsop changed: What|Removed |Added Attachment #127859|0 |1 is obsolete|| Attachment #166359|0 |1 is obsolete|| --- Comment #23 from Matt Blenkinsop --- Created attachment 166527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166527&action=edit Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Matt Blenkinsop changed: What|Removed |Added Attachment #164936|0 |1 is obsolete|| Attachment #166360|0 |1 is obsolete|| --- Comment #24 from Matt Blenkinsop --- Created attachment 166528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166528&action=edit Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 --- Comment #25 from Matt Blenkinsop --- Rebased so that the first commit matches the original, except for changes in Items.t which are now covered in the second commit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30047] Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > We do not have a script touching all authorities? That could fill the table > for existing records? > Another idea to accomplish that and mention in release notes? Something with misc/maintenance/update_authorities.pl ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 Katrin Fischer changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36824] Fix conversion of __VERSION__ in system preferences to use main rather than master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Katrin Fischer changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36823] Reports links to database schema 404 looking for master rather than main
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36823 Katrin Fischer changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34655] system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582 Katrin Fischer changed: What|Removed |Added Keywords|Academy,| |additional_work_needed | --- Comment #17 from Katrin Fischer --- Follow-up pushed to main. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34263] Suspending holds consecutively populates previously used date falsely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34263 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36804] Serials claims 'Clear filter' doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36804 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36169] Add guarantee to patron categories with type='Staff'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36169 HKS3 Tadeusz Sośnierz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36169] Add guarantee to patron categories with type='Staff'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36169 HKS3 Tadeusz Sośnierz changed: What|Removed |Added Attachment #162480|0 |1 is obsolete|| --- Comment #6 from HKS3 Tadeusz Sośnierz --- Created attachment 166529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166529&action=edit Bug 36169: Patron categories with type='Staff' should be able to have guarantees Library staff - whose patron category has a type='Staff' should be able to have guarantees added. Test plan: 1) Create a 'Library staff' patron category with 'Category type' = 'Staff' 2) Create a patron account using the 'Library staff' patron category 3) Notice the '+ Add guarantee' button is not displayed in the members toolbar for the 'Library staff' patron you created 4) Apply patches and restart services 5) Refresh your browser window 6) Notice the '+ Add guarantee' button is now displaying for the 'Library staff' patron 7) Confirm you can successfully add a guarantee 8) Run unit test t/db_dependent/Koha/Patrons.t Sponsored-By: Waitaki District Council, New Zealand Signed-off-by: Tadeusz „tadzik” Sośnierz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36791] Koha explodes when trying to edit an authority record with an invalid authid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36791 Katrin Fischer changed: What|Removed |Added Summary|Koha explodes when trying |Koha explodes when trying |to edit an authority rec. |to edit an authority record |with an invalid authid |with an invalid authid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #166182|0 |1 is obsolete|| --- Comment #11 from Nick Clemens (kidclamp) --- Created attachment 166530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166530&action=edit Bug 36676: SIP2 drops connection on unknown patron id in fee paid message When sending a fee paid message to SIP2 with an unknown patron id it will respond with an empty response followed by dropping the connection to a client. Test plan: a) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount 0.01 Output: Trying 'fee_paid' SEND: 3720240423124447FT00USDBV0.01|AO|AA2352900100046|ACterm1| Use of uninitialized value $data in concatenation (.) or string at /usr/share/koha/bin/sip_cli_emulator.pl line 355, chunk 1. READ: b) apply patch c) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount 0.01 Output: Trying 'fee_paid' SEND: 3720240423125602FT00USDBV0.01|AO|AA2352900100046|ACterm1| READ: 38N20240423125602AO|AA2352900100046|AFInvalid patron barcode.| Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36757] Add assignee to catalog concern/ticket detail view when opened from catalog detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #17 from Katrin Fischer --- I am sorry, but with the follow-up the modal no longer opens when I click on the number of "changes". Can you please double check? I tried a reset_all, restart_all, private browser window... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #42 from Katrin Fischer --- Thank to everyone for their perseverance :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed --- Comment #43 from Katrin Fischer --- Hm, a little too early - Martin, can you double check? I am having a fail: prove -v /kohadevbox/koha/t/db_dependent/Koha/Auth/Client.t /kohadevbox/koha/t/db_dependent/Koha/Auth/Client.t .. 1..4 # Subtest: get_user() tests 1..5 C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm line 1869. C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm line 1869. ok 1 - Patron correctly retrieved ok 2 - Data mapped correctly ok 3 - No surname mapped ok 4 - Is the same domain # Looks like you planned 5 tests but ran 4. not ok 1 - get_user() tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #166462|0 |1 is obsolete|| --- Comment #44 from Tomás Cohen Arazi --- Created attachment 166531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166531&action=edit Bug 36503: Move and update unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 166532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166532&action=edit Bug 36503: (follow-up) Fix tests count Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36503] Add a plugin hook to modify patrons after authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36503 --- Comment #46 from Katrin Fischer --- Thanks for the quick work, Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36824] Fix conversion of __VERSION__ in system preferences to use main rather than master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36824] Fix conversion of __VERSION__ in system preferences to use main rather than master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36824 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
