[Koha-bugs] [Bug 26567] Allow to limit subscription search to subscriptions with routing lists

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26567

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #26 from Chris Cormack  ---
(In reply to Marcel de Rooy from comment #24)
> (In reply to Katrin Fischer from comment #16)
> > (In reply to Marcel de Rooy from comment #15)
> > > (In reply to Katrin Fischer from comment #14)
> > > > Isn't in Discussion a bit harsh for a question? ;)
> > > > 
> > > > Can you explain why the group or limit 1 is better than using a 
> > > > distinct?
> > > 
> > > Isnt Failed QA a bit hard too? lol. Had no reason to fail here.
> > > 
> > > Counter question:
> > > q| INNER JOIN (SELECT DISTINCT subscriptionid FROM 
> > > subscriptionroutinglist)
> > > srl ON srl.subscriptionid = subscription.subscriptionid|;
> > > 
> > > Doesnt this looks a bit odd? Joining a subselect. Probably we c/should
> > > compare performance on the various constructs. But I gladly get a response
> > > from the author of doing that all by myself ;)
> > 
> > You will have to deal with me I am afraid. Our sponsorship for this has run
> > out.
> 
> Still do not really like the construct, but have no formal argument.
> Running out of sponsorship as a reason for not replying does not sound good
> to me btw. The author has a moral obligation too. Welcome to open source.

This comment was unnecessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36822] When creating a new patron via C4::Auth_with_ldap inserts 0000-00-00 for invalid updated_on

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36822

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||RM_priority

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21482] Create a "landing page" for ILL

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21482

--- Comment #6 from Katrin Fischer  ---
(In reply to Magnus Enger from comment #5)
> (In reply to Pedro Amorim from comment #4)
> > One question here is do we want to invest time in creating a landing page
> > for ILL or would we prefer investing more time in creating a landing page
> > "engine" that any module can make use of in the future?
> 
> That sounds like an awesome idea!

Agreed, I don't think you will find someone saying 'no' to this suggestion.
Having configurable items would also solve the 'problem' with the discussion we
had about the acq landing page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24607] Improve sequence in which fields are displayed in XSLT output

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607

Katrin Fischer  changed:

   What|Removed |Added

Summary|XSLT output should be   |Improve sequence in which
   |listed in MARC tag order|fields are displayed in
   ||XSLT output

--- Comment #6 from Katrin Fischer  ---
Very helpful information, thx Heather!
I'll reword this a bit into "improve the sequence" as I doubt a bit that we
stick to the proper order now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33024] Lazy load the components in the routes definition

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36636] Set leader 05 to d (deleted) for records in deletedbiblio_metadata

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36636

Katrin Fischer  changed:

   What|Removed |Added

Summary|Should we set leader 05 to  |Set leader 05 to d
   |deleted for records in  |(deleted) for records in
   |deletedbiblio_metadata? |deletedbiblio_metadata

--- Comment #1 from Katrin Fischer  ---
I think that would make sense.
When using OAI-PMH these records I believe are harvested with the 'd' already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35149] Add "do nothing" option to CircAutoPrintQuickSlip system preference

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #163639|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36835] New: Add a way to get a local cover image from biblionumber

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36835

Bug ID: 36835
   Summary: Add a way to get a local cover image from biblionumber
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathsaby...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I don't think there is currently an API route for getting a local cover image
(stored by Koha) from the biblionumber of the record

It could be useful

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36725] Add Current publication frequency to Elasticsearch index mappings

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36725

--- Comment #1 from Alex Buckley  ---
Created attachment 166615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166615&action=edit
Bug 36725: Add Current publication frequency 310$a to Elasticsearch index
mappings

Test plan:
1. Start up KTD with Elasticsearch: ktd --es8 up

2. Apply this patch and restart all services (restart_all)

3. Reset the mappings: Administration > Catalog > Search engine configuration
(Elasticsearch) > Reset mappings (at the bottom of the page)

4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev

5. Alternative to steps 3 and 4: reset_all

6. Update the visibility for 310$a in the default framework so that it is
visible inte Editor (OPAC, Staff interface should already be selected).

7. Add a new record using the default framework and put a term in 310$a, such
as 'Annual'.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36035] Form is broken in addorderiso2709.pl

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36035

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
   Keywords||rel_23_05_candidate

--- Comment #9 from Aleisha Amohia  ---
This is needed in 23.05 please

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36725] Add Current publication frequency to Elasticsearch index mappings

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36725

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36660] Make Authorities 'see from' searches more specific

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36660

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36660] Make Authorities 'see from' searches more specific

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36660

--- Comment #1 from Aleisha Amohia  ---
Created attachment 166616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166616&action=edit
Bug 36660: Make Authorities 'see from' searches 'exact'

This enhancement changes the search URL for 'see from' headings to look for an
'exact' match.

When using a 'see from' heading, when Koha does a 'contains' search this is
quite general and may fetch a bunch of unexpected results.

This enhancement also changes the OPAC authority search to search on all
headings when doing a 'see from' search, so the results mirror that on the
staff interface. Also important if subheading info is stored in the $x or other
subfields, for example.

To test (assume using KTD):

1) In the staff interface, add a new topical term authority. Set the following
values:
  150$a: Quests
  550$a: Travel
2) Add a second topical term authority, this is one we DON'T want showing in
'see from' results. Set the following values:
  150$a: Cheques
  550$a: Travellers' cheques
3) Do a 'main heading ($a only)' search for 'Quests'. Your new heading should
show in the results, with 'Travel' showing as a see from searchable link.
4) Click the 'Travel' search link. Notice you get a few results, including the
'Cheques' heading which we don't want to show.
5) Follow steps 3 & 4 on the OPAC. Notice you get a few results, but your
'Quests' heading doesn't even show, which you may expect it to.

6) Apply the patch and restart services.

7) In the staff interface, go back to the Authorities homepage.
8) Repeat steps 3 & 4. Confirm you get the expected 'Quests' heading in the
results, and do not get the 'Cheques' heading.
9) Repeat steps 3 & 4 on the OPAC. Confirm you get the expected 'Quests'
heading in the results, and do not get the 'Cheques' heading.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-05-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #32 from Emmi Takkinen  ---
(In reply to Nick Clemens (kidclamp) from comment #31)
> I like this a lot - self contained and makes minimal changes, the patches
> are clean and easy to read, but I think we need to consider some things here
> before this moves ahead
> 
> Must fix:
> The JS alerts to prevent submission fire an alert per warning, so you need
> to click through several if you make a mistake - these should be combined
> into a single alert
> 
> There is no way to see the limits you have placed on your search - I think
> these need to be shown to the user, ideally they would be editable, but
> showing them would be a start
> 
> Should fix:
> While I like the idea of minimalizing data for privacy, excluding the
> borrower info on the holds feels a bit too far. Ideally this would be under
> columns configuration, and we have patron-title.inc for showing borrower
> info only to staff who should see it. The current column selection feels 
> 
> The display should be paginated, ideally it would use the holds API to load
> the holds to ensure performance, as scrolling can get really long really
> fast. It would be nice too to be able to select all in a filtered search -
> right now 'Select all' selects even those not visible in the table
> 
> Could fix:
> If implemented with the datatables API this could then work like the patron
> search, with filters present on the page. 
> 
> The batch edit implies more batch actions - cancellation, reverting, etc.
> but these can all be follow-ups I think

Thank you Nick for feedback. First two points are indeed something that should
be fixed. I'm just bit unsure how to display those search terms in search
result page. I also agree that using API does have benefits and table should be
paginated (even my test data might produce result of over 2000 holds and that
is cumbersome for users go through). I'll take a look what I can do to these.
Setting this as assigned for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/