[Koha-bugs] [Bug 37161] After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #168004|0   |1
is obsolete||

--- Comment #6 from Phil Ringnalda  ---
Created attachment 168007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168007=edit
Bug 37161: After deleting a tag in a MARC framework, redirect back to the tag
list rather than showing a 'Tag deleted' page first

Currently after you delete a tag from a MARC framework, Koha intends to show
you a page with the text "Tag deleted" and an OK button to click to go back to
where you were in the list of tags. But because that depends on the template
variable being set for the name of the op in the script, and the name of the
op is "cud-delete_confirmed" which isn't a legal TT variable name, nothing is
set to tell the template what to display, so it displays a mostly-blank page.

Far better to show, don't tell, and just redirect to the list of tags like
deleting a tag from an authority framework does.

Test plan:
1. Without the patch, Administration - MARC bibliographic frameworks -
   Binders row - Actions menu - MARC structure
2. Type 092 and press Enter in the Search for tag: input
3. 092 row - Actions menu - Delete - Yes, delete this tag
4. Stare blankly at the blank page with only a header
5. Apply patch, restart_all
6. Administration - MARC bibliographic frameworks - Kits row - Actions menu -
   MARC structure
7. Type 092 and press Enter in the Search for tag: input
8. 092 row - Actions menu - Delete - Yes, delete this tag
9. Enjoy the sight of the Kits framework showing a search for 092 that
   doesn't show one, because you just deleted it, and now you can delete
   the 096 tag next

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37165] Can't edit frequencies due to stray cud- in modify op

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165

--- Comment #1 from Phil Ringnalda  ---
Created attachment 168006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168006=edit
Bug 37165: Can't edit frequencies due to stray cud- in modify op

The op modify in subscription-frequencies.pl isn't a cud- operation, it's
a GET of the editing form, so it shouldn't have been changed to cud-modify.

Test plan:
1. Don't apply the patch yet
2. Serials - Manage frequencies - for any frequency click Edit
2. Note that the editing form is empty
3. Apply patch, restart_all
4. Repeat step 2, note that now the editing form has the existing data
5. Change anything, Display order is nice, and save to verify that
   cud-savemod still works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37165] Can't edit frequencies due to stray cud- in modify op

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165

Phil Ringnalda  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on||37165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165
[Bug 37165] Can't edit frequencies due to stray cud- in modify op
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37165] New: Can't edit frequencies due to stray cud- in modify op

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37165

Bug ID: 37165
   Summary: Can't edit frequencies due to stray cud- in modify op
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Serials
  Assignee: p...@chetcolibrary.org
  Reporter: p...@chetcolibrary.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 36192

serials/subscription-frequencies.pl has two modify ops: a POST with cud-savemod
changes the frequency, and a GET with modify loads the editing form, except
that was changed to cud-modify when it shouldn't have been.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
[Bug 36192] [OMNIBUS] CSRF Protection for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35125] AutoCreateAuthorities creates separate authorities when thesaurus differs, even with LinkerConsiderThesaurus set to Don't

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125

--- Comment #2 from Phil Ringnalda  ---
Still does, still annoying having two name authorities created for every
autobiography where the author is also a subject.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on|37162   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162
[Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in
auth_tag_structure.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162

Phil Ringnalda  changed:

   What|Removed |Added

 Blocks|36192   |

--- Comment #2 from Phil Ringnalda  ---
Wups, doesn't block bug 36192, unlike marctagstructure this has been dead code
since 2009.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
[Bug 36192] [OMNIBUS] CSRF Protection for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162

Phil Ringnalda  changed:

   What|Removed |Added

 Blocks||36192


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
[Bug 36192] [OMNIBUS] CSRF Protection for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on||37162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162
[Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in
auth_tag_structure.tt
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on|37161   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161
[Bug 37161] After deleting a tag in a MARC framework, template doesn't do the
[% IF ( delete_confirmed ) %] stuff
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on||37161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161
[Bug 37161] After deleting a tag in a MARC framework, template doesn't do the
[% IF ( delete_confirmed ) %] stuff
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37161] After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161

Phil Ringnalda  changed:

   What|Removed |Added

 Blocks|37162   |36192


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192
[Bug 36192] [OMNIBUS] CSRF Protection for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162
[Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in
auth_tag_structure.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162

--- Comment #1 from Phil Ringnalda  ---
Created attachment 168005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168005=edit
Bug 37162: Remove the [% IF ( delete_confirmed ) %] stuff in
auth_tag_structure.tt

Since auth_tag_structure.pl redirects after deleting when the op is
delete_confirmed (which is actually cud-delete_confirmed) rather than loading
the template, there's no reason to have dead code for IF ( delete_confirmed )
which is both never set, and is never called when anything like it is set.

Test plan:
1. With the patch applied, Administration - Authority types - Chronological
   Term row - Actions menu - MARC Structure
2. You've already verified that auth_tag_structure.tt isn't malformed, but for
   extra fun choose a tag, Actions menu - Delete - Yes, delete and verify that
   it was deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162

Phil Ringnalda  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37162] Remove the [% IF ( delete_confirmed ) %] stuff in auth_tag_structure.tt

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162

Phil Ringnalda  changed:

   What|Removed |Added

Summary|Use or remove the [% IF (   |Remove the [% IF (
   |delete_confirmed ) %] stuff |delete_confirmed ) %] stuff
   |in auth_tag_structure.tt|in auth_tag_structure.tt
   Assignee|oleon...@myacpl.org |p...@chetcolibrary.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37161] After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161

--- Comment #5 from Phil Ringnalda  ---
Created attachment 168004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168004=edit
Bug 37161: After deleting a tag in a MARC framework, redirect back to the tag
list rather than showing a 'Tag deleted' page first

Currently after you delete a tag from a MARC framework, Koha intends to show
you a page with the text "Tag deleted" and an OK button to click to go back to
where you were in the list of tags. But because that depends on the template
variable being set for the name of the op in the script, and the name of the
op is "cud-delete_confirmed" which isn't a legal TT variable name, nothing is
set to tell the template what to display, so it displays a mostly-blank page.

Far better to show, don't tell, and just redirect to the list of tags like
deleting a tag from an authority framework does.

Test plan:
1. Without the patch, Administration - MARC bibliographic frameworks -
   Binders row - Actions menu - MARC structure
2. Type 092 and press Enter in the Search for tag: input
3. 092 row - Actions menu - Delete - Yes, delete this tag
4. Stare blankly at the blank page with only a header
5. Apply patch, restart_all
6. Administration - MARC bibliographic frameworks - Kits row - Actions menu -
   MARC structure
7. Type 092 and press Enter in the Search for tag: input
8. 092 row - Actions menu - Delete - Yes, delete this tag
9. Enjoy the sight of the Kits framework showing a search for 092 that
   doesn't show one, because you just deleted it, and now you can delete
   the 096 tag next

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37161] After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161

Phil Ringnalda  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37161] After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161

Phil Ringnalda  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org
 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |p...@chetcolibrary.org

--- Comment #4 from Phil Ringnalda  ---
Luckily, it's also common practice to just redirect to showing the result of a
cud- op rather than depending on a template knowing what to do, which limits
the damages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37161] After deleting a tag in a MARC framework, template doesn't do the [% IF ( delete_confirmed ) %] stuff

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37161

--- Comment #3 from Phil Ringnalda  ---
Oh, I see, not magic, just common practice to do something like
https://git.koha-community.org/Koha-community/Koha/src/commit/b0b168b6f84ef00babf566097933de7a338726a7/admin/marctagstructure.pl#L79
where you add a template param of $op => 1, which worked fine when it was also
common practice to name ops in a way compatible with TT variable names, which
are alphanumeric plus underscore, which doesn't include the hyphen in cud-.

So every script with a cud- op needs to have its template checked for use of
the former op name, and the script needs to be updated to set the non-cud-
version of it if the template uses it? Fun!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37078] Damaged Status not showing in detail.pl

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078

--- Comment #3 from Phil Ringnalda  ---
Created attachment 168003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168003=edit
Bug 37078: Damaged status not showing in detail.pl

The API returns the fact that an item is damaged in 'damaged_status' but the
code that builds the holdings table is looking for 'damaged' so it doesn't
find that an item is damaged.

Test plan:
1. Administration - Authorized values - DAMAGED row, click Add
2. Give it the Authorized value 2 and the Description Awful
3. On a record with more than one item, like Empress of the blues,
   edit one item to have Damaged status: Damaged and one to have
   Damaged status: Awful
4. On the bib detail view, note that the status column shows both
   as 'Available'
5. Apply patch, refresh
6. Note that now one shows as Damaged and one as Awful (verifying that
   the value is being read from the AV, not the fallback default which
   is also 'Damaged')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37078] Damaged Status not showing in detail.pl

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078

Phil Ringnalda  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

Phil Ringnalda  changed:

   What|Removed |Added

 Blocks||37078


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078
[Bug 37078] Damaged Status not showing in detail.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37078] Damaged Status not showing in detail.pl

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37078

Phil Ringnalda  changed:

   What|Removed |Added

 Depends on||33568
  Component|Circulation |Staff interface
   Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org
   |ity.org |
 CC||jonathan.dru...@gmail.com
   Keywords||regression

--- Comment #2 from Phil Ringnalda  ---
Comment 1 would be something else, this is just from bug 33568 using the wrong
term to find damaged in the API output it uses to build the holdings table for
bib detail.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
[Bug 33568] Use the REST API to display items on the biblio detail view
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37164] New: worker-output.log file grows to incredible sizes and causing the server to crash

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37164

Bug ID: 37164
   Summary: worker-output.log file grows to incredible sizes and
causing the server to crash
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: yuriy.kots...@oa.edu.ua
QA Contact: testo...@bugs.koha-community.org

Created attachment 168002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168002=edit
scrinchot worker-output.log.2 (fragment)

The worker-output.log file grows to incredible sizes.  While checking one of
the files (5 GB), a warning entry was found and this entry was duplicated a
huge number of times over a short period of time.

The first two records are as follows:
DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI
connect('database=koha_library;host=localhost;port=3306','koha_library',...)
failed: Lost connection to MySQL server at 'reading initial communication
packet', system error: 104 at /usr/share/koha/lib/Koha/Database.pm line 91. at
/usr/share/koha/lib/Koha/Objects.pm line 312
DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI
connect('database=koha_library;host=localhost;port=3306','koha_library',...)
failed: Can't connect to local MySQL server through socket
'/var/run/mysqld/mysqld.sock' (111) at /usr/share/koha/lib/Koha/Database.pm
line 91. at /usr/share/koha/lib/Koha/Objects.pm line 312



Line number three indicates the date and time 2024/05/20 17:35:52
In general, the record looks like this:
 [2024/05/20 17:35:52] [WARN] Frame not processed - malformed JSON string,
neither tag, array, object, number, string or atom, at character offset 0
(before "You must log in usin...") at
/usr/share/koha/bin/workers/background_jobs_worker.pl line 120.
 main::catch {...}  /usr/share/koha/bin/workers/background_jobs_worker.pl (122)
This entry occurs 985 times in a row.

Recording in the next second:
[2024/05/20 17:35:53] [WARN] Frame not processed - malformed JSON string,
neither tag, array, object, number, string or atom, at character offset 0
(before "You must log in usin...") at
/usr/share/koha/bin/workers/background_jobs_worker.pl line 120.
 main::catch {...}  /usr/share/koha/bin/workers/background_jobs_worker.pl (122)
occurs 1483 times in a row.

Recording in the next second:
[2024/05/20 17:35:54] [WARN] Frame not processed - malformed JSON string,
neither tag, array, object, number, string or atom, at character offset 0
(before "You must log in usin...") at
/usr/share/koha/bin/workers/background_jobs_worker.pl line 120.
 main::catch {...}  /usr/share/koha/bin/workers/background_jobs_worker.pl (122)
occurs 6952 times

A total of 16,709,173 messages of the same type were generated from 2024/05/20
17:35:52 to 2024/05/21 10:59:08



After this series of messages, other messages have already appeared:
Cannot connect to the message broker, the jobs will be processed anyway (Failed
to connect: Error connecting to localhost:61613: Connection refused at
/usr/share/perl5/Net/Stomp.pm line 27.; giving up at
/usr/share/perl5/Net/Stomp.pm line 27.
) at /usr/share/koha/bin/workers/background_jobs_worker.pl line 92.
Cannot connect to the message broker, the jobs will be processed anyway (Failed
to connect: Error connecting to localhost:61613: Connection refused at
/usr/share/perl5/Net/Stomp.pm line 27.; giving up at
/usr/share/perl5/Net/Stomp.pm line 27.
) at /usr/share/koha/bin/workers/background_jobs_worker.pl line 92.


Today, worker-output.log was 108 GB in size and took up all free disk space,
causing the server to crash.

Perhaps someone had the same problems and was able to overcome them

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34070] background_jobs_worker.pl floods logs when not connecting

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34070

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #83 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #82)
> (In reply to David Nind from comment #81)
> > There is a query on the mailing list about how to use this new feature:
> > https://lists.katipo.co.nz/pipermail/koha/2024-June/060730.html
> > 
> > I've had a crack at responding, but if I've not got it right could someone
> > involved provide some more information?
> > 
> > Thanks.
> 
> I'm not seeing the email on my inbox!

I've received both of them - maybe a problem with spam?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35092] [OMNIBUS] Remaining background job/worker issues

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #82 from Tomás Cohen Arazi  ---
(In reply to David Nind from comment #81)
> There is a query on the mailing list about how to use this new feature:
> https://lists.katipo.co.nz/pipermail/koha/2024-June/060730.html
> 
> I've had a crack at responding, but if I've not got it right could someone
> involved provide some more information?
> 
> Thanks.

I'm not seeing the email on my inbox!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29846] Missing documentation system preferences for Overdrive

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29846

Emmanuel Bétemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 37160] spinelabel-print.pl print pop-up window should be configurable

2024-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37160

--- Comment #1 from Katrin Fischer  ---
What do you mean by configurable here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/